[PATCH v7 07/10] drm/i915: Only use one link bw config for MST topologies

2018-04-11 Thread Lyude Paul
to change when the entire topology has been disconnected. V4: - Track link rate/lane count in the atomic topology state instead of in intel_dp. V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp_mst.c | 79

[PATCH v7 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state()

2018-04-11 Thread Lyude Paul
in drm_atomic.c/drm_atomic_helper.c. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/dr

[PATCH v7 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent

2018-04-11 Thread Lyude Paul
will never have compute_config() ran on them, move vcpi freeing out of the atomic check and into compute_config(). Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> V7: - Fix CHECKPATCH errors Si

[PATCH v7 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state()

2018-04-11 Thread Lyude Paul
in drm_atomic.c/drm_atomic_helper.c. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 13 +++-- include/drm/drm_dp_mst_helper.h | 6 -- 2 files changed, 11 insertions(+), 8

[PATCH v7 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent

2018-04-11 Thread Lyude Paul
will never have compute_config() ran on them, move vcpi freeing out of the atomic check and into compute_config(). Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul --- drivers/gpu/drm/i915/intel_dp_mst.c | 84

[PATCH v7 06/10] drm/dp_mst: Add reset_state callback to topology mgr

2018-04-11 Thread Lyude Paul
in i915 from the topology's atomic state. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/dr

[PATCH v7 10/10] drm/i915: Implement proper fallback training for MST

2018-04-11 Thread Lyude Paul
retraining work into hotplug_work - Grab the correct power wells when retraining. - Loop through MST encoders in intel_dp_get_crtc_mask(), quicker/easier than connectors V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com&g

[PATCH v7 06/10] drm/dp_mst: Add reset_state callback to topology mgr

2018-04-11 Thread Lyude Paul
in i915 from the topology's atomic state. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 10 ++ include/drm/drm_dp_mst_helper.h | 3 ++- 2 files changed, 12 insertions

[PATCH v7 10/10] drm/i915: Implement proper fallback training for MST

2018-04-11 Thread Lyude Paul
retraining work into hotplug_work - Grab the correct power wells when retraining. - Loop through MST encoders in intel_dp_get_crtc_mask(), quicker/easier than connectors V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915

[PATCH v7 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable

2018-04-11 Thread Lyude Paul
. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |

[PATCH v7 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable

2018-04-11 Thread Lyude Paul
. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 46 --- .../amd/display/amdgpu_dm

[PATCH v7 09/10] drm/dp_mst: Add MST fallback retraining helpers

2018-04-11 Thread Lyude Paul
docs on the retraining procedure. V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 440 +

[PATCH v7 09/10] drm/dp_mst: Add MST fallback retraining helpers

2018-04-11 Thread Lyude Paul
docs on the retraining procedure. V7: - Fix CHECKPATCH errors Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/drm_dp_mst_topology.c | 440 +- include/drm/drm_dp_mst_helper.h | 20 ++ 2 files changed, 455 insertions(+), 5

[PATCH v7 04/10] drm/dp_mst: Remove all evil duplicate state pointers

2018-04-11 Thread Lyude Paul
>state. This confused me for over 4 hours until I realized there was no magic behind these pointers. So, let's save everyone else from the trouble. Signed-off-by: Lyude Paul <ly...@redhat.com>. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.c

[PATCH v7 04/10] drm/dp_mst: Remove all evil duplicate state pointers

2018-04-11 Thread Lyude Paul
>state. This confused me for over 4 hours until I realized there was no magic behind these pointers. So, let's save everyone else from the trouble. Signed-off-by: Lyude Paul . Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- include/drm/drm_dp_mst_helper.h | 6 -- 1 file c

[PATCH v6 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state()

2018-04-11 Thread Lyude Paul
in drm_atomic.c/drm_atomic_helper.c. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 13 +++-- include/drm/drm_dp_mst_helper.h | 5 +++-

[PATCH v6 04/10] drm/dp_mst: Remove all evil duplicate state pointers

2018-04-11 Thread Lyude Paul
>state. This confused me for over 4 hours until I realized there was no magic behind these pointers. So, let's save everyone else from the trouble. Signed-off-by: Lyude Paul <ly...@redhat.com>. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.c

[PATCH v6 02/10] drm/i915: Move DP modeset retry work into intel_dp

2018-04-11 Thread Lyude Paul
dealing with an MST device, along with being able to easily trace the intel_dp struct back to it's respective connector (if there is any). So, move the modeset_retry_work function out of the intel_connector struct and into intel_dp. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by:

[PATCH v6 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state()

2018-04-11 Thread Lyude Paul
in drm_atomic.c/drm_atomic_helper.c. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/drm_dp_mst_topology.c | 13 +++-- include/drm/drm_dp_mst_helper.h | 5 +++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v6 04/10] drm/dp_mst: Remove all evil duplicate state pointers

2018-04-11 Thread Lyude Paul
>state. This confused me for over 4 hours until I realized there was no magic behind these pointers. So, let's save everyone else from the trouble. Signed-off-by: Lyude Paul . Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- include/drm/drm_dp_mst_helper.h | 6 -- 1 file c

[PATCH v6 02/10] drm/i915: Move DP modeset retry work into intel_dp

2018-04-11 Thread Lyude Paul
dealing with an MST device, along with being able to easily trace the intel_dp struct back to it's respective connector (if there is any). So, move the modeset_retry_work function out of the intel_connector struct and into intel_dp. Signed-off-by: Lyude Paul Reviewed-by: Manasi Navare Cc: Manasi

[PATCH v6 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent

2018-04-11 Thread Lyude Paul
will never have compute_config() ran on them, move vcpi freeing out of the atomic check and into compute_config(). Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/i915/i

[PATCH v6 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent

2018-04-11 Thread Lyude Paul
will never have compute_config() ran on them, move vcpi freeing out of the atomic check and into compute_config(). Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- drivers/gpu/drm/i915/intel_dp_mst.c | 78 +++-- 1 file changed, 57 insertions(+), 21

[PATCH v6 07/10] drm/i915: Only use one link bw config for MST topologies

2018-04-11 Thread Lyude Paul
to change when the entire topology has been disconnected. V4: - Track link rate/lane count in the atomic topology state instead of in intel_dp. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@

[PATCH v6 07/10] drm/i915: Only use one link bw config for MST topologies

2018-04-11 Thread Lyude Paul
to change when the entire topology has been disconnected. V4: - Track link rate/lane count in the atomic topology state instead of in intel_dp. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp_mst.c | 77

[PATCH v6 10/10] drm/i915: Implement proper fallback training for MST

2018-04-11 Thread Lyude Paul
retraining work into hotplug_work - Grab the correct power wells when retraining. - Loop through MST encoders in intel_dp_get_crtc_mask(), quicker/easier than connectors Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä

[PATCH v6 10/10] drm/i915: Implement proper fallback training for MST

2018-04-11 Thread Lyude Paul
retraining work into hotplug_work - Grab the correct power wells when retraining. - Loop through MST encoders in intel_dp_get_crtc_mask(), quicker/easier than connectors Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c | 10

[PATCH v6 09/10] drm/dp_mst: Add MST fallback retraining helpers

2018-04-11 Thread Lyude Paul
docs on the retraining procedure. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 438 +- include/drm/d

[PATCH v6 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable

2018-04-11 Thread Lyude Paul
. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 35 +++- .../amd

[PATCH v6 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable

2018-04-11 Thread Lyude Paul
. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 35 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.h| 4 +- drivers/gpu/drm/drm_dp_mst_topology.c

[PATCH v6 09/10] drm/dp_mst: Add MST fallback retraining helpers

2018-04-11 Thread Lyude Paul
docs on the retraining procedure. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/drm_dp_mst_topology.c | 438 +- include/drm/drm_dp_mst_helper.h | 20 ++ 2 files changed, 453 insertions(+), 5 deletions(-) diff --git

[PATCH v6 06/10] drm/dp_mst: Add reset_state callback to topology mgr

2018-04-11 Thread Lyude Paul
in i915 from the topology's atomic state. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 11 +++ include/drm/drm_dp_mst_helper.h

[PATCH v6 01/10] drm/atomic: Print debug message on atomic check failure

2018-04-11 Thread Lyude Paul
Does what it says on the label, it's a little confusing debugging atomic check failures otherwise. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/drm_atomic.c

[PATCH v6 01/10] drm/atomic: Print debug message on atomic check failure

2018-04-11 Thread Lyude Paul
Does what it says on the label, it's a little confusing debugging atomic check failures otherwise. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_atomic.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v6 06/10] drm/dp_mst: Add reset_state callback to topology mgr

2018-04-11 Thread Lyude Paul
in i915 from the topology's atomic state. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 11 +++ include/drm/drm_dp_mst_helper.h | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v6 00/10] drm/i915: Implement proper fallback training for MST

2018-04-11 Thread Lyude Paul
Latest version of PW series 39642, hopefully this should also actually come up on intel-gfx and go through CI. No changes other than rebasing to the current drm-intel-next-queued Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work

[PATCH v6 00/10] drm/i915: Implement proper fallback training for MST

2018-04-11 Thread Lyude Paul
Latest version of PW series 39642, hopefully this should also actually come up on intel-gfx and go through CI. No changes other than rebasing to the current drm-intel-next-queued Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work

[PATCH v5] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-06 Thread Lyude Paul
krn Changes since v2: - Only send DPMS off when we're disabling the last sink, and only send DPMS on when we're enabling the first sink - dhnkrn Changes since v3: - Check against is_mst, not intel_dp->is_mst - dhnkrn/vsyrjala Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by

[PATCH v5] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-06 Thread Lyude Paul
krn Changes since v2: - Only send DPMS off when we're disabling the last sink, and only send DPMS on when we're enabling the first sink - dhnkrn Changes since v3: - Check against is_mst, not intel_dp->is_mst - dhnkrn/vsyrjala Signed-off-by: Lyude Paul Reviewed-by: Dhinakaran Pandiyan Re

Re: [PATCH v4] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-06 Thread Lyude Paul
On Fri, 2018-04-06 at 12:48 -0700, Laura Abbott wrote: > On 04/06/2018 11:52 AM, Lyude Paul wrote: > > When doing a modeset where the sink is transitioning from D3 to D0 , it > > would sometimes be possible for the initial power_up_phy() to start > > timing out. This w

Re: [PATCH v4] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-06 Thread Lyude Paul
On Fri, 2018-04-06 at 12:48 -0700, Laura Abbott wrote: > On 04/06/2018 11:52 AM, Lyude Paul wrote: > > When doing a modeset where the sink is transitioning from D3 to D0 , it > > would sometimes be possible for the initial power_up_phy() to start > > timing out. This w

[PATCH v4] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-06 Thread Lyude Paul
krn Changes since v2: - Only send DPMS off when we're disabling the last sink, and only send DPMS on when we're enabling the first sink - dhnkrn Changes since v3: - Check against is_mst, not intel_dp->is_mst - dhnkrn/vsyrjala Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinaka

[PATCH v4] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-06 Thread Lyude Paul
krn Changes since v2: - Only send DPMS off when we're disabling the last sink, and only send DPMS on when we're enabling the first sink - dhnkrn Changes since v3: - Check against is_mst, not intel_dp->is_mst - dhnkrn/vsyrjala Signed-off-by: Lyude Paul Cc: Dhinakaran Pandiyan Cc: Ville Syrjä

[PATCH v3] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-05 Thread Lyude Paul
krn Changes since v2: - Only send DPMS off when we're disabling the last sink, and only send DPMS on when we're enabling the first sink - dhnkrn Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@l

[PATCH v3] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-05 Thread Lyude Paul
krn Changes since v2: - Only send DPMS off when we're disabling the last sink, and only send DPMS on when we're enabling the first sink - dhnkrn Signed-off-by: Lyude Paul Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: Laura Abbott Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm

Re: [PATCH v2] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-05 Thread Lyude Paul
Actually - ignore this patch, I'm going to do a v3 because i just noticed there is something very silly and broken I just introduced into the disable codepath On Thu, 2018-04-05 at 16:36 -0400, Lyude Paul wrote: > When doing a modeset where the sink is transitioning from D3 to D0 , it >

Re: [PATCH v2] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-05 Thread Lyude Paul
Actually - ignore this patch, I'm going to do a v3 because i just noticed there is something very silly and broken I just introduced into the disable codepath On Thu, 2018-04-05 at 16:36 -0400, Lyude Paul wrote: > When doing a modeset where the sink is transitioning from D3 to D0 , it >

[PATCH v2] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-05 Thread Lyude Paul
krn Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Laura Abbott <labb...@redhat.com> Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to

[PATCH v2] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-05 Thread Lyude Paul
krn Signed-off-by: Lyude Paul Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: Laura Abbott Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.") --- This email should hopefully actually be picked up by patchwork this time, hooray!

[PATCH] [RESEND] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com&g

[PATCH] [RESEND] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: Laura Abbott Cc: sta...@vger.kernel.org

[PATCH] [RESEND] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com&g

[PATCH] [RESEND] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: Laura Abbott Cc: sta...@vger.kernel.org

[PATCH] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com&g

[PATCH] drm/i915/dp: Send DPCD ON for MST before phy_up

2018-04-04 Thread Lyude Paul
on the hub, not the phy_up sideband message. This means that the real fix we need is to use the DPMS on before sending a phy_up to ensure that the hub is ready to accept sideband messages. Signed-off-by: Lyude Paul Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: Laura Abbott Cc: sta...@vger.kernel.org

[PATCH 1/1] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
own. Changes since v2: - Fix patch name, no functional changes Changes since v3: - acks, t-b's Signed-off-by: Lyude Paul <ly...@redhat.com> Acked-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Tested-by: Laura Abbott <labb...@redhat.com> Cc: Ville Syrjälä <ville.syr

[PATCH 1/1] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
own. Changes since v2: - Fix patch name, no functional changes Changes since v3: - acks, t-b's Signed-off-by: Lyude Paul Acked-by: Dhinakaran Pandiyan Tested-by: Laura Abbott Cc: Ville Syrjälä Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable

[PATCH 0/1] Keep AUX on while disabling DPMS for MST

2018-04-04 Thread Lyude Paul
Resend that was required anyway since I missed some t-b's and some acks. Trying to figure out what patchwork is doing that's making this patch not get noticed. Maybe it's the lack of cover letters on the previous versions of this Lyude Paul (1): drm/i915: Keep AUX block running when

[PATCH 0/1] Keep AUX on while disabling DPMS for MST

2018-04-04 Thread Lyude Paul
Resend that was required anyway since I missed some t-b's and some acks. Trying to figure out what patchwork is doing that's making this patch not get noticed. Maybe it's the lack of cover letters on the previous versions of this Lyude Paul (1): drm/i915: Keep AUX block running when

[PATCH v2][RESEND] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
own. Changes since v2: - Fix patch name, no functional changes Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Laura Abbott <labb...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: sta...@vger.kern

[PATCH v2][RESEND] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
own. Changes since v2: - Fix patch name, no functional changes Signed-off-by: Lyude Paul Cc: Laura Abbott Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.") --- drivers/gpu/drm/i915/i

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 22:35 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 03:00:12PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > > > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > > > On Wed, 20

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 22:35 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 03:00:12PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > > > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > > > On Wed, 20

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 22:31 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:59:09PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > > > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > > > On Wed, 20

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 22:31 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:59:09PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > > > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > > > On Wed, 20

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabl

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabl

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabl

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabl

Re: [Intel-gfx] [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 11:44 -0700, Manasi Navare wrote: > On Wed, Apr 04, 2018 at 06:34:29PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > While enabling/disabling DPMS before link training with MST hubs is > > > per

Re: [Intel-gfx] [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 11:44 -0700, Manasi Navare wrote: > On Wed, Apr 04, 2018 at 06:34:29PM +0300, Ville Syrjälä wrote: > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > While enabling/disabling DPMS before link training with MST hubs is > > > per

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > While enabling/disabling DPMS before link training with MST hubs is > > perfectly valid; unfortunately disabling DPMS results in some devices > > disabli

Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-04 Thread Lyude Paul
On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > While enabling/disabling DPMS before link training with MST hubs is > > perfectly valid; unfortunately disabling DPMS results in some devices > > disabli

[PATCH v5 02/10] drm/i915: Move DP modeset retry work into intel_dp

2018-04-02 Thread Lyude Paul
dealing with an MST device, along with being able to easily trace the intel_dp struct back to it's respective connector (if there is any). So, move the modeset_retry_work function out of the intel_connector struct and into intel_dp. Signed-off-by: Lyude Paul <ly...@redhat.com> Reviewed-by:

[PATCH v5 02/10] drm/i915: Move DP modeset retry work into intel_dp

2018-04-02 Thread Lyude Paul
dealing with an MST device, along with being able to easily trace the intel_dp struct back to it's respective connector (if there is any). So, move the modeset_retry_work function out of the intel_connector struct and into intel_dp. Signed-off-by: Lyude Paul Reviewed-by: Manasi Navare Cc: Manasi

[PATCH v5 00/10] Implement proper MST fallback retraining in i915

2018-04-02 Thread Lyude Paul
Latest version of https://patchwork.freedesktop.org/series/39642/ , hopefully patchwork understands this and doesn't break anything! Lots of changes. Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix

[PATCH v5 00/10] Implement proper MST fallback retraining in i915

2018-04-02 Thread Lyude Paul
Latest version of https://patchwork.freedesktop.org/series/39642/ , hopefully patchwork understands this and doesn't break anything! Lots of changes. Lyude Paul (10): drm/atomic: Print debug message on atomic check failure drm/i915: Move DP modeset retry work into intel_dp drm/dp_mst: Fix

[PATCH v5 01/10] drm/atomic: Print debug message on atomic check failure

2018-04-02 Thread Lyude Paul
Does what it says on the label, it's a little confusing debugging atomic check failures otherwise. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/drm_atomic.c

[PATCH v5 01/10] drm/atomic: Print debug message on atomic check failure

2018-04-02 Thread Lyude Paul
Does what it says on the label, it's a little confusing debugging atomic check failures otherwise. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_atomic.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v5 06/10] drm/dp_mst: Add reset_state callback to topology mgr

2018-04-02 Thread Lyude Paul
in i915 from the topology's atomic state. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 11 +++ include/drm/drm_dp_mst_helper.h

[PATCH v5 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state()

2018-04-02 Thread Lyude Paul
in drm_atomic.c/drm_atomic_helper.c. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 13 +++-- include/drm/drm_dp_mst_helper.h | 5 +++-

[PATCH v5 03/10] drm/dp_mst: Fix naming on drm_atomic_get_mst_topology_state()

2018-04-02 Thread Lyude Paul
in drm_atomic.c/drm_atomic_helper.c. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/drm_dp_mst_topology.c | 13 +++-- include/drm/drm_dp_mst_helper.h | 5 +++-- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v5 06/10] drm/dp_mst: Add reset_state callback to topology mgr

2018-04-02 Thread Lyude Paul
in i915 from the topology's atomic state. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- drivers/gpu/drm/drm_dp_mst_topology.c | 11 +++ include/drm/drm_dp_mst_helper.h | 3 ++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm

[PATCH v5 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent

2018-04-02 Thread Lyude Paul
will never have compute_config() ran on them, move vcpi freeing out of the atomic check and into compute_config(). Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lyude Paul <ly...@redhat.com> --- drivers/gpu/drm/i915/i

[PATCH v5 08/10] drm/i915: Make intel_dp_mst_atomic_check() idempotent

2018-04-02 Thread Lyude Paul
will never have compute_config() ran on them, move vcpi freeing out of the atomic check and into compute_config(). Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- drivers/gpu/drm/i915/intel_dp_mst.c | 78 +++-- 1 file changed, 57 insertions(+), 21

[PATCH v5 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable

2018-04-02 Thread Lyude Paul
. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 35 +++- .../amd

[PATCH v5 05/10] drm/dp_mst: Make drm_dp_mst_topology_state subclassable

2018-04-02 Thread Lyude Paul
. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 14 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.c| 35 +++- .../amd/display/amdgpu_dm/amdgpu_dm_mst_types.h| 4 +- drivers/gpu/drm/drm_dp_mst_topology.c

[PATCH v5 10/10] drm/i915: Implement proper fallback training for MST

2018-04-02 Thread Lyude Paul
retraining work into hotplug_work - Grab the correct power wells when retraining. - Loop through MST encoders in intel_dp_get_crtc_mask(), quicker/easier than connectors Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä

[PATCH v5 10/10] drm/i915: Implement proper fallback training for MST

2018-04-02 Thread Lyude Paul
retraining work into hotplug_work - Grab the correct power wells when retraining. - Loop through MST encoders in intel_dp_get_crtc_mask(), quicker/easier than connectors Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c | 10

[PATCH v5 09/10] drm/dp_mst: Add MST fallback retraining helpers

2018-04-02 Thread Lyude Paul
docs on the retraining procedure. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> --- drivers/gpu/drm/drm_dp_mst_topology.c | 438 +- include/drm/d

[PATCH v5 09/10] drm/dp_mst: Add MST fallback retraining helpers

2018-04-02 Thread Lyude Paul
docs on the retraining procedure. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/drm_dp_mst_topology.c | 438 +- include/drm/drm_dp_mst_helper.h | 20 ++ 2 files changed, 453 insertions(+), 5 deletions(-) diff --git

[PATCH v5 04/10] drm/dp_mst: Remove all evil duplicate state pointers

2018-04-02 Thread Lyude Paul
>state. This confused me for over 4 hours until I realized there was no magic behind these pointers. So, let's save everyone else from the trouble. Signed-off-by: Lyude Paul <ly...@redhat.com>. Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.c

[PATCH v5 04/10] drm/dp_mst: Remove all evil duplicate state pointers

2018-04-02 Thread Lyude Paul
>state. This confused me for over 4 hours until I realized there was no magic behind these pointers. So, let's save everyone else from the trouble. Signed-off-by: Lyude Paul . Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Lyude Paul --- include/drm/drm_dp_mst_helper.h | 6 -- 1 file c

[PATCH v5 07/10] drm/i915: Only use one link bw config for MST topologies

2018-04-02 Thread Lyude Paul
to change when the entire topology has been disconnected. V4: - Track link rate/lane count in the atomic topology state instead of in intel_dp. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjälä <ville.syrj...@

[PATCH v5 07/10] drm/i915: Only use one link bw config for MST topologies

2018-04-02 Thread Lyude Paul
to change when the entire topology has been disconnected. V4: - Track link rate/lane count in the atomic topology state instead of in intel_dp. Signed-off-by: Lyude Paul Cc: Manasi Navare Cc: Ville Syrjälä --- drivers/gpu/drm/i915/intel_dp_mst.c | 77

[PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-02 Thread Lyude Paul
own. Changes since v2: - Fix patch name, no functional changes Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Laura Abbott <labb...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: sta...@vger.kern

[PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST

2018-04-02 Thread Lyude Paul
own. Changes since v2: - Fix patch name, no functional changes Signed-off-by: Lyude Paul Cc: Laura Abbott Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.") --- drivers/gpu/drm/i915/i

[PATCH] i915/dp_mst: Keep AUX block running when disabling DPMS

2018-04-02 Thread Lyude Paul
own. Signed-off-by: Lyude Paul <ly...@redhat.com> Cc: Laura Abbott <labb...@redhat.com> Cc: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to

[PATCH] i915/dp_mst: Keep AUX block running when disabling DPMS

2018-04-02 Thread Lyude Paul
own. Signed-off-by: Lyude Paul Cc: Laura Abbott Cc: Dhinakaran Pandiyan Cc: Ville Syrjälä Cc: sta...@vger.kernel.org Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable MST hub.") --- drivers/gpu/drm/i915/intel_dp.c | 6 -- 1 file changed, 4 insertions(+), 2 delet

Re: [PATCH v3 1/5] drm/i915: Move DP modeset retry work into intel_dp

2018-03-13 Thread Lyude Paul
On Mon, 2018-03-12 at 23:01 +0200, Ville Syrjälä wrote: > On Fri, Mar 09, 2018 at 04:32:27PM -0500, Lyude Paul wrote: > > While having the modeset_retry_work in intel_connector makes sense with > > SST, this paradigm doesn't make a whole ton of sense when it comes to > > MST

<    2   3   4   5   6   7   8   9   10   >