xa/0x10
[<923e>] do_one_initcall+0xaa/0x130
[<90027ae2>] parse_args+0x19e/0x27c
[<9418>] repair_env_string+0x0/0x58
[<9374>] kernel_init_freeable+0x88/0x12c
[<9382>] kernel_init_freeable+0x96/0x12c
[<9418>] repair_env_string+0x0/0x
_spi_is_v2(as) &&
> + !of_get_property(pdev->dev.of_node, "cs-gpios", NULL)) {
> + as->use_cs_gpios = false;
> + master->num_chipselect = 4;
> + }
This part breaks the AVR32 boards and probably anything else that
doesn't use devicetre
Andy Shevchenko writes:
> On Mon, 2015-12-21 at 19:27 +0000, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>> > I can share my working branch with a set of patches regarding to
>> > dw_dmac. We may do our work based on that code and after I'll
>> >
atest), PPC 460EX (Onboard
>> > SATA)
>>
>> I can test on AVR32. That is as far as I know the only system I have
>> with this DMA engine.
>
> If you have Intel Haswell, BayTrail, Braswell, CherryTrail, Broadwell,
> you have it as well as long you have LPSS blo
Andy Shevchenko writes:
> On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote:
>> On 12/21/2015 2:27 PM, Måns Rullgård wrote:
>> > The hard drive is recognized .
>> > > These system gets unresponsive with USB devices like the mouse
>> > > and
&g
Andy Shevchenko writes:
> On Mon, 2015-12-21 at 18:16 +0000, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>> > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård
>> > wrote:
>> > > Andy Shevchenko writes:
>> > >
>> > I used
Julian Margetson writes:
> On 12/21/2015 2:27 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/21/2015 1:55 PM, Andy Shevchenko wrote:
>>>> On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson wrote:
>>>>> On 12/21/2015 12:48 P
Andy Shevchenko writes:
> On Mon, 2015-12-21 at 01:19 +0000, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>> > P.S. I also noticed that original driver enables interrupt per each
>> > block
>>
>> And then ignores all but the transfer com
t;> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko
>>>>> wrote:
>>>>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård
>>>>>> wrote:
>>>>>> I noticed thanks to DWC_PARAMS that burst size is hardcoded to 32
>>>>&g
ndy Shevchenko
>>>> wrote:
>>>>>
>>>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård
>>>>> wrote:
>>>>> I noticed thanks to DWC_PARAMS that burst size is hardcoded to 32
>>>>> items on this board, however reg
Andy Shevchenko writes:
> On Mon, 2015-12-21 at 15:24 +0000, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>
>> Oh, that one again. My patch still applies. Here it is as applied
>> to
>> that revision of the file.
>>
>> From what I
Andy Shevchenko writes:
> On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>>> +Viresh
>>>
>>> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote:
>>>> Andy Shevchenko writes:
>>>>
>>
Julian Margetson writes:
> On 12/21/2015 9:24 AM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>>>>> P.S. Anyway we have to ask Julian to try the kernel with
>>>>>> 8b3444852a2b58129 reverted.
>>>>>>
>
iable]
> static struct dw_dma_slave sata_dwc_dma_dws = {
> ^
> drivers/ata/sata_dwc_460ex.c:1279:13: warning:
> ‘sata_dwc_dma_filter’ defined but not used [-Wunused-function]
> static bool sata_dwc_dma_filter(struct dma_chan *chan, void *param)
>
Julian Margetson writes:
> On 12/21/2015 4:40 AM, Andy Shevchenko wrote:
>> +Viresh
>>
>> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote:
>>> Andy Shevchenko writes:
>>>
>>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote:
>&g
Andy Shevchenko writes:
> +Viresh
>
> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>>>>> On 12/20/2015 1:11
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Mon, 2015-12-21 at 18:16 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>
>> > On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård <m...@mansr.com>
>&g
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Mon, 2015-12-21 at 15:19 -0400, Julian Margetson wrote:
>> On 12/21/2015 2:27 PM, Måns Rullgård wrote:
>> > The hard drive is recognized .
>> > > These system gets unrespon
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Mon, Dec 21, 2015 at 2:15 PM, Måns Rullgård <m...@mansr.com> wrote:
>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>
>>> +Viresh
>>>
>>> On Mon, Dec 21, 2015 at 2:58 AM
Julian Margetson <runa...@candw.ms> writes:
> On 12/21/2015 2:27 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/21/2015 1:55 PM, Andy Shevchenko wrote:
>>>> On Mon, Dec 21, 2015 at 7:26 PM, Julian Margetson <
+0200, Andy Shevchenko wrote:
>>>>> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko
>>>>> <andy.shevche...@gmail.com> wrote:
>>>>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <m...@mansr.com>
>>>>>> wrote:
>>
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Mon, 2015-12-21 at 15:24 +0000, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>
>> Oh, that one again. My patch still applies. Here it is as applied
>> to
&
gt; etc (SPI, UART, dmatest), AVR32 (MMC, dmatest), PPC 460EX (Onboard
>> > SATA)
>>
>> I can test on AVR32. That is as far as I know the only system I have
>> with this DMA engine.
>
> If you have Intel Haswell, BayTrail, Braswell, CherryTrail, Broadwell,
> you h
gt;>
>>>> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko
>>>> <andy.shevche...@gmail.com> wrote:
>>>>>
>>>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <m...@mansr.com>
>>>>> wrote:
>>>>> I notic
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Mon, 2015-12-21 at 01:19 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>
>> > P.S. I also noticed that original driver enables interrupt per each
&g
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Mon, 2015-12-21 at 19:27 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
>>
>> > I can share my working branch with a set of patches regarding to
&g
n, void *param)
> ^
Those messages do not match the contents of the file from v4.0.
For your convenience, here's the file as it should be.
$ sha1sum drivers/ata/sata_dwc_460ex.c
0f54dfa3a91591101f5de434c3a631a5cd20ff1a drivers/ata/sata_dwc_460ex.c
--
Måns Rullgård
/*
* drive
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> +Viresh
>
> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård <m...@mansr.com> wrote:
>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>
>>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <
Julian Margetson <runa...@candw.ms> writes:
> On 12/21/2015 4:40 AM, Andy Shevchenko wrote:
>> +Viresh
>>
>> On Mon, Dec 21, 2015 at 2:58 AM, Måns Rullgård <m...@mansr.com> wrote:
>>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>&g
Julian Margetson <runa...@candw.ms> writes:
> On 12/21/2015 9:24 AM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>>>>> P.S. Anyway we have to ask Julian to try the kernel with
>>>>>> 8b3444852a2b58129
Andy Shevchenko writes:
> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko
> wrote:
>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote:
>>> Julian Margetson writes:
>>>> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>>>>> Julian Margetson
Måns Rullgård writes:
> Andy Shevchenko writes:
>
>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote:
>>> Julian Margetson writes:
>>>> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>>>>> Julian Margetson writes:
>>
>>
Andy Shevchenko writes:
> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>
>>> [ 48.769671] ata3.00: failed command: READ FPDMA QUE
Andy Shevchenko writes:
> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>
>>> [ 48.769671] ata3.00: failed command: READ FPDMA QUE
Julian Margetson writes:
> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/19/2015 4:41 PM, Måns Rullgård wrote:
>>>> Andy Shevchenko writes:
>>>>
>>>>> On Sat, Dec 19, 2015 at 10:16 PM, Jul
Andy Shevchenko writes:
> On Sun, Dec 20, 2015 at 7:11 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/19/2015 4:41 PM, Måns Rullgård wrote:
>>>> Andy Shevchenko writes:
>>>>
>>>>> On Sat, Dec 19, 2015 at 10:16 P
Julian Margetson writes:
> On 12/19/2015 4:41 PM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>>> On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote:
>>>> On 12/19/2015 3:07 PM, Måns Rullgård wrote:
>>>>> Julian Margetson writ
Måns Rullgård <m...@mansr.com> writes:
> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>
>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <m...@mansr.com> wrote:
>>> Julian Margetson <runa...@candw.ms> writes:
>>>> On 12/20/2015 1
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <m...@mansr.com> wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>>>> Julian Margetson <run
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <m...@mansr.com> wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>>>> Julian Margetson <run
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Sun, Dec 20, 2015 at 10:17 PM, Andy Shevchenko
> <andy.shevche...@gmail.com> wrote:
>> On Sun, Dec 20, 2015 at 8:49 PM, Måns Rullgård <m...@mansr.com> wrote:
>>> Julian Margetson <runa...@candw.ms
Julian Margetson <runa...@candw.ms> writes:
> On 12/20/2015 1:11 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/19/2015 4:41 PM, Måns Rullgård wrote:
>>>> Andy Shevchenko <andy.shevche...@gmail.com> write
Julian Margetson <runa...@candw.ms> writes:
> On 12/19/2015 4:41 PM, Måns Rullgård wrote:
>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>
>>> On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson <runa...@candw.ms> wrote:
>>>> On
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Sun, Dec 20, 2015 at 7:11 PM, Måns Rullgård <m...@mansr.com> wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/19/2015 4:41 PM, Måns Rullgård wrote:
>>>> Andy Shevchenko
Andy Shevchenko writes:
> On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson wrote:
>> On 12/19/2015 3:07 PM, Måns Rullgård wrote:
>>> Julian Margetson writes:
>
>>>> Total pages: 522752
>>>> [0.00] Kernel command line: root=/de
Julian Margetson writes:
> On 12/19/2015 1:19 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/19/2015 1:05 PM, Måns Rullgård wrote:
>>>> Andy Shevchenko writes:
>>>>
>>>>> On Sat, Dec 19, 2015 at 5:40 PM, Måns R
Julian Margetson writes:
> On 12/19/2015 1:05 PM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>>> On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote:
>>>
>>>> OK, I've found something. The dma setup errors are benign, caused by
>>&
Andy Shevchenko writes:
> On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård wrote:
>
>> OK, I've found something. The dma setup errors are benign, caused by
>> the driver calling dmaengine_prep_slave_sg() even for non-dma
>> operations.
>
> I suppose the fol
Julian Margetson writes:
> On 12/19/2015 11:40 AM, Måns Rullgård wrote:
>> OK, I've found something. The dma setup errors are benign, caused by
>> the driver calling dmaengine_prep_slave_sg() even for non-dma
>> operations. The real error is the lock recursion that's
Julian Margetson writes:
> On 12/18/2015 10:34 PM, Andy Shevchenko wrote:
>> On Sat, Dec 19, 2015 at 1:16 AM, Måns Rullgård wrote:
>>> Julian Margetson writes:
>>>
>>>> On 12/18/2015 6:33 PM, Måns Rullgård wrote:
>>>>> Julian Margetson wri
Julian Margetson <runa...@candw.ms> writes:
> On 12/19/2015 1:19 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/19/2015 1:05 PM, Måns Rullgård wrote:
>>>> Andy Shevchenko <andy.shevche...@gmail.com> wr
Julian Margetson <runa...@candw.ms> writes:
> On 12/19/2015 11:40 AM, Måns Rullgård wrote:
>> OK, I've found something. The dma setup errors are benign, caused by
>> the driver calling dmaengine_prep_slave_sg() even for non-dma
>> operations. The real error is the loc
Julian Margetson <runa...@candw.ms> writes:
> On 12/19/2015 1:05 PM, Måns Rullgård wrote:
>> Andy Shevchenko <andy.shevche...@gmail.com> writes:
>>
>>> On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård <m...@mansr.com> wrote:
>>>
>>>
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Sat, Dec 19, 2015 at 5:40 PM, Måns Rullgård <m...@mansr.com> wrote:
>
>> OK, I've found something. The dma setup errors are benign, caused by
>> the driver calling dmaengine_prep_slave_sg() even for non-dm
Julian Margetson <runa...@candw.ms> writes:
> On 12/18/2015 10:34 PM, Andy Shevchenko wrote:
>> On Sat, Dec 19, 2015 at 1:16 AM, Måns Rullgård <m...@mansr.com> wrote:
>>> Julian Margetson <runa...@candw.ms> writes:
>>>
>>>> On 12/18/2015 6
Andy Shevchenko <andy.shevche...@gmail.com> writes:
> On Sat, Dec 19, 2015 at 10:16 PM, Julian Margetson <runa...@candw.ms> wrote:
>> On 12/19/2015 3:07 PM, Måns Rullgård wrote:
>>> Julian Margetson <runa...@candw.ms> writes:
>
>>>> Total pa
Julian Margetson writes:
> On 12/18/2015 6:33 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/18/2015 1:18 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>>>>
>>>>> On 12/18/20
Julian Margetson writes:
> On 12/18/2015 1:18 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/18/2015 8:49 AM, Måns Rullgård wrote:
>>>> Andy Shevchenko writes:
>>>>
>>>>>>> [5.206125] Unable t
Julian Margetson writes:
> On 12/18/2015 8:49 AM, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>>>>> [5.206125] Unable to handle kernel paging request for data at
>>>>> address 0x
>>>>> [5.228546] Faulting inst
Julian Margetson writes:
> On 12/18/2015 8:45 AM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>>>> Builds now. Using my own .config.
>>>> What changed?
>>> I may have messed up the patch initially .
>> Probably. Let's pr
rnel cmdline?
Enabling debug messages in the sata_dwc driver might also be informative.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[5.228546] Faulting instruction address: 0xc043a2c8
>>> [5.248577] Vector: 300 (Data Access) at [eddafae0]
>>> [5.268658] pc: c043a2c8: sata_dwc_qc_issue+0xb8/0x204
>> Well, that's not good. Can you translate that address to a line of code?
>>
> need
Julian Margetson writes:
> On 12/17/2015 8:06 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>>>>
>>>>> On 12/17/2015 2:51 PM, Måns Rullgård
Andy Shevchenko writes:
> On Thu, 2015-12-17 at 17:41 -0400, Julian Margetson wrote:
>> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>> > Julian Margetson writes:
>> >
>> > > On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>> > > > Julian Marg
Julian Margetson <runa...@candw.ms> writes:
> On 12/17/2015 8:06 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runa...@candw.ms> writes:
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Thu, 2015-12-17 at 17:41 -0400, Julian Margetson wrote:
>> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>> > Julian Margetson <runa...@candw.ms> writes:
>> >
>> > > On 12/17
gt;>> 0x
>>> [5.228546] Faulting instruction address: 0xc043a2c8
>>> [5.248577] Vector: 300 (Data Access) at [eddafae0]
>>> [5.268658] pc: c043a2c8: sata_dwc_qc_issue+0xb8/0x204
>> Well, that's not good. Can you translate that address to a line of
ac_core.dyndbg dw_dmac.dyndbg' to the kernel cmdline?
Enabling debug messages in the sata_dwc driver might also be informative.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info a
Julian Margetson <runa...@candw.ms> writes:
> On 12/18/2015 8:45 AM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>>>> Builds now. Using my own .config.
>>>> What changed?
>>> I may have messed up the
Julian Margetson <runa...@candw.ms> writes:
> On 12/18/2015 8:49 AM, Måns Rullgård wrote:
>> Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
>>
>>>>> [5.206125] Unable to handle kernel paging request for data at
>>>>> add
Julian Margetson <runa...@candw.ms> writes:
> On 12/18/2015 6:33 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/18/2015 1:18 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runa...@candw.ms> writes:
Julian Margetson <runa...@candw.ms> writes:
> On 12/18/2015 1:18 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/18/2015 8:49 AM, Måns Rullgård wrote:
>>>> Andy Shevchenko <andriy.shevche...@linux.intel.com>
Julian Margetson writes:
> On 12/17/2015 8:06 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>>>>
>>>>> On 12/17/2015 2:51 PM, Måns Rullgård
Julian Margetson writes:
> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>>>>
>>>>> On 12/17/2015 1:59 PM, Måns Rullgård wro
Julian Margetson writes:
> On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> On 12/17/2015 1:59 PM, Måns Rullgård wrote:
>>>> Julian Margetson writes:
>>>>
>>>>> I have been running my machine most
Julian Margetson writes:
> On 12/17/2015 1:59 PM, Måns Rullgård wrote:
>> Julian Margetson writes:
>>
>>> I have been running my machine mostly configured for pciex1 thus with
>>> the sata_dwc disabled.
>>> The changes to sata_dwc-460ex do cause an
t;
> The old code had some blank lines, which I suppose were there for clarity.
> I attempted to follow the same idea.
> But I don't mind changing the code as you wish.
It could well be that your patch results in a clearer final version, but
the diff is harder to parse when unchanged lines
o that since it unconditionally
dereferences a null pointer in the probe function. My patch fixes that
as a side-effect.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vge
Andy Shevchenko writes:
> On Thu, 2015-12-17 at 15:13 +0000, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>> > On Tue, 2015-12-15 at 23:34 +, Måns Rullgård wrote:
>> > > Mans Rullgard writes:
>> > >
>> > > >
t(p, UART_DLL, old_dll);
> -serial_out(p, UART_DLM, old_dlm);
> serial_out(p, UART_LCR, old_lcr);
>
> return id;
> --
If you left the blank lines alone, the patch would end up much easier to
understand. In this diff, some of the lines listed as added or removed
hav
Andy Shevchenko writes:
> On Thu, 2015-12-17 at 15:19 +0000, Måns Rullgård wrote:
>> Andy Shevchenko writes:
>>
>> > On Tue, 2015-12-15 at 23:25 +, Mans Rullgard wrote:
>> > > This moves all global data into the driver private struct, thus
>> &g
Sebastian Frias writes:
> - reading/writing to UART_DLL/UART_DLM directly are converted to using
> the read_dl/write_dl callbacks.
This should be an obvious fix. Please send that as a separate patch.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe l
. Is that the warnings
you refer to? I'm not getting any regular compiler warnings.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.
Andy Shevchenko writes:
> On Tue, 2015-12-15 at 23:34 +0000, Måns Rullgård wrote:
>> Mans Rullgard writes:
>>
>> > Currently this driver only works with a DesignWare DMA engine which
>> > it
>> > registers manually using the second "reg" addr
>
> -serial_out(p, UART_DLL, old_dll);
> -serial_out(p, UART_DLM, old_dlm);
> serial_out(p, UART_LCR, old_lcr);
>
> return id;
> --
If you left the blank lines alone, the patch would end up much easier to
understand. In this diff, some of the lines li
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Thu, 2015-12-17 at 15:13 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
>>
>> > On Tue, 2015-12-15 at 23:34 +, Måns Rullgård wrote:
>>
There are some issues with __iomem annotations. Is that the warnings
you refer to? I'm not getting any regular compiler warnings.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Thu, 2015-12-17 at 15:19 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
>>
>> > On Tue, 2015-12-15 at 23:25 +, Mans Rullgard wrote:
>> >
Sebastian Frias <s...@laposte.net> writes:
> - reading/writing to UART_DLL/UART_DLM directly are converted to using
> the read_dl/write_dl callbacks.
This should be an obvious fix. Please send that as a separate patch.
--
Måns Rullgård
--
To unsubscribe from this list: s
Andy Shevchenko <andriy.shevche...@linux.intel.com> writes:
> On Tue, 2015-12-15 at 23:34 +0000, Måns Rullgård wrote:
>> Mans Rullgard <m...@mansr.com> writes:
>>
>> > Currently this driver only works with a DesignWare DMA engine which
>> > it
Julian Margetson <runa...@candw.ms> writes:
> On 12/17/2015 1:59 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> I have been running my machine mostly configured for pciex1 thus with
>>> the sata_dwc disabled.
>&
obvious.
>>
>
> The old code had some blank lines, which I suppose were there for clarity.
> I attempted to follow the same idea.
> But I don't mind changing the code as you wish.
It could well be that your patch results in a clearer final version, but
the diff is harder to parse wh
upstream would do that since it unconditionally
dereferences a null pointer in the probe function. My patch fixes that
as a side-effect.
--
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
Julian Margetson <runa...@candw.ms> writes:
> On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/17/2015 1:59 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runa...@candw.ms> writes:
>&
Julian Margetson <runa...@candw.ms> writes:
> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/17/2015 2:51 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runa...@candw.ms> writes:
Julian Margetson <runa...@candw.ms> writes:
> On 12/17/2015 8:06 PM, Måns Rullgård wrote:
>> Julian Margetson <runa...@candw.ms> writes:
>>
>>> On 12/17/2015 3:53 PM, Måns Rullgård wrote:
>>>> Julian Margetson <runa...@candw.ms> writes:
Mark Brown writes:
> On Wed, Dec 16, 2015 at 01:31:30PM +0000, Måns Rullgård wrote:
>
>> This is the 1/1 you were missing.
>
> I need the patch in a form I can apply.
I assumed your email client had some way of displaying the message I
replied to. Guess I was wrong.
>&g
compatible: "wlf,wm8974"
> + - reg: the I2C address or SPI chip select number of the device
> +
> +Examples:
> +
> +codec: wm8974@1a {
> + compatible = "wlf,wm8974";
> + reg = <0x1a>;
> +};
> --
> 2.6.3
>
--
Måns Rullgård
--
To unsub
+
>> +err = phy_power_on(hsdev->phy);
>> +if (err)
>> +goto error_out;
>> +
>> /*
>> * Now, register with libATA core, this will also initiate the
>> * device discovery process, invoking our port_start() handler &
&g
> +Required properties:
> + - compatible: "wlf,wm8974"
> + - reg: the I2C address or SPI chip select number of the device
> +
> +Examples:
> +
> +codec: wm8974@1a {
> + compatible = "wlf,wm8974";
> + reg = <0x1a>;
> +};
>
301 - 400 of 818 matches
Mail list logo
