Re: [PATCH v2 01/13] intel_gna: add driver module

Andy Shevchenko writes: > On Wed, Mar 24, 2021 at 8:38 PM Maciej Kwapulinski > wrote: >> >> diff --git a/include/uapi/misc/intel/gna.h b/include/uapi/misc/intel/gna.h >> new file mode 100644 >> index ..a7e435b74a0a >> --- /dev/null &g

Re: [PATCH v2 02/13] intel_gna: add component of hardware operation

Andy Shevchenko writes: > On Wed, Mar 24, 2021 at 8:38 PM Maciej Kwapulinski > wrote: >> +#define gna_reg_write(addr, offset, value) writel((value), (addr) + >> (offset)) > > No point And make them functions, not macros. > >> + >> +#endif // __GNA

[PATCH v2 12/13] intel_gna: add a 'misc' device

The new 'misc' device is the node for applications in user space to interact with the driver. Signed-off-by: Maciej Kwapulinski Tested-by: Savo Novakovic --- drivers/misc/intel/gna/gna_device.c | 69 ++-- drivers/misc/intel/gna/gna_device.h | 6 +++ dr

[PATCH v2 13/13] intel_gna: add file operations to a 'misc' device

From: Tomasz Jankowski Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/gna_device.c | 60 - 1

[PATCH v2 09/13] intel_gna: add a work queue to process scoring requests

Novakovic Co-developed-by: Anisha Dattatraya Kulkarni Signed-off-by: Anisha Dattatraya Kulkarni Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/gna_device.c | 12 +++ drivers/misc

[PATCH v2 11/13] intel_gna: add ioctl handler

scoring completion. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/Kbuild | 2 +- drivers/misc/intel/gna

[PATCH v2 10/13] intel_gna: add interrupt handler

: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/gna_device.c | 45 - drivers/misc/intel/gna/gna_device.h | 2 ++ drivers/misc/intel/gna/gna_hw.h | 1 - 3 files changed, 46 insertions(+), 2 deletions

[PATCH v2 07/13] intel_gna: add request component

Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/Kbuild| 2 +- drivers/misc/intel/gna/gna_device.c | 6 + drivers/misc/intel/gna/gna_device.h | 6 + drivers/misc/intel/gna

[PATCH v2 06/13] intel_gna: add hardware ids

From: Tomasz Jankowski Add PCI ids of Intel(R) Gaussian & Neural Accelerator on supported platforms. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapuli

[PATCH v2 05/13] intel_gna: initialize mmu

From: Tomasz Jankowski Setup mmu in the driver with a new memory component. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-Developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/gna_device.c | 29 +++-- 1 file

[PATCH v2 08/13] intel_gna: implement scoring

From: Tomasz Jankowski Add a new component for scoring logic such as configuring and kicking off the hardware. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej

[PATCH v2 04/13] intel_gna: add memory handling

Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel/gna/Kbuild | 2 +- drivers/misc/intel/gna/gna_device.c | 20 ++ drivers/misc/intel/gna/gna_device.h | 13

[PATCH v2 03/13] intel_gna: read hardware info in the driver

From: Tomasz Jankowski Get the hardware information from register MMIO_IBUFFS Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/intel

[PATCH v2 01/13] intel_gna: add driver module

nxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- Documentation/misc-devices/index.rst | 1 + Documentation/misc-devices/intel/gna.rst | 48 ++ .../userspace-api/ioctl/ioctl-number.rst | 1 + MAINTAI

[PATCH v2 02/13] intel_gna: add component of hardware operation

From: Tomasz Jankowski Add definitions and utilities to interact with the hardware device. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski

[PATCH v2 00/13] Driver of Intel(R) Gaussian & Neural Accelerator

r files' includes and forward declarations cleanup - ISR made static - unused comments cleanup - "_priv_" segment removed from function names - tested: v5.11-rc3 -> v5.11 - number of other/minor fixes --- Maciej Kwapulinski (1): intel_gna: add a 'misc' device To

Re: [PATCH v1 01/12] gna: add driver module

Greg Kroah-Hartman writes: > On Fri, Feb 26, 2021 at 01:59:14PM +0100, Maciej Kwapulinski wrote: >> >> Greg Kroah-Hartman writes: >> >> > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: >> >> >> --- /dev/null >>

Re: [PATCH v1 01/12] gna: add driver module

Greg Kroah-Hartman writes: > On Mon, Mar 01, 2021 at 11:39:23AM +0100, Maciej Kwapulinski wrote: >> >> Maciej Kwapulinski writes: >> >> > Greg Kroah-Hartman writes: >> > >> >> On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapul

Re: [PATCH v1 01/12] gna: add driver module

Maciej Kwapulinski writes: > Greg Kroah-Hartman writes: > >> On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: >>> >>> Andy Shevchenko writes: >>> >>> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >>> >

Re: [PATCH v1 01/12] gna: add driver module

Greg Kroah-Hartman writes: > On Mon, Mar 01, 2021 at 11:18:59AM +0100, Maciej Kwapulinski wrote: >> >> Andy Shevchenko writes: >> >> > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski >> > wrote: >> >> >> >> >>

Re: [PATCH v1 01/12] gna: add driver module

Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> >> +static int __init gna_drv_init(void) >> +{ >> + int ret; >> + >> + mutex_init(&gna_drv_priv.lock); >> + >> + gna_class

Re: [PATCH v1 01/12] gna: add driver module

Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> >> +#define GNA_DRV_VER"1.2.0" > > Nowadays the version is the Git SHA sum. > right, "version" is present in about 7% of all modules do You mea

Re: [PATCH v1 01/12] gna: add driver module

Greg Kroah-Hartman writes: > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: >> --- /dev/null >> +++ b/drivers/misc/gna/gna_driver.h >> @@ -0,0 +1,41 @@ >> +/* SPDX-License-Identifier: GPL-2.0-only */ >> +/* Copyright(c) 2017-2021 Inte

Re: [PATCH v1 01/12] gna: add driver module

Andy Shevchenko writes: > On Tue, Feb 16, 2021 at 6:11 PM Maciej Kwapulinski > wrote: >> >> +err_clear_master: >> + pci_clear_master(pcidev); >> +err_release_regions: >> + pci_release_regions(pcidev); >> +end: >> + dev_err

Re: [PATCH v1 01/12] gna: add driver module

Greg Kroah-Hartman writes: > On Tue, Feb 16, 2021 at 05:05:14PM +0100, Maciej Kwapulinski wrote: >> --- /dev/null >> +++ b/drivers/misc/gna/gna_driver.c >> @@ -0,0 +1,65 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +// Copyright(c) 2017-2021 Intel Corpor

[PATCH v1 11/12] gna: add ioctl handler

scoring completion. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/Kbuild | 2 +- drivers/misc/gna/gna_device.c | 40

[PATCH v1 10/12] gna: add interrupt handler

: Jianxun Zhang Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 32 ++-- drivers/misc/gna/gna_device.h | 2 ++ drivers/misc/gna/gna_hw.c | 10 ++ drivers/misc/gna/gna_hw.h | 2 ++ 4 files changed, 44 insertions(+), 2 deletions

[PATCH v1 09/12] gna: add a work queue to process scoring requests

: Anisha Dattatraya Kulkarni Signed-off-by: Anisha Dattatraya Kulkarni Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 21 +- drivers/misc/gna

[PATCH v1 08/12] gna: implement scoring

From: Tomasz Jankowski Add a new component for scoring logic such as configuring and kicking off the hardware. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej

[PATCH v1 07/12] gna: add request component

Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/Kbuild| 2 +- drivers/misc/gna/gna_device.c | 5 + drivers/misc/gna/gna_device.h | 5 + drivers/misc/gna/gna_mem.c | 3

[PATCH v1 06/12] gna: add hardware ids

From: Tomasz Jankowski Add PCI ids of Intel(R) Gaussian & Neural Accelerator on supported platforms. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_devi

[PATCH v1 04/12] gna: add memory handling

Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/Kbuild | 2 +- drivers/misc/gna/gna_device.c | 6 + drivers/misc/gna/gna_device.h | 11 +- drivers/misc/gna

[PATCH v1 05/12] gna: initialize mmu

From: Tomasz Jankowski Setup mmu in the driver with a new memory component. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/misc/gna

[PATCH v1 03/12] gna: read hardware info in the driver

From: Tomasz Jankowski Get the hardware information from register MMIO_IBUFFS Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Signed-off-by: Maciej Kwapulinski --- drivers/misc/gna/gna_device.c | 6 ++ 1 file

[PATCH v1 02/12] gna: add component of hardware operation

From: Tomasz Jankowski Add definitions and utilities to interact with the hardware device. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski

[PATCH v1 12/12] gna: add a char device

From: Tomasz Jankowski The new char device is the node for applications in user space to interact with the driver. Signed-off-by: Tomasz Jankowski Tested-by: Savo Novakovic Co-developed-by: Jianxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej

[PATCH v1 01/12] gna: add driver module

nxun Zhang Signed-off-by: Jianxun Zhang Co-developed-by: Maciej Kwapulinski Signed-off-by: Maciej Kwapulinski --- Documentation/misc-devices/gna.rst| 48 ++ Documentation/misc-devices/index.rst | 1 + .../userspace-api/ioctl/ioctl-number.rst | 1 + MAINTAI

[PATCH v1 00/12] Driver of Intel(R) Gaussian & Neural Accelerator

Dear kernel maintainers, This submission is a kernel driver to support Intel(R) Gaussian & Neural Accelerator (Intel(R) GNA). Intel(R) GNA is a PCI-based neural co-processor available on multiple Intel platforms. AI developers and users can offload continuous inference workloads to an Intel(R)