Re: linux-next: build failure after merge of the scsi-mkp tree

Hi Stephen, > On Mar 21, 2018, at 11:25 PM, Stephen Rothwell wrote: > > Hi Martin, > > After merging the scsi-mkp tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > drivers/scsi/qla2xxx/qla_gs.c: In function 'qla24xx_async_gnnft_done': >

Re: linux-next: build failure after merge of the scsi-mkp tree

Hi Stephen, > On Mar 21, 2018, at 11:25 PM, Stephen Rothwell wrote: > > Hi Martin, > > After merging the scsi-mkp tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > drivers/scsi/qla2xxx/qla_gs.c: In function 'qla24xx_async_gnnft_done': >

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann <m...@cm4all.com> wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" <himanshu.madh...@cavium.com> wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. > > No,

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. > > No, let me repeat: this is a different bug! > > Yo

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Hi Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann <m...@cm4all.com> wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" <himanshu.madh...@cavium.com> wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. >

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Hi Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. > > No, let me repeat: this is a different bug! > > Yo

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Hi Max, > On Jan 15, 2018, at 9:26 AM, Max Kellermann wrote: > > When the qla2xxx firmware is unavailable, eventually > qla2x00_sp_timeout() is reached, which calls the timeout function and > frees the srb_t instance. > > The timeout function always resolves to

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Hi Max, > On Jan 15, 2018, at 9:26 AM, Max Kellermann wrote: > > When the qla2xxx firmware is unavailable, eventually > qla2x00_sp_timeout() is reached, which calls the timeout function and > frees the srb_t instance. > > The timeout function always resolves to qla2x00_async_iocb_timeout(), >

Re: [linux-next][qla2xxx][85caa95]kernel BUG at lib/list_debug.c:31!

> On Jan 10, 2018, at 9:38 PM, Abdul Haleem <abdha...@linux.vnet.ibm.com> wrote: > > On Tue, 2018-01-09 at 18:09 +, Madhani, Himanshu wrote: >> Hello Abdul, >> >>> On Jan 9, 2018, at 7:54 AM, Bart Van Assche <bart.vanass...@wdc.com> wrote: >>

Re: [linux-next][qla2xxx][85caa95]kernel BUG at lib/list_debug.c:31!

> On Jan 10, 2018, at 9:38 PM, Abdul Haleem wrote: > > On Tue, 2018-01-09 at 18:09 +, Madhani, Himanshu wrote: >> Hello Abdul, >> >>> On Jan 9, 2018, at 7:54 AM, Bart Van Assche wrote: >>> >>> On Tue, 2018-01-09 at 14:44 +0530, Abdul Halee

Re: [linux-next][qla2xxx][85caa95]kernel BUG at lib/list_debug.c:31!

Hello Abdul, > On Jan 9, 2018, at 7:54 AM, Bart Van Assche wrote: > > On Tue, 2018-01-09 at 14:44 +0530, Abdul Haleem wrote: >> Greeting's, >> >> Linux next kernel panics on powerpc when module qla2xxx is load/unload. >> >> Machine Type: Power 8 PowerVM LPAR >>

Re: [linux-next][qla2xxx][85caa95]kernel BUG at lib/list_debug.c:31!

Hello Abdul, > On Jan 9, 2018, at 7:54 AM, Bart Van Assche wrote: > > On Tue, 2018-01-09 at 14:44 +0530, Abdul Haleem wrote: >> Greeting's, >> >> Linux next kernel panics on powerpc when module qla2xxx is load/unload. >> >> Machine Type: Power 8 PowerVM LPAR >> Kernel :

Re: [PATCH 2/9] scsi: qla2xxx: Use zeroing allocator rather than allocator/memset

> On Dec 30, 2017, at 7:28 AM, Himanshu Jha wrote: > > Use dma_zalloc_coherent and vzalloc instead of dma_alloc_coherent and > vmalloc respectively, followed by memset 0. > > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > Suggested-by: Luis R.

Re: [PATCH 2/9] scsi: qla2xxx: Use zeroing allocator rather than allocator/memset

> On Dec 30, 2017, at 7:28 AM, Himanshu Jha wrote: > > Use dma_zalloc_coherent and vzalloc instead of dma_alloc_coherent and > vmalloc respectively, followed by memset 0. > > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > > Suggested-by: Luis R. Rodriguez > Signed-off-by:

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Hi Max, > On Dec 7, 2017, at 6:46 AM, Max Kellermann wrote: > > When the qla2xxx firmware is unavailable, eventually > qla2x00_sp_timeout() is reached, which calls the timeout function and > frees the srb_t instance. > > The timeout function always resolves to

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

Hi Max, > On Dec 7, 2017, at 6:46 AM, Max Kellermann wrote: > > When the qla2xxx firmware is unavailable, eventually > qla2x00_sp_timeout() is reached, which calls the timeout function and > frees the srb_t instance. > > The timeout function always resolves to qla2x00_async_iocb_timeout(), >

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Bart, > On Nov 5, 2017, at 4:18 PM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > > On Wed, 2017-11-01 at 19:18 +, Madhani, Himanshu wrote: >> Hi Kees, >> >>> On Nov 1, 2017, at 11:46 AM, Kees Cook <keesc...@chromium.org> wrote: >>&g

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Bart, > On Nov 5, 2017, at 4:18 PM, Bart Van Assche wrote: > > On Wed, 2017-11-01 at 19:18 +, Madhani, Himanshu wrote: >> Hi Kees, >> >>> On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: >>> >>> On Tue, Oct 31, 2017 at 12:13 PM, Kees Coo

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Kees, > On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: >> This breaks out the logical steps to convert the qla2xxx timers: >> >> 1) init_timer() -> setup_timer() >> 2) refactor

Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Kees, > On Nov 1, 2017, at 11:46 AM, Kees Cook wrote: > > On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook wrote: >> This breaks out the logical steps to convert the qla2xxx timers: >> >> 1) init_timer() -> setup_timer() >> 2) refactor qla2x00_start_timer() to not pass callback as argument >>

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Kees, > On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: > > How very strange. I don't see any code change with this patch. Even > the passed arguments are the same; it's only enforcing the types now. > And the system is fine with only this patch reverted? Yes. Agree

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Kees, > On Oct 31, 2017, at 11:28 AM, Kees Cook wrote: > > How very strange. I don't see any code change with this patch. Even > the passed arguments are the same; it's only enforcing the types now. > And the system is fine with only this patch reverted? Yes. Agree patch looks okay, but

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Bart, > On Oct 31, 2017, at 11:12 AM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > > On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: >> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen <martin.peter...@oracle.com> >> wrote: >>>&g

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Bart, > On Oct 31, 2017, at 11:12 AM, Bart Van Assche wrote: > > On Tue, 2017-10-31 at 18:03 +, Madhani, Himanshu wrote: >> On Oct 31, 2017, at 8:49 AM, Martin K. Petersen >> wrote: >>>> In preparation for unconditionally passing the struct tim

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Martin/Kees, > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen > wrote: > > > Kees, > >> In preparation for unconditionally passing the struct timer_list >> pointer to all timer callbacks, switch to using the new timer_setup() >> and from_timer() to pass the

Re: [PATCH] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Martin/Kees, > On Oct 31, 2017, at 8:49 AM, Martin K. Petersen > wrote: > > > Kees, > >> In preparation for unconditionally passing the struct timer_list >> pointer to all timer callbacks, switch to using the new timer_setup() >> and from_timer() to pass the timer pointer explicitly. >

Re: [PATCH 5/6] scsi: qla2xxx: Cocci spatch "pool_zalloc-simple"

> On Sep 20, 2017, at 11:15 PM, Thomas Meyer wrote: > > Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. > Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" > > Signed-off-by: Thomas Meyer > --- > > diff -u -p

Re: [PATCH 5/6] scsi: qla2xxx: Cocci spatch "pool_zalloc-simple"

> On Sep 20, 2017, at 11:15 PM, Thomas Meyer wrote: > > Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0. > Found by coccinelle spatch "api/alloc/pool_zalloc-simple.cocci" > > Signed-off-by: Thomas Meyer > --- > > diff -u -p a/drivers/scsi/qla2xxx/qla_bsg.c

Re: [PATCH] qla2xxx: add missing includes for qla_isr

> On Aug 30, 2017, at 6:12 AM, Johannes Thumshirn wrote: > > Since commit 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling") > we make use of 'struct nvmefc_fcp_req' in qla24xx_nvme_iocb_entry() without > including linux/nvme-fc-driver.h where it is defined. > >

Re: [PATCH] qla2xxx: add missing includes for qla_isr

> On Aug 30, 2017, at 6:12 AM, Johannes Thumshirn wrote: > > Since commit 7401bc18d1ee ("scsi: qla2xxx: Add FC-NVMe command handling") > we make use of 'struct nvmefc_fcp_req' in qla24xx_nvme_iocb_entry() without > including linux/nvme-fc-driver.h where it is defined. > > Add

Re: scsi: qla2xxx: use dma_mapping_error to check map errors

> On Aug 8, 2017, at 6:55 AM, Pan Bian wrote: > > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its > return value is checked against NULL, which could result in failures. > >

Re: scsi: qla2xxx: use dma_mapping_error to check map errors

> On Aug 8, 2017, at 6:55 AM, Pan Bian wrote: > > The return value of dma_map_single() should be checked by > dma_mapping_error(). However, in function qla26xx_dport_diagnostics(), its > return value is checked against NULL, which could result in failures. > > Signed-off-by: Pan Bian > --- >

Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning

> On Jun 30, 2017, at 9:10 AM, Arnd Bergmann wrote: > > When NVMe support is disabled, we get a couple of harmless warnings: > > drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: > 'qla_nvme_unregister_remote_port' defined but not used > [-Werror=unused-function] >

Re: [PATCH 2/2] scsi: qla2xxx: avoid unused-function warning

> On Jun 30, 2017, at 9:10 AM, Arnd Bergmann wrote: > > When NVMe support is disabled, we get a couple of harmless warnings: > > drivers/scsi/qla2xxx/qla_nvme.c:667:13: error: > 'qla_nvme_unregister_remote_port' defined but not used > [-Werror=unused-function] >

Re: [PATCH][scsi-next] scsi: qla2xxx: fix a bunch of typos and spelling mistakes

> On Jun 30, 2017, at 6:47 AM, Colin King wrote: > > From: Colin Ian King > > Fix the following typos/spelling mistakes: > > "attribure" -> "attribute" > "suppored" -> "supported" > "Symobilic" -> "Symbolic" > "iteself" -> "itself" >

Re: [PATCH][scsi-next] scsi: qla2xxx: fix a bunch of typos and spelling mistakes

> On Jun 30, 2017, at 6:47 AM, Colin King wrote: > > From: Colin Ian King > > Fix the following typos/spelling mistakes: > > "attribure" -> "attribute" > "suppored" -> "supported" > "Symobilic" -> "Symbolic" > "iteself" -> "itself" > "reqeust" -> "request" > "nvme_wait_on_comand" ->

Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap

> On Jun 30, 2017, at 9:41 AM, James Bottomley wrote: > > On Fri, 2017-06-30 at 18:10 +0200, Arnd Bergmann wrote: >> cont_pkt->entry_type is an 8-bit field, so doing a 32-bit byteswap >> on it will store incorrect data: >> >> drivers/scsi/qla2xxx/qla_nvme.c: In

Re: [PATCH 1/2] scsi: qla2xxx: remove incorrect byte swap

> On Jun 30, 2017, at 9:41 AM, James Bottomley wrote: > > On Fri, 2017-06-30 at 18:10 +0200, Arnd Bergmann wrote: >> cont_pkt->entry_type is an 8-bit field, so doing a 32-bit byteswap >> on it will store incorrect data: >> >> drivers/scsi/qla2xxx/qla_nvme.c: In function

Re: linux-next: build warnings after merge of the scsi-mkp tree

Hi Stephen, James, > On Jun 28, 2017, at 10:07 PM, Stephen Rothwell wrote: > > Hi James, > > This has now migrated to the scsi tree. > > On Wed, 28 Jun 2017 15:55:10 +1000 Stephen Rothwell > wrote: >> >> After merging the scsi-mkp tree, today's

Re: linux-next: build warnings after merge of the scsi-mkp tree

Hi Stephen, James, > On Jun 28, 2017, at 10:07 PM, Stephen Rothwell wrote: > > Hi James, > > This has now migrated to the scsi tree. > > On Wed, 28 Jun 2017 15:55:10 +1000 Stephen Rothwell > wrote: >> >> After merging the scsi-mkp tree, today's linux-next build >> (powerpc_ppc64_defconfig)

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

> On Jun 23, 2017, at 12:10 AM, Johannes Thumshirn wrote: > > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

> On Jun 23, 2017, at 12:10 AM, Johannes Thumshirn wrote: > > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to qpair > members

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

Hi Martin, On 6/27/17, 6:32 PM, "Martin K. Petersen" wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

Hi Martin, On 6/27/17, 6:32 PM, "Martin K. Petersen" wrote: > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to

Re: [PATCH] scsi: qla2xxx: fix printk format string warning on 32-bit

Hi Arnd, > On Jun 9, 2017, at 3:46 AM, Arnd Bergmann wrote: > > On 32-bit architectures, we using %lx to print a size_t causes a harmless > warning: > > qla2xxx/qla_init.c: In function 'qla24xx_load_risc_flash': > qla2xxx/qla_init.c:6407:7: error: format '%lx' expects argument

Re: [PATCH] scsi: qla2xxx: fix printk format string warning on 32-bit

Hi Arnd, > On Jun 9, 2017, at 3:46 AM, Arnd Bergmann wrote: > > On 32-bit architectures, we using %lx to print a size_t causes a harmless > warning: > > qla2xxx/qla_init.c: In function 'qla24xx_load_risc_flash': > qla2xxx/qla_init.c:6407:7: error: format '%lx' expects argument of type 'long

Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt

> On Jun 5, 2017, at 10:29 AM, Colin King wrote: > > From: Colin Ian King > > An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove > redundant wait when target is stopped.") removed a null check > on ha->tgt.tgt_ops and replaced it

Re: [PATCH][scsi-next] scsi: qla2xxx: remove redundant null check on tgt

> On Jun 5, 2017, at 10:29 AM, Colin King wrote: > > From: Colin Ian King > > An earlier commit ed7fb808477b846bb2 ("scsi: qla2xxx: Remove > redundant wait when target is stopped.") removed a null check > on ha->tgt.tgt_ops and replaced it with a new check that null > checked tgt, thus making

Re: [PATCH 0/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support

> On Jun 3, 2017, at 3:10 PM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > Hi Himanshu + Quinn, > > Here is a small series to introduce proper percpu se_lun->lun_ref > counting for TMR, and add common code in target_submit_tmr()

Re: [PATCH 0/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support

> On Jun 3, 2017, at 3:10 PM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > Hi Himanshu + Quinn, > > Here is a small series to introduce proper percpu se_lun->lun_ref > counting for TMR, and add common code in target_submit_tmr() to > do tag lookup for unpacked_lun in

Re: [PATCH] qla2xxx: remove writeq/readq function definitions

> On Jun 2, 2017, at 4:32 AM, Corentin Labbe wrote: > > Instead of rewriting write/readq, use linux/io-64-nonatomic-lo-hi.h which > already have them. > > Signed-off-by: Corentin Labbe > --- > drivers/scsi/qla2xxx/qla_nx.h | 17

Re: [PATCH] qla2xxx: remove writeq/readq function definitions

tries. */ > #define RESPONSE_ENTRY_CNT_82XX 128 /* Number of response > entries.*/ > -- > 2.13.0 > Looks Good. Thanks Acked-by: Himanshu Madhani - Himanshu

Re: [PATCH 0/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support

> On Jun 3, 2017, at 3:10 PM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > Hi Himanshu + Quinn, > > Here is a small series to introduce proper percpu se_lun->lun_ref > counting for TMR, and add common code in target_submit_tmr()

Re: [PATCH 0/3] target: Add TARGET_SCF_LOOKUP_LUN_FROM_TAG support

> On Jun 3, 2017, at 3:10 PM, Nicholas A. Bellinger > wrote: > > From: Nicholas Bellinger > > Hi Himanshu + Quinn, > > Here is a small series to introduce proper percpu se_lun->lun_ref > counting for TMR, and add common code in target_submit_tmr() to > do tag lookup for unpacked_lun in

RE: [PATCH] qla2xxx: Fix ql_dump_buffer

> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, March 2, 2017 5:15 PM > To: qla2xxx-upstr...@qlogic.com > Cc: James E.J. Bottomley ; Martin K. Petersen > ; linux-s...@vger.kernel.org; linux- >

RE: [PATCH] qla2xxx: Fix ql_dump_buffer

> -Original Message- > From: Joe Perches [mailto:j...@perches.com] > Sent: Thursday, March 2, 2017 5:15 PM > To: qla2xxx-upstr...@qlogic.com > Cc: James E.J. Bottomley ; Martin K. Petersen > ; linux-s...@vger.kernel.org; linux- > ker...@vger.kernel.org > Subject: [PATCH] qla2xxx: Fix

RE: [PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, February 23, 2017 2:57 AM > To: qla2xxx-upstr...@qlogic.com; James E . J . Bottomley > ; Martin K . Petersen > ; linux-s...@vger.kernel.org >

RE: [PATCH] qla2xxx: fix spelling mistake: "seperator" -> "separator"

> -Original Message- > From: Colin King [mailto:colin.k...@canonical.com] > Sent: Thursday, February 23, 2017 2:57 AM > To: qla2xxx-upstr...@qlogic.com; James E . J . Bottomley > ; Martin K . Petersen > ; linux-s...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Subject: [PATCH]

Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer

On 12/29/16, 2:20 PM, "Colin King" wrote: >From: Colin Ian King > >Rename the vendor_indentifer and hba_indentifer fields to correct spelling. > >Signed-off-by: Colin Ian King >--- > drivers/scsi/qla2xxx/qla_def.h |

Re: [PATCH] qla2xxx: rename {vendor|hba}_indentifer to {vendor|hba}_identifer

On 12/29/16, 2:20 PM, "Colin King" wrote: >From: Colin Ian King > >Rename the vendor_indentifer and hba_indentifer fields to correct spelling. > >Signed-off-by: Colin Ian King >--- > drivers/scsi/qla2xxx/qla_def.h | 4 ++-- > drivers/scsi/qla2xxx/qla_gs.c | 6 +++--- > 2 files changed, 5

Re: [PATCH 2/2] scsi: qla2xxx: make msix_entries const

On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >msix_entries and qla82xx_msix_entries arrays are never modified in >drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data. > >Signed-off-by: Nicolas Iooss >--- >

Re: [PATCH 2/2] scsi: qla2xxx: make msix_entries const

On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >msix_entries and qla82xx_msix_entries arrays are never modified in >drivers/scsi/qla2xxx/qla_isr.c. Move their contents to read-only data. > >Signed-off-by: Nicolas Iooss >--- > drivers/scsi/qla2xxx/qla_isr.c | 6 +++--- > 1 file changed, 3

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >qla24xx_enable_msix() calls scnprintf() with a non-literal format >string. This makes clang report -Wformat-security warnings when >compiling this function: > >drivers/scsi/qla2xxx/qla_isr.c:3083:7: error: format

Re: [PATCH 1/2] scsi: qla2xxx: silent -Wformat-security warning

On 12/26/16, 5:23 AM, "Nicolas Iooss" wrote: >qla24xx_enable_msix() calls scnprintf() with a non-literal format >string. This makes clang report -Wformat-security warnings when >compiling this function: > >drivers/scsi/qla2xxx/qla_isr.c:3083:7: error: format string is not a >string

Re: [PATCH] scsi/qla2xxx: label endian-ness for many fields

On 12/9/16, 12:45 PM, "Michael S. Tsirkin" wrote: >This adds endian-ness labels for lots of qla structs. >Doing this cuts down number of sparse warnings from ~1700 to ~1400. >Will help find and resolve some of real issues down the road. > >Signed-off-by: Michael S. Tsirkin

Re: [PATCH] scsi/qla2xxx: label endian-ness for many fields

On 12/9/16, 12:45 PM, "Michael S. Tsirkin" wrote: >This adds endian-ness labels for lots of qla structs. >Doing this cuts down number of sparse warnings from ~1700 to ~1400. >Will help find and resolve some of real issues down the road. > >Signed-off-by: Michael S. Tsirkin > >--- >

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

Hi Mike/Bart, On 12/8/16, 8:17 AM, "virtualization-boun...@lists.linux-foundation.org on behalf of Michael S. Tsirkin" wrote: >On Thu, Dec 08, 2016 at 06:38:11AM +, Bart Van Assche wrote: >> On

Re: [PATCH] linux/types.h: enable endian checks for all sparse builds

Hi Mike/Bart, On 12/8/16, 8:17 AM, "virtualization-boun...@lists.linux-foundation.org on behalf of Michael S. Tsirkin" wrote: >On Thu, Dec 08, 2016 at 06:38:11AM +, Bart Van Assche wrote: >> On 12/07/16 21:54, Michael S. Tsirkin wrote: >> > On Thu, Dec 08, 2016 at 05:21:47AM +,

Re: [PATCH] qla2xxx: do not abort all commands in the adapter during EEH recovery

On 11/14/16, 1:26 PM, "Mauricio Faria de Oliveira" wrote: >The previous commit ("qla2xxx: fix invalid DMA access after command >aborts in PCI device remove") introduced a regression during an EEH >recovery, since the change to the qla2x00_abort_all_cmds() function

Re: [PATCH] qla2xxx: do not abort all commands in the adapter during EEH recovery

On 11/14/16, 1:26 PM, "Mauricio Faria de Oliveira" wrote: >The previous commit ("qla2xxx: fix invalid DMA access after command >aborts in PCI device remove") introduced a regression during an EEH >recovery, since the change to the qla2x00_abort_all_cmds() function >calls qla2xxx_eh_abort(),

Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O

On 11/7/16, 11:53 AM, "Mauricio Faria de Oliveira" wrote: >This patchset addresses a couple of errors that might happen during >PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), which prevent >the successful removal and re-addition of the adapter to the

Re: [PATCH 0/2] qla2xxx: fix errors in PCI device remove with ongoing I/O

On 11/7/16, 11:53 AM, "Mauricio Faria de Oliveira" wrote: >This patchset addresses a couple of errors that might happen during >PCI device remove (e.g., PCI hotplug, PowerVM DLPAR), which prevent >the successful removal and re-addition of the adapter to the system, >and cause an oops and/or