[PATCH v2] staging: vt6655: Rename two dimensional array declaration

Rename two dimensional array declaration to fix checkpatch warning: Avoid Camelcase and make the declaration more readable and understandable Signed-off-by: Madhumitha Prabakaran --- Changes in v2: Improve commit message --- drivers/staging/vt6655/baseband.c | 6 +++--- 1 file changed, 3

[PATCH] staging: vt6655: Fix camelcase

Fix checkpatch.pl - Avoid CamelCase: Signed-off-by: Madhumitha Prabakaran --- drivers/staging/vt6655/baseband.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/vt6655/baseband.c b/drivers/staging/vt6655/baseband.c index 1aa675241599..d89163299172

[PATCH v2] Staging: bcm2835-camera: Prefer kernel types

Fix the warning issued by checkpatch Prefer kernel type 'u32' over 'uint32_t'. Along with that include a blank line after a declaration to maintain Linux kernel coding style. Signed-off-by: Madhumitha Prabakaran --- Changes in v2: - Modified subject line - Included one more change in control.c

[PATCH] Staging: vc04_services: Fix kernel type 'u32' over 'uint32_t'

Fix the warning issued by checkpatch Prefer kernel type 'u32' over 'uint32_t' Signed-off-by: Madhumitha Prabakaran --- drivers/staging/vc04_services/bcm2835-camera/mmal-msg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835-camera

[PATCH] Staging: kpc2000: Cleanup in kpc_dma_transfer()

Remove unnecessary typecast in kzalloc function. In addition to that replace kzalloc(sizeof(*acd)) over kzalloc(sizeof(struct aio_cb_data)) to maintain Linux kernel style. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/kpc2000/kpc_dma/fileops.c | 2

[PATCH] Staging: speakup: Replace return type

Replace return type and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/speakup/i18n.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/speakup/i18n.c b/drivers/staging/speakup/i18n.c

[PATCH v3] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

Remove unnecessary variable from the function and make a corresponding change w.r.t the variable. In addition to that align the parameters in the parentheses to maintain Linux kernel coding style Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v2 - 1) Fix my

Re: [PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

On 04/20 :51, Greg KH wrote: > On Sat, Apr 20, 2019 at 11:56:44AM -0500, Madhumitha Prabakaran wrote: > > Remove unnecessary variable and replace return type. > > In addition to that align the function parameters with parentheses to > > maintain Linux coding style. >

[PATCH v2] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

Remove unnecessary variable and replace return type. In addition to that align the function parameters with parentheses to maintain Linux coding style. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v2 1) Fix my own error of removing function call from

Re: [PATCH] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

On 04/19 :49, Stefan Wahren wrote: > Hi Madhumitha, > > Am 19.04.19 um 23:23 schrieb Madhumitha Prabakaran: > > Remove unnecessary variable and replace return type. > > > > Issue suggested by Coccinelle. > > > > Signed-off-by: Madhumitha Prabakaran >

[PATCH] Staging: rtlwifi: Replace return type

Replace return type and remove the respective assignment. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtlwifi/core.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtlwifi/core.c b/drivers/staging/rtlwifi/core.c

[PATCH] Staging: vc04_services: Cleanup in ctrl_set_bitrate()

Remove unnecessary variable and replace return type. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/vc04_services/bcm2835-camera/controls.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/vc04_services/bcm2835

[PATCH] Staging: mt7621-mmc: Cleanup in msdc_app_cmd()

Remove unwanted variable and replace the respective return type. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/mt7621-mmc/sd.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging

[PATCH] Staging: rtl8723bs: core: Replace return types

Remove unwanted assignments and replace return types. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_sta_mgt.c b

Re: [greybus-dev] [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 04/17 :41, Alex Elder wrote: > On 4/16/19 5:13 PM, Madhumitha Prabakaran wrote: > > Fix a blank line after structure declarations. Also, convert > > macros into inline functions in order to maintain Linux kernel > > coding style based on which the inline function i

Re: [PATCH v2] Staging: greybus: Cleanup in greybus driver

On 04/17 :25, Greg KH wrote: > On Tue, Apr 16, 2019 at 05:13:18PM -0500, Madhumitha Prabakaran wrote: > > Fix a blank line after structure declarations. Also, convert > > macros into inline functions in order to maintain Linux kernel > > coding style based on whic

[PATCH v2] Staging: greybus: Cleanup in greybus driver

Fix a blank line after structure declarations. Also, convert macros into inline functions in order to maintain Linux kernel coding style based on which the inline function is preferable over the macro. Blank line fixes are suggested by checkpatch.pl Signed-off-by: Madhumitha Prabakaran Changes

[PATCH 3/3] Staging: rtl8723bs: Remove an unused struct tx_pending_t

Remove an unused struct tx_pending_t, as it is never used in kernel tree. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtl8723bs/include/ieee80211.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/ieee80211.h b/drivers/staging/rtl8723bs

[PATCH 1/3] Staging: rtl8723bs: Remove typedef in struct ieee_param_ex

Remove typedef in struct ieee_param_ex, as the struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/3] Staging: rtl8723bs: Remove typedef in struct ieee_param

Remove typedef in struct ieee_param, as the struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtl8723bs/include/ieee80211.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/3] Cleanups in rtl8723bs

Patch 1 and 2 remove typedef in structures. Patch 3 remove unused structure. Madhumitha Prabakaran (3): Staging: rtl8723bs: Remove typedef in struct ieee_param_ex Staging: rtl8723bs: Remove typedef in struct ieee_param Staging: rtl8723bs: Remove an unused struct tx_pending_t drivers

[PATCH v2] Staging: rtl8723bs: Remove typedef in struct sdio_data

Remove typedef in struct sdio_data and make the respective changes in associated files, as the struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Madhumitha Prabakaran --- Changes in v2: - Removed INTF_DATA data - Removed ifdef around

[PATCH] Staging: rtl8723bs: Remove typedef in struct sdio_data

Remove typedef in struct sdio_data and make the respective changes in associated files, as the struct that has elements that can reasonably be directly accessed should never be a typedef. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtl8723bs/hal/sdio_ops.c | 6 ++-- drivers

[PATCH] Staging: greybus: Cleanup in header file control.h

Fix a blank line after function/struct/union/enum declarations. Also, convert to_gb_control() macro into an inline function in order to maintain Linux kernel coding style based on which the inline function is preferable over the macro. Signed-off-by: Madhumitha Prabakaran --- drivers/staging

[PATCH] Staging: greybus: Fix spinlock_t definition without comment

Fix spinlock_t definition without comment. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/greybus/connection.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/greybus/connection.h b/drivers/staging/greybus/connection.h index 5ca3befc0636

[PATCH] Staging: olpc_dcon: Use WARN_ON() instead of BUG_ON()

Use WARN_ON() instead of BUG_ON(), as the WARN_ON() produces a backtrace without crashing the kernel. Issue found by checkpatch.pl. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/olpc_dcon/olpc_dcon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging

[PATCH] Staging: vc04_services: bcm2835-camera: Remove an exceptional

Remove an exceptional & on function names, otherwise they are used as pointers without &. Issue suggested using Coccinelle. Signed-off-by: Madhumitha Prabakaran --- .../vc04_services/bcm2835-camera/controls.c | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(

[PATCH] Staging: rtlwifi: Remove & on function name

Function name is otherwise used as pointers without &. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtlwifi/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtlwifi/pci.c b/drivers/staging/rtlwifi/p

[PATCH v3] Staging: rtlwifi: Cleanup crc16_ccitt()

crc16_ccitt() function does "BIT(0) << i" instead of "BIT(i)". Using !! is slightly shorter than "foo ? 1: 0" and remove unnecessary parentheses to make the code simple. Issue suggested by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v3: -

[PATCH v2] Staging: rtlwifi: Remove unwanted parentheses

Remove unwanted parentheses and use !! idiom in place of ternary operator to make code simple and more understandable. Signed-off-by: Madhumitha Prabakaran --- Changes in v2: - Changed commit log - Replaced ternary operator with !! idiom - Modified a BIT operator --- drivers/staging/rtlwifi

[PATCH] Staging: rtlwifi: Remove unwanted parentheses

Remove unwanted parentheses around right hand side of an assignment to make code better and more understandable. Issue found by Coccinelle. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/rtlwifi/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] Staging: mt7621-mmc: Use DIV_ROUND_UP in function msdc_set_mclk

Use DIV_ROUND_UP to make code simple and more understandable. Signed-off-by: Madhumitha Prabakaran --- drivers/staging/mt7621-mmc/sd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/mt7621-mmc/sd.c b/drivers/staging/mt7621-mmc/sd.c index 4b26ec896a96

[PATCH v3] Staging: gasket: Use DIV_ROUND_UP

Use DIV_ROUND_UP in-kernel function to make code simple and more understandable. Issue found using Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v3: - Included version no in patch Changes in v2: - Commit log modified --- drivers/staging/gasket/gasket_page_table.c | 5

[PATCH] Staging: gasket: Use DIV_ROUND_UP

Use DIV_ROUND_UP in-kernel function to make code simple and more understandable. Issue found using Coccinelle. Signed-off-by: Madhumitha Prabakaran --- Changes in v2: - Commit log modified --- drivers/staging/gasket/gasket_page_table.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions