>
> Thanks, I missed this.
>
> That's 80% my fault and 20% the fault of the usage of generic names
> SYMBOL/SIZE/OFFSET/LENGTH/CONFIG making it impossible to grep for them
> (and namespace conflicts quite possible).
>
> Can we get these #define's properly prefixed (e.g. KEXEC_SYMBOL etc.)
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please
(>d_lock);
> spin_unlock(_lock);
> }
> +
> + dput(dentry);
> }
> }
>
> Index: work/fs/sysfs/sysfs.h
> ===
> --- work.orig/fs/sysfs/sysfs.h
>
On Thu, May 17, 2007 at 07:49:31PM +0200, Tejun Heo wrote:
> Maneesh Soni wrote:
> > On Thu, May 17, 2007 at 05:04:23AM -0700, Greg KH wrote:
> >> On Wed, May 16, 2007 at 08:31:00PM +0200, Tejun Heo wrote:
> >>> sd->s_dentry updates made by dentry/inode reclam
!d_unhashed(dentry) && dentry->d_inode) {
> inode = dentry->d_inode;
> spin_lock(>i_lock);
> __iget(inode);
Ack'ed
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology La
;
spin_lock(inode-i_lock);
__iget(inode);
Ack'ed
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message
On Thu, May 17, 2007 at 07:49:31PM +0200, Tejun Heo wrote:
Maneesh Soni wrote:
On Thu, May 17, 2007 at 05:04:23AM -0700, Greg KH wrote:
On Wed, May 16, 2007 at 08:31:00PM +0200, Tejun Heo wrote:
sd-s_dentry updates made by dentry/inode reclamation are racy and can
lead to BUG() or oops
);
+extern spinlock_t sysfs_lock;
extern struct rw_semaphore sysfs_rename_sem;
extern struct super_block * sysfs_sb;
extern const struct file_operations sysfs_dir_operations;
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe
ot make it default. This might create boot issues with these
boxes.
> Maneesh, any other thoughts?
>
I actually wanted to investigate this oops but left it considering the
rework being done by Tejun. If this still make sense we can have some
more debug code stuffed there or get a cras
to investigate this oops but left it considering the
rework being done by Tejun. If this still make sense we can have some
more debug code stuffed there or get a crashdump (kdump) to get better
understanding of the race.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems
fff803a0c1a
Call Trace:
[] sysfs_hash_and_remove+0x7c/0xef
[] device_del+0x66/0x20a
[] netdev_run_todo+0xc6/0x225
[] :dummy:dummy_free_one+0x1c/0x2d
[] :dummy:dummy_cleanup_module+0xe/0x23
[] sys_delete_module+0x1b1/0x1e0
[] __up_write+0x21/0x10e
[] system_call+0x7e/0x83
Code: 41 ff 4c 24 4c 48 89
00
RIP [802935b4] simple_unlink+0x14/0x5c
RSP 81021b38be28
CR2: 004c
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body
t; > /debug/kprobes/snapshot_probe
Thus, the actual data collection code can reside in a separate
module or a systemtap script which provides very good post-processing
capabalities, and can be used without recompiling or rebooting the kernel.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology
, the actual data collection code can reside in a separate
module or a systemtap script which provides very good post-processing
capabalities, and can be used without recompiling or rebooting the kernel.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab
On Sat, Mar 24, 2007 at 08:35:35AM +0530, Maneesh Soni wrote:
> On Fri, Mar 23, 2007 at 12:43:27PM -0700, Ethan Solomita wrote:
> > I ran stress testing overnight and came up with a similar failure
> > (s_dentry == NULL) but in a different location. A NULL pointer
> >
On Sat, Mar 24, 2007 at 08:35:35AM +0530, Maneesh Soni wrote:
On Fri, Mar 23, 2007 at 12:43:27PM -0700, Ethan Solomita wrote:
I ran stress testing overnight and came up with a similar failure
(s_dentry == NULL) but in a different location. A NULL pointer
dereference happened
can review the VFS related
changes but please split the patches as you like but one possible way
could be as chunks dealing with changes related to
1. data structure changes
2. creation/removal of directories
3. creation/removal of files
4. creation/removal of symlinks
5. open/read/write/c
in a tight loop in
parallel with working (find, open/read/writhe/close/ file) on /sys,
makes a good enough testcase to hit races.
Thanks
Manesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line unsubscribe
has thankfully provided me
a crashdump.
In the dump, so far it looks like that we have a sysfs_dirent (corresponding to
file /sys/devices/system/cpu/cpu1/microcode/processor_flags), with a corrupted
s_dentry.
crash> struct sysfs_dirent c7721f2c
struct sysfs_dirent {
s_count = {
counter
looking at this problem and will update further.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
saw. And the second one should not occur as now we are not
using the s_dentry in sysfs_readdir().
Regards,
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
not occur as now we are not
using the s_dentry in sysfs_readdir().
Regards,
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Systems and Technology Lab,
Bangalore, India
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED
ated dentry, if there is one, else
it invokes iunique(). This can create a race situation, and crash while
accessing the dentry/inode in sysfs_readdir().
o The following patch always use i_unique() to get the inode number. This
is ok as sysfs doesnot have permanent inode numbering. It
This also avoids the now unnecessary s_dentry in sysfs_d_iput().
Signed-off-by: Maneesh Soni [EMAIL PROTECTED]
---
linux-2.6.21-rc4-git8-maneesh/fs/sysfs/dir.c |6 +-
1 files changed, 1 insertion(+), 5 deletions(-)
diff -puN fs/sysfs/dir.c~fix-sysfs-reclaim-race fs/sysfs/dir.c
--- linux
On Mon, Dec 04, 2006 at 11:06:41AM -0500, Alan Stern wrote:
> On Mon, 4 Dec 2006, Maneesh Soni wrote:
>
> > hmm, I guess Greg has to say the final word. The question is either to fail
> > the IO (-ENODEV) or fail the file removal (-EBUSY). If we are not going to
> > fa
On Mon, Dec 04, 2006 at 11:06:41AM -0500, Alan Stern wrote:
On Mon, 4 Dec 2006, Maneesh Soni wrote:
hmm, I guess Greg has to say the final word. The question is either to fail
the IO (-ENODEV) or fail the file removal (-EBUSY). If we are not going to
fail the removal then your patch
On Mon, Dec 04, 2006 at 07:38:00AM +0100, Oliver Neukum wrote:
> Am Montag, 4. Dezember 2006 05:43 schrieb Maneesh Soni:
> > On Fri, Dec 01, 2006 at 11:43:06PM +0100, Oliver Neukum wrote:
> > > Hi,
> > >
> > > Alan Stern has discovered a race in s
On Mon, Dec 04, 2006 at 07:38:00AM +0100, Oliver Neukum wrote:
Am Montag, 4. Dezember 2006 05:43 schrieb Maneesh Soni:
On Fri, Dec 01, 2006 at 11:43:06PM +0100, Oliver Neukum wrote:
Hi,
Alan Stern has discovered a race in sysfs, whereby driver callbacks could
be
called after
On Fri, Dec 01, 2006 at 11:43:06PM +0100, Oliver Neukum wrote:
> Hi,
>
> Alan Stern has discovered a race in sysfs, whereby driver callbacks could be
> called after sysfs_remove_file() has run. The attached patch should fix it.
>
> It introduces a new data structure acting as a collection of all
On Fri, Dec 01, 2006 at 11:43:06PM +0100, Oliver Neukum wrote:
Hi,
Alan Stern has discovered a race in sysfs, whereby driver callbacks could be
called after sysfs_remove_file() has run. The attached patch should fix it.
It introduces a new data structure acting as a collection of all
On Wed, Aug 10, 2005 at 03:35:53PM -0700, Greg KH wrote:
> On Wed, Aug 10, 2005 at 03:36:36PM +0530, Maneesh Soni wrote:
> > On Wed, Aug 10, 2005 at 04:26:51PM +1000, Keith Owens wrote:
> > > FYI, the intermittent free after use in sysfs is still there in
> > > 2.6.13-rc
f this helps or not.
Thanks
Maneesh
o following patch moves the code to free devt_attr from class_device_del()
to class_dev_release() which is called after the last reference to the
corresponding kobject() is gone. This allows to keep the devt_attr
alive while the corresponding sysfs file is op
moves the code to free devt_attr from class_device_del()
to class_dev_release() which is called after the last reference to the
corresponding kobject() is gone. This allows to keep the devt_attr
alive while the corresponding sysfs file is open.
Signed-off-by: Maneesh Soni [EMAIL PROTECTED
On Wed, Aug 10, 2005 at 03:35:53PM -0700, Greg KH wrote:
On Wed, Aug 10, 2005 at 03:36:36PM +0530, Maneesh Soni wrote:
On Wed, Aug 10, 2005 at 04:26:51PM +1000, Keith Owens wrote:
FYI, the intermittent free after use in sysfs is still there in
2.6.13-rc6.
The race condition
On Tue, Aug 02, 2005 at 01:05:50PM +1000, Keith Owens wrote:
> On Mon, 1 Aug 2005 12:03:21 -0700,
> Andrew Morton <[EMAIL PROTECTED]> wrote:
> >Keith Owens <[EMAIL PROTECTED]> wrote:
> >>
> >> On Sat, 30 Jul 2005 02:29:55 -0700,
> >> Andrew Morton <[EMAIL PROTECTED]> wrote:
> >> >Keith Owens
On Tue, Aug 02, 2005 at 01:05:50PM +1000, Keith Owens wrote:
On Mon, 1 Aug 2005 12:03:21 -0700,
Andrew Morton [EMAIL PROTECTED] wrote:
Keith Owens [EMAIL PROTECTED] wrote:
On Sat, 30 Jul 2005 02:29:55 -0700,
Andrew Morton [EMAIL PROTECTED] wrote:
Keith Owens [EMAIL PROTECTED] wrote:
evacuation from
cache.
Signed-off-by: Maneesh Soni <[EMAIL PROTECTED]>
---
linux-2.6.13-rc2-maneesh/fs/sysfs/file.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff -puN fs/sysfs/file.c~fix-sysfs_chmod_file fs/sysfs/file.c
--- linux-2.6.13-rc2/fs/sysfs/file
o sysfs_dirent's s_mode field should also be updated in sysfs_setattr(), else
there could be inconsistency in the two fields. s_mode is used while
->readdir so as not to bring in the inode to cache.
Signed-off-by: Maneesh Soni <[EMAIL PROTECTED]>
---
linux-2.6.13-rc2-maneesh
o sysfs_dirent's s_mode field should also be updated in sysfs_setattr(), else
there could be inconsistency in the two fields. s_mode is used while
-readdir so as not to bring in the inode to cache.
Signed-off-by: Maneesh Soni [EMAIL PROTECTED]
---
linux-2.6.13-rc2-maneesh/fs/sysfs
evacuation from
cache.
Signed-off-by: Maneesh Soni [EMAIL PROTECTED]
---
linux-2.6.13-rc2-maneesh/fs/sysfs/file.c | 18 ++
1 files changed, 10 insertions(+), 8 deletions(-)
diff -puN fs/sysfs/file.c~fix-sysfs_chmod_file fs/sysfs/file.c
--- linux-2.6.13-rc2/fs/sysfs/file.c~fix
on pre and post handlers are defined*/
> + struct kprobe comm_probe;
> +};
> +
> #ifdef CONFIG_KPROBES
> /* Locks kprobe: irq must be disabled */
> void lock_kprobes(void);
> @@ -109,6 +129,8 @@ int longjmp_break_handler(struct kprobe
> int register_jprobe(struct jp
Panchamukhi
Linux Technology Center
India Software Labs, IBM Bangalore
Ph: 91-80-25044636
[EMAIL PROTECTED]
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: [EMAIL PROTECTED]
Phone: 91-80-25044990
-
To unsubscribe from this list: send the line
s an interesting NUMA machine they can test it on I'd love to hear
> about it!
>
> This also includes a fix for the bug Maneesh found last week with
> GCC 3.3 generating a switch table in prom_init.c, which doesn't
> work.
>
I tried the patch and it works fine in my setup also.
they can test it on I'd love to hear
about it!
This also includes a fix for the bug Maneesh found last week with
GCC 3.3 generating a switch table in prom_init.c, which doesn't
work.
I tried the patch and it works fine in my setup also.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center
On Thu, Feb 24, 2005 at 06:05:45AM -0700, Eric W. Biederman wrote:
> Maneesh Soni <[EMAIL PROTECTED]> writes:
>
> > On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote:
> > > Vivek Goyal <[EMAIL PROTECTED]> wrote:
> > > >
> > >
o do it in user-space. We are evaluating both
the approaches and should arrive at the conclusion asap.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: [EMAIL PROTECTED]
Phone: 91-80-25044990
-
To unsubscribe from this list: send the line "
and should arrive at the conclusion asap.
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: [EMAIL PROTECTED]
Phone: 91-80-25044990
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED
On Thu, Feb 24, 2005 at 06:05:45AM -0700, Eric W. Biederman wrote:
Maneesh Soni [EMAIL PROTECTED] writes:
On Thu, Feb 24, 2005 at 01:13:12AM -0800, Andrew Morton wrote:
Vivek Goyal [EMAIL PROTECTED] wrote:
Kexec on panic is broken on i386 in 2.6.11-rc3-mm2 because of
re
mbol kallsyms_lookup_name
>
> How did you use it ? it looks like kallsyms_lookup_name()
> is not exported. Thats the reason why I was hardcoding addresses.
>
I checked the network packet logging patch, it also adds the
EXPORT_SYMBOL(kallsyms_lookup_name). :)
http://prdownloads.sour
the
EXPORT_SYMBOL(kallsyms_lookup_name). :)
http://prdownloads.sourceforge.net/dprobes/plog.tar.gz?download
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: [EMAIL PROTECTED]
Phone: 91-80-25044990
-
To unsubscribe from this list: send the line
> + buf->chan->cb->buf_full(buf);
Typo? statement after return !
Thanks
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM India Software Labs,
Bangalore, India
email: [EMAIL PROTECTED]
Phone: 91-80-25044990
-
To unsubscribe from this l
);
+ schedule_delayed_work(buf-wake_readers, 1);
+ }
+
+ if (unlikely(relay_buf_full(buf))) {
+ return 0;
+ buf-chan-cb-buf_full(buf);
Typo? statement after return !
Thanks
Maneesh
--
Maneesh Soni
Linux
copy-update mechanism
and FD management at "http://lse.sourceforge.net/locking/rclock.html; as
rclock-2.4.2-01.patch and files_struct_rcu-2.4.2-03.patch but we are working on
simpler interfaces. Also let me know if you need the patches for a different
2.4 kernel version.
Maneesh
--
Maneesh Soni
are working on
simpler interfaces. Also let me know if you need the patches for a different
2.4 kernel version.
Maneesh
--
Maneesh Soni
IBM Linux Technology Center,
IBM India Software Lab, Bangalore.
email: [EMAIL PROTECTED]
http://lse.sourceforge.net/locking/rclock.html
-
To unsubscribe from this list
o acquire the
same files->file_lock. And in those scenarios we should see considerable
performance improvement by using the files_struct patch as in the case of
"chat"benchmark.
Regards,
Maneesh
--
Maneesh Soni <[EMAIL PROTECTED]>
http://lse.sourceforge.net/locking/rclock.
set. That is when many
child processes share parent's files_struct and everybody tries to acquire the
same files-file_lock. And in those scenarios we should see considerable
performance improvement by using the files_struct patch as in the case of
"chat"benchmark.
Regards,
Maneesh
.html)
and by using synchronize_kernel() (from Rusty Russell, Keith Owens).
Regards,
Maneesh
--
Maneesh Soni <[EMAIL PROTECTED]>
http://lse.sourceforge.net/locking/rclock.html
IBM Linux Technology Center,
IBM Software L
://lse.sourceforge.net/locking/module_unloading-2.4.1-0.1.tar.gz
Thank you,
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM Software Labs, Bangalore, INDIA
Phone: +91-80-5262355 Extn: 2717
--
-
To unsubscribe from this list: send the line "unsubscribe
://lse.sourceforge.net/locking/module_unloading-2.4.1-0.1.tar.gz
Thank you,
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM Software Labs, Bangalore, INDIA
Phone: +91-80-5262355 Extn: 2717
--
-
To unsubscribe from this list: send the line "unsubscribe
ty Russell, Keith Owens).
Regards,
Maneesh
--
Maneesh Soni [EMAIL PROTECTED]
http://lse.sourceforge.net/locking/rclock.html
IBM Linux Technology Center,
IBM Software Lab, Bangalore, India
-
To unsubscribe from this
do some
profiling to look into this but it will be helpfull if you can tell me if there
is some known thing regarding this.
I am copying this to Andrew also, if he can also help. Also if you have some
dbench numbers from 2.4.x kernel, please let me have a look into those also.
Thank you,
Maneesh
--
Maneesh S
is some known thing regarding this.
I am copying this to Andrew also, if he can also help. Also if you have some
dbench numbers from 2.4.x kernel, please let me have a look into those also.
Thank you,
Maneesh
--
Maneesh Soni [EMAIL PROTECTED]
IBM Linux Technology Center,
IBM Software L
ml.
The config options required for this patch are CONFIG_RCLOCK and CONFIG_FD_RCU.
Regards,
Maneesh
--
Maneesh Soni <[EMAIL PROTECTED]>
IBM Linux Technology Center,
IBM Software Lab, Bangalore, India
---patch
diff
The config options required for this patch are CONFIG_RCLOCK and CONFIG_FD_RCU.
Regards,
Maneesh
--
Maneesh Soni [EMAIL PROTECTED]
IBM Linux Technology Center,
IBM Software Lab, Bangalore, India
---patch
diff -urN linu
Just a couple of points:
On Thu, Apr 05, 2001 at 10:36:10AM -0400, Tom Leete wrote:
[...]
> +spinlock_t proc_alloc_map_lock = RW_LOCK_UNLOCKED;
> +
Why not make this static?
Initializer should be SPIN_LOCK_UNLOCKED.
Maneesh Soni
Linux Technology Center,
IBM Bangalore.
-
To unsubscrib
Just a couple of points:
On Thu, Apr 05, 2001 at 10:36:10AM -0400, Tom Leete wrote:
[...]
+spinlock_t proc_alloc_map_lock = RW_LOCK_UNLOCKED;
+
Why not make this static?
Initializer should be SPIN_LOCK_UNLOCKED.
Maneesh Soni
Linux Technology Center,
IBM Bangalore.
-
To unsubscribe from
://lse.sourceforge.net/locking/module_unloading-2.4.1-0.1.tar.gz
Thank you,
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM Software Labs, Bangalore, INDIA
Phone: +91-80-5262355 Extn: 2717
--
-
To unsubscribe from this list: send the line "unsubscribe
://lse.sourceforge.net/locking/module_unloading-2.4.1-0.1.tar.gz
Thank you,
Maneesh
--
Maneesh Soni
Linux Technology Center,
IBM Software Labs, Bangalore, INDIA
Phone: +91-80-5262355 Extn: 2717
--
-
To unsubscribe from this list: send the line "unsubscribe
68 matches
Mail list logo
