ata *h,
{
int rel_port = -1, group_id;
struct alua_port_group *pg, *old_pg = NULL;
- bool pg_updated;
+ bool pg_updated = false;
unsigned long flags;
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com>
---
Manoj Kumar
, group_id;
struct alua_port_group *pg, *old_pg = NULL;
- bool pg_updated;
+ bool pg_updated = false;
unsigned long flags;
Reviewed-by: Manoj Kumar
---
Manoj Kumar
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
Add defines for mad version and mad os_type, and replace the magic
numbers in set_adapter_info() accordingly.
Signed-off-by: Tyrel Datwyler
---
drivers/scsi/ibmvscsi/ibmvscsi.c | 8
drivers
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are
off by one. They are currently defined as 0x06 and 0x07 respetively.
These values are defined in PAPR correctly as 0x05 and 0x06
Tyrel:
Thanks for incorporating the suggestions.
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a valid
command/response entry (0x80
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com>
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
The enum values for VIOSRP_LINUX_FORMAT and VIOSRP_INLINE_FORMAT are
off by one. They are currently defined as 0x06 and 0x07 respetively.
These values are defined in PAPR cor
Tyrel:
Thanks for incorporating the suggestions.
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com>
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com>
---
Manoj Kumar
On 2/10/2016 7:32 PM, Tyrel Datwyler wrote:
Add defines for mad version and mad os_type, and replace the magic
numbers in set_adapter_info() accordingly.
Signed-off-by: Tyrel Datwyler <tyr...@linux.vne
Yeah, I can see how that is confusing. Since, all three possible valid
crq message types have the first bit set I think this was originally a
cute hack to grab anything that was likely valid. Then in
ibmvscsi_handle_crq() we explicitly match the full header value in a
switch statement logging
Yeah, I can see how that is confusing. Since, all three possible valid
crq message types have the first bit set I think this was originally a
cute hack to grab anything that was likely valid. Then in
ibmvscsi_handle_crq() we explicitly match the full header value in a
switch statement logging
On 2/3/2016 5:28 PM, Tyrel Datwyler wrote:
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a valid
command/response entry (0x80), a valid initialization entry (0xC0),
and a transport event (0xFF). Define these values as enums
On 2/3/2016 5:28 PM, Tyrel Datwyler wrote:
The PAPR defines four valid header values for the first byte of a
CRQ message. Namely, an unused/empty message (0x00), a valid
command/response entry (0x80), a valid initialization entry (0xC0),
and a transport event (0xFF). Define these values as enums
Tim:
Reviewed-by: Manoj Kumar
---
Manoj Kumar
On 10/30/2015 1:22 PM, tim.gard...@canonical.com wrote:
From: Tim Gardner
drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied
to the left hand
Tim:
Reviewed-by: Manoj Kumar <ma...@linux.vnet.ibm.com>
---
Manoj Kumar
On 10/30/2015 1:22 PM, tim.gard...@canonical.com wrote:
From: Tim Gardner <tim.gard...@canonical.com>
drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_ma
Geliang:
Thanks for catching this.
- Manoj
Acked-by: Manoj Kumar
On 9/30/2015 9:55 PM, Geliang Tang wrote:
IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it.
Signed-off-by: Geliang Tang
---
drivers/scsi/cxlflash/superpipe.c | 4 ++--
1 file changed, 2 insertions(+), 2
Geliang:
Thanks for catching this.
- Manoj
Acked-by: Manoj Kumar <ma...@linux.vnet.ibm.com>
On 9/30/2015 9:55 PM, Geliang Tang wrote:
IS_ERR_OR_NULL already contain an unlikely compiler flag. Drop it.
Signed-off-by: Geliang Tang <geliangt...@163.com>
---
drivers/scsi/cxlflash
Hello,
While installing DCE 0.1.13 on RH Linux AS 2.1 Kernel 2.4.18-e.54smp
running on Itanium, the system hangs and becomes unbootable. It then has
to be started in single user mode, the dce rpm has to be removed and
then booted. This happens with kernel patch 52/54.
Has anyone faced a
Hello,
While installing DCE 0.1.13 on RH Linux AS 2.1 Kernel 2.4.18-e.54smp
running on Itanium, the system hangs and becomes unbootable. It then has
to be started in single user mode, the dce rpm has to be removed and
then booted. This happens with kernel patch 52/54.
Has anyone faced a
18 matches
Mail list logo
