Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-06-23 Thread Marc Zyngier
On Mon, 23 Jun 2025 11:31:32 +0100, Ganapatrao Kulkarni wrote: > > On 6/19/2025 5:15 PM, Marc Zyngier wrote: > >> > > >>> Also, running EL2 is the least of our worries, because that's pretty > >>> easy to deal with. It is running at EL1/0 when

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-06-19 Thread Marc Zyngier
On Thu, 19 Jun 2025 10:40:15 +0100, Ganapatrao Kulkarni wrote: > > > [Sorry for late reply] > > On 5/29/2025 5:18 PM, Marc Zyngier wrote: > > On Thu, 29 May 2025 11:29:58 +0100, > > Ganapatrao Kulkarni wrote: > >> > >> > >> Hi E

Re: [PATCH v2 0/3] mm/huge_memory: vmf_insert_folio_*() and vmf_insert_pfn_pud() fixes

2025-06-12 Thread Marc Herbert
suddenly SKIP on first invocation, ... instructions unclear or the tests >>>>> are shaky. This is how far I got: >>>> >>>> FWIW I had a similar experience, although I eventually got the FAIL cases >>>> below >>>> to pass. I forget exac

Re: [PATCH V3 2/2] KVM: selftests: Change MDSCR_EL1 register holding variables as uint64_t

2025-06-11 Thread Marc Zyngier
On Wed, 11 Jun 2025 04:45:10 +0100, Anshuman Khandual wrote: > > > > On 10/06/25 10:31 PM, Marc Zyngier wrote: > > On Tue, 10 Jun 2025 06:31:28 +0100, > > Anshuman Khandual wrote: > >> > >> Change MDSCR_EL1 register holding local variables as uin

Re: [PATCH V3 2/2] KVM: selftests: Change MDSCR_EL1 register holding variables as uint64_t

2025-06-10 Thread Marc Zyngier
On Tue, 10 Jun 2025 06:31:28 +0100, Anshuman Khandual wrote: > > Change MDSCR_EL1 register holding local variables as uint64_t that reflects > its true register width as well. > > Cc: Marc Zyngier > Cc: Oliver Upton > Cc: Joey Gouly > Cc: k...@vger.kernel.org >

Re: [PATCH v3 0/4] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-05 Thread Marc Zyngier
On Thu, 05 Jun 2025 12:36:09 +0200, Sebastian Ott wrote: > Some small fixes for arch_timer_edge_cases that I stumbled upon > while debugging failures for this selftest on ampere-one. > > Changes since v1: > * determine effective counter width based on suggestions from Marc >

Re: [PATCH v2 0/3] KVM: arm64: selftests: arch_timer_edge_cases fixes

2025-06-04 Thread Marc Zyngier
ures for this selftest on ampere-one. > >> > >> Changes since v1: modified patch 3 based on suggestions from Marc. > >> > >> I've done some tests with this on various machines - seems to be all > >> good, however on ampere-one I now hit this in 10% o

Re: [RFC PATCH v2 8/9] KVM: selftests: arm64: Extend kvm_page_table_test to run guest code in vEL2

2025-06-02 Thread Marc Zyngier
On Mon, 02 Jun 2025 07:04:07 +0100, Itaru Kitayama wrote: > > On Mon, May 12, 2025 at 03:52:50AM -0700, Ganapatrao Kulkarni wrote: > > Adding code to run guest_code in vEL2. > > NV is enabled using command line argument and it is disabled by default. > > > > NV is only enabled on ARM64, for othe

Re: [RFC PATCH v2 1/9] KVM: arm64: nv: selftests: Add support to run guest code in vEL2.

2025-05-29 Thread Marc Zyngier
On Mon, 12 May 2025 11:52:43 +0100, Ganapatrao Kulkarni wrote: > > This patch adds required changes to vcpu init to run a guest code > in vEL2 context and also adds NV specific helper functions. > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/testing/selftests/kvm/Makefile.kvm | 2 +

Re: [RFC PATCH v2 0/9] KVM: Enable Nested Virt selftests

2025-05-29 Thread Marc Zyngier
On Thu, 29 May 2025 11:29:58 +0100, Ganapatrao Kulkarni wrote: > > > Hi Eric, > > On 5/28/2025 6:58 PM, Eric Auger wrote: > > Hi Ganapatrao, > > > > On 5/12/25 12:52 PM, Ganapatrao Kulkarni wrote: > >> This patch series makes the selftest work with NV enabled. The guest code > >> is run in vEL

Re: [PATCH 3/3] KVM: arm64: selftests: arch_timer_edge_cases - workaround for AC03_CPU_14

2025-05-10 Thread Marc Zyngier
On Fri, 09 May 2025 15:33:12 +0100, Sebastian Ott wrote: > > arch_timer_edge_cases currently fails on ampere-one machines with > the following assertion failure: > > Test Assertion Failure > arm64/arch_timer_edge_cases.c:169: timer_condition == istatus > pid=11236 tid=11236 errno=4

Re: [PATCH] KVM: selftests: add test for SVE host corruption

2025-05-06 Thread Marc Zyngier
On Thu, 17 Apr 2025 00:32:49 +0100, Mark Brown wrote: > This test program, originally written by Mark Rutland and lightly modified > by me for upstream, verifies that we do not have the issues with host SVE > state being discarded which were fixed in > >fbc7e61195e2 ("KVM: arm64: Unconditional

Re: [PATCH] KVM: selftests: Fix a couple "prio" signedness bugs

2025-03-21 Thread Marc Zyngier
Hey Dan, On Fri, 21 Mar 2025 14:32:53 +, Dan Carpenter wrote: > > There is an assert which relies on "prio" to be signed. > > GUEST_ASSERT(prio >= 0); > > Change the type from uint32_t to int. > > Fixes: 728fcc46d2c2 ("KVM: selftests: aarch64: Add test for restoring active > IRQs")

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Marc Kleine-Budde
On 12.03.2025 14:28:10, Matias Ezequiel Vara Larsen wrote: > On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > > On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > > >

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Marc Kleine-Budde
inline, we need not only a proper Linux CAN driver, but also a proper VirtIO specification. This whole project is too big for me to do it as a collaborative effort. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengut

Re: [PATCH v15 01/15] platform-msi: Add msi_remove_device_irq_domain() in platform_device_msi_free_irqs_all()

2025-03-01 Thread Marc Zyngier
vice_msi_init_and_alloc_irqs() is the sole tool a platform device has to allocate platform MSIs, it would make sense for platform_device_msi_free_irqs_all() to teardown the MSI domain at the same time as the MSIs. This also avoids warnings and unexpected behaviours when a driver repeatedly allocates and frees MSIs." With that: Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH v15 00/15] PCI: EP: Add RC-to-EP doorbell with platform MSI controller

2025-03-01 Thread Marc Zyngier
On Thu, 20 Feb 2025 20:01:10 +, Frank Li wrote: > > On Tue, Feb 11, 2025 at 02:21:53PM -0500, Frank Li wrote: > > Thomas Gleixner and Marc Zyngier: > > Do you have any comments about irq/msi part? It certainly looks better and less invasive than the previous incar

Re: [PATCH v15 07/15] PCI: endpoint: pci-ep-msi: Add MSI address/data pair mutable check

2025-03-01 Thread Marc Zyngier
On Tue, 11 Feb 2025 19:22:00 +, Frank Li wrote: > > Some MSI controller change address/data pair when irq_set_affinity(). > Current PCI endpoint can't support this type MSI controller. So add flag > MSI_FLAG_MUTABLE in include/linux/msi.h and check it when allocate > doorbell. > > Signed-off

Re: [PATCH v15 04/15] irqchip/gic-v3-its: Add support for device tree msi-map and msi-mask

2025-03-01 Thread Marc Zyngier
On Tue, 11 Feb 2025 19:21:57 +, Frank Li wrote: > > Some platform devices create child devices dynamically and require the > parent device's msi-map to map device IDs to actual sideband information. > > A typical use case is using ITS as a PCIe Endpoint Controller(EPC)'s > doorbell function,

Re: [PATCH v15 02/15] irqdomain: Add IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and irq_domain_is_msi_immutable()

2025-03-01 Thread Marc Zyngier
On Tue, 11 Feb 2025 19:21:55 +, Frank Li wrote: > > Add the flag IRQ_DOMAIN_FLAG_MSI_IMMUTABLE and the API function > irq_domain_is_msi_immutable() to check if the MSI controller retains an > immutable address/data pair during irq_set_affinity(). > > Ensure compatibility with MSI users like

Re: kvm: nVHE hyp panic at: __kvm_nvhe_kvm_hyp_handle_sysre

2025-02-12 Thread Marc Zyngier
On Wed, 12 Feb 2025 11:41:38 +, Dan Carpenter wrote: > > On Tue, Feb 11, 2025 at 11:36:31AM +, Marc Zyngier wrote: > > For the crash at hand, which clearly shows nVHE, can you report > > whether the following hack fixes it for you? > > > > M. >

Re: kvm: nVHE hyp panic at: __kvm_nvhe_kvm_hyp_handle_sysre

2025-02-11 Thread Marc Zyngier
On Tue, 11 Feb 2025 11:24:06 +, Naresh Kamboju wrote: > > Regression on rk3399-rock-pi-4b while running kvm-unit-tests with > nvhe, protected and vhe mode with virtualization enabled. I do not buy this. RK3399 only has ARMv8.0 cores, which by definition do not have VHE. > > First seen on n

Re: [RFC PATCH 1/2] KVM: arm64: nv: selftests: Add guest hypervisor test

2025-02-07 Thread Marc Zyngier
On Fri, 07 Feb 2025 13:26:41 +, Ganapatrao Kulkarni wrote: > > >> + if (is_vcpu_nested(vcpu)) { > >> + vcpu_set_reg(vcpu, KVM_ARM64_SYS_REG(SYS_CPTR_EL2), fpen); > >> + vcpu_set_reg(vcpu, KVM_ARM64_SYS_REG(SYS_SCTLR_EL2), sctlr_el1); > >> + vcpu_set_reg(vcpu, KVM_A

Re: [RFC PATCH 1/2] KVM: arm64: nv: selftests: Add guest hypervisor test

2025-02-06 Thread Marc Zyngier
On Thu, 06 Feb 2025 16:41:19 +, Ganapatrao Kulkarni wrote: > > This patch adds the required changes to init vcpu in vEL2 context. > Also adds a KVM selftest to execute guest code as a guest hypervisor(L1). > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/testing/selftests/kvm/Makefile.

Re: [RFC PATCH 2/2] KVM: arm64: nv: selftests: Access VNCR mapped registers

2025-02-06 Thread Marc Zyngier
On Thu, 06 Feb 2025 16:41:20 +, Ganapatrao Kulkarni wrote: > > With NV2 enabled, some of the EL1/EL2/EL12 register accesses are > transformed to memory accesses. This test code accesses all those > registers in guest code to validate that they are not trapped to L0. > Traps to L0 are invisib

Re: [PATCH bpf-next v7 4/5] bpf: verifier: Support eliding map lookup nullness

2025-01-30 Thread Marc Hartmayer
thanks for the fix! I’ve tested the fix and it fixed the problem. Tested-by: Marc Hartmayer […snip…]

Re: [RFC PATCH 1/4] perf: arm_pmuv3: Introduce module param to partition the PMU

2025-01-29 Thread Marc Zyngier
On Tue, 28 Jan 2025 22:08:27 +, Colton Lewis wrote: > > >> + bitmap_set(cpu_pmu->cntr_mask, 0, pmcr_n); > >> + > >> + if (reserved_guest_counters > 0 && reserved_guest_counters < pmcr_n) { > >> + cpu_pmu->hpmn = reserved_guest_counters; > >> + cpu_pmu->partitioned = true;

Re: [RFC PATCH 1/4] perf: arm_pmuv3: Introduce module param to partition the PMU

2025-01-28 Thread Marc Zyngier
On Mon, 27 Jan 2025 22:20:27 +, Colton Lewis wrote: > > For PMUv3, the register MDCR_EL2.HPMN partitiones the PMU counters > into two ranges where counters 0..HPMN-1 are accessible by EL1 and, if > allowed, EL0 while counters HPMN..N are only accessible by EL2. > > Introduce a module paramet

Re: [PATCH] KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable

2024-12-17 Thread Marc Zyngier
On Tue, 17 Dec 2024 15:10:28 +, Mark Brown wrote: > > [1 ] > On Tue, Dec 17, 2024 at 01:54:39PM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > The selftests are shipped as part of the kernel source and frequently > > > used for testing the ker

Re: [PATCH] KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable

2024-12-17 Thread Marc Zyngier
On Tue, 17 Dec 2024 13:12:12 +, Mark Brown wrote: > > [1 ] > On Tue, Dec 17, 2024 at 08:30:37AM +0000, Marc Zyngier wrote: > > Mark Brown wrote: > > > > Fixes: 03c7527e97f7 ("KVM: arm64: Do not allow ID_AA64MMFR0_EL1.ASIDbits > > > to be overridde

Re: [PATCH] KVM: arm64: Fix set_id_regs selftest for ASIDBITS becoming unwritable

2024-12-17 Thread Marc Zyngier
> - REG_FTR_BITS(FTR_LOWER_SAFE, ID_AA64MMFR0_EL1, ASIDBITS, 0), > REG_FTR_BITS(FTR_LOWER_SAFE, ID_AA64MMFR0_EL1, PARANGE, 0), > REG_FTR_END, > }; > With the Fixes: line dropped, Acked-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH net-next v3 4/9] net: af_can: do not leave a dangling sk pointer in can_create()

2024-10-14 Thread Marc Kleine-Budde
d-off-by: Ignat Korchagin > Reviewed-by: Vincent Mailhol Reviewed-by: Marc Kleine-Budde regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung Nürnberg | Phone: +49-5121-206917

Re: [PATCH 1/1] s390/virtio_ccw: fix dma_parm pointer not set up

2024-10-08 Thread Marc Hartmayer
gt; for the best! > > Signed-off-by: Halil Pasic > Fixes: 334304ac2bac ("dma-mapping: don't return errors from > dma_set_max_seg_size") > Reported-by: "Marc Hartmayer" > Closes: https://bugzilla.linux.ibm.com/show_bug.cgi?id=209131 I guess, this line can

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-13 Thread Marc Zyngier
On Fri, 12 Apr 2024 15:54:22 +0100, Sean Christopherson wrote: > > On Fri, Apr 12, 2024, Marc Zyngier wrote: > > On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > > Also, if you're

Re: [PATCH 1/4] KVM: delete .change_pte MMU notifier callback

2024-04-12 Thread Marc Zyngier
On Fri, 12 Apr 2024 11:44:09 +0100, Will Deacon wrote: > > On Fri, Apr 05, 2024 at 07:58:12AM -0400, Paolo Bonzini wrote: > > diff --git a/arch/arm64/kvm/mmu.c b/arch/arm64/kvm/mmu.c > > index dc04bc767865..ff17849be9f4 100644 > > --- a/arch/arm64/kvm/mmu.c > > +++ b/arch/arm64/kvm/mmu.c > > @@ -

Re: [PATCH 0/4] KVM, mm: remove the .change_pte() MMU notifier and set_pte_at_notify()

2024-04-12 Thread Marc Zyngier
7 +--- > mm/migrate_device.c | 8 +--- > mm/mmu_notifier.c | 17 - > virt/kvm/kvm_main.c | 50 + > 26 files changed, 10 insertions(+), 411 deletions(-) > Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH v3 6/7] KVM: arm64: Participate in bitmap-based PTE aging

2024-04-02 Thread Marc Zyngier
On Tue, 02 Apr 2024 05:06:56 +0100, Yu Zhao wrote: > > On Mon, Apr 1, 2024 at 7:30 PM James Houghton wrote: > > > > Participate in bitmap-based aging while grabbing the KVM MMU lock for > > reading. Ideally we wouldn't need to grab this lock at all, but that > > would require a more intrustive a

Re: [PATCH] irqchip: Add support for IDT 79rc3243x interrupt controller

2021-04-20 Thread Marc Zyngier
On 2021-04-20 13:34, Thomas Bogendoerfer wrote: IDT 79rc3243x SoCs have rather simple interrupt controllers connected to the MIPS CPU interrupt lines. Each of them has room for up to 32 interrupts. Signed-off-by: Thomas Bogendoerfer Is there a DT binding for this irqchip? The code looks fine,

Re: [PATCH] ptp: Don't print an error if ptp_kvm is not supported

2021-04-20 Thread Marc Zyngier
On Tue, 20 Apr 2021 14:24:19 +0100, Jon Hunter wrote: > Commit 300bb1fe7671 ("ptp: arm/arm64: Enable ptp_kvm for arm/arm64") > enable ptp_kvm support for ARM platforms and for any ARM platform that > does not support this, the following error message is displayed ... > > ERR KERN fail to initiali

[PATCH] PCI: tegra: Restore MSI enable state on resume

2021-04-20 Thread Marc Zyngier
When going into suspend, the Tegra MSI controller loses its state. Restore the MSI allocation on resume so that PCI devices are usable again. Reported-by: Jon Hunter Tested-by: Jon Hunter Fixes: 973a28677e39 ("PCI: tegra: Convert to MSI domains") Signed-off-by: Marc Zyngier C

Re: [PATCH v10 5/7] PCI: mediatek-gen3: Add MSI support

2021-04-20 Thread Marc Zyngier
q; > > + > > + hwirq = data->hwirq % PCIE_MSI_IRQS_PER_SET; > > + > > + msg->address_hi = upper_32_bits(msi_set->msg_addr); > > + msg->address_lo = lower_32_bits(msi_set->msg_addr); > > + msg->data = hwirq; > > + dev_dbg(port->de

Re: [PATCH] genirq/irqaction: Move dev_id and percpu_dev_id in a union

2021-04-20 Thread Marc Zyngier
On Mon, 19 Apr 2021 00:44:14 +0100, Thomas Gleixner wrote: > > On Sat, Apr 10 2021 at 13:00, Marc Zyngier wrote: > > dev_id and percpu_dev_id are mutually exclusive in struct irqaction, > > as they conceptually represent the same thing, only in a per-cpu > > fashion. &

Re: [PATCH v2] irqchip/xilinx: Expose Kconfig option for Zynq/ZynqMP

2021-04-20 Thread Marc Zyngier
On Mon, 19 Apr 2021 20:42:45 +0100, Robert Hancock wrote: > > Previously the XILINX_INTC config option was hidden and only > auto-selected on the MicroBlaze platform. However, this IP can also be > used on the Zynq and ZynqMP platforms as a secondary cascaded > controller. Allow this option to be

Re: [PATCH v19 6/7] KVM: arm64: Add support for the KVM PTP service

2021-04-17 Thread Marc Zyngier
On Sat, 17 Apr 2021 09:59:39 +0100, Zenghui Yu wrote: > > On 2021/3/30 22:54, Marc Zyngier wrote: > > +PTP_KVM support for arm/arm64 > > += > > + > > +PTP_KVM is used for high precision time sync between host and guests. > > +It r

Re: [PATCH v19 7/7] ptp: arm/arm64: Enable ptp_kvm for arm/arm64

2021-04-17 Thread Marc Zyngier
On Sat, 17 Apr 2021 09:42:37 +0100, Zenghui Yu wrote: > > On 2021/3/30 22:54, Marc Zyngier wrote: > > +int kvm_arch_ptp_init(void) > > +{ > > + int ret; > > + > > + ret = kvm_arm_hyp_service_available(ARM_SMCCC_KVM_FUNC_PTP); > > + if (ret <= 0)

[tip: timers/core] time/timecounter: Mark 1st argument of timecounter_cyc2time() as const

2021-04-16 Thread tip-bot2 for Marc Kleine-Budde
The following commit has been merged into the timers/core branch of tip: Commit-ID: 07ff4aed015c564d03fd518d2fb54e5e6948903c Gitweb: https://git.kernel.org/tip/07ff4aed015c564d03fd518d2fb54e5e6948903c Author:Marc Kleine-Budde AuthorDate:Wed, 03 Mar 2021 11:35:44 +01:00

Re: [PATCH] irqchip/xilinx: Expose Kconfig option

2021-04-16 Thread Marc Zyngier
On Fri, 16 Apr 2021 17:05:49 +0100, Robert Hancock wrote: > > On Fri, 2021-04-16 at 14:41 +0100, Marc Zyngier wrote: > > On Fri, 16 Apr 2021 00:32:50 +0100, > > Robert Hancock wrote: > > > Previously the XILINX_INTC config option was hidden and only > >

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-16 Thread Marc Zyngier
On Fri, 16 Apr 2021 02:13:38 +0100, Kever Yang wrote: > > Hi Marc, > > On 2021/4/15 下午4:11, Marc Zyngier wrote: > > Hi Kever, > > > > On Thu, 15 Apr 2021 08:24:33 +0100, > > Kever Yang wrote: > >> Hi Marc, Peter, > >> > >>    

Re: [PATCH v4 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-16 Thread Marc Zyngier
On Thu, 15 Apr 2021 15:08:09 +0100, Keqian Zhu wrote: > > Hi Marc, > > On 2021/4/15 22:03, Keqian Zhu wrote: > > The MMIO region of a device maybe huge (GB level), try to use > > block mapping in stage2 to speedup both map and unmap. > > > > Compared

Re: [RFC PATCH] irqchip/gic-v3: Do not enable irqs when handling spurious interrups

2021-04-16 Thread Marc Zyngier
[+ Mark] On Fri, 16 Apr 2021 07:22:17 +0100, He Ying wrote: > > We found this problem in our kernel src tree: > > [ 14.816231] [ cut here ] > [ 14.816231] kernel BUG at irq.c:99! > [ 14.816232] Internal error: Oops - BUG: 0 [#1] SMP > [ 14.816232] Process swapper

Re: [PATCH] irqchip/xilinx: Expose Kconfig option

2021-04-16 Thread Marc Zyngier
On Fri, 16 Apr 2021 00:32:50 +0100, Robert Hancock wrote: > > Previously the XILINX_INTC config option was hidden and only > auto-selected on the MicroBlaze platform. However, this IP can also be > used on other platforms. Allow this option to be user-enabled. > > Signed-off-by: Robert Hancock

Re: [PATCH v2 0/2] MCAN: Add support for implementing transceiver as a phy

2021-04-16 Thread Marc Kleine-Budde
patch hits mainline. Then I'll merge this into linux-can-next. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hil

Re: [PATCH v5 0/3] CAN TRANSCEIVER: Add support for CAN transceivers

2021-04-16 Thread Marc Kleine-Budde
-q1.pdf > > Aswath Govindraju (3): > phy: core: Reword the comment specifying the units of max_link_rate to > be Mbps > dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers > phy: phy-can-transceiver: Add support for generic CAN transceiver > driver &

Re: [PATCH v4 3/3] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-16 Thread Marc Kleine-Budde
;CAN transceiver PHY" > + select GENERIC_PHY > + help > + This option enables support for CAN transceivers as a PHY. This > + driver provides function for putting the transceivers in various > + functional modes using gpios and sets the a

Re: [PATCH v2 2/2] can: m_can: Add support for transceiver as phy

2021-04-15 Thread Marc Kleine-Budde
quot;, ret); please use dev_err_probe(), as the probing might be deferred and this is not an error. > + return ret; > + } > + > + if (transceiver) > + priv->cdev.can.bitrate_max = transceiver->attrs.max_link_rate; > + >

Re: [PATCH v3 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-15 Thread Marc Zyngier
On Thu, 15 Apr 2021 12:26:26 +0100, Keqian Zhu wrote: > > Hi Marc, > > On 2021/4/15 18:23, Marc Zyngier wrote: > > On Thu, 15 Apr 2021 03:20:52 +0100, > > Keqian Zhu wrote: > >> > >> Hi Marc, > >> > >> On 2021/4/14 17:05, Marc Zyngie

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 20:42:36, Vincent MAILHOL wrote: > On Thu. 15 Apr 2021 at 18:04, Marc Kleine-Budde wrote: > > On 15.04.2021 09:47:23, Colin King wrote: > > > From: Colin Ian King > > > > > > There is an assignment to *netdev tha

Re: [PATCH][next] can: etas_es58x: Fix a couple of spelling mistakes

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 12:30:50, Colin King wrote: > From: Colin Ian King > > There are spelling mistakes in netdev_dbg and netdev_dbg messages, > fix these. > > Signed-off-by: Colin Ian King Applied to linux-can-next/testing. Tnx, Marc -- Pengutronix e.K. |

Re: [PATCH 3/5] s390: Get rid of oprofile leftovers

2021-04-15 Thread Marc Zyngier
On Thu, 15 Apr 2021 11:38:52 +0100, Heiko Carstens wrote: > > On Wed, Apr 14, 2021 at 02:44:07PM +0100, Marc Zyngier wrote: > > perf_pmu_name() and perf_num_counters() are unused. Drop them. > > > > Signed-off-by: Marc Zyngier > > --- > >

Re: [PATCH v3 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-15 Thread Marc Zyngier
On Thu, 15 Apr 2021 03:20:52 +0100, Keqian Zhu wrote: > > Hi Marc, > > On 2021/4/14 17:05, Marc Zyngier wrote: > > + Santosh, who found some interesting bugs in that area before. > > > > On Wed, 14 Apr 2021 07:51:09 +0100, > > Keqian Zhu wrote: > >>

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Marc Kleine-Budde
cumentation/devicetree/bindings/phy folder. Also, > scripts/get_maintainer.pl is giving the names of maintainers after > reading the yaml files too. Nice! Clever script. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.p

Re: [PATCH][next] can: etas_es58x: Fix missing null check on netdev pointer

2021-04-15 Thread Marc Kleine-Budde
verity: ("Dereference before null check") > Fixes: 8537257874e9 ("can: etas_es58x: add core support for ETAS ES58X CAN > USB interfaces") > Signed-off-by: Colin Ian King Looks good. Applied to linux-can-next/testing. Tnx, Marc -- Pengutronix e.K.

Re: [PATCH][next] can: etas_es58x: Fix potential null pointer dereference on pointer cf

2021-04-15 Thread Marc Kleine-Budde
net-next/master https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/?id=e2b1e4b532abdd39bfb7313146153815e370d60c Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertr

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-15 Thread Marc Zyngier
Hi Kever, On Thu, 15 Apr 2021 08:24:33 +0100, Kever Yang wrote: > > Hi Marc, Peter, > >     RK356x GIC has two issues: > > 1. GIC only support 32bit address while rk356x supports 8GB DDR SDRAM, > so we use ZONE_DMA32 to fix this issue; What transactions does this affe

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-15 Thread Marc Kleine-Budde
On 15.04.2021 11:57:20, Aswath Govindraju wrote: > Hi Marc, > > On 14/04/21 9:03 pm, Marc Kleine-Budde wrote: > > On 14.04.2021 19:35:18, Aswath Govindraju wrote: > >> Add binding documentation for TI TCAN104x CAN transceivers. > >> >

Re: [PATCH v2 0/6] CAN TRANSCEIVER: Add support for CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
t CAN transceivers. > > Patches 5 & 6 add support for implementing the transceiver as a phy of > m_can_platform driver. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretun

Re: [PATCH v2 4/6] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-14 Thread Marc Kleine-Budde
\ > broadcom/\ I'm not sure how the phy framework handles this, but I assume it's alphabetically sorted, too. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengu

Re: [PATCH v2 4/6] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-14 Thread Marc Kleine-Budde
/devicetree/bindings/net/can/ > F: Documentation/devicetree/bindings/phy/ti,tcan104x-can.yaml > +F: drivers/phy/phy-can-transceiver.c > F: drivers/net/can/ please keep this alphabetically sorted Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embed

Re: [PATCH v2 3/6] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
iption: > + max bit rate supported in bps > +minimum: 1 > + > +required: > + - compatible > + - '#phy-cells' > + > +additionalProperties: false > + > +examples: > + - | > +#include > + > +transceiver1: tcan104x-phy { > + co

Re: [PATCH v2 6/6] can: m_can: Add support for transceiver as phy

2021-04-14 Thread Marc Kleine-Budde
t; + else > + priv->cdev.can.bitrate_max = transceiver->attrs.max_link_rate; > + > priv->base = addr; > priv->mram_base = mram_addr; > > @@ -108,6 +122,7 @@ static int m_can_plat_probe(struct platform_device *pdev) > mcan_class->pm_cl

[PATCH 5/5] perf: Get rid of oprofile leftovers

2021-04-14 Thread Marc Zyngier
perf_pmu_name() and perf_num_counters() are unused. Drop them. Signed-off-by: Marc Zyngier --- include/linux/perf_event.h | 2 -- kernel/events/core.c | 5 - 2 files changed, 7 deletions(-) diff --git a/include/linux/perf_event.h b/include/linux/perf_event.h index 3f7f89ea5e51

[PATCH 2/5] arm64: Get rid of oprofile leftovers

2021-04-14 Thread Marc Zyngier
perf_pmu_name() and perf_num_counters() are now unused. Drop them. Signed-off-by: Marc Zyngier --- drivers/perf/arm_pmu.c | 30 -- 1 file changed, 30 deletions(-) diff --git a/drivers/perf/arm_pmu.c b/drivers/perf/arm_pmu.c index 2d10d84fb79c..d4f7f1f9cc77 100644

[PATCH 4/5] sh: Get rid of oprofile leftovers

2021-04-14 Thread Marc Zyngier
perf_pmu_name() and perf_num_counters() are unused. Drop them. Signed-off-by: Marc Zyngier --- arch/sh/kernel/perf_event.c | 18 -- 1 file changed, 18 deletions(-) diff --git a/arch/sh/kernel/perf_event.c b/arch/sh/kernel/perf_event.c index 445e3ece4c23..1d2507f22437 100644

[PATCH 3/5] s390: Get rid of oprofile leftovers

2021-04-14 Thread Marc Zyngier
perf_pmu_name() and perf_num_counters() are unused. Drop them. Signed-off-by: Marc Zyngier --- arch/s390/kernel/perf_event.c | 21 - 1 file changed, 21 deletions(-) diff --git a/arch/s390/kernel/perf_event.c b/arch/s390/kernel/perf_event.c index 1e75cc983546..ea7729bebaa0

[PATCH 1/5] KVM: arm64: Divorce the perf code from oprofile helpers

2021-04-14 Thread Marc Zyngier
KVM/arm64 is the sole user of perf_num_counters(), and really could do without it. Stop using the obsolete API by relying on the existing probing code. Signed-off-by: Marc Zyngier --- arch/arm64/kvm/perf.c | 7 +-- arch/arm64/kvm/pmu-emul.c | 2 +- include/kvm/arm_pmu.h | 4 3

[PATCH 0/5] perf: oprofile spring cleanup

2021-04-14 Thread Marc Zyngier
architectures but arm64, s390 and sh (plus a bit of cruft in the core perf code). With KVM fixed, perf_num_counters() and perf_pmu_name() are finally gone. Thanks, M. [1] https://lore.kernel.org/lkml/20210215050618.hgftdmfmslbdrg3j@vireshk-i7 Marc Zyngier (5): KVM: arm64: Divorce the perf

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-14 Thread Marc Zyngier
On Wed, 14 Apr 2021 12:41:20 +0100, Peter Geis wrote: > > On Tue, Apr 13, 2021 at 11:51 AM Marc Zyngier wrote: > > > > On Tue, 13 Apr 2021 16:03:51 +0100, > > Peter Geis wrote: > > > > > > On Tue, Apr 13, 2021 at 10:01 AM Marc Zyngier wrote: > >

Re: arch/arm64/kvm/perf.c:58:36: error: implicit declaration of function 'perf_num_counters'

2021-04-14 Thread Marc Zyngier
On Tue, 13 Apr 2021 21:00:57 +0100, Nathan Chancellor wrote: [...] > I just ran into this again. It is not a clang specific issue, it > reproduces quite easily with arm64 defconfig minus CONFIG_PERF_EVENTS > and gcc 10.3.0: > > arch/arm64/kvm/perf.c: In function 'kvm_perf_init': > arch/arm64/kv

Re: [PATCH v3 2/2] kvm/arm64: Try stage2 block mapping for host device MMIO

2021-04-14 Thread Marc Zyngier
+ Santosh, who found some interesting bugs in that area before. On Wed, 14 Apr 2021 07:51:09 +0100, Keqian Zhu wrote: > > The MMIO region of a device maybe huge (GB level), try to use > block mapping in stage2 to speedup both map and unmap. > > Compared to normal memory mapping, we should consi

Re: [GIT PULL] coresight: Fixes for ETE and TRBE

2021-04-14 Thread Marc Zyngier
On Tue, 13 Apr 2021 20:45:00 +0100, Mathieu Poirier wrote: > > On Tue, 13 Apr 2021 at 10:52, Marc Zyngier wrote: > > > > Hi Mathieu, > > > > On Tue, 13 Apr 2021 17:19:52 +0100, > > Mathieu Poirier wrote: > >

Re: [PATCH 0/4] CAN TRANSCEIVER: Add support for CAN transceivers

2021-04-14 Thread Marc Kleine-Budde
add it CAN NETWORK DRIVERS. regards, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Embedded Linux | https://www.pengutronix.de | Vertretung West/Dortmund | Phone: +49-231-2826-924 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-555

Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-13 Thread Marc Kleine-Budde
On 14.04.2021 11:54:36, Aswath Govindraju wrote: > Hi Marc, > > On 12/04/21 3:48 pm, Marc Kleine-Budde wrote: > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > >> The driver adds support for generic CAN transceivers. Currently > >> the modes supported by this dr

Re: [GIT PULL] coresight: Fixes for ETE and TRBE

2021-04-13 Thread Marc Zyngier
er_coresight_cpu() (2021-04-13 09:46:27 -0600) > > ---- > Hi Marc, > > Please consider these two patches, they are ETE/TRBE fixes found by bots. > > Let me know if you want me to rebase on your next branch and send the > pull r

Re: [PATCH v6 00/30] Network fs helper library & fscache kiocb API

2021-04-13 Thread Marc Dionne
| 50 +- > include/linux/netfs.h | 234 > include/linux/pagemap.h | 41 +- > include/net/af_rxrpc.h |2 +- > include/trace/events/afs.h | 74 +- > include/trace/events/netfs.h

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-13 Thread Marc Zyngier
On Tue, 13 Apr 2021 16:03:51 +0100, Peter Geis wrote: > > On Tue, Apr 13, 2021 at 10:01 AM Marc Zyngier wrote: [...] > > What happens if you hack all the allocations to happen in the low 4GB > > of the PA space? > > It seems to work correctly. > The downstream hack

Re: [PATCH] KVM: arm/arm64: Fix KVM_VGIC_V3_ADDR_TYPE_REDIST read

2021-04-13 Thread Marc Zyngier
On Mon, 12 Apr 2021 17:00:34 +0200, Eric Auger wrote: > When reading the base address of the a REDIST region > through KVM_VGIC_V3_ADDR_TYPE_REDIST we expect the > redistributor region list to be populated with a single > element. > > However list_first_entry() expects the list to be non empty. >

Re: [PATCH] can: etas_es58x: fix null pointer dereference when handling error frames

2021-04-13 Thread Marc Kleine-Budde
USB interfaces") > Reported-by: Arunachalam Santhanam > Signed-off-by: Vincent Mailhol > --- > Hi Marc, > > I am really sorry, but I was just notified about this issue litteraly > a few minutes after you send the pull request to net-next. :D > I am not sure how to procee

Re: [PATCH] Fixed: ARM64 GIC ITS could not resume from suspend

2021-04-13 Thread Marc Zyngier
On Tue, 13 Apr 2021 07:40:10 +0100, 414777...@qq.com wrote: > > From: Mengguang Peng > > - After ITS suspend, in the ATF(arm-trusted-firmware), > gicv3_rdistif_init_restore() just restore GICR_CTLR.Enable_LPIs bit > of boot cpu. > > - In its_cpu_init_lpis() of kernel, gic_data_rdist()->lpi_

Re: [RFC] ITS fails to allocate on rk3568/rk3566

2021-04-13 Thread Marc Zyngier
Hi Peter, On Mon, 12 Apr 2021 21:49:59 +0100, Peter Geis wrote: > > Good Afternoon, > > I am assisting with early bringup of the rk3566 based quartz64 > development board for mainline linux. > I've encountered a few issues with allocating ITS on their version of > the GIC-V3. > The first issue

Re: [RFC v4 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-13 Thread Marc Zyngier
On Tue, 13 Apr 2021 01:07:23 +0100, Andrew Lunn wrote: > > > > > +static void > > > > +mt7530_setup_mdio_irq(struct mt7530_priv *priv) > > > > +{ > > > > + struct dsa_switch *ds = priv->ds; > > > > + int p; > > > > + > > > > + for (p = 0; p < MT7530_NUM_PHYS; p++) { > > > > +

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-13 Thread Marc Kleine-Budde
On 12.04.2021 12:49:56, Rob Herring wrote: > On Mon, Apr 12, 2021 at 12:19:30PM +0200, Marc Kleine-Budde wrote: > > On 4/9/21 3:40 PM, Aswath Govindraju wrote: > > > Add binding documentation for TI TCAN104x CAN transceivers. > > > > > &

Re: [PATCH v2 00/10] KVM: Consolidate and optimize MMU notifiers

2021-04-12 Thread Marc Zyngier
22 +- > > virt/kvm/kvm_main.c| 325 +++-- > > 16 files changed, 552 insertions(+), 662 deletions(-) > > > > For MIPS, I am going to post a series that simplifies TLB flushing > further. I applied it, and rebased this one on top, to > kvm/mmu-notifier-queue. > > Architecture maintainers, please look at the branch and > review/test/ack your parts. I've given this a reasonably good beating on arm64 for both VHE and nVHE HW, and nothing caught fire, although I was left with a conflict in the x86 code after merging with linux/master. Feel free to add a Tested-by: Marc Zyngier for the arm64 side. M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH 4/4] can: m_can_platform: Add support for transceiver as phy

2021-04-12 Thread Marc Kleine-Budde
itrate_max = (transceiver->attrs.max_link_rate) * 100; > + if (!bitrate_max) > + dev_warn(&pdev->dev, "Invalid value for transceiver max > bitrate. Ignoring bitrate limit\n"); Please move this check to the generic transce

Re: [PATCH 1/4] dt-bindings: phy: Add binding for TI TCAN104x CAN transceivers

2021-04-12 Thread Marc Kleine-Budde
in bps > +minimum: 1 > + > +required: > + - compatible > + - '#phy-cells' > + > +additionalProperties: false > + > +examples: > + - | > +#include > + > +transceiver1: tcan104x-phy { > + compatible = "ti,tcan1043"; > + #phy-cel

Re: [PATCH 2/4] phy: phy-can-transceiver: Add support for generic CAN transceiver driver

2021-04-12 Thread Marc Kleine-Budde
data->flags & EN_PRESENT) { > + enable_gpio = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW); > + if (IS_ERR(enable_gpio)) > + return PTR_ERR(enable_gpio); > + can_transceiver_phy->enable_gpio = enable_gpio; > + } > + > +

Re: [PATCH v2 03/10] KVM: arm64: Convert to the gfn-based MMU notifier callbacks

2021-04-12 Thread Marc Zyngier
e the memslot lookups occur before > calling into arch code. > > Signed-off-by: Sean Christopherson Reviewed-by: Marc Zyngier M. -- Without deviation from the norm, progress is not possible.

Re: [PATCH v15 0/3] Introducing ETAS ES58X CAN USB interfaces

2021-04-12 Thread Marc Kleine-Budde
On 10.04.2021 18:59:45, Vincent Mailhol wrote: > Here comes the 15th iteration of the patch. This new version addresses > the comments received from Marc (thanks again for the review!) and > simplify the device probing by using .driver_info. diff --git a/drivers/net/can/usb/e

Re: [RFC v4 net-next 2/4] net: dsa: mt7530: add interrupt support

2021-04-12 Thread Marc Zyngier
On Mon, 12 Apr 2021 04:42:35 +0100, DENG Qingfang wrote: > > Add support for MT7530 interrupt controller to handle internal PHYs. > In order to assign an IRQ number to each PHY, the registration of MDIO bus > is also done in this driver. > > Signed-off-by: DENG Qingfang > --- > RFC v3 -> RFC v4

[PATCH] genirq/irqaction: Move dev_id and percpu_dev_id in a union

2021-04-10 Thread Marc Zyngier
dev_id and percpu_dev_id are mutually exclusive in struct irqaction, as they conceptually represent the same thing, only in a per-cpu fashion. Move them into an anonymous union, saving a few bytes on the way. Signed-off-by: Marc Zyngier --- include/linux/interrupt.h | 6 -- 1 file changed

Re: [PATCH] irqchip: fixed S3 could not resume after suspend

2021-04-09 Thread Marc Zyngier
On Fri, 09 Apr 2021 11:10:09 +0100, 414777...@qq.com wrote: > > From: Mengguang Peng > > On arm64 platform, found that the machine could not wake up after suspend, > this patch updates the its suspend and resume handling code. > > - Add a variable named ctlr_save in struct rdists. > - When susp

  1   2   3   4   5   6   7   8   9   10   >