Re: [patch 2/3] timers: do not raise softirq unconditionally (spinlockless version)

2019-05-30 Thread Marcelo Tosatti
On Wed, May 29, 2019 at 04:53:26PM +0200, Anna-Maria Gleixner wrote: > On Mon, 15 Apr 2019, Marcelo Tosatti wrote: > > > Check base->pending_map locklessly and skip raising timer softirq > > if empty. > > > > What allows the lockless (and potentially r

Re: memory leak in sctp_process_init

2019-05-30 Thread Marcelo Ricardo Leitner
On Thu, May 30, 2019 at 10:20:11AM -0400, Neil Horman wrote: > On Wed, May 29, 2019 at 08:37:57PM -0300, Marcelo Ricardo Leitner wrote: > > On Wed, May 29, 2019 at 03:07:09PM -0400, Neil Horman wrote: > > > --- a/net/sctp/sm_make_chunk.c > > > +++ b/net/sctp/sm_ma

Re: memory leak in sctp_process_init

2019-05-29 Thread Marcelo Ricardo Leitner
e SCTP_PARAM_RANDOM and SCTP_PARAM_HMAC_ALGO. I don't see a reason for SCTP_PARAM_STATE_COOKIE to be different here. This way it would be always allocated, and ready to be kfreed. We still need to free it after the handshake, btw. Marcelo

Re: [PATCH net-next] sctp: deduplicate identical skb_checksum_ops

2019-05-29 Thread Marcelo Ricardo Leitner
tp_dnat_handler 13211132-189 > l4proto_manip_pkt 25362313-223 > Total: Before=359297613, After=359296459, chg -0.00% > > Reviewed-by: Xin Long > Signed-off-by: Matteo Croce Acked-by: Marcelo Ricardo Leitner

Re: memory leak in sctp_process_init

2019-05-27 Thread Marcelo Ricardo Leitner
hat this is on the client side. It was handling the INIT_ACK chunk, from sctp_sf_do_5_1C_ack(). I'm not seeing anything else other than sctp_association_free() releasing this memory. This means 2 things: - Every time the cookie is retransmitted, it leaks. As shown by the repetitive leaks here. - The cookie remains allocated throughout the association, which is also not good as that's a 1k that we could have released back to the system right after the handshake. Marcelo

Re: [PATCH] staging: iio: adis16240: add of_match_table entry

2019-05-24 Thread Marcelo Schmitt
Hi Alexandru, On 05/24, Alexandru Ardelean wrote: > On Fri, May 24, 2019 at 6:30 AM Rodrigo Ribeiro wrote: > > > > This patch adds of_match_table entry in device driver in order to > > enable spi fallback probing. > > > > Signed-off-by: Rodrigo Ribeiro

Re: [PATCH] sched: introduce configurable delay before entering idle

2019-05-17 Thread Marcelo Tosatti
On Thu, May 16, 2019 at 09:32:06PM -0700, Ankur Arora wrote: > On 2019-05-15 1:43 p.m., Marcelo Tosatti wrote: > >On Wed, May 15, 2019 at 11:42:56AM -0700, Ankur Arora wrote: > >>On 5/14/19 6:50 AM, Marcelo Tosatti wrote: > >>>On Mon, May 13, 2019 at 05:2

Re: [PATCH] sched: introduce configurable delay before entering idle

2019-05-16 Thread Marcelo Tosatti
On Wed, May 15, 2019 at 11:42:56AM -0700, Ankur Arora wrote: > On 5/14/19 6:50 AM, Marcelo Tosatti wrote: > >On Mon, May 13, 2019 at 05:20:37PM +0800, Wanpeng Li wrote: > >>On Wed, 8 May 2019 at 02:57, Marcelo Tosatti wrote: > >>> > >>> > >&g

Re: [PATCH] sched: introduce configurable delay before entering idle

2019-05-15 Thread Marcelo Tosatti
On Wed, May 15, 2019 at 09:42:48AM +0800, Wanpeng Li wrote: > On Wed, 15 May 2019 at 02:20, Marcelo Tosatti wrote: > > > > On Tue, May 14, 2019 at 11:20:15AM -0400, Konrad Rzeszutek Wilk wrote: > > > On Tue, May 14, 2019 at 10:50:23AM -0300, Marcelo Tosatti wrote: >

Re: [PATCH] sched: introduce configurable delay before entering idle

2019-05-14 Thread Marcelo Tosatti
On Tue, May 14, 2019 at 11:20:15AM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, May 14, 2019 at 10:50:23AM -0300, Marcelo Tosatti wrote: > > On Mon, May 13, 2019 at 05:20:37PM +0800, Wanpeng Li wrote: > > > On Wed, 8 May 2019 at 02:57, Marcelo Tosatti wrote: > > >

Re: [PATCH] sched: introduce configurable delay before entering idle

2019-05-14 Thread Marcelo Tosatti
On Mon, May 13, 2019 at 05:20:37PM +0800, Wanpeng Li wrote: > On Wed, 8 May 2019 at 02:57, Marcelo Tosatti wrote: > > > > > > Certain workloads perform poorly on KVM compared to baremetal > > due to baremetal's ability to perform mwait on NEED_RESCHED > > bit

Re: [PATCH] sched: introduce configurable delay before entering idle

2019-05-07 Thread Marcelo Tosatti
On Wed, May 08, 2019 at 12:15:19AM +0200, Peter Zijlstra wrote: > On Tue, May 07, 2019 at 03:56:49PM -0300, Marcelo Tosatti wrote: > > > > Certain workloads perform poorly on KVM compared to baremetal > > due to baremetal's ability to perform mwait on NEED_RESCHED > > b

[PATCH] sched: introduce configurable delay before entering idle

2019-05-07 Thread Marcelo Tosatti
: 31.814230202231556 Guest: 38.1771876513 (83 %) Guest, idle_spin=50us: 33.31770989804 (95 %) Guest, idle_spin=220us: 32.2782655149 (98 %) Signed-off-by: Marcelo Tosatti --- kernel/sched/idle.c | 86

Re: [patch 0/3] do not raise timer softirq unconditionally (spinlockless version)

2019-05-05 Thread Marcelo Tosatti
On Mon, Apr 15, 2019 at 05:12:13PM -0300, Marcelo Tosatti wrote: > For isolated CPUs, we'd like to skip awakening ktimersoftd > (the switch to and then back from ktimersoftd takes 10us in > virtualized environments, in addition to other OS overhead, > which exceeds telco requirement

Re: [patch 0/3] do not raise timer softirq unconditionally (spinlockless version)

2019-04-15 Thread Marcelo Tosatti
On Mon, Apr 15, 2019 at 05:12:13PM -0300, Marcelo Tosatti wrote: > For isolated CPUs, we'd like to skip awakening ktimersoftd > (the switch to and then back from ktimersoftd takes 10us in > virtualized environments, in addition to other OS overhead, > which exceeds telco requirement

[patch 3/3] timers: condense pending bitmap information

2019-04-15 Thread Marcelo Tosatti
Condense the pending bitmap information in a bool. Improves cyclictest results by 4us. Signed-off-by: Marcelo Tosatti --- kernel/time/timer.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) Index: linux-rt-devel/kernel/time/timer.c

[patch 1/3] timers: raise timer softirq on __mod_timer/add_timer_on

2019-04-15 Thread Marcelo Tosatti
n timer addition and timer interrupt execution by unconditionally (in case of isolated CPUs) raising the timer softirq after making sure the updated bitmap is visible on remote CPUs. This patch reduces cyclictest latency from 25us to 14us on my testbox. Signed-off-by: Marcelo Tosat

[patch 2/3] timers: do not raise softirq unconditionally (spinlockless version)

2019-04-15 Thread Marcelo Tosatti
Check base->pending_map locklessly and skip raising timer softirq if empty. What allows the lockless (and potentially racy against mod_timer) check is that mod_timer will raise another timer softirq after modifying base->pending_map. Signed-off-by: Marcelo Tosatti --- kernel/time/t

[patch 0/3] do not raise timer softirq unconditionally (spinlockless version)

2019-04-15 Thread Marcelo Tosatti
For isolated CPUs, we'd like to skip awakening ktimersoftd (the switch to and then back from ktimersoftd takes 10us in virtualized environments, in addition to other OS overhead, which exceeds telco requirements for packet forwarding for 5G) from the sched tick. The patch "timers: do not raise

Re: [PATCH 4/4] staging: iio: ad9832: add devicetree documentation

2019-04-02 Thread Marcelo Schmitt
On 04/02, Alexandru Ardelean wrote: > On Mon, Apr 1, 2019 at 5:38 PM Marcelo Schmitt > wrote: > > > > Add a devicetree documentation for the ad9832 direct digital > > synthesizer, waveform generator. > > > > Signed-off-by: Marcelo Schmitt > > ---

Re: Work on iio: stating: frequency: ad9832

2019-04-02 Thread Marcelo Schmitt
On 04/02, Alexandru Ardelean wrote: > On Mon, Apr 1, 2019 at 7:13 PM Jonathan Cameron > wrote: > > > > On Mon, 1 Apr 2019 11:25:29 -0300 > > Marcelo Schmitt wrote: > > > > > Hello, > > > > > > I was looking for some work on staging: i

Re: [PATCH 2/4] staging: iio: ad9832: add SPDX identifier

2019-04-02 Thread Marcelo Schmitt
On 04/01, Greg KH wrote: > On Mon, Apr 01, 2019 at 08:36:50PM +0530, Mukesh Ojha wrote: > > > > On 4/1/2019 8:07 PM, Marcelo Schmitt wrote: > > > Add SPDX identifier of GPL-2.0 for the ad9832 driver. > > > > > > Signed-off-by: Marcelo Schmitt >

[PATCH 4/4] staging: iio: ad9832: add devicetree documentation

2019-04-01 Thread Marcelo Schmitt
Add a devicetree documentation for the ad9832 direct digital synthesizer, waveform generator. Signed-off-by: Marcelo Schmitt --- .../bindings/iio/frequency/ad9832.txt | 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio

[PATCH 3/4] staging: iio: ad9832: use clock framework for clock reference

2019-04-01 Thread Marcelo Schmitt
Previously external clock were set through platform_data struct. Now device uses clk struct defined in include/linux/clk.h to handle external clock source. It also removes mclk from platform_data struct. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 37

[PATCH 2/4] staging: iio: ad9832: add SPDX identifier

2019-04-01 Thread Marcelo Schmitt
Add SPDX identifier of GPL-2.0 for the ad9832 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c index

[PATCH 1/4] staging: iio: ad9832: organize includes

2019-04-01 Thread Marcelo Schmitt
Organize includes to list them in lexicographic order. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/frequency/ad9832.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/staging/iio/frequency/ad9832.c b/drivers/staging/iio/frequency/ad9832.c

[PATCH 0/4] staging: iio: ad9832: use clock framework

2019-04-01 Thread Marcelo Schmitt
This series of patches do minor codestyle ajusts, set SPDX licence identifier, set use of linux's clock framework to handle external clock, and add a devicetree documentation. Marcelo Schmitt (4): staging: iio: ad9832: organize includes staging: iio: ad9832: add SPDX identifier staging: iio

Work on iio: stating: frequency: ad9832

2019-04-01 Thread Marcelo Schmitt
, Marcelo

Help on testing ad5933 driver

2019-03-21 Thread Marcelo Schmitt
/ad5933) page. Any advice will be greatly appreciated. Thanks in advance, Marcelo

[PATCH v5 1/2] staging: iio: ad5933: change attributes to match ABI

2019-03-21 Thread Marcelo Schmitt
Change device attributes' names to match ABI documentation. Names were chosen such that they tend to be similar to existing ABI so it should be easier to standardize them when necessary. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/ad5933.c | 24 +-- 1

[PATCH v5 2/2] staging: iio: ad5933: move out of staging

2019-03-21 Thread Marcelo Schmitt
. Signed-off-by: Marcelo Schmitt --- drivers/iio/Kconfig | 1 + drivers/iio/Makefile | 1 + drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio/impedance-analyzer/Makefile | 5 + drivers/iio/impedance-analyzer/ad5933.c

[PATCH v5 0/2] staging: iio: ad5933: move out of staging

2019-03-21 Thread Marcelo Schmitt
. Marcelo Schmitt (2): staging: iio: ad5933: change attributes to match ABI staging: iio: ad5933: move out of staging drivers/iio/Kconfig | 1 + drivers/iio/Makefile | 1 + drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio

[PATCH v4 6/7] staging: iio: ad5933: change attributes to match ABI

2019-03-16 Thread Marcelo Schmitt
Change device attributes' names to match ABI documentation. Names were chosen such that they tend to be similar to existing ABI so it should be easier to standardize them when necessary. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/ad5933.c | 20 +-- 1

[PATCH v4 7/7] staging: iio: ad5933: move out of staging

2019-03-16 Thread Marcelo Schmitt
. Signed-off-by: Marcelo Schmitt --- drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio/impedance-analyzer/Makefile | 5 + drivers/iio/impedance-analyzer/ad5933.c | 811 ++ .../staging/iio/impedance-analyzer/Kconfig| 18 - .../staging/iio/impedance

[PATCH v4 5/7] staging: iio: ad5933: add ABI documentation

2019-03-16 Thread Marcelo Schmitt
Add an ABI documentation for the ad5933 driver. Signed-off-by: Marcelo Schmitt --- .../sysfs-bus-iio-impedance-analyzer-ad5933 | 35 +++ .../sysfs-bus-iio-impedance-analyzer-ad5933 | 30 2 files changed, 35 insertions(+), 30 deletions(-) create mode 100644

[PATCH v4 3/7] staging: iio: ad5933: add SPDX identifier

2019-03-16 Thread Marcelo Schmitt
Add SPDX identifier of GPL-2.0 for the ad5933 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance

[PATCH v4 4/7] staging: iio: ad5933: change help rule message

2019-03-16 Thread Marcelo Schmitt
Remove the previous comment about direct access via sysfs which would lead one think ad5933 driver has limitations it actually doesn't. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v4 1/7] staging: iio: ad5933: change multi-line comment style

2019-03-16 Thread Marcelo Schmitt
Make multi-line comments compliant with the preferred code style. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging

[PATCH v4 2/7] staging: iio: ad5933: organize includes

2019-03-16 Thread Marcelo Schmitt
Organize includes to list them in lexicographic order. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/ad5933.c| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio

[PATCH v4 0/7] staging: iio: ad5933: move out of staging

2019-03-16 Thread Marcelo Schmitt
to existing ABI. Finally, it moves the ad5933 driver from staging directory to iio main drivers directory. Marcelo Schmitt (7): staging: iio: ad5933: change multi-line comment style staging: iio: ad5933: organize includes staging: iio: ad5933: add SPDX identifier staging: iio: ad5933: change

Re: [PATCH v3 5/7] staging: iio: ad5933: add ABI documentation

2019-03-12 Thread Marcelo Schmitt
On 03/11, Alexandru Ardelean wrote: > On Sun, Mar 10, 2019 at 7:47 PM Marcelo Schmitt > wrote: > > > > Add an ABI documentation for the ad5933 driver. > > There's already an ABI documentation for this driver. > See: > https://git.kernel.org/pub/scm/linux/kernel/

[PATCH v3 6/7] staging: iio: ad5933: change attributes' ABI call

2019-03-10 Thread Marcelo Schmitt
Change device attributes to use more suitable ABI functions when setting and displaying AC output excitation voltage. It better complies with device hardware since these attributes are used to manage DDS peak-to-peak output voltage. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio

[PATCH v3 7/7] staging: iio: ad5933: move out of staging

2019-03-10 Thread Marcelo Schmitt
. Signed-off-by: Marcelo Schmitt --- drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio/impedance-analyzer/Makefile | 5 + drivers/iio/impedance-analyzer/ad5933.c | 811 ++ .../staging/iio/impedance-analyzer/Kconfig| 18 - .../staging/iio/impedance

[PATCH v3 5/7] staging: iio: ad5933: add ABI documentation

2019-03-10 Thread Marcelo Schmitt
Add an ABI documentation for the ad5933 driver. Signed-off-by: Marcelo Schmitt --- .../ABI/testing/sysfs-bus-iio-ad5933 | 39 +++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-ad5933 diff --git a/Documentation/ABI/testing

[PATCH v3 4/7] staging: iio: ad5933: change help rule message

2019-03-10 Thread Marcelo Schmitt
Remove the previous comment about direct access via sysfs which would lead one think ad5933 driver has limitations it actually doesn't. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v3 3/7] staging: iio: ad5933: add SPDX identifier

2019-03-10 Thread Marcelo Schmitt
Add SPDX identifier of GPL-2.0 for the ad5933 driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance

[PATCH v3 1/7] staging: iio: ad5933: change multi-line comment style

2019-03-10 Thread Marcelo Schmitt
Make multi-line comments compliant with the preferred code style. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging

[PATCH v3 2/7] staging: iio: ad5933: organize includes

2019-03-10 Thread Marcelo Schmitt
Organize includes to list them in lexicographic order. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/ad5933.c| 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio

[PATCH v3 0/7] move out of staging

2019-03-10 Thread Marcelo Schmitt
functions. Finally, it moves the ad5933 driver from staging directory to iio main drivers directory. Marcelo Schmitt (7): staging: iio: ad5933: change multi-line comment style staging: iio: ad5933: organize includes staging: iio: ad5933: add SPDX identifier staging: iio: ad5933: change help rule

Re: general protection fault in sctp_sched_rr_dequeue

2019-03-07 Thread Marcelo Ricardo Leitner
:sctp_sched_rr_dequeue+0xd3/0x170 net/sctp/stream_sched_rr.c:141 > > The panic was caused by sched->init() reset stream->rr_next = NULL, even > > if outq->out_chunk_list is not empty. > > > > We should remove the sched->init() from sctp_stream_init(), since > > all sched info was moved into sout->ext and sctp_stream_alloc_out() > > will not afffect it. > > > I think what you're saying is we can just let sctp_outq_init handle the stream > scheduler initalization, correct? If so, ACK to that approach > Neil +1 Marcelo

Re: [PATCH v2 3/4] staging: iio: ad5933: add ABI documentation

2019-03-03 Thread Marcelo Schmitt
On 03/03, Jonathan Cameron wrote: > On Thu, 28 Feb 2019 23:53:14 -0300 > Marcelo Schmitt wrote: > > > Add an ABI documentation for the ad5933 driver. > > > > Signed-off-by: Marcelo Schmitt > Hi Marcelo, > > The ABI that you have defined which is actually ne

[PATCH v2 4/4] staging: iio: ad5933: move out of staging

2019-02-28 Thread Marcelo Schmitt
. Signed-off-by: Marcelo Schmitt --- drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio/impedance-analyzer/Makefile | 5 + drivers/iio/impedance-analyzer/ad5933.c | 811 ++ .../staging/iio/impedance-analyzer/Kconfig| 18 - .../staging/iio/impedance

[PATCH v2 2/4] staging: iio: ad5933: change help rule message

2019-02-28 Thread Marcelo Schmitt
Remove the previous comment about direct access via sysfs which would lead one think ad5933 driver has limitations it actually doesn't. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

[PATCH v2 3/4] staging: iio: ad5933: add ABI documentation

2019-02-28 Thread Marcelo Schmitt
Add an ABI documentation for the ad5933 driver. Signed-off-by: Marcelo Schmitt --- .../ABI/testing/sysfs-bus-iio-ad5933 | 91 +++ 1 file changed, 91 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-ad5933 diff --git a/Documentation/ABI/testing

[PATCH v2 1/4] staging: iio: ad5933: add SPDX identifier

2019-02-28 Thread Marcelo Schmitt
Add SPDX identifier of GPL-2.0 for the ad5933 driver. Organize imports. Make multi-line comments compliant with the preferred code style. Signed-off-by: Marcelo Schmitt --- .../staging/iio/impedance-analyzer/ad5933.c | 30 ++- 1 file changed, 16 insertions(+), 14 deletions

[PATCH v2 0/4] staging: iio: ad5933: move out of staging

2019-02-28 Thread Marcelo Schmitt
directory. Marcelo Schmitt (4): staging: iio: ad5933: add SPDX identifier staging: iio: ad5933: change help rule message staging: iio: ad5933: add ABI documentation staging: iio: ad5933: move out of staging .../ABI/testing/sysfs-bus-iio-ad5933 | 91 ++ drivers/iio/impedance

Re: [PATCH] sctp: chunk.c: correct format string for size_t in printk

2019-02-28 Thread Marcelo Ricardo Leitner
' > printk(fmt, ##__VA_ARGS__); \ >~~~^ > > Fixes: 5b5e0928f742 ("lib/vsprintf.c: remove %Z support") > Link: https://github.com/ClangBuiltLinux/linux/issues/378 > Signed-off-by: Matthias Maennich Acked-by: Marcelo Ricardo Leitner >

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-14 Thread Marcelo Ricardo Leitner
On Thu, Feb 14, 2019 at 10:52:00PM +0800, Xin Long wrote: > On Thu, Feb 14, 2019 at 10:39 PM Marcelo Ricardo Leitner > wrote: > > > > On Thu, Feb 14, 2019 at 12:17:45PM -0200, Marcelo Ricardo Leitner wrote: > > > On Thu, Feb 14, 2019 at 10:03:30PM +0800, Xin Long wr

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-14 Thread Marcelo Ricardo Leitner
On Thu, Feb 14, 2019 at 12:17:45PM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Feb 14, 2019 at 10:03:30PM +0800, Xin Long wrote: > > On Wed, Feb 13, 2019 at 9:52 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, Feb 13, 2019 at 12:35:56PM +0800, Xin L

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-14 Thread Marcelo Ricardo Leitner
On Thu, Feb 14, 2019 at 12:17:45PM -0200, Marcelo Ricardo Leitner wrote: > On Thu, Feb 14, 2019 at 10:03:30PM +0800, Xin Long wrote: > > On Wed, Feb 13, 2019 at 9:52 PM Marcelo Ricardo Leitner > > wrote: > > > > > > On Wed, Feb 13, 2019 at 12:35:56PM +0800, Xin L

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-14 Thread Marcelo Ricardo Leitner
On Thu, Feb 14, 2019 at 10:03:30PM +0800, Xin Long wrote: > On Wed, Feb 13, 2019 at 9:52 PM Marcelo Ricardo Leitner > wrote: > > > > On Wed, Feb 13, 2019 at 12:35:56PM +0800, Xin Long wrote: > > > On Wed, Feb 13, 2019 at 4:00 AM syzbot > > > wrote: > >

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-13 Thread 'Marcelo Ricardo Leitner'
On Wed, Feb 13, 2019 at 04:17:41PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 10 February 2019 20:16 > ... > > We have issues on read path too. 52ccb8e90c0a ("[SCTP]: Update > > SCTP_PEER_ADDR_PARAMS socket option to the latest api

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-13 Thread Marcelo Ricardo Leitner
On Wed, Feb 13, 2019 at 12:35:56PM +0800, Xin Long wrote: > On Wed, Feb 13, 2019 at 4:00 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:d4104460aec1 Add linux-next specific files for 20190211 > > git tree: linux-next > > console

Re: KASAN: use-after-free Read in sctp_outq_tail

2019-02-12 Thread Marcelo Ricardo Leitner
its are in? Recent patches are involved with this code, but not sure what was included on the test. Marcelo

Re: [PATCH net] sctp: call gso_reset_checksum when computing checksum in sctp_gso_segment

2019-02-12 Thread Marcelo Ricardo Leitner
to be set in skb_segment(). > > For TCP/UDP, when feature supports HW_CSUM, CHECKSUM_PARTIAL will be set > and gso_reset_checksum will be called to set SKB_GSO_CB(skb)->csum_start. > > So SCTP should do the same as TCP/UDP, to call gso_reset_checksum() when > computing checksum in sctp

Re: [PATCH net] sctp: set stream ext to NULL after freeing it in sctp_stream_outq_migrate

2019-02-12 Thread Marcelo Ricardo Leitner
e fix it by simply setting them to NULL after freeing. > > Fixes: 5e32a431 ("sctp: introduce stream scheduler foundations") > Reported-by: syzbot+58e480e7b28f2d890...@syzkaller.appspotmail.com > Signed-off-by: Xin Long Acked-by: Marcelo Ricardo Leitner > --- >

Re: [PATCH] staging: iio: ad5933: move out of staging

2019-02-11 Thread Marcelo Schmitt
On 02/11, Jonathan Cameron wrote: > On Mon, 11 Feb 2019 13:43:11 -0200 > Marcelo Schmitt wrote: > > > Move ad5933 impedance-analyzer driver from staging to mainline. > > > > The ad5933 is a high precision impedance converter system > > solution that combine

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-11 Thread Marcelo Ricardo Leitner
On Mon, Feb 11, 2019 at 10:04:32AM -0500, Neil Horman wrote: > On Sun, Feb 10, 2019 at 10:46:16AM -0200, Marcelo Ricardo Leitner wrote: > > On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > > > From: Marcelo Ricardo Leitner > > > Date: Wed

[PATCH] staging: iio: ad5933: move out of staging

2019-02-11 Thread Marcelo Schmitt
. Signed-off-by: Marcelo Schmitt --- drivers/iio/impedance-analyzer/Kconfig| 18 + drivers/iio/impedance-analyzer/Makefile | 5 + drivers/iio/impedance-analyzer/ad5933.c | 810 ++ .../staging/iio/impedance-analyzer/Kconfig| 18 - .../staging/iio/impedance

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-10 Thread Marcelo Ricardo Leitner
On Sun, Feb 10, 2019 at 10:46:16AM -0200, Marcelo Ricardo Leitner wrote: > On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > > From: Marcelo Ricardo Leitner > > Date: Wed, 6 Feb 2019 18:37:54 -0200 > > > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, J

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-10 Thread Marcelo Ricardo Leitner
On Sat, Feb 09, 2019 at 03:12:17PM -0800, David Miller wrote: > From: Marcelo Ricardo Leitner > Date: Wed, 6 Feb 2019 18:37:54 -0200 > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > >> Make sctp_setsockopt_events() able to accept sctp_event_subscrib

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-07 Thread 'Marcelo Ricardo Leitner'
On Thu, Feb 07, 2019 at 05:33:07PM +, David Laight wrote: > From: Marcelo Ricardo Leitner > > Sent: 06 February 2019 21:07 > > > > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > > > > On 2/6/19 12:37 PM, Marcelo Ric

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 04:08:27PM -0500, Neil Horman wrote: > On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: >

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 12:48:38PM -0800, Julien Gomes wrote: > > > On 2/6/19 12:37 PM, Marcelo Ricardo Leitner wrote: > > On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > >> Make sctp_setsockopt_events() able to accept sctp_event_subscribe > >> s

Re: [PATCH net] sctp: make sctp_setsockopt_events() less strict about the option length

2019-02-06 Thread Marcelo Ricardo Leitner
On Wed, Feb 06, 2019 at 12:14:30PM -0800, Julien Gomes wrote: > Make sctp_setsockopt_events() able to accept sctp_event_subscribe > structures longer than the current definitions. > > This should prevent unjustified setsockopt() failures due to struct > sctp_event_subscribe extensions (as in 4.11

[PATCH] selftests: net: fix "from" match test in fib_rule_tests.sh

2019-01-30 Thread Marcelo Henrique Cerri
Fix the IPv4 address of the dummy0 interface and ensure that ip_forward is enabled in the network space to get a valid response when checking for routes between the gateway and other hosts. Signed-off-by: Marcelo Henrique Cerri --- tools/testing/selftests/net/fib_rule_tests.sh | 4 +++- 1 file

Re: [PATCH AUTOSEL 4.19 033/258] sctp: Fix SKB list traversal in sctp_intl_store_ordered().

2019-01-28 Thread Marcelo Ricardo Leitner
ned value when something > like skb_queue_walk() naturally terminates. > > This will actually matter when SKB queues are converted over to > list_head. > > Formalize what this code ends up doing with the current > implementation. Hi Sasha, This one too then. Thanks, Marcelo

Re: [PATCH AUTOSEL 4.19 034/258] sctp: Fix SKB list traversal in sctp_intl_store_reasm().

2019-01-28 Thread Marcelo Ricardo Leitner
_walk() naturally terminates. > > This will actually matter when SKB queues are converted over to > list_head. > > Formalize what this code ends up doing with the current > implementation. I don't think this patch is really needed for -stable without the SKB queue convertion, but okay. Marcelo

Re: [PATCH 6/7] sctp: Convert to genradix

2019-01-18 Thread Marcelo Ricardo Leitner
On Fri, Jan 18, 2019 at 08:10:22AM -0500, Neil Horman wrote: > On Tue, Jan 15, 2019 at 12:29:26PM -0200, Marcelo Ricardo Leitner wrote: > > On Mon, Dec 17, 2018 at 04:00:21PM -0500, Kent Overstreet wrote: > > > On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote: >

Re: [PATCH 6/7] sctp: Convert to genradix

2019-01-15 Thread Marcelo Ricardo Leitner
ruct sctp_as > > goto out; > > } > > > > - stream->outcnt = outcnt; > > - > > asoc->strreset_outstanding = !!out + !!in; > > > > out: > > > > > > We're at 4.20-rc7 and this series is rather large. I'll merge them all > > to see what happens, but I don't think it's 4.21-rc1 material? > > Yeah, agreed. Thanks! Ping? Where did this go? Marcelo

Re: [PATCH net] sctp: allocate sctp_sockaddr_entry with kzalloc

2019-01-14 Thread Marcelo Ricardo Leitner
ocate sctp_sockaddr_entry with kzalloc for both sctp > ipv4 and ipv6 addresses, as does in sctp_v4/6_copy_addrlist(). > > Reported-by: Alexander Potapenko > Signed-off-by: Xin Long Seems you were faster than syzkaller, but we could still use: Reported-by: syzbot+ae0c70c0c2d40c51b...@syzkall

Re: [PATCH 6/7] sctp: Convert to genradix

2018-12-17 Thread Marcelo Ricardo Leitner
On Mon, Dec 17, 2018 at 12:50:01PM -0800, Andrew Morton wrote: > On Mon, 17 Dec 2018 08:19:28 -0500 Kent Overstreet > wrote: > > > @@ -535,9 +470,6 @@ int sctp_send_add_streams(struct sctp_association *asoc, > > goto out; > > } > > > > - stream->incnt = incnt; > > -

Re: [PATCH net] sctp: initialize sin6_flowinfo for ipv6 addrs in sctp_inet6addr_event

2018-12-10 Thread Marcelo Ricardo Leitner
really used by SCTP, so it will be fixed by simply > setting it to 0. > > The issue exists since very beginning. > Thanks Alexander for the reproducer provided. > > Reported-by: syzbot+ad5d327e6936a2e28...@syzkaller.appspotmail.com > Signed-off-by: Xin Long Acked-by: Marcelo

Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
the pieces of advice needed for this work. Thanks, Marcelo Em sáb, 8 de dez de 2018 às 16:18, Marcelo Schmitt escreveu: > > This series of patches change voltage regulator error handling for the > ad5933. > It also add an option to specify external clock reference using a clock

Re: [PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
the pieces of advice needed for this work. Thanks, Marcelo Em sáb, 8 de dez de 2018 às 16:18, Marcelo Schmitt escreveu: > > This series of patches change voltage regulator error handling for the > ad5933. > It also add an option to specify external clock reference using a clock

[PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933

2018-12-08 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 26 +++ 1 file changed, 26

[PATCH 3/3] staging: iio: ad5933: add binding doc for ad5933

2018-12-08 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 26 +++ 1 file changed, 26

[PATCH 2/3] staging: iio: ad5933: use clock framework for clock reference

2018-12-08 Thread Marcelo Schmitt
Add the option to specify the external clock (MCLK) using the clock framework. Also remove the old platform data structure. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../staging/iio/impedance-analyzer/ad5933.c | 43

[PATCH 2/3] staging: iio: ad5933: use clock framework for clock reference

2018-12-08 Thread Marcelo Schmitt
Add the option to specify the external clock (MCLK) using the clock framework. Also remove the old platform data structure. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- .../staging/iio/impedance-analyzer/ad5933.c | 43

[PATCH 1/3] staging: iio: ad5933: change regulator binging for vref

2018-12-08 Thread Marcelo Schmitt
Set a single voltage regulator for all voltage references. Remove voltage reference value from default platafrom data struct. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- drivers/staging/iio/impedance-analyzer/ad5933.c | 14

[PATCH 1/3] staging: iio: ad5933: change regulator binging for vref

2018-12-08 Thread Marcelo Schmitt
Set a single voltage regulator for all voltage references. Remove voltage reference value from default platafrom data struct. Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella Co-Developed-by: Gabriel Capella --- drivers/staging/iio/impedance-analyzer/ad5933.c | 14

[PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
This series of patches change voltage regulator error handling for the ad5933. It also add an option to specify external clock reference using a clock framework and remove the old platform data structure. Finally it adds binding documentation for devicetree. Marcelo Schmitt (3): staging: iio

[PATCH 0/3] Add devicetree support for ad5933

2018-12-08 Thread Marcelo Schmitt
This series of patches change voltage regulator error handling for the ad5933. It also add an option to specify external clock reference using a clock framework and remove the old platform data structure. Finally it adds binding documentation for devicetree. Marcelo Schmitt (3): staging: iio

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-12-02 Thread Marcelo Schmitt
On 11/25, Jonathan Cameron wrote: > On Thu, 22 Nov 2018 10:53:47 -0200 > Marcelo Schmitt wrote: > > > Previously, there was an implicit creation of a kfifo which was replaced > > by a call to triggered_buffer_setup, which is already implemented in iio > > infrastr

Re: [PATCH] staging: iio: ad5933: replaced kfifo by triggered_buffer

2018-12-02 Thread Marcelo Schmitt
On 11/25, Jonathan Cameron wrote: > On Thu, 22 Nov 2018 10:53:47 -0200 > Marcelo Schmitt wrote: > > > Previously, there was an implicit creation of a kfifo which was replaced > > by a call to triggered_buffer_setup, which is already implemented in iio > > infrastr

[PATCH] staging: iio: ad5933: add binding doc for ad5933

2018-12-02 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Co-Developed-by: Gabriel Capella Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 23 +++ 1 file changed, 23

[PATCH] staging: iio: ad5933: add binding doc for ad5933

2018-12-02 Thread Marcelo Schmitt
Add a devicetree documentation for the ad5933 and ad5934 impedance converter, network analyzer. Co-Developed-by: Gabriel Capella Signed-off-by: Marcelo Schmitt Signed-off-by: Gabriel Capella --- .../iio/impedance-analyzer/ad5933.txt | 23 +++ 1 file changed, 23

[PATCH v2] staging: iio: ad5933: add device tree support

2018-11-24 Thread Marcelo Schmitt
Add a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device tree support. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/iio/impedance

[PATCH v2] staging: iio: ad5933: add device tree support

2018-11-24 Thread Marcelo Schmitt
Add a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device tree support. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/iio/impedance

[PATCH] staging: iio: ad5933: finalized device-tree support

2018-11-23 Thread Marcelo Schmitt
Added a of_device_id struct variable and subsequent call to MODULE_DEVICE_TABLE macro to complete device-tree support for this driver. Signed-off-by: Marcelo Schmitt --- drivers/staging/iio/impedance-analyzer/ad5933.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging

<    1   2   3   4   5   6   7   8   9   10   >