d all
comments from me, Joe and Petr, per [2].
For the two patches:
Reviewed-by: Marcos Paulo de Souza
[1]: https://github.com/mricon/b4/issues/58
[2]:
https://lore.kernel.org/live-patching/b2637bad-9022-496a-9b83-0d348a635...@gmail.com/T/#m14bc5c118490c1b17e782a0f0173c1fb70d187c7
> ---
&
ssed for the
test to be merged. Either way,
Reviewed-by: Marcos Paulo de Souza
Tested-by: Marcos Paulo de Souza
> ---
> Changes in v2:
> - functions.sh: added reset tracing on push and pop_config.
> - test-ftrace.sh: enabled tracing_on before test init.
> - nitpick: added double q
modules in alphabetical order.
> Rename module description.
>
> V2:
> Save and restore kprobe state.
With the syntax error pointed out by Joe resolved, you can add:
Tested-by: Marcos Paulo de Souza
Reviewed-by: Marcos Paulo de Souza
>
> Michael Vetter (3):
> selftests:
On Tue, 2024-10-08 at 15:52 +0800, Wardenjohn wrote:
> Add selftest test cases to sysfs attribute 'stack_order'.
>
> Signed-off-by: Wardenjohn
> ---
> .../testing/selftests/livepatch/test-sysfs.sh | 71
> +++
> .../selftests/livepatch/test_modules/Makefile | 5 +-
> .../test_klp
On Mon, 2024-09-30 at 11:33 +0200, Michael Vetter wrote:
> Thanks to Miroslav, Petr and Marcos for the reviews!
As the only changes were regarding bash nitpicks I keep my review from
earlier patchset, so:
Reviewed-by: Marcos Paulo de Souza
>
> V4:
> Use variable for /sys/kernel
ute should contain a
new test to exercise the correct behavior.
Other than that, for the series:
Acked-by: Marcos Paulo de Souza
>
> V1 -> V2:
> 1. According to the suggestion from Petr, to make the meaning more
> clear, rename
> 'order' to 'stack_order'.
selftests: livepatch: save and restore kprobe state
> selftests: livepatch: test livepatching a kprobed function
>
Thanks for the new version! LGTM, so the series is
Reviewed-by: Marcos Paulo de Souza
> tools/testing/selftests/livepatch/Makefile | 3 +-
> .../testing/selftests/li
to/aesni-intel_glue.c:682:12) [REMOVED] [edges: 4]
> constprop: gcmaes_crypt_by_sg.constprop.13/4182
> (arch/x86/crypto/aesni-intel_glue.c:682:12)
>
> Affected functions: 3
> scatterwalk_unmap.isra.8/4117 (./include/crypto/scatterwalk.h:59:20)
> [REMOVED]
> gcmaes_crypt_by_sg/4019 (arch/x86/crypto/aesni-intel_glue.c:682:12)
> [REMOVED]
> gcmaes_crypt_by_sg.constprop.13/4182
> (arch/x86/crypto/aesni-intel_glue.c:682:12)
>
>
>
> The rest looks great. Thanks a lot, Joe, for putting it together.
I think that we should start provinding a "Livepatch creation how-to", something
similar, but for now I believe that some documentation is better than no
documentation. This document can evolve to reach such point in the future, but
for now, with Miroslav suggestions applied:
Acked-by: Marcos Paulo de Souza
>
> Miroslav
to be
> resolved by this tool
> - klp-convert: code simplification
> - selftests: add selftest livepatching function using an external symbol
Thanks for sending this new version Lukas! It currently fails to apply on
current Linux master, but the conflict is very simple to address (attache
st
> file to warn readers.
>
> Suggested-by: Josh Poimboeuf
> Signed-off-by: Joe Lawrence
> ---
> samples/livepatch/README.rst | 15 +++
> 1 file changed, 15 insertions(+)
> create mode 100644 samples/livepatch/README.rst
Acked-by: Marcos Paulo de Souza
>
&
On Mon, 6 Nov 2023 17:25:08 +0100 Lukas Hruska wrote:
> Summary
> ---
>
> This is a significantly simplified version of the original klp-convert tool.
> The klp-convert code has never got a proper review and also clean ups
> were not easy. The last version was v7, see
> https://lore.kerne
On Mon, 2023-11-06 at 17:25 +0100, Lukas Hruska wrote:
> Add a section to Documentation/livepatch/module-elf-format.rst
> describing how klp-convert works for fixing relocations.
>
> Signed-off-by: Lukas Hruska
Reviewed-by: Marcos Paulo de Souza
> ---
> Documentation/li
gt; Signed-off-by: Lukas Hruska
Reviewed-by: Marcos Paulo de Souza
(The patch currently conflicts with Linus tree on Makefile and
modpost.c, but nothing to worry, AFAICS)
> ---
> .gitignore | 1 +
> Makefile | 10 ++
> scripts/Makefile.modf
> + *
> > + */
> > +
> > +#define SHN_LIVEPATCH 0xff20
> > +#define SHF_RELA_LIVEPATCH 0x0010
> > +#define MODULE_NAME_LEN(64 - sizeof(GElf_Addr))
> > +#define WARN(format, ...) \
> > + fprintf(stderr, "klp-convert: " format "\n",
> > ##__VA_ARGS__)
> > +
> > +struct sympos {
> > + char *symbol_name;
> > + char *object_name;
> > + char *loading_obj_name;
> > + int pos;
> > +};
>
> It seems that this structure is not longer used.
>
> > +/*
> > + * klp-convert uses macros and structures defined in the linux
> > sources
> > + * package (see include/uapi/linux/livepatch.h). To prevent the
> > + * dependency when building locally, they are defined below. Also
> > notice
> > + * that these should match the definitions from the targeted
> > kernel.
> > + */
> > +
> > +#define KLP_RELA_PREFIX".klp.rela."
> > +#define KLP_SYM_RELA_PREFIX".klp.sym.rela."
> > +#define KLP_SYM_PREFIX ".klp.sym."
> > +
> > +#ifndef __packed
> > +#define __packed __attribute__((packed))
> > +#endif
> > +
> > +struct klp_module_reloc {
> > + union {
> > + void *sym;
> > + uint64_t sym64; /* Force 64-bit width */
> > + };
> > + uint32_t sympos;
> > +} __packed;
>
> And this one as well.
>
> I do not see any other obvious problem. And it seems to work
> at least for the later added sample module.
I agree with Petr in all his other comments. With the comments
addressed, you can add:
Reviewed-by: Marcos Paulo de Souza
>
> Best Regards,
> Petr
kas Hruska
Reviewed-by: Marcos Paulo de Souza
> ---
> MAINTAINERS | 1 +
> include/uapi/linux/livepatch.h | 15 +++
> kernel/livepatch/core.c | 5 +++--
> 3 files changed, 19 insertions(+), 2 deletions(-)
> create mode 100644 includ
'i8042_dmi_noselftest_table[0].matches')
>
> Add the missing separator between the two.
Oops, my bad...
Thanks for fixing it Arnd.
Reviewed-by: Marcos Paulo de Souza
>
> Fixes: b5d6e7ab7fe7 ("Input: i8042 - add ASUS Zenbook Flip to
> noselftest list")
> Sig
From: Marcos Paulo de Souza
[BUG]
After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one
block group item"), cache->length is being assigned after calling
btrfs_create_block_group_cache. This causes a problem since
set_free_space_tree_thresholds is calculate t
From: Marcos Paulo de Souza
[BUG]
After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one
block group item"), cache->length is being assigned after calling
btrfs_create_block_group_cache. This causes a problem since
set_free_space_tree_thresholds is calculate t
From: Marcos Paulo de Souza
[BUG]
After commit 9afc66498a0b ("btrfs: block-group: refactor how we read one
block group item"), cache->length is being assigned after calling
btrfs_create_block_group_cache. This causes a problem since
set_free_space_tree_thresholds is calculate t
This argument was not being considered since blk-mq was set by default,
so removed this documentation to avoid confusion.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/kernel-per-CPU-kthreads.txt | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/Documentation
This argument was not being used since the legacy IO path was removed,
when blk-mq was enabled by default. So removed it from the kernel
parameters documentation.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/admin-guide/kernel-parameters.txt | 6 --
1 file changed, 6 deletions
Since the inclusion of blk-mq, elevator argument was not being
considered anymore, and it's utility died long with the legacy IO path,
now removed too.
Signed-off-by: Marcos Paulo de Souza
---
block/elevator.c | 14 --
1 file changed, 14 deletions(-)
diff --git a/block/elevato
ping?
On Mon, Jun 24, 2019 at 01:09:33PM -0300, Marcos Paulo de Souza wrote:
> set_capacity expects the disk size in sectors of 512 bytes, and changing
> the magic number 9 to SECTOR_SHIFT clarifies this intent.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> drivers/block
ping?
On Tue, Jun 18, 2019 at 07:44:54PM -0300, Marcos Paulo de Souza wrote:
> If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
>
> Signed-off-by: Marcos Paulo de Souza
> Acked
On Thu, Jun 20, 2019 at 04:32:38PM -0400, Martin K. Petersen wrote:
>
> Marcos,
>
> > My first idea was to add a vendor:product mapping at SCSI layer, but
> > so far I haven't found one, so I added the model/vendor found by
> > INQUIRY. Would it be better to check for prod:vendor (as values,
> >
humble ping :)
On Tue, Jun 18, 2019 at 07:44:54PM -0300, Marcos Paulo de Souza wrote:
> If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
>
> Signed-off-by: Marcos Paulo de Souza
> Acked
On Wed, Jun 19, 2019 at 06:45:43AM -0300, Marcos Paulo de Souza wrote:
> On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote:
> >
> > Marcos,
> >
> > > Currently, all USB devices skip VPD pages, even when the device
> > > supports them (SPC
On Wed, Jun 19, 2019 at 08:34:56AM +0200, Hannes Reinecke wrote:
> On 6/19/19 5:35 AM, Martin K. Petersen wrote:
> >
> > Marcos,
> >
> >> WWID composed from VPD data from device, specifically page 0x83. So,
> >> when a device does not have VPD support, for example USB storage
> >> devices where V
On Tue, Jun 18, 2019 at 11:21:22PM -0400, Martin K. Petersen wrote:
>
> Marcos,
>
> > Currently, all USB devices skip VPD pages, even when the device
> > supports them (SPC-3 and later), but some of them support VPD, like
> > Cruzer Blade.
>
> What's your confidence level wrt. all Cruzer Blades
ping? Can anybody take a look at this patch?
Thanks,
Marcos
On Tue, Jun 11, 2019 at 11:08:28PM -0300, Marcos Paulo de Souza wrote:
> WWID composed from VPD data from device, specifically page 0x83. So,
> when a device does not have VPD support, for example USB storage devices
> whe
On Tue, Jun 18, 2019 at 06:07:24PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 12:17:39PM -0300, Marcos Paulo de Souza wrote:
> > On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote:
> > > On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote:
> > >
>
If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
Signed-off-by: Marcos Paulo de Souza
Acked-by: Alan Stern
---
Changes from v1:
changed the check of try_vpd_pages from:
sdev->try_vpd_pages =
On Tue, Jun 18, 2019 at 09:48:01AM -0400, Alan Stern wrote:
> On Mon, 17 Jun 2019, Marcos Paulo de Souza wrote:
>
> > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> > be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
> >
> &g
On Tue, Jun 18, 2019 at 12:52:03PM +0200, Greg Kroah-Hartman wrote:
> On Tue, Jun 18, 2019 at 07:30:04AM -0300, Marcos Paulo de Souza wrote:
> > On Tue, Jun 18, 2019 at 08:49:47AM +0200, Greg Kroah-Hartman wrote:
> > > On Mon, Jun 17, 2019 at 10:31:46PM -0300, Marcos Pa
On Tue, Jun 18, 2019 at 08:49:47AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jun 17, 2019 at 10:31:46PM -0300, Marcos Paulo de Souza wrote:
> > If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
> > be honored, so only set skip_vpd_pages is try_vpd_p
://lkml.org/lkml/2019/6/11/1408
Marcos Paulo de Souza (2):
scsi: devinfo: BLIST_TRY_VPD_PAGES for SanDisk Cruzer Blade
usb: storage: scsiglue: Do not skip VPD if try_vpd_pages is set
drivers/scsi/scsi_devinfo.c| 2 ++
drivers/usb/storage/scsiglue.c | 7 +--
2 files changed, 7 insertions
Currently, all USB devices skip VPD pages, even when the device supports
them (SPC-3 and later), but some of them support VPD, like Cruzer Blade.
Signed-off-by: Marcos Paulo de Souza
---
drivers/scsi/scsi_devinfo.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi
If BLIST_TRY_VPD_PAGES is set for a device, even for an USB, it should
be honored, so only set skip_vpd_pages is try_vpd_pages is not set.
Signed-off-by: Marcos Paulo de Souza
---
drivers/usb/storage/scsiglue.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers
hide wwid sysfs file when the
devices does not support VPD.
Signed-off-by: Marcos Paulo de Souza
---
drivers/scsi/scsi_sysfs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index dbb206c90ecf..bfd890fa0c69 100644
--- a/drivers/scsi
Commit c42d3240990814eec1e4b2b93fa0487fc4873aed
("md: return -ENODEV if rdev has no mddev assigned") changed rdev_attr_store to
return -ENODEV when rdev->mddev is NULL, now do the same to rdev_attr_show.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/md.c | 2 +-
1 fi
ks
Marcos Paulo de Souza (5):
md cleanup
raid1-10: Unify r{1,10}bio_pool_free
raid0: Remove return statement from void function
md: raid0: Return md_integrity_register result directly
md: raid0: Make ret local in raid0_run
drivers/md/raid0.c| 8 ++--
drivers/md/raid1
Avoiding duplicated code, since they just execute a kfree.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid1-10.c | 5 +
drivers/md/raid1.c| 13 -
drivers/md/raid10.c | 11 +++
3 files changed, 12 insertions(+), 17 deletions(-)
diff --git a/drivers/md
This return statement was introduced in commit
1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 ("Linux-2.6.12-rc2") and can be
safely removed.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid0.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/md/raid0.c b/drivers/md/rai
Commit 0c35bd4723e4a39ba2da4c13a22cb97986ee10c8
("md: fix problems with freeing private data after ->run failure")
removed the check for the result of md_integrity_register, so we don't
need to store it anymore, so return it directly.
Signed-off-by: Marcos Paulo de Souza
---
ret variable is only used in a specific situation, so make it local
instead of global.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid0.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/md/raid0.c b/drivers/md/raid0.c
index e72255464c09..b28dbb797f76
ping.
On Thu, May 09, 2019 at 08:18:49AM -0300, Marcos Paulo de Souza wrote:
> These definitions are being moved to raid1-10.c.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> drivers/md/raid1-10.c | 25 +
> drivers/
These definitions are being moved to raid1-10.c.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/raid1-10.c | 25 +
drivers/md/raid1.c| 29 ++---
drivers/md/raid10.c | 27 +--
3 files changed, 28 insertions(+), 53
Describing better what the function does, what the arguments are meant for, and
what SQ stands for.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* Change "SQ" to "only one hw_queue (SQ)" in the function signature
documentation (suggested by Chaitan
Hi João,
On 2/13/19 7:46 PM, Marcos Paulo de Souza wrote:
Hello João,
On 2/12/19 2:30 PM, João Paulo Rechi Vita wrote:
On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza
wrote:
Hello João,
On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
Hello Marcos,
On Sun, Feb 10, 2019 at 5:05 PM
Hi Dmitry,
On 2/18/19 5:15 PM, Dmitry Torokhov wrote:
On Mon, Feb 18, 2019 at 03:21:10PM +0100, Rodrigo Rivas Costa wrote:
On Sun, Feb 17, 2019 at 09:42:52PM -0300, Marcos Paulo de Souza wrote:
- if (!wait_for_completion_timeout(&request->done, 30 * HZ)) {
+
Hello João,
On 2/12/19 2:30 PM, João Paulo Rechi Vita wrote:
> On Mon, Feb 11, 2019 at 6:31 PM Marcos Paulo de Souza
> wrote:
>>
>> Hello João,
>>
>> On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
>>> Hello Marcos,
>>>
>>> On Sun,
Hello João,
On 2/11/19 5:14 PM, João Paulo Rechi Vita wrote:
> Hello Marcos,
>
> On Sun, Feb 10, 2019 at 5:05 PM Marcos Paulo de Souza
> wrote:
>>
>>
>>
>> On 2/10/19 9:45 PM, Andy Shevchenko wrote:
>>> On Sun, Feb 10, 2019 at 9:24 PM M
On 2/10/19 9:45 PM, Andy Shevchenko wrote:
> On Sun, Feb 10, 2019 at 9:24 PM Marcos Paulo de Souza
> wrote:
>>
>> Hi,
>>
>> Since 5.0.0-rc4 I vefiried that my ASUS laptop
>
> Can you be more specific, what model, BIOS version, etc (also would be
> ni
Hi,
Since 5.0.0-rc4 I vefiried that my ASUS laptop cannot turn the screen of
anymore. There were several commits in 5.0 merge window touching this
functionality like:
71b12beaf12f platform/x86: asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan
codes
b3f2f3799a97 platform/x86: asus-nb-wmi: Map
The Notes section of the comment was removed, because now
blk_release_queue can only be executed from blk_cleanup_queue (being
called when the q->kobj reaches zero), and also blk_init_queue was removed
in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* Ty
Ping :)
On 1/30/19 11:11 PM, Marcos Paulo de Souza wrote:
> The Notes section of the comment was removed, because now
> blk_release_queue can only be executed from blk_cleanup_queue (being
> called when the q->kobj reaches zero), and also blk_init_queue was removed
> in a1ce35fa49
Ping :)
On 1/25/19 1:50 AM, Bart Van Assche wrote:
> On 1/24/19 6:01 PM, Marcos Paulo de Souza wrote:
>> Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
>> a newly created function called blk_exit_queue, including the call of
>> blkcg_exit_
The Notes section of the comment was removed, because now
blk_release_queue can only be executed from blk_cleanup_queue (being
called when the q->kobj reaches zero), and also blk_init_queue was removed
in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
This is basically a v2 of ht
Since 4cf6324b17e9, a portion of function blk_cleanup_queue was moved to
a newly created function called blk_exit_queue, including the call of
blkcg_exit_queue. So, adjust the documenation according.
Signed-off-by: Marcos Paulo de Souza
---
block/blk-cgroup.c | 2 +-
1 file changed, 1 insertion
HI Jeans,
On 1/15/19 1:54 AM, Jens Axboe wrote:
> On 1/14/19 8:06 PM, Marcos Paulo de Souza wrote:
>> blk_init_queue was removed in a1ce35fa4985.
>
> Honestly, most of that comment is wrong anyway. Since this isn't
> a visible API, I'd just kill the comment complete
blk_init_queue was removed in a1ce35fa4985.
Signed-off-by: Marcos Paulo de Souza
---
There are more two references in Documentation/block/biodoc.txt, but maybe that
file needs a rewrite in rst anyway?
block/blk-sysfs.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git
This argument was removed in 5f0ed774ed29.
Signed-off-by: Marcos Paulo de Souza
---
block/blk-core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index c78042975737..eba494f528cb 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -661,7 +661,6
ping?
On Sat, Dec 22, 2018 at 08:08:45AM -0200, Marcos Paulo de Souza wrote:
> bio_alloc_bioset return a bio pointer or NULL, so we can avoid storing
> the returned data into a new variable.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> drivers/md/md.c | 7 +--
&g
ping?
On Sat, Dec 22, 2018 at 08:03:54AM -0200, Marcos Paulo de Souza wrote:
> Instead of just using plain '1', as it improves readability.
>
> Signed-off-by: Marcos Paulo de Souza
> ---
> include/linux/blk_types.h | 2 +-
> 1 file changed, 1 insertion(+), 1 d
Patch sent by mistake. The commit message should be:
"Docs/kernel-api.rst: Remove blk-tag.c reference"
Thanks,
On Tue, Jan 01, 2019 at 10:40:14PM -0200, Marcos Paulo de Souza wrote:
> After 7ca01926463a, legacy rq tagging was removed, so block/blk-tag.c
> does not exists anymore.
: Cannot open file ./block/blk-tag.c
So remove blk-tag.c traces from kernel-api.rst file to silence these
warnings.
Signed-off-by: Marcos Paulo de Souza
---
Documentation/core-api/kernel-api.rst | 6 --
1 file changed, 6 deletions(-)
diff --git a/Documentation/core-api/kernel-api.rst
b
bio_alloc_bioset return a bio pointer or NULL, so we can avoid storing
the returned data into a new variable.
Signed-off-by: Marcos Paulo de Souza
---
drivers/md/md.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/md/md.c b/drivers/md/md.c
index fc488cb30a94
Instead of just using plain '1', as it improves readability.
Signed-off-by: Marcos Paulo de Souza
---
include/linux/blk_types.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 1dcf652ba0aa..905c666a0101 10
On Wed, May 02, 2018 at 04:12:18PM +0200, Christian Brauner wrote:
> On Wed, Apr 18, 2018 at 11:46:38PM -0300, Marcos Paulo de Souza wrote:
> > Found while inspecting the code that handles the setgroups procfs file.
>
> This is not really improving anything so I unfortunately don
Found while inspecting the code that handles the setgroups procfs file.
Signed-off-by: Marcos Paulo de Souza
---
Tested locally setting up a new userns, and setting setgroups as deny and allow,
worked as before.
kernel/user_namespace.c | 20 +++-
1 file changed, 7 insertions
On Thu, Nov 30, 2017 at 11:04:06AM +0100, Michal Hocko wrote:
> CC Eric
>
> On Sun 26-11-17 14:06:52, Marcos Paulo de Souza wrote:
> > Currently this check for CLONE_NEWIPC with CLONE_SYSVSEM is done inside
> > copy_namespaces, resulting in a handful of error paths being
because copy_namespaces is called just from
copy_process function.
Signed-off-by: Marcos Paulo de Souza
---
kernel/fork.c| 11 +++
kernel/nsproxy.c | 11 ---
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index 2113e252cb9d
Instead of calling blk_trace_bio_get_cgid(q, bio)) seven times, call it directly
inside blk_add_trace_bio.
Signed-off-by: Marcos Paulo de Souza
---
Discovered when checking the missing documentation of cgid in blk_add_trace_bio
function when running make pdfdocs.
kernel/trace/blktrace.c | 26
instead of passing cgid as a parameter.
Signed-off-by: Marcos Paulo de Souza
---
Discovered when checking the missing documentation of cgid in blk_add_trace_bio
function when running make pdfdocs.
kernel/trace/blktrace.c | 26 ++
1 file changed, 10 insertions(+), 16
Thus reducing one indentation level while maintaining the same
rationale.
Signed-off-by: Marcos Paulo de Souza
---
kernel/fork.c | 51 +--
1 file changed, 25 insertions(+), 26 deletions(-)
diff --git a/kernel/fork.c b/kernel/fork.c
index
All other places that deals with namespaces have an explanation of why
the restriction is there. The description added in this commit was based
in e66eded8309eb.
Signed-off-by: Marcos Paulo de Souza
---
kernel/fork.c | 4
1 file changed, 4 insertions(+)
diff --git a/kernel/fork.c b/kernel
The following commit fixes the following sparse report:
drivers/staging//unisys/visorhba/visorhba_main.c:660:29: warning: cast to
restricted __le64
by casting readq (which is unsigned long on x86) to u64, as expected by the
seq_printf call.
Signed-off-by: Marcos Paulo de Souza
---
Just
On Fri, Apr 28, 2017 at 12:29:55PM +0200, Greg Kroah-Hartman wrote:
> On Sun, Apr 23, 2017 at 05:51:17PM -0300, Marcos Paulo de Souza wrote:
> > Fix the following sparse warning:
> > rtl8192u/ieee80211/ieee80211_rx.c:1489:45: warning: incorrect type in
> > assignment
]
[usertype]
Since ac_params->tx_op_limit is already an __le16, we shouldn't convert it into
cpu type.
Signed-off-by: Marcos Paulo de Souza
---
Sorry, I don't have the hardware to test, so please review and tell me if I'm
wrong in this one!
drivers/staging/rtl8192u/ieee80211/
Signed-off-by: Marcos Paulo de Souza
---
v5 -> v6:
Resend v5, but now include a change into input_uapi.rst (added by Dmitry and
Mauro) to include the newly added uinput documentation.
v4 -> v5:
Fixed the way we detect the old interface of uinput (suggested by Peter)
v3 ->
On Wed, Mar 29, 2017 at 12:34:05PM +0200, Greg KH wrote:
> On Thu, Mar 23, 2017 at 04:09:03PM -0300, Marcos Paulo de Souza wrote:
> > On Wed, Mar 29, 2017 at 09:31:14AM +0200, Greg KH wrote:
> > > On Tue, Mar 28, 2017 at 11:14:06PM -0300, Marcos Paulo de Souza wrote:
> >
On Wed, Mar 29, 2017 at 09:31:14AM +0200, Greg KH wrote:
> On Tue, Mar 28, 2017 at 11:14:06PM -0300, Marcos Paulo de Souza wrote:
> > head_up parameter is marked with __user attribute, tmp is filled
> > by a copy_from_user from next, that is also marked as __user, so
> >
head_up parameter is marked with __user attribute, tmp is filled
by a copy_from_user from next, that is also marked as __user, so
tmp.next needs to be "casted" as __user to make sparse happy.
Signed-off-by: Marcos Paulo de Souza
---
this is mt first patch addressing an issue of spar
Signed-off-by: Marcos Paulo de Souza
---
v3 -> v4:
Add comment and a sleep call before UI_DEV_DESTROY (requested by Peter)
On emit function, add an fd parameter, avoiding global variables
Check return of ioctl related to older kernels that don't have UI_GET_VERSION
Fix typos
On Mon, Mar 27, 2017 at 11:06:11AM +1000, Peter Hutterer wrote:
> On Sun, Mar 26, 2017 at 01:48:12PM -0300, Marcos Paulo de Souza wrote:
> > Signed-off-by: Marcos Paulo de Souza
> > ---
> > v2 -> v3:
> > Changes in libevdev's description (suggested by Peter)
&
On Mon, Mar 27, 2017 at 08:52:58AM +1000, Peter Hutterer wrote:
> On Sun, Mar 26, 2017 at 01:21:14PM -0300, Marcos Paulo de Souza wrote:
> > On Fri, Mar 24, 2017 at 02:39:13PM +1000, Peter Hutterer wrote:
> > > as usual, reading through these things multiple times means one spots
Hi all,
this is the third version of the patchset, solved some typos and suggestions
from
Peter and Jon Corbet.
Thanks for the suggestions. I hope this version is better than the last one.
Marcos Paulo de Souza (1):
Documentation: Input: Add uinput documentation
Documentation/input
Signed-off-by: Marcos Paulo de Souza
---
v2 -> v3:
Changes in libevdev's description (suggested by Peter)
Added uinput version check when using the old interface (suggested by Peter)
Removed section numbers from sections, sphinx creates these indexes
(suggestion by Jon)
On Fri, Mar 24, 2017 at 02:39:13PM +1000, Peter Hutterer wrote:
> as usual, reading through these things multiple times means one spots a
> couple of different things. sorry about that.
>
> On Fri, Mar 24, 2017 at 12:34:59AM -0300, Marcos Paulo de Souza wrote:
> > Signed-off-b
Signed-off-by: Marcos Paulo de Souza
---
Documentation/input/uinput.rst | 196 +
1 file changed, 196 insertions(+)
create mode 100644 Documentation/input/uinput.rst
diff --git a/Documentation/input/uinput.rst b/Documentation/input/uinput.rst
new file
On Thu, Mar 23, 2017 at 01:23:56PM +1000, Peter Hutterer wrote:
> On Wed, Mar 22, 2017 at 11:54:48PM -0300, Marcos Paulo de Souza wrote:
> > Hi Peter,
> >
> > first of all, thanks a lot for reading this patch so quickly and to
> > point a lot of things to make this d
e of the guesswork
> out. While it's good to have documentation for the kernel module,
> application authors should really use libevdev's uinput interface.
>
> On Tue, Mar 21, 2017 at 11:58:17PM -0300, Marcos Paulo de Souza wrote:
> > Signed-off
d here:
https://marcosps.github.io/
* Let me know if you find anything that can make the documentation more clear,
or
anything that can make the code better
Marcos Paulo de Souza (1):
Documentation: Input: Add uinput documentation
Documentation/input/u
Signed-off-by: Marcos Paulo de Souza
---
Documentation/input/uinput.rst | 158 +
1 file changed, 158 insertions(+)
create mode 100644 Documentation/input/uinput.rst
diff --git a/Documentation/input/uinput.rst b/Documentation/input/uinput.rst
new file
.matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Embedded Box PC 3000"),
> + },
> + },
> + {
> /* OQO Model 01 */
>
DMI_MATCH(DMI_PRODUCT_VERSION, "V1.31"),
> },
> },
> + {
> + /* TUXEDO BU1406 */
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Notebook"),
> + DMI_MATCH(DMI_PRODUCT_N
02 <- alps_v5_protocol_data
> > E7=73 03 0a, EC=88 b3 22 <- alps_v7_protocol_data
> > E7=73 03 0a, EC=88 b3 18 <- alps_v7_protocol_data
> >
> > Best Regards,
> > Masaki Ota
> > -Original Message-
> > From: Pali Rohár [mailto:pali.ro.
Hi John and Pali,
On Sun, Feb 19, 2017 at 03:24:58PM +, John Preston wrote:
> On 2017-02-19 13:35, Pali Rohár wrote:
> > On Sunday 19 February 2017 13:16:34 John L. Preston wrote:
> > > ---
> > > drivers/input/mouse/alps.c | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/
This can happen in cases like bug #102951[1], so add a proper debug msg
as done in wait_read. Also, change wait_read debug message to differ from
wait_write.
[1] https://bugzilla.kernel.org/show_bug.cgi?id=102951
Signed-off-by: Marcos Paulo de Souza
---
Changes from v1:
* use dbg instead of
uint32_t format, uint32_t rate, u8 channels,
Signed-off-by: Marcos Paulo de Souza
---
drivers/staging/greybus/audio_gb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/greybus/audio_gb.c
b/drivers/staging/greybus/audio_gb.c
index 42f287d..7884
1 - 100 of 171 matches
Mail list logo
