[PATCH v5 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-06 Thread Mario Limonciello
to a sysfs attribute. The API for interacting with this interface is defined in documentation as well as a uapi header provides the format of the structures. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- Documentation/ABI/testing/dell-smbios-wmi | 41 .

[PATCH v5 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs

2017-10-06 Thread Mario Limonciello
-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/wmi.c | 17 - include/linux/wmi.h| 4 2 files changed, 21 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 4d73a87c2ddf..bcb41c1c7f52

[PATCH v5 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-06 Thread Mario Limonciello
to a sysfs attribute. The API for interacting with this interface is defined in documentation as well as a uapi header provides the format of the structures. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/dell-smbios-wmi | 41 .../ABI/testing/sysfs-platform-dell

[PATCH v5 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs

2017-10-06 Thread Mario Limonciello
-off-by: Mario Limonciello --- drivers/platform/x86/wmi.c | 17 - include/linux/wmi.h| 4 2 files changed, 21 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 4d73a87c2ddf..bcb41c1c7f52 100644 --- a/drivers/platform/x86/wmi.c +++ b

[PATCH v5 12/14] platform/x86: dell-smbios-smm: test for WSMT

2017-10-06 Thread Mario Limonciello
-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios-smm.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/platform/x86/dell-smbios-smm.c b/drivers/platform/x86/dell-smbios-smm.c index 223531e43fea..ba3157

[PATCH v5 12/14] platform/x86: dell-smbios-smm: test for WSMT

2017-10-06 Thread Mario Limonciello
-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios-smm.c | 34 ++ 1 file changed, 34 insertions(+) diff --git a/drivers/platform/x86/dell-smbios-smm.c b/drivers/platform/x86/dell-smbios-smm.c index 223531e43fea..ba315753e847 100644 --- a/drivers

[PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures

2017-10-04 Thread Mario Limonciello
of the data should not be relied upon. For the remaining data set vectors, continue to notate a warning in undefined results, but as those are fields that the descriptor intended to refer to other applications, don't fail if they're new values. Signed-off-by: Mario Limonciello <mario.limon

[PATCH v4 04/14] platform/x86: dell-wmi: increase severity of some failures

2017-10-04 Thread Mario Limonciello
of the data should not be relied upon. For the remaining data set vectors, continue to notate a warning in undefined results, but as those are fields that the descriptor intended to refer to other applications, don't fail if they're new values. Signed-off-by: Mario Limonciello --- drivers/platform/x86

[PATCH v4 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs

2017-10-04 Thread Mario Limonciello
-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/wmi.c | 17 - include/linux/wmi.h| 4 2 files changed, 21 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 4d73a87c2ddf..bcb41c1c7f52

[PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

2017-10-04 Thread Mario Limonciello
. This is intentionally marked to only be readable as root as it can contain sensitive information about the platform's configuration. MAINTAINERS was missing for this driver. Add myself and Pali to maintainers list for it. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> Suggested-by

[PATCH v4 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs

2017-10-04 Thread Mario Limonciello
-off-by: Mario Limonciello --- drivers/platform/x86/wmi.c | 17 - include/linux/wmi.h| 4 2 files changed, 21 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index 4d73a87c2ddf..bcb41c1c7f52 100644 --- a/drivers/platform/x86/wmi.c +++ b

[PATCH v4 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

2017-10-04 Thread Mario Limonciello
. This is intentionally marked to only be readable as root as it can contain sensitive information about the platform's configuration. MAINTAINERS was missing for this driver. Add myself and Pali to maintainers list for it. Signed-off-by: Mario Limonciello Suggested-by: Andy Shevchenko --- .../ABI

[PATCH v4 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

2017-10-04 Thread Mario Limonciello
driver-...@vger.kernel.org S: Maintained F: drivers/platform/x86/dell-smbios.* +DELL SMBIOS SMM DRIVER +M: Mario Limonciello <mario.limoncie...@dell.com> +L: platform-driver-...@vger.kernel.org +S: Maintained +F: drivers/platform/x86/dell-smbios-smm.* + DELL LAPTOP DRIVER M:

[PATCH v4 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

2017-10-04 Thread Mario Limonciello
F: drivers/platform/x86/dell-smbios.* +DELL SMBIOS SMM DRIVER +M: Mario Limonciello +L: platform-driver-...@vger.kernel.org +S: Maintained +F: drivers/platform/x86/dell-smbios-smm.* + DELL LAPTOP DRIVER M: Matthew Garrett M: Pali Rohár diff --git a/drivers

[PATCH v4 03/14] platform/x86: dell-wmi: allow 32k return size in the descriptor

2017-10-04 Thread Mario Limonciello
Some platforms this year will be adopting 32k WMI buffer, so don't complain when encountering those. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x8

[PATCH v4 03/14] platform/x86: dell-wmi: allow 32k return size in the descriptor

2017-10-04 Thread Mario Limonciello
Some platforms this year will be adopting 32k WMI buffer, so don't complain when encountering those. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform

[PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

2017-10-04 Thread Mario Limonciello
. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- MAINTAINERS| 5 + drivers/platform/x86/Kconfig | 12 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/dell-wmi-descriptor.c

[PATCH v4 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

2017-10-04 Thread Mario Limonciello
. Signed-off-by: Mario Limonciello --- MAINTAINERS| 5 + drivers/platform/x86/Kconfig | 12 +++ drivers/platform/x86/Makefile | 1 + drivers/platform/x86/dell-wmi-descriptor.c | 162 + drivers/platform/x86/dell

[PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-04 Thread Mario Limonciello
the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- MAINTAINERS| 1 + drivers/platform/x86/wmi.c | 67 +- include/linux/wmi.h| 2 ++ include/uapi/linux/wmi.h

[PATCH v4 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver

2017-10-04 Thread Mario Limonciello
this to operate over WMI-ACPI will use an ACPI OperationRegion for a buffer of data storage when SMM calls are performed. This is a safer approach to use in kernel drivers as the SMM will only have access to that OperationRegion. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.

[PATCH v4 12/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-04 Thread Mario Limonciello
the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello --- MAINTAINERS| 1 + drivers/platform/x86/wmi.c | 67 +- include/linux/wmi.h| 2 ++ include/uapi/linux/wmi.h | 10 +++ 4 files changed, 79

[PATCH v4 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver

2017-10-04 Thread Mario Limonciello
this to operate over WMI-ACPI will use an ACPI OperationRegion for a buffer of data storage when SMM calls are performed. This is a safer approach to use in kernel drivers as the SMM will only have access to that OperationRegion. Signed-off-by: Mario Limonciello --- MAINTAINERS

[PATCH v4 10/14] platform/x86: dell-smbios-smm: test for WSMT

2017-10-04 Thread Mario Limonciello
-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios-smm.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers/platform/x86/dell-smbios-smm.c b/drivers/platform/x86/dell-smbios-smm.c index 2e1c5d2dfd61..3271e9

[PATCH v4 10/14] platform/x86: dell-smbios-smm: test for WSMT

2017-10-04 Thread Mario Limonciello
-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios-smm.c | 36 ++ 1 file changed, 36 insertions(+) diff --git a/drivers/platform/x86/dell-smbios-smm.c b/drivers/platform/x86/dell-smbios-smm.c index 2e1c5d2dfd61..3271e9a876e9 100644 --- a/drivers

[PATCH v4 14/14] platform/x86: Kconfig: Set default for dell-smbios to ACPI_WMI

2017-10-04 Thread Mario Limonciello
The dell-smbios driver no longer depends on dcdbas, and it should now be offered with the preferred WMI backend when the WMI bus is enabled. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/d

[PATCH v4 13/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-04 Thread Mario Limonciello
the format of the structures. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- Documentation/ABI/testing/dell-smbios-wmi | 43 ++ .../ABI/testing/sysfs-platform-dell-smbios-wmi | 10 +++ MAINTAINERS| 1 + drivers/platfo

[PATCH v4 14/14] platform/x86: Kconfig: Set default for dell-smbios to ACPI_WMI

2017-10-04 Thread Mario Limonciello
The dell-smbios driver no longer depends on dcdbas, and it should now be offered with the preferred WMI backend when the WMI bus is enabled. Signed-off-by: Mario Limonciello --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b

[PATCH v4 13/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-04 Thread Mario Limonciello
the format of the structures. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/dell-smbios-wmi | 43 ++ .../ABI/testing/sysfs-platform-dell-smbios-wmi | 10 +++ MAINTAINERS| 1 + drivers/platform/x86/dell-smbios-wmi.c

[PATCH v4 00/14] Introduce support for Dell SMBIOS over WMI

2017-10-04 Thread Mario Limonciello
r patches so all fixups come first in the series. Mario Limonciello (14): platform/x86: wmi: Add new method wmidev_evaluate_method platform/x86: dell-wmi: clean up wmi descriptor check platform/x86: dell-wmi: allow 32k return size in the descriptor platform/x86: dell-wmi: increase severit

[PATCH v4 00/14] Introduce support for Dell SMBIOS over WMI

2017-10-04 Thread Mario Limonciello
r patches so all fixups come first in the series. Mario Limonciello (14): platform/x86: wmi: Add new method wmidev_evaluate_method platform/x86: dell-wmi: clean up wmi descriptor check platform/x86: dell-wmi: allow 32k return size in the descriptor platform/x86: dell-wmi: increase severit

[PATCH v4 01/14] platform/x86: wmi: Add new method wmidev_evaluate_method

2017-10-04 Thread Mario Limonciello
Drivers properly using the wmibus can pass their wmi_device pointer rather than the GUID back to the WMI bus to evaluate the proper methods. Any "new" drivers added that use the WMI bus should use this rather than the old wmi_evaluate_method that would take the GUID. Signed-off

[PATCH v4 02/14] platform/x86: dell-wmi: clean up wmi descriptor check

2017-10-04 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> Reviewed-by: Edward O'Callaghan <quasi...@google.com> Suggested-by: Andy Shevchenko <andy.shevche...@gmail.com> --- drivers/platf

[PATCH v4 01/14] platform/x86: wmi: Add new method wmidev_evaluate_method

2017-10-04 Thread Mario Limonciello
Drivers properly using the wmibus can pass their wmi_device pointer rather than the GUID back to the WMI bus to evaluate the proper methods. Any "new" drivers added that use the WMI bus should use this rather than the old wmi_evaluate_method that would take the GUID. Signed-off

[PATCH v4 02/14] platform/x86: dell-wmi: clean up wmi descriptor check

2017-10-04 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello Reviewed-by: Edward O'Callaghan Suggested-by: Andy Shevchenko --- drivers/platform/x86/dell-wmi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v4 07/14] platform/x86: dell-smbios: only run if proper oem string is detected

2017-10-04 Thread Mario Limonciello
The proper way to indicate that a system is a 'supported' Dell System is by the presence of this string in OEM strings. Allowing the driver to load on non-Dell systems will have undefined results. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x8

[PATCH v4 07/14] platform/x86: dell-smbios: only run if proper oem string is detected

2017-10-04 Thread Mario Limonciello
The proper way to indicate that a system is a 'supported' Dell System is by the presence of this string in OEM strings. Allowing the driver to load on non-Dell systems will have undefined results. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 7 +++ 1 file

[PATCH v3 3/8] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

2017-09-27 Thread Mario Limonciello
check into dell-wmi-smbios and let both drivers use it from there. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios.c | 81 ++ drivers/platform/x86/dell-smbios.h | 3 ++ drivers/platform/x86/dell-wmi.c

[PATCH v3 3/8] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

2017-09-27 Thread Mario Limonciello
check into dell-wmi-smbios and let both drivers use it from there. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 81 ++ drivers/platform/x86/dell-smbios.h | 3 ++ drivers/platform/x86/dell-wmi.c| 75

[PATCH v3 7/8] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios

2017-09-27 Thread Mario Limonciello
The dell-wmi-smbios driver should be enabled by default when ACPI_WMI is enabled (like many other WMI drivers). Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kco

[PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI

2017-09-27 Thread Mario Limonciello
nse with multiple different ioctl methods. * Default WMI interface to 32k (This would normally be queried via MOF, but that's not possible yet) * Create separate buffers for WMI and SMI. If WMI is available, free the SMI buffer. * Reorder patches so all fixups come first in the series. Ma

[PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface

2017-09-27 Thread Mario Limonciello
option. When modifying this, add myself to MAINTAINERS. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- MAINTAINERS| 6 ++ drivers/platform/x86/Kconfig | 14 ++-- drivers/platform/x86/dell-smbios.c

[PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers

2017-09-27 Thread Mario Limonciello
access to this character device and proper locking on it. When a WMI vendor driver is unloaded the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/wmi.

[PATCH v3 7/8] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios

2017-09-27 Thread Mario Limonciello
The dell-wmi-smbios driver should be enabled by default when ACPI_WMI is enabled (like many other WMI drivers). Signed-off-by: Mario Limonciello --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index

[PATCH v3 0/8] Introduce support for Dell SMBIOS over WMI

2017-09-27 Thread Mario Limonciello
nse with multiple different ioctl methods. * Default WMI interface to 32k (This would normally be queried via MOF, but that's not possible yet) * Create separate buffers for WMI and SMI. If WMI is available, free the SMI buffer. * Reorder patches so all fixups come first in the series. Ma

[PATCH v3 2/8] platform/x86: dell-smbios: Introduce a WMI-ACPI interface

2017-09-27 Thread Mario Limonciello
option. When modifying this, add myself to MAINTAINERS. Signed-off-by: Mario Limonciello --- MAINTAINERS| 6 ++ drivers/platform/x86/Kconfig | 14 ++-- drivers/platform/x86/dell-smbios.c | 128 - drivers/platform/x86/dell

[PATCH v3 4/8] platform/x86: wmi: create character devices when requested by drivers

2017-09-27 Thread Mario Limonciello
access to this character device and proper locking on it. When a WMI vendor driver is unloaded the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello --- drivers/platform/x86/wmi.c | 98 +++--- include/linux/wmi.h

[PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-27 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> Reviewed-by: Edward O'Callaghan <quasi...@google.com> --- drivers/platform/x86/dell-smbios.c | 10 +- 1 file changed, 5 inse

[PATCH v3 8/8] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-27 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello Reviewed-by: Edward O'Callaghan --- drivers/platform/x86/dell-smbios.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell

[PATCH v3 6/8] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens

2017-09-27 Thread Mario Limonciello
. This is intentionally marked to only be readable as root as it can contain sensitive information about the platform's configuration. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- .../ABI/testing/sysfs-platform-dell-wmi-smbios | 16 ++ drivers/platform/x86/dell-sm

[PATCH v3 6/8] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens

2017-09-27 Thread Mario Limonciello
. This is intentionally marked to only be readable as root as it can contain sensitive information about the platform's configuration. Signed-off-by: Mario Limonciello --- .../ABI/testing/sysfs-platform-dell-wmi-smbios | 16 ++ drivers/platform/x86/dell-smbios.c | 36

[PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-09-27 Thread Mario Limonciello
with this interface is defined in documentation as well as a uapi header provides the format of the structures. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- Documentation/ABI/testing/dell-wmi-smbios | 11 drivers/platform/x86/dell-smbios.c

[PATCH v3 5/8] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-09-27 Thread Mario Limonciello
with this interface is defined in documentation as well as a uapi header provides the format of the structures. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/dell-wmi-smbios | 11 drivers/platform/x86/dell-smbios.c| 100 -- drivers/platform/x86/dell

[PATCH v3 1/8] platform/x86: wmi: Add new method wmidev_evaluate_method

2017-09-27 Thread Mario Limonciello
Drivers properly using the wmibus can pass their wmi_device pointer rather than the GUID back to the WMI bus to evaluate the proper methods. Any "new" drivers added that use the WMI bus should use this rather than the old wmi_evaluate_method that would take the GUID. Signed-off

[PATCH v3 1/8] platform/x86: wmi: Add new method wmidev_evaluate_method

2017-09-27 Thread Mario Limonciello
Drivers properly using the wmibus can pass their wmi_device pointer rather than the GUID back to the WMI bus to evaluate the proper methods. Any "new" drivers added that use the WMI bus should use this rather than the old wmi_evaluate_method that would take the GUID. Signed-off

[PATCH v2 01/14] platform/x86: dell-wmi: label driver as handling notifications

2017-09-26 Thread Mario Limonciello
This driver serves the purpose of responding to WMI based notifications from the DELL_EVENT_GUID (9DBB5994-A997-11DA-B012-B622A1EF5492). Other GUIDs will be handled by separate drivers. Update the language used by this driver to avoid future confusion. Signed-off-by: Mario Limonciello

[PATCH v2 01/14] platform/x86: dell-wmi: label driver as handling notifications

2017-09-26 Thread Mario Limonciello
This driver serves the purpose of responding to WMI based notifications from the DELL_EVENT_GUID (9DBB5994-A997-11DA-B012-B622A1EF5492). Other GUIDs will be handled by separate drivers. Update the language used by this driver to avoid future confusion. Signed-off-by: Mario Limonciello

[PATCH v2 07/14] platform/x86: wmi: destroy on cleanup rather than unregister

2017-09-26 Thread Mario Limonciello
device_create documentation says to cleanup using device_destroy Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c

[PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor GUID modalias

2017-09-26 Thread Mario Limonciello
The descriptor GUID is not used to indicate that WMI notifications in the dell-wmi driver work properly. As such a modalias should not be present that causes this driver to load on systems with this GUID. Reviewed-by: Pali Pohar <pali.ro...@gmail.com> Signed-off-by: Mario Limon

[PATCH v2 05/14] platform/x86: wmi: sort include list

2017-09-26 Thread Mario Limonciello
The include list is randomly assembled right now. Sort in alphabetical order. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/wmi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/d

[PATCH v2 06/14] platform/x86: wmi: Cleanup exit routine in reverse order of init

2017-09-26 Thread Mario Limonciello
The initialize routine is: * class -> bus -> platform The exit routine is: * platform -> class -> bus Fix the exit routine to be: * platform -> bus -> class Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/wmi.c | 2 +- 1 file ch

[PATCH v2 10/14] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

2017-09-26 Thread Mario Limonciello
check into dell-wmi-smbios and let both drivers use it from there. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-wmi-smbios.c | 84 ++ drivers/platform/x86/dell-wmi-smbios.h | 3 ++ drivers/platform/x86/dell

[PATCH v2 07/14] platform/x86: wmi: destroy on cleanup rather than unregister

2017-09-26 Thread Mario Limonciello
device_create documentation says to cleanup using device_destroy Signed-off-by: Mario Limonciello --- drivers/platform/x86/wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index acbc2b02db3d..7a05843aff19

[PATCH v2 03/14] platform/x86: dell-wmi: Don't match on descriptor GUID modalias

2017-09-26 Thread Mario Limonciello
The descriptor GUID is not used to indicate that WMI notifications in the dell-wmi driver work properly. As such a modalias should not be present that causes this driver to load on systems with this GUID. Reviewed-by: Pali Pohar Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell

[PATCH v2 05/14] platform/x86: wmi: sort include list

2017-09-26 Thread Mario Limonciello
The include list is randomly assembled right now. Sort in alphabetical order. Signed-off-by: Mario Limonciello --- drivers/platform/x86/wmi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/platform/x86/wmi.c b/drivers/platform/x86/wmi.c index

[PATCH v2 06/14] platform/x86: wmi: Cleanup exit routine in reverse order of init

2017-09-26 Thread Mario Limonciello
The initialize routine is: * class -> bus -> platform The exit routine is: * platform -> class -> bus Fix the exit routine to be: * platform -> bus -> class Signed-off-by: Mario Limonciello --- drivers/platform/x86/wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH v2 10/14] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

2017-09-26 Thread Mario Limonciello
check into dell-wmi-smbios and let both drivers use it from there. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-wmi-smbios.c | 84 ++ drivers/platform/x86/dell-wmi-smbios.h | 3 ++ drivers/platform/x86/dell-wmi.c| 75

[PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes

2017-09-26 Thread Mario Limonciello
These aren't needed to compile the module. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 0a5723

[PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi-smbios

2017-09-26 Thread Mario Limonciello
of people maintaing it. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/Makefile | 2 +- d

[PATCH v2 11/14] platform/x86: wmi: create character devices when requested by drivers

2017-09-26 Thread Mario Limonciello
that maps to those file operations. The WMI vendor drivers will be responsible for managing access to this character device and proper locking on it. When a WMI vendor driver is unloaded the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello <mario.limon

[PATCH v2 02/14] platform/x86: dell-smbios: drop needless includes

2017-09-26 Thread Mario Limonciello
These aren't needed to compile the module. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 0a5723468bff..6654ad44a04c 100644 --- a/drivers

[PATCH v2 09/14] platform/x86: dell-smbios: rename to dell-wmi-smbios

2017-09-26 Thread Mario Limonciello
of people maintaing it. Signed-off-by: Mario Limonciello --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/Makefile | 2 +- drivers/platform/x86/dell-laptop.c

[PATCH v2 11/14] platform/x86: wmi: create character devices when requested by drivers

2017-09-26 Thread Mario Limonciello
that maps to those file operations. The WMI vendor drivers will be responsible for managing access to this character device and proper locking on it. When a WMI vendor driver is unloaded the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello --- drivers

[PATCH v2 13/14] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios

2017-09-26 Thread Mario Limonciello
The dell-wmi-smbios driver should be enabled by default when ACPI_WMI is enabled (like many other WMI drivers). Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kco

[PATCH v2 08/14] platform/x86: dell-smbios: Introduce a WMI-ACPI interface

2017-09-26 Thread Mario Limonciello
option. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Kconfig | 8 +- drivers/platform/x86/dell-smbios.c | 150 ++--- drivers/platform/x86/dell-smbios.h | 15 +++- 3 files changed, 140 insertions(+), 33 del

[PATCH v2 13/14] platform/x86: Kconfig: Change the default settings for dell-wmi-smbios

2017-09-26 Thread Mario Limonciello
The dell-wmi-smbios driver should be enabled by default when ACPI_WMI is enabled (like many other WMI drivers). Signed-off-by: Mario Limonciello --- drivers/platform/x86/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig index

[PATCH v2 08/14] platform/x86: dell-smbios: Introduce a WMI-ACPI interface

2017-09-26 Thread Mario Limonciello
option. Signed-off-by: Mario Limonciello --- drivers/platform/x86/Kconfig | 8 +- drivers/platform/x86/dell-smbios.c | 150 ++--- drivers/platform/x86/dell-smbios.h | 15 +++- 3 files changed, 140 insertions(+), 33 deletions(-) diff --git a/drivers/platform

[PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-26 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-wmi-smbios.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/de

[PATCH v2 12/14] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-09-26 Thread Mario Limonciello
. The character device will only be created if the WMI interface was found. The API for interacting with this interface is defined in documentation as well as a uapi header provides the format of the structures. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- Documentati

[PATCH v2 14/14] platform/x86: dell-wmi-smbios: clean up wmi descriptor check

2017-09-26 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-wmi-smbios.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/dell-wmi-smbios.c b/drivers

[PATCH v2 12/14] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-09-26 Thread Mario Limonciello
. The character device will only be created if the WMI interface was found. The API for interacting with this interface is defined in documentation as well as a uapi header provides the format of the structures. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/dell-wmi-smbios | 10

[PATCH v2 04/14] platform/x86: dell-smbios: Add pr_fmt definition to driver

2017-09-26 Thread Mario Limonciello
pr_fmt provides formatting to be used by the driver when displaying errors and messages. Reviewed-by: Pali Pohar <pali.ro...@gmail.com> Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios.c | 1 + 1 file changed, 1 insertion(+) diff --g

[PATCH v2 04/14] platform/x86: dell-smbios: Add pr_fmt definition to driver

2017-09-26 Thread Mario Limonciello
pr_fmt provides formatting to be used by the driver when displaying errors and messages. Reviewed-by: Pali Pohar Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform

[PATCH v2 00/14] Introduce support for Dell SMBIOS over WMI

2017-09-26 Thread Mario Limonciello
. * Reorder patches so all fixups come first in the series. Mario Limonciello (14): platform/x86: dell-wmi: label driver as handling notifications platform/x86: dell-smbios: drop needless includes platform/x86: dell-wmi: Don't match on descriptor GUID modalias platform/x86: dell-smbios: Add

[PATCH v2 00/14] Introduce support for Dell SMBIOS over WMI

2017-09-26 Thread Mario Limonciello
. * Reorder patches so all fixups come first in the series. Mario Limonciello (14): platform/x86: dell-wmi: label driver as handling notifications platform/x86: dell-smbios: drop needless includes platform/x86: dell-wmi: Don't match on descriptor GUID modalias platform/x86: dell-smbios: Add

[PATCH 03/12] platform/x86: dell-smbios: Add pr_fmt definition to driver

2017-09-21 Thread Mario Limonciello
Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-smbios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 0a5723468bff..e9b1ca07c872 100644 --- a/drivers/platform/x8

[PATCH 03/12] platform/x86: dell-smbios: Add pr_fmt definition to driver

2017-09-21 Thread Mario Limonciello
Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/platform/x86/dell-smbios.c b/drivers/platform/x86/dell-smbios.c index 0a5723468bff..e9b1ca07c872 100644 --- a/drivers/platform/x86/dell-smbios.c +++ b/drivers

[PATCH 05/12] platform/x86: dell-smbios: rename to dell-wmi-smbios

2017-09-21 Thread Mario Limonciello
of people maintaing it. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/Makefile| 2 +- drivers/platfo

[PATCH 05/12] platform/x86: dell-smbios: rename to dell-wmi-smbios

2017-09-21 Thread Mario Limonciello
of people maintaing it. Signed-off-by: Mario Limonciello --- MAINTAINERS | 6 ++ drivers/platform/x86/Kconfig | 2 +- drivers/platform/x86/Makefile| 2 +- drivers/platform/x86/dell-laptop.c

[PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface

2017-09-21 Thread Mario Limonciello
in kernel drivers as the platform will only have access to that OperationRegion. As a result, this change removes the dependency on this driver on the dcdbas kernel module. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/Kconfig | 8 ++-- drivers/platfo

[PATCH 04/12] platform/x86: dell-smbios: Switch to a WMI-ACPI interface

2017-09-21 Thread Mario Limonciello
in kernel drivers as the platform will only have access to that OperationRegion. As a result, this change removes the dependency on this driver on the dcdbas kernel module. Signed-off-by: Mario Limonciello --- drivers/platform/x86/Kconfig | 8 ++-- drivers/platform/x86/dell-smbios.c | 76

[PATCH 11/12] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-09-21 Thread Mario Limonciello
for the driver to provide a R/W ioctl to ensure that two competing userspace processes don't race to provide or read each others data. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- Documentation/ABI/testing/dell-wmi-smbios | 19 ++ drivers/platform/x86/dell-wmi-smbios.c

[PATCH 11/12] platform/x86: dell-wmi-smbios: introduce character device for userspace

2017-09-21 Thread Mario Limonciello
for the driver to provide a R/W ioctl to ensure that two competing userspace processes don't race to provide or read each others data. Signed-off-by: Mario Limonciello --- Documentation/ABI/testing/dell-wmi-smbios | 19 ++ drivers/platform/x86/dell-wmi-smbios.c| 108

[PATCH 06/12] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens

2017-09-21 Thread Mario Limonciello
. This is intentionally marked to only be readable as root as it can contain sensitive information about the platform's configuration. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- .../ABI/testing/sysfs-platform-dell-wmi-smbios | 16 + drivers/platform/x86/dell-wmi-sm

[PATCH 06/12] platform/x86: dell-wmi-smbios: Add a sysfs interface for SMBIOS tokens

2017-09-21 Thread Mario Limonciello
. This is intentionally marked to only be readable as root as it can contain sensitive information about the platform's configuration. Signed-off-by: Mario Limonciello --- .../ABI/testing/sysfs-platform-dell-wmi-smbios | 16 + drivers/platform/x86/dell-wmi-smbios.c | 38

[PATCH 09/12] platform/x86: wmi: create character devices when requested by drivers

2017-09-21 Thread Mario Limonciello
that maps to those file operations. The WMI vendor drivers will be responsible for managing access to this character device and proper locking on it. When a WMI vendor driver is unloaded the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello <mario.limon

[PATCH 09/12] platform/x86: wmi: create character devices when requested by drivers

2017-09-21 Thread Mario Limonciello
that maps to those file operations. The WMI vendor drivers will be responsible for managing access to this character device and proper locking on it. When a WMI vendor driver is unloaded the WMI bus driver will clean up the character device. Signed-off-by: Mario Limonciello --- drivers

[PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

2017-09-21 Thread Mario Limonciello
check into dell-wmi-smbios and let both drivers use it from there. Signed-off-by: Mario Limonciello <mario.limoncie...@dell.com> --- drivers/platform/x86/dell-wmi-smbios.c | 78 ++ drivers/platform/x86/dell-wmi-smbios.h | 3 ++ drivers/platform/x86/dell

[PATCH 07/12] platform/x86: dell-wmi-smbios: Use Dell WMI descriptor check

2017-09-21 Thread Mario Limonciello
check into dell-wmi-smbios and let both drivers use it from there. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-wmi-smbios.c | 78 ++ drivers/platform/x86/dell-wmi-smbios.h | 3 ++ drivers/platform/x86/dell-wmi.c| 75

[PATCH 00/12] Introduce support for Dell SMBIOS over WMI

2017-09-21 Thread Mario Limonciello
that needs for userspace and kernel space this patch series introduces a generic way for WMI drivers to be able to create character devices through the WMI bus when desired. Requiring WMI drivers to explictly ask for this functionality will act as an effective vendor whitelist. Mario Limonciello (12

[PATCH 00/12] Introduce support for Dell SMBIOS over WMI

2017-09-21 Thread Mario Limonciello
that needs for userspace and kernel space this patch series introduces a generic way for WMI drivers to be able to create character devices through the WMI bus when desired. Requiring WMI drivers to explictly ask for this functionality will act as an effective vendor whitelist. Mario Limonciello (12

<    1   2   3   4   5   6   7   8   >