message before the end of
this Thursday the latest, as I am partaking in an evaluation period from the
organization I am working for with a deadline very close to that time.
Thank you,
Mark
On 2019-08-20 7:46 a.m., Mark Balantzyan wrote:
Hi all,
The race condition in the mptctl driver I&#
n of this race
possibility.
Thank you,
Mark
On Sun, 18 Aug 2019, Julian Calaby wrote:
Hi Mark,
On Thu, Aug 15, 2019 at 8:02 PM Mark Balantzyan wrote:
Certain functions in the driver, such as mptctl_do_fw_download() and
mptctl_do_mpt_command(), rely on the instance of mptctl_id, which doe
Hi Julian, all,
I submitted a patch v4 following Julian's review. A function such as
"mptctl_do_mpt_command" I don't think is a setup function and so the race
condition (likelihood) remains. Again, this was mainly concerning the
usage of "mptctl_id" variable in the driver. My objective was jus
mutually signalled to cooperate.
Signed-off-by: Mark Balantzyan
---
Changelog v2
Lacked a version number but added properly terminated else condition at
(former) line 2300.
Changelog v3
Fixes "return -EAGAIN" lines which were erroneously tabbed as if to be guarded
by "if&qu
.
Changelog v2
Lacked a version number but added properly terminated else condition at
(former) line 2300.
Changelog v3
Fixes "return -EAGAIN" lines which were erroneously tabbed as if to be guarded
by "if" conditions lying above them.
Signed-off-by: Mark Balantzyan
---
dr
.
Signed-off-by: Mark Balantzyan
---
drivers/message/fusion/mptctl.c | 39 ++---
1 file changed, 31 insertions(+), 8 deletions(-)
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index 4470630d..f0b49a85 100644
--- a/drivers/message/fusion
.
Signed-off-by: Mark Balantzyan
---
drivers/message/fusion/mptctl.c | 36 ++---
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index 4470630d..58ce0fc0 100644
--- a/drivers/message/fusion
.
Signed-off-by: Mark Balantzyan
---
drivers/message/fusion/mptctl.c | 36 ++---
1 file changed, 29 insertions(+), 7 deletions(-)
diff --git a/drivers/message/fusion/mptctl.c b/drivers/message/fusion/mptctl.c
index 4470630d..58ce0fc0 100644
--- a/drivers/message/fusion
Dear Ondrej,
As advised by another kernel maintainer, patches for antiquated drivers
like these (this one which I test-built successfully) should hang around
until someone with the hardware volunteers to test it. Therefore, I would
provide the software and the individual would serve as the har
Please see: https://lkml.org/lkml/2019/8/2/6
Thank you.
There was some sort of filesystem error that cause the wrong file to be
saved. Hence, yes, possibly there was no difference betwee the v2 and the
'v4' (which should have been the 'v3'). Since the last one, though
unchanged from v2, was a changelog-less 'v3', THIS is an actual 'v4'.
Thank you,
This patch rewrites the alim1535_wdt driver to use the watchdog subsystem.
By virtue of this, it also fixes a (theoretical) race condition between the
formerly arranged ali_timeout_bits and ali_settimer() interoperation.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig| 1
Balantzyan wrote:
This patch rewrites the alim1535_wdt driver to use the watchdog subsystem.
By virtue of this, it also fixes a (theoretical) race condition between the
formerly arranged ali_timeout_bits and ali_settimer() interoperation.
Signed-off-by: Mark Balantzyan
This is v4. A minute ago I
This patch rewrites the alim1535_wdt driver to use the watchdog subsystem.
By virtue of this, it also fixes a (theoretical) race condition between the
formerly arranged ali_timeout_bits and ali_settimer() interoperation.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig| 1
This patch rewrites the alim1535_wdt driver to use the watchdog subsystem.
By virtue of this, it also fixes a (theoretical) race condition between the
formerly arranged ali_timeout_bits and ali_settimer() interoperation.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig| 1
This patch rewrites the alim1535_wdt driver to use the watchdog subsystem. By
virtue of this, it also fixes a potential race condition between
ali_timeout_bits and ali_settimer().
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig| 1 +
drivers/watchdog/alim1535_wdt.c
Hi Guenter, all,
I don't really understand this focus on fixing theoretic/irrelevant
race conditions in drivers which no one uses anymore. Maybe someone
can enlighten me ?
In conjunction with linuxtesting.org and The Linux Foundation, I've been
enlisted to test and work
Hi Hans, all,
Sorry for the poor patching, I am a student and as you may tell still new
to this system. At the time of the patching, I wasn't fully informed of
all the requirements that go into such things, and am still learning.
Would it be alright if I submit a report instead? In order to,
Hi Guenter, all,
It's alright if you still don't wish to review my patch on alim1535_wdt,
but my employer and I, using our race condition analysis tool, detected it
to contain a race condition warning. I believe any possible issues could
be resolved if it were rewritten to use the watchdog sub
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
drivers/watchdog
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
drivers/watchdog
My employer (and yes, I am working for the Linux Foundation) has me
working on analysing race condition warnings in the Linux kernel. They
have a driver verification project running under the umbrella of the ELISA
project involved in the research, investigation, experimentation, and
establishme
Hi Guenter,
If it's not too much too ask, I also propose to rewrite alim1535_wdt to
use the watchdog subsystem as I believe we are making progress toward the
similar end in pc87413_wdt, as my evaluation ends in some weeks.
Thank you,
Mark
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
drivers/watchdog
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
drivers/watchdog
Hi all, Guenter,
Thank you for your email. Unfortunately, on my end, the indentation is
straight and perhaps through protocol transfer there was stray
modification.
I've made the other changes as indicated that I'll submit in a v2 patch
shortly. Is 'v2' permissible to include in the title in th
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
drivers/watchdog
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
drivers/watchdog
Yes, each time I go through an edit I discover something I missed,
apologies. Will be working on it for a bit, currently getting compile time
errors. Just letting you know and it’s good we’re checking :-)
Thank you,
Mark
Hi all, Guenter,
Sure, it'd be great to work on ib700, doing both, if we may. I feel it's
worth a shot in case somebody out there has the hardware to test the
pc87413_wdt driver, though I'm doing my best building the individual
module and checking for compilation errors (as best I can).
I ju
addresses this
need by rewriting into common watchdog interface utilization for the driver.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/pc87413_wdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
index bc6c4e19..6863145a
addresses this
need by rewriting into common watchdog interface utilization for the driver.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/pc87413_wdt.c | 235 +++--
1 file changed, 22 insertions(+), 213 deletions(-)
diff --git a/drivers/watchdog/pc87413_wdt.c b
addresses this
need by rewriting into common watchdog interface utilization for the driver.
Signed-off-by: Mark Balantzyan
---
drivers/media/pci/tw686x/Kconfig | 1 +
drivers/watchdog/pc87413_wdt.c | 92 +++-
2 files changed, 45 insertions(+), 48 deletions(-)
diff --git
addresses this
need by rewriting into common watchdog interface utilization for the driver.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/pc87413_wdt.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/watchdog/pc87413_wdt.c b/drivers/watchdog/pc87413_wdt.c
index a9070a22
Hello all, Guenter,
I am being evaluated as a student by my organization. I appreciate your
patience with my emails and patches.
I would like to please propose that we divide and conquer: I write the
code for converting the driver to common watchdog interface (and I thank
you for your guidan
-- Forwarded message --
Hi all, sorry for the duplicate message Guenter, wanted to be sure my
message is transferred:
Thank you for your reply, Guenter! Sorry there were issues applying the
patch, I used git format-patch to produce the patch and pasted the main
contents into a p
addresses this need by rewriting into common watchdog interface utilization for the driver.
Signed-off-by: Mark Balantzyan
---
drivers/media/pci/tw686x/Kconfig | 1 +
drivers/watchdog/pc87413_wdt.c | 92 +++-
2 files changed, 45 insertions(+), 48 deletions(-)
diff
to free the remaining resources and memory where the last open
handle(s) is/were closed.
Signed-off-by: Mark Balantzyan
---
drivers/media/pci/tw686x/tw686x-video.c | 15 +++
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/drivers/media/pci/tw686x/tw686x-video.c
b
else
return -EINVAL;
-
+spin_unlock(&ali_lock);
timeout = t;
return 0;
}
--
2.17.1
Signed-off-by: Mark Balantzyan
Cc: Pavel Andrianov
Cc:Wim Van Sebroeck (maintainer:WATCHDOG DEVICE
DRIVERS)
Cc: Guenter Roeck (maintainer:WATCHDOG DEVICE DRIVERS)
Cc:linux-watc
39 matches
Mail list logo
