Re: [PATCH RFT v12 0/8] fork: Support shadow stacks in clone3()

2024-11-01 Thread Mark Brown
On Thu, Oct 31, 2024 at 09:06:09PM +, Edgecombe, Rick P wrote: > On Thu, 2024-10-31 at 19:25 +0000, Mark Brown wrote: > > base-commit: d17cd7b7cc92d37ee8b2df8f975fc859a261f4dc > Where can I find this base commit? Ah, that's still my branch from when I posted what's no

[PATCH RFT v12 4/8] fork: Add shadow stack support to clone3()

2024-10-31 Thread Mark Brown
-by: Mark Brown --- arch/arm64/mm/gcs.c | 54 +- arch/x86/include/asm/shstk.h | 11 +++-- arch/x86/kernel/process.c| 2 +- arch/x86/kernel/shstk.c | 57 +--- include/asm-generic/cacheflush.h | 11 + include/linux/sched

[PATCH RFT v12 8/8] selftests/clone3: Test shadow stack support

2024-10-31 Thread Mark Brown
., this should be overly cautious. Acked-by: Shuah Khan Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 143 +- tools/testing/selftests/clone3/clone3_selftests.h | 63 ++ 2 files changed, 205 insertions(+), 1 deletion(-) diff --git a

[PATCH RFT v12 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code

2024-10-31 Thread Mark Brown
iewed-by: Catalin Marinas Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index e066b201fa64eb17c55939b7cec18ac5d10

[PATCH RFT v12 6/8] selftests/clone3: Factor more of main loop into test_clone3()

2024-10-31 Thread Mark Brown
change. Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Reviewed-by: Catalin Marinas Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 77 - 1 file changed, 37 insertions(+), 40 deletions(-) diff --git a/tools/testing

[PATCH RFT v12 5/8] selftests/clone3: Remove redundant flushes of output streams

2024-10-31 Thread Mark Brown
s. Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Reviewed-by: Catalin Marinas Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3_selftests.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/clone3/clone3_selftests.h b/tools/te

[PATCH RFT v12 3/8] selftests: Provide helper header for shadow stack testing

2024-10-31 Thread Mark Brown
interfaces. Reviewed-by: Rick Edgecombe Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Signed-off-by: Mark Brown --- tools/testing/selftests/ksft_shstk.h | 98 1 file changed, 98 insertions(+) diff --git a/tools/testing/selftests/ksft_shstk.h b

[PATCH RFT v12 2/8] Documentation: userspace-api: Add shadow stack API documentation

2024-10-31 Thread Mark Brown
feature let's provide some documentation covering the common aspects. Reviewed-by: Catalin Marinas Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Signed-off-by: Mark Brown --- Documentation/userspace-api/index.rst| 1 + Documentation/userspace-api/shadow_stack.rst

[PATCH RFT v12 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack()

2024-10-31 Thread Mark Brown
error code on failure. Acked-by: Deepak Gupta Signed-off-by: Mark Brown --- arch/arm64/include/asm/gcs.h | 8 arch/arm64/kernel/process.c | 8 arch/arm64/mm/gcs.c | 8 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm64/include/asm/gcs.h b

[PATCH RFT v12 0/8] fork: Support shadow stacks in clone3()

2024-10-31 Thread Mark Brown
..@kernel.org/T/#mc58f97f27461749ccf400ebabf6f9f937116a86b Signed-off-by: Mark Brown --- Changes in v12: - Add the regular prctl() to the userspace API document since arm64 support is queued in -next. - Link to v11: https://lore.kernel.org/r/20241005-clone3-shadow-stack-v11-0-2a6a2bd6d...@kernel.

Re: [PATCH RFT v11 0/8] fork: Support shadow stacks in clone3()

2024-10-30 Thread Mark Brown
On Sat, Oct 05, 2024 at 11:31:27AM +0100, Mark Brown wrote: > The kernel has recently added support for shadow stacks, currently > x86 only using their CET feature but both arm64 and RISC-V have > equivalent features (GCS and Zicfiss respectively), I am actively > working on GCS[1].

[PATCH v2 2/2] kselftest/arm64: Poll less often while waiting for fp-stress children

2024-10-29 Thread Mark Brown
ignal raise interval when all the children are started and we start sending signals. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp-stress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/arm64/fp/fp-stress.c b/tools/testing/self

[PATCH v2 0/2] kselftest/arm64: fp-stress signal delivery interval improvements

2024-10-29 Thread Mark Brown
the signal handling code. Do a quick change to increase the rate of signal delivery, trying to avoid excessive impact on emulated platforms, and a further change to mitigate the impact that this creates during startup. Signed-off-by: Mark Brown --- Changes in v2: - Minor clarifications in commit

[PATCH v2 1/2] kselftest/arm64: Increase frequency of signal delivery in fp-stress

2024-10-29 Thread Mark Brown
moved the signal generation out of the main supervisor thread, though we should also consider that he percentage of time that we spend interacting with the floating point state is also a consideration. Suggested-by: Mark Rutland Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp

Re: [PATCH 1/2] kselftest/arm64: Increase frequency of signal delivery in fp-stress

2024-10-29 Thread Mark Brown
On Tue, Oct 29, 2024 at 03:43:37PM +, Mark Rutland wrote: > On those emulated platforms (FVP?), does this change trigger the faukure > more often? Yes. > I gave this a quick test, and with this change, running fp-stress on a > defconfig kernel running on 1 CPU triggers the "Bad SVCR: 0" spla

[PATCH] kselftest/arm64: Use ksft_perror() to log MTE failures

2024-10-29 Thread Mark Brown
more information is available should the tests fail. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/mte/mte_common_util.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b/tools/testing/selftests/

[PATCH 2/2] kselftest/arm64: Lower poll interval while waiting for fp-stress children

2024-10-28 Thread Mark Brown
ignal raise interval when all the children are started and we start sending signals. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp-stress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/arm64/fp/fp-stress.c b/tools/testing/self

[PATCH 1/2] kselftest/arm64: Increase frequency of signal delivery in fp-stress

2024-10-28 Thread Mark Brown
moved the signal generation out of the main supervisor thread, though we should also consider that he percentage of time that we spend interacting with the floating point state is also a consideration. Suggested-by: Mark Rutland Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp

[PATCH 0/2] kselftest/arm64: fp-stress signal delivery interval improvements

2024-10-28 Thread Mark Brown
the signal handling code. Do a quick change to increase the rate of signal delivery, trying to avoid excessive impact on emulated platforms, and a further change to mitigate the impact that this creates during startup. Signed-off-by: Mark Brown --- Mark Brown (2): kselftest/arm64: Increase

[PATCH] kselftest/arm64: Fix encoding for SVE B16B16 test

2024-10-28 Thread Mark Brown
The test for SVE_B16B16 had a cut'n'paste of a SME instruction, fix it with a relevant SVE instruction. Fixes: 44d10c27bd75 ("kselftest/arm64: Add 2023 DPISA hwcap test coverage") Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/abi/hwcap.c | 4 ++-- 1 file c

Re: kselftest:arm64/FVP: arm64_check_buffer_fill - failed on Linux next-20241025

2024-10-28 Thread Mark Brown
On Tue, Oct 29, 2024 at 01:16:32AM +0530, Naresh Kamboju wrote: > The following kselftest arm64 and FVP failed with Linux next-20241025 on > - Qemu-arm64 > - FVP > > running Linux next-20241025 kernel. > > First seen on next-20241025 > Good: next-20241024 > BAD: next-20241025 > > kself

Re: [PATCH 0/6] kselftest/arm64: Test floating point signal context restore in fp-stress

2024-10-28 Thread Mark Brown
On Mon, Oct 28, 2024 at 02:26:44PM +, Mark Rutland wrote: > 1) We only singal the tasks once a second. Dave's original shell test >script hammered this constantly, and it makes a substantial impact >actually triggering a bug. >Without these patches, I hacked the fp-stress.c main l

Re: [PATCH for-next 1/7] selftests/alsa: Add a few missing gitignore files

2024-10-25 Thread Mark Brown
On Fri, Oct 25, 2024 at 09:40:04AM +0800, Li Zhijian wrote: > index 12dc3fcd3456..1407fd24a97b 100644 > --- a/tools/testing/selftests/alsa/.gitignore > +++ b/tools/testing/selftests/alsa/.gitignore > @@ -1,3 +1,5 @@ > mixer-test > pcm-test > test-pcmtest-driver > +global-timer > +utimer-test >

[PATCH 1/6] kselftest/arm64: Correct misleading comments on fp-stress irritators

2024-10-23 Thread Mark Brown
current register state which is expected to be overwritten on return from the handler by the saved register state. Update the comment to reflect what the handler is actually doing. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fpsimd-test.S | 3 +-- tools/testing/selftests/arm64

[PATCH 4/6] kselftest/arm64: Implement irritators for ZA and ZT

2024-10-23 Thread Mark Brown
ment them, just trivially SMSTOP and SMSTART to reset all bits in the register to 0. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/za-test.S | 12 tools/testing/selftests/arm64/fp/zt-test.S | 12 2 files changed, 8 insertions(+), 16 deletions(-) dif

[PATCH 6/6] kselftest/arm64: Test signal handler state modification in fp-stress

2024-10-23 Thread Mark Brown
the signal handler, verifying that when we return the saved register state is restored from the signal context as expected. Switch over to triggering that to validate that we are restoring as expected. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp-stress.c | 2 +- 1 file

[PATCH 5/6] kselftest/arm64: Provide a SIGUSR1 handler in the kernel mode FP stress test

2024-10-23 Thread Mark Brown
s the number of signals like we do for SIGUSR2, allowing fp-stress to treat all the test programs uniformly. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/kernel-test.c | 4 1 file changed, 4 insertions(+) diff --git a/tools/testing/selftests/arm64/fp/kernel-test.c b/tools/te

[PATCH 3/6] kselftest/arm64: Corrupt P15 in the irritator when testing SSVE

2024-10-23 Thread Mark Brown
When building for streaming SVE the irritator for SVE skips updates of both P15 and FFR. While FFR is skipped since it might not be present there is no reason to skip corrupting P15 so move the ifdef appropriately. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/sve-test.S | 2

[PATCH 2/6] kselftest/arm64: Remove unused ADRs from irritator handlers

2024-10-23 Thread Mark Brown
The irritator handlers for the fp-stress test programs all use ADR to load an address into x0 which is then not referenced. Remove these ADRs as they just cause confusion. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fpsimd-test.S | 1 - tools/testing/selftests/arm64/fp/sve

[PATCH 0/6] kselftest/arm64: Test floating point signal context restore in fp-stress

2024-10-23 Thread Mark Brown
test programs that can have them and then switch the signals generated by the fp-stress program over to use the irritators, ensuring that we validate that we restore the saved signal context properly. Signed-off-by: Mark Brown --- Mark Brown (6): kselftest/arm64: Correct misleading comments

[PATCH] kselftest/arm64: Log fp-stress child startup errors to stdout

2024-10-22 Thread Mark Brown
g for output from the child. Improve robustness and output quality by logging to stdout instead. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/fp/fp-stress.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/fp-stress

[PATCH] KVM: selftests: Fix build on on non-x86 architectures

2024-10-21 Thread Mark Brown
ddition of this x86 specific command line flag conditional on building for x86. Fixes: 9a400068a158 ("KVM: selftests: x86: Avoid using SSE/AVX instructions") Signed-off-by: Mark Brown --- tools/testing/selftests/kvm/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[PATCH] kselftest/arm64: Fail the overall fp-stress test if any test fails

2024-10-17 Thread Mark Brown
Currently fp-stress does not report a top level test result if it runs to completion, it always exits with a return code 0. Use the ksft_finished() helper to ensure that the exit code for the top level program reports a failure if any of the individual tests has failed. Signed-off-by: Mark Brown

[PATCH] kselftest/arm64: Ensure stable names for GCS stress test results

2024-10-11 Thread Mark Brown
The GCS stress test program currently uses the PID of the threads it creates in the test names it reports, resulting in unstable test names between runs. Fix this by using a thread number instead. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/gcs/gcs-stress.c | 6 +++--- 1 file

Re: [PATCH v3] selftests: sched_ext: Add sched_ext as proper selftest target

2024-10-09 Thread Mark Brown
On Tue, Oct 08, 2024 at 05:35:18PM +0200, Björn Töpel wrote: > The sched_ext selftests is missing proper cross-compilation support, a > proper target entry, and out-of-tree build support. Tested-by: Mark Brown Reviewed-by: Mark Brown There's still the thing with picking up the hos

Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target

2024-10-07 Thread Mark Brown
On Mon, Oct 07, 2024 at 06:00:57PM +0200, Björn Töpel wrote: > The sched_ext BPF programs relies on a vmlinux.h, which is generated > using bpftool and the vmlinux with BTF information. Have you built a > kernel with BTF support? OK, so having beaten the kernel config into shape and using GCC rat

Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target

2024-10-07 Thread Mark Brown
On Mon, Oct 07, 2024 at 06:45:32PM +0200, Björn Töpel wrote: > Mark Brown writes: > > I didn't actually build a kernel, if the build system needs a kernel > > it's just silently not detected that it's missing? > It tries to find a kernel with BTF: >

Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target

2024-10-07 Thread Mark Brown
On Mon, Oct 07, 2024 at 06:00:57PM +0200, Björn Töpel wrote: > Mark Brown writes: > > When building for arm64 with this applied on top of mainline or -next > > I'm seeing: > Thanks for taking it for a spin! > >make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu- -C

Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target

2024-10-07 Thread Mark Brown
On Mon, Oct 07, 2024 at 06:00:57PM +0200, Björn Töpel wrote: > Mark Brown writes: > > On Mon, Oct 07, 2024 at 09:31:32AM +0200, Björn Töpel wrote: > > CLNG-BPF create_dsq.bpf.o > > In file included from create_dsq.bpf.c:9: > > /home/broonie/git/linux/tools/sched_ext/

Re: [PATCH v2] selftests: sched_ext: Add sched_ext as proper selftest target

2024-10-07 Thread Mark Brown
On Mon, Oct 07, 2024 at 09:31:32AM +0200, Björn Töpel wrote: > When building the kselftest suite, e.g.: > make ARCH=riscv CROSS_COMPILE=riscv64-linux-gnu- \ > SKIP_TARGETS="" O=/output/foo -C tools/testing/selftests install > The expectation is that the sched_ext is included, cross-built,

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-10-07 Thread Mark Brown
On Mon, Oct 07, 2024 at 10:07:24AM +0530, Dev Jain wrote: > On 9/16/24 09:28, Dev Jain wrote: > > Gentle ping, adding all x86 maintainers and the x86 list, in case they > > missed. > Gentle ping Given that this was posted prior to the merge window you should probably resend it at this point. s

Re: [PATCH] selftests: Do not skip BPF selftests by default

2024-10-05 Thread Mark Brown
On Sat, Oct 05, 2024 at 12:12:15PM +0200, Björn Töpel wrote: > Mark Brown writes: > > On Fri, Oct 04, 2024 at 03:34:49PM +0200, Björn Töpel wrote: > >> Mark Brown writes: > > It's a bit unfortunate having to pull clang into GCC build containers, > > and needi

[PATCH RFT v11 8/8] selftests/clone3: Test shadow stack support

2024-10-05 Thread Mark Brown
., this should be overly cautious. Acked-by: Shuah Khan Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 143 +- tools/testing/selftests/clone3/clone3_selftests.h | 63 ++ 2 files changed, 205 insertions(+), 1 deletion(-) diff --git a

[PATCH RFT v11 7/8] selftests/clone3: Allow tests to flag if -E2BIG is a valid error code

2024-10-05 Thread Mark Brown
d-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/testing/selftests/clone3/clone3.c b/tools/testing/selftests/clone3/clone3.c index e066b201fa64eb17c55939b7cec18ac5d109613b..5b8b7d640e70132242fc6939450669acd0c534f9 1

[PATCH RFT v11 6/8] selftests/clone3: Factor more of main loop into test_clone3()

2024-10-05 Thread Mark Brown
change. Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3.c | 77 - 1 file changed, 37 insertions(+), 40 deletions(-) diff --git a/tools/testing/selftests/clone3/clone3.c b

[PATCH RFT v11 5/8] selftests/clone3: Remove redundant flushes of output streams

2024-10-05 Thread Mark Brown
s. Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Signed-off-by: Mark Brown --- tools/testing/selftests/clone3/clone3_selftests.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/clone3/clone3_selftests.h b/tools/testing/selftests/clone3/clone3_se

[PATCH RFT v11 4/8] fork: Add shadow stack support to clone3()

2024-10-05 Thread Mark Brown
-by: Mark Brown --- arch/arm64/mm/gcs.c | 54 +- arch/x86/include/asm/shstk.h | 11 +++-- arch/x86/kernel/process.c| 2 +- arch/x86/kernel/shstk.c | 57 +--- include/asm-generic/cacheflush.h | 11 + include/linux/sched

[PATCH RFT v11 3/8] selftests: Provide helper header for shadow stack testing

2024-10-05 Thread Mark Brown
interfaces. Reviewed-by: Rick Edgecombe Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Signed-off-by: Mark Brown --- tools/testing/selftests/ksft_shstk.h | 98 1 file changed, 98 insertions(+) diff --git a/tools/testing/selftests/ksft_shstk.h b

[PATCH RFT v11 2/8] Documentation: userspace-api: Add shadow stack API documentation

2024-10-05 Thread Mark Brown
feature let's provide some documentation covering the common aspects. Reviewed-by: Catalin Marinas Reviewed-by: Kees Cook Tested-by: Kees Cook Acked-by: Shuah Khan Signed-off-by: Mark Brown --- Documentation/userspace-api/index.rst| 1 + Documentation/userspace-api/shadow_stack.rst

[PATCH RFT v11 1/8] arm64/gcs: Return a success value from gcs_alloc_thread_stack()

2024-10-05 Thread Mark Brown
error code on failure. Signed-off-by: Mark Brown --- arch/arm64/include/asm/gcs.h | 8 arch/arm64/kernel/process.c | 8 arch/arm64/mm/gcs.c | 8 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/arch/arm64/include/asm/gcs.h b/arch/arm64/include/asm/

[PATCH RFT v11 0/8] fork: Support shadow stacks in clone3()

2024-10-05 Thread Mark Brown
..@kernel.org/T/#mc58f97f27461749ccf400ebabf6f9f937116a86b Signed-off-by: Mark Brown --- Changes in v11: - Rebase onto arm64 for-next/gcs, which is based on v6.12-rc1, and integrate arm64 support. - Rework the interface to specify a shadow stack pointer rather than a base and size like we do for th

[PATCH] kselftest/arm64: Validate that GCS push and write permissions work

2024-10-04 Thread Mark Brown
to get the permissions in case the system is locked down to make them inaccessible. Signed-off-by: Mark Brown --- tools/testing/selftests/arm64/gcs/.gitignore | 2 + tools/testing/selftests/arm64/gcs/Makefile | 8 ++- tools/testing/selftests/arm64/gcs/gcspushm.S | 96

Re: [PATCH] selftests: Do not skip BPF selftests by default

2024-10-04 Thread Mark Brown
On Fri, Oct 04, 2024 at 03:34:49PM +0200, Björn Töpel wrote: > Mark Brown writes: > > On Fri, Oct 04, 2024 at 11:53:47AM +0200, Björn Töpel wrote: > >> This effectively is a revert of commit 7a6eb7c34a78 ("selftests: Skip > >> BPF seftests by default"). At

Re: [PATCH] selftests: Do not skip BPF selftests by default

2024-10-04 Thread Mark Brown
On Fri, Oct 04, 2024 at 11:53:47AM +0200, Björn Töpel wrote: > From: Björn Töpel > > This effectively is a revert of commit 7a6eb7c34a78 ("selftests: Skip > BPF seftests by default"). At the time when this was added, BPF had > "build time dependencies on cutting edge versions". Since then a > num

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-02 Thread Mark Brown
On Wed, Oct 02, 2024 at 02:42:58PM +0100, Mark Brown wrote: > On Tue, Oct 01, 2024 at 11:03:10PM +, Edgecombe, Rick P wrote: > > I'm not so sure. The thing is a regular stack can be re-used in full - just > > set > > the RSP to the end and take advantage of the w

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-02 Thread Mark Brown
On Tue, Oct 01, 2024 at 11:03:10PM +, Edgecombe, Rick P wrote: > On Tue, 2024-10-01 at 18:33 +0100, Mark Brown wrote: > > My suspicion would be that if we're doing the pivot to a previously used > > shadow stack we'd also be pivoting the regular stack along wit

Re: [PATCH RFT v9 4/8] fork: Add shadow stack support to clone3()

2024-10-01 Thread Mark Brown
On Tue, Oct 01, 2024 at 05:12:38PM +0200, Christian Brauner wrote: > On Fri, Sep 27, 2024 at 03:21:59PM GMT, Edgecombe, Rick P wrote: > > Did you catch that a token can be at a different offsets location on the > > stack > > depending on args passed to map_shadow_stack? So userspace will need >

[PATCH] KVM: selftests: Fix build on architectures other than x86_64

2024-09-30 Thread Mark Brown
004a ("KVM: selftests: Allow slot modification stress test with quirk disabled") Reported-by: Aishwarya TCV Signed-off-by: Mark Brown --- This is obviously disruptive for testing of KVM changes on non-x86 architectures. --- tools/testing/selftests/kvm/memslot_modification_stress_test.c |

Re: [PATCH v6 1/2] selftests: Rename sigaltstack to generic signal

2024-09-05 Thread Mark Brown
On Thu, Sep 05, 2024 at 11:26:02AM +0530, Dev Jain wrote: > On 9/4/24 22:35, Shuah Khan wrote: > > So who does the backports whenevenr something changes? You are adding > > work where as the automated process would just work without this > > change. It doesn't matter if there is another test that

Re: [PATCH v7 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-06-26 Thread Mark Brown
On Fri, May 31, 2024 at 07:34:58PM +0200, Karel Balej wrote: > Support the LDO and buck regulators of the Marvell 88PM886 PMIC. Reviewed-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH v6 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-05-05 Thread Mark Brown
On Sun, May 05, 2024 at 08:52:06PM +0200, Karel Balej wrote: > Should I then drop this op and the max_uA values from all the > regulators? Probably, yes. signature.asc Description: PGP signature

Re: [PATCH v6 3/5] regulator: add regulators driver for Marvell 88PM886 PMIC

2024-05-05 Thread Mark Brown
On Sat, May 04, 2024 at 09:37:06PM +0200, Karel Balej wrote: > +static const struct regulator_ops pm886_ldo_ops = { > + .list_voltage = regulator_list_voltage_table, > + .map_voltage = regulator_map_voltage_iterate, > + .set_voltage_sel = regulator_set_voltage_sel_regmap, > + .get_

Re: [PATCH] ASoC: tracing: Export SND_SOC_DAPM_DIR_OUT to its value

2024-04-16 Thread Mark Brown
On Tue, 16 Apr 2024 00:03:03 -0400, Steven Rostedt wrote: > The string SND_SOC_DAPM_DIR_OUT is printed in the snd_soc_dapm_path trace > event instead of its value: > >(((REC->path_dir) == SND_SOC_DAPM_DIR_OUT) ? "->" : "<-") > > User space cannot parse this, as it has no idea what SND_SOC_DAP

Re: (subset) [PATCH 0/5] Add TCPM support for PM7250B and Fairphone 4

2024-03-25 Thread Mark Brown
On Fri, 22 Mar 2024 09:01:31 +0100, Luca Weiss wrote: > This series adds support for Type-C Port Management on the Fairphone 4 > which enables USB role switching and orientation switching. > > This enables a user for example to plug in a USB stick or a USB keyboard > to the Type-C port. > > > [.

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 08:14:44PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T19:00:24+00:00: > > I would expect that if you have two separate register maps they would > > have separate configurations that describe the corresponding physical > > register maps, as f

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 07:16:43PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T17:48:28+00:00: > > > They do according to the downstream driver which is my only reference. > > > In fact, there the driver defines the configs separately for each regmap > >

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 06:32:03PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T17:17:40+00:00: > > Do they both genuinely have the same maximum register? > They do according to the downstream driver which is my only reference. > In fact, there the driver defines the configs

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 06:08:16PM +0100, Karel Balej wrote: > Mark Brown, 2024-03-21T16:58:44+00:00: > > > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > > > + .reg_bits = 8, > > > > > > > + .val_b

Re: [RFC PATCH v4 2/5] mfd: add driver for Marvell 88PM886 PMIC

2024-03-21 Thread Mark Brown
On Thu, Mar 21, 2024 at 05:55:17PM +0100, Karel Balej wrote: > Lee Jones, 2024-03-21T16:20:45+00:00: > > On Thu, 21 Mar 2024, Karel Balej wrote: > > > > > +static const struct regmap_config pm886_i2c_regmap = { > > > > > + .reg_bits = 8, > > > > > + .val_bits = 8, > > > > > + .max_regi

Re: [PATCH 0/2] ASoC: trace: trace more parameters in ASoC DAPM events

2024-03-06 Thread Mark Brown
On Wed, 06 Mar 2024 10:29:59 +0100, Luca Ceresoli wrote: > This small series adds parameters to existing DAPM trace events to make > them more informative. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: trace: add component to

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-07 Thread Mark Brown
On Sun, Jan 07, 2024 at 10:49:20AM +0100, Karel Balej wrote: > On Fri Jan 5, 2024 at 4:18 PM CET, Mark Brown wrote: > > Why are we adding an of_compatible here? It's redundant, the MFD split > > is a feature of Linux internals not of the hardware, and the existing > &g

Re: [RFC PATCH 4/5] regulator: add 88pm88x regulators driver

2024-01-05 Thread Mark Brown
On Thu, Dec 28, 2023 at 10:39:13AM +0100, Karel Balej wrote: > @@ -68,6 +68,21 @@ static struct mfd_cell pm886_devs[] = { > .num_resources = ARRAY_SIZE(pm88x_onkey_resources), > .resources = pm88x_onkey_resources, > }, > + { > + .name = "88pm88x-re

Re: [PATCH v2 0/2] Remove reset GPIO for AW88261

2023-10-03 Thread Mark Brown
On Mon, 02 Oct 2023 16:00:10 +0200, Luca Weiss wrote: > The AW88261 chip doesn't have a reset gpio, so remove it from the > bindings and from the driver. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: dt-bindings: awinic,aw8839

Re: [PATCH RFC] ASoC: codecs: aw88261: Remove non-existing reset gpio

2023-09-29 Thread Mark Brown
On Fri, Sep 29, 2023 at 02:44:47PM +0200, Luca Weiss wrote: > Unfortunately the dt binding is a bit trickier to update since it's made > for both AW88261 and AW88395. > After spending a bit of time using non-Google search machines (Google > seems incapable of finding anything there) I found a dat

Re: [PATCH RFC] ASoC: codecs: aw88261: Remove non-existing reset gpio

2023-09-29 Thread Mark Brown
On Fri, Sep 29, 2023 at 12:28:10PM +0200, Luca Weiss wrote: > According to the AW88261 datasheet (V1.1) and device schematics I have > access to, there is no reset gpio present on the AW88261. Remove it. That looks to be the case according to https://doc.awinic.com/doc/20230609wm/c815e155-60b

Re: [PATCH] ASoC: ak4458: enable daisy chain

2021-04-20 Thread Mark Brown
On Tue, 20 Apr 2021 18:44:13 +0800, Shengjiu Wang wrote: > Enable Daisy Chain if in TDM mode and the number of played > channels is bigger than the maximum supported number of channels. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC:

Re: [PATCH] spidev: Add Micron SPI NOR Authenta device compatible

2021-04-20 Thread Mark Brown
On Mon, 19 Apr 2021 20:40:15 +, shiva.linuxwo...@gmail.com wrote: > Add compatible string for Micron SPI NOR Authenta device. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spidev: Add Micron SPI NOR Authenta device compatible comm

Re: [PATCH v3 0/2] spi: altera: Add DFL bus support for Altera SPI

2021-04-20 Thread Mark Brown
On Fri, 16 Apr 2021 09:57:18 -0700, matthew.gerl...@linux.intel.com wrote: > This patch set adds Device Feature List (DFL) bus support for > the Altera SPI Master controller. > > Patch 1 separates spi-altera.c into spi-altera-core.c and > spi-altera-platform.c. > > Patch 2 adds spi-altera-dfl.c.

Re: Enabling pmbus power control

2021-04-20 Thread Mark Brown
On Tue, Apr 20, 2021 at 11:40:24AM -0500, Zev Weiss wrote: > On Tue, Apr 20, 2021 at 11:13:18AM CDT, Mark Brown wrote: > > I already suggested writing a driver or drivers that represent the > > hardware you have, that advice remains. It's hard to follow what you > > we

Re: Enabling pmbus power control

2021-04-20 Thread Mark Brown
On Tue, Apr 20, 2021 at 10:19:04AM -0500, Zev Weiss wrote: > Mark, do you have any further input on what a viable approach might look > like? I already suggested writing a driver or drivers that represent the hardware you have, that advice remains. It's hard to follow what you were trying to say

Re: [PATCH v1 2/2] spi: Avoid potential UB when counting unused native CSs

2021-04-20 Thread Mark Brown
On Tue, Apr 20, 2021 at 06:07:06PM +0300, Andy Shevchenko wrote: > On Tue, Apr 20, 2021 at 03:56:16PM +0100, Mark Brown wrote: > > On Tue, Apr 20, 2021 at 05:10:04PM +0300, Andy Shevchenko wrote: > > > ffz(), that has been used to count unused native CSs, might produce UB >

Re: spi: stm32-qspi: Fix compilation warning in ARM64

2021-04-20 Thread Mark Brown
On Tue, 20 Apr 2021 10:21:03 +0200, patrice.chot...@foss.st.com wrote: > This fixes warnings detected when compiling in ARM64. > Introduced by 'commit 18674dee3cd6 ("spi: stm32-qspi: Add dirmap support")' Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Than

Re: [PATCH v1 2/2] spi: Avoid potential UB when counting unused native CSs

2021-04-20 Thread Mark Brown
On Tue, Apr 20, 2021 at 05:10:04PM +0300, Andy Shevchenko wrote: > ffz(), that has been used to count unused native CSs, might produce UB Bit of an IA there... signature.asc Description: PGP signature

Re: [PATCH v2] ASoC: ak4458: check reset control status

2021-04-19 Thread Mark Brown
On Mon, 19 Apr 2021 17:54:32 +0800, Shengjiu Wang wrote: > check the return value of ak4458_rstn_control. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: ak4458: check reset control status commit: e86a53fb64ed0a4749eeac2eccc7a64

Re: [PATCH] ASoC: sigmadsp: Disable cache mechanism for readbacks

2021-04-19 Thread Mark Brown
On Mon, 19 Apr 2021 16:49:01 +0200, Niklas Carlsson wrote: > The ALSA control readback functionality only works for non-volatile > controls, i.e. control values that does not change on their own without > driver interaction. > > This doesn't work for readbacks since the DSP firmware updates the >

Re: [PATCH 0/3] spi: stm32-qspi: Fix and update

2021-04-19 Thread Mark Brown
On Mon, 19 Apr 2021 14:15:38 +0200, patrice.chot...@foss.st.com wrote: > Christophe Kerello (1): > spi: stm32-qspi: fix pm_runtime usage_count counter > > Patrice Chotard (2): > spi: stm32-qspi: Trigger DMA only if more than 4 bytes to transfer > spi: stm32-qspi: Add dirmap support > > [...

Re: [PATCH] spi: Handle SPI device setup callback failure.

2021-04-19 Thread Mark Brown
On Mon, 19 Apr 2021 14:06:31 +0100, Joe Burmeister wrote: > If the setup callback failed, but the controller has auto_runtime_pm > and set_cs, the setup failure could be missed. Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next Thanks! [1/1] spi: Handle SPI

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-19 Thread Mark Brown
On Fri, Apr 16, 2021 at 02:39:25PM -0500, Pierre-Louis Bossart wrote: > On 4/16/21 1:55 PM, Mark Brown wrote: > > to the maximum supported bit width for internal operation so bit width > > only matters on external interfaces) but I think for a first pass we can > >

Re: [PATCH v5 3/5] regulator: sy7636a: Initial commit

2021-04-19 Thread Mark Brown
On Mon, Apr 19, 2021 at 07:02:20AM +1000, Alistair Francis wrote: > drivers/regulator/sy7636a-regulator.c | 127 ++ > include/linux/mfd/sy7636a.h | 1 + It would make merging slightly easier if you could either put the MFD change in the MFD patch or allocate se

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 11:47:01AM -0500, Pierre-Louis Bossart wrote: > On 4/16/21 11:31 AM, Mark Brown wrote: > > Not really written down that I can think of. I think the next steps > > that I can think of right now are unfortunately bigger and harder ones, > > mainly

Re: [PATCH 0/5] spi: spi-zynqmp-gqspi: fix spi issues

2021-04-16 Thread Mark Brown
On Sat, Apr 17, 2021 at 12:31:44AM +0800, Quanyang Wang wrote: > Sorry for any confusion caused. No worries, it's mainly just an issue for anyone doing stable backports - hopefully they'll figure things out. signature.asc Description: PGP signature

Re: [RFC PATCH 0/3] Separate BE DAI HW constraints from FE ones

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 04:03:05PM +, codrin.ciubota...@microchip.com wrote: > Thank you for the links! So basically the machine driver disappears and > all the components will be visible in user-space. Not entirely - you still need something to say how they're wired together but it'll be a

Re: [RFC PATCH v2 1/1] arm64: Implement stack trace termination record

2021-04-16 Thread Mark Brown
ng > that this is the final frame record in the chain. Reviewed-by: Mark Brown signature.asc Description: PGP signature

Re: [PATCH 0/5] spi: spi-zynqmp-gqspi: fix spi issues

2021-04-16 Thread Mark Brown
On Fri, 16 Apr 2021 22:20:42 +0800, quanyang.w...@windriver.com wrote: > V2: > Remove all "Fixes:" tags since they base on some patches are not > with "Fixes:". > > V1: > This series fix some issues that occurs in spi-zynqmp-gqspi.c. > > [...] Applied to https://git.kernel.org/pub/scm/linux/

Re: [next] aarch64-linux-gnu-ld: Unexpected GOT/PLT entries detected!

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 08:45:04PM +0530, Naresh Kamboju wrote: > The arm64 allnoconfig build failed on linux -next tag 20210416 > fpsimd.c:(.text+0x144): undefined reference to `sve_load_state' > aarch64-linux-gnu-ld: arch/arm64/kernel/fpsimd.o: in function `fpsimd_save': > fpsimd.c:(.text+0x1f8

Re: [RFC PATCH v2 0/4] arm64: Implement stack trace reliability checks

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 09:43:48AM -0500, Madhavan T. Venkataraman wrote: > How would you prefer I handle this? Should I place all SYM_CODE functions that > are actually safe for the unwinder in a separate section? I could just take > some approach and solve this. But I would like to get your opin

Re: [PATCH 1/5] spi: spi-zynqmp-gqspi: fix clk_enable/disable imbalance issue

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 10:04:30PM +0800, quanyang.wang wrote: > I am sorry. These patches should NOT be with "Fixes" tag since they base on > the patches > which are not with "Fixes". May I send a V2 patch series which remove these > "Fixes" tags? Well, if they're fixing bugs that were present

Re: [PATCH 1/5] spi: spi-zynqmp-gqspi: fix clk_enable/disable imbalance issue

2021-04-16 Thread Mark Brown
On Fri, Apr 16, 2021 at 08:46:48AM +0800, quanyang.w...@windriver.com wrote: > Since pm_runtime works now, clks can be enabled/disabled by calling > zynqmp_runtime_suspend/resume. So we don't need to enable these clks > explicitly in zynqmp_qspi_setup_op. Remove them to fix this issue. > Fixes: 1

Re: [PATCH v1] ASoC: Intel: kbl_da7219_max98927: Fix kabylake_ssp_fixup function

2021-04-15 Thread Mark Brown
On Thu, 15 Apr 2021 14:43:47 +0200, Lukasz Majczak wrote: > kabylake_ssp_fixup function uses snd_soc_dpcm to identify the > codecs DAIs. The HW parameters are changed based on the codec DAI of the > stream. The earlier approach to get snd_soc_dpcm was using container_of() > macro on snd_pcm_hw_para

Re: [PATCH] ASoC: codecs: wcd934x: Fix missing IRQF_ONESHOT as only threaded handler

2021-04-15 Thread Mark Brown
On Thu, 15 Apr 2021 15:38:29 +0800, zhuguangqin...@gmail.com wrote: > Coccinelle noticed: > sound/soc/codecs/wcd934x.c:5041:7-32: ERROR: Threaded IRQ with no primary > handler requested without IRQF_ONESHOT Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

  1   2   3   4   5   6   7   8   9   10   >