et/ethernet/freescale/fman/Kconfig | 1 +
> drivers/net/ethernet/mellanox/mlx5/core/Kconfig | 1 +
> drivers/net/ethernet/microchip/Kconfig | 1 +
> drivers/net/ethernet/netronome/Kconfig | 1 +
> drivers/net/ethernet/nxp/Kconfig | 1 +
> drivers/net/ethernet/rocker/Kconfig | 1 +
> 10 files changed, 10 insertions(+)
For the Agere et131x driver:
Acked-by: Mark Einon
On Fri, 2020-07-17 at 15:40 +0200, Andrew Lunn wrote:
> On Fri, Jul 17, 2020 at 02:21:35PM +0100, Mark Einon wrote:
> > Following the removal of an unused variable assignment (remove
> > unused variable 'pm_csr') the associated register read can also go,
> > as
Following the removal of an unused variable assignment (remove
unused variable 'pm_csr') the associated register read can also go,
as the read also occurs in the subsequent et1310_in_phy_coma()
call.
Signed-off-by: Mark Einon
---
drivers/net/ethernet/agere/et131x.c | 3 ---
1 file changed, 3
> Signed-off-by: Zhang Changzhong
> ---
> drivers/net/ethernet/agere/et131x.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
This makes sense, thanks.
The readl() line modified here is also redundant as it gets called from
the subsequent et1310_in_phy_coma() ca
riable
>
> Signed-off-by: Jason Yan
Acked-by: Mark Einon
{r.p,ok1.p,ok2.p};
> identifier r.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct ethtool_ops i = { ... };
> //
>
> Signed-off-by: Julia Lawall <julia.law...@lip6.fr>
Looks good, thanks.
Acked-by: Mark Einon <mark.ei...@gmail.com>
{r.p,ok1.p,ok2.p};
> identifier r.i;
> @@
> i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
> struct ethtool_ops i = { ... };
> //
>
> Signed-off-by: Julia Lawall
Looks good, thanks.
Acked-by: Mark Einon
Commit-ID: 7f99f8b94c9355acdb14f1be28cb19aac741da68
Gitweb: http://git.kernel.org/tip/7f99f8b94c9355acdb14f1be28cb19aac741da68
Author: Mark Einon
AuthorDate: Wed, 1 Apr 2015 22:32:04 +0100
Committer: Ingo Molnar
CommitDate: Fri, 3 Apr 2015 15:21:56 +0200
x86/earlyprintk: Put
Commit-ID: 7f99f8b94c9355acdb14f1be28cb19aac741da68
Gitweb: http://git.kernel.org/tip/7f99f8b94c9355acdb14f1be28cb19aac741da68
Author: Mark Einon mark.ei...@gmail.com
AuthorDate: Wed, 1 Apr 2015 22:32:04 +0100
Committer: Ingo Molnar mi...@kernel.org
CommitDate: Fri, 3 Apr 2015 15:21:56
defines.
Signed-off-by: Mark Einon
---
v2 - Move code to another #ifdef instead of creating a new ifdef pair after
comment by Borislav Petkov .
v3 - Fixed commit errors from v2, changed some uintXX_t data types to
equivalent uXX.
arch/x86/kernel/early_printk.c | 32
On Wed, Apr 01, 2015 at 09:54:10AM +0200, Ingo Molnar wrote:
>
> * Mark Einon wrote:
>
> > Two static functions are only used if CONFIG_PCI is defined,so only build
> > them
> > if this is the case. Fixes the build warnings:
> >
> > arch/x
On Wed, Apr 01, 2015 at 09:54:10AM +0200, Ingo Molnar wrote:
* Mark Einon mark.ei...@gmail.com wrote:
Two static functions are only used if CONFIG_PCI is defined,so only build
them
if this is the case. Fixes the build warnings:
arch/x86/kernel/early_printk.c:98:13: warning
defines.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
v2 - Move code to another #ifdef instead of creating a new ifdef pair after
comment by Borislav Petkov b...@alien8.de.
v3 - Fixed commit errors from v2, changed some uintXX_t data types to
equivalent uXX.
arch/x86/kernel/early_printk.c
, int value)
^
arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but
not used [-Wunused-function]
static unsigned int mem32_serial_in(unsigned long addr, int offset)
^
Signed-off-by: Mark Einon
---
v2 - Move code to another #ifdef instead
, int value)
^
arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but
not used [-Wunused-function]
static unsigned int mem32_serial_in(unsigned long addr, int offset)
^
Signed-off-by: Mark Einon
---
arch/x86/kernel/early_printk.c | 2 ++
1
, int value)
^
arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but
not used [-Wunused-function]
static unsigned int mem32_serial_in(unsigned long addr, int offset)
^
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
arch/x86/kernel
, int value)
^
arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but
not used [-Wunused-function]
static unsigned int mem32_serial_in(unsigned long addr, int offset)
^
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
v2 - Move code
andles all
> corner cases correctly. This is a minor API cleanup only.
>
> Signed-off-by: Nicholas Mc Guire
Acked-by: Mark Einon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
correctly. This is a minor API cleanup only.
Signed-off-by: Nicholas Mc Guire hof...@osadl.org
Acked-by: Mark Einon mark.ei...@gmail.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
The usbip driver was moved out of staging in 3.17-rc3 but the MAINTAINERS file
still has the old staging entry as well as the new one. Remove the old entry.
Signed-off-by: Mark Einon
---
MAINTAINERS | 5 -
1 file changed, 5 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0eb6c2a
The usbip driver was moved out of staging in 3.17-rc3 but the MAINTAINERS file
still has the old staging entry as well as the new one. Remove the old entry.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
MAINTAINERS | 5 -
1 file changed, 5 deletions(-)
diff --git a/MAINTAINERS b
On Wed, Oct 01, 2014 at 04:14:49PM +0200, Tobias Klauser wrote:
> On 2014-10-01 at 15:43:47 +0200, Joe Perches wrote:
> > On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote:
> > > On 2014-09-30 at 23:29:46 +0200, Mark Einon wrote:
> > > > This adds the et
On Wed, Oct 01, 2014 at 04:14:49PM +0200, Tobias Klauser wrote:
On 2014-10-01 at 15:43:47 +0200, Joe Perches j...@perches.com wrote:
On Wed, 2014-10-01 at 14:45 +0200, Tobias Klauser wrote:
On 2014-09-30 at 23:29:46 +0200, Mark Einon mark.ei...@gmail.com wrote:
This adds the ethernet
On Tue, Sep 30, 2014 at 12:32:01PM -0700, Greg KH wrote:
>
> This is a fine way to make a patch, but it's no way that any of the
> netdev developers could ever review it to know what the code happens to
> look like in my staging-next branch :(
>
> How about just sending a patch that adds the
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
Signed-off-by: Mark Einon
---
This patch appiles to both staging-next and the linux-next tag next-20140930,
and takes into account all feedback recieved from the recent RFC for this
patch
On Tue, Sep 30, 2014 at 11:25:43PM +0530, Karthik Nayak wrote:
> Removes the 'out of memory' warning issued by checkpatch
>
> Signed-off-by: Karthik Nayak
> ---
Hi,
I'm not sure which tree you're working agianst, but this change has already
been made and is on both staging-next and linux-next.
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
> 1. WARNING: else is not generally useful after a break or return
>
> 2. WARNING: quoted string split across lines
>
> 3. WARNING: break quoted strings at a space character
>
> Signed-off-by: Karthik Nayak
> ---
Hi again,
You
On Tue, Sep 30, 2014 at 10:56:17PM +0530, Karthik Nayak wrote:
1. WARNING: else is not generally useful after a break or return
2. WARNING: quoted string split across lines
3. WARNING: break quoted strings at a space character
Signed-off-by: Karthik Nayak karthik@gmail.com
---
Hi
On Tue, Sep 30, 2014 at 11:25:43PM +0530, Karthik Nayak wrote:
Removes the 'out of memory' warning issued by checkpatch
Signed-off-by: Karthik Nayak karthik@gmail.com
---
Hi,
I'm not sure which tree you're working agianst, but this change has already
been made and is on both
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
This patch appiles to both staging-next and the linux-next tag next-20140930,
and takes into account all feedback recieved from the recent
On Tue, Sep 30, 2014 at 12:32:01PM -0700, Greg KH wrote:
This is a fine way to make a patch, but it's no way that any of the
netdev developers could ever review it to know what the code happens to
look like in my staging-next branch :(
How about just sending a patch that adds the driver to
Some split lines are less than 80 chars if rejoined, so rejoin them.
Reported-by: Joe Perches
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging
On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote:
> On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
>
> checkpatch type modification you might
Reported-by: Joe Perches
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cd90831..0a927d2 100644
--- a/drivers/staging/et131x
Reported-by: Joe Perches
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index f5459ec..cd90831 100644
--- a/drivers/staging/et131x/et131x.c
Reported-by: Joe Perches
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4b2ae49..b976c75 100644
--- a/drivers/staging/et131x
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index f5459ec..cd90831 100644
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 4b2ae49..b976c75
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index cd90831..0a927d2 100644
On Tue, Sep 23, 2014 at 02:07:17PM -0700, Joe Perches wrote:
On Tue, 2014-09-23 at 21:05 +0100, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
checkpatch type modification you might consider:
Reduce logging line
Some split lines are less than 80 chars if rejoined, so rejoin them.
Reported-by: Joe Perches j...@perches.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
Signed-off-by: Mark Einon
---
Changes from v1:
-modified MAINTAINERS in scope with changes
-Fixed typo in Kconfig, Atheros -> Agere
-Made review changes from Tobias Klauser, see patch
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 6539a8a..10f20b3 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x
br memory on allocation. Subsequent frees of
this fbr memory explicitly zeros the ring_virtaddr value.
Reported-by: Tobias Klauser
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c
The Power Management functions can be conditional by assigning pm ops
directly to .driver.pm, instead of using #ifdef's, saving some lines of
code.
Reported-by: Tobias Klauser
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 7 ++-
1 file changed, 2 insertions(+), 5
Casting a void* popinter to a struct pointer is unnecessary, don't do
it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 2889f86..6539a8a
On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote:
> On 2014-09-23 at 11:46:15 +0200, Mark Einon wrote:
> > On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
> >
> > Hi Tobias,
> >
> > Thanks for the d
On Tue, Sep 23, 2014 at 09:56:53AM +1000, Angus Gibson wrote:
> > +config NET_VENDOR_AGERE
> > + bool "Agere devices"
> > + default y
> > + depends on PCI
> > + ---help---
> > + If you have a network (Ethernet) card belonging to this class, say =
> > Y
> > + and read the
On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote:
> On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
> > This patch moves the et131x gigabit ethernet driver from drivers/staging
> > to drivers/net/ethernet/agere.
> >
> > There are no known issues at t
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
> > +/* et131x_rx_dma_memory_alloc
> > + *
> > + * Allocates Free buffer ring 1 for sure, free buffer ring 0 if required,
> > + * and the Packet Status Ring.
> >
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below -
[...]
+/* et131x_rx_dma_memory_alloc
+ *
+ * Allocates Free buffer ring 1 for sure, free buffer ring 0 if required,
+ * and the Packet Status Ring.
+ */
On Mon, Sep 22, 2014 at 06:57:25PM -0700, Joe Perches wrote:
On Mon, 2014-09-22 at 22:28 +0100, Mark Einon wrote:
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
There are no known issues at this time.
This doesn't apply to -next
On Tue, Sep 23, 2014 at 09:56:53AM +1000, Angus Gibson wrote:
+config NET_VENDOR_AGERE
+ bool Agere devices
+ default y
+ depends on PCI
+ ---help---
+ If you have a network (Ethernet) card belonging to this class, say =
Y
+ and read the Ethernet-HOWTO, available
On Tue, Sep 23, 2014 at 12:01:07PM +0200, Tobias Klauser wrote:
On 2014-09-23 at 11:46:15 +0200, Mark Einon mark.ei...@gmail.com wrote:
On Tue, Sep 23, 2014 at 09:22:53AM +0200, Tobias Klauser wrote:
Hi Tobias,
Thanks for the details review. I've replied below
The Power Management functions can be conditional by assigning pm ops
directly to .driver.pm, instead of using #ifdef's, saving some lines of
code.
Reported-by: Tobias Klauser tklau...@distanz.ch
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 7 ++-
1
Casting a void* popinter to a struct pointer is unnecessary, don't do
it.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index
on allocation. Subsequent frees of
this fbr memory explicitly zeros the ring_virtaddr value.
Reported-by: Tobias Klauser tklau...@distanz.ch
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 6539a8a..10f20b3 100644
--- a/drivers/staging/et131x/et131x.c
+++ b
This patch moves the et131x gigabit ethernet driver from drivers/staging
to drivers/net/ethernet/agere.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
Changes from v1:
-modified MAINTAINERS in scope with changes
-Fixed typo in Kconfig, Atheros - Agere
-Made review changes from Tobias
nstat->multicast refers to received packets, not transmitted as
is returned here. Change it so that received packet stats are
given.
Signed-off-by: Mark Einon
---
changing to send to alternate address for Gary Zambrano, maintainers entry
bounced.
drivers/net/ethernet/broadcom/b44.c | 2 +-
nstat->multicast refers to received packets, not transmitted as
is returned here. Change it so that received packet stats are
given.
Signed-off-by: Mark Einon
---
drivers/net/ethernet/broadcom/b44.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ether
nstat-multicast refers to received packets, not transmitted as
is returned here. Change it so that received packet stats are
given.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/net/ethernet/broadcom/b44.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
nstat-multicast refers to received packets, not transmitted as
is returned here. Change it so that received packet stats are
given.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
changing to send to alternate address for Gary Zambrano, maintainers entry
bounced.
drivers/net/ethernet
The driver supports auto-negotiation and 100BaetT_Half but doesn't
advertise or list it in it's phydev. Fix that.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c
Fix occurrences in et131x.c of:
CHECK: Alignment should match open parenthesis
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 130 +---
1 file changed, 67 insertions(+), 63 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers
ually need the dead code, as we're now using NAPI to
handle enabling interrupts - but we do need to enable interrupts if
NAPI is not scheduled - so enable interrupts if this is the case.
Reported-by: Dan Carpenter
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 18
The spinlock fbr_lock is only used in a single call sequence staring
from et131x_poll. As this call is already locked by napi->poll_lock,
we can remove it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/stag
The spinlock fbr_lock is only used in a single call sequence staring
from et131x_poll. As this call is already locked by napi-poll_lock,
we can remove it.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 6 --
1 file changed, 6 deletions(-)
diff --git
the dead code, as we're now using NAPI to
handle enabling interrupts - but we do need to enable interrupts if
NAPI is not scheduled - so enable interrupts if this is the case.
Reported-by: Dan Carpenter dan.carpen...@oracle.com
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x
Fix occurrences in et131x.c of:
CHECK: Alignment should match open parenthesis
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 130 +---
1 file changed, 67 insertions(+), 63 deletions(-)
diff --git a/drivers/staging
The driver supports auto-negotiation and 100BaetT_Half but doesn't
advertise or list it in it's phydev. Fix that.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers
On Sat, Aug 30, 2014 at 01:32:16PM -0700, Greg KH wrote:
> On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote:
> > Replace a long list of contiguous writel() calls with a for loop iterating
> > over the same values.
> >
> > Signed-off-by: Mark Einon
> >
On Sat, Aug 30, 2014 at 01:32:16PM -0700, Greg KH wrote:
On Wed, Aug 20, 2014 at 11:17:53PM +0100, Mark Einon wrote:
Replace a long list of contiguous writel() calls with a for loop iterating
over the same values.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging
i2c_wack is only used to implement a while(1) loop, so let's remove it.
Signed-off-by: Mark Einon
---
Modified to remove function parameter indenting changes, which are
largely unrelated.
drivers/staging/et131x/et131x.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote:
> Hi Mark,
>
> On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon wrote:
>
> >
> > Hi Fabio, thanks for the review.
> >
> > It's a space alignment of parameters to go with the previous change, to
>
() to et131x_handle_send_pkts()
-replacing bottom half workqueue with poll function which handles
send & receive of skbs.
-adding various other necessary standard napi calls.
Also remove this item from the README TODO list.
Signed-off-by: Mark Einon
---
Updated after Stephen Hemminger comme
On Thu, Aug 21, 2014 at 08:40:20AM +, David Laight wrote:
> From: Mark Einon
> > Replace a long list of contiguous writel() calls with a for loop iterating
> > over the same address values.
> >
> > Also remove redundant comments on the macstat registers, the variabl
On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> > - bool done = true;
> > + int count = 0;
> > + int limit = budget;
> > + bool not_done = false;
>
> Don't use negative
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
> On Wed, 20 Aug 2014 23:17:58 +0100
> Mark Einon wrote:
>
> >
> > + if (budget > MAX_PACKETS_HANDLED)
> > + limit = MAX_PACKETS_HANDLED;
>
> Why this artificial restriction
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote:
> On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon wrote:
>
> > do {
> > pci_read_config_dword(pdev,
> > -
On Wed, Aug 20, 2014 at 07:22:54PM -0300, Fabio Estevam wrote:
On Wed, Aug 20, 2014 at 7:17 PM, Mark Einon mark.ei...@gmail.com wrote:
do {
pci_read_config_dword(pdev,
- LBCIF_DATA_REGISTER, val
On Wed, Aug 20, 2014 at 08:25:01PM -0700, Stephen Hemminger wrote:
On Wed, 20 Aug 2014 23:17:58 +0100
Mark Einon mark.ei...@gmail.com wrote:
+ if (budget MAX_PACKETS_HANDLED)
+ limit = MAX_PACKETS_HANDLED;
Why this artificial restriction?
Hi Stephen, thanks
On Wed, Aug 20, 2014 at 08:25:45PM -0700, Stephen Hemminger wrote:
On Wed, 20 Aug 2014 23:17:58 +0100
Mark Einon mark.ei...@gmail.com wrote:
- bool done = true;
+ int count = 0;
+ int limit = budget;
+ bool not_done = false;
Don't use negative variables. Better to keep
On Thu, Aug 21, 2014 at 08:40:20AM +, David Laight wrote:
From: Mark Einon
Replace a long list of contiguous writel() calls with a for loop iterating
over the same address values.
Also remove redundant comments on the macstat registers, the variable names
are good enough
() to et131x_handle_send_pkts()
-replacing bottom half workqueue with poll function which handles
send receive of skbs.
-adding various other necessary standard napi calls.
Also remove this item from the README TODO list.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
Updated after Stephen
On Thu, Aug 21, 2014 at 09:06:40AM -0300, Fabio Estevam wrote:
Hi Mark,
On Thu, Aug 21, 2014 at 6:18 AM, Mark Einon mark.ei...@gmail.com wrote:
Hi Fabio, thanks for the review.
It's a space alignment of parameters to go with the previous change, to
keep wrapping consistent
i2c_wack is only used to implement a while(1) loop, so let's remove it.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
Modified to remove function parameter indenting changes, which are
largely unrelated.
drivers/staging/et131x/et131x.c | 5 +
1 file changed, 1 insertion(+), 4
i2c_wack is only used to implement a while(1) loop, so let's remove it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index fc18e8d
There's already working code to set the mac address, so let's use it.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 53 +
1 file changed, 1 insertion(+), 52 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging
Replace a long list of contiguous writel() calls with a for loop iterating
over the same address values.
Also remove redundant comments on the macstat registers, the variable names
are good enough.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 59
There's no need to handle any rx/tx interrupts in the middle of an mtu
change, so don't.
After this change, receive and transmit interrupts are only handled in
one place, which paves the way to using NAPI.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 --
1 file changed, 2
Replace a long list of contiguous writel() calls with a for loop iterating
over the same values.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 27 +++
1 file changed, 3 insertions(+), 24 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b
We actually mean to clear the ET_INTR_TXDMA_ISR reg after handling
a completed transfer, not the ET_INTR_TXDMA_ERR reg, which should
get handled immediately after.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
To better describe it's use as a hard limit.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/et131x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 551b250..df83ea3 100644
--- a/drivers
so won't apply cleanly in it's
current state. Please let me know if I need to do anything about this.
Cheers,
Mark
---
Mark Einon (8):
staging: et131x: Use eth_mac_addr() instead of duplicating the
functionality
staging: et131x: Don't handle rx/tx packets when changing mtu
staging: et1
() to et131x_handle_send_pkts()
-replacing bottom half workqueue with poll function which handles
send & receive of skbs.
-adding various other necessary standard napi calls.
Also remove this item from the README TODO list.
Signed-off-by: Mark Einon
---
drivers/staging/et131x/README |
() to et131x_handle_send_pkts()
-replacing bottom half workqueue with poll function which handles
send receive of skbs.
-adding various other necessary standard napi calls.
Also remove this item from the README TODO list.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x
, not staging-next - so won't apply cleanly in it's
current state. Please let me know if I need to do anything about this.
Cheers,
Mark
---
Mark Einon (8):
staging: et131x: Use eth_mac_addr() instead of duplicating the
functionality
staging: et131x: Don't handle rx/tx packets when changing mtu
We actually mean to clear the ET_INTR_TXDMA_ISR reg after handling
a completed transfer, not the ET_INTR_TXDMA_ERR reg, which should
get handled immediately after.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 2 +-
1 file changed, 1 insertion(+), 1
To better describe it's use as a hard limit.
Signed-off-by: Mark Einon mark.ei...@gmail.com
---
drivers/staging/et131x/et131x.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index 551b250..df83ea3
1 - 100 of 189 matches
Mail list logo
