Re: [PATCH] nfc: fix typo

2021-01-24 Thread Mark Greer
nuous SPI transaction or not, and the actual > - * direct cmd opcode or regster address. > + * direct cmd opcode or register address. > */ > #define TRF7970A_CMD_BIT_CTRL BIT(7) > #define TRF7970A_CMD_BIT_RW BIT(6) Acked-by: Mark Greer

Re: [PATCH] greybus: audio: remove unused code

2020-05-13 Thread Mark Greer
ing again they can take a look at the git history. Thanks for this, Alexandre. Acked-by: Mark Greer

Re: [PATCH 7/9] staging: greybus: move core include files to include/linux/greybus/

2019-08-27 Thread Mark Greer
> Cc: Alex Elder > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: Rui Miguel Silva > Cc: David Lin > Cc: "Bryan O'Donoghue" > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Greg Kroah-Hartman > --- Acked-by: Mark Greer

Re: [PATCH 2/9] staging: greybus: remove license "boilerplate"

2019-08-27 Thread Mark Greer
: Alex Elder > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Viresh Kumar > Cc: "Bryan O'Donoghue" > Cc: greybus-...@lists.linaro.org > Cc: de...@driverdev.osuosl.org > Signed-off-by: Greg Kroah-Hartman > --- Acked-by: Mark Greer

Re: [PATCH] staging: greybus: remove redundant assignment to variable is_empty

2019-07-04 Thread Mark Greer
udio_manager_module *module, *next; > - int is_empty = 1; > + int is_empty; > > down_write(&modules_rwsem); Reviewed-by: Mark Greer

Re: DMA coherency in drivers/tty/serial/mpsc.c

2019-06-26 Thread Mark Greer
On Wed, Jun 26, 2019 at 08:48:37AM +0200, Christoph Hellwig wrote: > On Tue, Jun 25, 2019 at 09:37:22AM -0700, Mark Greer wrote: > > Yeah, the mpsc driver had lots of ugly cache related hacks because of > > cache coherency bugs in the early version of the MV64x60 bridge chips

[PATCH] serial: mpsc: Remove obsolete MPSC driver

2019-06-26 Thread Mark Greer
Support for the Marvell MV64x60 line of bridge chips that contained MPSC controllers has been removed and there are no other components that have that controller so remove its driver. Signed-off-by: Mark Greer --- Documentation/admin-guide/devices.txt |4 +- drivers/tty/serial/Kconfig

Re: DMA coherency in drivers/tty/serial/mpsc.c

2019-06-25 Thread Mark Greer
On Tue, Jun 25, 2019 at 02:26:41PM +0200, Christoph Hellwig wrote: > Hi Paul, Dale and Mark (I hope this reaches the right Mark), Hi Christoph. Yes, you did reach the right Mark. :) > I've started auditing all users of DMA_ATTR_NON_CONSISTENT ot prepare > for major API improvements in that area

Re: [PATCH] greybus: audio_manager: fix a missing check of ida_simple_get

2019-04-30 Thread Mark Greer
rwal I am sorry for not responding until now. For some strange reason, email from this list are being delayed. I just got this today (April 30). Thanks for the patch, Kangjie, and thanks for the review, Vaibhav. And FWIW, Reviewed-by: Mark Greer Mark --

Re: [PATCH] staging: greybus: fix spelling mistake: "Inavlid" -> "Invalid"

2018-05-22 Thread Mark Greer
, "Invalid kcontrol count=%d for %s\n", > w->ncontrols, w->name); > return ret; > } Acked-by: Mark Greer

Re: [RESEND][PATCH 2/4] NFC: st21nfca: Fix memory OOB and leak issues in connectivity events handler

2018-04-20 Thread Mark Greer
On Fri, Apr 20, 2018 at 03:39:46PM +0300, Andy Shevchenko wrote: > On Wed, 2018-04-18 at 15:35 +0530, Amit Pundir wrote: > > > if (skb->data[transaction->aid_len + 2] != > > - NFC_EVT_TRANSACTION_PARAMS_TAG) > > + NFC_EVT_TRANSACTION_PARAMS_TAG || > > +

Re: [PATCH v3] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Mark Greer
n audio.h > + * (Android media layer) > + */ > enum { > GBAUDIO_DEVICE_NONE = 0x0, > /* reserved bits */ > -- > 1.9.1 Reviewed-by: Mark Greer

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-06 Thread Mark Greer
On Fri, Apr 06, 2018 at 10:52:17AM +0530, Viresh Kumar wrote: > On Fri, Apr 6, 2018 at 3:49 AM, Mark Greer wrote: > > On Wed, Apr 04, 2018 at 12:02:46AM +0530, Gaurav Dhingra wrote: > >> Wrap comment to fix warning "prefer a maximum 75 chars per line" > >&g

[PATCH 4/5] powerpc/boot: Remove core support for Marvell mv64x60 hostbridges

2018-04-05 Thread Mark Greer
There are no longer any platforms that use Marvell's mv64x60 hostbridges so remove the supporting boot code. Signed-off-by: Mark Greer --- arch/powerpc/boot/Makefile | 2 +- arch/powerpc/boot/mv64x60.c | 581 arch/powerpc/boot/mv64x60.h

[PATCH 5/5] powerpc: Remove core support for Marvell mv64x60 hostbridges

2018-04-05 Thread Mark Greer
There are no longer any platforms that use Marvell's mv64x60 hostbridges so remove the supporting kernel code. CC: Dale Farnsworth Signed-off-by: Mark Greer --- Documentation/devicetree/bindings/marvell.txt | 516 - arch/powerpc/sysdev/Makefile

[PATCH 0/5] powerpc: Remove support for Marvell mv64x60 hostbridges

2018-04-05 Thread Mark Greer
5c24035003 (Automatic merge of branches 'master', 'next' and 'fixes' into merge) Thanks, Mark -- Mark Greer (5): powerpc/embedded6xx: Remove C2K board support powerpc/boot: Remove support for Marvell MPSC serial controller powerpc/boot: Remove support for Marve

[PATCH 1/5] powerpc/embedded6xx: Remove C2K board support

2018-04-05 Thread Mark Greer
The C2K platform appears to be orphaned so remove code supporting it. CC: Remi Machet Signed-off-by: Mark Greer --- arch/powerpc/boot/Makefile | 5 +- arch/powerpc/boot/cuboot-c2k.c | 189 -- arch/powerpc/boot/dts/c2k.dts | 366

[PATCH 2/5] powerpc/boot: Remove support for Marvell MPSC serial controller

2018-04-05 Thread Mark Greer
There are no longer any platforms that use Marvell's MPSC serial controller so remove its driver. Signed-off-by: Mark Greer --- arch/powerpc/boot/Makefile | 2 +- arch/powerpc/boot/mpsc.c | 169 - arch/powerpc/boot/ops.h| 1 - arch/po

[PATCH 3/5] powerpc/boot: Remove support for Marvell mv64x60 i2c controller

2018-04-05 Thread Mark Greer
There are no longer any platforms that use Marvell's mv64x60's i2c controller so remove its driver. Signed-off-by: Mark Greer --- arch/powerpc/boot/Makefile | 2 +- arch/powerpc/boot/mv64x60_i2c.c | 204 2 files changed, 1 inserti

Re: [PATCH] staging: greybus: Fix warning to limit chars per line

2018-04-05 Thread Mark Greer
bits */ > -- > 1.9.1 Hi Gaurav. Thank you for the patch, it looks fine to me. Reviewed-by: Mark Greer

Re: [PATCH V9 1/4] dma-mapping: Rework dma_get_cache_alignment()

2017-10-24 Thread Mark Greer
Cc: Marek Szyprowski > Cc: Kyungmin Park > Cc: Michael Chan > Cc: Benjamin Herrenschmidt > Cc: Ivan Mikhaylov > Cc: Tariq Toukan > Cc: Andy Gross > Cc: Mark A. Greer > Cc: Robert Baldyga > Cc: Marek Szyprowski > Signed-off-by: Huacai Chen > --- For the mpsc stuff: Acked-by: Mark Greer

Re: [PATCH V8 1/5] dma-mapping: Rework dma_get_cache_alignment()

2017-10-18 Thread Mark Greer
On Tue, Oct 17, 2017 at 04:05:38PM +0800, Huacai Chen wrote: > Make dma_get_cache_alignment() to accept a 'dev' argument. As a result, > it can return different alignments due to different devices' I/O cache > coherency. > > Currently, ARM/ARM64 and MIPS support coherent & noncoherent devices > co

Re: [PATCH 2/3] greybus: audio: don't inclide rwlock.h directly.

2017-10-05 Thread Mark Greer
On Thu, Oct 05, 2017 at 02:56:54PM +0200, Sebastian Andrzej Siewior wrote: > rwlock.h should not be included directly. Instead linux/splinlock.h > should be included. One thing it does is to break the RT build. > > Cc: Vaibhav Agarwal > Cc: Mark Greer > Cc: Johan Hovold >

Re: [PATCH] staging: greybus: audio: constify snd_soc_dai_ops structures

2017-08-21 Thread Mark Greer
_dai_ops gbcodec_dai_ops = { > .startup = gbcodec_startup, > .shutdown = gbcodec_shutdown, > .hw_params = gbcodec_hw_params, Thanks Arvind. Acked-by: Mark Greer

Re: [PATCH v4] NFC: trf7970a: Correct register settings for 27MHz clock

2017-04-27 Thread Mark Greer
On Thu, Apr 27, 2017 at 05:28:46PM -0400, Geoff Lansberry wrote: > In prior commits the selected clock frequency does not propagate > correctly to what is written to the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- Acked-by: Mark Greer

Re: [PATCH v3] NFC: trf7970a: Correct register settings for 27MHz clock

2017-04-27 Thread Mark Greer
IRQF_TRIGGER_RISING | IRQF_ONESHOT, > -- > 2.7.4 With the suggested fix above: Acked-by: Mark Greer

Re: [PATCH v2] NFC: trf7970a: Correct register settings for 27MHz clock

2017-04-26 Thread Mark Greer
On Wed, Apr 26, 2017 at 09:41:48PM -0400, Geoff Lansberry wrote: Hi Geoff. > In prior commits the selected clock frequency does not propagate > correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > > Signed-off-by: Geoff Lansberry > --- > drivers/nfc/trf7970a.c | 7

Re: [PATCH] NFC: trf7970a: Correct register settings for 27MHz clock

2017-04-26 Thread Mark Greer
On Wed, Apr 26, 2017 at 09:48:33AM -0400, Geoff Lansberry wrote: > In prior commits the selected clock frequency does not propagate > correctly to what is written the the TRF7970A_MODULATOR_SYS_CLK_CTRL > register. > Also fixes a bug that causes the device tree property check to always > pass. > >

Re: [PATCH] power: bq24190_charger: mark PM functions as __maybe_unused

2017-03-20 Thread Mark Greer
quot;power: bq24190_charger: Check the interrupt status on > resume") > Signed-off-by: Arnd Bergmann > --- Probably too late but if it isn't... Acked-by: Mark Greer

Re: [PATCH -next] staging: greybus: audio_gb.c: Change uint32_t to u32

2017-01-22 Thread Mark Greer
, > > CHECK: Prefer kernel type 'u32' over 'uint32_t' > + uint32_t format, uint32_t rate, u8 channels, > > Signed-off-by: Marcos Paulo de Souza > --- Good catch, thanks. Acked-by: Mark Greer

Re: [PATCH v3 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2017-01-20 Thread Mark Greer
the hardware configuration. If no option is supplied it defaults to > 3.3 volt configuration. > > Signed-off-by: Geoff Lansberry > --- > .../devicetree/bindings/net/nfc/trf7970a.txt | 2 ++ > drivers/nfc/trf7970a.c | 26 > +++++- Acked-by: Mark Greer

Re: [PATCH v3 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2017-01-19 Thread Mark Greer
13.56MHz clock or the optional 27.12MHz clock. > > Signed-off-by: Geoff Lansberry > --- Acked-by: Mark Greer

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Mark Greer
On Tue, Jan 03, 2017 at 01:35:18PM -0500, Geoff Lansberry wrote: > On Tue, Jan 3, 2017 at 11:33 AM, Mark Greer wrote: > > On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > >> In the meantime - here is some more info about how we use it. > >> > >

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2017-01-03 Thread Mark Greer
[Please stop top-posting. Bottom-post only to these lists.] Hi Geoff & happy new year. On Tue, Dec 27, 2016 at 09:18:32AM -0500, Geoff Lansberry wrote: > Mark - I will split this off soon. OK > In the meantime - here is some more info about how we use it. > > We do use NFC structures.I di

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-24 Thread Mark Greer
On Sat, Dec 24, 2016 at 11:17:18AM -0500, Geoff Lansberry wrote: > Mark - I'm sorry, but I did not write this code, and therefore was not > able to accurately describe it. It is fixing a different issue, not > the neard segfault that we are still chasing. Last week Jaret Cantu > sent a separate e

Re: [PATCH v3 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-23 Thread Mark Greer
On Wed, Dec 21, 2016 at 11:18:34PM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the state of the trf7970a is currently reading but > another request has been made to send a command before it has finished

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-21 Thread Mark Greer
On Wed, Dec 21, 2016 at 06:47:36AM -0500, Geoff Lansberry wrote: > Thanks Mark. Should I resubmit patches with the requested edits today, or > wait a bit for more comments? What is the desired etiquette? Its up to you. I don't think there are any hard & fast rules on this. If it were me, I w

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:16:31AM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry > > The TRF7970A has configuration options for supporting hardware designs > with 1.8 Volt or 3.3 Volt IO. This commit adds a device tree option, > using a fixed regulator binding, for setting the io voltag

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:13:23AM -0500, Geoff Lansberry wrote: > On Mon, Dec 19, 2016 at 5:35 PM, Rob Herring wrote: > > On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > >> From: Geoff Lansberry > >> > >> --- > >> Documentation/devicetree/bindings/net/nfc/trf7970a.txt | 2 ++

Re: nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 02:13:52PM -0500, Justin Bronder wrote: > On 20/12/16 11:59 -0700, Mark Greer wrote: > > On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > > > From: Jaret Cantu > > > > > > Repeated polling attempts cause a NULL deref

Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 11:16:32AM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the state of the trf7970a is currently reading but > another request has been made to send a command before it has finished

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Mark Greer
On Tue, Dec 20, 2016 at 01:29:13PM -0500, Geoff Lansberry wrote: > On Tue, Dec 20, 2016 at 1:11 PM, Mark Greer wrote: > > Hi Geoff. > > > > Please put the version in your subjects when submitting anything but the > > initial version of a patch (e.g., [PATCH v2 1/3]).

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-20 Thread Mark Greer
Hi Geoff. Please put the version in your subjects when submitting anything but the initial version of a patch (e.g., [PATCH v2 1/3]). Which series do you want reviewed? Mark --

Re: [PATCH 3/3] nfc: trf7970a: Prevent repeated polling from crashing the kernel

2016-12-15 Thread Mark Greer
On Thu, Dec 15, 2016 at 05:30:44PM -0500, Geoff Lansberry wrote: > From: Jaret Cantu > > Repeated polling attempts cause a NULL dereference error to occur. > This is because the curent state of the trf7970a is reading but > a request has been made to send a command. > > The solution is to proper

Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage

2016-12-15 Thread Mark Greer
On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry Missing commit description. > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 2d2a077..b4c37ab 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -1048,6 +1049,11

Re: [PATCH 1/3] NFC: trf7970a: add device tree option for 27MHz clock

2016-12-15 Thread Mark Greer
Hi Geoff. On Thu, Dec 15, 2016 at 05:30:42PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry Please add an informative commit description to all of your commits. No matter how trivial this patch may seem to you now, it may not be to others (or to you in a few years). > diff --git a/driver