Re: linux-next: build failure after merge of the rdma tree

2019-07-09 Thread Mark Zhang
-port auto mode support") Signed-off-by: Mark Zhang diff --git a/include/rdma/rdma_counter.h b/include/rdma/rdma_counter.h index 68827700ba95..eb99856e8b30 100644 --- a/include/rdma/rdma_counter.h +++ b/include/rdma/rdma_counter.h @@ -9,10 +9,10 @@ #include #include -#include

Re: [PATCH v3 2/4] mfd: max77620: add documentation for backup battery charging

2019-02-18 Thread Mark Zhang
On 2/19/2019 10:07 AM, Mark Zhang wrote: > On 2/19/2019 2:06 AM, Rob Herring wrote: >> On Tue, Feb 12, 2019 at 12:44 AM Mark Zhang wrote: >>> >>> Adding documentation for 3 new backup battery charging dts >>> properties: >>> - maxim,charging-current-mi

Re: [PATCH v3 2/4] mfd: max77620: add documentation for backup battery charging

2019-02-18 Thread Mark Zhang
On 2/19/2019 2:06 AM, Rob Herring wrote: > On Tue, Feb 12, 2019 at 12:44 AM Mark Zhang wrote: >> >> Adding documentation for 3 new backup battery charging dts >> properties: >> - maxim,charging-current-microamp >> - maxim,charging-voltage-microvolt >> - max

Re: [PATCH v2 0/4] Add max77620 charging & low battery support

2019-02-12 Thread Mark Zhang
On 2/12/2019 4:04 PM, Lee Jones wrote: > On Tue, 12 Feb 2019, Mark Zhang wrote: > >> On 2/7/2019 4:48 PM, Lee Jones wrote: >>> On Tue, 29 Jan 2019, Mark Zhang wrote: >>> >>>> This patch set adds support for max77620 backup battery charging and >>&g

[PATCH v3 0/4] Add max77620 charging & low battery support

2019-02-11 Thread Mark Zhang
This patch set adds support for max77620 backup battery charging and low battery monitoring. Changes in v3: - Add unit suffix to backup battery charging dts properties - Reduce/optimize the low battery monitoring dts properties Changes in v2: - Add devicetree binding documentation Mark Zhang (4

[PATCH v3 2/4] mfd: max77620: add documentation for backup battery charging

2019-02-11 Thread Mark Zhang
Adding documentation for 3 new backup battery charging dts properties: - maxim,charging-current-microamp - maxim,charging-voltage-microvolt - maxim,output-resister-ohms Signed-off-by: Mark Zhang --- .../devicetree/bindings/mfd/max77620.txt | 20 +++ 1 file changed, 20

[PATCH v3 4/4] mfd: max77620: add documentation for low battery monitoring

2019-02-11 Thread Mark Zhang
Adding documentation for low battery monitor properties: - maxim,low-battery-dac-enable - maxim,low-battery-mode Signed-off-by: Mark Zhang --- Documentation/devicetree/bindings/mfd/max77620.txt | 14 ++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings

[PATCH v3 3/4] mfd: max77620: Add low battery monitor support

2019-02-11 Thread Mark Zhang
This patch adds PMIC configurations for low-battery monitoring by handling max77620 register CNFGGLBL1. Signed-off-by: Laxman Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 35 ++- 1 file changed, 34 insertions

[PATCH v3 1/4] mfd: max77620: Add backup battery charger support

2019-02-11 Thread Mark Zhang
Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index d8ddd1a6f304..494d98357f65 100644 --- a/drivers/mfd

Re: [PATCH v2 0/4] Add max77620 charging & low battery support

2019-02-11 Thread Mark Zhang
On 2/7/2019 4:48 PM, Lee Jones wrote: > On Tue, 29 Jan 2019, Mark Zhang wrote: > >> This patch set adds support for max77620 backup battery charging and >> low battery monitoring. >> >> Changes in v2: >> - Add devicetree binding documentation >> >>

Re: [PATCH v2 4/4] mfd: max77620: add documentation for low battery monitoring

2019-01-30 Thread Mark Zhang
On 1/31/2019 3:53 AM, Rob Herring wrote: > On Tue, Jan 29, 2019 at 04:55:31PM +0800, Mark Zhang wrote: >> Adding documentation for low battery monitor properties: >> - maxim,low-battery-dac-enable >> - maxim,low-battery-dac-disable >> - maxim,low-battery-shutdown-en

Re: [PATCH v2 2/4] mfd: max77620: add documentation for backup battery charging

2019-01-30 Thread Mark Zhang
On 1/31/2019 3:51 AM, Rob Herring wrote: > On Tue, Jan 29, 2019 at 04:55:29PM +0800, Mark Zhang wrote: >> Adding documentation for 3 new backup battery charging dts >> properties: >> - maxim,backup-battery-charging-current >> - maxim,backup-battery-charging-voltage >&

答复: [2/2] mfd: max77620: Add low battery monitor support

2019-01-29 Thread Mark Zhang
_chip writes 0xFF to offset zero. Mark -邮件原件- 发件人: Billy Laws 发送时间: Tuesday, January 29, 2019 9:34 PM 收件人: Mark Zhang 抄送: Lee Jones ; linux-kernel@vger.kernel.org; linux-te...@vger.kernel.org; Laxman Dewangan ; Venkat Reddy Talla 主题: Re: [2/2] mfd: max77620: Add low battery monito

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-29 Thread Mark Zhang
o regmap_add_irqchip should not touch them so I didn't make changes to driver codes in v2. Mark > > On Tue, Jan 29, 2019 at 6:52 AM Mark Zhang wrote: >> >> On 1/27/2019 10:54 PM, Billy Laws wrote: >>> >This patch adds PMIC configurations for low-battery >>

[PATCH v2 4/4] mfd: max77620: add documentation for low battery monitoring

2019-01-29 Thread Mark Zhang
Adding documentation for low battery monitor properties: - maxim,low-battery-dac-enable - maxim,low-battery-dac-disable - maxim,low-battery-shutdown-enable - maxim,low-battery-shutdown-disable - maxim,low-battery-reset-enable - maxim,low-battery-reset-disable Signed-off-by: Mark Zhang

[PATCH v2 0/4] Add max77620 charging & low battery support

2019-01-29 Thread Mark Zhang
This patch set adds support for max77620 backup battery charging and low battery monitoring. Changes in v2: - Add devicetree binding documentation Mark Zhang (4): mfd: max77620: Add backup battery charger support mfd: max77620: add documentation for backup battery charging mfd: max77620

[PATCH v2 1/4] mfd: max77620: Add backup battery charger support

2019-01-29 Thread Mark Zhang
Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index d8ddd1a6f304..f58143103185 100644 --- a/drivers/mfd

[PATCH v2 2/4] mfd: max77620: add documentation for backup battery charging

2019-01-29 Thread Mark Zhang
Adding documentation for 3 new backup battery charging dts properties: - maxim,backup-battery-charging-current - maxim,backup-battery-charging-voltage - maxim,backup-battery-output-resister Signed-off-by: Mark Zhang --- .../devicetree/bindings/mfd/max77620.txt | 20 +++ 1

[PATCH v2 3/4] mfd: max77620: Add low battery monitor support

2019-01-29 Thread Mark Zhang
This patch adds PMIC configurations for low-battery monitoring by handling max77620 register CNFGGLBL1. Signed-off-by: Laxman Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 57 +- 1 file changed, 56

答复: [2/2] mfd: max77620: Add low battery monitor support

2019-01-28 Thread Mark Zhang
Oh yeah will do, thanks. -邮件原件- 发件人: Billy Laws 发送时间: Tuesday, January 29, 2019 3:36 PM 收件人: Mark Zhang 抄送: Lee Jones ; linux-kernel@vger.kernel.org; linux-te...@vger.kernel.org; Laxman Dewangan ; Venkat Reddy Talla 主题: Re: [2/2] mfd: max77620: Add low battery monitor support Sure

Re: [2/2] mfd: max77620: Add low battery monitor support

2019-01-28 Thread Mark Zhang
really need them. Or you can create a patch if you have requirement for them, is this OK to you Billy? Mark > > See: https://datasheetspdf.com/pdf-file/924230/Maxim/MAX8698C/1  pg 46 > >Signed-off-by: Laxman Dewangan > >Signed-off-by: Venkat Reddy Talla > >Signe

[PATCH 1/2] mfd: max77620: Add backup battery charger support

2019-01-22 Thread Mark Zhang
Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 80 ++ 1 file changed, 80 insertions(+) diff --git a/drivers/mfd/max77620.c b/drivers/mfd/max77620.c index d8ddd1a6f304..f58143103185 100644 --- a/drivers/mfd

[PATCH 2/2] mfd: max77620: Add low battery monitor support

2019-01-22 Thread Mark Zhang
This patch adds PMIC configurations for low-battery monitoring by handling max77620 register CNFGGLBL1. Signed-off-by: Laxman Dewangan Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/mfd/max77620.c | 57 +- 1 file changed, 56

Re: [PATCH] regmap-irq: do not write mask register if mask_base is zero

2019-01-14 Thread Mark Zhang
x27;s mask register address is zero, in that case, could you help to suggest what is the right way? Thanks, Mark On 1/14/2019 5:32 PM, Mark Zhang wrote: > If client have not provided the mask base register then do not > write into the mask register. > > Signed-off-by: Laxman Dewan

[PATCH] regmap-irq: do not write mask register if mask_base is zero

2019-01-14 Thread Mark Zhang
If client have not provided the mask base register then do not write into the mask register. Signed-off-by: Laxman Dewangan Signed-off-by: Jinyoung Park Signed-off-by: Venkat Reddy Talla Signed-off-by: Mark Zhang --- drivers/base/regmap/regmap-irq.c | 6 ++ 1 file changed, 6 insertions

Re: [PATCH 2/2] regulator: max77620: disable notifier events for FPS rails

2019-01-11 Thread Mark Zhang
On 1/10/2019 8:07 PM, Mark Brown wrote: > On Thu, Jan 10, 2019 at 12:11:17PM +0800, Mark Zhang wrote: > >> +/* there is no SW control for rails which are part of FPS >> + * set always no contraint to true to avoid regulator >> + * ena

[PATCH 1/2] regulator: max77620: Initialize values for DT properties

2019-01-09 Thread Mark Zhang
If regulator DT node doesn't exist, its of_parse_cb callback function isn't called. Then all values for DT properties are filled with zero. This leads to wrong register update for FPS and POK settings. Signed-off-by: Jinyoung Park Signed-off-by: Mark Zhang --- drivers/regulato

[PATCH 2/2] regulator: max77620: disable notifier events for FPS rails

2019-01-09 Thread Mark Zhang
Signed-off-by: Mark Zhang --- drivers/regulator/max77620-regulator.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/regulator/max77620-regulator.c b/drivers/regulator/max77620-regulator.c index cd93cf53e23c..20e985071bfc 100644 --- a/drivers/regulator/max77620-regulator.c

Re: [Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-25 Thread Mark Zhang
\n" + " daddu %0, $1 \n" #endif " .setpop" : "=r" (sum) 2017-01-26 2:13 GMT+08:00 Alexander Duyck : > On Tue, Jan 24, 2017 at 8:35 PM, Mark Zhang wrote: >> If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1

[Bug fix]mips 64bits checksum error -- csum_tcpudp_nofold

2017-01-24 Thread Mark Zhang
If the input parameters as saddr = 0xc0a8fd60,daddr = 0xc0a8fda1,len = 80, proto = 17, sum =0x7eae049d. The correct result should be 1, but original function return 0. Attached the correction patch. 0001-Fixed-the-mips-64bits-checksum-error-csum_tcpudp_nof.patch Description: Binary data

[PATCH v2] memory: Add NVIDIA SMMU suspend/resume support

2014-12-23 Thread Mark Zhang
This patch adds suspend/resume support for NVIDIA SMMU. Signed-off-by: Mark Zhang --- Hi Alex/Olof/Thierry/Hiroshi, This patch is created on top of Thierry Reding's patch set: "[PATCH v7 00/12] NVIDIA Tegra memory controller and IOMMU support" Changes since v1: - Remove the l

Re: [PATCH] memory: Add NVIDIA SMMU suspend/resume support

2014-12-22 Thread Mark Zhang
On 12/12/2014 04:18 PM, Alexandre Courbot wrote: > Hi Mark, > > On Mon, Dec 8, 2014 at 3:20 PM, Mark Zhang wrote: >> This patch adds suspend/resume support for NVIDIA SMMU. > > >> This patch is created on top of Thierry Reding's patch set: >> >> &quo

Re: [PATCH] drm/tegra: dsi: Add suspend/resume support

2014-12-09 Thread Mark Zhang
On 12/10/2014 03:29 AM, Sean Paul wrote: > On Sun, Dec 7, 2014 at 10:40 PM, Mark Zhang wrote: >> This patch adds the suspend/resume support for Tegra drm >> driver by calling the corresponding DPMS functions. [...] >> + if (dsi->slave) { >> + err

[PATCH] clk: tegra: Define PLLD_DSI and remove dsia(b)_mux

2014-12-08 Thread Mark Zhang
ol. Signed-off-by: Peter De Schrijver Signed-off-by: Mark Zhang --- drivers/clk/tegra/clk-id.h | 2 -- drivers/clk/tegra/clk-tegra-periph.c | 2 -- drivers/clk/tegra/clk-tegra114.c | 10 +++-- drivers/clk/tegra/clk-tegra124.c | 36 ++---

[PATCH] drm/tegra: dsi: Add suspend/resume support

2014-12-07 Thread Mark Zhang
This patch adds the suspend/resume support for Tegra drm driver by calling the corresponding DPMS functions. Signed-off-by: Mark Zhang --- Hi, This patch hooks DSI driver's suspend/resume to implement the whole display system's suspend/resume. I know this is a super ugly way, but as w

[PATCH] memory: Add NVIDIA SMMU suspend/resume support

2014-12-07 Thread Mark Zhang
This patch adds suspend/resume support for NVIDIA SMMU. This patch is created on top of Thierry Reding's patch set: "[PATCH v7 00/12] NVIDIA Tegra memory controller and IOMMU support" Signed-off-by: Mark Zhang --- drivers/iommu/te

[PATCH] arm: mm: add memory type for inner-writeback

2013-12-26 Thread Mark Zhang
From: Colin Cross For streaming-style operations (e.g., software rendering of graphics surfaces shared with non-coherent DMA devices), the cost of performing L2 cache maintenance can exceed the benefit of having the larger cache (this is particularly true for OUTER_CACHE configurations like the A

Re: [PATCHv7 06/12] ARM: tegra: create a DT header defining SWGROUP ID

2013-12-18 Thread Mark Zhang
On 12/12/2013 03:57 PM, Hiroshi Doyu wrote: > Create a header file to define the swgroup IDs used by the IOMMU(SMMU) > binding. "swgroup" is a group of H/W clients which a Tegra SoC > supports. This unique ID can be used to calculate MC_SMMU_ name>_ASID_0 register offset and MC__HOTRESET_*_0 > regi

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-23 Thread Mark Zhang
On 10/23/2013 06:58 PM, Thierry Reding wrote: > On Wed, Oct 23, 2013 at 06:46:17PM +0800, Mark Zhang wrote: >> On 10/23/2013 06:36 PM, Mark Zhang wrote: >>> On 10/23/2013 05:09 PM, Thierry Reding wrote: >>>> On Wed, Oct 23, 2013 at 04:49:29PM +0800, Mark Zhang wrote

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-23 Thread Mark Zhang
On 10/23/2013 06:54 PM, Thierry Reding wrote: > On Wed, Oct 23, 2013 at 06:31:30PM +0800, Mark Zhang wrote: >> On 10/23/2013 05:09 PM, Thierry Reding wrote: >>> On Wed, Oct 23, 2013 at 04:49:29PM +0800, Mark Zhang wrote: >>>> On 10/23/2013 04:00 PM, Thierry Reding wro

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-23 Thread Mark Zhang
On 10/23/2013 06:36 PM, Mark Zhang wrote: > On 10/23/2013 05:09 PM, Thierry Reding wrote: >> On Wed, Oct 23, 2013 at 04:49:29PM +0800, Mark Zhang wrote: >>> On 10/23/2013 04:00 PM, Thierry Reding wrote: >>>> On Wed, Oct 23, 2013 at 10:16:24AM +0800, Mark Zhang wrote

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-23 Thread Mark Zhang
On 10/23/2013 05:09 PM, Thierry Reding wrote: > On Wed, Oct 23, 2013 at 04:49:29PM +0800, Mark Zhang wrote: >> On 10/23/2013 04:00 PM, Thierry Reding wrote: >>> On Wed, Oct 23, 2013 at 10:16:24AM +0800, Mark Zhang wrote: >>>> On 10/22/2013 08:49 PM, Thierry Reding wro

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-23 Thread Mark Zhang
On 10/23/2013 05:09 PM, Thierry Reding wrote: > On Wed, Oct 23, 2013 at 04:49:29PM +0800, Mark Zhang wrote: >> On 10/23/2013 04:00 PM, Thierry Reding wrote: >>> On Wed, Oct 23, 2013 at 10:16:24AM +0800, Mark Zhang wrote: >>>> On 10/22/2013 08:49 PM, Thierry Reding wro

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-23 Thread Mark Zhang
On 10/23/2013 04:00 PM, Thierry Reding wrote: > On Wed, Oct 23, 2013 at 10:16:24AM +0800, Mark Zhang wrote: >> On 10/22/2013 08:49 PM, Thierry Reding wrote: >>> On Tue, Oct 22, 2013 at 04:55:09PM +0800, Mark Zhang wrote: >>>> On 10/22/2013 03:24 PM, Thierry Reding wro

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-22 Thread Mark Zhang
On 10/22/2013 08:49 PM, Thierry Reding wrote: > On Tue, Oct 22, 2013 at 04:55:09PM +0800, Mark Zhang wrote: >> On 10/22/2013 03:24 PM, Thierry Reding wrote: >>> On Fri, Oct 18, 2013 at 12:48:12PM +0800, Mark Zhang wrote: >> [...] >>>>> >>>>

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-22 Thread Mark Zhang
On 10/22/2013 03:24 PM, Thierry Reding wrote: > On Fri, Oct 18, 2013 at 12:48:12PM +0800, Mark Zhang wrote: [...] >>> >> >> Okay, I just want to set the "notify" function pointer in "struct >> platform_pwm_backlight_data", because I want to tune

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-21 Thread Mark Zhang
Ping Thierry... Mark On 10/18/2013 12:48 PM, Mark Zhang wrote: > On 10/17/2013 03:14 PM, Thierry Reding wrote: >> On Thu, Oct 17, 2013 at 02:49:57PM +0800, Mark Zhang wrote: >>> Hi, >>> >>> This is the first time I send mail to linux-pwm, I didn't read

Re: How to set fops in "struct platform_pwm_backlight_data"?

2013-10-17 Thread Mark Zhang
On 10/17/2013 03:14 PM, Thierry Reding wrote: > On Thu, Oct 17, 2013 at 02:49:57PM +0800, Mark Zhang wrote: >> Hi, >> >> This is the first time I send mail to linux-pwm, I didn't read through >> the mails in this list, so if somebody already asked this question,

How to set fops in "struct platform_pwm_backlight_data"?

2013-10-16 Thread Mark Zhang
Hi, This is the first time I send mail to linux-pwm, I didn't read through the mails in this list, so if somebody already asked this question, I'm sorry about that. I wanna set some fops in "struct platform_pwm_backlight_data". But the currrent probe function in pwm_bl.c says: --- if (!data)

Re: [PATCH -next RESEND] gpu: host1x: drm: fix missing unlock on error

2013-04-23 Thread Mark Zhang
Alright. Please send this to linux-tegra ML and ping Thierry. Mark On 04/24/2013 11:07 AM, Wei Yongjun wrote: > On 04/24/2013 10:53 AM, Mark Zhang wrote: >> I think Thierry has acked this patch. So why? > > Yes, Thierry has acked this patch five months ago, but this patch does not

Re: [PATCH -next RESEND] gpu: host1x: drm: fix missing unlock on error

2013-04-23 Thread Mark Zhang
I think Thierry has acked this patch. So why? Mark On 04/24/2013 10:48 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Add the missing unlock before return from function host1x_drm_init() and > host1x_drm_exit() in the error handling case. > > Signed-off-by: Wei Yongjun > --- > rebased on the l

Re: [RFC 1/4] video: panel: add CLAA101WA01A panel support

2013-01-31 Thread Mark Zhang
On 02/01/2013 01:20 AM, Stephen Warren wrote: > On 01/30/2013 08:51 PM, Mark Zhang wrote: >> On 01/31/2013 04:19 AM, Stephen Warren wrote: >>> On 01/30/2013 12:20 AM, Mark Zhang wrote: >>>> On 01/30/2013 11:02 AM, Alexandre Courbot wrote: >>>>> Add

Re: [RFC 1/4] video: panel: add CLAA101WA01A panel support

2013-01-30 Thread Mark Zhang
On 01/31/2013 02:36 PM, Alexandre Courbot wrote: > On Thu, Jan 31, 2013 at 1:54 PM, Mark Zhang wrote: >> Display controller don't know whether the panel has EDID EEPROM but the >> panel driver knows. So why we need to make display controller queries >> EDID blindly? Sinc

Re: [RFC 1/4] video: panel: add CLAA101WA01A panel support

2013-01-30 Thread Mark Zhang
On 01/31/2013 12:24 PM, Alexandre Courbot wrote: > On Thu, Jan 31, 2013 at 12:51 PM, Mark Zhang wrote: >>> DDC access is a property of the display controller, not the panel >>> itself. The panel might be hooked up to a display controller's DDC/I2C >>> channel a

Re: [RFC 1/4] video: panel: add CLAA101WA01A panel support

2013-01-30 Thread Mark Zhang
On 01/31/2013 04:19 AM, Stephen Warren wrote: > On 01/30/2013 12:20 AM, Mark Zhang wrote: >> On 01/30/2013 11:02 AM, Alexandre Courbot wrote: >>> Add support for the Chunghwa CLAA101WA01A display panel. > >>> +static int panel_claa101_get_modes

Re: [RFC 1/4] video: panel: add CLAA101WA01A panel support

2013-01-30 Thread Mark Zhang
On 01/30/2013 03:48 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Wed, Jan 30, 2013 at 04:27:11PM +0900, Alex Courbot wrote: >> On 01/30/2013 04:20 PM, Mark Zhang wrote: > [...] >>>> +static int panel_claa101_get_modes

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Mark Zhang
On 01/30/2013 03:01 PM, Alex Courbot wrote: > On 01/30/2013 03:50 PM, Mark Zhang wrote: [...] > >>> +/* register display notifier */ >>> +output->display_notifier.dev = NULL; >> >> Set "display_notifier.dev" to NULL makes we have to compare

Re: [RFC 1/4] video: panel: add CLAA101WA01A panel support

2013-01-29 Thread Mark Zhang
On 01/30/2013 11:02 AM, Alexandre Courbot wrote: > Add support for the Chunghwa CLAA101WA01A display panel. > > Signed-off-by: Alexandre Courbot > --- [...] > + > +#include > + > +#define CLAA101WA01A_WIDTH 223 > +#define CLAA101WA01A_HEIGHT 125 If I remember correct, the physical size of th

Re: [RFC 3/4] drm: tegra: use the Common Display Framework

2013-01-29 Thread Mark Zhang
On 01/30/2013 11:02 AM, Alexandre Courbot wrote: > Make the tegra-drm driver use the Common Display Framework, letting it > control the panel state according to the DPMS status. > > A "nvidia,panel" property is added to the output node of the Tegra DC > that references the panel connected to a giv

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Mark Zhang
On 01/21/2013 04:52 PM, Marc Dietrich wrote: > Hi, > >>> diff --git a/drivers/video/backlight/pwm_bl_tegra.c >>> b/drivers/video/backlight/pwm_bl_tegra.c new file mode 100644 >>> index 000..8f2195b >>> --- /dev/null >>> +++ b/drivers/video/backlight/pwm_bl_tegra.c >> >> So according to the fil

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-21 Thread Mark Zhang
On 01/21/2013 04:24 PM, Alex Courbot wrote: > On Monday 21 January 2013 15:35:58 Mark Zhang wrote: >>> + backlight { >>> + compatible = "pwm-backlight-ventana"; >>> + brightness-levels = <0 16 32 48 64 80 96 112 128

Re: [PATCH 2/3] tegra: pwm-backlight: add tegra pwm-bl driver

2013-01-20 Thread Mark Zhang
On 01/19/2013 06:30 PM, Alexandre Courbot wrote: > Add a PWM-backlight subdriver for Tegra boards, with support for > Ventana. > > Signed-off-by: Alexandre Courbot > --- [...] > > + backlight { > + compatible = "pwm-backlight-ventana"; > + brightness-levels = <0 16 3

Re: [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support

2013-01-20 Thread Mark Zhang
Patch is applied OK on 3.8-rc4. Hmmm.. But I think it's better to make the patch can be applied on linux-next. Mark On 01/21/2013 10:09 AM, Mark Zhang wrote: > Hi Alex, > > This patch set applies failed on tot linux-next(0118). Here is the log: > > markz@markz-hp6200

Re: [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support

2013-01-20 Thread Mark Zhang
Hi Alex, This patch set applies failed on tot linux-next(0118). Here is the log: markz@markz-hp6200:~/tegradrm/official-upstream-kernel$ git am ~/Desktop/*.eml Applying: pwm-backlight: add subdriver mechanism error: patch failed: drivers/video/backlight/pwm_bl.c:35 error: drivers/video/backlight/

Re: [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support

2013-01-19 Thread Mark Zhang
On 01/20/2013 01:26 PM, Alexandre Courbot wrote: > On Sun, Jan 20, 2013 at 12:38 PM, Mark Zhang wrote: >> So this is a non power sequence version of backlight & panel enabling, >> isn't it? I remember we talked about this several days ago and you >> mentioned kern

Re: [PATCH 0/3] pwm-backlight: add subdrivers & Tegra support

2013-01-19 Thread Mark Zhang
Yeah, thanks Alex. :) So this is a non power sequence version of backlight & panel enabling, isn't it? I remember we talked about this several days ago and you mentioned kernel guys want an ad-hoc version(power sequence logics inside driver, not in DT) and I believe this is it, right? I think fin

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Mark Zhang
On 01/03/2013 01:50 PM, Terje Bergström wrote: > On 03.01.2013 05:31, Mark Zhang wrote: >> Sorry I didn't get it. Yes, in current design, you can pin all mem >> handles in one time but I haven't found anything related with "locking >> only once per submit&

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:42 PM, Terje Bergström wrote: > On 28.12.2012 11:14, Mark Zhang wrote: >> diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c >> index a936902..c3ded60 100644 >> --- a/drivers/gpu/drm/tegra/gr2d.c >> +++ b/drivers/gpu/drm/tegra/

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:25 PM, Terje Bergström wrote: > On 26.12.2012 11:42, Mark Zhang wrote: [...] > >> >> if (!de) >> diff --git a/drivers/gpu/host1x/dev.c b/drivers/gpu/host1x/dev.c >> index 07e8813..01ed10d 100644 >> --- a/drivers/gpu/host1x/dev

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-02 Thread Mark Zhang
On 01/02/2013 05:31 PM, Terje Bergström wrote: > On 02.01.2013 09:40, Mark Zhang wrote: >> On 12/21/2012 07:39 PM, Terje Bergstrom wrote: >>> Add support for host1x client modules, and host1x channels to submit >>> work to the clients. The work is submitted in GEM CMA

Re: [PATCHv4 3/8] gpu: host1x: Add channel support

2013-01-01 Thread Mark Zhang
Just one minor issue. Check below. On 12/21/2012 07:39 PM, Terje Bergstrom wrote: > Add support for host1x client modules, and host1x channels to submit > work to the clients. The work is submitted in GEM CMA buffers, so > this patch adds support for them. > > Signed-off-by: Terje Bergstrom > --

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-28 Thread Mark Zhang
Hi Terje, Here is the second part comments. I admit I still haven't finished reading the codes... really too many codes. :) Anyway I'll keep doing this when I have free slots. diff --git a/drivers/gpu/drm/tegra/gr2d.c b/drivers/gpu/drm/tegra/gr2d.c index a936902..c3ded60 100644 --- a/drivers/gpu/

Re: [PATCHv4 0/8] Support for Tegra 2D hardware

2012-12-26 Thread Mark Zhang
Hi Terje, I applied your patches on top of upstream 1224 kernel. Then I read the codes. So here is my review comments(I use "git diff" to print out, check below). I admit it's easy for me to not need to find the corresponding lines in your 8 patch mails, but I've no idea whether it is ok for you.

Re: [PATCH 0/9] ARM: Initial support for Tegra 114 SoC.

2012-12-24 Thread Mark Zhang
On 12/20/2012 05:43 PM, Hiroshi Doyu wrote: > Hi, > > This patchset adds initial support for the NVIDIA's new Tegra 114 > SoC (T114) based on the ARM Cortex-A15 MP. It has the minimal support > to allow the kernel to boot up into shell console. This can be used as > a basis for adding other device

Re: [RFC v2 1/8] video: tegra: Add nvhost driver

2012-12-03 Thread Mark Zhang
On 12/04/2012 05:03 AM, Thierry Reding wrote: [...] > > One other thing that such a design can help with is refactoring common > code or parameterizing code. Maybe newer generations are not compatible > but can easily be made to work with existing code by introducing a > variable such as register

Re: [RFC v2 1/8] video: tegra: Add nvhost driver

2012-12-03 Thread Mark Zhang
On 12/04/2012 05:03 AM, Thierry Reding wrote: [...] >> I think there's room for letting Terje's complete knowledge of future >> chips guide the design of the current code that's sent upstream. >> Certainly we shouldn't add a ton of unnecessary abstraction layers >> right now that aren't needed for

Re: [RFC v2 8/8] drm: tegra: Add gr2d device

2012-12-03 Thread Mark Zhang
On 12/03/2012 05:40 PM, Daniel Vetter wrote: > On Mon, Dec 3, 2012 at 10:30 AM, Mark Zhang wrote: >> I'm new in kernel development. Could you tell me or give me some >> materials to read that why we need to align the size of IOCTL structures >> to 64bit? I can unders

Re: [RFC v2 8/8] drm: tegra: Add gr2d device

2012-12-03 Thread Mark Zhang
Hi Dave: I'm new in kernel development. Could you tell me or give me some materials to read that why we need to align the size of IOCTL structures to 64bit? I can understand if we're working in a 64bit kernel but why we need to do this if we're in a 32bit arm kernel? Besides, why the pointers in I

Re: [PATCH] ARM: dt: tegra: cardhu: Add drm components

2012-12-02 Thread Mark Zhang
On 12/01/2012 03:28 AM, Stephen Warren wrote: > On 11/29/2012 10:44 PM, Mark Zhang wrote: >> This patch adds the RGB & HDMI nodes in Tegra 30 cardhu's dts. >> This makes the LVDS & HDMI working. > > This still doesn't add any of the backlight/panel GPIO pro

Re: [RFC,v2,3/8] video: tegra: host: Add channel and client support

2012-11-29 Thread Mark Zhang
On 11/29/2012 06:46 PM, Terje Bergström wrote: > On 29.11.2012 12:01, Mark Zhang wrote: >> >> Just for curious, why "pb->mapped + 1K" is the end of a 4K pushbuffer? > > pb->mapped is u32 *, so compiler will take care of multiplying by > sizeof(u32). >

[PATCH] ARM: dt: tegra: cardhu: Add drm components

2012-11-29 Thread Mark Zhang
This patch adds the RGB & HDMI nodes in Tegra 30 cardhu's dts. This makes the LVDS & HDMI working. Signed-off-by: Mark Zhang --- Changes: - This patch depcrates the patch: "[PATCH V2] ARM: dt: tegra: cardhu: Add drm components" Because the issue that LCD and HDMI can&

Re: [PATCH 1/1] ARM: tegra: bus_notifier registers IOMMU devices(was: How to specify IOMMU'able devices in DT)

2012-11-29 Thread Mark Zhang
On 11/28/2012 09:48 PM, Hiroshi Doyu wrote: > Hiroshi Doyu wrote @ Mon, 24 Sep 2012 14:50:14 +0300 > (EEST): > ... > On Mon, 2012-09-24 at 12:04 +0300, Hiroshi Doyu wrote: >> diff --git a/drivers/base/platform.c b/drivers/base/platform.c >> index a1a7225..9eae3be 100644 >> --- a/d

Re: [RFC,v2,3/8] video: tegra: host: Add channel and client support

2012-11-29 Thread Mark Zhang
On 11/26/2012 09:19 PM, Terje Bergström wrote: > Add support for host1x client modules, and host1x channels to submit > work to the clients. The work is submitted in dmabuf buffers, so add > support for dmabuf memory management, too. [...] > diff --git a/drivers/video/tegra/host/bus_client.c > b/

Re: [RFC,v2,1/8] video: tegra: Add nvhost driver

2012-11-29 Thread Mark Zhang
On 11/26/2012 09:19 PM, Terje Bergström wrote: > Add nvhost, the driver for host1x. This patch adds support for reading and > incrementing sync points and dynamic power management. > > Signed-off-by: Terje Bergstrom > > --- > drivers/video/Kconfig |2 + > driver

Re: [RFC,v2,8/8] drm: tegra: Add gr2d device

2012-11-28 Thread Mark Zhang
On 11/26/2012 09:19 PM, Terje Bergström wrote: > Add client driver for 2D device. > > Signed-off-by: Arto Merilainen > Signed-off-by: Terje Bergstrom > > --- > [...] > + > +static int > +tegra_drm_ioctl_open_channel(struct drm_device *drm, void *data, > + struct drm_file

Re: [PATCH V2] ARM: dt: tegra: cardhu: Add drm components

2012-11-26 Thread Mark Zhang
On 11/27/2012 07:17 AM, Stephen Warren wrote: > On 11/20/2012 12:27 AM, Mark Zhang wrote: >> This patch adds the rgb node which is needed by >> tegra drm driver. > > This doesn't seem to include all the GPIOs/regulators/... required to > enable the panel and backlig

Re: [PATCH V2] drm: Add NVIDIA Tegra30 support

2012-11-19 Thread Mark Zhang
All right. I guess you might already have this, just sent this to make things clear. On 11/20/2012 03:37 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Tue, Nov 20, 2012 at 03:26:16PM +0800, Mark Zhang wrote: >> This patch is based on Thierry's d

Re: [PATCH V2] drm: Add NVIDIA Tegra30 support

2012-11-19 Thread Mark Zhang
Stephen & Thierry, I downloaded all patches from patchwork so right now it should not have space issues. Mark On 11/20/2012 03:26 PM, Mark Zhang wrote: > This patch is based on Thierry's drm patch for Tegra20: > - [PATCH v2 0/6] Device tree updates for host1x support > - [PA

[PATCH V2] ARM: dt: tegra: cardhu: Add drm components

2012-11-19 Thread Mark Zhang
This patch adds the rgb node which is needed by tegra drm driver. Signed-off-by: Mark Zhang --- Changes in V2: - Remove HDMI node in dts. Currently tegra drm driver doesn't work while RGB and HDMI are enabled simultaneously arch/arm/boot/dts/tegra30-cardhu.dtsi | 11 ++- 1

[PATCH V2] drm: Add NVIDIA Tegra30 support

2012-11-19 Thread Mark Zhang
This patch is based on Thierry's drm patch for Tegra20: - [PATCH v2 0/6] Device tree updates for host1x support - [PATCH v3 0/2] NVIDIA Tegra DRM driver It adds the support for NVIDIA Tegra30. Signed-off-by: Mark Zhang --- drivers/gpu/drm/tegra/dc.c |1 + drivers/gpu/drm/tegra/hos

Re: [PATCH] drm: Add NVIDIA Tegra30 support

2012-11-18 Thread Mark Zhang
On 11/19/2012 02:45 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Mon, Nov 19, 2012 at 02:18:51PM +0800, Mark Zhang wrote: >> On 11/17/2012 12:29 AM, Stephen Warren wrote: >>> On 11/15/2012 09:58 PM, Mark Zhang wrote: >>>> This patch is base

Re: [PATCH] drm: Add NVIDIA Tegra30 support

2012-11-18 Thread Mark Zhang
On 11/17/2012 12:29 AM, Stephen Warren wrote: > On 11/15/2012 09:58 PM, Mark Zhang wrote: >> This patch is based on Thierry's drm patch for Tegra20: >> - [PATCH v2 0/6] Device tree updates for host1x support >> - [PATCH v3 0/2] NVIDIA Tegra DRM driver >> >>

Re: [PATCH] drm: Add NVIDIA Tegra30 support

2012-11-15 Thread Mark Zhang
On 11/16/2012 03:11 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Nov 16, 2012 at 02:48:55PM +0800, Mark Zhang wrote: >> On 11/16/2012 02:43 PM, Thierry Reding wrote: >>>> Old Signed by an unknown key >>> >>> On Fri, Nov 1

Re: [PATCH] drm: Add NVIDIA Tegra30 support

2012-11-15 Thread Mark Zhang
On 11/16/2012 02:43 PM, Thierry Reding wrote: > * PGP Signed by an unknown key > > On Fri, Nov 16, 2012 at 12:58:09PM +0800, Mark Zhang wrote: >> This patch is based on Thierry's drm patch for Tegra20: >> - [PATCH v2 0/6] Device tree updates for host1x support >> -

[PATCH] ARM: dt: tegra: cardhu: Add drm components

2012-11-15 Thread Mark Zhang
This patch adds the rgb and hdmi nodes which are necessary for tegra drm driver. Signed-off-by: Mark Zhang --- arch/arm/boot/dts/tegra30-cardhu.dtsi | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/tegra30-cardhu.dtsi b/arch/arm

[PATCH] drm: Add NVIDIA Tegra30 support

2012-11-15 Thread Mark Zhang
This patch is based on Thierry's drm patch for Tegra20: - [PATCH v2 0/6] Device tree updates for host1x support - [PATCH v3 0/2] NVIDIA Tegra DRM driver It adds the support for NVIDIA Tegra30. Signed-off-by: Mark Zhang --- drivers/gpu/drm/tegra/dc.c |1 + drivers/gpu/drm/tegra/hos

Re: [PATCH v3 0/2] NVIDIA Tegra DRM driver

2012-11-15 Thread Mark Zhang
Thierry, By the way, when do you plan to send drm patches for Tegra 3? I'm wondering if you don't have a Tegra 3 board for testing, I can do that for you. Mark On 11/16/2012 05:28 AM, Thierry Reding wrote: > This third version of the patch series cleans up some minor issues that > were found in t

Re: [PATCH v3 0/2] NVIDIA Tegra DRM driver

2012-11-15 Thread Mark Zhang
Hi Thierry, Thank you for your hard work. The series, Acked-by: Mark Zhang Reviewed-by: Mark Zhang Tested-by: Mark Zhang On Ventana, LVDS and HDMI worked. PS: Alex's power sequence patch is needed to enable panel and backlight. Also we need to define dc and hdmi nodes in te

Re: [PATCH v2 0/6] Device tree updates for host1x support

2012-11-15 Thread Mark Zhang
Hi Thierry, Thank you for your hard work. The series, Acked-by: Mark Zhang Reviewed-by: Mark Zhang Tested-by: Mark Zhang On Ventana, LVDS and HDMI worked. PS: Alex's power sequence patch is needed to enable panel and backlight. Also we need to define dc and hdmi nodes in te

Re: [PATCH v2 1/2] drm: Add NVIDIA Tegra20 support

2012-11-13 Thread Mark Zhang
On 11/14/2012 01:37 AM, Stephen Warren wrote: > On 11/13/2012 12:15 AM, Mark Zhang wrote: >> On 11/13/2012 05:55 AM, Thierry Reding wrote: >>> This commit adds a KMS driver for the Tegra20 SoC. This includes basic >>> support for host1x and the two display controllers f

  1   2   >