Re: [PATCH RESEND] arm64: dts: qcom: Add support for OnePlus 5/5T

2021-04-02 Thread Martin Botka
<51400>; + vdda-pll-max-microamp = <14600>; + vddp-ref-clk-max-microamp = <100>; + vddp-ref-clk-always-on; +}; + + { + status = "okay"; + + /* Disable USB3 clock requirement as the device only supports USB2 */ + qcom,select-utmi-as-pipe-clk; +}; + +_dwc3 { + /* Drop the unused USB 3 PHY */ + phys = <>; + phy-names = "usb2-phy"; + + /* Fastest mode for USB 2 */ + maximum-speed = "high-speed"; + + /* Force to peripheral until we can switch modes */ + dr_mode = "peripheral"; +}; + +/* Hold off on WLAN enablement until MSS remoteproc and friends are brought up */ + { + vdd-0.8-cx-mx-supply = <_l5a_0p8>; + vdd-1.8-xo-supply = <_l7a_1p8>; + vdd-1.3-rfa-supply = <_l17a_1p3>; + vdd-3.3-ch0-supply = <_l25a_3p3>; +}; diff --git a/arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dts b/arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dts new file mode 100644 index ..b46214a32478 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/msm8998-oneplus-dumpling.dts @@ -0,0 +1,25 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * OnePlus 5T (dumpling) device tree + * + * Copyright (c) 2021, Jami Kettunen + */ + +#include "msm8998-oneplus-common.dtsi" + +/ { + model = "OnePlus 5T"; + compatible = "oneplus,dumpling", "qcom,msm8998"; + /* Required for bootloader to select correct board */ + qcom,board-id = <8 0 17801 43>; +}; + +/* Update the screen height values from 1920 to 2160 on the 5T */ + { + height = <2160>; +}; + +/* Adjust digitizer area height to match the 5T's taller panel */ +_f12 { + touchscreen-y-mm = <137>; +}; -- 2.30.1 Only thing i would nit pick about it is to split it into 2 commits maybe. Other than that nothing. Reviewed-by: Martin Botka

Re: [PATCH 34/41] arm64: dts: qcom: sdm630-nile: Configure WCN3990 Bluetooth

2021-02-27 Thread Martin Botka
Signed-off-by: Martin Botka Sorry for the second Sob. Previous one was HTML. Sorry On Sat, Feb 27, 2021 at 11:40, Konrad Dybcio wrote: From: AngeloGioacchino Del Regno From: Martin Botka That got caught in rebasing madness.. Should any additional mistakes appear, I'll send a V2

Re: [PATCH v5 2/4] leds: Add driver for Qualcomm LPG

2020-10-26 Thread Martin Botka
Hi! > I was trying to use obviously bogus numbers to make you to specify > which patches you reviewed :-). A now that makes much more sense. I reviewed patch 2. Tho from the quick look i dont see anything wrong with the DTS changes either.

Re: [PATCH v5 2/4] leds: Add driver for Qualcomm LPG

2020-10-26 Thread Martin Botka
> Good way to say that is "Patches 7 and 28, Reviewed-by:"... 7 and 28 ? I dont see any patches 7 and 28 (I assume thats a typo for 8) Either way. Reviewed-by: Martin Botka

Re: [PATCH v4 1/2] dt-bindings: interconnect: Add bindings for Qualcomm SDM660 NoC

2020-10-19 Thread Martin Botka
> Documentation/devicetree/bindings/interconnect/qcom,sdm660.example.dts:20:18: > fatal error: dt-bindings/clock/qcom,mmcc-sdm660.h: No such file or directory >20 | #include > | ^~ This patch depends on my MMCC patch (sent

Re: [PATCH v5 2/4] leds: Add driver for Qualcomm LPG

2020-10-17 Thread Martin Botka
With the changes done to in V5 i have nothing to add.

Re: [PATCH 1/5] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver

2020-10-13 Thread Martin Botka
Actually, correction. This parent is used by cpp_clk_src.

Re: [PATCH 1/5] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver

2020-10-13 Thread Martin Botka
Yes, The unused parent map should be removed and resent.

Re: [PATCH 3/7] drm/msm/a5xx: Add support for Adreno 508, 509, 512 GPUs

2020-09-26 Thread Martin Botka
Tested on Xperia 10 Tested-by: Martin Botka

Re: [PATCH 5/5] dt-bindings: clock: Add QCOM SDM630 and SDM660 graphics clock bindings

2020-09-26 Thread Martin Botka
Tested on Xperia 10 Tested-by: Martin Botka

Re: [PATCH 4/5] clk: qcom: Add SDM660 GPU Clock Controller (GPUCC) driver

2020-09-26 Thread Martin Botka
Tested on Xperia 10 Tested-by: Martin Botka

Re: [PATCH] phy: qcom-qusb2: Add support for SDM630/660

2020-09-26 Thread Martin Botka
Tested on Xperia 10 Tested-by: Martin Botka

Re: [PATCH 1/5] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver

2020-09-26 Thread Martin Botka
Tested-by: Martin Botka

Re: [PATCH RFC 3/6] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG module

2020-07-27 Thread Martin Botka
Hello, Mo 27. 7. 2020 at 22:10 Uwe Kleine-König wrote: > > On Fri, Jul 24, 2020 at 11:36:53PM +0200, Martin Botka wrote: > > From: Fenglin Wu > > > > Add pwm_chip to support QTI LPG module and export LPG channels as > > PWM devices for consumer drivers' usage. >

Re: [PATCH RCC 1/6] pwm: Add different PWM output types support

2020-07-27 Thread Martin Botka
Mo 27. 7. 2020 at 22:10 Uwe Kleine-König wrote: > > Hello, > > On Fri, Jul 24, 2020 at 11:36:51PM +0200, Martin Botka wrote: > > From: Fenglin Wu > > > > Normally, PWM channel has fixed output until software request to change > > "fixed" in

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Martin Botka
Hello, > I hit "reply-to-all" and the mail only was sent to you because you wrote > to only me. Yes my reply was only to you. But your original message was sent only to me too. So when i clicked reply to all it was only you as you sent it only to me. > Also threading is somehow strange because

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Martin Botka
> Could you please send the messages also to everyone else ? Next time of course.

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-27 Thread Martin Botka
Hello Uwe, On Sat, Jul 25, 2020 at 09:12:23PM +0200, Martin Botka wrote: >> > Note there is already a series that changes these values to u64. See >> > a9d887dc1c60ed67f2271d66560cdcf864c4a578 in linux-next. >> >> Amazing. But isn't there the same issue with it a

Re: [PATCH RFC 4/6] leds: leds-qti-tri-led: Add LED driver for QTI TRI_LED module

2020-07-26 Thread Martin Botka
Hello. This driver has the breath feature of the driver broken as I sent a slightly modified version of it from when I was testing it. The proper version will come when i will be sending out V2 which will be hopefully soon as I'm little busy. Best regards Martin

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-26 Thread Martin Botka
> And all divisions go mad on 32-bit CPU, right? > Please, if you thought about it carefully, update a commit message to > clarify that. Hello, This patch will be dropped in V2 since another series already made these u64. See a9d887dc1c60ed67f2271d66560cdcf864c4a578 in linux-next. I have not

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Martin Botka
> +#include > - gain_q23 = (gain_q23 * dmic->boost_gain) / 100; > + gain_q23 = div_u64(gain_q23 * dmic->boost_gain, 100); Ok so using a macro. Thank you.

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Martin Botka
Hello, As can be seen this divides llu by llu in few warnings and error. At the time of sending i didn't realize it but this fails on 32 bit architectures. So i would like to ask how would you like this fixed ? Using macro or some other way ? Thank you. Best regards, Martin

Re: [PATCH RFC 0/6] Add QCOM pwm-lpg and tri-led drivers

2020-07-24 Thread Martin Botka
> First copy was ok. Second had broken formatting. Both were plaintext > AFAICT. It's just that gmail was telling me that it didn't send it to some of the email addresses because i forgot to check the "Use plain text" in Gmail.

Re: [PATCH RFC 0/6] Add QCOM pwm-lpg and tri-led drivers

2020-07-24 Thread Martin Botka
> Vitej do klubu :-). Dakujem > Please double check. Actually, is the series for one chip or for two > of them? LED framework should is happy to talk to generic pwm driver... I'm not sure on that one. I will have to talk to some people about that. I will get back to you on that when i find out

Re: [PATCH RFC 0/6] Add QCOM pwm-lpg and tri-led drivers

2020-07-24 Thread Martin Botka
Hi, Dalsi cech co hackuje LEDky? Nie. Slovak. Bindings should go first, they may need to be converted to yml (devicetree people will know). OK Can generic pwm driver be used here? I have not tried to do that. But considering it's custom chip from Qualcomm then it's unlikely. This is for RGB

[PATCH RFC 6/6] Documentation: Add binding for pwm-qti-lpg

2020-07-24 Thread Martin Botka
From: Fenglin Wu Add documentation for pwm-qti-lpg Signed-off-by: Fenglin Wu Signed-off-by: Martin Botka --- .../devicetree/bindings/pwm/pwm-qti-lpg.txt | 163 ++ 1 file changed, 163 insertions(+) create mode 100644 Documentation/devicetree/bindings/pwm/pwm-qti-lpg.txt

[PATCH RFC 0/6] Add QCOM pwm-lpg and tri-led drivers

2020-07-24 Thread Martin Botka
Hello, This series brings QCOM pwm-lpg and tri-led drivers from 4.14 that is required to support pmic-connected notification LED. This comes straight from downstream and I'm ready for your comments. Fenglin Wu (6): pwm: Add different PWM output types support pwm: core: Add option to config

[PATCH RFC 4/6] leds: leds-qti-tri-led: Add LED driver for QTI TRI_LED module

2020-07-24 Thread Martin Botka
-by: Martin Botka --- drivers/leds/Kconfig| 9 + drivers/leds/Makefile | 1 + drivers/leds/leds-qti-tri-led.c | 640 3 files changed, 650 insertions(+) create mode 100644 drivers/leds/leds-qti-tri-led.c diff --git a/drivers/leds/Kconfig

[PATCH RFC 3/6] pwm: pwm-qti-lpg: Add PWM driver for QTI LPG module

2020-07-24 Thread Martin Botka
From: Fenglin Wu Add pwm_chip to support QTI LPG module and export LPG channels as PWM devices for consumer drivers' usage. Signed-off-by: Fenglin Wu [martin.bot...@gmail.com: Fast-forward the driver from kernel 4.14 to 5.8] Signed-off-by: Martin Botka --- drivers/pwm/Kconfig | 10

[PATCH RFC 5/6] Documentation: Add binding for qti-tri-led

2020-07-24 Thread Martin Botka
From: Fenglin Wu Add documentation for qti-tri-led Signed-off-by: Fenglin Wu Signed-off-by: Martin Botka --- .../bindings/leds/leds-qti-tri-led.txt| 72 +++ 1 file changed, 72 insertions(+) create mode 100644 Documentation/devicetree/bindings/leds/leds-qti-tri

[PATCH RCC 1/6] pwm: Add different PWM output types support

2020-07-24 Thread Martin Botka
different PWM types and add relevant helper functions to set and get PWM output types and pattern. Signed-off-by: Fenglin Wu [konradyb...@gmail.com: Fast-forward from kernel 4.14 to 5.8] Signed-off-by: Konrad Dybcio Signed-off-by: Martin Botka --- drivers/pwm/core.c | 26 + drivers

[PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-24 Thread Martin Botka
. Signed-off-by: Fenglin Wu [konradyb...@gmail.com: Fast-forward from kernel 4.14 to 5.8] Signed-off-by: Konrad Dybcio Signed-off-by: Martin Botka --- drivers/pwm/core.c | 30 +++-- drivers/pwm/sysfs.c | 6 ++-- include/linux/pwm.h | 79

Re: [PATCH 8/8] arm64: dts: qcom: Add support for Sony Xperia 10/10 Plus (Ganges platform)

2020-06-21 Thread Martin Botka
Sorry made a typo in mail. Tested-by: Martin Botka

Re: [PATCH 8/8] arm64: dts: qcom: Add support for Sony Xperia 10/10 Plus (Ganges platform)

2020-06-21 Thread Martin Botka
Tested-by: Martin Botka ne 21. 6. 2020 o 23:38 Konrad Dybcio napísal(a): > > From: Martin Botka > > Add device tree support for the Sony Xperia 10 and 10 > Plus smartphones. They are all based on the Sony Ganges > platform (sdm630/636) and share a lot of common code.