Hi Nava,
On minor comment below.
On 02/04/2021 11.09, Nava kishore Manne wrote:
Some systems are memory constrained but they need to load very
large Configuration files. The FPGA subsystem allows drivers to
request this Configuration image be loaded from the filesystem,
but this requires that t
Update pci_ids.h with the vendor ID for Silicom Denmark. The define is
going to be referenced in driver(s) for FPGA accelerated smart NICs.
Signed-off-by: Martin Hundebøll
---
Changes since v1:
* Align commit message/shortlog with similar changes to pci_ids.h
include/linux/pci_ids.h | 2
Update pci_ids.h with the vendor id for Silicom Denmark.
Signed-off-by: Martin Hundebøll
---
include/linux/pci_ids.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index d8156a5dbee8..aae07d512ca6 100644
--- a/include/linux/pci_ids.h
Hi Russ,
On 02/12/2020 00.30, Russ Weight wrote:
On 12/1/20 12:47 AM, Martin Hundebøll wrote:
Hi Russ,
On 01/12/2020 00.54, Russ Weight wrote:
Thanks Martin. I'll work on a fix for this.
Attached is my in-house fix.
// Martin
On 11/26/20 6:02 AM, Martin Hundebøll wrote:
Hi Rus
Hi Russ,
On 01/12/2020 00.54, Russ Weight wrote:
Thanks Martin. I'll work on a fix for this.
Attached is my in-house fix.
// Martin
On 11/26/20 6:02 AM, Martin Hundebøll wrote:
Hi Russ,
I found another thing while testing this...
On 06/11/2020 02.09, Russ Weight wrote:
+s
Hi Russ,
I found another thing while testing this...
On 06/11/2020 02.09, Russ Weight wrote:
+static ssize_t filename_store(struct device *dev, struct device_attribute
*attr,
+ const char *buf, size_t count)
+{
+ struct fpga_sec_mgr *smgr = to_sec_mgr(dev);
Hi Russ,
Just stumbled upon the below when preparing to upstream some Silicom changes
On 06/11/2020 02.09, Russ Weight wrote:
diff --git a/include/linux/fpga/fpga-sec-mgr.h
b/include/linux/fpga/fpga-sec-mgr.h
index f85665b79b9d..e03de72134d6 100644
--- a/include/linux/fpga/fpga-sec-mgr.h
++
On 19/09/2019 15.27, Martin Hundebøll wrote:
But we haven't been able to reproduce locally.
Scratch that. It's reliably reproduced by sending/saturating the uart
with outgoing data.
// Martin
Hi,
We've come across the below lockdep report when using n_gsm multiplexing
on an imx uart.
The inverted lock scenario caused by:
1) the uart tx-ready interrupt causing the tty layer to call down
into n_gsm, and
2) n_gsm transmitting data, causing it to call up into the tty layer
We ha
On 04/09/2019 10.18, Jiri Slaby wrote:
On 29. 08. 19, 21:42, Martin Hundebøll wrote:
On 22/08/2019 23.56, Martin Hundebøll wrote:
When tearing down the n_gsm ldisc while one or more of its child ports
are open, a lock dep warning occurs:
[ 56.254258
On 22/08/2019 23.56, Martin Hundebøll wrote:
When tearing down the n_gsm ldisc while one or more of its child ports
are open, a lock dep warning occurs:
[ 56.254258] ==
[ 56.260447] WARNING: possible circular locking dependency detected
.454365]__fput+0x94/0x1e8
Avoid the warning by doing the port hangup asynchronously.
Signed-off-by: Martin Hundebøll
---
drivers/tty/n_gsm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c
index d30525946892..36a3eb4ad4c5 100644
Hi Greg,
Just a friendly "ping" on this patch.
Thanks,
Martin
On 12/08/2019 23.12, Martin Hundebøll wrote:
Guessing the first tty for a gsm0710 multiplexed serial device is not
currently possible, which makes it racy to use with multiple modems.
Add a way to map the physical ser
On 12/08/2019 22.59, Martin Hundebøll wrote:
On 25/07/2019 13.26, Greg Kroah-Hartman wrote:
On Wed, Jul 17, 2019 at 11:40:02AM +0200, Martin Hundebøll wrote:
Hi,
The GSM0710 line discipline driver triggers a lockdep warning when
disabling
the ldisc while holding a multiplexed virtual
Guessing the first tty for a gsm0710 multiplexed serial device is not
currently possible, which makes it racy to use with multiple modems.
Add a way to map the physical serial tty to its related mux devices
using an ioctl.
Signed-off-by: Martin Hundebøll
---
Changes since v3:
* use __u32
On 25/07/2019 13.26, Greg Kroah-Hartman wrote:
On Wed, Jul 17, 2019 at 11:40:02AM +0200, Martin Hundebøll wrote:
Hi,
The GSM0710 line discipline driver triggers a lockdep warning when disabling
the ldisc while holding a multiplexed virtual tty open
ected
[ 74.528094] 5.2.0-00114-gdab52e30156b #6 Not tainted
[ 74.533065]
<...>
This has supposedly been fixed before in 4d9b109060f6 ("tty: Prevent
deadlock in n_gsm driver"), but the fix was undone in be7065725590
("TTY/n_gsm: Remo
Guessing the first tty for a gsm0710 multiplexed serial device is not
currently possible, which makes it racy to use with multiple modems.
Add a way to map the physical serial tty to its related mux devices
using an ioctl.
Signed-off-by: Martin Hundebøll
---
Changes since v2:
* rename IOCTL
The n_gsm driver handles registration of /dev/gsmttyX nodes, so there's
no need to do mknod manually.
Signed-off-by: Martin Hundebøll
---
Documentation/serial/n_gsm.rst | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/Documentation/serial/n_gsm.
There is no reason to gues the line discipline number when it is
available from tty.h
Signed-off-by: Martin Hundebøll
---
Documentation/serial/n_gsm.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/serial/n_gsm.rst b/Documentation/serial/n_gsm.rst
index
Make it obvious how the gsm mux number relates to the virtual tty lines
by using helper functions instead of shifting 6 bits.
Signed-off-by: Martin Hundebøll
---
Changes since v2:
* use unsigned integers in both helper functions
drivers/tty/n_gsm.c | 19 +++
1 file changed
On 09/07/2019 17.22, Alan Cox wrote:
+ int base;
/* open the serial port connected to the modem */
fd = open(SERIAL_PORT, O_RDWR | O_NOCTTY | O_NDELAY);
@@ -58,6 +61,11 @@ Major parts of the initialization program :
c.mtu = 127;
/* set the new configuration */
On 09/07/2019 08.49, Jiri Slaby wrote:
On 09. 07. 19, 8:46, Martin Hundebøll wrote:
@@ -2623,6 +2624,9 @@ static int gsmld_ioctl(struct tty_struct *tty, struct
file *file,
if (copy_from_user(&c, (void *)arg, sizeof(c)))
return -EF
Make it obvious how the gsm mux number relates to the virtual tty lines
by using helper function instead of shifting 6 bits.
Signed-off-by: Martin Hundebøll
---
drivers/tty/n_gsm.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b
There is no reason to gues the line discipline number when it is
available from tty.h
Signed-off-by: Martin Hundebøll
---
Documentation/serial/n_gsm.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/serial/n_gsm.rst b/Documentation/serial/n_gsm.rst
index
The n_gsm driver handles registration of /dev/gsmttyX nodes, so there's
no need to do mknod manually.
Signed-off-by: Martin Hundebøll
---
Changes since v1:
* updated bullet numbering
Documentation/serial/n_gsm.rst | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
Guessing the base tty for a gsm0710 multiplexed serial device is not
currently possible, which makes it racy to use with multiple modems.
Add a way to map the physical serial tty to its related mux devices
using a ioctl.
Signed-off-by: Martin Hundebøll
---
Changes since v1:
* use put_user
Make it obvious how the gsm mux number relates to the virtual tty lines
by using helper function instead of shifting 6 bits.
Signed-off-by: Martin Hundebøll
---
drivers/tty/n_gsm.c | 16 +---
1 file changed, 13 insertions(+), 3 deletions(-)
diff --git a/drivers/tty/n_gsm.c b
There is no reason to gues the line discipline number when it is
available from tty.h
Signed-off-by: Martin Hundebøll
---
Documentation/serial/n_gsm.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/serial/n_gsm.rst b/Documentation/serial/n_gsm.rst
index
Guessing the base tty for a gsm0710 multiplexed serial device is not
currently possible, which makes it racy to use with multiple modems.
Add a way to map the physical serial tty to its related mux devices
using a ioctl.
Signed-off-by: Martin Hundebøll
---
Documentation/serial/n_gsm.rst | 8
The n_gsm driver handles registration of /dev/gsmttyX nodes, so there's
no need to do mknod manually.
Signed-off-by: Martin Hundebøll
---
Documentation/serial/n_gsm.rst | 10 --
1 file changed, 10 deletions(-)
diff --git a/Documentation/serial/n_gsm.rst b/Documentation/serial/n_gs
On 2018-06-20 09:34, Esben Haabendal wrote:
From: Esben Haabendal
The if statement just above this if/else statement triggers on the same
condition, and then invalidates it.
Signed-off-by: Esben Haabendal
Cc: Martin Hundebøll
For the entire series:
Acked-by: Martin Hundebøll
Hi,
Yeah, you can add my
Acked-by: Martin Hundebøll
Thanks,
Martin
On February 2, 2018 8:00:27 AM GMT+01:00, Jean Delvare wrote:
>Hi Martin,
>
>On Thu, 1 Feb 2018 09:08:05 +0100, Martin Hundebøll wrote:
>> dmi_init() rightfully checks if dmi is available at all, and errors
mping to the err-label.
Signed-off-by: Martin Hundebøll
---
drivers/firmware/dmi_scan.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
index 783041964439..86c5e0625a08 100644
--- a/drivers/firmware/dmi_scan.c
34 matches
Mail list logo
