Masahiro,
> When CONFIG_UAPI_HEADER_TEST=y, exported headers are compile-tested to
> make sure they can be included from user-space.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Replace pci_read_config_word() and pci_write_config_word() calls with
> pcie_capability_read_word() and pcie_capability_write_word().
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Replace pci_read_config_word() and pci_write_config_word() calls with
> pcie_capability_read_word() and pcie_capability_write_word().
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Variable retv is initialized to a value that is never read and it is
> re-assigned later. The initialization is redundant and can be removed.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christophe,
> This should be 'pmcraid', not 'pcmraid'
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Mark switch cases where we are expecting to fall through.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
tmf
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
the rest are tidy-up patches
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
equence whereas .hce_enable_notify will be called everytime
> controller is reenabled.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tomas,
> Define new a type: uc_string_id for easier string handling and less
> casting. Reduce number or string copies in price of a dynamic
> allocation.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
llthrough=]
>case 2: ++x;
>^~~
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings:
>
> drivers/scsi/sun3_scsi.c: warning: this statement may fall through
> [-Wimplicit-fallthrough=]: => 399:9, 403:9
Applied to 5.4/scsi-queue, thanks!
-
Gustavo,
> Mark switch cases where we are expecting to fall through.
>
> This patch fixes the following warnings (Building: sparc defconfig):
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Mark switch cases where we are expecting to fall through.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
lied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fix sparse warnings:
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Mark switch cases where we are expecting to fall through.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo A.,
> Mark switch cases where we are expecting to fall through.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Jia-Ju,
> In qla2x00_alloc_fcport(), fcport is assigned to NULL in the error
> handling code on line 4880:
> fcport = NULL;
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Chuhong,
> Use vzalloc instead of using vmalloc to allocate memory and then
> zeroing it with memset. This simplifies the code.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> kmem_cache_destroy() can handle NULL pointer correctly, so there is
> no need to check NULL pointer before calling kmem_cache_destroy().
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> A null check before dma_pool_destroy is redundant,
> so remove it. This is detected by coccinelle.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> While removing an ibmvfc client adapter a WARN_ON like the following
> WARN_ON is seen in the kernel log:
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Fix spelling mistake in kernel warning message and replace printk with
> with pr_warn.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Christophe,
> #define relative to FCOE CTLR start with FCOE_CTLR, except
> FCOE_CTRL_SOL_TOV.
>
> This is likely a typo and CTRL should be CTLR here as well.
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fix sparse warnings:
>
> drivers/scsi/megaraid/megaraid_sas_fusion.c:541:1: warning: symbol
> 'megasas_alloc_cmdlist_fusion' was not declared. Should it be static?
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Junxiao,
> While loading fw crashdump in function fw_crash_buffer_show(), left
> bytes in one dma chunk was not checked, if copying size over it,
> overflow access will cause kernel panic.
Applied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
plied to 5.3/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
orthogonal to
the SCSI changes.
I do think it's important that we get these fixed up in 5.3. And given
that we're on the eve of the merge window, the time to get these changes
merged is now. I'd hate to see them miss another release...
--
Martin K. Petersen Oracle Linux Engineering
Waiman,
> Is someone going to merge this patch in the current cycle?
I was hoping somebody would step up and patch all the bad accesses and
not just page 10.
--
Martin K. Petersen Oracle Linux Engineering
pt3sas was acked, I assume it's the
same thing.
I'm not so keen on how big the last batch of patches for the merge
window is getting. But I queued your fixes up for 5.3.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> A null check before a kfree is redundant, so remove it.
> This is detected by coccinelle.
Applied to 5.4/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bean,
> This patch is to change msleep() to usleep_range() based on
> Documentation/timers/timers-howto.txt. It suggests using
> usleep_range() for small msec(1ms - 20ms) since msleep() will often
> sleep longer than desired value.
Applied to 5.4/scsi-queue, thanks!
--
Martin
Colin,
> Currently if lport is null then the null lport pointer is dereference
> when printing out debug via the FC_LPORT_DB macro. Fix this by using
> the more generic FC_LIBFC_DBG debug macro instead that does not use
> lport.
Applied to 5.3/scsi-fixes, thanks!
--
Martin
Christoph,
> Ping? What happened to this set of bug fixes?
I thought they depended on Jens' tree?
--
Martin K. Petersen Oracle Linux Engineering
Hannes,
Please review!
> Currently if lport is null then the null lport pointer is dereference
> when printing out debug via the FC_LPORT_DB macro. Fix this by using
> the more generic FC_LIBFC_DBG debug macro instead that does not use
> lport.
--
Martin K. Petersen
Paolo,
> Stefan answered, and the series now has three reviews! It may be late
> for 5.3 but I hope this can go in soon.
I queued these up for 5.4. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
edhat.com/show_bug.cgi?id=1724077
> https://jira.sw.ru/browse/PSBM-95736
These two links don't appear to be publicly accessible and therefore do
not belong in the patch.
--
Martin K. Petersen Oracle Linux Engineering
he SPDX tags that this
> is a kernel header to which the Linux-syscall-note applies.
OK.
--
Martin K. Petersen Oracle Linux Engineering
However, now
> they each get their own copy, which leads to a huge increase in stack
> usage as seen from the compiler warning:
Applied to 5.3/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Marcos,
> Currently, all USB devices skip VPD pages, even when the device
> supports them (SPC-3 and later), but some of them support VPD, like
> Cruzer Blade.
We'll try it and see what happens. As I mentioned, SanDisk have
traditionally been pretty good wrt. spec compliance.
--
James,
> I also don't really think the replacement adds anything to readability,
> so it should probably be removed from the checkpatch warnings.
I agree.
--
Martin K. Petersen Oracle Linux Engineering
plied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
hould it be static?
> drivers/scsi/megaraid/megaraid_sas_base.c:3194:25: warning: symbol
> 'megaraid_host_attrs' was not declared. Should it be static?
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> One of the more common cases of allocation size calculations is finding
> the size of a structure that has a zero-sized array at the end, along
> with memory for some number of elements for that array. For example:
Applied to 5.4/scsi-queue, thanks!
--
Martin K.
Arnd to ack the license change since he has made changes
(however mechanical) to the file.
--
Martin K. Petersen Oracle Linux Engineering
James,
> Actually, I was planning a second pull request for that one. I
> presume you think it's ready to go?
It's spent 3 weeks in -next without any complaints.
--
Martin K. Petersen Oracle Linux Engineering
has
> failed). Plus number of minor changes, spelling fixes and other
> trivia.
Looks like you forgot to pull in the scatterlist topic branch.
--
Martin K. Petersen Oracle Linux Engineering
Paolo,
> Ping? Are there any more objections?
It's a core change so we'll need some more reviews. I suggest you
resubmit.
--
Martin K. Petersen Oracle Linux Engineering
Adrian,
> Add more Intel PCI Ids.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
y by hand. Please use git send-email to
post patches. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
; GPL-2.0-or-later
Looks like there are tons of the old style SPDX tags in the kernel. Is
there going to be a treewide conversion to the new tag format?
Just wondering how much to clean up given that the files Christoph
touched only constitute a subset of the old style tags found under
drivers/scsi.
--
but have had a critical fire
eating up a bunch of my time the last couple of weeks. I'll get to it...
--
Martin K. Petersen Oracle Linux Engineering
Dongli,
> The 'affinity_hint_set' is not used any longer since
> commit 0d9f0a52c8b9 ("virtio_scsi: use virtio IRQ affinity").
Applied to 5.3/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
interfaces from /proc simply never took place. What happened was
that *new* functionality largely went to sysfs.
Note that I don't have a problem adding missing knobs to sysfs where it
makes sense. But it will obviously take a while for userland apps to
adopt it.
--
Martin K. Petersen
Hi Young,
> sc_cmd->sense_buffer is not guaranteed to be allocated so we need to
> sc_cmd->check if the pointer is NULL before trying to copy anything
> into it.
bnx2fc does not appear to use a driver-specific sense buffer.
--
Martin K. Petersen Oracle Linux Engineering
just trying to establish how risky
it is for me to pick it up.
--
Martin K. Petersen Oracle Linux Engineering
that also
> have one. I can't say about "all others" but so far, 4/4 devices that
> I tested have VPD. (They were all SPC-3 or SPC-4 compliant).
That's not a very large sample. However, SanDisk have traditionally been
pretty good wrt. spec compliance.
--
Martin K. Petersen Oracle Linux Engineering
is,
> change the scsi_sdev_attr_is_visible function to hide wwid sysfs file
> when the devices does not support VPD.
Not a big fan of attribute files that come and go.
Why not just return an empty string? Hannes?
--
Martin K. Petersen Oracle Linux Engineering
is change with?
--
Martin K. Petersen Oracle Linux Engineering
sible option and
select it if either of the PCI/ISA/PCMCIA drivers are enabled.
--
Martin K. Petersen Oracle Linux Engineering
gt; advertised as present.
Applied to 5.3/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
.
> struct MR_PD_CFG_SEQ seq[1];
> } __packed;
>
> Make use of the struct_size() helper instead of an open-coded version
> in order to avoid any potential type mistakes.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
i.c. The remaining complaints seem to be
> false positives.
>
> Some of these patches are not trivial to backport. Those patches have
> been nominated for recent -stable branches only.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Ondrej,
> Host reset oopses because it calls wd719x_chip_init, which calls
> request_firmware, under a spinlock. Stop the RISC first, then flush
> active SCBs under a spinlock. Finally call wd719x_chip_init unlocked.
Applied to 5.3/scsi-queue. Thank you!
--
Martin K. Petersen
Christophe,
> Use 'kasprintf()' instead of:
>- snprintf(NULL, 0...
>- kmalloc(...
>- snprintf(...
>
> This is less verbose and saves 7 bytes (i.e. the space for '/(null)') if
> 'udev->dev_config' is NULL.
Applied to 5.3/scsi-queue. Thanks!
--
Martin K. Pe
Branden,
> Adding functionality to allow the SCSI queue depth to be changed, by
> utilizing the "scsi_change_queue_depth" function.
Applied to 5.3/scsi-queue. Please run checkpatch before submission. I
fixed it up this time.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
level 3 was used: -Wimplicit-fallthrough=3
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
i-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Michael,
> No matter - patch applied cleanly to what I'm running on my Falcon,
> and works just fine for now (stresstest will take a few hours to
> complete). And that'll thoroughly exercise the reselection code path,
> from what we've seen before.
How did it go?
--
Martin
.
I'll monitor and merge them.
--
Martin K. Petersen Oracle Linux Engineering
;horkage & ATA_HORKAGE_ZERO_AFTER_TRIM) {
> - ata_dev_info(dev, "Enabling
> discard_zeroes_data\n");
> + dev->horkage & ATA_HORKAGE_ZERO_AFTER_TRIM)
> rbuf[14] |= 0x40; /* LBPRZ */
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
quot;trim: %s, queued: %s,
> zero_after_trim: %s\n",
> + trim_status, trim_queued, trim_zero);
> + }
> +
Otherwise no particular objections. We were trying to limit noise during
boot which is why this information originally went to sysfs instead of
being printed during probe.
--
Martin K. Petersen Oracle Linux Engineering
John,
>> Many times in libsas, and in LLDDs which use libsas, the check for an
>> expander device is re-implemented or open coded.
>
> Applied to 5.3/scsi-queue, thanks.
Dropped again. Breaks isci. Please fix.
--
Martin K. Petersen Oracle Linux Engineering
Geert,
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
Geert,
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
>
> It's not used any more since
> commit 200aed582d61 ("megaraid_sas: endianness related bug fixes and code
> optimization")
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
("megaraid_sas : Firmware crash dump feature support")
>
> 'ci_h' is not used since commit 9b3d028f3468 ("scsi: megaraid_sas:
> Pre-allocate frequently used DMA buffers")
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
John,
> Many times in libsas, and in LLDDs which use libsas, the check for an
> expander device is re-implemented or open coded.
Applied to 5.3/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
t_get_ctx_for_oxid' [-Werror,-Wunused-function]
>
> These functions are only compiled when CONFIG_NVME_TARGET_FC is enabled.
> Use that same condition so there is no more warning. While the fixes
> commit did not introduce these functions, it caused these warnings.
Applied to 5.3/scs
scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
gt; drivers/scsi/lpfc/lpfc_init.c:75:10: warning: symbol 'lpfc_present_cpu' was
> not declared. Should it be static?
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warnings:
>
> drivers/scsi/lpfc/lpfc_init.c: In function lpfc_setup_cq_lookup:
> drivers/scsi/lpfc/lpfc_init.c:9359:30: warning: variable qp set but not used
> [-Wunused-but-set-variable]
Applied to 5.3/scsi-queue, thanks
John,
> This patchset introduces some misc patches for the driver. Nothing
> particularly stands out, maybe apart from a patch to delete a PHY's
> timer when necessary.
Applied to 5.3/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
hat doesn't use dev_cmd
> for device management requests, and was wrong in the first place.
Applied to 5.2/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bharath,
> Replace kmalloc + memcpy with kmemdup.
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
megaraid_sas: add hibernation support")
>
> 'wait_time' is not used since commit
> 11c71cb4ab7c ("megaraid_sas: Do not allow PCI access during OCR")
Applied to 5.3/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
e]
Applied to 5.3/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
d then modify it in the second fetch.
>
> To fix this, we need to recheck the 'ioc_number' in the second fetch.
Applied to 5.3/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
ueue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
ill clear
> phy->in_shutdown and a new shutdown-event will be queued. The queue will
> be full of these shutdown-events.
>
> Fix this by only clear phy->in_shutdown in sas_phye_shutdown(), that is
> after the first shutdown-event has been executed.
Applied 1+2 to 5.2/scsi-fi
Thomas,
> Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0.
Applied to 5.3/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> If alloc_workqueue fails in alua_init, it should return -ENOMEM,
> otherwise it will trigger null-ptr-deref while unloading module which
> calls destroy_workqueue dereference wq->lock like this:
Applied to 5.2/scsi-fixes. Thanks!
--
Martin K. Petersen
Lianbo,
> When SME is enabled, the smartpqi driver won't work on the HP DL385
> G10 machine, which causes the failure of kernel boot because it fails
> to allocate pqi error buffer. Please refer to the kernel log:
Applied to 5.2/scsi-fixes, thanks!
--
Martin K. Petersen Ora
Colin,
> Currently the check for a lockup_detected failure exits via the label
> return_reset_status that reads and dereferences an uninitialized
> pointer dev. Fix this by ensuring dev is inintialized to null.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Ora
Hariprasad,
> fix below warning reported by coccicheck
>
> drivers/target/iscsi/iscsi_target_nego.c:175:6-8: WARNING: possible
> condition with no effect (if == else)
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Ondrej,
> Add PCMCIA card support to Future Domain SCSI driver.
>
> Tested with IBM SCSI PCMCIA Adapter 40G1890.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Weitao,
> fix abord to abort
Updated patch header to reflect the pm8001 driver and applied to
5.3/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Ondrej,
> Add register bit definitions from documentation to header file and use
> them instead of magic constants. No changes to generated binary.
Applied to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
I need to synthesize the
contents of the pages with problems. I can't share the ones I have
received from customers so I removed the arrays from the patch.
--
Martin K. Petersen Oracle Linux Engineering
>From 968dfc5cd498d2ea6e77801cc9b9183a1a28b35d Mon Sep 17 00:00:00 2001
From: "M
701 - 800 of 3174 matches
Mail list logo
