Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-11-16 Thread Martin Lund
On Fri, Nov 16, 2018 at 2:50 PM Naga Sureshkumar Relli wrote: > > Hi, > > > -Original Message- > > From: Michal Simek [mailto:michal.si...@xilinx.com] > > Sent: Friday, November 16, 2018 6:04 PM > > To: Martin Lund ; Naga Sureshkumar Relli > &g

Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-11-16 Thread Martin Lund
On Fri, Nov 16, 2018 at 2:50 PM Naga Sureshkumar Relli wrote: > > Hi, > > > -Original Message- > > From: Michal Simek [mailto:michal.si...@xilinx.com] > > Sent: Friday, November 16, 2018 6:04 PM > > To: Martin Lund ; Naga Sureshkumar Relli > &g

Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-11-16 Thread Martin Lund
On Fri, Nov 16, 2018 at 12:50 PM Martin Lund wrote: > Compared with the example you will notice that "clock-name" should be > "clock-names". reg was missing a "0x0". Also, "sys" should be "clk_sys" and "flash" should be "clk_flash".

Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-11-16 Thread Martin Lund
On Fri, Nov 16, 2018 at 12:50 PM Martin Lund wrote: > Compared with the example you will notice that "clock-name" should be > "clock-names". reg was missing a "0x0". Also, "sys" should be "clk_sys" and "flash" should be "clk_flash".

Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-11-16 Thread Martin Lund
Hi Naga, I've been working on running up the latest kernel (v4.20-rc2) on our custom Xilinx hw board so that I can test the v12 version of your Arasan nand driver. I've managed to get the driver successfully up and running and ready for testing with a Micron MT29F64G08AFAAAWP device. However,

Re: [LINUX PATCH v12 1/3] dt-bindings: mtd: arasan: Add device tree binding documentation

2018-11-16 Thread Martin Lund
Hi Naga, I've been working on running up the latest kernel (v4.20-rc2) on our custom Xilinx hw board so that I can test the v12 version of your Arasan nand driver. I've managed to get the driver successfully up and running and ready for testing with a Micron MT29F64G08AFAAAWP device. However,

Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-11-12 Thread Martin Lund
Hi Naga, Just a few review comments for the v12 version. On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli wrote: > +#define PKT_OFST 0x00 > +#define PKT_CNT_SHIFT 12 > + > +#define MEM_ADDR1_OFST 0x04 > +#define MEM_ADDR2_OFST 0x08 For the sake of

Re: [LINUX PATCH v12 3/3] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-11-12 Thread Martin Lund
Hi Naga, Just a few review comments for the v12 version. On Fri, Nov 9, 2018 at 6:00 AM Naga Sureshkumar Relli wrote: > +#define PKT_OFST 0x00 > +#define PKT_CNT_SHIFT 12 > + > +#define MEM_ADDR1_OFST 0x04 > +#define MEM_ADDR2_OFST 0x08 For the sake of