Acked-By: Martin Pitt
Hello Junjie,
Junjie Mao [2014-10-28 9:31 +0800]:
> The driver is not released when ieee80211_register_hw fails in
> mac80211_hwsim_create_radio, leading to the access to the unregistered (and
> possibly freed) device in platform_driver_unregister:
Many thanks f
G "mac80211_hwsim: device_bind_driver failed
(%d)\n",
err);
- goto failed_hw;
+ goto failed_drvdata;
}
(I'm not claiming that this is correct, just taking a stab at
understanding what happens) If not, does i
it'ed
memory?
I can certainly check out linux-next, build the whole thing
statically, and try to twiddle things a bit, but I'm afraid that's
just going to take a while (both because this is all new to me and I'm
working on other things ATM), so please don't hold your breath. :-)
Thanks,
Martin
--
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
still works well.
Tested-By: Martin Pitt
Martin
--
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)
signature.asc
Description: Digital signature
If driver_register() fails, properly exit with the same error code.
Signed-off-by: Martin Pitt
---
drivers/net/wireless/mac80211_hwsim.c |7 ++-
1 files changed, 6 insertions(+), 1 deletions(-)
diff --git a/drivers/net/wireless/mac80211_hwsim.c
b/drivers/net/wireless/mac80211_hwsim.c
Properly register our mac80211_hwsim_driver, attach it to the platform bus.
Bind newly created hwsim devices to that driver, so that our wlan devices get
a proper "driver" sysfs attribute.
This makes mac80211_hwsim interfaces work with NetworkManager.
Signed-off-by: Martin Pitt
---
d
Hello Johannes,
Johannes Berg [2013-04-08 11:12 +0200]:
> I think you forgot to update the error path to unregister the driver.
Oops, thanks for spotting. Sending [PATCH v2].
Martin
--
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Deb
Properly register our mac80211_hwsim_driver, attach it to the platform bus.
Bind newly created hwsim devices to that driver, so that our wlan devices get
a proper "driver" sysfs attribute.
This makes mac80211_hwsim interfaces work with NetworkManager.
Signed-off-by: Martin Pitt
---
d
he style cleanup for the whole
file.
I got an ack from David Zeuthen (the primary udisks maintainer)
already, noted so in the patch.
Thank you in advance for considering,
Martin
--
Martin Pitt| http://www.piware.de
Ubuntu Developer (www.ubuntu.com) | Debian Deve
ful for being able to test the different behaviour/required
privileges in e. g. the udisks test suite.
Signed-off-by: Martin Pitt
Acked-By: David Zeuthen
---
drivers/scsi/scsi_debug.c | 30 +++---
1 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/drivers/sc
ful for being able to test the different behaviour/required
privileges in e. g. the udisks test suite.
Signed-off-by: Martin Pitt
Acked-By: David Zeuthen
---
drivers/scsi/scsi_debug.c | 30 +++---
1 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/drivers/sc
latter is desired, I'd
rather send a separate patch with just the style cleanup for the whole
file.
I got an ack from David Zeuthen (the primary udisks maintainer)
already, noted so in the patch.
Thank you in advance for considering,
Martin
--
Martin Pitt
? Can we define an e_flags bit for that?
Thanks in advance for any comment or idea,
Martin
--
Martin Pitthttp://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org
signature.asc
Description: Digital signature
serspace
> portion of
> apport or the kernel changes in the Ubuntu kernel?
Similarly to Neil's patches, the Ubuntu kernel calls the userspace
helper as root, too. Apport drops privileges to the target process as
soon as possible (there are a few things it needs to do before, like
a modification to split_argv, that I have a
> todo on next week.
Right, it's really just for perfectionism. Spaces in executable names
are EBW anyway, and readlink()ing /proc//exe is much more robust
anyway in terms of a small and orthogonal interface.
If the upstream kernel guys don&#
7;s usage of environment variables, on the
contrary. Using the standard macros is more explicit and elegant, and
I welcome that change. I just pointed out the reason why we chose the
environment variable approach initially.
I just wanted to mention this little problem for the sake of
correctness.
Thank you, and have a nice weekend!
Martin
--
Martin Pitthttp://www.piware.de
Ubuntu Developer http://www.ubuntu.com
Debian Developer http://www.debian.org
signature.asc
Description: Digital signature
bit cleaner, and
personally I do not care about the "executable name" macro for Apport
[1] (I grab it from /proc/pid/exe), but I wanted to mention this
possible caveat before it goes upstream.
Thank you,
Martin
[1] https://wiki.ubuntu.com/Apport
--
Martin Pitthttp://www.piwa
17 matches
Mail list logo
