Re: [PATCH 0/2] kconfig: allow use of relations other than (in)equality

2015-07-05 Thread Martin Walch
) Next, there is the case that B = 1 is true and C = 1 is false and the resulting implications and the same with B = 1 false and C = 1 true and with both of them false. And it probably needs even more constraints to get the first three propositions consistent in general. Yes, it is possible to get this ri

Re: [PATCH 0/2] kconfig: allow use of relations other than (in)equality

2015-07-02 Thread Martin Walch
tually more complex and reasoning harder. Once the new relations are added, it will be hard to get rid of them again. So, should this patch be reconsidered? Regards, Martin Walch -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [PATCH] Kconfig: drop bogus default values

2015-03-23 Thread Martin Walch
ads to the same configuration. However if there was a third default line, then in the former case that third default value would be always ignored while in the latter case it would determine the default value on s390. Regards, Martin Walch -- -- To unsubscribe from this list: send the line "

Re: [PATCH] Kconfig: drop bogus default values

2015-03-23 Thread Martin Walch
on each architecture PCI_QUIRKS=y except on s390 where PCI_QUIRKS=n. Regards, Martin Walch -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] net:Kconfig: drop no sense dependence entry for BONDING

2015-03-12 Thread Martin Walch
On Thursday 12 March 2015 21:59:33 Wang YanQing wrote: > "IPV6 || IPV6=n" means no dependence! IPV6 and BONDING are both tristate symbols and therefore this is not the same as no dependency. When setting IPV6 to m, the expression evaluates to "IPV6 || IPV6=n" "m || m=n" "m || n" "m" So, if IPV6

Re: [PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c

2014-10-10 Thread Martin Walch
On Tuesday 07 October 2014 11:21:51 Dirk Gouders wrote: > Paul Bolle writes: > > > On Mon, 2014-09-22 at 19:13 +0200, Martin Walch wrote: > >> expr_eliminate_dups2() in scripts/kconfig/expr.c applies two bad > >> inference rules: > >> > >> (FOO

[Resending PATCH v2 0/2] kconfig: fix bad syntactic transformation

2014-09-22 Thread Martin Walch
comments and convert C99 style comments to traditional ones. Martin Walch (2): kconfig: fix bad syntactic transformation in expr.c kconfig: trivial - adjust comments scripts/kconfig/expr.c | 146 +++-- scripts/kconfig/expr.h | 3 - 2 files changed, 1

[PATCH v2 1/2] kconfig: fix bad syntactic transformation in expr.c

2014-09-22 Thread Martin Walch
not triggered in mainline, so this patch does not modify the configuration space there. As a side effect, this reduces code size in expr.c by roughly 10% and slightly improves startup time for all configuration frontends. Signed-off-by: Martin Walch ---

[PATCH v2 2/2] kconfig: trivial - adjust comments

2014-09-22 Thread Martin Walch
djustment corresponding to the code. It should probably read (a!='b') && (a='c') -> 'b'='c' ? 'n' : a='c' 2) that one is similar: (a!='m') && (a!='n') -> (a='m') it should be (a!='m

kconfig: NEW: syntax highlighting for Kconfig files in KDE

2014-09-12 Thread Martin Walch
l (subject start [kconfig.xml]) or in the bug tracker of KDE at https://bugs.kde.org/ Regards Martin Walch -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/

[RESEND PATCH v2 2/2] kconfig: trivial - adjust comments in expr.c

2014-06-10 Thread Martin Walch
From: Martin Walch Replace any C99 comments with traditional ones (/*...*/). Also fix the contents of two comments: 1) the second occurrence of (a='b') && (a!='c') -> 'b'='c' ? 'n' : a='b' is probably copy & paste from

[RESEND PATCH v2 1/2] kconfig: completely remove expr_eliminate_dups2() and related code

2014-06-10 Thread Martin Walch
From: Martin Walch remove expr_eliminate_dups2(), expr_extract_eq_and(), expr_extract_eq_or(), and expr_extract_eq() from scripts/kconfig/expr.[ch] As the comments in the code state, expr_eliminate_dups2 applies these two transformations: (FOO || BAR) && (!FOO && !BAR)

[RESEND PATCH v2 0/2] kconfig: Remove bad inference rules expr_eliminate_dups2()

2014-06-10 Thread Martin Walch
. Martin Walch (2): kconfig: completely remove expr_eliminate_dups2() and related code kconfig: trivial - adjust comments scripts/kconfig/expr.c | 146 +++-- scripts/kconfig/expr.h | 3 - 2 files changed, 19 insertions(+), 130 deletions(-) -- 1.8.5.5

[PATCH v2 2/2] kconfig: trivial - adjust comments

2014-04-18 Thread Martin Walch
From: Martin Walch Date: Fri, 18 Apr 2014 22:15:37 +0200 Subject: [PATCH v2 2/2] kconfig: trivial - adjust comments Replace any C99 comments with traditional ones (/*...*/). Also fix the contents of two comments: 1) the second occurrence of (a='b') && (a!='c')

[PATCH v2 1/2] kconfig: completely remove expr_eliminate_dups2() and related code

2014-04-18 Thread Martin Walch
From: Martin Walch Date: Fri, 18 Apr 2014 22:10:14 +0200 Subject: [PATCH v2 1/2] kconfig: completely remove expr_eliminate_dups2() and related code remove expr_eliminate_dups2(), expr_extract_eq_and(), expr_extract_eq_or(), and expr_extract_eq() from scripts/kconfig/expr.[ch] As the comments

[PATCH v2 0/2] kconfig: Remove bad inference rules expr_eliminate_dups2()

2014-04-18 Thread Martin Walch
to fix something somewhere). Maybe some warning should be documented in case this patch gets accepted? v2 updates line numbers after latest changes PATCH 2: Fix some comments when touching expr.c anyway. No code changes. v2 additionally converts C99 style comments to traditional ones. Martin

[PATCH 1/2] kconfig: completely remove expr_eliminate_dups2() and related code

2014-02-13 Thread Martin Walch
From: Martin Walch Date: Thu, 13 Feb 2014 02:13:01 +0100 Subject: [PATCH 1/2] kconfig: completely remove expr_eliminate_dups2() and related code this removes expr_eliminate_dups2(), expr_extract_eq_and(), expr_extract_eq_or(), and expr_extract_eq() from scripts/kconfig/expr.[ch] As the

[PATCH 0/2] kconfig: Remove bad inference rules expr_eliminate_dups2()

2014-02-13 Thread Martin Walch
From: Martin Walch Date: Thu, 13 Feb 2014 12:22:18 +0100 Subject: [PATCH 0/2] kconfig: Remove bad inference rules expr_eliminate_dups2() PATCH 1: Removes expr_eliminate_dups2() and other related code. This does not seem to actually affect the behaviour when using Kconfig files from the mainline

[PATCH 2/2] kconfig: trivial - adjust comments

2014-02-13 Thread Martin Walch
From: Martin Walch Date: Thu, 13 Feb 2014 12:17:06 +0100 Subject: [PATCH 2/2] kconfig: trivial - adjust comments the line (a='b') && (a!='c') -> 'b'='c' ? 'n' : a='b' is probably copy & paste from above, missing the adj

Re: [PATCH] staging: r8188eu: default to "y" in Kconfig

2014-02-11 Thread Martin Walch
On Tuesday 11 February 2014 13:31:32 Paul Bolle wrote: > This patch also deserves a > Reported-by: Martin Walch > > line, but that apparently requires Martin's permission. I would be happy. And I am sorry for not sending patches myself. As I expect to find some more issues

[kconfig] update: results of some syntactical checks

2013-10-19 Thread Martin Walch
This is an update to the syntactic results that I sent, back in July. With kernel 3.12 nearing completion, I would like to point to new sections in Kconfig files with potential problems: drivers/media/common/siano/Kconfig:21-26 > config SMS_SIANO_DEBUGFS > bool "Enable debugfs for smsdvb" >

[PATCH v2 3/5] kconfig: adjust warning message for conflicting types

2013-10-03 Thread Martin Walch
From: Martin Walch Date: Thu, 3 Oct 2013 18:32:02 +0200 Subject: [PATCH v2 3/5] kconfig: adjust warning message for conflicting types Each symbol must have exactly one type assigned. However, if a symbol happens to have two different types assigned at runtime, a warning is printed and the first

[PATCH v2 1/5] kconfig: add short explanation to SYMBOL_WRITE

2013-10-03 Thread Martin Walch
From: Martin Walch Date: Thu, 3 Oct 2013 17:21:23 +0200 Subject: [PATCH v2 1/5] kconfig: add short explanation to SYMBOL_WRITE replace the question mark in the comment after SYMBOL_WRITE with an explanation Signed-off-by: Martin Walch --- scripts/kconfig/expr.h | 2 +- 1 file changed, 1

[PATCH v2 0/5] kconfig: cleanups, documentation updates, and one bug fix

2013-10-03 Thread Martin Walch
unused definition from scanner No changes since the first version. PATCH 5: kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len As I do not think it is worth to make this a separate patch, I appended this fix for a bug that is only triggered by the search

[PATCH v2 2/5] kconfig: fix trivial typos and update mconf documentation

2013-10-03 Thread Martin Walch
From: Martin Walch Date: Thu, 3 Oct 2013 17:28:14 +0200 Subject: [PATCH v2 2/5] kconfig: fix trivial typos and update mconf documentation This fixes lots of typos in comments and strings. It also updates the documentation strings in mconf to reflect the changes in the user interface from the

[PATCH v2 4/5] kconfig: remove unused definition from scanner

2013-10-03 Thread Martin Walch
From: Martin Walch Date: Thu, 3 Oct 2013 18:33:47 +0200 Subject: [PATCH v2 4/5] kconfig: remove unused definition from scanner The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion. As it is a dead definition, any changes in the resulting code generated by flex would be

[PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len

2013-10-03 Thread Martin Walch
From: Martin Walch Date: Thu, 3 Oct 2013 18:35:16 +0200 Subject: [PATCH v2 5/5] kconfig: fix bug in search results string: use strlen(gstr->s), not gstr->len The struct gstr has a capacity that may differ from the actual string length. However, a string manipulation in the function searc

Re: [PATCH 4/4] kconfig: remove unused definition from scanner

2013-10-02 Thread Martin Walch
in including the regenerated files in this patch set. Of course, if you see any benefit in regenerating the *_shipped files, I can still do so. Regards, Martin Walch -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord

Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-02 Thread Martin Walch
On Wednesday 02 October 2013 16:42:27 David Rientjes wrote: > The purpose of SYMBOL_WRITE is in sym_calc_value() where it is set if the > config symbol is visible and settable by the user, which is why I > suggested it be specified as being writable by the user. Then this looks strange to me: a

Re: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-02 Thread Martin Walch
> > diff --git a/scripts/kconfig/expr.h b/scripts/kconfig/expr.h > > index df198a5..ba663e1 100644 > > --- a/scripts/kconfig/expr.h > > +++ b/scripts/kconfig/expr.h > > @@ -93,7 +93,7 @@ struct symbol { > > #define SYMBOL_CHOICEVAL 0x0020 /* used as a value in a choice block */ > > #define SYMB

[PATCH 4/4] kconfig: remove unused definition from scanner

2013-10-01 Thread Martin Walch
From: Martin Walch Date: Wed, 2 Oct 2013 06:58:46 +0200 Subject: [PATCH 4/4] kconfig: remove unused definition from scanner The definition ws [ \n\t] is not used anywhere. Drop it to avoid confusion. Signed-off-by: Martin Walch --- scripts/kconfig/zconf.l | 1 - 1 file changed, 1 deletion

[PATCH 3/4] kconfig: adjust warning message for conflicting types

2013-10-01 Thread Martin Walch
From: Martin Walch Date: Wed, 2 Oct 2013 06:58:01 +0200 Subject: [PATCH 3/4] kconfig: adjust warning message for conflicting types Adjust warning: a second symbol type does *not* replace the first one. Signed-off-by: Martin Walch --- scripts/kconfig/menu.c | 2 +- 1 file changed, 1 insertion

[PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE

2013-10-01 Thread Martin Walch
From: Martin Walch Date: Wed, 2 Oct 2013 06:54:27 +0200 Subject: [PATCH 1/4] kconfig: add short explanation to SYMBOL_WRITE replace the question mark in the comment after SYMBOL_WRITE with an explanation Signed-off-by: Martin Walch --- scripts/kconfig/expr.h | 2 +- 1 file changed, 1 insertion

[PATCH 0/4]kconfig: minor cleanups and corrections

2013-10-01 Thread Martin Walch
Hello, these are some simple fixes to correct minor things I came across while reading the code. Martin Walch (4): kconfig: add short explanation to SYMBOL_WRITE kconfig: trivial: fix typos in comments kconfig: adjust warning message for conflicting types kconfig: remove unused

[PATCH 2/4] kconfig: trivial: fix typos

2013-10-01 Thread Martin Walch
From: Martin Walch Date: Wed, 2 Oct 2013 06:56:45 +0200 Subject: [PATCH 2/4] kconfig: trivial: fix typos inser() -> insert(), tell -> tells, peoperty -> property Signed-off-by: Martin Walch --- scripts/kconfig/mconf.c | 2 +- scripts/kconfig/menu.c | 2 +- scripts/kconfig/sym

Re: [kconfig] results of some syntactical checks

2013-07-17 Thread Martin Walch
On Wednesday 17 July 2013 01:18:00 Paul Bolle wrote: > On Wed, 2013-07-17 at 00:34 +0200, Martin Walch wrote: > > As I am working on yet another project for analyzing LKC's input files, I > > have some intermediate results from simple syntactical checks. > > Naive questi

[kconfig] results of some syntactical checks

2013-07-16 Thread Martin Walch
As I am working on yet another project for analyzing LKC's input files, I have some intermediate results from simple syntactical checks. The results below are an excerpt from a run against tche current master. If anyone is interested in the code (it's written in Java), please contact me. I plan

RAMster selects HAVE_ALIGNED_STRUCT_PAGE on 64 bit systems when it should not

2013-03-16 Thread Martin Walch
underscore from 64_BIT in drivers/staging/zcache/Kconfig. Regards Martin Walch -- signature.asc Description: This is a digitally signed message part.

Documentation of kconfig language differs from implementation regarding existence of symbols

2012-10-09 Thread Martin Walch
According to the documentation, at least FOO0 should exist, even if BAR0 is set to n. But this is not the case. AFAICS, both versions behave equivalently. I suggest changing the documentation accordingly. Regards Martin Walch -- config FOO0 tristate "FOO0" depends