Re: [RFC 0/2] Kbuild: Support nested composite objects

2021-01-26 Thread Masahiro Yamada
omposite objects > > scripts/Makefile.lib | 20 > 1 file changed, 16 insertions(+), 4 deletions(-) > > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Best Regards Masahiro Yamada

Re: [PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-26 Thread Masahiro Yamada
On Tue, Jan 26, 2021 at 5:01 PM Rolf Eike Beer wrote: > > Am Dienstag, 26. Januar 2021, 07:30:03 CET schrieb Masahiro Yamada: > > On Tue, Jan 26, 2021 at 2:42 PM Rolf Eike Beer wrote: > > > Am Mittwoch, 13. Januar 2021, 13:49:12 CET schrieb Rolf Eike Beer: > >

Re: [PATCH v5] scripts: use pkg-config to locate libcrypto

2021-01-26 Thread Masahiro Yamada
Platz 3, 37083 Göttingen, Germany > Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160 > Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055 > > emlix - smart embedded open source Is 'PKG_CONFIG' necessary? I see many Makefiles hard-coding 'pkg-config'. -- Best Regards Masahiro Yamada

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-26 Thread Masahiro Yamada
ttps://lore.kernel.org/patchwork/patch/836247/#1031547 Now that the compiler capability is evaluated in Kconfig, this is a harder requirement. In reality, a different compiler might be used, and, this requirement might be loosened, but the same compiler should be required for CONFIG_GCC_PLUGINS. -- Best Regards Masahiro Yamada

[PATCH 3/4] net: switchdev: use obj-$(CONFIG_NET_SWITCHDEV) form in net/Makefile

2021-01-25 Thread Masahiro Yamada
CONFIG_NET_SWITCHDEV is a bool option. Change the ifeq conditional to the standard obj-$(CONFIG_NET_SWITCHDEV) form. Use obj-y in net/switchdev/Makefile because Kbuild visits this Makefile only when CONFIG_NET_SWITCHDEV=y. Signed-off-by: Masahiro Yamada --- net/Makefile | 4

[PATCH 1/4] net: move CONFIG_NET guard to top Makefile

2021-01-25 Thread Masahiro Yamada
-by: Masahiro Yamada --- Makefile | 3 ++- net/Makefile | 11 --- 2 files changed, 6 insertions(+), 8 deletions(-) diff --git a/Makefile b/Makefile index b0e4767735dc..61357f7eb55f 100644 --- a/Makefile +++ b/Makefile @@ -649,7 +649,8 @@ ifeq ($(KBUILD_EXTMOD),) core-y

[PATCH 2/4] net: dcb: use obj-$(CONFIG_DCB) form in net/Makefile

2021-01-25 Thread Masahiro Yamada
CONFIG_DCB is a bool option. Change the ifeq conditional to the standard obj-$(CONFIG_DCB) form. Use obj-y in net/dcb/Makefile because Kbuild visits this Makefile only when CONFIG_DCB=y. Signed-off-by: Masahiro Yamada --- net/Makefile | 4 +--- net/dcb/Makefile | 2 +- 2 files changed, 2

[PATCH 4/4] net: l3mdev: use obj-$(CONFIG_NET_L3_MASTER_DEV) form in net/Makefile

2021-01-25 Thread Masahiro Yamada
CONFIG_NET_L3_MASTER_DEV is a bool option. Change the ifeq conditional to the standard obj-$(CONFIG_NET_L3_MASTER_DEV) form. Use obj-y in net/l3mdev/Makefile because Kbuild visits this Makefile only when CONFIG_NET_L3_MASTER_DEV=y. Signed-off-by: Masahiro Yamada --- net/Makefile| 4

[PATCH] net: sysctl: remove redundant #ifdef CONFIG_NET

2021-01-25 Thread Masahiro Yamada
CONFIG_NET is a bool option, and this file is compiled only when CONFIG_NET=y. Remove #ifdef CONFIG_NET, which we know it is always met. Signed-off-by: Masahiro Yamada --- net/core/sysctl_net_core.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/core/sysctl_net_core.c b/net/core

Re: [PATCH] kbuild: simplify GCC_PLUGINS enablement in dummy-tools/gcc

2021-01-25 Thread Masahiro Yamada
On Sat, Jan 23, 2021 at 6:16 PM Masahiro Yamada wrote: > > With commit 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev > capability test") applied, this check can be way simpler because > now scripts/gcc-plugins/Kconfig only checks plugin-version.h > > Si

Re: [PATCH v2] doc: gcc-plugins: drop more stale information

2021-01-25 Thread Masahiro Yamada
On Sat, Jan 23, 2021 at 10:34 PM Masahiro Yamada wrote: > > [1] Drop the version information > > The range of the supported GCC versions are always changing. The > current minimal GCC version is 4.9, and commit 1e860048c53e > ("gcc-plugins: simplify GCC plugin-dev ca

Re: [PATCH] cmd_dtc: Enable generation of device tree symbols

2021-01-25 Thread Masahiro Yamada
(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \ > + $(DTC) -@ -O $(patsubst .%,%,$(suffix $@)) -o $@ -b 0 \ > $(addprefix -i,$(dir $<) $(DTC_INCLUDE)) $(DTC_FLAGS) \ > -d $(depfile).dtc.tmp $(dtc-tmp) ; \ > cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile) > -- > 2.29.2 > -- Best Regards Masahiro Yamada

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-25 Thread Masahiro Yamada
On Tue, Jan 26, 2021 at 6:28 AM Josh Poimboeuf wrote: > > On Tue, Jan 26, 2021 at 06:16:01AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 26, 2021 at 5:42 AM Josh Poimboeuf wrote: > > > > > > When building out-of-tree kernel modules, the build system doesn't

Re: [PATCH RFC] gcc-plugins: Handle GCC version mismatch for OOT modules

2021-01-25 Thread Masahiro Yamada
NCOV),) > +ifneq ($(KBUILD_EXTMOD),) > +ifneq ($(CONFIG_GCC_VERSION), $(shell > $(srctree)/scripts/gcc-version.sh $(HOSTCXX))) > +$(warning warning: Disabling CONFIG_GCC_PLUGIN_SANCOV for > out-of-tree modules due to GCC version mismatch.) > +kcov-flags-y := $(filter-out %/sancov_plugin.so, $(kcov-flags-y)) > +endif > +endif > +endif > + > export CFLAGS_KCOV := $(kcov-flags-y) > -- > 2.29.2 > -- Best Regards Masahiro Yamada

[PATCH v2] doc: gcc-plugins: drop more stale information

2021-01-23 Thread Masahiro Yamada
exists because commit 9f671e58159a ("security: Create "kernel hardening" config area") moved some of plugin CONFIG options to another file. Find an appropriate place to add the new CONFIG. The sub-directory support was never used by anyone, and removed by commit c17d6179ad5a (&qu

[PATCH] doc: gcc-plugins: drop more stale information

2021-01-23 Thread Masahiro Yamada
Create "kernel hardening" config area") moved some of plugin CONFIG options to another file. Find an appropriate place to add the new CONFIG. I do not understand what was intended by the $(src)/ prefix. Remove it. Signed-off-by: Masahiro Yamada --- Documentation/kbuild

[PATCH] kbuild: simplify GCC_PLUGINS enablement in dummy-tools/gcc

2021-01-23 Thread Masahiro Yamada
With commit 1e860048c53e ("gcc-plugins: simplify GCC plugin-dev capability test") applied, this check can be way simpler because now scripts/gcc-plugins/Kconfig only checks plugin-version.h Signed-off-by: Masahiro Yamada --- scripts/dummy-tools/gcc | 10 +++--- 1 file changed, 3

Re: [PATCH] diffconfig: use python3 instead of python in Shebang line

2021-01-22 Thread Masahiro Yamada
On Sat, Jan 23, 2021 at 12:51 AM Joe Perches wrote: > > On Fri, 2021-01-22 at 07:06 +0900, Masahiro Yamada wrote: > > I use Ubuntu, where /usr/bin/python is a symlink > > to /usr/bin/python3. > > Odd, here: > > $ lsb_release -a > No LSB modules are av

Re: [PATCH V6 4/6] kbuild: Add support to build overlays (%.dtbo)

2021-01-22 Thread Masahiro Yamada
f-by: Viresh Kumar > --- Acked-by: Masahiro Yamada > .gitignore | 1 + > Makefile | 5 - > scripts/Makefile.dtbinst | 3 +++ > scripts/Makefile.lib | 5 + > 4 files changed, 13 insertions(+), 1 deletion(-) > > diff --git a/.gitignore b/.gi

Re: [PATCH] diffconfig: use python3 instead of python in Shebang line

2021-01-21 Thread Masahiro Yamada
On Fri, Jan 22, 2021 at 5:35 AM Andy Shevchenko wrote: > > On Thu, Jan 21, 2021 at 10:31 PM Andy Shevchenko > wrote: > > > > On Thu, Jan 21, 2021 at 10:28 PM Masahiro Yamada > > wrote: > > > > > > On Fri, Jan 22, 2021 at 2:17 AM Scott Branden >

Re: [PATCH] diffconfig: use python3 instead of python in Shebang line

2021-01-21 Thread Masahiro Yamada
gt; @@ -1,4 +1,4 @@ > -#!/usr/bin/env python > +#!/usr/bin/env python3 > # SPDX-License-Identifier: GPL-2.0 > # > # diffconfig - a tool to compare .config files. > -- > 2.17.1 > Just from curiosity, what problem is this solving? Is there a distribution where 'python' does not exist, but 'python3' does ? -- Best Regards Masahiro Yamada

Re: [PATCH] MAINTAINERS: adjust to clang-version.sh removal

2021-01-21 Thread Masahiro Yamada
group. > To unsubscribe from this group and stop receiving emails from it, send an > email to clang-built-linux+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/clang-built-linux/20210121161640.GA1101379%40ubuntu-m3-large-x86. -- Best Regards Masahiro Yamada

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-20 Thread Masahiro Yamada
,7 @@ ifeq ($(KBUILD_EXTMOD),) input-symdump := vmlinux.symvers output-symdump := Module.symvers +module-srcpath := $(srctree) else @@ -82,9 +83,20 @@ MODPOST += -e input-symdump := Module.symvers $(KBUILD_EXTRA_SYMBOLS) output-symdump := $(KBUILD_EXTMOD)/Module.symvers +module-srcpath := $(KBUILD_EXTMOD) endif -- Best Regards Masahiro Yamada

[PATCH] kbuild: warn a relative path used for M= in out-of-tree builds

2021-01-20 Thread Masahiro Yamada
officially supported ever. I do not recommend this usage. Reported-by: Will McVicker Signed-off-by: Masahiro Yamada --- Makefile | 7 +++ 1 file changed, 7 insertions(+) diff --git a/Makefile b/Makefile index b0e4767735dc..e42a27447eae 100644 --- a/Makefile +++ b/Makefile @@ -1699,6 +1699,13

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Masahiro Yamada
On Wed, Jan 20, 2021 at 6:55 PM Viresh Kumar wrote: > > On 20-01-21, 17:58, Masahiro Yamada wrote: > > > +%.dtb %.dtbo: include/config/kernel.release scripts_dtc > > > $(Q)$(MAKE) $(build)=$(dtstree) $(dtstree)/$@ > > > > > > No, this is wro

Re: [PATCH V5 4/5] kbuild: Add support to build overlays (%.dtbo)

2021-01-20 Thread Masahiro Yamada
-E $(dtc_cpp_flags) -x > assembler-with-cpp -o $(dtc-tmp) $< ; > -d $(depfile).dtc.tmp $(dtc-tmp) ; \ > cat $(depfile).pre.tmp $(depfile).dtc.tmp > $(depfile) > > -$(obj)/%.dtb: $(src)/%.dts $(DTC) FORCE > +$(obj)/%.dtb $(obj)/%.dtbo: $(src)/%.dts $(DTC) FORCE > $(call if_changed_dep,dtc) Same here. You need to duplicate the rules everywhere, unfortunately. > DT_CHECKER ?= dt-validate > -- > 2.25.0.rc1.19.g042ed3e048af > -- Best Regards Masahiro Yamada

[PATCH] kbuild: use always-y instead of extra-y

2021-01-19 Thread Masahiro Yamada
As commit d0e628cd817f ("kbuild: doc: clarify the difference between extra-y and always-y") explained, extra-y should be used for listing the prerequsites of vmlinux. always-y is a better fix here. Signed-off-by: Masahiro Yamada --- Documentation/devicetree/bindings/Mak

[PATCH] kbuild: remove deprecated syntax EXTRA_*FLAGS, always, hostprogs-*

2021-01-19 Thread Masahiro Yamada
The backward compatibility has been kept for a while. There is no user in upstream. Out-of-tree users must be converted to new ones. Signed-off-by: Masahiro Yamada --- scripts/Makefile.clean | 3 --- scripts/Makefile.lib | 17 - 2 files changed, 20 deletions(-) diff --git

[PATCH] ARM: vdso: remove unneded extra-y addition

2021-01-19 Thread Masahiro Yamada
The vdso linker script is prepocessed on demand. Adding it to 'targets' is enough, and line 13 of this Makefile does that. This extra-y addition is unneeded. Signed-off-by: Masahiro Yamada --- KernelVersion: v5.11-rc1 arch/arm/vdso/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git

Re: [PATCH v5 1/3] Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4

2021-01-19 Thread Masahiro Yamada
On Sat, Jan 16, 2021 at 8:54 AM Masahiro Yamada wrote: > > On Sat, Jan 16, 2021 at 6:51 AM Nick Desaulniers > wrote: > > > > On Fri, Jan 15, 2021 at 1:48 PM Sedat Dilek wrote: > > > > > > On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers > > &g

Re: [PATCH] kbuild: doc: remove "Objects which export symbols" section

2021-01-19 Thread Masahiro Yamada
On Sun, Jan 17, 2021 at 8:52 PM Masahiro Yamada wrote: > > EXPORT_SYMBOL is unrelated to makefiles. No need to mention it. > > Signed-off-by: Masahiro Yamada > --- Applied to linux-kbuild. > > Documentation/kbuild/makefiles.rst | 8 +--- > 1 file changed, 1 i

[PATCH] kbuild: stop removing stale file

2021-01-19 Thread Masahiro Yamada
Revert commit 223c24a7dba9 ("kbuild: Automatically remove stale file"). It was more than 6 years ago. I do not expect anybody to start git-bisect for such a big window. Signed-off-by: Masahiro Yamada --- Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git a/Makefile b/Make

[PATCH] init/version.c: remove Version_ symbol

2021-01-19 Thread Masahiro Yamada
existed until commit 4eb9241127a0 ("Documentation: admin-guide: update bug-hunting.rst") finally removed the stale ksymoops information. This symbol is no longer needed. [1] https://git.kernel.org/pub/scm/linux/kernel/git/history/history.git/commit/?id=ad68b2f085f5c79e4759ca2d13947b3c885

Re: [PATCH] gcc-plugins: simplify GCC plugin-dev capability test

2021-01-19 Thread Masahiro Yamada
rsion that CC was built against, or the version that HOSTCC was built against?" I do not have a good insight about this. I am not sure if it is perfectly OK to use gmp.h from HOSTCC when it was not bundled with CC. The version difference might not be a significant issue, though... -- Best Regards Masahiro Yamada

Re: [PATCH v2] kbuild: give the SUBLEVEL more room in KERNEL_VERSION

2021-01-19 Thread Masahiro Yamada
cking this can > > down the road. > > > > Cc: sta...@kernel.org > > Signed-off-by: Sasha Levin > > --- > > Looks good to me, thanks for fixing up the USB code. > > Reviewed-by: Greg Kroah-Hartman Applied to linux-kbuild. Thanks. -- Best Regards Masahiro Yamada

Re: [PATCH v6] kbuild: check the minimum compiler version in Kconfig

2021-01-18 Thread Masahiro Yamada
On Sat, Jan 16, 2021 at 8:36 AM Masahiro Yamada wrote: > > Paul Gortmaker reported a regression in the GCC version check. [1] > If you use GCC 4.8, the build breaks before showing the error message > "error Sorry, your version of GCC is too old - please use 4.9 or newer.&q

Re: [PATCH] kbuild: give SUBLEVEL more room in KERNEL_VERSION

2021-01-18 Thread Masahiro Yamada
rged\n" . $herecurr); It helps external modules to be compiled for multiple kernel versions. #if KERNEL_VERSION_CODE < KERNEL_VERSION(5, 4, 0) code for the kernel versions older than 5.4.0 #endif The upstream code does not do this. But, LINUX_VERSION_CODE is actually used in many places... > So how about we just provide a "real" version/subversion/revision > #define as well, and clean up all in-kernel users, so we can get this to > work, and we can change it in the future more easily. > > thanks, > > greg k-h -- Best Regards Masahiro Yamada

Re: [PATCH 2/2] sh: boot: avoid unneeded rebuilds under arch/sh/boot/compressed/

2021-01-17 Thread Masahiro Yamada
On Sun, Jan 17, 2021 at 10:35 PM John Paul Adrian Glaubitz wrote: > > Hi Masahiro! > > On 1/17/21 12:16 PM, Masahiro Yamada wrote: > > Even if none of source code is updated, the following are every time > > rebuilt: > > > > CC arch/sh/boot/compresse

Re: [PATCH v5] modules: introduce the MODULE_SCMVERSION config

2021-01-17 Thread Masahiro Yamada
mand line. masahiro@oscar:~/workspace/linux$ ./scripts/mod/modpost -v ./scripts/mod/modpost: option requires an argument -- 'v' I see the error message from getopt() instead of your hand-made error check. > + strncpy(module_scmversion, optarg, > sizeof(module_scmversion) - 1); > + break; > default: > exit(1); > } > @@ -2630,6 +2651,7 @@ int main(int argc, char **argv) > add_depends(, mod); > add_moddevtable(, mod); > add_srcversion(, mod); > + add_scmversion(); > > sprintf(fname, "%s.mod.c", mod->name); > write_if_changed(, fname); > -- > 2.30.0.284.gd98b1dd5eaa7-goog > -- Best Regards Masahiro Yamada

[PATCH] kbuild: doc: remove "Objects which export symbols" section

2021-01-17 Thread Masahiro Yamada
EXPORT_SYMBOL is unrelated to makefiles. No need to mention it. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/makefiles.rst | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/Documentation/kbuild/makefiles.rst b/Documentation/kbuild/makefiles.rst index

[PATCH 2/2] sh: boot: avoid unneeded rebuilds under arch/sh/boot/compressed/

2021-01-17 Thread Masahiro Yamada
/vmlinux OBJCOPY arch/sh/boot/zImage Add build artifacts to 'targets' as needed. I turned the library files to check-in files. It is simpler than copying from arch/sh/lib/ at build-time. Signed-off-by: Masahiro Yamada --- arch/sh/boot/compressed/.gitignore | 5 - arch/sh/boot/compressed

[PATCH 1/2] sh: boot: add intermediate vmlinux.bin* to targets instead of extra-y

2021-01-17 Thread Masahiro Yamada
You do not need to build all of vmlinux.bin* They are built on demand as prerequsites of uImage.bin*, hence should be added to targets instead of extra-y. Signed-off-by: Masahiro Yamada --- arch/sh/boot/Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/sh

[PATCH] openrisc: add arch/openrisc/Kbuild

2021-01-17 Thread Masahiro Yamada
Describe the subdirectories under arch/openrisc/ in arch/openrisc/Kbuild so you can use the standard obj-y syntax. I removed the CONFIG_OPENRISC_BUILTIN_DTB conditional because it is already controlled by arch/openrisc/boot/dts/Makefile. Signed-off-by: Masahiro Yamada --- arch/openrisc/Kbuild

Re: [PATCH v5 1/3] Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4

2021-01-15 Thread Masahiro Yamada
On Sat, Jan 16, 2021 at 6:51 AM Nick Desaulniers wrote: > > On Fri, Jan 15, 2021 at 1:48 PM Sedat Dilek wrote: > > > > On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers > > wrote: > > > > > > From: Masahiro Yamada > > > > > > Th

[PATCH 3/3] genksyms: remove useless case DOTS

2021-01-15 Thread Masahiro Yamada
This switch statement does not list out all the cases. Since the 'default' covers all the rest, the 'DOTS' case is unneeded. Signed-off-by: Masahiro Yamada --- scripts/genksyms/lex.l | 1 - 1 file changed, 1 deletion(-) diff --git a/scripts/genksyms/lex.l b/scripts/genksyms/lex.l index

[PATCH 2/3] genksyms: remove dead code for ST_TABLE_*

2021-01-15 Thread Masahiro Yamada
No one sets lexstate to ST_TABLE_*. It is is very old code, and I do not know what was the plan at that time. Let's remove the dead code. Signed-off-by: Masahiro Yamada --- scripts/genksyms/lex.l | 54 -- 1 file changed, 54 deletions(-) diff --git

[PATCH 1/3] genksyms: make source_file a local variable in lexer

2021-01-15 Thread Masahiro Yamada
This is only used in yylex() in lex.l Signed-off-by: Masahiro Yamada --- scripts/genksyms/genksyms.c | 2 +- scripts/genksyms/genksyms.h | 2 +- scripts/genksyms/lex.l | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/scripts/genksyms/genksyms.c b/scripts/genksyms

[PATCH v6] kbuild: check the minimum compiler version in Kconfig

2021-01-15 Thread Masahiro Yamada
Chancellor Reviewed-by: Miguel Ojeda Tested-by: Miguel Ojeda Tested-by: Sedat Dilek Signed-off-by: Masahiro Yamada --- Changes in v6: - Now that https://lore.kernel.org/r/20210112224832.10980-1-w...@kernel.org landed in Linus' tree, I cleaned up as well. Changes in v5: - double-quote $(cc-na

[PATCH v5] kbuild: check the minimum compiler version in Kconfig

2021-01-15 Thread Masahiro Yamada
Miguel Ojeda Tested-by: Sedat Dilek Signed-off-by: Masahiro Yamada --- Changes in v5: - double-quote $(cc-name) in the CC_IS_GCC and CC_IS_CLANG Changes in v4: - use lore version of the links Changes in v3: - add $(srctree)/ to fix out-of-tree build - support ICC version Changes in v2: - f

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-15 Thread Masahiro Yamada
On Fri, Jan 15, 2021 at 3:15 AM Miguel Ojeda wrote: > > On Thu, Jan 14, 2021 at 5:25 AM Masahiro Yamada wrote: > > > > The cc-version.sh also shows the error if the compiler is old: > > > > $ make defconfig CC=clang-9 > > *** Default configu

Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

2021-01-15 Thread Masahiro Yamada
On Sat, Jan 16, 2021 at 5:15 AM wrote: > > On 2021-01-14 17:12, Masahiro Yamada wrote: > > On Fri, Jan 15, 2021 at 6:50 AM Jeff Johnson > > wrote: > >> > >> From: Mahesh Kumar Kalikot Veetil > >> > >> Modules with a large number of com

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-14 Thread Masahiro Yamada
s sense only when you build *.S -> *.o This is why I think DEBUG_CFLAGS += -gdwarf-4 (for source debug of .c files) and KBUILD_AFLAGS += -Wa,gdwarf-4 (for source debug of .S files) are basically orthogonal (and they can be even controlled by separate CONFIG options). As stated above, DEBUG_CFLAGS += -Wa,gdward-4 does not make sense. I am not a compiler expert, but that is what I understood from some experiments. Please correct me if I am wrong. > > When I use GCC v10.2.1 DEBUG_CFLAGS are not set. > > You should have -gdwarf-4 (and not -Wa,-gwarf-4) set for DEBUG_CFLAGS > when compiling with GCC and enabling CONFIG_DEBUG_INFO_DWARF4. Can you > please confirm? (Perhaps you may have accidentally disabled > CONFIG_DEBUG_INFO by rerunning `make defconfig`?) > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

2021-01-14 Thread Masahiro Yamada
> $(multi-used-m): FORCE > > $(call if_changed,link_multi-m) > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > > > > > -- > Thanks, > ~Nick Desaulniers -- Best Regards Masahiro Yamada

Re: [PATCH v2 2/2] kbuild: handle excessively long argument lists

2021-01-14 Thread Masahiro Yamada
$(file >$@.in,$(filter %.o,$^)) \ > + $(LD) $(ld_flags) -r -o $@ @$@.in; \ > + rm -f $@.in > > $(multi-used-m): FORCE > $(call if_changed,link_multi-m) > -- > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > a Linux Foundation Collaborative Project > -- Best Regards Masahiro Yamada

Re: [PATCH] scripts: kconfig: fix HOSTCC call

2021-01-14 Thread Masahiro Yamada
ic sysroot). > -if echo '#include ' | "${HOSTCC}" -E - >/dev/null 2>&1; then > +if echo '#include ' | ${HOSTCC} -E - >/dev/null ; then Please keep 2>&1. This script will display the enough error message at the end. > echo cflags=\"-D_GNU_SOURCE\" > echo libs=\"-lncurses\" > exit 0 > -- > 2.11.0 > -- Best Regards Masahiro Yamada

[PATCH v4] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Masahiro Yamada
ted-by: Miguel Ojeda Signed-off-by: Masahiro Yamada --- Changes in v4: - use lore version of the links Changes in v3: - add $(srctree)/ to fix out-of-tree build - support ICC version Changes in v2: - fix the function name include/linux/compiler-clang.h | 10 - init/Kconfig

[PATCH v3] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Masahiro Yamada
d-by: Linus Torvalds Signed-off-by: Masahiro Yamada --- Changes in v3: - add $(srctree)/ to fix out-of-tree build - support ICC version Changes in v2: - fix the function name include/linux/compiler-clang.h | 10 - init/Kconfig | 9 ++-- scripts/Kconfig.include

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Masahiro Yamada
to __INTEL_COMPILER=xxyy __INTEL_COMPILER_UPDATE=zz The output from 19.0.1 does not make sense, though. BTW, when I tried ICC a few years ago, I could not build the kernel with it. -- Best Regards Masahiro Yamada

Re: Toolchain-dependent config options

2021-01-13 Thread Masahiro Yamada
tectures and toolchains. Introducing the build breakage is annoying. -- Best Regards Masahiro Yamada

[PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-13 Thread Masahiro Yamada
Torvalds Signed-off-by: Masahiro Yamada --- Changes in v2: - fix the function name include/linux/compiler-clang.h | 10 - init/Kconfig | 9 +++-- scripts/Kconfig.include| 6 +++ scripts/cc-version.sh | 69 ++ scri

[PATCH] kbuild: check the minimum compiler version in Kconfig

2021-01-13 Thread Masahiro Yamada
Torvalds Signed-off-by: Masahiro Yamada --- include/linux/compiler-clang.h | 10 - init/Kconfig | 9 +++-- scripts/Kconfig.include| 6 +++ scripts/cc-version.sh | 69 ++ scripts/clang-version.sh | 19 -- sc

Re: [PATCH] compiler.h: Raise minimum version of GCC to 5.1 for arm64

2021-01-13 Thread Masahiro Yamada
rm64 (for-next/fixes), thanks! > > [1/1] compiler.h: Raise minimum version of GCC to 5.1 for arm64 > https://git.kernel.org/arm64/c/1f1244a5ddb7 > > -- > Catalin > Maybe, we can raise the minimal version to gcc 5.1 for all architectures. -- Best Regards Masahiro Yamada

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Masahiro Yamada
On Tue, Jan 12, 2021 at 4:34 AM Nathan Chancellor wrote: > > On Tue, Jan 12, 2021 at 04:19:01AM +0900, Masahiro Yamada wrote: > > On Tue, Jan 12, 2021 at 3:06 AM Nathan Chancellor > > wrote: > > > > > > After commit da5fb18225b4 ("bpf: Support pre-2.

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-11 Thread Masahiro Yamada
e 100755 > index ..6de6f734a345 > --- /dev/null > +++ b/scripts/pahole-version.sh > @@ -0,0 +1,16 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# > +# Usage: $ ./scripts/pahole-version.sh pahole > +# > +# Print the pahole version as a three digit string > +# such as `119' for pahole v1.19 etc. > + > +pahole="$*" > + > +if ! [ -x "$(command -v $pahole)" ]; then > +echo 0 > +exit 1 > +fi > + > +$pahole --version | sed -E 's/v([0-9]+)\.([0-9]+)/\1\2/' > > base-commit: e22d7f05e445165e58feddb4e40cc9c0f94453bc > -- > 2.30.0 > -- Best Regards Masahiro Yamada

Re: [RFC 0/2] kbuild: Add support to build overlays (%.dtbo)

2021-01-11 Thread Masahiro Yamada
On Fri, Jan 8, 2021 at 4:02 AM Rob Herring wrote: > > On Wed, Jan 6, 2021 at 10:35 PM Masahiro Yamada wrote: > > > > On Wed, Jan 6, 2021 at 12:21 AM Rob Herring wrote: > > > > > > On Tue, Jan 5, 2021 at 4:24 AM Viresh Kumar > > > wrote

Re: [RFC 0/2] kbuild: Add support to build overlays (%.dtbo)

2021-01-11 Thread Masahiro Yamada
On Tue, Jan 12, 2021 at 1:13 AM Rob Herring wrote: > > +David Gibson > > On Mon, Jan 11, 2021 at 9:40 AM Masahiro Yamada wrote: > > > > On Mon, Jan 11, 2021 at 8:17 PM Viresh Kumar > > wrote: > > > > > > On 07-01-21, 14:28, Masahiro Ya

Re: [RFC 0/2] kbuild: Add support to build overlays (%.dtbo)

2021-01-11 Thread Masahiro Yamada
On Mon, Jan 11, 2021 at 8:17 PM Viresh Kumar wrote: > > On 07-01-21, 14:28, Masahiro Yamada wrote: > > Viresh's patch is not enough. > > > > We will need to change .gitignore > > and scripts/Makefile.dtbinst as well. > > > > In my understanding, the bui

[GIT PULL] Kbuild fixes for v5.11-rc3

2021-01-10 Thread Masahiro Yamada
lib/raid6: Let $(UNROLL) rules work with macOS userland Lukas Bulwahn (1): MAINTAINERS: adjust GCC PLUGINS after gcc-plugin.sh removal Masahiro Yamada (1): kconfig: remove 'kvmconfig' and 'xenconfig' shorthands Randy Dunlap (1): kconfig: config script: add a little user

Re: [PATCH] Documentation: kbuild: Fix section reference

2021-01-10 Thread Masahiro Yamada
ined in "3.11 Custom > Rules". > > Note: It is a typical mistake to forget the FORCE prerequisite. > Another common pitfall is that whitespace is sometimes significant; > for > -- > 2.25.0.rc1.19.g042ed3e048af > -- Best Regards Masahiro Yamada

Re: [PATCH V2 2/2] scripts: dtc: Build fdtoverlay and fdtdump tools

2021-01-06 Thread Masahiro Yamada
:= $(libfdt) fdtoverlay.o util.o > # Source files need to get at the userspace version of libfdt_env.h to > compile > HOST_EXTRACFLAGS += -I $(srctree)/$(src)/libfdt > -- > 2.25.0.rc1.19.g042ed3e048af > -- Best Regards Masahiro Yamada

Re: [RFC 0/2] kbuild: Add support to build overlays (%.dtbo)

2021-01-06 Thread Masahiro Yamada
to reuse for them. > > Also fdtoverlay is an external entity right now, and is not part of the > > kernel. Do we need to make it part of the kernel ? Or keep using the > > external entity ? > > Part of the kernel. We just need to add it to the dtc sync script and > makefile I think. > > Rob -- Best Regards Masahiro Yamada

[PATCH] sysctl: use min() helper for namecmp()

2021-01-04 Thread Masahiro Yamada
Make it slightly readable by using min(). Signed-off-by: Masahiro Yamada --- fs/proc/proc_sysctl.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/fs/proc/proc_sysctl.c b/fs/proc/proc_sysctl.c index 317899222d7f..86341c0f0c40 100644 --- a/fs/proc/proc_sysctl.c +++ b

Re: Kconfig, DEFAULT_NETSCH, and shooting yourself in the foot..

2021-01-02 Thread Masahiro Yamada
prompt "Default" config DEFAULT_FOO bool "Use foo for default" depends on FOO = y config DEFAULT_BAR bool "Use bar for default" depends on BAR = y config DEFAULT_FALLBACK bool "fallback when nothing else is builtin" endchoice -- Best Regards Masahiro Yamada

Re: Linux 5.11-rc1

2021-01-02 Thread Masahiro Yamada
On Sat, Jan 2, 2021 at 4:51 PM Masahiro Yamada wrote: > > On Sat, Jan 2, 2021 at 3:55 AM Sedat Dilek wrote: > > > > On Fri, Jan 1, 2021 at 5:14 PM Pavel Machek wrote: > > > > > > Hi! > > > > > > > > > >

Re: Linux 5.11-rc1

2021-01-02 Thread Masahiro Yamada
ed 'make deb-pkg' with/without rootless builds. It also successfully found depmod in /sbin, presumably dpkg tools automatically tweak PATH env variable. Maybe, the problem is when we run 'make modules_install' for cross compilation, which we do not necessarily require the root permission. Users can still adjust PATH in ~/.profile, but somebody may think breaking the legacy behavior is annoying. So, after some consideration, the workaround by Linus looks good to me. -- Best Regards Masahiro Yamada

Re: [PATCH v2] local64.h: make mandatory

2020-12-27 Thread Masahiro Yamada
kernel.org > Cc: Ley Foon Tan > Cc: Mark Salter > Cc: Aurelien Jacquiot > Cc: linux-c6x-...@linux-c6x.org > Cc: Peter Zijlstra > Cc: Masahiro Yamada Reviewed-by: Masahiro Yamada > Cc: Andrew Morton > --- > Would some $maintainer please plan to apply/m

[PATCH 2/2] powerpc/vdso64: remove meaningless vgettimeofday.o build rule

2020-12-23 Thread Masahiro Yamada
VDSO64 is only built for the 64-bit kernel, hence vgettimeofday.o is built by the generic rule in scripts/Makefile.build. This line does not provide anything useful. Signed-off-by: Masahiro Yamada --- arch/powerpc/kernel/vdso64/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git

[PATCH 1/2] powerpc/vdso: fix unnecessary rebuilds of vgettimeofday.o

2020-12-23 Thread Masahiro Yamada
in the embedded vdso images. Removing the unneeded second descend solves the problem. Link: https://lore.kernel.org/linuxppc-dev/87tuslxhry@mpe.ellerman.id.au/ Reported-by: Michael Ellerman Signed-off-by: Masahiro Yamada --- arch/powerpc/kernel/Makefile | 4 ++-- arch

[PATCH] microblaze: do not select TRACING_SUPPORT directly

2020-12-23 Thread Masahiro Yamada
TRACE_IRQFLAGS_SUPPORT and STACKTRACE_SUPPORT, so there is no change in the resulted configuration. Signed-off-by: Masahiro Yamada --- arch/microblaze/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/microblaze/Kconfig b/arch/microblaze/Kconfig index a0e0c43a2852..acd6d0e68089

Re: [PATCH v2] kconfig: config script: add a little user help

2020-12-23 Thread Masahiro Yamada
On Sun, Dec 20, 2020 at 2:08 AM Randy Dunlap wrote: > > Give the user a clue about the problem along with the 35 lines of > usage/help text. > > Signed-off-by: Randy Dunlap > Cc: Andi Kleen > Cc: Masahiro Yamada > Cc: linux-kbu...@vger.kernel.org > --- >

[PATCH] kconfig: remove 'kvmconfig' and 'xenconfig' shorthands

2020-12-22 Thread Masahiro Yamada
Linux 5.10 is out. Remove the 'kvmconfig' and 'xenconfig' shorthands as previously announced. Signed-off-by: Masahiro Yamada --- scripts/kconfig/Makefile | 10 -- 1 file changed, 10 deletions(-) diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile index e46df0a2d4f9

Re: [PATCH] sh: check return code of request_irq

2020-12-22 Thread Masahiro Yamada
gt; + IRQF_PERCPU, "IPI", (void *)(long)i)) > + pr_err("Failed to request irq %d\n", i); > > for (i = 0; i < max_cpus; i++) > set_cpu_present(i, true); > -- > 2.29.2.729.g45daf8777d-goog > -- Best Regards Masahiro Yamada

Re: [PATCH] Revert "kbuild: avoid static_assert for genksyms"

2020-12-22 Thread Masahiro Yamada
On Sun, Dec 20, 2020 at 3:40 AM Masahiro Yamada wrote: > > This reverts commit 14dc3983b5dff513a90bd5a8cc90acaf7867c3d0. > > Macro Elver had sent a fix proper fix earlier, and also pointed out > corner cases: > > "I guess what you propose is simpler, but might still ha

[GIT PULL 2/2] Kconfig updates for v5.11-rc1

2020-12-22 Thread Masahiro Yamada
- Validate signal/slot connection at compile time of qconf - Sanitize header includes Boris Kolpackov (2): kconfig: make lkc.h self-sufficient #include-wise kconfig: clean up header inclusion Masahiro Yamada (6): kconfig

[GIT PULL 1/2] Kbuild updates for v5.11-rc1

2020-12-22 Thread Masahiro Yamada
): Documentation/kbuild: Document COMPILE_TEST dependencies Documentation/kbuild: Document platform dependency practises Marco Elver (1): genksyms: Ignore module scoped _Static_assert() Masahiro Yamada (12): kbuild: doc: update the description about kbuild Makefiles

Re: [PATCH v2] openrisc: Add vmlinux.bin target

2020-12-21 Thread Masahiro Yamada
; - add cleanup rule > - add vmlinux.bin to targets > - Add gitignore Reviewed-by: Masahiro Yamada --- Best Regards Masahiro Yamada

Re: [PATCH] openrisc: Add vmlinux.bin target

2020-12-21 Thread Masahiro Yamada
d,objcopy) Please add targets += vmlinux.bin Also, you need to add arch/openrisc/boot/.gitignore > -- > 2.29.2 > -- Best Regards Masahiro Yamada

Re: [PATCH] Makefile: Remove Module.symvers when make clean

2020-12-21 Thread Masahiro Yamada
'make clean' > CLEAN_FILES += include/ksym vmlinux.symvers \ > - modules.builtin modules.builtin.modinfo modules.nsdeps \ > + modules.builtin modules.builtin.modinfo modules.nsdeps > Module.symvers\ >compile_commands.json > > # Directories & files removed with 'make mrproper' > -- > 2.1.0 > -- Best Regards Masahiro Yamada

Re: [PATCH] arm64: do not descend to vdso directories twice

2020-12-21 Thread Masahiro Yamada
On Mon, Dec 21, 2020 at 11:36 PM Vincenzo Frascino wrote: > > Hi Masahiro, > > On 12/18/20 2:45 AM, Masahiro Yamada wrote: > > arm64 descends into each vdso directory twice; first in vdso_prepare, > > second during the ordinary build process. > > > > PPC mi

Re: [PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-21 Thread Masahiro Yamada
On Tue, Dec 22, 2020 at 12:26 AM Andrew Lunn wrote: > > On Mon, Dec 21, 2020 at 02:43:23PM +0900, Masahiro Yamada wrote: > > The declaration of request_irq() in is marked as > > __must_check. > > > > Without the return value check, I see the following warnings

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-21 Thread Masahiro Yamada
On Sun, Dec 13, 2020 at 6:47 AM David Laight wrote: > > From: Masahiro Yamada > > Sent: 12 December 2020 16:55 > > > > This script was written in awk in spite of the file extension '.sh'. > > Rewrite it as a shell script. > ... > > +# > > +# Usage: $ .

Re: [PATCH 3/3] kbuild: rewrite ld-version.sh in shell script

2020-12-21 Thread Masahiro Yamada
On Sun, Dec 13, 2020 at 2:48 AM Dominique Martinet wrote: > > Masahiro Yamada wrote on Sun, Dec 13, 2020: > > This script was written in awk in spite of the file extension '.sh'. > > Rewrite it as a shell script. > > Wow! I wasn't expecting so much, would hav

[PATCH] fs: binfmt_em86: check the result of remove_arg_zero()

2020-12-21 Thread Masahiro Yamada
Roeck Signed-off-by: Masahiro Yamada --- fs/binfmt_em86.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/binfmt_em86.c b/fs/binfmt_em86.c index 06b9b9fddf70..ba1e22b2e2a3 100644 --- a/fs/binfmt_em86.c +++ b/fs/binfmt_em86.c @@ -63,7 +63,9 @@ static int load_em86(struct

[PATCH] kconfig: drop filename and line number prefix from warning/error-if macros

2020-12-21 Thread Masahiro Yamada
at from $(info,...), $(warning-if,...), $(error-if,...) will become symmetrical. Prefixing the file name and the line number to error messages is useful (but should not be a part of the language specification), so now it is implemented as a macro in scripts/Kconfig.include. Signed-off-by: Masahiro Yamada

[PATCH] kconfig: doc: fix $(fileno) to $(filename)

2020-12-20 Thread Masahiro Yamada
This is a typo. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/kconfig-macro-language.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kbuild/kconfig-macro-language.rst b/Documentation/kbuild/kconfig-macro-language.rst index 8b413ef9603d

[PATCH] kconfig: doc: fix $(fileno) to $(filename)

2020-12-20 Thread Masahiro Yamada
This is a typo. Signed-off-by: Masahiro Yamada --- Documentation/kbuild/kconfig-macro-language.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/kbuild/kconfig-macro-language.rst b/Documentation/kbuild/kconfig-macro-language.rst index 8b413ef9603d

Re: [PATCH v1] kbuild: enforce -Werror=unused-result

2020-12-20 Thread Masahiro Yamada
On Tue, Dec 1, 2020 at 7:42 PM Masahiro Yamada wrote: > > On Tue, Nov 17, 2020 at 7:47 PM Olaf Hering wrote: > > > > It is a hard error if a return value is ignored. > > In case the return value has no meaning, remove the attribute. > > > > Signed-off-by: Olaf

Re: [PATCH v3] Compiler Attributes: remove CONFIG_ENABLE_MUST_CHECK

2020-12-20 Thread Masahiro Yamada
me warnings. Tomorrow's linux-next should be OK and, you can send my patch in this merge window. -- Best Regards Masahiro Yamada

[PATCH] net: lantiq_etop: check the result of request_irq()

2020-12-20 Thread Masahiro Yamada
attribute warn_unused_result [-Wunused-result]   281 |    request_irq(irq, ltq_etop_dma_irq, 0, "etop_rx", priv);       |    ^~ Reported-by: Miguel Ojeda Signed-off-by: Masahiro Yamada --- drivers/net/ethernet/lantiq_etop.c | 13 +

Re: [PATCH] MAINTAINERS: adjust GCC PLUGINS after gcc-plugin.sh removal

2020-12-20 Thread Masahiro Yamada
-harden...@vger.kernel.org > S: Maintained > F: Documentation/kbuild/gcc-plugins.rst > F: scripts/Makefile.gcc-plugins > -F: scripts/gcc-plugin.sh > F: scripts/gcc-plugins/ > > GCOV BASED KERNEL PROFILING > -- > 2.17.1 > -- Best Regards Masahiro Yamada

<    1   2   3   4   5   6   7   8   9   10   >