Re: [PATCH] ipmi: Clear smi_info->thread to prevent use-after-free during module unload

Hi Corey, On 2018/01/16 9:40, Corey Minyard wrote: > On 01/15/2018 01:58 AM, Masamitsu Yamazaki wrote: >> During code inspection, I found an use-after-free possibility during >> unloading >> ipmi_si in the polling mode. > > I'm curious, what exactly is this c

[PATCH] ipmi: Clear smi_info->thread to prevent use-after-free during module unload

Subject:[PATCH] ipmi: Clear smi_info->thread to prevent use-after-free during module unload To: Corey Minyard To: openipmi-develo...@lists.sourceforge.net Cc: linux-kernel@vger.kernel.org Cc: j-nom...@ce.jp.nec.com Cc: k-u...@ct.jp.nec.com Cc: m-yamaz...@ah.jp.nec.com During code inspection, I f

[PATCH] ipmi: Stop timers before cleaning up the module

System may crash after unloading ipmi_si.ko module because a timer may remain and fire after the module cleaned up resources. cleanup_one_si() contains the following processing. /* * Make sure that interrupts, the timer and the thread are * stopped and will not run again