Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-08-02 Thread Masashi Honma
HT40 is capable. Now, I understand why you rejected this patch. But now, when disable_ht=1, no HT Capabilities element in beacon even though the node supports HT. My trailing patch could solve the issue. Masashi Honma.

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-08-02 Thread Masashi Honma
HT40 is capable. Now, I understand why you rejected this patch. But now, when disable_ht=1, no HT Capabilities element in beacon even though the node supports HT. My trailing patch could solve the issue. Masashi Honma.

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-08-01 Thread Masashi Honma
_SUP_WIDTH_20_40 bit in beacon was below. hostapd0.conf IEEE80211_HT_CAP_SUP_WIDTH_20_40 = 1 hostapd1.conf IEEE80211_HT_CAP_SUP_WIDTH_20_40 = 0 So I think the bit should be zero if disabled also for mesh peer. Masashi Honma.

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-08-01 Thread Masashi Honma
_SUP_WIDTH_20_40 bit in beacon was below. hostapd0.conf IEEE80211_HT_CAP_SUP_WIDTH_20_40 = 1 hostapd1.conf IEEE80211_HT_CAP_SUP_WIDTH_20_40 = 0 So I think the bit should be zero if disabled also for mesh peer. Masashi Honma.

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-08-01 Thread Masashi Honma
On 2016年08月01日 19:03, Johannes Berg wrote: But why is that behaviour *correct*? We still support 40 MHz bandwidth things, we just don't use them if we disable HT40. I could not fully understand your concern... Do you mean we have 2 bugs about disabling HT40 ? 1) bits in HT capabilities IE

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-08-01 Thread Masashi Honma
On 2016年08月01日 19:03, Johannes Berg wrote: But why is that behaviour *correct*? We still support 40 MHz bandwidth things, we just don't use them if we disable HT40. I could not fully understand your concern... Do you mean we have 2 bugs about disabling HT40 ? 1) bits in HT capabilities IE

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-25 Thread Masashi Honma
On 2016年07月22日 14:26, Masashi Honma wrote: > On 2016年07月14日 05:07, Yaniv Machani wrote: >> + >> +/* if channel width is 20MHz - configure HT capab accordingly*/ >> +if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { >> +cap &=

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-25 Thread Masashi Honma
On 2016年07月22日 14:26, Masashi Honma wrote: > On 2016年07月14日 05:07, Yaniv Machani wrote: >> + >> +/* if channel width is 20MHz - configure HT capab accordingly*/ >> +if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { >> +cap &=

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-21 Thread Masashi Honma
On 2016年07月14日 05:07, Yaniv Machani wrote: + + /* if channel width is 20MHz - configure HT capab accordingly*/ + if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { + cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40; + cap &=

Re: [PATCH v3 3/3] mac80211: mesh: fixed HT ies in beacon template

2016-07-21 Thread Masashi Honma
On 2016年07月14日 05:07, Yaniv Machani wrote: + + /* if channel width is 20MHz - configure HT capab accordingly*/ + if (sdata->vif.bss_conf.chandef.width == NL80211_CHAN_WIDTH_20) { + cap &= ~IEEE80211_HT_CAP_SUP_WIDTH_20_40; + cap &=