Re: [PATCH] platform/chrome: fix a double-unlock issue

2020-06-26 Thread Mat King
On Thu, Jun 25, 2020 at 2:26 AM Enric Balletbo i Serra wrote: > > Hi Qiushi, > > Thank you for your patch. > > On 23/5/20 5:16, wu000...@umn.edu wrote: > > From: Qiushi Wu > > > > In function cros_ec_ishtp_probe(), "up_write" is already called > > before function "cros_ec_dev_init". But

Re: [PATCH] acpi: battery: Always read fresh battery state on update

2020-06-05 Thread Mat King
On Fri, Jun 5, 2020 at 5:30 AM Rafael J. Wysocki wrote: > > On Thu, Jun 4, 2020 at 9:57 PM Mathew King wrote: > > > > When the ACPI battery receives a notification event it should always > > read the battery state fresh from the ACPI device and not use the cached > > state. > > Why should it?

Re: [PATCH 1/4] power_supply: Cleanup power supply sysfs attribute list

2020-05-04 Thread Mat King
On Fri, May 1, 2020 at 6:32 PM Sebastian Reichel wrote: > > Hi, > > On Fri, Apr 24, 2020 at 11:35:30AM -0600, Mathew King wrote: > > Make the device attribute list used to create sysfs attributes more > > robust by decoupling the list order from order of the enum defined in > > power_supply.h.

Re: New sysfs interface for privacy screens

2019-10-01 Thread Mat King
On Tue, Oct 1, 2019 at 10:27 AM Greg KH wrote: > > On Tue, Oct 01, 2019 at 10:09:46AM -0600, Mat King wrote: > > Resending in plain text mode > > > > I have been looking into adding Linux support for electronic privacy > > screens which is a feature on s