Re: [PATCH v11 1/4] remoteproc: zynqmp: fix lockstep mode memory region

2024-02-28 Thread Mathieu Poirier
On Wed, 28 Feb 2024 at 12:24, Tanmay Shah wrote: > > > On 2/28/24 11:08 AM, Mathieu Poirier wrote: > > On Mon, Feb 19, 2024 at 09:44:34AM -0800, Tanmay Shah wrote: > > > In lockstep mode, r5 core0 uses TCM of R5 core1. Following is lockstep > > > mode memory

Re: [PATCH v11 1/4] remoteproc: zynqmp: fix lockstep mode memory region

2024-02-28 Thread Mathieu Poirier
On Mon, Feb 19, 2024 at 09:44:34AM -0800, Tanmay Shah wrote: > In lockstep mode, r5 core0 uses TCM of R5 core1. Following is lockstep > mode memory region as per hardware reference manual. > > | *TCM* | *R5 View* | *Linux view* | > | R5_0 ATCM (128 KB) | 0x_ |

Re: [PATCH v11 4/4] remoteproc: zynqmp: parse TCM from device tree

2024-02-28 Thread Mathieu Poirier
On Mon, Feb 19, 2024 at 09:44:37AM -0800, Tanmay Shah wrote: > ZynqMP TCM information was fixed in driver. Now ZynqMP TCM information > is available in device-tree. Parse TCM information in driver > as per new bindings. > > Signed-off-by: Tanmay Shah > --- > > Changes in v11: > - Remove

Re: Audio dsp recovery using remoteproc

2024-02-27 Thread Mathieu Poirier
Good day, On Fri, Feb 16, 2024 at 03:29:56PM -0800, noman pouigt wrote: > mailbox to dsp_1 is currently modeling platform pcm driver. > mailbox to dsp_2 is also doing the same. > > Platform driver callbacks cause IPC to be sent to dsp's. > Lifecycle of two dsp's are managed by separate

Re: [PATCH 3/3] dt-bindings: remoteproc: ti,davinci: remove unstable remark

2024-02-26 Thread Mathieu Poirier
roc/ti,davinci-rproc.txt > @@ -1,9 +1,6 @@ > TI Davinci DSP devices > === > > -Binding status: Unstable - Subject to changes for DT representation of clocks > -and resets > - Reviewed-by: Mathieu Poirier > The TI Davinci family of SoC

Re: [PATCH v3 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-23 Thread Mathieu Poirier
On Fri, Feb 23, 2024 at 02:54:13PM +0100, Arnaud POULIQUEN wrote: > Hello Mathieu, > > On 2/22/24 20:02, Mathieu Poirier wrote: > > Hi, > > > > On Wed, Feb 14, 2024 at 06:21:27PM +0100, Arnaud Pouliquen wrote: > >> The new TEE remoteproc device is used to man

Re: [PATCH v3 3/7] remoteproc: core: Add check on cached_table pointer

2024-02-23 Thread Mathieu Poirier
On Wed, Feb 14, 2024 at 06:21:23PM +0100, Arnaud Pouliquen wrote: > Add a check on the optional rproc->cached_table to perform the memory > copy only if it is not null. > > 2 use cases to support: > - starting on boot, in which case rproc->cached_table can be null, > - starting on crash recovery,

Re: [PATCH v3 1/7] remoteproc: Add TEE support

2024-02-23 Thread Mathieu Poirier
On Wed, Feb 14, 2024 at 06:21:21PM +0100, Arnaud Pouliquen wrote: > From: Arnaud Pouliquen > > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this device offers a client >

Re: [PATCH v3 7/7] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-22 Thread Mathieu Poirier
Hi, On Wed, Feb 14, 2024 at 06:21:27PM +0100, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution

Re: [PATCH v3 1/7] remoteproc: Add TEE support

2024-02-20 Thread Mathieu Poirier
Good morning, On Wed, Feb 14, 2024 at 06:21:21PM +0100, Arnaud Pouliquen wrote: > From: Arnaud Pouliquen > > Add a remoteproc TEE (Trusted Execution Environment) driver > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this device offers a

Re: [PATCH v10 4/4] remoteproc: zynqmp: parse TCM from device tree

2024-02-14 Thread Mathieu Poirier
Good morning, On Tue, Feb 13, 2024 at 09:54:50AM -0800, Tanmay Shah wrote: > ZynqMP TCM information was fixed in driver. Now ZynqMP TCM information > is available in device-tree. Parse TCM information in driver > as per new bindings. > > Signed-off-by: Tanmay Shah > --- > > Changes in v10: >

Re: [Linux-stm32] [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-13 Thread Mathieu Poirier
On Tue, 13 Feb 2024 at 08:48, Arnaud POULIQUEN wrote: > > Hello Mathieu, > > On 2/5/24 10:13, Arnaud POULIQUEN wrote: > > > > > > On 2/2/24 20:53, Mathieu Poirier wrote: > >> On Thu, Feb 01, 2024 at 07:33:35PM +0100, Arnaud POULIQUEN wrote: > >>>

Re: [PATCH] remoteproc: zynqmp: fix lockstep mode memory region

2024-02-06 Thread Mathieu Poirier
45 ++-- > 1 file changed, 12 insertions(+), 133 deletions(-) > I am happy with this patch but won't apply it because I want to see what comes next. Please include it in your next patchet. Reviewed-by: Mathieu Poirier > diff --git a/drivers/remoteproc/xlnx_r5_remoteproc.

Re: [PATCH] rpmsg: core: make rpmsg_bus const

2024-02-05 Thread Mathieu Poirier
On Sun, Feb 04, 2024 at 05:32:05PM -0300, Ricardo B. Marliere wrote: > Now that the driver core can properly handle constant struct bus_type, > move the rpmsg_bus variable to be a constant structure as well, > placing it into read-only memory which can not be modified at runtime. > > Cc: Greg

Re: [PATCH v2 0/5] K3 DSP Remoteproc remove cleanup

2024-02-05 Thread Mathieu Poirier
On Mon, Feb 05, 2024 at 12:27:48PM -0600, Andrew Davis wrote: > Hello all, > > This series uses various devm_ helpers to simplify the device > removal path. > > Removing an unused var "ret1" got squashed into the wrong patch in > the v1 series causing a bisectability error. v2 is based on -next

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-02 Thread Mathieu Poirier
On Thu, Feb 01, 2024 at 07:33:35PM +0100, Arnaud POULIQUEN wrote: > > > On 2/1/24 17:02, Mathieu Poirier wrote: > > On Thu, Feb 01, 2024 at 04:06:37PM +0100, Arnaud POULIQUEN wrote: > >> hello Mathieu, > >> > >> On 1/31/24 19:52, Mathieu Poirier wrote

Re: [PATCH 9/9] remoteproc: stm32: Use devm_rproc_alloc() helper

2024-02-02 Thread Mathieu Poirier
On Tue, Jan 23, 2024 at 12:46:32PM -0600, Andrew Davis wrote: > Use the device lifecycle managed allocation function. This helps prevent > mistakes like freeing out of order in cleanup functions and forgetting to > free on error paths. > > Signed-off-by: Andrew Davis > --- >

Re: [PATCH 4/8] remoteproc: k3-dsp: Use devm_ti_sci_get_by_phandle() helper

2024-02-02 Thread Mathieu Poirier
Hi Andrew, On Tue, Jan 23, 2024 at 12:49:09PM -0600, Andrew Davis wrote: > Use the device lifecycle managed TI-SCI get() function. This helps prevent > mistakes like not put()'ing in the wrong order in cleanup functions and > forgetting to put() on error paths. > > Signed-off-by: Andrew Davis >

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-02-01 Thread Mathieu Poirier
On Thu, Feb 01, 2024 at 04:06:37PM +0100, Arnaud POULIQUEN wrote: > hello Mathieu, > > On 1/31/24 19:52, Mathieu Poirier wrote: > > On Tue, Jan 30, 2024 at 10:13:48AM +0100, Arnaud POULIQUEN wrote: > >> > >> > >> On 1/26/24 18:11, Mathieu Poirier wrote

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-01-31 Thread Mathieu Poirier
On Tue, Jan 30, 2024 at 10:13:48AM +0100, Arnaud POULIQUEN wrote: > > > On 1/26/24 18:11, Mathieu Poirier wrote: > > On Thu, Jan 18, 2024 at 11:04:33AM +0100, Arnaud Pouliquen wrote: > >> The new TEE remoteproc device is used to manage remote firmware in a > >>

Re: [PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-31 Thread Mathieu Poirier
On Tue, Jan 30, 2024 at 02:47:07PM -0600, Tanmay Shah wrote: > > On 1/17/24 12:58 PM, Mathieu Poirier wrote: > > Alright, I spent several hours looking at this patchset and the driver as a > > whole. I certainly salute your efforts to heed my advice and make the code &g

Re: [PATCH v2 1/4] remoteproc: Add TEE support

2024-01-29 Thread Mathieu Poirier
On Thu, Jan 18, 2024 at 11:04:30AM +0100, Arnaud Pouliquen wrote: > From: Arnaud Pouliquen > > Add a remoteproc TEE (Trusted Execution Environment) device > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this device offers a client >

Re: [PATCH v2 1/4] remoteproc: Add TEE support

2024-01-26 Thread Mathieu Poirier
On Thu, Jan 18, 2024 at 11:04:30AM +0100, Arnaud Pouliquen wrote: > From: Arnaud Pouliquen > > Add a remoteproc TEE (Trusted Execution Environment) device > that will be probed by the TEE bus. If the associated Trusted > application is supported on secure part this device offers a client >

Re: [PATCH v2 4/4] remoteproc: stm32: Add support of an OP-TEE TA to load the firmware

2024-01-26 Thread Mathieu Poirier
On Thu, Jan 18, 2024 at 11:04:33AM +0100, Arnaud Pouliquen wrote: > The new TEE remoteproc device is used to manage remote firmware in a > secure, trusted context. The 'st,stm32mp1-m4-tee' compatibility is > introduced to delegate the loading of the firmware to the trusted > execution context. In

Re: [PATCH v2 1/4] remoteproc: Add TEE support

2024-01-26 Thread Mathieu Poirier
On Fri, Jan 26, 2024 at 02:39:33PM +0100, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 1/25/24 19:55, Mathieu Poirier wrote: > > Hi Arnaud, > > > > On Thu, Jan 18, 2024 at 11:04:30AM +0100, Arnaud Pouliquen wrote: > >> From: Arnaud Pouliquen > >>

Re: [PATCH v2 1/4] remoteproc: Add TEE support

2024-01-25 Thread Mathieu Poirier
Hi Arnaud, On Thu, Jan 18, 2024 at 11:04:30AM +0100, Arnaud Pouliquen wrote: > From: Arnaud Pouliquen > > Add a remoteproc TEE (Trusted Execution Environment) device Device or driver? Seems to be the latter... > that will be probed by the TEE bus. If the associated Trusted > application is

Re: [PATCH 0/2] remoteproc: stm32: Fix sparse warnings

2024-01-23 Thread Mathieu Poirier
On Wed, Jan 17, 2024 at 02:53:10PM +0100, Arnaud Pouliquen wrote: > Fix warnings reported by sparse using make option "C=1" > > Arnaud Pouliquen (2): > remoteproc: stm32: Fix incorrect type in assignment for va > remoteproc: stm32: Fix incorrect type assignment returned by >

Re: [PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-22 Thread Mathieu Poirier
On Mon, Jan 22, 2024 at 01:02:08PM -0700, Mathieu Poirier wrote: > On Mon, 22 Jan 2024 at 10:51, Iuliana Prodan wrote: > > > > On 1/5/2024 6:01 PM, Ulf Hansson wrote: > > > Let's avoid the boilerplate code to manage the multiple PM domain case, by > > > convertin

Re: [PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-22 Thread Mathieu Poirier
On Mon, 22 Jan 2024 at 10:51, Iuliana Prodan wrote: > > On 1/5/2024 6:01 PM, Ulf Hansson wrote: > > Let's avoid the boilerplate code to manage the multiple PM domain case, by > > converting into using dev_pm_domain_attach|detach_list(). > > > > Cc: Mathieu Poirier &

Re: [PATCH v9 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-17 Thread Mathieu Poirier
Alright, I spent several hours looking at this patchset and the driver as a whole. I certainly salute your efforts to heed my advice and make the code less brittle but I'm afraid we are not there. See below for a different way to proceed. On Wed, Jan 10, 2024 at 01:35:05PM -0800, Tanmay Shah

Re: [PATCH] dt-bindings: remoteproc: do not override firmware-name $ref

2024-01-16 Thread Mathieu Poirier
sztof Kozlowski > --- > Documentation/devicetree/bindings/remoteproc/mtk,scp.yaml | 4 ++-- For the above: Reviewed-by: Mathieu Poirier > .../devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml | 2 +- > .../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 2 +-

Re: [PATCH] rpmsg: Remove usage of the deprecated ida_simple_xx() API

2024-01-15 Thread Mathieu Poirier
Hi Christophe, On Sun, Jan 14, 2024 at 10:37:43AM +0100, Christophe JAILLET wrote: > ida_alloc() and ida_free() should be preferred to the deprecated > ida_simple_get() and ida_simple_remove(). > > Note that the upper limit of ida_simple_get() is exclusive, but the one of > ida_alloc_max() is

Re: [PATCH v4 1/2] remoteproc: Make rproc_get_by_phandle() work for clusters

2024-01-15 Thread Mathieu Poirier
Hi Tanmay, Thanks for the refactoring, this is in line with what Bjorn and I have talked about at Plumbers. Please see my comments below. On Wed, Jan 03, 2024 at 02:11:24PM -0800, Tanmay Shah wrote: > From: Mathieu Poirier > > Multi-cluster remoteproc designs typically have the fol

Re: [PATCH V3] remoteproc: virtio: Fix wdg cannot recovery remote processor

2024-01-10 Thread Mathieu Poirier
Good day Joakim, On Sun, Dec 17, 2023 at 01:36:59PM +0800, joakim.zh...@cixtech.com wrote: > From: Joakim Zhang > > Recovery remote processor failed when wdg irq received: > [0.842574] remoteproc remoteproc0: crash detected in cix-dsp-rproc: type > watchdog > [0.842750] remoteproc

Re: [PATCH v8 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-08 Thread Mathieu Poirier
On Thu, 4 Jan 2024 at 09:14, Tanmay Shah wrote: > > > On 1/3/24 12:17 PM, Mathieu Poirier wrote: > > On Fri, Dec 15, 2023 at 03:57:25PM -0800, Tanmay Shah wrote: > > > ZynqMP TCM information is fixed in driver. Now ZynqMP TCM information > > > > s/"

Re: [PATCH v8 3/3] remoteproc: zynqmp: parse TCM from device tree

2024-01-03 Thread Mathieu Poirier
On Fri, Dec 15, 2023 at 03:57:25PM -0800, Tanmay Shah wrote: > ZynqMP TCM information is fixed in driver. Now ZynqMP TCM information s/"is fixed in driver"/"was fixed in driver" > is available in device-tree. Parse TCM information in driver > as per new bindings. > > Signed-off-by: Tanmay Shah

Re: [PATCH v8 2/3] dts: zynqmp: add properties for TCM in remoteproc

2024-01-03 Thread Mathieu Poirier
Hi Tanmay, On Fri, Dec 15, 2023 at 03:57:24PM -0800, Tanmay Shah wrote: > Add properties as per new bindings in zynqmp remoteproc node > to represent TCM address and size. > > This patch also adds alternative remoteproc node to represent > remoteproc cluster in split mode. By default lockstep

Re: [PATCH 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-03 Thread Mathieu Poirier
On Wed, 3 Jan 2024 at 03:11, Ulf Hansson wrote: > > On Tue, 2 Jan 2024 at 19:41, Mathieu Poirier > wrote: > > > > Hi Ulf, > > > > I'm in agreement with the modifications done to imx_rproc.c and > > imx_dsp_rproc.c. > > There is one thing I am am

Re: [RESEND PATCH v3 1/2] remoteproc: Make rproc_get_by_phandle() work for clusters

2024-01-02 Thread Mathieu Poirier
On Wed, Dec 20, 2023 at 08:47:19AM -0600, Tanmay Shah wrote: > > On 11/14/23 10:23 AM, Mathieu Poirier wrote: > > On Tue, 14 Nov 2023 at 08:22, Bjorn Andersson wrote: > > > > > > On Sat, Oct 14, 2023 at 04:15:47PM -0700, Tanmay Shah wrote: > > > > Fr

Re: [PATCH 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-02 Thread Mathieu Poirier
erting into using dev_pm_domain_attach|detach_list(). > > Cc: Mathieu Poirier > Cc: Bjorn Andersson > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: > Signed-off-by: Ulf Hansson > --- > drivers/remoteproc/imx_rproc.c | 73 +- > 1 file ch

Re: [PATCH v8 2/3] dts: zynqmp: add properties for TCM in remoteproc

2023-12-23 Thread Mathieu Poirier
On Wed, 20 Dec 2023 at 07:45, Tanmay Shah wrote: > > > On 12/20/23 7:14 AM, Michal Simek wrote: > > > > On 12/16/23 00:57, Tanmay Shah wrote: > > > Add properties as per new bindings in zynqmp remoteproc node > > > to represent TCM address and size. > > > > > > This patch also adds alternative

Re: [PATCH] rpmsg: virtio: free driver_override when rpmsg_remove()

2023-12-18 Thread Mathieu Poirier
On Fri, Dec 15, 2023 at 10:00:49AM +0800, Xiaolei Wang wrote: > free driver_override when rpmsg_remove(), otherwise > the following memory leak will occur: > > unreferenced object 0xd55d7080 (size 128): > comm "kworker/u8:2", pid 56, jiffies 4294893188 (age 214.272s) > hex dump (first

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-12-08 Thread Mathieu Poirier
On Wed, Dec 06, 2023 at 12:06:45PM -0600, Tanmay Shah wrote: > > On 12/6/23 9:43 AM, Mathieu Poirier wrote: > > On Fri, 1 Dec 2023 at 11:10, Tanmay Shah wrote: > > > > > > > > > On 11/29/23 11:10 AM, Mathieu Poirier wrote: > > > > On Mon,

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-12-06 Thread Mathieu Poirier
On Fri, 1 Dec 2023 at 11:10, Tanmay Shah wrote: > > > On 11/29/23 11:10 AM, Mathieu Poirier wrote: > > On Mon, Nov 27, 2023 at 10:33:05AM -0600, Tanmay Shah wrote: > > > > > > On 11/23/23 12:11 PM, Mathieu Poirier wrote: > > > > On Wed, Nov 22

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-27 Thread Mathieu Poirier
ulator/mps,mpq7920.yaml| 4 ++-- > .../devicetree/bindings/remoteproc/fsl,imx-rproc.yaml | 8 Reviewed-by: Mathieu Poirier > 14 files changed, 27 insertions(+), 27 deletions(-) > > diff --git a/Documentation/devicetree/bindings/auxdisplay/hit,hd44780.yaml > b/D

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-11-23 Thread Mathieu Poirier
On Wed, Nov 22, 2023 at 03:00:36PM -0600, Tanmay Shah wrote: > Hi Mathieu, > > Please find my comments below. > > On 11/21/23 4:59 PM, Mathieu Poirier wrote: > > Hi, > > > > On Fri, Nov 17, 2023 at 09:42:37AM -0800, Tanmay Shah wrote: > > > Use

Re: [PATCH v7 4/4] remoteproc: zynqmp: parse TCM from device tree

2023-11-22 Thread Mathieu Poirier
On Wed, Nov 22, 2023 at 10:51:08AM -0700, Mathieu Poirier wrote: > On Fri, Nov 17, 2023 at 09:42:38AM -0800, Tanmay Shah wrote: > > ZynqMP TCM information is fixed in driver. Now ZynqMP TCM information > > is available in device-tree. Parse TCM information in driver > >

Re: [PATCH v7 4/4] remoteproc: zynqmp: parse TCM from device tree

2023-11-22 Thread Mathieu Poirier
On Fri, Nov 17, 2023 at 09:42:38AM -0800, Tanmay Shah wrote: > ZynqMP TCM information is fixed in driver. Now ZynqMP TCM information > is available in device-tree. Parse TCM information in driver > as per new bindings. > > Signed-off-by: Tanmay Shah > --- > > Changes in v7: > - move checking

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-11-22 Thread Mathieu Poirier
On Fri, Nov 17, 2023 at 09:42:37AM -0800, Tanmay Shah wrote: > Use TCM pm domains extracted from device-tree > to power on/off TCM using general pm domain framework. > > Signed-off-by: Tanmay Shah > --- > > Changes in v7: > - %s/pm_dev1/pm_dev_core0/r > - %s/pm_dev_link1/pm_dev_core0_link/r

Re: [PATCH v7 3/4] remoteproc: zynqmp: add pm domains support

2023-11-21 Thread Mathieu Poirier
Hi, On Fri, Nov 17, 2023 at 09:42:37AM -0800, Tanmay Shah wrote: > Use TCM pm domains extracted from device-tree > to power on/off TCM using general pm domain framework. > > Signed-off-by: Tanmay Shah > --- > > Changes in v7: > - %s/pm_dev1/pm_dev_core0/r > -

Re: [PATCH v4 0/2] Rpmsg support for i.MX DSP with resource table

2023-11-20 Thread Mathieu Poirier
On Fri, Oct 13, 2023 at 06:27:29PM +0300, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > These patches are needed in order to support rpmsg on DSP when a > resource table is available. > > Changes since v3: > - add reserve-memory nodes in imx8mp-evk.dts rather than .dtsi (patch 2/2) >

Re: [RESEND PATCH v3 1/2] remoteproc: Make rproc_get_by_phandle() work for clusters

2023-11-14 Thread Mathieu Poirier
On Tue, 14 Nov 2023 at 08:22, Bjorn Andersson wrote: > > On Sat, Oct 14, 2023 at 04:15:47PM -0700, Tanmay Shah wrote: > > From: Mathieu Poirier > > > > Multi-cluster remoteproc designs typically have the following DT > > declaration: &g

Re: [PATCH v3 3/5] remoteproc: k3-r5: Add support for IPC-only mode for all R5Fs

2023-11-02 Thread Mathieu Poirier
Hi Jan, On Thu, Nov 02, 2023 at 11:07:45AM +0100, Jan Kiszka wrote: > On 13.02.22 21:12, Suman Anna wrote: > > Add support to the K3 R5F remoteproc driver to configure all the R5F > > cores to be either in IPC-only mode or the traditional remoteproc mode. > > The IPC-only mode expects that the

Re: [PATCH v4 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-10-23 Thread Mathieu Poirier
Hey guys, On Fri, Oct 13, 2023 at 06:27:31PM +0300, Iuliana Prodan (OSS) wrote: > From: Iuliana Prodan > > Add the reserve-memory nodes used by DSP when the rpmsg > feature is enabled. > > Signed-off-by: Iuliana Prodan > --- > arch/arm64/boot/dts/freescale/imx8mp-evk.dts | 22

Re: [PATCH v6 3/4] remoteproc: zynqmp: add pm domains support

2023-10-18 Thread Mathieu Poirier
Good morning, On Thu, Oct 12, 2023 at 09:22:28PM -0700, Tanmay Shah wrote: > Use TCM pm domains extracted from device-tree > to power on/off TCM using general pm domain framework. > > Signed-off-by: Tanmay Shah > --- > > Changes in v6: > - Remove spurious change > - Handle errors in

Re: [PATCH] dt-bindings: Drop kernel copy of common reserved-memory bindings

2023-10-16 Thread Mathieu Poirier
te processor (e.g. remoteproc firmware and carveouts, rpmsg >vrings, ...). > - (see ../reserved-memory/reserved-memory.yaml) > + (see reserved-memory/reserved-memory.yaml in dtschema project) Reviewed-by: Mathieu Poirier > > required: >- compatib

Re: [PATCH] remoteproc: st: Use device_get_match_data()

2023-10-11 Thread Mathieu Poirier
On Mon, Oct 09, 2023 at 04:13:40PM -0500, Rob Herring wrote: > Use preferred device_get_match_data() instead of of_match_device() to > get the driver match data. With this, adjust the includes to explicitly > include the correct headers. > > Signed-off-by: Rob Herring > --- >

Re: [PATCH] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2023-10-04 Thread Mathieu Poirier
On Wed, 4 Oct 2023 at 07:51, Apurva Nandan wrote: > > Hi Mathieu, > > On 11/09/23 22:15, Mathieu Poirier wrote: > > Hi Apurva, > > > > On Wed, Sep 06, 2023 at 06:17:56PM +0530, Apurva Nandan wrote: > >> PSC controller has a limitation that it can only power

Re: [PATCH] remoteproc: zynqmp: change tcm address translation method

2023-09-29 Thread Mathieu Poirier
On Mon, Sep 25, 2023 at 10:26:48AM -0700, Tanmay Shah wrote: > Introduce device address in hardcode TCM table. > Device address is used for address translation. > Also, previous method(hack) to mask few bits from address > to achieve address translation is removed > > Signed-off-by: Tanmay Shah

Re: [PATCH] dt-bindings: remoteproc: mtk,scp: Add missing additionalProperties on child node schemas

2023-09-28 Thread Mathieu Poirier
Hi Rob, On Tue, Sep 26, 2023 at 11:45:08AM -0500, Rob Herring wrote: > Just as unevaluatedProperties or additionalProperties are required at > the top level of schemas, they should (and will) also be required for > child node schemas. That ensures only documented properties are > present for any

Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility

2023-09-21 Thread Mathieu Poirier
On Tue, Sep 19, 2023 at 11:23:36AM +0200, AngeloGioacchino Del Regno wrote: > In older devicetrees we had the ChromeOS EC in a node called "cros-ec" > instead of the newer "cros-ec-rpmsg", but this driver is now checking > only for the latter, breaking compatibility with those. > > Besides, we

Re: [PATCH] remoteproc: mediatek: Refactor single core check and fix retrocompatibility

2023-09-20 Thread Mathieu Poirier
On Tue, Sep 19, 2023 at 11:23:36AM +0200, AngeloGioacchino Del Regno wrote: > In older devicetrees we had the ChromeOS EC in a node called "cros-ec" > instead of the newer "cros-ec-rpmsg", but this driver is now checking > only for the latter, breaking compatibility with those. > > Besides, we

Re: [PATCH v17 00/14] Add support for MT8195 SCP 2nd core

2023-09-18 Thread Mathieu Poirier
On Mon, Sep 18, 2023 at 06:44:25PM +0800, Chen-Yu Tsai wrote: > On Mon, Sep 18, 2023 at 6:32 PM Laura Nao wrote: > > > > > Other than patch 2 and 14, I have applied this set. The remaining > > > patches will > > > have to be resent to Matthias. > > > > > Thanks, > > > Mathieu > > > > Hello, > >

Re: [PATCH v17 00/14] Add support for MT8195 SCP 2nd core

2023-09-18 Thread Mathieu Poirier
On Mon, Sep 18, 2023 at 12:31:41PM +0200, Laura Nao wrote: > > Other than patch 2 and 14, I have applied this set. The remaining patches > > will > > have to be resent to Matthias. > > > Thanks, > > Mathieu > > Hello, > > With patch 2 missing, the SCP is not probed correctly anymore on

Re: [PATCH v17 00/14] Add support for MT8195 SCP 2nd core

2023-09-13 Thread Mathieu Poirier
On Fri, Sep 01, 2023 at 04:09:21PM +0800, Tinghan Shen wrote: > The mediatek remoteproc driver currently only allows bringing up a > single core SCP, e.g. MT8183. It also only bringing up the 1st > core in SoCs with a dual-core SCP, e.g. MT8195. This series support > to bring-up the 2nd core of

Re: [PATCH 2/2] arm64: dts: imx8mp: add reserve-memory nodes for DSP

2023-09-12 Thread Mathieu Poirier
On Tue, Sep 12, 2023 at 01:51:42PM +0300, Iuliana Prodan wrote: > On 9/12/2023 12:36 PM, Krzysztof Kozlowski wrote: > > On 12/09/2023 10:49, Iuliana Prodan wrote: > > > > > Should I test this on other tree(s)? > > > > You test the patch on the tree you send it. What is the point to test it > > > >

Re: [PATCH] remoteproc: k3-r5: Wait for core0 power-up before powering up core1

2023-09-11 Thread Mathieu Poirier
Hi Apurva, On Wed, Sep 06, 2023 at 06:17:56PM +0530, Apurva Nandan wrote: > PSC controller has a limitation that it can only power-up the second core > when the first core is in ON state. Power-state for core0 should be equal > to or higher than core1, else the kernel is seen hanging during rproc

Re: [PATCH V4 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP

2021-04-16 Thread Mathieu Poirier
On Thu, Apr 15, 2021 at 09:27:33PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > V4: > Typo fix > patch 4: take state as a check condition > patch 5: move regmap lookup/attach to imx_rproc_detect_mode > patch 6: add imx_rproc_clk_enable for optional clk > patch 8: use switch/case

Re: [PATCH V4 7/8] remoteproc: imx_rproc: support i.MX7ULP

2021-04-16 Thread Mathieu Poirier
On Thu, Apr 15, 2021 at 09:27:40PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM > and powers most serivces used by A7 core, so A7 core has no power to s/serivces/services > start and stop M4 core. And the M4

Re: [PATCH V4 6/8] remoteproc: imx_rproc: make clk optional

2021-04-16 Thread Mathieu Poirier
rr(dev, "Failed to get clock\n"); > - ret = PTR_ERR(priv->clk); > - goto err_put_mbox; > - } > - > - /* > - * clk for M4 block including memory. Should be > - * enabled before .start for FW transfer. > - */

Re: [PATCH V4 5/8] remoteproc: imx_rproc: initial support for mutilple start/stop method

2021-04-16 Thread Mathieu Poirier
On Thu, Apr 15, 2021 at 09:27:38PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Add three methods IMX_RPROC_NONE(no need start/stop), IMX_RPROC_MMIO > (start/stop through mmio) and IMX_RPROC_SMC(start/stop through ARM SMCCC). > > The current SoCs supported are all using

Re: [PATCH V4 4/8] remoteproc: imx_rproc: parse fsl,auto-boot

2021-04-16 Thread Mathieu Poirier
DETACHED) > + rproc->auto_boot = of_property_read_bool(np, "fsl,auto-boot"); > + Reviewed-by: Mathieu Poirier > ret = rproc_add(rproc); > if (ret) { > dev_err(dev, "rproc_add failed\n"); > -- > 2.7.4 >

Re: [PATCH v2 0/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-16 Thread Mathieu Poirier
Hi James, On Fri, Apr 16, 2021 at 01:56:30PM +0300, James Clark wrote: > Changes since v1: > * Improved variable name from etm_timestamp -> cs_timestamp > * Fixed ordering of Signed-off-by > You forgot to add the RB and AB you received. Since Arnaldo is responsible for the perf tools

Re: [PATCH 0/1] coresight: Fix for v5.12-rc7

2021-04-16 Thread Mathieu Poirier
On Fri, 16 Apr 2021 at 01:36, Greg KH wrote: > > On Fri, Apr 16, 2021 at 08:54:00AM +0200, Greg KH wrote: > > On Thu, Apr 15, 2021 at 02:24:03PM -0600, Mathieu Poirier wrote: > > > Hi Greg, > > > > > > Please consider this patch as a fix for v5.12-rc7.

Re: [PATCH v7 00/10] CoreSight configuration management; ETM strobing

2021-04-15 Thread Mathieu Poirier
[...] > > Mike Leach (10): > coresight: syscfg: Initial coresight system configuration > coresight: syscfg: Add registration and feature loading for cs devices > coresight: config: Add configuration and feature generic functions > coresight: etm-perf: update to handle configuration

Re: [PATCH 0/7] Split Coresight decode by aux records

2021-04-15 Thread Mathieu Poirier
Hi James, On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: > Hi All, > > Since my previous RFC, I've fixed --per-thread mode and solved > most of the open questions. I've also changed --dump-raw-trace > to use the same code path so it's also working now. > > I think the only open

[PATCH 0/1] coresight: Fix for v5.12-rc7

2021-04-15 Thread Mathieu Poirier
Hi Greg, Please consider this patch as a fix for v5.12-rc7. Applies cleanly to your char-misc-linus branch (e49d033bddf5). Thanks, Mathieu Mike Leach (1): coresight: etm-perf: Fix define build issue when built as module drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +- 1 file

[PATCH 1/1] coresight: etm-perf: Fix define build issue when built as module

2021-04-15 Thread Mathieu Poirier
) to correct this. Fixes: 88f11864cf1d ("coresight: etm-perf: Support PID tracing for kernel at EL2") Signed-off-by: Mike Leach Reviewed-by: Leo Yan Link: https://lore.kernel.org/r/20210414194808.22872-1-mike.le...@linaro.org Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/cor

Re: [PATCH 2/2] perf cs-etm: Set time on synthesised samples to preserve ordering

2021-04-15 Thread Mathieu Poirier
gt; else if (event->header.type == PERF_RECORD_SWITCH_CPU_WIDE) > return cs_etm__process_switch_cpu_wide(etm, event); > > - if (!etm->timeless_decoding && > - event->header.type == PERF_RECORD_AUX) > + i

Re: [PATCH 1/2] perf cs-etm: Refactor timestamp variable names

2021-04-15 Thread Mathieu Poirier
stamp = sample->time; > else > - timestamp = 0; > + sample_kernel_timestamp = 0; > > - if (timestamp || etm->timeless_decoding) { > + if (sample_kernel_timestamp || etm->timeless_decoding) { > err = cs_et

Re: [GIT PULL] coresight: Fixes for ETE and TRBE

2021-04-13 Thread Mathieu Poirier
On Tue, 13 Apr 2021 at 10:52, Marc Zyngier wrote: > > Hi Mathieu, > > On Tue, 13 Apr 2021 17:19:52 +0100, > Mathieu Poirier wrote: > > > > The following changes since commit 4fb13790417a7bf726f3867a5d2b9723efde488b: > > > > dts: bindings: Document device

Re: [PATCH V3 8/8] remoteproc: imx_rproc: support i.MX8MN/P

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:58AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Add i.MX8MN/P remote processor(Cortex-M7) support, we are using ARM > SMCCC to start/stop M core, not using regmap interface. > > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 89

Re: [PATCH V3 7/8] remoteproc: imx_rproc: support i.MX7ULP

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:57AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > i.MX7ULP A7 core runs under control of M4 core, M4 core starts by ROM > and powers most serivces used by A7 core, so A7 core has no power to > start and stop M4 core. > > Signed-off-by: Peng Fan > --- >

Re: [PATCH V3 6/8] remoteproc: imx_rproc: initial support for mutilple start/stop method

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:56AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Add three methods IMX_RPROC_NONE(no need start/stop), IMX_RPROC_MMIO > (start/stop through mmio) and IMX_RPROC_SMC(start/stop through ARM SMCCC). > > The current SoCs supported are all using

Re: [PATCH V3 5/8] remoteproc: imx_rproc: parse fsl,auto-boot

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:55AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Parse fsl,auto-boot to indicate whether need remoteproc framework > auto boot or not. > > When remote processor is booted before Linux Kernel up, do not parse > fsl,auto-boot. So add an entry to store the

Re: [PATCH V3 4/8] remoteproc: imx_rproc: make clk optional

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:54AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > To i.MX7ULP, M4 is the master to control everything, so it not need > clk from A7. > > Reviewed-by: Richard Zhu > Signed-off-by: Peng Fan > --- > drivers/remoteproc/imx_rproc.c | 2 +- > 1 file

Re: [PATCH V3 2/8] dt-bindings: remoteproc: imx_rproc: add i.MX7ULP support

2021-04-13 Thread Mathieu Poirier
On Thu, Apr 08, 2021 at 09:54:52AM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Add i.MX7ULP compatible. > > We use i.MX7ULP dual mode and in which case i.MX7ULP A7 core runs under > control of M4 core, M4 core starts by ROM and powers most serivces used s/serivces/services > by A7

Re: [PATCH -next v2] coresight: trbe: Fix return value check in arm_trbe_register_coresight_cpu()

2021-04-13 Thread Mathieu Poirier
On Fri, Apr 09, 2021 at 09:49:01AM +, Wei Yongjun wrote: > In case of error, the function devm_kasprintf() returns NULL > pointer not ERR_PTR(). The IS_ERR() test in the return value > check should be replaced with NULL test. > > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- >

[GIT PULL] coresight: Fixes for ETE and TRBE

2021-04-13 Thread Mathieu Poirier
The following changes since commit 4fb13790417a7bf726f3867a5d2b9723efde488b: dts: bindings: Document device tree bindings for Arm TRBE (2021-04-06 16:05:38 -0600) are available in the Git repository at: g...@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE

Re: [PATCH 0/7] Restructure the rpmsg char and introduce the rpmsg-raw channel

2021-04-12 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 01:27:30PM +0100, Arnaud Pouliquen wrote: > This series is the second step in the division of the series [1]: > "Introducing a Generic IOCTL Interface for RPMsg Channel Management". > > The purpose of this patchset is to: > - split the control code related to the control

Re: [PATCH 5/7] rpmsg: char: Introduce a rpmsg driver for the rpmsg char device

2021-04-12 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 01:27:35PM +0100, Arnaud Pouliquen wrote: > A rpmsg char device allows to probe the endpoint device on a remote name > service announcement. > > With this patch the /dev/rpmsgX interface is created either by a user > application or by the remote firmware. > >

Re: [PATCH v6 09/10] coresight: syscfg: Add initial configfs support

2021-04-12 Thread Mathieu Poirier
/hwtracing/coresight/coresight-syscfg-configfs.h > Reviewed-by: Mathieu Poirier > diff --git a/drivers/hwtracing/coresight/Makefile > b/drivers/hwtracing/coresight/Makefile > index ad44f0fe3069..b6c4a48140ec 100644 > --- a/drivers/hwtracing/coresight/Makefile > +

Re: [PATCH 4/7] rpmsg: char: Introduce __rpmsg_chrdev_create_eptdev function

2021-04-09 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 01:27:34PM +0100, Arnaud Pouliquen wrote: > Introduce the __rpmsg_chrdev_create_eptdev internal function that returns > the rpmsg_eptdev context structure. > > This patch prepares the introduction of a rpmsg channel device for the > char device. The rpmsg device will need

Re: [PATCH 2/7] rpmsg: Move the rpmsg control device from rpmsg_char to rpmsg_ctrl

2021-04-09 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 01:27:32PM +0100, Arnaud Pouliquen wrote: > Create the rpmsg_ctrl.c module and move the code related to the > rpmsg_ctrldev device in this new module. > > Add the dependency between rpmsg_char and rpmsg_ctrl in the > kconfig file. > > Signed-off-by: Arnaud Pouliquen >

Re: [PATCH V2 4/4] remoteproc: imx_rproc: support remote cores booted before Linux Kernel

2021-04-07 Thread Mathieu Poirier
> + if (ret) { > + dev_err(dev, "Failed to read src\n"); > + return ret; > + } > + > + if (!(val & dcfg->src_stop)) > + priv->rproc->state = RPROC_DETACHED; > + > + return 0; > +} > + >

Re: [PATCH V2 3/4] remoteproc: imx: move memory parsing to rproc_ops

2021-04-07 Thread Mathieu Poirier
On Tue, Mar 30, 2021 at 01:30:34PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Use the rproc_ops::prepare() hook for doing memory resources > reallocation when reattach an remote procesor. s/when reattach an remote/when reattaching a remote/ > > Suggested-b

Re: [PATCH V2 3/4] remoteproc: imx: move memory parsing to rproc_ops

2021-04-07 Thread Mathieu Poirier
On Tue, Mar 30, 2021 at 01:30:34PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > Use the rproc_ops::prepare() hook for doing memory resources > reallocation when reattach an remote procesor. > > Suggested-by: Mathieu Poirier > Signed-off-by: Peng Fan > -

Re: [PATCH V2 1/4] remoteproc: imx: add missing of_node_put

2021-04-07 Thread Mathieu Poirier
On Tue, Mar 30, 2021 at 01:30:32PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > After of_parse_phandle, we need of_node_put to decrease the refcount > of the device_node. > > Reported-by: Mathieu Poirier > Signed-off-by: Peng Fan > --- > drivers/remotep

Re: [PATCH V2 0/8] remoteproc: imx_rproc: support i.MX7ULP/8MN/8MP

2021-04-07 Thread Mathieu Poirier
On Tue, Mar 30, 2021 at 05:12:46PM +0800, peng@oss.nxp.com wrote: > From: Peng Fan > > V2: > Patch 1/8, use fsl as vendor, typo fix > Because patchset [1] has v2 version, patch 5,6,7,8 are adapted that change. > > This patchset is to support i.MX7ULP/8MN/8MP, also includes a patch to

Re: [PATCH v2 3/3] remoteproc: pru: Fix and cleanup firmware interrupt mapping logic

2021-04-07 Thread Mathieu Poirier
ixed two additional cleanup paths in pru_handle_intrmap() >addressing Mathieu's review comment > v1: > https://patchwork.kernel.org/project/linux-remoteproc/patch/20210323223839.17464-4-s-a...@ti.com/ > > drivers/remoteproc/pru_rproc.c | 22 +++++++++- > 1 fil

<    1   2   3   4   5   6   7   8   9   10   >