[PATCH 4/4] MAINTAINERS: Add CoreSight header files

2021-04-07 Thread Mathieu Poirier
Adding CoreSight headers to the list of supported files so that maintainers can be notified when changes are submitted. Link: https://lore.kernel.org/r/20210326155431.2011889-1-mathieu.poir...@linaro.org Signed-off-by: Mathieu Poirier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 3/4] coresight: core: Fix typo in coresight-core.c

2021-04-07 Thread Mathieu Poirier
From: Qi Liu Fix the following checkpatch warning: WARNING: 'compoment' may be misspelled - perhaps 'component'? Link: https://lore.kernel.org/r/1616487086-50418-1-git-send-email-liuqi...@huawei.com Signed-off-by: Qi Liu Signed-off-by: Suzuki K Poulose ---

[PATCH 2/4] coresight: etm: perf: Make symbol 'format_attr_contextid' static

2021-04-07 Thread Mathieu Poirier
From: Wei Yongjun The sparse tool complains as follows: drivers/hwtracing/coresight/coresight-etm-perf.c:61:25: warning: symbol 'format_attr_contextid' was not declared. Should it be static? This symbol is not used outside of coresight-etm-perf.c, so this commit marks it static. Reported-by:

[PATCH 1/4] coresight: etm4x: Add ETM PID for Cortex-A78

2021-04-07 Thread Mathieu Poirier
From: Sai Prakash Ranjan Add ETM PID for Cortex-A78 to the list of supported ETMs. Link: https://lore.kernel.org/r/20210213112829.26834-1-saiprakash.ran...@codeaurora.org Reviewed-by: Mike Leach Signed-off-by: Sai Prakash Ranjan Signed-off-by: Suzuki K Poulose ---

[PATCH 0/4] coresight: Patches for v5.13

2021-04-07 Thread Mathieu Poirier
code. We'll see when we get there. Thanks, Mathieu Mathieu Poirier (1): MAINTAINERS: Add CoreSight header files Qi Liu (1): coresight: core: Fix typo in coresight-core.c Sai Prakash Ranjan (1): coresight: etm4x: Add ETM PID for Cortex-A78 Wei Yongjun (1): coresight: etm: perf: Make

Re: [PATCH 3/3] remoteproc: pru: Fix and cleanup firmware interrupt mapping logic

2021-04-06 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 05:38:39PM -0500, Suman Anna wrote: > The PRU firmware interrupt mappings are configured and unconfigured in > .start() and .stop() callbacks respectively using the variables 'evt_count' > and a 'mapped_irq' pointer. These variables are modified only during these >

Re: [PATCH 2/3] remoteproc: pru: Fix wrong success return value for fw events

2021-04-06 Thread Mathieu Poirier
is incorrect value as is, letting the pru_rproc_start() interpret it > as a success and boot the PRU. > Very subtle... I had to look twice to make sure. Reviewed-by: Mathieu Poirier > Fix this by returning an error value back upon any such failure. While > at this, revise the e

Re: [PATCH 1/3] remoteproc: pru: Fixup interrupt-parent logic for fw events

2021-04-06 Thread Mathieu Poirier
) { > kfree(pru->mapped_irq); > return -ENODEV; > @@ -337,11 +344,13 @@ static int pru_handle_intrmap(struct rproc *rproc) > goto map_fail; > } > } > + of_node_put(irq_parent); > > return ret; > > map_fail: > pru_dispose_irq_mapping(pru); > + of_node_put(irq_parent); Reviewed-by: Mathieu Poirier > > return ret; > } > -- > 2.30.1 >

[GIT PULL v2] coresight: Add support for ETE and TRBE

2021-04-06 Thread Mathieu Poirier
The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c: KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE for

Re: [GIT PULL] coresight: Add support for ETE and TRBE

2021-04-06 Thread Mathieu Poirier
On Tue, 6 Apr 2021 at 02:22, Marc Zyngier wrote: > > Hi Mathieu, > > On Mon, 05 Apr 2021 20:17:57 +0100, > Mathieu Poirier wrote: > > > > The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c: > > > > KVM: arm64: Disable guest acce

Re: [PATCH v5 09/10] coresight: syscfg: Add initial configfs support

2021-04-05 Thread Mathieu Poirier
On Tue, Mar 16, 2021 at 06:03:59PM +, Mike Leach wrote: > Adds configfs subsystem and attributes to the configuration manager > to enable the listing of loaded configurations and features. > > The default values of feature parameters can be accessed and altered > from these attributes to

[GIT PULL] coresight: Add support for ETE and TRBE

2021-04-05 Thread Mathieu Poirier
The following changes since commit a354a64d91eec3e0f8ef0eed575b480fd75b999c: KVM: arm64: Disable guest access to trace filter controls (2021-03-24 17:26:38 +) are available in the Git repository at: g...@gitolite.kernel.org:pub/scm/linux/kernel/git/coresight/linux.git next-ETE-TRBE

Re: [PATCH v5 08/10] coresight: config: Add preloaded configurations

2021-04-01 Thread Mathieu Poirier
644 drivers/hwtracing/coresight/coresight-cfg-afdo.c > create mode 100644 drivers/hwtracing/coresight/coresight-cfg-preload.c > create mode 100644 drivers/hwtracing/coresight/coresight-cfg-preload.h > Reviewed-by: Mathieu Poirier > diff --git a/drivers/hwtracing/coresigh

Re: [PATCH v5 07/10] coresight: etm4x: Add complex configuration handlers to etmv4

2021-04-01 Thread Mathieu Poirier
gt; 5 files changed, 238 insertions(+), 3 deletions(-) > create mode 100644 drivers/hwtracing/coresight/coresight-etm4x-cfg.c > create mode 100644 drivers/hwtracing/coresight/coresight-etm4x-cfg.h > Reviewed-by: Mathieu Poirier > diff --git a/drivers/hwtracing/coresight/Makefile

Re: [PATCH v5 06/10] coresight: etm-perf: Update to activate selected configuration

2021-04-01 Thread Mathieu Poirier
On Tue, Mar 16, 2021 at 06:03:56PM +, Mike Leach wrote: > Add calls to activate the selected configuration as perf starts > and stops the tracing session. > > Signed-off-by: Mike Leach > Reviewed-by: Suzuki K Poulose Reviewed-by: Mathieu Poirier > --- > driver

Re: [PATCH v5 05/10] coresight: syscfg: Add API to activate and enable configurations

2021-04-01 Thread Mathieu Poirier
+ > 4 files changed, 134 insertions(+) > Reviewed-by: Mathieu Poirier > diff --git a/drivers/hwtracing/coresight/coresight-config.h > b/drivers/hwtracing/coresight/coresight-config.h > index 38fd1c71eb05..f1a5957a25c9 100644 > --- a/drivers/hwtracing/coresight/coresight-config.h

Re: [PATCH v5 04/10] coresight: etm-perf: update to handle configuration selection

2021-03-31 Thread Mathieu Poirier
dle) > return data->snk_config; > return NULL; > } > +int etm_perf_add_symlink_cscfg(struct device *dev, > +struct cscfg_config_desc *config_desc); > +void etm_perf_del_symlink_cscfg(struct cscfg_config_desc *config_desc); > #el

Re: [PATCH v5 03/10] coresight: config: Add configuration and feature generic functions

2021-03-30 Thread Mathieu Poirier
| 3 +- > 4 files changed, 286 insertions(+), 2 deletions(-) > create mode 100644 drivers/hwtracing/coresight/coresight-config.c > This patch is so much easier to review with a consistent naming convention... With the kernel test robot warning addressed: Reviewed-by: Mathieu

Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host

2021-03-30 Thread Mathieu Poirier
On Tue, 30 Mar 2021 at 10:47, Greg KH wrote: > > On Tue, Mar 30, 2021 at 10:33:51AM -0600, Mathieu Poirier wrote: > > On Tue, 30 Mar 2021 at 09:35, Greg KH wrote: > > > > > > On Tue, Mar 30, 2021 at 09:23:14AM -0600, Mathieu Poirier wrote: > > > > On Tue

Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host

2021-03-30 Thread Mathieu Poirier
On Tue, 30 Mar 2021 at 09:35, Greg KH wrote: > > On Tue, Mar 30, 2021 at 09:23:14AM -0600, Mathieu Poirier wrote: > > On Tue, Mar 30, 2021 at 11:38:18AM +0100, Suzuki K Poulose wrote: > > > On 26/03/2021 16:55, Mathieu Poirier wrote: > > > > On Tue, Mar 23, 2

Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host

2021-03-30 Thread Mathieu Poirier
On Tue, Mar 30, 2021 at 11:38:18AM +0100, Suzuki K Poulose wrote: > On 26/03/2021 16:55, Mathieu Poirier wrote: > > On Tue, Mar 23, 2021 at 12:06:35PM +, Suzuki K Poulose wrote: > > > For a nvhe host, the EL2 must allow the EL1&0 translation > > > regime for Tra

Re: [PATCH v5 02/10] coresight: syscfg: Add registration and feature loading for cs devices

2021-03-29 Thread Mathieu Poirier
nfig.h| 98 ++ > .../hwtracing/coresight/coresight-syscfg.c| 324 +- > .../hwtracing/coresight/coresight-syscfg.h| 19 + > include/linux/coresight.h | 5 + > 4 files changed, 445 insertions(+), 1 deletion(-) Reviewed-by: Mathieu Poir

Re: [PATCH v5 01/10] coresight: syscfg: Initial coresight system configuration

2021-03-29 Thread Mathieu Poirier
+} > + > +void cscfg_exit(void) > +{ > + cscfg_clear_device(); > +} > diff --git a/drivers/hwtracing/coresight/coresight-syscfg.h > b/drivers/hwtracing/coresight/coresight-syscfg.h > new file mode 100644 > index ..18be9b58cd0b > --- /dev/null >

Re: [PATCH v5 04/19] perf: aux: Add CoreSight PMU buffer formats

2021-03-29 Thread Mathieu Poirier
ORESIGHT format (indicates the Frame format) > - RAW format (indicates the format of the source) > > The default value is CORESIGHT format for all the records > (i,e == 0). Add the RAW format for others that use > raw format. > > Cc: Peter Zijlstra > Cc: Mike Leach > Cc

Re: [PATCH v2 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-29 Thread Mathieu Poirier
hunk >double-checking the dt ti,cluster-mode values in k3_r5_probe() > v1: > https://patchwork.kernel.org/project/linux-remoteproc/patch/20210318215842.8196-3-s-a...@ti.com/ > > drivers/remoteproc/ti_k3_r5_remoteproc.c | 149 ++- > 1 file changed, 120 in

Re: [PATCH] coresight-pmu.h: Fix a typo

2021-03-29 Thread Mathieu Poirier
On Fri, 26 Mar 2021 at 13:53, Bhaskar Chowdhury wrote: > > On 09:32 Fri 26 Mar 2021, Mathieu Poirier wrote: > >Hi Bhaskar, > > > >On Fri, Mar 26, 2021 at 07:52:44PM +0530, Bhaskar Chowdhury wrote: > >> > >> s/orignally/originally/ > >

Re: [PATCH v5 07/19] arm64: kvm: Enable access to TRBE support for host

2021-03-26 Thread Mathieu Poirier
> Cc: Mark Rutland > Cc: Anshuman Khandual > Acked-by: Mathieu Poirier > Signed-off-by: Suzuki K Poulose > --- > arch/arm64/include/asm/el2_setup.h | 13 + > arch/arm64/include/asm/kvm_arm.h | 2 ++ > arch/arm64/include/asm/kvm_host.h | 2 ++ >

Re: [PATCH v5 05/19] arm64: Add support for trace synchronization barrier

2021-03-26 Thread Mathieu Poirier
On Wed, Mar 24, 2021 at 05:40:39PM +, Marc Zyngier wrote: > On Wed, 24 Mar 2021 17:19:36 +, > Catalin Marinas wrote: > > > > On Wed, Mar 24, 2021 at 05:06:58PM +, Suzuki K Poulose wrote: > > > On 24/03/2021 16:30, Marc Zyngier wrote: > > > > > > > > OK, so we definitely do need these

[PATCH] MAINTAINERS: Add CoreSight header files

2021-03-26 Thread Mathieu Poirier
Adding CoreSight headers to the list of supported files so that maintainers can be notified when changes are submitted. Signed-off-by: Mathieu Poirier --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d92f85ca831d..caf7ad0bb12b 100644

Re: [PATCH] coresight-pmu.h: Fix a typo

2021-03-26 Thread Mathieu Poirier
Hi Bhaskar, On Fri, Mar 26, 2021 at 07:52:44PM +0530, Bhaskar Chowdhury wrote: > > s/orignally/originally/ Even if the change is trivial this changelog is insufficient. Moreover, if you found the problem with an automated tool, please add the name of the tool to the changelog. Thanks, Mathieu

Re: [PATCH 2/2] remoteproc: imx_rproc: support remote cores booted before Linux Kernel

2021-03-25 Thread Mathieu Poirier
On Fri, Mar 19, 2021 at 06:47:08PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > Support remote cores booted before Linux Kernel booting. > > Add rsc_table to hold the resource table published by remote cores > Add attach hook Missing a period "." and a new line between the paragraphs. >

Re: [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX

2021-03-25 Thread Mathieu Poirier
On Thu, Mar 25, 2021 at 05:00:42PM -0600, Mathieu Poirier wrote: > Hi Peng, > > On Fri, Mar 19, 2021 at 06:47:07PM +0800, Peng Fan (OSS) wrote: > > From: Peng Fan > > > > 8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32, > > and also ren

Re: [PATCH 1/2] remoteproc: imx_rproc: enlarge IMX7D_RPROC_MEM_MAX

2021-03-25 Thread Mathieu Poirier
Hi Peng, On Fri, Mar 19, 2021 at 06:47:07PM +0800, Peng Fan (OSS) wrote: > From: Peng Fan > > 8 is not enough when we need more, so enlarge IMX7D_RPROC_MEM_MAX to 32, > and also rename it to IMX_RPROC_MEM_MAX which make more sense. > > Signed-off-by: Peng Fan > --- >

Re: [PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-25 Thread Mathieu Poirier
On Tue, Mar 23, 2021 at 03:19:11PM -0600, Mathieu Poirier wrote: > Good day Arnaud, > > On Mon, Mar 22, 2021 at 10:26:51AM +0100, Arnaud Pouliquen wrote: > > From: Arnaud Pouliquen > > > > A mechanism similar to the shutdown mailbox signal is implemented to &g

Re: [PATCH 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-25 Thread Mathieu Poirier
On Thu, Mar 25, 2021 at 04:00:55PM -0500, Suman Anna wrote: > Hi Mathieu, > > On 3/25/21 12:30 PM, Mathieu Poirier wrote: > > Good morning, > > > > On Thu, Mar 18, 2021 at 04:58:42PM -0500, Suman Anna wrote: > >> The K3 AM64x SoC family has a revised R5F s

Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs

2021-03-25 Thread Mathieu Poirier
On Wed, 24 Mar 2021 at 11:09, Suman Anna wrote: > > On 3/23/21 6:20 PM, Mathieu Poirier wrote: > > On Mon, Mar 15, 2021 at 03:58:59PM -0500, Suman Anna wrote: > >> The K3 PRUs are 32-bit processors and in general have some limitations > >> in using the standard ARM

Re: [PATCH 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-25 Thread Mathieu Poirier
Good morning, On Thu, Mar 18, 2021 at 04:58:42PM -0500, Suman Anna wrote: > The K3 AM64x SoC family has a revised R5F sub-system and contains a > subset of the R5F clusters present on J721E SoCs. The K3 AM64x SoCs > only have two dual-core Arm R5F clusters/subsystems with 2 R5F cores > each

Re: [PATCH 2/2] remoteproc: k3-r5: Extend support to R5F clusters on AM64x SoCs

2021-03-24 Thread Mathieu Poirier
Good day Suman, On Thu, Mar 18, 2021 at 04:58:42PM -0500, Suman Anna wrote: > The K3 AM64x SoC family has a revised R5F sub-system and contains a > subset of the R5F clusters present on J721E SoCs. The K3 AM64x SoCs > only have two dual-core Arm R5F clusters/subsystems with 2 R5F cores > each

Re: [PATCH] remoteproc: pru: Fix firmware loading crashes on K3 SoCs

2021-03-23 Thread Mathieu Poirier
o Data RAMs as well for all K3 SoCs. > > Fixes: 1d39f4d19921 ("remoteproc: pru: Add support for various PRU cores on > K3 AM65x SoCs") > Signed-off-by: Suman Anna Probably a good idea to CC stable as well... Reviewed-by: Mathieu Poirier > --- > drivers/remoteproc/

Re: [PATCH v2 2/2] remoteproc: stm32: add capability to detach

2021-03-23 Thread Mathieu Poirier
quot;clean". Usually it means zero'ing out but in this case it means a re-initialisation of the original values. > *table_sz = RSC_TBL_SIZE; > return (struct resource_table *)ddata->rsc_va; > } > @@ -607,6 +640,7 @@ static const struct rproc_ops st_rproc_ops = { > .start = stm32_rproc_start, > .stop = stm32_rproc_stop, > .attach = stm32_rproc_attach, > + .detach = stm32_rproc_detach, With the above: Reviewed-by: Mathieu Poirier > .kick = stm32_rproc_kick, > .load = rproc_elf_load_segments, > .parse_fw = stm32_rproc_parse_fw, > -- > 2.17.1 >

Re: [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable

2021-03-22 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:33PM +, Suzuki K Poulose wrote: > If the CPU implements Arm v8.4 Trace filter controls (FEAT_TRF), > move the ETM to trace prohibited region using TRFCR, while disabling. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Anshuman Khandual >

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-22 Thread Mathieu Poirier
), > > >> an write pointer (TRBPTR_EL1) and a limit pointer (TRBLIMITR_EL1). But > > >> the > > >> access to the trace buffer could be prohibited by a higher exception > > >> level > > >> (EL3 or EL2), indicated by TRBIDR_EL1.P. The TRBE

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-22 Thread Mathieu Poirier
2), indicated by TRBIDR_EL1.P. The TRBE can also generate a CPU > private interrupt (PPI) on address translation errors and when the buffer > is full. Overall implementation here is inspired from the Arm SPE driver. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-19 Thread Mathieu Poirier
2), indicated by TRBIDR_EL1.P. The TRBE can also generate a CPU > private interrupt (PPI) on address translation errors and when the buffer > is full. Overall implementation here is inspired from the Arm SPE driver. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-19 Thread Mathieu Poirier
On Fri, 19 Mar 2021 at 04:34, Suzuki K Poulose wrote: > > Hi Mathieu, > > > On 18 Mar 2021, at 18:08, Mathieu Poirier > > wrote: > > > > Good morning, > > > > On Thu, Feb 25, 2021 at 07:35:42PM +, Suzuki K Poulose wrote: > >> From: Ans

Re: [PATCH v4 18/19] coresight: sink: Add TRBE driver

2021-03-18 Thread Mathieu Poirier
tion level > (EL3 or EL2), indicated by TRBIDR_EL1.P. The TRBE can also generate a CPU > private interrupt (PPI) on address translation errors and when the buffer > is full. Overall implementation here is inspired from the Arm SPE driver. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc

Re: [PATCH v4 17/19] coresight: core: Add support for dedicated percpu sinks

2021-03-17 Thread Mathieu Poirier
dent. > Build the path directly and skip connection scanning for such devices. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki K Poulose > Tested-by: Suzuki K Poulose > Reviewed-by: Suzuki K Poulose > Signed-off-by: Anshuman Khandual > [Moved the set/get percpu sink APIs f

Re: [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable

2021-03-17 Thread Mathieu Poirier
On Wed, Mar 17, 2021 at 10:44:51AM +, Suzuki K Poulose wrote: > Hi Mathieu > > On 3/16/21 7:30 PM, Mathieu Poirier wrote: > > On Thu, Feb 25, 2021 at 07:35:33PM +, Suzuki K Poulose wrote: > > > If the CPU implements Arm v8.4 Trace filter controls (FEAT_TRF), >

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-17 Thread Mathieu Poirier
On Mon, Mar 15, 2021 at 09:32:40PM +, Ben Levinsky wrote: > > > -Original Message- > From: Mathieu Poirier > Date: Monday, March 15, 2021 at 10:37 AM > To: Ben Levinsky > Cc: "devicet...@vger.kernel.org" , > "linux-remotep...@vger.kernel.

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-17 Thread Mathieu Poirier
[...] > > > +/* > > > + * zynqmp_r5_remoteproc_probe > > > + * > > > + * @pdev: domain platform device for R5 cluster > > > + * > > > + * called when driver is probed, for each R5 core specified in > DT, > > > + * setup as needed to do

Re: [PATCH v4 10/19] coresight: etm-perf: Allow an event to use different sinks

2021-03-16 Thread Mathieu Poirier
driver and matches the same subtype. Please note > that at anytime there can be only one ETM tracing the event. > > Adding support for different types of sinks for a single > event is complex and is not something that we expect > on a sane configuration. > > Cc: Mathieu

Re: [PATCH v4 09/19] coresight: etm4x: Move ETM to prohibited region for disable

2021-03-16 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:33PM +, Suzuki K Poulose wrote: > If the CPU implements Arm v8.4 Trace filter controls (FEAT_TRF), > move the ETM to trace prohibited region using TRFCR, while disabling. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Anshuman Khandual >

Re: [PATCH v4 08/19] arm64: kvm: Enable access to TRBE support for host

2021-03-16 Thread Mathieu Poirier
+++ > arch/arm64/kvm/hyp/nvhe/switch.c | 1 + > 7 files changed, 65 insertions(+), 4 deletions(-) > Acked-by: Mathieu Poirier > diff --git a/arch/arm64/include/asm/el2_setup.h > b/arch/arm64/include/asm/el2_setup.h > index d77d358f9395..bda918948471 1

Re: [PATCH v4 07/19] arm64: Add TRBE definitions

2021-03-16 Thread Mathieu Poirier
On Thu, Feb 25, 2021 at 07:35:31PM +, Suzuki K Poulose wrote: > From: Anshuman Khandual > > This adds TRBE related registers and corresponding feature macros. > > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Suzuki K Poulose > Reviewed-by: Suzuki K Poulose &

Re: [PATCH v4 02/19] perf: aux: Add CoreSight PMU buffer formats

2021-03-16 Thread Mathieu Poirier
gt; - RAW format (indicates the format of the source) > > The default value is CORESIGHT format for all the records > (i,e == 0). Add the RAW format for others that use > raw format. > > Cc: Peter Zijlstra > Cc: Mike Leach > Cc: Mathieu Poirier > Cc: Leo Yan > Cc: A

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-15 Thread Mathieu Poirier
On Thu, Mar 11, 2021 at 11:49:13PM +, Ben Levinsky wrote: > Hi Mathieu > > -Original Message- > From: Mathieu Poirier > Date: Tuesday, March 9, 2021 at 8:53 AM > To: Ben Levinsky > Cc: "devicet...@vger.kernel.org" , > "linux-remotep

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-15 Thread Mathieu Poirier
> > + > > +static void zynqmp_r5_cleanup_mbox(struct zynqmp_r5_rproc *z_rproc) > > +{ > > + mbox_free_channel(z_rproc->tx_chan); > > + mbox_free_channel(z_rproc->rx_chan); > > +} > > + > > +/** > > + * zynqmp_r5_probe - Probes ZynqMP R5 processor

Re: [PATCH v2] remoteproc: qcom_q6v5_mss: Validate p_filesz in ELF loader

2021-03-15 Thread Mathieu Poirier
, > + i, fw_name); > + ret = -EINVAL; > + release_firmware(seg_fw); > + memunmap(ptr); > + goto release_firmware; > + } > + Reviewed-by: Mathieu Poirier > release_firmware(seg_fw); > } > > -- > 2.29.2 >

Re: [PATCH] remoteproc: qcom: wcnss: Fix race with iris probe

2021-03-15 Thread Mathieu Poirier
> --- > drivers/remoteproc/qcom_wcnss.c | 52 > drivers/remoteproc/qcom_wcnss.h | 4 +- > drivers/remoteproc/qcom_wcnss_iris.c | 120 +++++------ > 3 files changed, 91 insertions(+), 85 deletions(-) Acked-by: Mathieu Poirier > > di

Re: [PATCH] remoteproc: qcom_q6v5_mss: Provide errors for firmware-name parsing

2021-03-15 Thread Mathieu Poirier
> 1, >hexagon_mdt_image); > - if (ret < 0 && ret != -EINVAL) > + if (ret < 0 && ret != -EINVAL) { > + dev_err(>dev, "unable to read mpss firmware-name\n"); > goto free_rproc; > + } Reviewed-by: Mathieu Poirier > > platform_set_drvdata(pdev, qproc); > > -- > 2.29.2 >

Re: [PATCH 0/6] rpmsg: enable the use of the rpmsg_char device for the Virtio backend

2021-03-15 Thread Mathieu Poirier
> include/linux/rpmsg.h | 3 +- > include/uapi/linux/rpmsg.h| 13 ++- > 6 files changed, 108 insertions(+), 13 deletions(-) Reviewed-by: Mathieu Poirier > > -- > 2.17.1 >

[PATCH v8 13/17] remoteproc: Properly deal with a kernel panic when attached

2021-03-12 Thread Mathieu Poirier
The panic handler operation of registered remote processors should also be called when remote processors have been attached to. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 6 +- 1 file changed, 5 insertions

[PATCH v8 16/17] remoteproc: Properly deal with a detach request when attached

2021-03-12 Thread Mathieu Poirier
This patch introduces the capability to detach a remote processor that has been attached to by the remoteproc core. For that to happen a rproc::ops::detach() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c

[PATCH v8 14/17] remoteproc: Properly deal with a start request when attached

2021-03-12 Thread Mathieu Poirier
This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the case with the running state, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Poirier

[PATCH v8 15/17] remoteproc: Properly deal with a stop request when attached

2021-03-12 Thread Mathieu Poirier
Allow a remote processor that was started by another entity to be switched off by the remoteproc core. For that to happen a rproc::ops::stop() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c | 3

[PATCH v8 17/17] remoteproc: Refactor function rproc_cdev_release()

2021-03-12 Thread Mathieu Poirier
Refactor function rproc_cdev_release() to take into account the current state of the remote processor when choosing the state to transition to. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_cdev.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

[PATCH v8 10/17] remoteproc: Introduce function rproc_detach()

2021-03-12 Thread Mathieu Poirier
Introduce function rproc_detach() to enable the remoteproc core to release the resources associated with a remote processor without stopping its operation. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 58

[PATCH v8 11/17] remoteproc: Properly deal with the resource table when detaching

2021-03-12 Thread Mathieu Poirier
-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- New for V8: - Checking return code for error in __rproc_datch(). --- drivers/remoteproc/remoteproc_core.c | 82 include/linux/remoteproc.h | 3 + 2 files changed, 85 insertions(+) diff --git a/drivers

[PATCH v8 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-12 Thread Mathieu Poirier
processor. From that point on the copy is used, as if the remote processor had been started by the remoteproc core. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen Reported-by: kernel test robot --- New for V8: - Removed variable @table_ptr as it served no purpose. --- drivers

[PATCH v8 09/17] remoteproc: Introduce function __rproc_detach()

2021-03-12 Thread Mathieu Poirier
te processor while the latter is kept operating. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.

[PATCH v8 04/17] remoteproc: Properly represent the attached state

2021-03-12 Thread Mathieu Poirier
-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 20 +--- drivers/remoteproc/remoteproc_sysfs.c | 5 + include/linux/remoteproc.h| 2 -- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git

[PATCH v8 08/17] remoteproc: Add new detach() remoteproc operation

2021-03-12 Thread Mathieu Poirier
Add an new detach() operation in order to support scenarios where the remoteproc core is going away but the remote processor is kept operating. This could be the case when the system is rebooted or when the platform driver is removed. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan

[PATCH v8 07/17] remoteproc: stm32: Move memory parsing to rproc_ops

2021-03-12 Thread Mathieu Poirier
From: Arnaud POULIQUEN Some actions such as memory resources reallocation are needed when trying to reattach a co-processor. Use the prepare() operation for these actions. Co-developed-by: Mathieu Poirier Signed-off-by: Mathieu Poirier Signed-off-by: Arnaud POULIQUEN --- drivers/remoteproc

[PATCH v8 05/17] remoteproc: Add new get_loaded_rsc_table() to rproc_ops

2021-03-12 Thread Mathieu Poirier
Add a new get_loaded_rsc_table() operation in order to support scenarios where the remoteproc core has booted a remote processor and detaches from it. When re-attaching to the remote processor, the core needs to know where the resource table has been placed in memory. Signed-off-by: Mathieu

[PATCH v8 06/17] remoteproc: stm32: Move resource table setup to rproc_ops

2021-03-12 Thread Mathieu Poirier
to be available at a later time than the platform driver's probe() function. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 141 +++ 1 file changed, 68 insertions(+), 73 deletions(-) diff --git a/drivers/remoteproc

[PATCH v8 03/17] remoteproc: Add new RPROC_ATTACHED state

2021-03-12 Thread Mathieu Poirier
Add a new RPROC_ATTACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_sysfs.c | 1

[PATCH v8 00/17] remoteproc: Add support for detaching a remote processor

2021-03-12 Thread Mathieu Poirier
to rproc_ops Mathieu Poirier (16): remoteproc: Remove useless check in rproc_del() remoteproc: Rename function rproc_actuate() remoteproc: Add new RPROC_ATTACHED state remoteproc: Properly represent the attached state remoteproc: Add new get_loaded_rsc_table() to rproc_ops remoteproc

[PATCH v8 02/17] remoteproc: Rename function rproc_actuate()

2021-03-12 Thread Mathieu Poirier
Rename function rproc_actuate() to rproc_attach(). That way it is easy to understand that it does the opposite of rproc_detach(). Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 8 1 file changed, 4

[PATCH v8 01/17] remoteproc: Remove useless check in rproc_del()

2021-03-12 Thread Mathieu Poirier
when in fact it no longer exist. Invariably calling rproc_shutdown() is fine since it will return immediately if the remote processor has already been switched off. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 4

Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M

2021-03-11 Thread Mathieu Poirier
On Thu, Mar 11, 2021 at 01:26:25AM +, Peng Fan (OSS) wrote: > Mathieu, > > > Subject: Re: [PATCH V13 00/10] remoteproc: imx_rproc: support iMX8MQ/M > > > > On Sat, Mar 06, 2021 at 07:24:15PM +0800, peng@oss.nxp.com wrote: > > > From: Peng Fan > > > > > > V13: > > > Add R-b tag from Rob

Re: [PATCH v7 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-11 Thread Mathieu Poirier
On Wed, Mar 10, 2021 at 05:53:04PM -0600, Bjorn Andersson wrote: > On Wed 10 Mar 15:10 CST 2021, Mathieu Poirier wrote: > > > When a remote processor that was attached to is stopped, special care > > must be taken to make sure the shutdown process is similar to what > >

[PATCH v7 05/17] remoteproc: Add new get_loaded_rsc_table() to rproc_ops

2021-03-10 Thread Mathieu Poirier
Add a new get_loaded_rsc_table() operation in order to support scenarios where the remoteproc core has booted a remote processor and detaches from it. When re-attaching to the remote processor, the core needs to know where the resource table has been placed in memory. Signed-off-by: Mathieu

[PATCH v7 17/17] remoteproc: Refactor function rproc_cdev_release()

2021-03-10 Thread Mathieu Poirier
Refactor function rproc_cdev_release() to take into account the current state of the remote processor when choosing the state to transition to. Signed-off-by: Mathieu Poirier --- New for V7: Keep the behavior of the shutdown operation in rproc_del() intact. --- drivers/remoteproc

[PATCH v7 16/17] remoteproc: Properly deal with a detach request when attached

2021-03-10 Thread Mathieu Poirier
This patch introduces the capability to detach a remote processor that has been attached to by the remoteproc core. For that to happen a rproc::ops::detach() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c

[PATCH v7 08/17] remoteproc: Add new detach() remoteproc operation

2021-03-10 Thread Mathieu Poirier
Add an new detach() operation in order to support scenarios where the remoteproc core is going away but the remote processor is kept operating. This could be the case when the system is rebooted or when the platform driver is removed. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan

[PATCH v7 04/17] remoteproc: Properly represent the attached state

2021-03-10 Thread Mathieu Poirier
-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 20 +--- drivers/remoteproc/remoteproc_sysfs.c | 5 + include/linux/remoteproc.h| 2 -- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git

[PATCH v7 15/17] remoteproc: Properly deal with a stop request when attached

2021-03-10 Thread Mathieu Poirier
Allow a remote processor that was started by another entity to be switched off by the remoteproc core. For that to happen a rproc::ops::stop() operation needs to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_cdev.c | 3

[PATCH v7 13/17] remoteproc: Properly deal with a kernel panic when attached

2021-03-10 Thread Mathieu Poirier
The panic handler operation of registered remote processors should also be called when remote processors have been attached to. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 6 +- 1 file changed, 5 insertions

[PATCH v7 12/17] remoteproc: Properly deal with the resource table when stopping

2021-03-10 Thread Mathieu Poirier
processor. From that point on the copy is used, as if the remote processor had been started by the remoteproc core. Signed-off-by: Mathieu Poirier --- New for V7: New Patch, used to be part of 11/16 in V6. --- drivers/remoteproc/remoteproc_core.c | 53 +++- 1 file changed, 52

[PATCH v7 14/17] remoteproc: Properly deal with a start request when attached

2021-03-10 Thread Mathieu Poirier
This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the case with the running state, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Poirier

[PATCH v7 01/17] remoteproc: Remove useless check in rproc_del()

2021-03-10 Thread Mathieu Poirier
when in fact it no longer exist. Invariably calling rproc_shutdown() is fine since it will return immediately if the remote processor has already been switched off. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 4

[PATCH v7 09/17] remoteproc: Introduce function __rproc_detach()

2021-03-10 Thread Mathieu Poirier
te processor while the latter is kept operating. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 30 1 file changed, 30 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.

[PATCH v7 11/17] remoteproc: Properly deal with the resource table when detaching

2021-03-10 Thread Mathieu Poirier
-by: Mathieu Poirier --- New for V7: New Patch, used to be part of 11/16 in V6. --- drivers/remoteproc/remoteproc_core.c | 77 include/linux/remoteproc.h | 3 ++ 2 files changed, 80 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers

[PATCH v7 10/17] remoteproc: Introduce function rproc_detach()

2021-03-10 Thread Mathieu Poirier
Introduce function rproc_detach() to enable the remoteproc core to release the resources associated with a remote processor without stopping its operation. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 58

[PATCH v7 07/17] remoteproc: stm32: Move memory parsing to rproc_ops

2021-03-10 Thread Mathieu Poirier
From: Arnaud POULIQUEN Some actions such as memory resources reallocation are needed when trying to reattach a co-processor. Use the prepare() operation for these actions. Co-developed-by: Mathieu Poirier Signed-off-by: Mathieu Poirier Signed-off-by: Arnaud POULIQUEN --- drivers/remoteproc

[PATCH v7 06/17] remoteproc: stm32: Move resource table setup to rproc_ops

2021-03-10 Thread Mathieu Poirier
to be available at a later time than the platform driver's probe() function. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/stm32_rproc.c | 141 +++ 1 file changed, 68 insertions(+), 73 deletions(-) diff --git a/drivers/remoteproc

[PATCH v7 03/17] remoteproc: Add new RPROC_ATTACHED state

2021-03-10 Thread Mathieu Poirier
Add a new RPROC_ATTACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_sysfs.c | 1

[PATCH v7 02/17] remoteproc: Rename function rproc_actuate()

2021-03-10 Thread Mathieu Poirier
Rename function rproc_actuate() to rproc_attach(). That way it is easy to understand that it does the opposite of rproc_detach(). Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 8 1 file changed, 4

[PATCH v7 00/17] remoteproc: Add support for detaching a remote processor

2021-03-10 Thread Mathieu Poirier
(1): remoteproc: stm32: Move memory parsing to rproc_ops Mathieu Poirier (16): remoteproc: Remove useless check in rproc_del() remoteproc: Rename function rproc_actuate() remoteproc: Add new RPROC_ATTACHED state remoteproc: Properly represent the attached state remoteproc: Add new

Re: [PATCH v26 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2021-03-09 Thread Mathieu Poirier
[...] > + > +/** > + * zynqmp_r5_probe - Probes ZynqMP R5 processor device node > + * this is called for each individual R5 core to > + * set up mailbox, Xilinx platform manager unique ID, > + * add to rproc core > + * > + * @pdev: domain

<    1   2   3   4   5   6   7   8   9   10   >