[PATCH 12/15] coresight: tmc-etr: Check if page is valid before dma_map_page()

2020-11-27 Thread Mathieu Poirier
dev_attr_store sysfs_kf_write Cc: sta...@vger.kernel.org Fixes: 99443ea19e8b ("coresight: Add generic TMC sg table framework") Signed-off-by: Mao Jinlong Signed-off-by: Sai Prakash Ranjan Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/cor

[PATCH 08/15] coresight: Remove unnecessary THIS_MODULE of funnel and replicator driver

2020-11-27 Thread Mathieu Poirier
From: Qi Liu As THIS_MODULE has been set in platform_driver_register(), so remove it from static funnel driver and static replicator driver to avoid set it twice. Signed-off-by: Qi Liu Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-funnel.c | 2 +- drivers

[PATCH 14/15] coresight-tpiu: Fix W=1 warning in TPIU driver

2020-11-27 Thread Mathieu Poirier
for this component. on line 53 - I thought it was a doc line CC drivers/hwtracing/coresight/coresight-cpu-debug.o CC drivers/hwtracing/coresight/coresight-catu.o Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-tpiu.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 09/15] coresight: tmc-etf: Fix NULL ptr dereference in tmc_enable_etf_sink_perf()

2020-11-27 Thread Mathieu Poirier
-wide trace scenarios") Signed-off-by: Sai Prakash Ranjan Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-priv.h| 2 ++ drivers/hwtracing/coresight/coresight-tmc-etf.c | 4 +++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/hwtracing

[PATCH 15/15] coresight-stm: Fix W=1 warning in STM driver

2020-11-27 Thread Mathieu Poirier
in 'channel_space' Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-stm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwtracing/coresight/coresight-stm.c b/drivers/hwtracing/coresight/coresight-stm.c index b0ad912651a9..32d29704206b 100644

[PATCH 11/15] coresight: tmc-etr: Assign boolean values to a bool variable

2020-11-27 Thread Mathieu Poirier
From: Kaixu Xia Fix the following coccinelle warnings: ./drivers/hwtracing/coresight/coresight-tmc-etr.c:957:2-15: WARNING: Assignment of 0/1 to bool variable Fix them by assigning boolean values. Reported-by: Tosk Robot Signed-off-by: Kaixu Xia Signed-off-by: Mathieu Poirier --- drivers

[PATCH 13/15] coresight: Fix W=1 warnings in core framework

2020-11-27 Thread Mathieu Poirier
parameter or member 'sink' not described in '_coresight_build_path' CC drivers/hwtracing/coresight/coresight-cpu-debug.o CC drivers/hwtracing/coresight/coresight-catu.o Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-core.c | 8 +++- 1 file changed, 7

[PATCH 10/15] coresight: etb10: Fix possible NULL ptr dereference in etb_enable_perf()

2020-11-27 Thread Mathieu Poirier
where we cache PID in alloc_buffer() callback which is called as the part of etm_setup_aux(). Cc: sta...@vger.kernel.org Fixes: 75d7dbd38824 ("coresight: etb10: Add support for CPU-wide trace scenarios") Signed-off-by: Sai Prakash Ranjan Signed-off-by: Mathieu Poirier --- drivers

[PATCH 05/15] coresight: etm4x: Update TRCIDR3.NUMPROCS handling to match v4.2

2020-11-27 Thread Mathieu Poirier
From: Suzuki K Poulose Since ETMv4.2, TRCIDR3.NUMPROCS has been extended to a 5bit field by encoding the top 2 bits[4:3] in TRCIDR3.[13:12], which were RES0. Fix the driver to compute the field correctly for ETMv4.2+ Cc: Mike Leach Cc: Mathieu Poirier Signed-off-by: Suzuki K Poulose Signed

[PATCH 04/15] coresight: etm4x: Fix accesses to TRCCIDCTLR1

2020-11-27 Thread Mathieu Poirier
From: Suzuki K Poulose The TRCCIDCTLR1 is only implemented if TRCIDR4.NUMCIDC > 4. Don't touch the register if it is not implemented. Cc: sta...@vger.kernel.org Cc: Mathieu Poirier Cc: Mike Leach Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresi

[PATCH 07/15] coresight: etm4x: Handle TRCVIPCSSCTLR accesses

2020-11-27 Thread Mathieu Poirier
From: Suzuki K Poulose TRCVIPCSSCTLR is not present if the TRCIDR4.NUMPC > 0. Thus we should only access the register if it is present, preventing any undesired behavior. Cc: sta...@vger.kernel.org Signed-off-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresi

[PATCH 02/15] coresight: core: Remove unneeded semicolon

2020-11-27 Thread Mathieu Poirier
From: Zou Wei Fixes coccicheck warning: ./drivers/hwtracing/coresight/coresight-core.c:421:4-5: Unneeded semicolon Reported-by: Hulk Robot Signed-off-by: Zou Wei Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-core.c | 2 +- 1 file changed, 1 insertion(+), 1

[PATCH 01/15] coresight: etm4x: Skip setting LPOVERRIDE bit for qcom,skip-power-up

2020-11-27 Thread Mathieu Poirier
for such platforms. Cc: sta...@vger.kernel.org Fixes: 02510a5aa78d ("coresight: etm4x: Add support to skip trace unit power up") Signed-off-by: Sai Prakash Ranjan Reviewed-by: Suzuki K Poulose Signed-off-by: Mathieu Poirier --- drivers/hwtracing/coresight/coresight-etm4x-core.c | 2 +- 1 file

[PATCH 00/15] coresight: Patches for v5.11

2020-11-27 Thread Mathieu Poirier
variable Mao Jinlong (1): coresight: tmc-etr: Check if page is valid before dma_map_page() Mathieu Poirier (3): coresight: Fix W=1 warnings in core framework coresight-tpiu: Fix W=1 warning in TPIU driver coresight-stm: Fix W=1 warning in STM driver Qi Liu (1): coresight: Remove unnecessary

Re: [PATCH] remoteproc: Add a rproc_set_firmware() API

2020-11-26 Thread Mathieu Poirier
+ struct device *dev; > + int ret, len; > + char *p; > + > + if (!rproc || !fw_name) > + return -EINVAL; > + > + dev = rproc->dev.parent; Since rproc->dev is available might as well use it. This is what the current implement

Re: [PATCH v2 1/3] remoteproc: Fix unbalanced boot with sysfs for no auto-boot rprocs

2020-11-26 Thread Mathieu Poirier
On Fri, Nov 20, 2020 at 09:01:54PM -0600, Suman Anna wrote: > The remoteproc core performs automatic boot and shutdown of a remote > processor during rproc_add() and rproc_del() for remote processors > supporting 'auto-boot'. The remoteproc devices not using 'auto-boot' > require either a

[PATCH v3 04/15] remoteproc: Add new RPROC_ATTACHED state

2020-11-26 Thread Mathieu Poirier
Add a new RPROC_ATTACHED state to take into account scenarios where the remoteproc core needs to attach to a remote processor that is booted by another entity. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_sysfs.c | 1

[PATCH v3 06/15] remoteproc: Properly deal with a kernel panic when attached

2020-11-26 Thread Mathieu Poirier
The panic handler operation of registered remote processors should also be called when remote processors have been attached to. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 6 +- 1 file changed, 5 insertions

[PATCH v3 15/15] remoteproc: Refactor rproc delete and cdev release path

2020-11-26 Thread Mathieu Poirier
Refactor function rproc_del() and rproc_cdev_release() to take into account the policy specified in the device tree. Signed-off-by: Mathieu Poirier --- drivers/remoteproc/remoteproc_cdev.c | 13 +++- drivers/remoteproc/remoteproc_core.c | 30 ++-- include/linux

[PATCH v3 14/15] remoteproc: Properly deal with detach request

2020-11-26 Thread Mathieu Poirier
This patch introduces the capability to detach a remote processor that has been attached to or booted by the remoteproc core. For that to happen a rproc::ops::detach() operation need to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan --- drivers/remoteproc/remoteproc_cdev.c

[PATCH v3 13/15] remoteproc: Properly deal with a start request when attached

2020-11-26 Thread Mathieu Poirier
This patch takes into account scenarios where a remote processor has been attached to when receiving a "start" command from sysfs. As with the "running" case, the command can't be carried out if the remote processor is already in operation. Signed-off-by: Mathieu Poirier ---

[PATCH v3 12/15] remoteproc: Properly deal with a stop request when attached

2020-11-26 Thread Mathieu Poirier
This patch introduces the capability to stop a remote processor that has been attached to by the remoteproc core. For that to happen a rproc::ops::stop() operation need to be available. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc

[PATCH v3 00/15] remoteproc: Add support for detaching from rproc

2020-11-26 Thread Mathieu Poirier
processing of "start" command in state_store() and rproc_cdev_write(). - Changed binding from "autonomous-on-core-reboot" to "autonomous-on-core-shutdown". - Wrote a proper YAML file for the binding. Mathieu Poirier (15): dt-bindings: remoteproc: Add bindind to su

[PATCH v3 10/15] remoteproc: Rename function rproc_actuate()

2020-11-26 Thread Mathieu Poirier
Align what was done for rproc_detach() by renaming function rproc_actuate(). That way it is easier to figure out the opposite of each functions. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 10 +- 1 file

[PATCH v3 02/15] remoteproc: Re-check state in rproc_shutdown()

2020-11-26 Thread Mathieu Poirier
The state of the remote processor may have changed between the time a call to rproc_shutdown() was made and the time it is executed. To avoid moving forward with an operation that may have been cancelled, recheck while holding the mutex. Cc: Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan

[PATCH v3 09/15] remoteproc: Introduce function rproc_detach()

2020-11-26 Thread Mathieu Poirier
Introduce function rproc_detach() to enable the remoteproc core to release the resources associated with a remote processor without stopping its operation. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan --- drivers/remoteproc/remoteproc_core.c | 65 +++- include

[PATCH v3 05/15] remoteproc: Properly represent the attached state

2020-11-26 Thread Mathieu Poirier
-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 20 +--- drivers/remoteproc/remoteproc_sysfs.c | 5 + include/linux/remoteproc.h| 2 -- 3 files changed, 2 insertions(+), 25 deletions(-) diff --git

[PATCH v3 07/15] remoteproc: Add new detach() remoteproc operation

2020-11-26 Thread Mathieu Poirier
Add an new detach() operation in order to support scenarios where the remoteproc core is going away but the remote processor is kept operating. This could be the case when the system is rebooted or when the platform driver is removed. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan

[PATCH v3 11/15] remoteproc: Add return value to function rproc_shutdown()

2020-11-26 Thread Mathieu Poirier
Add a return value to function rproc_shutdown() in order to properly deal with error conditions that may occur. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan --- drivers/remoteproc/remoteproc_core.c | 19 ++- include/linux/remoteproc.h | 2 +- 2 files changed

[PATCH v3 08/15] remoteproc: Introduce function __rproc_detach()

2020-11-26 Thread Mathieu Poirier
te processor while the latter is kept operating. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan --- drivers/remoteproc/remoteproc_core.c | 31 1 file changed, 31 insertions(+) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_

[PATCH v3 03/15] remoteproc: Remove useless check in rproc_del()

2020-11-26 Thread Mathieu Poirier
when in fact it no longer exist. Invariably calling rproc_shutdown() is fine since it will return immediately if the remote processor has already been switched off. Signed-off-by: Mathieu Poirier Reviewed-by: Peng Fan Reviewed-by: Arnaud Pouliquen --- drivers/remoteproc/remoteproc_core.c | 4

[PATCH v3 01/15] dt-bindings: remoteproc: Add bindind to support autonomous processors

2020-11-26 Thread Mathieu Poirier
if "autonomous-on-core-reboot" is specified in the remote processor DT node, the remoteproc core will detach the remote processor rather than switching it off. Signed-off-by: Mathieu Poirier --- .../bindings/remoteproc/remoteproc-core.yaml | 25 +++ 1 file changed, 25

[PATCH] MAINTAINERS: Adding help for coresight subsystem

2020-11-25 Thread Mathieu Poirier
-by: Mathieu Poirier --- MAINTAINERS | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index e73636b75f29..8d0b008c7781 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1723,11 +1723,13 @@ F: arch/arm/mach-ep93xx/micro9.c ARM/CORESIGHT FRAMEWORK

Re: [PATCH 3/3] remoteproc: k3-r5: Adjust TCM sizes in Split-mode on J7200 SoCs

2020-11-23 Thread Mathieu Poirier
On Mon, 23 Nov 2020 at 16:51, Mathieu Poirier wrote: > > Good afternoon Suman, > > On Wed, Nov 18, 2020 at 07:05:31PM -0600, Suman Anna wrote: > > The J7200 SoCs have a revised R5FSS IP that adds a unique feature w.r.t > > TCM sizing. Each R5F core in a cluster typicall

Re: [PATCH 3/3] remoteproc: k3-r5: Adjust TCM sizes in Split-mode on J7200 SoCs

2020-11-23 Thread Mathieu Poirier
m_init(kproc); > if (ret) { > dev_err(dev, "reserved memory init failed, ret = %d\n", > @@ -1407,10 +1448,12 @@ static int k3_r5_probe(struct platform_device *pdev) > } > > static const struct k3_r5_soc_data am65_j721e_soc_data = { > + .tcm_is_double = false, > .tcm_ecc_autoinit = false, > }; > > static const struct k3_r5_soc_data j7200_soc_data = { > + .tcm_is_double = true, > .tcm_ecc_autoinit = true, With the above and for the set: Reviewed-by: Mathieu Poirier > }; > > -- > 2.28.0 >

Re: [PATCH] remoteproc: Add module parameter 'auto_boot'

2020-11-23 Thread Mathieu Poirier
On Sat, Nov 21, 2020 at 06:38:49PM +, Paul Cercueil wrote: > Hi Mathieu, > > Le ven. 20 nov. 2020 à 15:37, Mathieu Poirier a > écrit : > > Hi Paul, > > > > On Sun, Nov 15, 2020 at 11:50:56AM +, Paul Cercueil wrote: > > > Until now the remotep

Re: [PATCH] coresight: tmc-etr: Check if page is valid before dma_map_page()

2020-11-23 Thread Mathieu Poirier
On Mon, Nov 23, 2020 at 10:46:56AM +, Suzuki K Poulose wrote: > On 11/23/20 10:21 AM, Sai Prakash Ranjan wrote: > > From: Mao Jinlong > > > > alloc_pages_node() return should be checked before calling > > dma_map_page() to make sure that valid page is mapped or > > else it can lead to aborts

Re: [PATCH] remoteproc: Add module parameter 'auto_boot'

2020-11-20 Thread Mathieu Poirier
Hi Paul, On Sun, Nov 15, 2020 at 11:50:56AM +, Paul Cercueil wrote: > Until now the remoteproc core would always default to trying to boot the > remote processor at startup. The various remoteproc drivers could > however override that setting. > > Whether or not we want the remote processor

[PATCH v7 4/8] rpmsg: virtio: Rename rpmsg_create_channel

2020-11-20 Thread Mathieu Poirier
From: Arnaud Pouliquen Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v7 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-11-20 Thread Mathieu Poirier
Use rpmsg byte conversion functions in order for the RPMSG headers and generic functions to be used by external entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 53 +--- 1 file changed, 28 insertions

[PATCH v7 6/8] rpmsg: virtio: Add rpmsg channel device ops

2020-11-20 Thread Mathieu Poirier
From: Arnaud Pouliquen Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 22 ++ 1 file changed, 22

[PATCH v7 3/8] rpmsg: Move structure rpmsg_ns_msg to header file

2020-11-20 Thread Mathieu Poirier
Move structure rpmsg_ns_msg to its own header file so that it can be used by other entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 32 +--- include/linux/rpmsg/ns.h | 42

[PATCH v7 5/8] rpmsg: core: Add channel creation internal API

2020-11-20 Thread Mathieu Poirier
From: Arnaud Pouliquen Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg

[PATCH v7 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-20 Thread Mathieu Poirier
From: Arnaud Pouliquen Make the RPMSG name service announcement a stand alone driver so that it can be reused by other subsystems. It is also the first step in making the functionatlity transport independent, i.e that is not tied to virtIO. Co-developed-by: Mathieu Poirier Signed-off

[PATCH v7 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public

2020-11-20 Thread Mathieu Poirier
Make function rpmsg_register_device() and rpmsg_unregister_device() functions public so that they can be used by other clients. While doing so get rid of two obsolete function, i.e register_rpmsg_device() and unregister_rpmsg_device(), to prevent confusion. Signed-off-by: Mathieu Poirier

[PATCH v7 1/8] rpmsg: Introduce __rpmsg{16|32|64} types

2020-11-20 Thread Mathieu Poirier
Introduce __rpmsg{16|32|64} types along with byte order conversion functions based on an rpmsg_device operation as a foundation to make RPMSG modular and transport agnostic. Suggested-by: Guennadi Liakhovetski Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- include/linux

[PATCH v7 0/8] rpmsg: Make RPMSG name service modular

2020-11-20 Thread Mathieu Poirier
() as reported by Guennadi Arnaud Pouliquen (4): rpmsg: virtio: Rename rpmsg_create_channel rpmsg: core: Add channel creation internal API rpmsg: virtio: Add rpmsg channel device ops rpmsg: Turn name service into a stand alone driver Mathieu Poirier (4): rpmsg: Introduce __rpmsg{16|32|64

Re: [PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-19 Thread Mathieu Poirier
On Thu, Nov 19, 2020 at 06:10:51PM +0100, Guennadi Liakhovetski wrote: > Hi Mathieu, > > I haven't tested it yet, but I've compared it to the previous version > and all the changed except the one, mentioned by Arnaud, seem to be > there! So, let's just fix this one and should be good to go! >

Re: [PATCH v2 3/3] remoteproc: Add ftrace events to trace lifecycle of remoteprocs

2020-11-18 Thread Mathieu Poirier
On Mon, Nov 16, 2020 at 01:44:44PM -0800, Rishabh Bhatnagar wrote: > Add trace events to trace bootup/shutdown/recovery of remote > processors. These events are useful in analyzing the time > spent in each step in the life cycle and can be used for > performace analysis. Also these serve as

[PATCH v6 4/8] rpmsg: virtio: Rename rpmsg_create_channel

2020-11-18 Thread Mathieu Poirier
From: Arnaud Pouliquen Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v6 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-18 Thread Mathieu Poirier
From: Arnaud Pouliquen Make the RPMSG name service announcement a stand alone driver so that it can be reused by other subsystems. It is also the first step in making the functionatlity transport independent, i.e that is not tied to virtIO. Co-developed-by: Mathieu Poirier Signed-off

[PATCH v6 6/8] rpmsg: virtio: Add rpmsg channel device ops

2020-11-18 Thread Mathieu Poirier
From: Arnaud Pouliquen Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 22 ++ 1 file changed, 22

[PATCH v6 5/8] rpmsg: core: Add channel creation internal API

2020-11-18 Thread Mathieu Poirier
From: Arnaud Pouliquen Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg

[PATCH v6 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public

2020-11-18 Thread Mathieu Poirier
Make function rpmsg_register_device() and rpmsg_unregister_device() functions public so that they can be used by other clients. While doing so get rid of two obsolete function, i.e register_rpmsg_device() and unregister_rpmsg_device(), to prevent confusion. Signed-off-by: Mathieu Poirier

[PATCH v6 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-11-18 Thread Mathieu Poirier
Use rpmsg byte conversion functions in order for the RPMSG headers and generic functions to be used by external entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 53 +--- 1 file changed, 28 insertions

[PATCH v6 3/8] rpmsg: Move structure rpmsg_ns_msg to header file

2020-11-18 Thread Mathieu Poirier
Move structure rpmsg_ns_msg to its own header file so that it can be used by other entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 32 +--- include/linux/rpmsg/ns.h | 42

[PATCH v6 1/8] rpmsg: Introduce __rpmsg{16|32|64} types

2020-11-18 Thread Mathieu Poirier
Introduce __rpmsg{16|32|64} types along with byte order conversion functions based on an rpmsg_device operation as a foundation to make RPMSG modular and transport agnostic. Suggested-by: Guennadi Liakhovetski Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- include/linux

[PATCH v6 0/8] rpmsg: Make RPMSG name service modular

2020-11-18 Thread Mathieu Poirier
rpmsg_ns_register_device() to rpmsg_ns.c for automatic module loading Arnaud Pouliquen (4): rpmsg: virtio: Rename rpmsg_create_channel rpmsg: core: Add channel creation internal API rpmsg: virtio: Add rpmsg channel device ops rpmsg: Turn name service into a stand alone driver Mathieu Poirier

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-18 Thread Mathieu Poirier
On Wed, 18 Nov 2020 at 00:08, Guennadi Liakhovetski wrote: > > On Tue, Nov 17, 2020 at 05:06:47PM -0700, Mathieu Poirier wrote: > > [snip] > > > I confirm that all this is working as expected - I will send a new revision > > of > > this set tomorrow afternoon.

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-17 Thread Mathieu Poirier
On Tue, Nov 17, 2020 at 05:44:05PM +0100, Arnaud POULIQUEN wrote: > > > On 11/17/20 5:03 PM, Guennadi Liakhovetski wrote: > > On Tue, Nov 17, 2020 at 12:42:30PM +0100, Arnaud POULIQUEN wrote: > > > > [snip] > > > >> diff --git a/drivers/rpmsg/rpmsg_ns.c b/drivers/rpmsg/rpmsg_ns.c > >> index

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-16 Thread Mathieu Poirier
On Mon, Nov 16, 2020 at 04:51:52PM +0100, Arnaud POULIQUEN wrote: > Hi Guennadi, > > On 11/16/20 4:10 PM, Guennadi Liakhovetski wrote: > > Hi Arnaud, > > > > On Mon, Nov 16, 2020 at 03:43:35PM +0100, Arnaud POULIQUEN wrote: > >> Hi Guennadi, Mathieu, > > > > [snip] > > > >> I tried the

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-14 Thread Mathieu Poirier
On Thu, Nov 12, 2020 at 10:04:17AM +0100, Arnaud POULIQUEN wrote: > > > On 11/11/20 1:37 AM, Mathieu Poirier wrote: > > On Tue, 10 Nov 2020 at 11:18, Arnaud POULIQUEN > > wrote: > >> > >> Hi Mathieu, Guennadi, > >> > >> On 11/9/20 6

Re: [RFC PATCH v2] coresight: etm4x: Modify core-commit of cpu to avoid the overflow of HiSilicon ETM

2020-11-11 Thread Mathieu Poirier
On Wed, Nov 11, 2020 at 04:58:23PM +0800, Qi Liu wrote: > Hi Mathieu, > > On 2020/9/10 0:26, Mathieu Poirier wrote: > > On Wed, Sep 09, 2020 at 12:30:02PM +0100, Mike Leach wrote: > >> Hi, > >> > >> On Wed, 2 Sep 2020 at 11:36, Suzuki K Poulose > &g

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-10 Thread Mathieu Poirier
On Tue, 10 Nov 2020 at 11:18, Arnaud POULIQUEN wrote: > > Hi Mathieu, Guennadi, > > On 11/9/20 6:55 PM, Mathieu Poirier wrote: > > On Mon, Nov 09, 2020 at 11:20:24AM +0100, Guennadi Liakhovetski wrote: > >> Hi Arnaud, > >> > >> On Mon, Nov 09, 202

Re: [RFC 00/11] arm64: coresight: Enable ETE and TRBE

2020-11-10 Thread Mathieu Poirier
Hi Anshuman, On Tue, 10 Nov 2020 at 05:45, Anshuman Khandual wrote: > > This series enables future IP trace features Embedded Trace Extension (ETE) > and Trace Buffer Extension (TRBE). This series depends on the ETM system > register instruction support series [0] and the v8.4 Self hosted

Re: [PATCH RESEND 2/2] perf test: Update branch sample parttern for cs-etm

2020-11-10 Thread Mathieu Poirier
counting") > Signed-off-by: Leo Yan > --- > tools/perf/tests/shell/test_arm_coresight.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Here too I would CC stable. With the above: Reviewed-by: Mathieu Poirier > > diff --git a/tools/perf/tests/shell/

Re: [PATCH RESEND 1/2] perf test: Fix a typo in cs-etm testing

2020-11-10 Thread Mathieu Poirier
On Tue, Nov 10, 2020 at 02:34:16PM +0800, Leo Yan wrote: > Fix a typo: s/devce_name/device_name. > > Fixes: fe0aed19b266 ("perf test: Introduce script for Arm CoreSight testing") > Signed-off-by: Leo Yan > --- > I would CC stable too. Reviewed-by: Mathieu Poirier

Re: [PATCH v2] coresight: tmc-etr: Assign boolean values to a bool variable

2020-11-10 Thread Mathieu Poirier
On Tue, Nov 10, 2020 at 11:39:15AM +0800, xiakaixu1...@gmail.com wrote: > From: Kaixu Xia > > Fix the following coccinelle warnings: > > ./drivers/hwtracing/coresight/coresight-tmc-etr.c:957:2-15: WARNING: > Assignment of 0/1 to bool variable > > Fix them by assigning boolean values. > >

Re: [PATCH v3 22/26] coresight: etm4x: Add necessary synchronization for sysreg access

2020-11-10 Thread Mathieu Poirier
On Tue, Nov 10, 2020 at 10:11:23AM +, Suzuki K Poulose wrote: > On 11/9/20 6:32 PM, Mathieu Poirier wrote: > > On Wed, Oct 28, 2020 at 10:09:41PM +, Suzuki K Poulose wrote: > > > As per the specification any update to the TRCPRGCTLR must be synchronized > > > b

Re: [PATCH v3 23/26] coresight: etm4x: Detect system instructions support

2020-11-10 Thread Mathieu Poirier
On Tue, Nov 10, 2020 at 09:31:42AM +, Suzuki K Poulose wrote: > On 11/9/20 8:22 PM, Mathieu Poirier wrote: > > On Wed, Oct 28, 2020 at 10:09:42PM +, Suzuki K Poulose wrote: > > > ETM v4.4 onwards adds support for system instruction access > > > to the ETM. D

Re: [PATCH v3 07/26] coresight: Introduce device access abstraction

2020-11-10 Thread Mathieu Poirier
On Tue, Nov 10, 2020 at 09:24:19AM +, Suzuki K Poulose wrote: > On 11/9/20 9:00 PM, Mathieu Poirier wrote: > > On Wed, Oct 28, 2020 at 10:09:26PM +, Suzuki K Poulose wrote: > > > We are about to introduce support for sysreg access to ETMv4.4+ > > > compone

Re: [PATCH v3 07/26] coresight: Introduce device access abstraction

2020-11-09 Thread Mathieu Poirier
to preserve the logic of these operations at a > single place we introduce an abstraction layer for the accesses > to a given device. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off-by: Suzuki K Poulose > --- > drivers/hwtracing/coresight/coresight-catu.c | 1 + >

Re: [PATCH v3 26/26] dts: bindings: coresight: ETM system register access only units

2020-11-09 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:45PM +, Suzuki K Poulose wrote: > Document the bindings for ETMs with system register accesses. > > Cc: devicet...@vger.kernel.org > Cc: Mathieu Poirier > Cc: Mike Leach > Cc: Rob Herring > Signed-off-by: Suzuki K Poulose > --- >

Re: [PATCH v3 25/26] coresight: etm4x: Add support for sysreg only devices

2020-11-09 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:44PM +, Suzuki K Poulose wrote: > Add support for devices with system instruction access only. > They don't have a memory mapped interface and thus are not > AMBA devices. > > Cc: Mathieu Poirier > Cc: Mike Leach > Signed-off

Re: [PATCH v3 24/26] coresight: etm4x: Refactor probing routine

2020-11-09 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:43PM +, Suzuki K Poulose wrote: > CoreSight ETM with system register access may not have a > memory mapped i/o access. Refactor the ETM specific probing > into a common routine to allow reusing the code for such ETMs. > > Cc: Mathieu Poirier &

Re: [PATCH v3 23/26] coresight: etm4x: Detect system instructions support

2020-11-09 Thread Mathieu Poirier
access *csa) > { > + /* > + * Always choose the memory mapped io, if there is > + * a memory map to prevent sysreg access on broken > + * systems. > + */ > if (drvdata->base) > return etm_init_iomem_access(drvdata, csa); > > + if (etm_init_sysreg_access(drvdata, csa)) > + return true; > + > return false; With the above: Reviewed-by: Mathieu Poirier > } > > -- > 2.24.1 >

Re: [PATCH v3 22/26] coresight: etm4x: Add necessary synchronization for sysreg access

2020-11-09 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:41PM +, Suzuki K Poulose wrote: > As per the specification any update to the TRCPRGCTLR must be synchronized > by a context synchronization event (in our case an explicist ISB) before > the TRCSTATR is checked. > > Cc: Mike Leach > Cc: Mathieu

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-09 Thread Mathieu Poirier
On Mon, Nov 09, 2020 at 11:20:24AM +0100, Guennadi Liakhovetski wrote: > Hi Arnaud, > > On Mon, Nov 09, 2020 at 09:48:37AM +0100, Arnaud POULIQUEN wrote: > > Hi Guennadi, Mathieu, > > > > On 11/6/20 6:53 PM, Mathieu Poirier wrote: > > > On Fri, Nov 06

Re: [PATCH v3 19/26] coresight: etm4x: Detect access early on the target CPU

2020-11-09 Thread Mathieu Poirier
On Mon, Nov 09, 2020 at 09:48:07AM +, Suzuki K Poulose wrote: > On 11/6/20 8:34 PM, Mathieu Poirier wrote: > > On Wed, Oct 28, 2020 at 10:09:38PM +, Suzuki K Poulose wrote: > > > In preparation to detect the support for system instruction > > > support, move

Re: [PATCH v3 17/26] coresight: etm4x: Cleanup secure exception level masks

2020-11-09 Thread Mathieu Poirier
On Mon, Nov 09, 2020 at 09:40:54AM +, Suzuki K Poulose wrote: > On 11/5/20 9:55 PM, Mathieu Poirier wrote: > > On Wed, Oct 28, 2020 at 10:09:36PM +, Suzuki K Poulose wrote: > > > We rely on the ETM architecture version to decide whether > > > Secure

Re: [PATCH v3 21/26] coresight: etm4x: Use TRCDEVARCH for component discovery

2020-11-06 Thread Mathieu Poirier
re.c | 46 +-- > 1 file changed, 23 insertions(+), 23 deletions(-) Reviewed-by: Mathieu Poirier I'm out of time for today, I will resume on Monday. Thanks, Mathieu > > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c > b/drivers/hwtracing/coresight/coresight-etm

Re: [PATCH v3 20/26] coresight: etm4x: Handle ETM architecture version

2020-11-06 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:39PM +, Suzuki K Poulose wrote: > We are about to rely on TRCDEVARCH for detecting the ETM > and its architecture version, falling back to TRCIDR1 if > the former is not implemented (in older broken implementations). > > Also, we use the architecture version

Re: [PATCH v3 19/26] coresight: etm4x: Detect access early on the target CPU

2020-11-06 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:38PM +, Suzuki K Poulose wrote: > In preparation to detect the support for system instruction > support, move the detection of the device access to the target > CPU. > > Signed-off-by: Suzuki K Poulose > --- > .../coresight/coresight-etm4x-core.c | 45

Re: [PATCH v3 19/26] coresight: etm4x: Detect access early on the target CPU

2020-11-06 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:38PM +, Suzuki K Poulose wrote: > In preparation to detect the support for system instruction > support, move the detection of the device access to the target > CPU. > > Signed-off-by: Suzuki K Poulose > --- > .../coresight/coresight-etm4x-core.c | 45

Re: [PATCH v3 18/26] coresight: etm4x: Clean up exception level masks

2020-11-06 Thread Mathieu Poirier
Good morning, On Wed, Oct 28, 2020 at 10:09:37PM +, Suzuki K Poulose wrote: > etm4_get_access_type() calculates the exception level bits > for use in address comparator registers. This is also used > by the TRCVICTLR register by shifting to the required position. > > This patch cleans up the

Re: [PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-06 Thread Mathieu Poirier
On Fri, Nov 06, 2020 at 03:00:28PM +0100, Guennadi Liakhovetski wrote: > On Fri, Nov 06, 2020 at 02:15:45PM +0100, Guennadi Liakhovetski wrote: > > Hi Mathieu, Arnaud, > > > > On Thu, Nov 05, 2020 at 03:50:28PM -0700, Mathieu Poirier wrote: > > > From: Arnau

[PATCH v5 0/8] rpmsg: Make RPMSG name service modular

2020-11-05 Thread Mathieu Poirier
creation internal API rpmsg: virtio: Add rpmsg channel device ops rpmsg: Turn name service into a stand alone driver Mathieu Poirier (4): rpmsg: Introduce __rpmsg{16|32|64} types rpmsg: virtio: Move from virtio to rpmsg byte conversion rpmsg: Move structure rpmsg_ns_msg to header file

[PATCH v5 3/8] rpmsg: Move structure rpmsg_ns_msg to header file

2020-11-05 Thread Mathieu Poirier
Move structure rpmsg_ns_msg to its own header file so that it can be used by other entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 32 +--- include/linux/rpmsg/ns.h | 42

[PATCH v5 4/8] rpmsg: virtio: Rename rpmsg_create_channel

2020-11-05 Thread Mathieu Poirier
From: Arnaud Pouliquen Rename the internal function as it is internal, and as the name will be used in rpmsg_core. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 6 +++--- 1 file changed, 3 insertions

[PATCH v5 6/8] rpmsg: virtio: Add rpmsg channel device ops

2020-11-05 Thread Mathieu Poirier
From: Arnaud Pouliquen Implement the create and release of the RPMsg channel for the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg/virtio_rpmsg_bus.c | 22 ++ 1 file changed, 22

[PATCH v5 5/8] rpmsg: core: Add channel creation internal API

2020-11-05 Thread Mathieu Poirier
From: Arnaud Pouliquen Add the channel creation API as a first step to be able to define the name service announcement as a rpmsg driver independent from the RPMsg virtio bus. Signed-off-by: Arnaud Pouliquen Signed-off-by: Mathieu Poirier Reviewed-by: Guennadi Liakhovetski --- drivers/rpmsg

[PATCH v5 8/8] rpmsg: Turn name service into a stand alone driver

2020-11-05 Thread Mathieu Poirier
From: Arnaud Pouliquen Make the RPMSG name service announcement a stand alone driver so that it can be reused by other subsystems. It is also the first step in making the functionatlity transport independent, i.e that is not tied to virtIO. Co-developed-by: Mathieu Poirier Signed-off

[PATCH v5 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public

2020-11-05 Thread Mathieu Poirier
Make function rpmsg_register_device() and rpmsg_unregister_device() functions public so that they can be used by other clients. While doing so get rid of two obsolete function, i.e register_rpmsg_device() and unregister_rpmsg_device(), to prevent confusion. Signed-off-by: Mathieu Poirier

[PATCH v5 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion

2020-11-05 Thread Mathieu Poirier
Use rpmsg byte conversion functions in order for the RPMSG headers and generic functions to be used by external entities. Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- drivers/rpmsg/virtio_rpmsg_bus.c | 53 +--- 1 file changed, 28 insertions

[PATCH v5 1/8] rpmsg: Introduce __rpmsg{16|32|64} types

2020-11-05 Thread Mathieu Poirier
Introduce __rpmsg{16|32|64} types along with byte order conversion functions based on an rpmsg_device operation as a foundation to make RPMSG modular and transport agnostic. Suggested-by: Guennadi Liakhovetski Signed-off-by: Mathieu Poirier Reviewed-by: Arnaud Pouliquen --- include/linux

Re: [PATCH v3 17/26] coresight: etm4x: Cleanup secure exception level masks

2020-11-05 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:36PM +, Suzuki K Poulose wrote: > We rely on the ETM architecture version to decide whether > Secure EL2 is available on the CPU for excluding the level > for address comparators and viewinst main control register. > We must instead use the TRCDIDR3.EXLEVEL_S

Re: [PATCH v3 16/26] coresight: etm4x: Check for Software Lock

2020-11-05 Thread Mathieu Poirier
-core.c | 40 --- > 1 file changed, 25 insertions(+), 15 deletions(-) > Reviewed-by: Mathieu Poirier > diff --git a/drivers/hwtracing/coresight/coresight-etm4x-core.c > b/drivers/hwtracing/coresight/coresight-etm4x-core.c > index a5c914b16e59..a12d58a04

Re: [PATCH v3 14/26] coresight: etm4x: Add sysreg access helpers

2020-11-05 Thread Mathieu Poirier
On Wed, Oct 28, 2020 at 10:09:33PM +, Suzuki K Poulose wrote: > ETMv4.4 architecture defines the system instructions for accessing > ETM via register accesses. Add basic support for accessing a given > register via system instructions. > > Cc: Mathieu Poirier > Cc: Mike L

Re: [PATCH v22 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-05 Thread Mathieu Poirier
Hi, On Wed, Nov 04, 2020 at 09:57:40PM +, Ben Levinsky wrote: > Hi Mathieu, > > > -Original Message- > > From: Mathieu Poirier > > Sent: Wednesday, November 4, 2020 1:30 PM > > To: Ben Levinsky > > Cc: michael.auch...@ni.com; Stefano Stabell

Re: [PATCH v22 5/5] remoteproc: Add initial zynqmp R5 remoteproc driver

2020-11-04 Thread Mathieu Poirier
On Tue, Nov 03, 2020 at 10:23:39AM -0800, Ben Levinsky wrote: > R5 is included in Xilinx Zynq UltraScale MPSoC so by adding this > remotproc driver, we can boot the R5 sub-system in different 2 > configurations - > * split > * lock-step > > The Xilinx R5 Remoteproc Driver boots the

<    2   3   4   5   6   7   8   9   10   11   >