Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-13 Thread Matias Ezequiel Vara Larsen
On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > Hello, > > I thought there would be some more comments coming and I could address > everything in one chunk. Not the case, besides your comments silence. > > On 08.01.24 20:34, Christophe JAILLET wrote: > > > > Hi, > > a few nits b

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Matias Ezequiel Vara Larsen
Hello, On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > Hello, > > I thought there would be some more comments coming and I could address > everything in one chunk. Not the case, besides your comments silence. > > On 08.01.24 20:34, Christophe JAILLET wrote: > > > > Hi, > > a fe

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Matias Ezequiel Vara Larsen
On Wed, Mar 12, 2025 at 02:36:05PM +0100, Marc Kleine-Budde wrote: > On 12.03.2025 14:28:10, Matias Ezequiel Vara Larsen wrote: > > On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > > > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > > &

Re: [PATCH v5] can: virtio: Initial virtio CAN driver.

2025-03-12 Thread Matias Ezequiel Vara Larsen
On Wed, Mar 12, 2025 at 11:41:26AM +0100, Marc Kleine-Budde wrote: > On 12.03.2025 11:31:12, Matias Ezequiel Vara Larsen wrote: > > On Thu, Feb 01, 2024 at 07:57:45PM +0100, Harald Mommer wrote: > > > Hello, > > > > > > I thought there would be some more

[PATCH net-next v2] vsock/virtio: add support for MSG_PEEK

2019-09-30 Thread Matias Ezequiel Vara Larsen
This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen Reviewed-by: Stefano Garzarella Tested-by: Stefano Garzarella --- net/vmw_vsock/virtio_transport_common.c | 55

[PATCH v2] vsock/virtio: add support for MSG_PEEK

2019-09-27 Thread Matias Ezequiel Vara Larsen
This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen --- net/vmw_vsock/virtio_transport_common.c | 55 +++-- 1 file changed, 52 insertions(+), 3

Re: [PATCH] vsock/virtio: add support for MSG_PEEK

2019-09-27 Thread Matias Ezequiel Vara Larsen
On Fri, Sep 27, 2019 at 06:37:00AM -0700, Eric Dumazet wrote: > > > On 9/27/19 1:55 AM, Stefano Garzarella wrote: > > > Good catch! > > > > Maybe we can solve in this way: > > > > list_for_each_entry(pkt, &vvs->rx_queue, list) { > > size_t off = pkt->off; > > > > i

[PATCH] vsock/virtio: add support for MSG_PEEK

2019-09-26 Thread Matias Ezequiel Vara Larsen
This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen --- net/vmw_vsock/virtio_transport_common.c | 50 +++-- 1 file changed, 47 insertions(+), 3

Re: [RFC] VSOCK: add support for MSG_PEEK

2019-09-23 Thread Matias Ezequiel Vara Larsen
quot; > > Some comments below: > > On Sun, Sep 22, 2019 at 05:48:27PM +, Matias Ezequiel Vara Larsen wrote: > > This patch adds support for MSG_PEEK. In such a case, packets are not > > removed from the rx_queue and credit updates are not sent. > > &

[RFC] VSOCK: add support for MSG_PEEK

2019-09-22 Thread Matias Ezequiel Vara Larsen
This patch adds support for MSG_PEEK. In such a case, packets are not removed from the rx_queue and credit updates are not sent. Signed-off-by: Matias Ezequiel Vara Larsen --- net/vmw_vsock/virtio_transport_common.c | 59 +++-- 1 file changed, 56 insertions(+), 3