Re: [PATCH 0/2] Add Mediatek X20 Development Board support

On 29/05/18 09:27, Manivannan Sadhasivam wrote: > Hi Matthias, > > On Tue, May 29, 2018 at 08:38:27AM +0200, Matthias Brugger wrote: >> Hi Manivannan, >> >> it's nice to see that someone at Linaro cares about upstreaming the 96 board. >> From what I can se

Re: [PATCH 0/2] Add Mediatek X20 Development Board support

Hi Manivannan, it's nice to see that someone at Linaro cares about upstreaming the 96 board. >From what I can see, your patches add the very same support to the board as does the mt6797 evaluation board. Do you have plans to upstream more drivers for the board? Do you have a roadmap or something?

Re: [PATCH 0/2] Add Mediatek X20 Development Board support

Hi Manivannan, it's nice to see that someone at Linaro cares about upstreaming the 96 board. >From what I can see, your patches add the very same support to the board as does the mt6797 evaluation board. Do you have plans to upstream more drivers for the board? Do you have a roadmap or something?

Re: [PATCH V5 3/4] soc: mediatek: pwrap: add pwrap driver for mt6797 SoCs

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > mt6797 is a highly integrated SoCs, it uses mt6351 for power management. > We need to add pwrap driver to access mt6351. Pwrap of mt6797 support > dynamic priority meichanism, sequence monitor

Re: [PATCH V5 3/4] soc: mediatek: pwrap: add pwrap driver for mt6797 SoCs

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > mt6797 is a highly integrated SoCs, it uses mt6351 for power management. > We need to add pwrap driver to access mt6351. Pwrap of mt6797 support > dynamic priority meichanism, sequence monitor and starvation mechanism

Re: [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > PWRAP_DEW_CIPHER_LOAD and PWRAP_DEW_CIPHER_START only exist at > PMIC_mt6397 datasheet. We fix it before merge PMIC_mt6351 driver. > > Fixes: 5ae48040aa47 ("soc: mediatek: PMIC wrap: add mt6323

Re: [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > PWRAP_DEW_CIPHER_LOAD and PWRAP_DEW_CIPHER_START only exist at > PMIC_mt6397 datasheet. We fix it before merge PMIC_mt6351 driver. > > Fixes: 5ae48040aa47 ("soc: mediatek: PMIC wrap: add mt6323 slave support") Same

Re: [PATCH V5 1/4] dt-bindings: pwrap: mediatek: add pwrap support for MT6797

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > We add pwrap support for MT6797 SoCs. > You forgot the Signed-off-by tag. > --- > Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH V5 1/4] dt-bindings: pwrap: mediatek: add pwrap support for MT6797

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > We add pwrap support for MT6797 SoCs. > You forgot the Signed-off-by tag. > --- > Documentation/devicetree/bindings/soc/mediatek/pwrap.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Stephen, On 05/13/2018 11:57 PM, Stephen Rothwell wrote: > Hi Matthias, > > Commit > > f039c4193c93 ("iregmap: include from > include/linux/regmap.h") > > is missing a Signed-off-by from its committer. > My tree was broken and the merge

Re: linux-next: Signed-off-by missing for commit in the mediatek tree

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Stephen, On 05/13/2018 11:57 PM, Stephen Rothwell wrote: > Hi Matthias, > > Commit > > f039c4193c93 ("iregmap: include from > include/linux/regmap.h") > > is missing a Signed-off-by from its committer. > My tree was broken and the merge

Re: [PATCH 2/2] arm64: dts: mt7622: add audio related device nodes

On 05/02/2018 05:53 AM, Sean Wang wrote: > Hi, Matthias > > On Wed, 2018-05-02 at 11:41 +0800, sean.w...@mediatek.com wrote: >> From: Ryder Lee >> >> Add audio device nodes and its proper setup for all used pins >> >> Signed-off-by: Ryder Lee >>

Re: [PATCH 2/2] arm64: dts: mt7622: add audio related device nodes

On 05/02/2018 05:53 AM, Sean Wang wrote: > Hi, Matthias > > On Wed, 2018-05-02 at 11:41 +0800, sean.w...@mediatek.com wrote: >> From: Ryder Lee >> >> Add audio device nodes and its proper setup for all used pins >> >> Signed-off-by: Ryder Lee >> Signed-off-by: Sean Wang >> --- >>

Re: [PATCH v2 00/12] refactor dts and add support for more boards

On 04/11/2018 10:53 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Changes since v1: > - Dropped several patches which have been merged. > - Rebased to linux-next-20180410 where those dependent patches including > [1] and [2] all have been got merged. > -

Re: [PATCH v2 00/12] refactor dts and add support for more boards

On 04/11/2018 10:53 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Changes since v1: > - Dropped several patches which have been merged. > - Rebased to linux-next-20180410 where those dependent patches including > [1] and [2] all have been got merged. > - Revised according to

Re: [PATCH v2 03/12] arm: dts: mt7623: fix invalid memory node being generated

On 04/11/2018 10:53 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Below two wrong nodes in existing DTS files would cause a fail boot since > in fact the address 0 is not the correct place the memory device locates > at. > > memory { > device_type =

Re: [PATCH v2 03/12] arm: dts: mt7623: fix invalid memory node being generated

On 04/11/2018 10:53 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Below two wrong nodes in existing DTS files would cause a fail boot since > in fact the address 0 is not the correct place the memory device locates > at. > > memory { > device_type = "memory"; > reg =

Re: [PATCH] soc: mediatek: remove unneeded semicolon

On 05/10/2018 04:57 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Fix up drivers/soc/mediatek/mtk-scpsys.c:255:2-3: Unneeded semicolon > accidently being added in commit f9e2f65dd561 ("soc: mediatek: add a > fixed wait for SRAM stable"). > > Fixes:

Re: [PATCH] soc: mediatek: remove unneeded semicolon

On 05/10/2018 04:57 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Fix up drivers/soc/mediatek/mtk-scpsys.c:255:2-3: Unneeded semicolon > accidently being added in commit f9e2f65dd561 ("soc: mediatek: add a > fixed wait for SRAM stable"). > > Fixes: f9e2f65dd561 ("soc: mediatek: add

Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll_timeout helpers

at we want... (see below) > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Matthias Brugger <matthias@gmail.com> > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: Weiyi Lu <weiyi...@mediatek.com> > --- > drivers/soc/mediatek/mtk-infracfg.c | 46

Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll_timeout helpers

> Signed-off-by: Sean Wang > Cc: Matthias Brugger > Cc: Ulf Hansson > Cc: Weiyi Lu > --- > drivers/soc/mediatek/mtk-infracfg.c | 46 > ++--- > 1 file changed, 12 insertions(+), 34 deletions(-) > Please write your changelog here in the

Re: [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > PWRAP_DEW_CIPHER_LOAD and PWRAP_DEW_CIPHER_START only exist at > PMIC_mt6397 datasheet. We fix it before merge PMIC_mt6351 driver. Please don't put info like "We fix it before merge PMIC_mt6351

Re: [PATCH V5 2/4] soc: mediatek: pwrap: fix cipher init setting error

On 05/10/2018 03:01 PM, argus@mediatek.com wrote: > From: Argus Lin > > PWRAP_DEW_CIPHER_LOAD and PWRAP_DEW_CIPHER_START only exist at > PMIC_mt6397 datasheet. We fix it before merge PMIC_mt6351 driver. Please don't put info like "We fix it before merge PMIC_mt6351 driver." in the commit

Re: [PATCH V4 5/8] soc: mediatek: pwrap: add pwrap for mt6797 SoCs

On 05/04/2018 05:04 AM, Sean Wang wrote: > On Thu, 2018-05-03 at 14:20 +0800, Argus Lin wrote: >> On Thu, 2018-05-03 at 12:01 +0800, Sean Wang wrote: >>> }; > > [...] > @@ -1503,11 +1581,13 @@ static int pwrap_probe(struct platform_device *pdev) if (IS_ERR(wrp->base))

Re: [PATCH V4 5/8] soc: mediatek: pwrap: add pwrap for mt6797 SoCs

On 05/04/2018 05:04 AM, Sean Wang wrote: > On Thu, 2018-05-03 at 14:20 +0800, Argus Lin wrote: >> On Thu, 2018-05-03 at 12:01 +0800, Sean Wang wrote: >>> }; > > [...] > @@ -1503,11 +1581,13 @@ static int pwrap_probe(struct platform_device *pdev) if (IS_ERR(wrp->base))

Re: [PATCH v3] soc: mediatek: add a fixed wait for SRAM stable

v2 -> v3: > - change the order for condition judgment with we check an existence of >the MTK_SCPD_FWAIT_SRAM first to get rid of any oversight on negative >condition. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Matthias Brugger <matthias@

Re: [PATCH v3] soc: mediatek: add a fixed wait for SRAM stable

he order for condition judgment with we check an existence of >the MTK_SCPD_FWAIT_SRAM first to get rid of any oversight on negative > condition. > > Signed-off-by: Sean Wang > Cc: Matthias Brugger > Cc: Ulf Hansson > Cc: Weiyi Lu > --- Now pused to v4.17-next/s

Re: [PATCH V4 5/8] soc: mediatek: pwrap: add pwrap for mt6797 SoCs

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > mt6797 is a highly integrated SoCs, it uses mt6351 for power > management. We need to add pwrap support to access mt6351. > Pwrap of mt6797 support new feature include starvation and channel >

Re: [PATCH V4 5/8] soc: mediatek: pwrap: add pwrap for mt6797 SoCs

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > mt6797 is a highly integrated SoCs, it uses mt6351 for power > management. We need to add pwrap support to access mt6351. > Pwrap of mt6797 support new feature include starvation and channel > request exception

Re: [PATCH V4 4/8] soc: mediatek: pwrap: add int1_en_all flag

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > MT6797 support int1_en flag for starvation > and cmd_miss exception interrupt. We add > a new flag int1_en_all to check if we need > to enable interrupt source or not. > > Signed-off-by: Argus

Re: [PATCH V4 4/8] soc: mediatek: pwrap: add int1_en_all flag

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > MT6797 support int1_en flag for starvation > and cmd_miss exception interrupt. We add > a new flag int1_en_all to check if we need > to enable interrupt source or not. > > Signed-off-by: Argus Lin > --- >

Re: [PATCH V4 3/8] soc: mediatek: pwrap: remove has_bridge flag

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > We use new flag caps to replace has_bridge. > Legacy chips support bridge use PWRAP_CAP_BRIDGE > to explain such capability. > > Signed-off-by: Argus Lin > --- Squash

Re: [PATCH V4 3/8] soc: mediatek: pwrap: remove has_bridge flag

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > We use new flag caps to replace has_bridge. > Legacy chips support bridge use PWRAP_CAP_BRIDGE > to explain such capability. > > Signed-off-by: Argus Lin > --- Squash this one into 2/8. Regards, Matthias >

Re: [PATCH V4 2/8] soc: mediatek: pwrap: add caps flag for pwrap

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > We use caps to describe pwrap's capability, used > to replace has_bridge flag for single meaning. > > Signed-off-by: Argus Lin > --- >

Re: [PATCH V4 2/8] soc: mediatek: pwrap: add caps flag for pwrap

On 05/02/2018 11:21 AM, argus@mediatek.com wrote: > From: Argus Lin > > We use caps to describe pwrap's capability, used > to replace has_bridge flag for single meaning. > > Signed-off-by: Argus Lin > --- > drivers/soc/mediatek/mtk-pmic-wrap.c | 11 +++ > 1 file changed, 11

Re: [PATCH v2 01/12] dt-bindings: cpufreq: mediatek: use - instead of _ in examples

.rutl...@arm.com> > Cc: linux...@vger.kernel.org > Cc: devicet...@vger.kernel.org > Acked-by: Viresh Kumar <viresh.ku...@linaro.org> > Reviewed-by: Rob Herring <r...@kernel.org> > --- > Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++--- >

Re: [PATCH v2 01/12] dt-bindings: cpufreq: mediatek: use - instead of _ in examples

umentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > Reviewed-by: Matthias Brugger Rafael, will you take this through your tree? Regards, Matthias > diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-media

Re: [PATCH V3 3/4] soc: mediatek: pwrap: add mt6351 for mt6797 SoCs

On 04/30/2018 09:53 AM, Argus Lin wrote: > On Tue, 2018-04-17 at 23:10 +0200, Matthias Brugger wrote: >> Please update the subject line, we don't add mt5797 here. > > Dear matthias: > I can't find where I wrote mt5797 at this patch. >> >> More comments below.

Re: [PATCH V3 3/4] soc: mediatek: pwrap: add mt6351 for mt6797 SoCs

On 04/30/2018 09:53 AM, Argus Lin wrote: > On Tue, 2018-04-17 at 23:10 +0200, Matthias Brugger wrote: >> Please update the subject line, we don't add mt5797 here. > > Dear matthias: > I can't find where I wrote mt5797 at this patch. >> >> More comments below.

Re: [PATCH v2 2/2] soc: mediatek: add a fixed wait for SRAM stable

On 04/30/2018 09:08 AM, Sean Wang wrote: > On Fri, 2018-04-27 at 11:46 +0200, Matthias Brugger wrote: >> Hi Sean, >> >> On 04/23/2018 11:39 AM, Sean Wang wrote: >>> On Mon, 2018-04-23 at 11:31 +0200, Matthias Brugger wrote: >>>> >>>>

Re: [PATCH v2 2/2] soc: mediatek: add a fixed wait for SRAM stable

On 04/30/2018 09:08 AM, Sean Wang wrote: > On Fri, 2018-04-27 at 11:46 +0200, Matthias Brugger wrote: >> Hi Sean, >> >> On 04/23/2018 11:39 AM, Sean Wang wrote: >>> On Mon, 2018-04-23 at 11:31 +0200, Matthias Brugger wrote: >>>> >>>>

Re: [PATCH] arm64: defconfig: Enable CONFIG_PINCTRL_MT7622 by default

On 04/20/2018 10:58 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Recently kernelCI reported the board mt7622-rfb1 has a fail test with > kernel: ERROR: did not start booting whose details could be seen at [1]. > > The cause is that UART0 can't output

Re: [PATCH] arm64: defconfig: Enable CONFIG_PINCTRL_MT7622 by default

On 04/20/2018 10:58 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Recently kernelCI reported the board mt7622-rfb1 has a fail test with > kernel: ERROR: did not start booting whose details could be seen at [1]. > > The cause is that UART0 can't output anything when it's missing a

Re: [PATCH v2 2/2] soc: mediatek: add a fixed wait for SRAM stable

Hi Sean, On 04/23/2018 11:39 AM, Sean Wang wrote: > On Mon, 2018-04-23 at 11:31 +0200, Matthias Brugger wrote: >> >> On 04/23/2018 10:36 AM, sean.w...@mediatek.com wrote: >>> From: Sean Wang <sean.w...@mediatek.com> >>> >>> MT7622_POWER_DOMAIN_WB d

Re: [PATCH v2 2/2] soc: mediatek: add a fixed wait for SRAM stable

Hi Sean, On 04/23/2018 11:39 AM, Sean Wang wrote: > On Mon, 2018-04-23 at 11:31 +0200, Matthias Brugger wrote: >> >> On 04/23/2018 10:36 AM, sean.w...@mediatek.com wrote: >>> From: Sean Wang >>> >>> MT7622_POWER_DOMAIN_WB doesn't send an ACK when

Re: [PATCH v2 1/2] soc: mediatek: introduce a CAPS flag for scp_domain_data

main. > > At present, type u8 for the caps field is selected which can satisfy the > current situation and doesn't take up extra space against type bool > previously used. > > Suggested-by: Matthias Brugger <matthias@gmail.com> > Signed-off-by: Sean Wang <sean.w

Re: [PATCH v2 1/2] soc: mediatek: introduce a CAPS flag for scp_domain_data

type u8 for the caps field is selected which can satisfy the > current situation and doesn't take up extra space against type bool > previously used. > > Suggested-by: Matthias Brugger > Signed-off-by: Sean Wang > --- > drivers/soc/mediatek/mtk-scpsys.c | 65 >

Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll_timeout helpers

_DELAY_US and MTK_POLL_TIMEOUT for >arguments sleep_us and timeout_us passing in regmap_read_poll_timeout. > - remove unnecessary linux/iopoll.h being included in. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Matthias Brugger <matthias@gmail.com>

Re: [PATCH v2 2/2] soc: mediatek: reuse regmap_read_poll_timeout helpers

>arguments sleep_us and timeout_us passing in regmap_read_poll_timeout. > - remove unnecessary linux/iopoll.h being included in. > > Signed-off-by: Sean Wang > Cc: Matthias Brugger > Cc: Ulf Hansson > Cc: Weiyi Lu > --- > drivers/soc/mediatek/mtk-infracfg.c

Re: [v2 00/10] arm/arm64: mediatek: Fix mmsys device probing

Hi Lee, On 04/24/2018 07:48 AM, Lee Jones wrote: > On Mon, 23 Apr 2018, matthias@kernel.org wrote: > >> From: Matthias Brugger <mbrug...@suse.com> >> >> Changes since v1: >> - add binding documentation >> - ddp: use regmap_update_bits >> - dd

Re: [v2 00/10] arm/arm64: mediatek: Fix mmsys device probing

Hi Lee, On 04/24/2018 07:48 AM, Lee Jones wrote: > On Mon, 23 Apr 2018, matthias@kernel.org wrote: > >> From: Matthias Brugger >> >> Changes since v1: >> - add binding documentation >> - ddp: use regmap_update_bits >> - ddp: ignore EPRO

Re: [PATCH v2 1/2] regmap: include from include/linux/regmap.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/23/2018 01:50 PM, Mark Brown wrote: > On Mon, Apr 23, 2018 at 12:11:01PM +0200, Matthias Brugger wrote: > >> On 04/23/2018 12:03 PM, Mark Brown wrote: >>> On Mon, Apr 23, 2018 at 02:42:44PM +0800, sean.w...@mediatek.com

Re: [PATCH v2 1/2] regmap: include from include/linux/regmap.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/23/2018 01:50 PM, Mark Brown wrote: > On Mon, Apr 23, 2018 at 12:11:01PM +0200, Matthias Brugger wrote: > >> On 04/23/2018 12:03 PM, Mark Brown wrote: >>> On Mon, Apr 23, 2018 at 02:42:44PM +0800, sean.w...@mediatek.com

Re: [PATCH v2 1/2] regmap: include from include/linux/regmap.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/23/2018 12:03 PM, Mark Brown wrote: > On Mon, Apr 23, 2018 at 02:42:44PM +0800, sean.w...@mediatek.com wrote: >> From: Sean Wang >> >> Similar to the readx_poll_timeout() macro calling ktime_* and using >> ktime_t

Re: [PATCH v2 1/2] regmap: include from include/linux/regmap.h

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 04/23/2018 12:03 PM, Mark Brown wrote: > On Mon, Apr 23, 2018 at 02:42:44PM +0800, sean.w...@mediatek.com wrote: >> From: Sean Wang >> >> Similar to the readx_poll_timeout() macro calling ktime_* and using >> ktime_t type, which is declared

Re: [PATCH v2 2/2] soc: mediatek: add a fixed wait for SRAM stable

ned-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Matthias Brugger <matthias@gmail.com> > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: Weiyi Lu <weiyi...@mediatek.com> > --- > drivers/soc/mediatek/mtk-scpsys.c | 24 ++-- > 1 fi

Re: [PATCH v2 2/2] soc: mediatek: add a fixed wait for SRAM stable

to have a fixed > and well-predefined duration to wait until its managed SRAM can be allowed > to access by all functions running on the top. > > v1 -> v2: > - use MTK_SCPD_FWAIT_SRAM flag as an indication requiring force waiting. > > Signed-off-by: Sean Wang > Cc:

Re: [PATCH 4/8] clk: mediatek: mt2701-mm: switch to mfd device

On 04/20/2018 03:00 PM, Matthias Brugger wrote: > Hi Stephen, > > On 11/15/2017 01:17 AM, Stephen Boyd wrote: >> On 11/14, Matthias Brugger wrote: >>> As the new mfd device is in place, switch probing >>> for the MMSYS to support invocation from the mfd device

Re: [PATCH 4/8] clk: mediatek: mt2701-mm: switch to mfd device

On 04/20/2018 03:00 PM, Matthias Brugger wrote: > Hi Stephen, > > On 11/15/2017 01:17 AM, Stephen Boyd wrote: >> On 11/14, Matthias Brugger wrote: >>> As the new mfd device is in place, switch probing >>> for the MMSYS to support invocation from the mfd device

Re: [PATCH 4/8] clk: mediatek: mt2701-mm: switch to mfd device

Hi Stephen, On 11/15/2017 01:17 AM, Stephen Boyd wrote: > On 11/14, Matthias Brugger wrote: >> As the new mfd device is in place, switch probing >> for the MMSYS to support invocation from the mfd device. >> >> Signed-off-by: Matthias Brugger <mbrug...@suse.com> &

Re: [PATCH 4/8] clk: mediatek: mt2701-mm: switch to mfd device

Hi Stephen, On 11/15/2017 01:17 AM, Stephen Boyd wrote: > On 11/14, Matthias Brugger wrote: >> As the new mfd device is in place, switch probing >> for the MMSYS to support invocation from the mfd device. >> >> Signed-off-by: Matthias Brugger >> --- > > Ac

Re: [PATCH 1/8] drm/mediatek: Use regmap for register access

Hi Philipp, On 11/23/2017 09:54 AM, Philipp Zabel wrote: > Hi Matthias, > > On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: >> The mmsys memory space is shared between the drm and the >> clk driver. Use regmap to access it. >> >> Signed-off-by: Ma

Re: [PATCH 1/8] drm/mediatek: Use regmap for register access

Hi Philipp, On 11/23/2017 09:54 AM, Philipp Zabel wrote: > Hi Matthias, > > On Tue, 2017-11-14 at 22:41 +0100, Matthias Brugger wrote: >> The mmsys memory space is shared between the drm and the >> clk driver. Use regmap to access it. >> >> Signed-off-by: Matthia

Re: [PATCH v1 5/7] soc: mediatek: add a fixed wait for SRAM stable

efore, it's necessary for such a power domain to have a fixed > and well-predefined duration to wait until its managed SRAM can be allowed > to access by all functions running on the top. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Matthias Brugger <matthias@gmail.c

Re: [PATCH v1 5/7] soc: mediatek: add a fixed wait for SRAM stable

to have a fixed > and well-predefined duration to wait until its managed SRAM can be allowed > to access by all functions running on the top. > > Signed-off-by: Sean Wang > Cc: Matthias Brugger > Cc: Ulf Hansson > Cc: Weiyi Lu > --- > drivers/soc/mediatek/mtk-scpsys.

Re: [PATCH v1 4/7] soc: mediatek: reuse regmap_read_poll_timeout helpers

On 04/03/2018 09:15 AM, sean.w...@mediatek.com wrote: > From: Sean Wang <sean.w...@mediatek.com> > > Reuse the common helpers regmap_read_poll_timeout provided by Linux core > instead of an open-coded handling. > > Signed-off-by: Sean Wang <sean.w...@mediatek.

Re: [PATCH v1 4/7] soc: mediatek: reuse regmap_read_poll_timeout helpers

On 04/03/2018 09:15 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > Reuse the common helpers regmap_read_poll_timeout provided by Linux core > instead of an open-coded handling. > > Signed-off-by: Sean Wang > Cc: Matthias Brugger > Cc: Ulf Hansson > Cc:

Re: [PATCH v1 3/7] soc: mediatek: reuse read[l,x]_poll_timeout helpers

is renamed to pdn_ack in order to be > consistent with the one used in scpsys_power_off. > > Signed-off-by: Sean Wang <sean.w...@mediatek.com> > Cc: Matthias Brugger <matthias@gmail.com> > Cc: Ulf Hansson <ulf.hans...@linaro.org> > Cc: Weiyi Lu <we

Re: [PATCH v1 3/7] soc: mediatek: reuse read[l,x]_poll_timeout helpers

dn_ack in order to be > consistent with the one used in scpsys_power_off. > > Signed-off-by: Sean Wang > Cc: Matthias Brugger > Cc: Ulf Hansson > Cc: Weiyi Lu > --- pushed to v4.17-next/soc Thanks! > drivers/soc/mediatek/mtk-scpsys.c | 91 > ++---

Re: [PATCH V3 3/4] soc: mediatek: pwrap: add mt6351 for mt6797 SoCs

Please update the subject line, we don't add mt5797 here. More comments below. On 03/23/2018 09:32 AM, argus@mediatek.com wrote: > From: Argus Lin > > mt6351 is a new power management IC and it is > used for mt6797 SoCs. We need to add mt6351_regs for > pmic

Re: [PATCH V3 3/4] soc: mediatek: pwrap: add mt6351 for mt6797 SoCs

Please update the subject line, we don't add mt5797 here. More comments below. On 03/23/2018 09:32 AM, argus@mediatek.com wrote: > From: Argus Lin > > mt6351 is a new power management IC and it is > used for mt6797 SoCs. We need to add mt6351_regs for > pmic register mapping and

Re: [PATCH V3 2/4] soc: mediatek: pwrap: add pwrap for mt6797 SoCs

On 03/23/2018 09:32 AM, argus@mediatek.com wrote: > From: Argus Lin > > mt6797 is a highly integrated SoCs, it uses mt6351 for power > management. We need to add pwrap support to access mt6351. > Pwrap of mt6797 also add new feature include starvation and > request

Re: [PATCH V3 2/4] soc: mediatek: pwrap: add pwrap for mt6797 SoCs

On 03/23/2018 09:32 AM, argus@mediatek.com wrote: > From: Argus Lin > > mt6797 is a highly integrated SoCs, it uses mt6351 for power > management. We need to add pwrap support to access mt6351. > Pwrap of mt6797 also add new feature include starvation and > request exception interrupt,

Re: [PATCH] soc: mediatek: use of_device_get_match_data()

On 04/16/2018 04:33 AM, Ryder Lee wrote: > The usage of of_device_get_match_data() reduce the code size a bit. > > Also, the only way to call pwrap_probe() is to match an entry in > of_pwrap_match_tbl[], so of_id cannot be NULL. > > Signed-off-by: Ryder Lee > ---

Re: [PATCH] soc: mediatek: use of_device_get_match_data()

On 04/16/2018 04:33 AM, Ryder Lee wrote: > The usage of of_device_get_match_data() reduce the code size a bit. > > Also, the only way to call pwrap_probe() is to match an entry in > of_pwrap_match_tbl[], so of_id cannot be NULL. > > Signed-off-by: Ryder Lee > --- Applied to v4.17-next/soc

Re: [PATCH v4 1/5] arm64: dts: mt2712: add pintcrl file

On 03/22/2018 03:58 AM, Zhiyong Tao wrote: > This patch adds pinctrl file for mt2712. > > Signed-off-by: Zhiyong Tao > Reviewed-by: Rob Herring > --- Applied to v4.17-next/dts64 > arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1123 >

Re: [PATCH v4 1/5] arm64: dts: mt2712: add pintcrl file

On 03/22/2018 03:58 AM, Zhiyong Tao wrote: > This patch adds pinctrl file for mt2712. > > Signed-off-by: Zhiyong Tao > Reviewed-by: Rob Herring > --- Applied to v4.17-next/dts64 > arch/arm64/boot/dts/mediatek/mt2712-pinfunc.h | 1123 > + > 1 file changed, 1123

Re: [PATCH v4 2/5] arm64: dts: mt2712: add pintcrl device node.

On 03/22/2018 03:58 AM, Zhiyong Tao wrote: > This patch adds pintcrl device node for mt2712. > > Signed-off-by: Zhiyong Tao > --- Applied to v4.17-next/dts64 Thanks! > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 18 ++ > 1 file changed, 18

Re: [PATCH v4 2/5] arm64: dts: mt2712: add pintcrl device node.

On 03/22/2018 03:58 AM, Zhiyong Tao wrote: > This patch adds pintcrl device node for mt2712. > > Signed-off-by: Zhiyong Tao > --- Applied to v4.17-next/dts64 Thanks! > arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git

Re: [PATCH v4 6/6] arm: dts: mediatek: modify audio related nodes for both MT2701 and MT7623

On 03/06/2018 10:09 AM, Ryder Lee wrote: > Modify audio related nodes to reflect the actual usage in binding documents. > > Signed-off-by: Ryder Lee > --- applied to v4.17-next/dts32 Thanks! > arch/arm/boot/dts/mt2701.dtsi | 188

Re: [PATCH v4 6/6] arm: dts: mediatek: modify audio related nodes for both MT2701 and MT7623

On 03/06/2018 10:09 AM, Ryder Lee wrote: > Modify audio related nodes to reflect the actual usage in binding documents. > > Signed-off-by: Ryder Lee > --- applied to v4.17-next/dts32 Thanks! > arch/arm/boot/dts/mt2701.dtsi | 188 - >

Re: [PATCH v2 0/5] update Mediatek MT2712 clock and scpsys support

On 03/21/2018 10:11 AM, Matthias Brugger wrote: > > > On 03/20/2018 08:23 AM, Stephen Boyd wrote: >> Quoting Weiyi Lu (2018-03-19 23:07:48) >>> On Mon, 2018-03-12 at 15:03 +0800, Weiyi Lu wrote: >>>> This series is based on v4.16-rc1 and composed of scpsys

Re: [PATCH v2 0/5] update Mediatek MT2712 clock and scpsys support

On 03/21/2018 10:11 AM, Matthias Brugger wrote: > > > On 03/20/2018 08:23 AM, Stephen Boyd wrote: >> Quoting Weiyi Lu (2018-03-19 23:07:48) >>> On Mon, 2018-03-12 at 15:03 +0800, Weiyi Lu wrote: >>>> This series is based on v4.16-rc1 and composed of scpsys

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

On 03/27/2018 10:05 AM, Lee Jones wrote: > On Fri, 23 Mar 2018, Dmitry Torokhov wrote: >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote: >>> Hi, Dmitry and Lee >>> >>> The series seems not being got merged. Are they good enough to be ready >>> into the your tree? >>> >>> Recently

Re: [PATCH v6 0/6] Add MediaTek PMIC keys support

On 03/27/2018 10:05 AM, Lee Jones wrote: > On Fri, 23 Mar 2018, Dmitry Torokhov wrote: >> On Thu, Mar 22, 2018 at 10:17:53AM +0800, Sean Wang wrote: >>> Hi, Dmitry and Lee >>> >>> The series seems not being got merged. Are they good enough to be ready >>> into the your tree? >>> >>> Recently

Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

On 03/23/2018 04:44 AM, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang <rick.ch...@mediatek.com> > Cc: Bin Liu <bin@mediatek.com> > Signed-off-by: Ryder Lee <ryder....@mediatek.com> Review

Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init()

On 03/23/2018 04:44 AM, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang > Cc: Bin Liu > Signed-off-by: Ryder Lee Reviewed-by: Matthias Brugger > --- > drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++--

Re: [PATCH v2 0/5] update Mediatek MT2712 clock and scpsys support

On 03/20/2018 08:23 AM, Stephen Boyd wrote: > Quoting Weiyi Lu (2018-03-19 23:07:48) >> On Mon, 2018-03-12 at 15:03 +0800, Weiyi Lu wrote: >>> This series is based on v4.16-rc1 and composed of scpsys control (PATCH >>> 1-2) and clock control (PATCH 3-5). >>> Basically, all changes are for the

Re: [PATCH v2 0/5] update Mediatek MT2712 clock and scpsys support

On 03/20/2018 08:23 AM, Stephen Boyd wrote: > Quoting Weiyi Lu (2018-03-19 23:07:48) >> On Mon, 2018-03-12 at 15:03 +0800, Weiyi Lu wrote: >>> This series is based on v4.16-rc1 and composed of scpsys control (PATCH >>> 1-2) and clock control (PATCH 3-5). >>> Basically, all changes are for the

Re: [PATCH v1 02/19] dt-bindings: cpufreq: mediatek: use - instead of _ in examples

Hi Sean, On 03/19/2018 03:51 AM, Sean Wang wrote: > > Hi, Matthias > > I'm worried you missed the patch which already got both tags Reviewed-by > from Rob and Acked-by: Viresh and thus I thought it > should be ready for your tree. > Yes, sorry I missed this one. Fortunately it is not

Re: [PATCH v1 02/19] dt-bindings: cpufreq: mediatek: use - instead of _ in examples

Hi Sean, On 03/19/2018 03:51 AM, Sean Wang wrote: > > Hi, Matthias > > I'm worried you missed the patch which already got both tags Reviewed-by > from Rob and Acked-by: Viresh and thus I thought it > should be ready for your tree. > Yes, sorry I missed this one. Fortunately it is not

Re: [PATCH 3/3] arm64: dts: mt2712: Add auxadc device node.

On 10/16/2017 05:09 PM, Matthias Brugger wrote: > > > On 10/13/2017 05:11 PM, Matthias Brugger wrote: >> >> >> On 09/24/2017 05:47 PM, Jonathan Cameron wrote: >>> On Thu, 21 Sep 2017 09:26:52 +0800 >>> Zhiyong Tao <zhiyong@mediatek.com>

Re: [PATCH 3/3] arm64: dts: mt2712: Add auxadc device node.

On 10/16/2017 05:09 PM, Matthias Brugger wrote: > > > On 10/13/2017 05:11 PM, Matthias Brugger wrote: >> >> >> On 09/24/2017 05:47 PM, Jonathan Cameron wrote: >>> On Thu, 21 Sep 2017 09:26:52 +0800 >>> Zhiyong Tao wrote: >>> >&g

Re: [PATCH v1] arm: dts: mt7623: add PCIe related nodes

On 02/14/2018 04:27 AM, Ryder Lee wrote: > This patch adds some device nodes for the PCIe function block and updates > related pinmux. > > Moreover, we add interrupt-map properties in both parent and children as > the chip only has one IRQ per slot that is connected to all INTx and get >

Re: [PATCH v1] arm: dts: mt7623: add PCIe related nodes

On 02/14/2018 04:27 AM, Ryder Lee wrote: > This patch adds some device nodes for the PCIe function block and updates > related pinmux. > > Moreover, we add interrupt-map properties in both parent and children as > the chip only has one IRQ per slot that is connected to all INTx and get >

Re: [PATCH v2 1/5] dt-bindings: soc: update MT2712 power dt-bindings

On 03/12/2018 08:03 AM, Weiyi Lu wrote: > Add new power domains(MFG_SC1/MFG_SC2/MFG_SC3) > for MT2712 according to ECO design change. > > Signed-off-by: Weiyi Lu > Reviewed-by: Rob Herring Pushed to v4.16-next/soc Thanks! > --- >

Re: [PATCH v2 1/5] dt-bindings: soc: update MT2712 power dt-bindings

On 03/12/2018 08:03 AM, Weiyi Lu wrote: > Add new power domains(MFG_SC1/MFG_SC2/MFG_SC3) > for MT2712 according to ECO design change. > > Signed-off-by: Weiyi Lu > Reviewed-by: Rob Herring Pushed to v4.16-next/soc Thanks! > --- > include/dt-bindings/power/mt2712-power.h | 3 +++ > 1 file

Re: [PATCH v2 2/5] soc: mediatek: update power domain data of MT2712

On 03/12/2018 08:03 AM, Weiyi Lu wrote: > 1. split MFG power domain into MFG/MFG_SC1/MFG_SC2/MFG_SC3 > according to MT2712 ECO design change > 2. add subdomain support for MT2712 > > Signed-off-by: Weiyi Lu Pushed to v4.16-next/soc Thanks! > --- >

Re: [PATCH v2 2/5] soc: mediatek: update power domain data of MT2712

On 03/12/2018 08:03 AM, Weiyi Lu wrote: > 1. split MFG power domain into MFG/MFG_SC1/MFG_SC2/MFG_SC3 > according to MT2712 ECO design change > 2. add subdomain support for MT2712 > > Signed-off-by: Weiyi Lu Pushed to v4.16-next/soc Thanks! > --- > drivers/soc/mediatek/mtk-scpsys.c | 42 >

Re: [PATCH v1 10/19] arm: dts: mt7623: remove useless property pinctrl-names at node switch@0

On 02/23/2018 11:16 AM, sean.w...@mediatek.com wrote: > From: Sean Wang > > The property pinctrl-names is totally superfluous. It would be good to > remove the property to keep the node neatness. There is actually > unnecessary to set up any pins for data path TRGMII

<    4   5   6   7   8   9   10   11   12   13   >