Re: [PATCH] media: saa7134: keep demod i2c gate open on Medion 7134

Hi Maciej, some comment about wording in commit message and code-comment. As far as I know the terms are defined like this: * gate open = i2c-clients behind gate can be reached * gate closed = i2c-clients behind gate are not reachable Regards Matthias Am 19.08.19 um 00:55 schrieb Maciej S. Szmi

Re: [PATCH v3] media: si2168: Refactor command setup code

Am 13.07.19 um 12:02 schrieb Mauro Carvalho Chehab: > Em Sat, 13 Jul 2019 00:11:12 +0200 > Marc Gonzalez escreveu: > >> On 12/07/2019 19:45, Mauro Carvalho Chehab wrote: >> >>> Brad Love escreveu: >>> >>> IMHO, using sizeof() here is a very bad idea. >> >> You may have a point... >> (Though

Re: [PATCH v2] media: si2165: fix a missing check of return value

Am 05.03.19 um 22:17 schrieb Sean Young: > On Fri, Dec 21, 2018 at 09:24:46AM +0100, Matthias Schwarzott wrote: >> Am 21.12.18 um 05:54 schrieb Kangjie Lu: >>> si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find >>> that "val_tmp"

Re: [PATCH] media: mt312: fix a missing check of mt312 reset

t looks correct. Reviewed-by: Matthias Schwarzott > --- > drivers/media/dvb-frontends/mt312.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/media/dvb-frontends/mt312.c > b/drivers/media/dvb-frontends/mt312.c > index 03e74a729168..bfbb87946

Re: [PATCH v2] media: si2165: fix a missing check of return value

) fails, > "val" will be a random value. Further use will lead to undefined > behaviors. The fix checks if si2165_readreg8() fails, and if so, returns > its error code upstream. > > Signed-off-by: Kangjie Lu Reviewed-by: Matthias Schwarzott > --- > drivers/media/dvb

Re: [PATCH] media: si2165: fix a missing check of return value

Am 20.12.18 um 09:12 schrieb Kangjie Lu: > si2165_readreg8() may fail. Looking into si2165_readreg8(), we will find > that "val_tmp" will be an uninitialized value when regmap_read() fails. > "val_tmp" is then assigned to "val". So if si2165_readreg8() fails, > "val" will be a random value. Further

Re: usb/media/em28xx: use-after-free in dvb_unregister_frontend

Am 21.11.2017 um 14:51 schrieb Andrey Konovalov: > Hi! > Hi Andrey, > I've got the following report while fuzzing the kernel with syzkaller. > > On commit e1d1ea549b57790a3d8cf6300e6ef86118d692a3 (4.15-rc1). > > em28xx 1-1:9.0: Disconnecting > tc90522 1-0015: Toshiba TC90522 attached. > qm1d1c0

Re: usb/media/dtt200u: use-after-free in __dvb_frontend_free

Am 23.10.2017 um 16:41 schrieb Andrey Konovalov: > Hi! > > I've got the following report while fuzzing the kernel with syzkaller. > > On commit 3e0cc09a3a2c40ec1ffb6b4e12da86e98feccb11 (4.14-rc5+). > > dvb-usb: found a 'WideView WT-220U PenType Receiver (based on ZL353)' > in warm state. > dvb-u

Re: [PATCH] [media] si2165: Refactoring for si2165_writereg_mask8()

for the variable "ret" at the end. > > Signed-off-by: Markus Elfring The patch looks fine. Signed-off-by: Matthias Schwarzott Regards Matthias PS: I am going to switch to regmap, but this change is not yet polished and until now does not touch this function. -- To unsubscribe