Re: [PATCH v7 0/3] vduse: add support for networking devices

2024-02-29 Thread Maxime Coquelin
Hello Michael, On 2/1/24 09:40, Michael S. Tsirkin wrote: On Thu, Feb 01, 2024 at 09:34:11AM +0100, Maxime Coquelin wrote: Hi Jason, It looks like all patches got acked by you. Any blocker to queue the series for next release? Thanks, Maxime I think it's good enough at this point. Wil

Re: [PATCH] vduse: implement DMA sync callbacks

2024-02-21 Thread Maxime Coquelin
Hello Christoph, On 2/20/24 10:01, Christoph Hellwig wrote: On Mon, Feb 19, 2024 at 06:06:06PM +0100, Maxime Coquelin wrote: Since commit 295525e29a5b ("virtio_net: merge dma operations when filling mergeable buffers"), VDUSE device require support for DMA's .sync_single_for_cpu

[PATCH] vduse: implement DMA sync callbacks

2024-02-19 Thread Maxime Coquelin
implements both .sync_single_for_cpu() and .sync_single_for_device() callbacks, and also skip bounce buffer copies during DMA map and unmap operations if the DMA_ATTR_SKIP_CPU_SYNC attribute is set to avoid extra copies of the same buffer. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/iov

Re: [PATCH v7 0/3] vduse: add support for networking devices

2024-02-01 Thread Maxime Coquelin
On 2/1/24 09:40, Michael S. Tsirkin wrote: On Thu, Feb 01, 2024 at 09:34:11AM +0100, Maxime Coquelin wrote: Hi Jason, It looks like all patches got acked by you. Any blocker to queue the series for next release? Thanks, Maxime I think it's good enough at this point. Will put it in

Re: [PATCH v7 0/3] vduse: add support for networking devices

2024-02-01 Thread Maxime Coquelin
Hi Jason, It looks like all patches got acked by you. Any blocker to queue the series for next release? Thanks, Maxime On 1/9/24 12:10, Maxime Coquelin wrote: This small series enables virtio-net device type in VDUSE. With it, basic operation have been tested, both with virtio-vdpa and vhost

[PATCH v7 3/3] vduse: enable Virtio-net device type

2024-01-09 Thread Maxime Coquelin
Reviewed-by: Eugenio Pérez Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index 00f3f562ab5d..8924bbc55635 100644 --- a/drivers/vdpa

[PATCH v7 2/3] vduse: Temporarily fail if control queue feature requested

2024-01-09 Thread Maxime Coquelin
. Until it is completed, let's fail features check if control-queue feature is requested. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c

[PATCH v7 1/3] vduse: validate block features only with block devices

2024-01-09 Thread Maxime Coquelin
-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers/vdpa/vdpa_user/vduse_dev.c index 0ddd4b8abecb..a5af6d4077b8 100644 --- a/drivers/vdpa/vdpa_user/vduse_dev.c +++ b

[PATCH v7 0/3] vduse: add support for networking devices

2024-01-09 Thread Maxime Coquelin
Net device type (Jason). - Rebased on latest master. Changes in v5: == - Move control queue disablement patch before Net devices enablement (Jason). - Unify operations LSM hooks into a single hook. - Rebase on latest master. Maxime Coquelin (3): vduse: validate block features

Re: [PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

2024-01-05 Thread Maxime Coquelin
On 1/5/24 10:59, Eugenio Perez Martin wrote: On Fri, Jan 5, 2024 at 9:12 AM Maxime Coquelin wrote: On 1/5/24 03:45, Jason Wang wrote: On Thu, Jan 4, 2024 at 11:38 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE

Re: [PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

2024-01-05 Thread Maxime Coquelin
On 1/5/24 03:45, Jason Wang wrote: On Thu, Jan 4, 2024 at 11:38 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the kernel thread

[PATCH v6 3/3] vduse: enable Virtio-net device type

2024-01-04 Thread Maxime Coquelin
This patch adds Virtio-net device type to the supported devices types. Initialization fails if the device does not support VIRTIO_F_VERSION_1 feature, in order to guarantee the configuration space is read-only. It also fails with -EPERM if the CAP_NET_ADMIN is missing. Signed-off-by: Maxime

[PATCH v6 2/3] vduse: Temporarily fail if control queue features requested

2024-01-04 Thread Maxime Coquelin
. Until it is completed, let's fail features check if any control-queue related feature is requested. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers

[PATCH v6 1/3] vduse: validate block features only with block devices

2024-01-04 Thread Maxime Coquelin
This patch is preliminary work to enable network device type support to VDUSE. As VIRTIO_BLK_F_CONFIG_WCE shares the same value as VIRTIO_NET_F_HOST_TSO4, we need to restrict its check to Virtio-blk device type. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin

[PATCH v6 0/3] vduse: add support for networking devices

2024-01-04 Thread Maxime Coquelin
(Jason). - Rebased on latest master. Changes in v5: == - Move control queue disablement patch before Net devices enablement (Jason). - Unify operations LSM hooks into a single hook. - Rebase on latest master. Maxime Coquelin (3): vduse: validate block features only with block

Re: [PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type

2024-01-04 Thread Maxime Coquelin
On 12/18/23 18:33, Stephen Smalley wrote: On Mon, Dec 18, 2023 at 12:21 PM Stephen Smalley wrote: On Tue, Dec 12, 2023 at 8:17 AM Maxime Coquelin wrote: This patch introduces a LSM hook for devices creation, destruction (ioctl()) and opening (open()) operations, checking the application

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

2023-12-18 Thread Maxime Coquelin
On 12/18/23 03:50, Jason Wang wrote: On Wed, Dec 13, 2023 at 7:23 PM Maxime Coquelin wrote: Hi Jason, On 12/13/23 05:52, Jason Wang wrote: On Tue, Dec 12, 2023 at 9:17 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the

Re: [PATCH v5 2/4] vduse: Temporarily disable control queue features

2023-12-13 Thread Maxime Coquelin
Hi Jason, On 12/13/23 05:52, Jason Wang wrote: On Tue, Dec 12, 2023 at 9:17 PM Maxime Coquelin wrote: Virtio-net driver control queue implementation is not safe when used with VDUSE. If the VDUSE application does not reply to control queue messages, it currently ends up hanging the kernel

[PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type

2023-12-12 Thread Maxime Coquelin
This patch introduces a LSM hook for devices creation, destruction (ioctl()) and opening (open()) operations, checking the application is allowed to perform these operations for the Virtio device type. Signed-off-by: Maxime Coquelin --- MAINTAINERS | 1 + drivers/vdpa

[PATCH v5 2/4] vduse: Temporarily disable control queue features

2023-12-12 Thread Maxime Coquelin
. Until it is completed, let's disable control virtqueue and features that depend on it. Signed-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 37 ++ 1 file changed, 37 insertions(+) diff --git a/drivers/vdpa/vdpa_user/vduse_dev.c b/drivers

[PATCH v5 3/4] vduse: enable Virtio-net device type

2023-12-12 Thread Maxime Coquelin
This patch adds Virtio-net device type to the supported devices types. Initialization fails if the device does not support VIRTIO_F_VERSION_1 feature, in order to guarantee the configuration space is read-only. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin

[PATCH v5 1/4] vduse: validate block features only with block devices

2023-12-12 Thread Maxime Coquelin
This patch is preliminary work to enable network device type support to VDUSE. As VIRTIO_BLK_F_CONFIG_WCE shares the same value as VIRTIO_NET_F_HOST_TSO4, we need to restrict its check to Virtio-blk device type. Acked-by: Jason Wang Reviewed-by: Xie Yongji Signed-off-by: Maxime Coquelin

[PATCH v5 0/4] vduse: add support for networking devices

2023-12-12 Thread Maxime Coquelin
block device type, - net: Virtio networking device type. Changes in v5: == - Move control queue disablement patch before Net devices enablement (Jason). - Unify operations LSM hooks into a single hook. - Rebase on latest master. Maxime Coquelin (4): vduse: validate block features

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

2023-12-08 Thread Maxime Coquelin
On 12/8/23 13:26, Michael S. Tsirkin wrote: On Fri, Dec 08, 2023 at 01:23:00PM +0100, Maxime Coquelin wrote: On 12/8/23 12:05, Michael S. Tsirkin wrote: On Fri, Dec 08, 2023 at 12:01:15PM +0100, Maxime Coquelin wrote: Hello Paul, On 11/8/23 03:31, Paul Moore wrote: On Oct 20, 2023

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

2023-12-08 Thread Maxime Coquelin
On 12/8/23 12:05, Michael S. Tsirkin wrote: On Fri, Dec 08, 2023 at 12:01:15PM +0100, Maxime Coquelin wrote: Hello Paul, On 11/8/23 03:31, Paul Moore wrote: On Oct 20, 2023 "Michael S. Tsirkin" wrote: This patch introduces LSM hooks for devices creation, destruction a

Re: [PATCH v4 4/4] vduse: Add LSM hooks to check Virtio device type

2023-12-08 Thread Maxime Coquelin
ned-off-by: Maxime Coquelin --- drivers/vdpa/vdpa_user/vduse_dev.c | 12 +++ include/linux/lsm_hook_defs.h | 4 +++ include/linux/security.h| 15 security/security.c | 42 ++ security/selinux/hooks.c

Re: [PATCH 1/2] vdpa: ifcvf: return err when fail to request config irq

2020-08-12 Thread Maxime Coquelin
[ 1398.943845] R13: 7ffd0948e6a0 R14: R15: [ 1398.951809] Modules linked in: vxlan ip6_udp_tunnel udp_tunnel ip_vs_sh ip_vs_wrr ip_vs_rr ip_vs xt_comment xt_mark nf_tables xt_nat vetht [ 1398.951847] ghash_clmulni_intel iTCO_vendor_support mlx5_core dcdbas rapl intel_cstate intel_uncore ipmi_ssif pcspkr mxm_wmi mlxfw virtii Tested-by: Maxime Coquelin Thanks, Maxime

Re: [PATCH] watchdog: Respect watchdog cpumask on CPU hotplug

2019-03-28 Thread Maxime Coquelin
kernel.org/lkml/b99c5a25-a5fe-18dd-2f1d-bdd6834f0...@redhat.com/ That looks so. I had a trial with your patch, and I can confirm it fixes my issue: Tested-by: Maxime Coquelin Thanks, Maxime Thanks, tglx

[Regression]: NMI watchdog regression from v4.19 onwards

2019-03-08 Thread Maxime Coquelin
Hi Peter, Oleg, NMI watchdog fires systematically on my machine with recent Kernels, whereas the NMI watch is supposed to be disabled: # cat /proc/sys/kernel/watchdog 0 # cat /proc/sys/kernel/nmi_watchdog 0 # [ 53.765648] NMI watchdog: Watchdog detected hard LOCKUP on cpu 7 [ 53.765648] Mo

Re: [PATCH] MAINTAINERS: update entries for ARM/STM32

2018-02-26 Thread Maxime Coquelin
RS > @@ -1999,8 +1999,10 @@ M: Maxime Coquelin > M: Alexandre Torgue > L: linux-arm-ker...@lists.infradead.org (moderated for non-subscribers) > S: Maintained > -T: git git://git.kernel.org/pub/scm/linux/kernel/git/mcoquelin/stm32.git > +T: git git

Re: [PATCH v2] irqchip: stm32: Fix copyright

2017-11-30 Thread Maxime Coquelin
2017-11-30 9:45 GMT+01:00 Benjamin Gaignard : > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > Acked-by: Alexandre TORGUE > CC: Maxime Coquelin > --- > drivers/irqchip/irq-stm32-exti.c | 3 ++- > 1 file

Re: [PATCH v2] pinctrl: stm32: Fix copyright

2017-11-30 Thread Maxime Coquelin
2017-11-30 9:46 GMT+01:00 Benjamin Gaignard : > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > Acked-by: Alexandre TORGUE > CC: Maxime Coquelin > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 3 ++-

Re: [PATCH v4] arch: arm: mach-stm32: Fix copyright

2017-11-30 Thread Maxime Coquelin
2017-11-30 9:49 GMT+01:00 Benjamin Gaignard : > Uniformize STMicroelectronics copyrights header > Add SPDX identifier > > Signed-off-by: Benjamin Gaignard > CC: Maxime Coquelin > --- > arch/arm/mach-stm32/board-dt.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(

Re: [PATCH v6 2/4] drivers: irqchip: Add STM32 external interrupts support

2016-09-21 Thread Maxime Coquelin
either on rising, falling or both edges. Each line can also >> > > be masked independently. >> > > >> > > Signed-off-by: Maxime Coquelin >> > > Signed-off-by: Alexandre TORGUE >> > >> > That all looks very reasonable now. The only

Re: [PATCH v2 07/10] reset: stm32: add driver Kconfig option

2016-09-03 Thread Maxime Coquelin
2016-08-30 10:24 GMT+02:00 Philipp Zabel : > Visible only if COMPILE_TEST is enabled, this allows to include the > driver in build tests. > > Cc: Maxime Coquelin > Cc: Gabriel Fernandez > Reviewed-by: Masahiro Yamada > Signed-off-by: Philipp Zabel > --- >

[PATCH] MAINTAINERS: update STM32 maintainers list

2016-06-22 Thread Maxime Coquelin
I will have less time to work on STM32 platform, so I propose Alexandre as co-maintainer. Alex is working in the STMicroelectronics division in charge of STM32 family, so he will have access to all technical information and hardware. Signed-off-by: Maxime Coquelin Cc: Alexandre Torgue

[PATCH] MAINTAINERS: update STi maintainer list

2016-06-21 Thread Maxime Coquelin
Remove myself as STi maintainer as I will no longer have access to STi platforms, and remove Srini too, who now works on other platforms. Patrice will manage the pull requests. Signed-off-by: Maxime Coquelin Cc: Patrice Chotard Cc: Srinivas Kandagatla Cc: Arnd Bergmann --- MAINTAINERS | 2

Re: [PATCH V2 12/63] clocksource/drivers/armv7m_systick: Convert init function to return error

2016-06-20 Thread Maxime Coquelin
eturn back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/armv7m_systick.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH V2 08/63] clocksource/drivers/st_lpc: Convert init function to return error

2016-06-20 Thread Maxime Coquelin
-off-by: Daniel Lezcano --- drivers/clocksource/clksrc_st_lpc.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH V2 18/63] clocksource/drivers/arm_global_timer: Convert init function to return error

2016-06-20 Thread Maxime Coquelin
. Signed-off-by: Daniel Lezcano --- drivers/clocksource/arm_global_timer.c | 28 ++-- 1 file changed, 18 insertions(+), 10 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH V2 47/63] clocksource/drivers/timer-stm32: Convert init function to return error

2016-06-20 Thread Maxime Coquelin
ust return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano > --- > drivers/clocksource/timer-stm32.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

[PATCH v4.7-rc] ARM: dts: STi: stih407-family: Disable reserved-memory co-processor nodes

2016-06-17 Thread Maxime Coquelin
tive use at the time of this writing and b) it is not affected by the current default behaviour which is causing issues. Fixes: fe135c6 (ARM: dts: STiH407: Move over to using the 'reserved-memory' API for obtaining DMA memory) Signed-off-by: Lee Jones Reviewed-by Peter Griffin Signed-

Re: [PATCH] ARM: dts: STi: stih407-family: Disable reserved-memory co-processor nodes

2016-06-17 Thread Maxime Coquelin
h/arm/boot/dts/stih407-family.dtsi | 3 +++ 1 file changed, 3 insertions(+) That sounds reasonable: Acked-by: Maxime Coquelin Arnd, Olof, can you pick this patch directly in -rc fixes, as it prevents STi boards to boot correctly? Thanks in advance, Maxime

Re: [PATCH v2 3/5] ARM: dts: Add I2C1 support for STM32F429 SoC

2016-06-02 Thread Maxime Coquelin
2016-06-02 16:26 GMT+02:00 M'boumba Cedric Madianga : > Signed-off-by: Patrice Chotard > Signed-off-by: M'boumba Cedric Madianga > --- > arch/arm/boot/dts/stm32f429.dtsi | 24 > 1 file changed, 24 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32f429.dtsi > b/arch/

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

2016-06-02 Thread Maxime Coquelin
Hi Cedric, 2016-06-02 17:35 GMT+02:00 M'boumba Cedric Madianga : > Hi, > >>> + >>> +/** >>> + * stm32f4_i2c_xfer() - Transfer combined I2C message >>> + * @i2c_adap: Adapter pointer to the controller >>> + * @msgs: Pointer to data to be written. >>> + * @num: Number of messages to be executed >>>

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

2016-06-01 Thread Maxime Coquelin
2016-06-01 16:01 GMT+02:00 M'boumba Cedric Madianga : > Hi Maxime, > +static void stm32f4_i2c_set_speed_mode(struct stm32f4_i2c_dev *i2c_dev) +{ + struct stm32f4_i2c_timings *t = &i2c_timings[i2c_dev->speed]; + u32 ccr, val, clk_rate; + + ccr = readl_

[PATCH] hwrng: stm32: fix maybe uninitialized variable warning

2016-05-26 Thread Maxime Coquelin
Suggested-by: Arnd Bergmann Cc: Daniel Thompson Signed-off-by: Maxime Coquelin --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c index 92a810648bd0..63d84

Re: [PATCH v2] pinctrl: stm32: factorize stm32_pconf_input/output_get()

2016-05-24 Thread Maxime Coquelin
deletions(-) Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 12:09 GMT+02:00 Daniel Thompson : > On 24/05/16 09:50, Maxime Coquelin wrote: >> >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_random/

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 10:58 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 10:50:17 AM CEST Maxime Coquelin wrote: >> diff --git a/drivers/char/hw_random/stm32-rng.c >> b/drivers/char/hw_random/stm32-rng.c >> index 92a810648bd0..2a0fc90e4dc3 100644 >> --- a/drivers/char/hw_

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-24 10:32 GMT+02:00 Arnd Bergmann : > On Tuesday, May 24, 2016 9:59:41 AM CEST Maxime Coquelin wrote: >> 2016-05-23 22:35 GMT+02:00 Arnd Bergmann : >> > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> >> diff --git a/drivers/char/hw_random/stm

Re: [PATCH] hwrng: stm32 - fix build warning

2016-05-24 Thread Maxime Coquelin
2016-05-23 22:35 GMT+02:00 Arnd Bergmann : > On Monday, May 23, 2016 6:14:08 PM CEST Sudip Mukherjee wrote: >> We have been getting build warning about: >> drivers/char/hw_random/stm32-rng.c: In function 'stm32_rng_read': >> drivers/char/hw_random/stm32-rng.c:82:19: warning: 'sr' may be used >>

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-18 Thread Maxime Coquelin
2016-05-18 11:31 GMT+02:00 Arnd Bergmann : > On Wednesday 18 May 2016 09:48:53 Maxime Coquelin wrote: >> 2016-05-17 18:25 GMT+02:00 David Miller : >> > From: Maxime Coquelin >> > Date: Tue, 17 May 2016 11:20:16 +0200 >> > >> >> Hi David, >

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-18 Thread Maxime Coquelin
2016-05-17 18:25 GMT+02:00 David Miller : > From: Maxime Coquelin > Date: Tue, 17 May 2016 11:20:16 +0200 > >> Hi David, >> >> 2016-05-09 21:06 GMT+02:00 David Miller : >>> From: Alexandre TORGUE >>> Date: Mon, 9 May 2016 12:31:33 +0200 >>&

Re: [PATCH 2/5] i2c: Add STM32F4 I2C driver

2016-05-17 Thread Maxime Coquelin
Hi Cedric, 2016-05-11 17:36 GMT+02:00 M'boumba Cedric Madianga : > This patch adds support for the STM32F4 I2C controller. > > Signed-off-by: M'boumba Cedric Madianga > --- > drivers/i2c/busses/Kconfig | 10 + > drivers/i2c/busses/Makefile | 1 + > drivers/i2c/busses/i2c-stm32f4.c

Re: [RESEND PATCH v6 0/6] Add Ethernet support on STM32F429

2016-05-17 Thread Maxime Coquelin
Hi David, 2016-05-09 21:06 GMT+02:00 David Miller : > From: Alexandre TORGUE > Date: Mon, 9 May 2016 12:31:33 +0200 > >> STM32F429 Chip embeds a Synopsys 3.50a MAC IP. >> This series: >> -enhance current stmmac driver to control it (code already >> available) and adds basic glue for STM32F429 c

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-05-02 Thread Maxime Coquelin
2016-04-30 13:32 GMT+02:00 Linus Walleij : > On Fri, Apr 29, 2016 at 1:19 PM, Maxime Coquelin > wrote: >> It looks like this: http://pastebin.com/raw/cs2WiNKZ >> You can directly check section 12.2.5 of the stm32f429 reference manual: >> http://www2.st.com/resource/en/ref

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-29 Thread Maxime Coquelin
On 04/28/2016 04:57 PM, Wolfram Sang wrote: The trick is to switch to SPI mode, 9 bits words and write a 0, so that 9 clock pulses are generated. Heh. As long as it works :) But as you said, it really needs a comment. :) I didn't faced the problem myself, but it looks good with an oscillosco

Re: [PATCH v6 2/6] Documentation: Bindings: Add STM32 DWMAC glue

2016-04-29 Thread Maxime Coquelin
2016-04-28 22:59 GMT+02:00 Rob Herring : > On Mon, Apr 25, 2016 at 01:53:58PM +0200, Alexandre TORGUE wrote: >> Signed-off-by: Alexandre TORGUE > > Acked-by: Rob Herring Thanks Rob! Arnd, I only have patches 4, 5 and 6 of this series for stm32 (2 DT, one defconfig) for v4.7. Should I send a pul

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-04-29 Thread Maxime Coquelin
2016-04-29 10:53 GMT+02:00 Linus Walleij : > On Tue, Apr 19, 2016 at 11:04 AM, Maxime Coquelin > wrote: >> 2016-04-08 11:43 GMT+02:00 Linus Walleij : >>> On Thu, Mar 31, 2016 at 5:09 PM, Maxime Coquelin >>> wrote: >>> >>>> +static int stm32_

Re: [PATCH] i2c: st: Implement i2c_bus_recovery_info callbacks

2016-04-28 Thread Maxime Coquelin
Hi Wolfram, On 04/24/2016 11:10 PM, Wolfram Sang wrote: +/* + * i2c bus recovery routines + * get_scl and set_scl must be defined to avoid the recover_bus field of + * i2c_bus_recovery_info to be overriden with NULL during the + * i2c_add_adapter call + */ Oh, that shouldn't be like this. Can y

Re: [PATCH v6 6/6] ARM: dts: stm32f429: Update Ethernet node on Eval board

2016-04-28 Thread Maxime Coquelin
2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > Update new pinctrl phandle name and use new node name. > > Signed-off-by: Alexandre TORGUE > > diff --git a/arch/arm/boot/dts/stm32429i-eval.dts > b/arch/arm/boot/dts/stm32429i-eval.dts Acked-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH v6 5/6] ARM: dts: stm32f429: Align Ethernet node with new bindings properties

2016-04-28 Thread Maxime Coquelin
Hi Alex, 2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > This patch aligns clocks names and node reference according to new > stm32-dwmac glue binding. It also renames Ethernet pinctrl phandle > (indeed there is no need to add 0 as Ethernet instance as there is only > one IP in SOC). > > Signed-of

Re: [PATCH v6 4/6] ARM: STM32: Enable Ethernet in stm32_defconfig

2016-04-28 Thread Maxime Coquelin
Hi Alex, 2016-04-25 13:54 GMT+02:00 Alexandre TORGUE : > Enable basic Ethernet support (IPV4) for stm32 defconfig. > > Signed-off-by: Alexandre TORGUE Acked-by: Maxime Coquelin Thanks! Maxime

Re: [[PATCH v2] 1/8] ARM: dts: STi: STiH407: Provide generic (safe) DVFS configuration

2016-04-26 Thread Maxime Coquelin
e ST CPUFreq driver will over-ride these generic values. Signed-off-by: Lee Jones Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stih407-family.dtsi | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.

Re: [PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-04-19 Thread Maxime Coquelin
Hi Linus 2016-04-08 11:43 GMT+02:00 Linus Walleij : > On Thu, Mar 31, 2016 at 5:09 PM, Maxime Coquelin > wrote: > >> +static int stm32_gpio_to_irq(struct gpio_chip *chip, unsigned offset) >> +{ >> + struct stm32_pinctrl *pctl = dev_get_drvdata(chip-

Re: [PATCH v2 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-04-19 Thread Maxime Coquelin
Hi Linus, Sorry for the late reply, I was off last week. 2016-04-08 11:38 GMT+02:00 Linus Walleij : > On Thu, Mar 31, 2016 at 5:09 PM, Maxime Coquelin > wrote: > >> +static void stm32_irq_handler(struct irq_desc *desc) >> +{ >> + struct irq_domain *domain = irq

Re: [PATCH v2 1/9] Documentation: dt-bindings: Document STM32 EXTI controller bindings

2016-04-04 Thread Maxime Coquelin
Hi Rob, 2016-04-04 7:15 GMT+02:00 Rob Herring : > On Thu, Mar 31, 2016 at 05:09:31PM +0200, Maxime Coquelin wrote: >> Signed-off-by: Maxime Coquelin >> --- >> .../bindings/interrupt-controller/st,stm32-exti.txt | 20 >> >> 1 file changed,

[PATCH v2 4/9] ARM: dts: Add EXTI controller node to stm32f429

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32f429.dtsi | 8 1 file changed, 8 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index 35df462559ca..1a189d44ad38 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++ b/arch/arm/boot

[PATCH v2 3/9] ARM: STM32: Select external interrupts controller

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- arch/arm/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index cdfa6c2b7626..13b230a731eb 100644 --- a/arch/arm/Kconfig +++ b/arch/arm/Kconfig @@ -884,6 +884,7 @@ config ARCH_STM32 select CLKSRC_STM32

[PATCH v2 8/9] ARM: dts: Declare push button as GPIO key on stm32f429 Disco board

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32429i-eval.dts | 18 ++ arch/arm/boot/dts/stm32f429-disco.dts | 13 + 2 files changed, 31 insertions(+) diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts index

[PATCH v2 1/9] Documentation: dt-bindings: Document STM32 EXTI controller bindings

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- .../bindings/interrupt-controller/st,stm32-exti.txt | 20 1 file changed, 20 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt-controller/st,stm32-exti.txt diff --git a/Documentation/devicetree/bindings

[PATCH v2 6/9] pinctrl: Add IRQ support to STM32 gpios

2016-03-31 Thread Maxime Coquelin
System Config registers. Signed-off-by: Maxime Coquelin --- drivers/pinctrl/stm32/Kconfig | 1 + drivers/pinctrl/stm32/pinctrl-stm32.c | 68 +++ 2 files changed, 69 insertions(+) diff --git a/drivers/pinctrl/stm32/Kconfig b/drivers/pinctrl/stm32/Kconfig

[PATCH v2 7/9] ARM: dts: Add GPIO irq support to STM2F429

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32f429.dtsi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b/arch/arm/boot/dts/stm32f429.dtsi index 1a189d44ad38..68247625a8d5 100644 --- a/arch/arm/boot/dts/stm32f429.dtsi +++ b/arch/arm/boot/dts

[PATCH v2 9/9] ARM: config: Enable GPIO Key driver in stm32_defconfig

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- arch/arm/configs/stm32_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig index 1e5ec2a0e4cf..e7b56d4f1798 100644 --- a/arch/arm/configs/stm32_defconfig +++ b

[PATCH v2 5/9] Documentation: dt-bindings: Add IRQ related properties of STM32 pinctrl

2016-03-31 Thread Maxime Coquelin
Signed-off-by: Maxime Coquelin --- Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/st,stm32-pinctrl.txt index

[PATCH v2 0/9] Add STM32 EXTI interrupt controller support

2016-03-31 Thread Maxime Coquelin
irq (Linus W.) Maxime Coquelin (9): Documentation: dt-bindings: Document STM32 EXTI controller bindings drivers: irqchip: Add STM32 external interrupts support ARM: STM32: Select external interrupts controller ARM: dts: Add EXTI controller node to stm32f429 Documentation: dt-bindings: Add

[PATCH v2 2/9] drivers: irqchip: Add STM32 external interrupts support

2016-03-31 Thread Maxime Coquelin
. Signed-off-by: Maxime Coquelin --- drivers/irqchip/Kconfig | 4 + drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-stm32-exti.c | 169 +++ 3 files changed, 174 insertions(+) create mode 100644 drivers/irqchip/irq-stm32-exti.c diff --git a

Re: [PATCH] MAINTAINERS: Add the stlinux kernel mailing list for the STi drm driver.

2016-03-18 Thread Maxime Coquelin
they want to be maintainers of this driver (which I think probably makes sense given that the display IP is quite complicated). I agree with Peter, let's just add kernel@stlinux entry in the DRM STi entry. Acked-by: Maxime Coquelin Regards, Maxime

Re: [PATCH v2 0/4] Add Ethernet support on STM32F429

2016-03-01 Thread Maxime Coquelin
/ethernet/stmicro/stmmac/stmmac_platform.c | 1 + 6 files changed, 272 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/stm32-dwmac.txt create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c You can add my: Tested-by: Maxime Coquelin Thanks! Maxime

Re: [PATCH v3 4/4] ARM: STM32: Enable Ethernet in stm32_defconfig

2016-03-01 Thread Maxime Coquelin
Hi Alex, Arnd, On 02/26/2016 11:51 AM, Alexandre TORGUE wrote: Enable basic Ethernet support (IPV4) for stm32 defconfig. Signed-off-by: Alexandre TORGUE diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig index ec52505..8b8abe0 100644 --- a/arch/arm/configs/stm32_

Re: [PATCH 2/3] ARM: dts: stm32f429: Add Ethernet support

2016-03-01 Thread Maxime Coquelin
Hi Alex, I have made a handful of changes on your patch, let me know if this is ok for you. If ok, it will be part of the PR I'll send tomorrow. On 02/29/2016 05:29 PM, Alexandre TORGUE wrote: Add Ethernet support (Synopsys MAC IP 3.50a) on stm32f429 SOC. Signed-off-by: Alexandre TOR

Re: [PATCH 5/8] drivers/pinctrl: make stm32/pinctrl-stm32f429.c explicitly non-modular

2016-03-01 Thread Maxime Coquelin
_initcall in the non-modular > case, the init ordering remains unchanged with this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the

[PATCH] ARM: dts: stm32429i-eval: Add USB HS host mode support

2016-02-29 Thread Maxime Coquelin
This patch adds USB HS support in host mode only. This port supports OTG mode, but the device more is not working properly as of now. Once the device mode fixed, the node will be updated to support OTG. Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32429i-eval.dts | 16

Re: [PATCH 27/50] pinctrl: stm32: Use devm_pinctrl_register() for pinctrl registration

2016-02-25 Thread Maxime Coquelin
2016-02-24 14:15 GMT+01:00 Laxman Dewangan : > Use devm_pinctrl_register() for pin control registration. > > Signed-off-by: Laxman Dewangan > Cc: Maxime Coquelin > Cc: Patrice Chotard > --- > drivers/pinctrl/stm32/pinctrl-stm32.c | 7 --- > 1 file changed, 4 in

Re: [PATCH 45/50] pinctrl: st: Use devm_pinctrl_register() for pinctrl registration

2016-02-24 Thread Maxime Coquelin
On 02/24/2016 02:16 PM, Laxman Dewangan wrote: Use devm_pinctrl_register() for pin control registration. Signed-off-by: Laxman Dewangan Cc: Srinivas Kandagatla Cc: Maxime Coquelin Cc: Patrice Chotard Cc: ker...@stlinux.com --- drivers/pinctrl/pinctrl-st.c | 2 +- 1 file changed, 1

[PATCH] ARM: dts: stm32f429: Fix clocks referenced by GPIO banks

2016-02-23 Thread Maxime Coquelin
All the clocks referenced by the GPIO banks were not the good ones. Reported-by: Bruno Herrera Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32f429.dtsi | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/arch/arm/boot/dts/stm32f429.dtsi b

Re: [PATCH 0/3] ARM: stm32: Introduce support for STM32F469

2016-02-18 Thread Maxime Coquelin
Hi Lee, On 02/16/2016 03:16 PM, Lee Jones wrote: Simple set using the STM32F429 infrastructure as a foundation. There will be more changes to the DTS files and a requirement for added hierarchical layering as more differences become apparent. Lee Jones (3): ARM: stm32: Supply a DTS file for

Re: [PATCH v4 4/9] pinctrl: Add STM32 MCUs support

2016-02-13 Thread Maxime Coquelin
On 02/13/2016 03:48 PM, Linus Walleij wrote: On Mon, Feb 1, 2016 at 1:09 PM, Maxime Coquelin wrote: On 02/01/2016 11:39 AM, Maxime Coquelin wrote: 2016-02-01 11:21 GMT+01:00 Arnd Bergmann : drivers/pinctrl/stm32/pinctrl-stm32.c:26:47: fatal error: dt-bindings/pinctrl/pinctrl-stm32.h: No

[PATCH 0/2] pinctrl: stm32; Fix build issue in -next and make compile-testing possible

2016-02-08 Thread Maxime Coquelin
ected for compile testing via menuconfig, but the Makefile only selected stm32 driver directory if ARCH_STM32 was selected. The second patch selects the stm32 driver if PINCTRL_STM32 is selected. Regards, Maxime Maxime Coquelin (2): pinctrl: stm32: Remove dependency with DT bindings header

[PATCH 2/2] pinctrl: stm32: Fix compile testing selection

2016-02-08 Thread Maxime Coquelin
While selecting the driver for compile testing seemed possible, the driver was not compiled because the driver directory was only added if ARCH_STM32 was selected. This patch now makes the pinctrl Makefile to add stm32 directory if PINCTRL_STM32 is selected. Signed-off-by: Maxime Coquelin

[PATCH 1/2] pinctrl: stm32: Remove dependency with DT bindings header files

2016-02-08 Thread Maxime Coquelin
Some macros where defined in DT bindings headers, whereas only used in the driver. This patch moves these macros to the driver side. Signed-off-by: Maxime Coquelin --- drivers/pinctrl/stm32/pinctrl-stm32.c | 2 -- drivers/pinctrl/stm32/pinctrl-stm32.h | 8 2 files changed, 8

Re: [PATCH v5 0/9] Add STM32 pinctrl/GPIO driver

2016-02-08 Thread Maxime Coquelin
2016-02-03 12:04 GMT+01:00 Maxime Coquelin : > Hi Linus, > > This is the fifth round of STM32 pinctrl series, which is rebased on top of > v4.5-rc1 and removes no more needed dependency between DT and driver. > > Also, it fixes the Makefile so that it is really built when COMPILE

Re: [PATCH] pinctrl: stm32: fix compile error and modernize

2016-02-08 Thread Maxime Coquelin
2016-02-05 23:49 GMT+01:00 Linus Walleij : > - Fix the dev->parent assignment compile error > - Use gpiochip_get_data() to get the data pointer for the > banks > > Cc: Maxime Coquelin > Cc: Patrice Chotard > Signed-off-by: Linus Walleij > --- > I don't ev

[PATCH v5 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings

2016-02-03 Thread Maxime Coquelin
Acked-by: Patrice Chotard Acked-by: Linus Walleij Signed-off-by: Maxime Coquelin --- include/dt-bindings/pinctrl/stm32f429-pinfunc.h | 1239 +++ 1 file changed, 1239 insertions(+) create mode 100644 include/dt-bindings/pinctrl/stm32f429-pinfunc.h diff --git a/include/dt

[PATCH v5 1/9] ARM: Kconfig: Introduce MACH_STM32F429 flag

2016-02-03 Thread Maxime Coquelin
This patch introduces the MACH_STM32F429 to make possible to only select STM32F429 pinctrl driver. By default, all the MACH_STM32Fxxx flags will be set with STM32 defconfig. Acked-by: Patrice Chotard Acked-by: Linus Walleij Signed-off-by: Maxime Coquelin --- arch/arm/Kconfig | 5 + 1

[PATCH v5 4/9] pinctrl: Add STM32 MCUs support

2016-02-03 Thread Maxime Coquelin
This patch adds pinctrl and GPIO support to STMicroelectronic's STM32 family of MCUs. While it only supports STM32F429 for now, it has been designed to enable support of other MCUs of the family (e.g. STM32F746). Acked-by: Patrice Chotard Signed-off-by: Maxime Coquelin --- drivers/pi

[PATCH v5 8/9] ARM: dts: Add leds support to STM32F429 boards

2016-02-03 Thread Maxime Coquelin
Acked-by: Patrice Chotard Acked-by: Linus Walleij Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32429i-eval.dts | 17 + arch/arm/boot/dts/stm32f429-disco.dts | 11 +++ 2 files changed, 28 insertions(+) diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b

[PATCH v5 9/9] ARM: config: Enable GPIO Led driver in stm32_defconfig

2016-02-03 Thread Maxime Coquelin
Acked-by: Linus Walleij Acked-by: Patrice Chotard Signed-off-by: Maxime Coquelin --- arch/arm/configs/stm32_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/stm32_defconfig b/arch/arm/configs/stm32_defconfig index ec52505..1e5ec2a 100644 --- a/arch/arm/configs

[PATCH v5 7/9] ARM: dts: Add USART1 pin config to STM32F429 boards

2016-02-03 Thread Maxime Coquelin
This patch selects USART1 pin configuration on PA9/PA10 pins for both Eval and Disco boards. Acked-by: Linus Walleij Acked-by: Patrice Chotard Signed-off-by: Maxime Coquelin --- arch/arm/boot/dts/stm32429i-eval.dts | 2 ++ arch/arm/boot/dts/stm32f429-disco.dts | 2 ++ arch/arm/boot/dts

  1   2   3   4   5   6   7   8   >