Re: [PATCH v16 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-18 Thread Michał Mirosław
rlay_formats = tegra114_overlay_formats, > .modifiers = tegra20_modifiers, > .has_win_a_without_filters = false, > + .has_win_b_vfilter_mem_client = false, > .has_win_c_without_vert_filter = false, > + .plane_tiled_memory_bandwidth_x2 = true, > }; > > static const struct tegra_dc_soc_info tegra124_dc_soc_info = { > @@ -2314,7 +2660,9 @@ static const struct tegra_dc_soc_info > tegra124_dc_soc_info = { > .overlay_formats = tegra124_overlay_formats, > .modifiers = tegra124_modifiers, > .has_win_a_without_filters = false, > + .has_win_b_vfilter_mem_client = false, > .has_win_c_without_vert_filter = false, > + .plane_tiled_memory_bandwidth_x2 = false, > }; > > static const struct tegra_dc_soc_info tegra210_dc_soc_info = { > @@ -2333,7 +2681,9 @@ static const struct tegra_dc_soc_info > tegra210_dc_soc_info = { > .overlay_formats = tegra114_overlay_formats, > .modifiers = tegra124_modifiers, > .has_win_a_without_filters = false, > + .has_win_b_vfilter_mem_client = false, > .has_win_c_without_vert_filter = false, > + .plane_tiled_memory_bandwidth_x2 = false, > }; > > static const struct tegra_windowgroup_soc tegra186_dc_wgrps[] = { > @@ -2382,6 +2732,7 @@ static const struct tegra_dc_soc_info > tegra186_dc_soc_info = { > .has_nvdisplay = true, > .wgrps = tegra186_dc_wgrps, > .num_wgrps = ARRAY_SIZE(tegra186_dc_wgrps), > + .plane_tiled_memory_bandwidth_x2 = false, > }; > > static const struct tegra_windowgroup_soc tegra194_dc_wgrps[] = { > @@ -2430,6 +2781,7 @@ static const struct tegra_dc_soc_info > tegra194_dc_soc_info = { > .has_nvdisplay = true, > .wgrps = tegra194_dc_wgrps, > .num_wgrps = ARRAY_SIZE(tegra194_dc_wgrps), > + .plane_tiled_memory_bandwidth_x2 = false, > }; For globals you will have .x = false by default; I'm not sure those entries add much value. Reviewed-by: Michał Mirosław

Re: [PATCH v5 2/7] clk: tegra: Fix refcounting of gate clocks

2021-03-18 Thread Michał Mirosław
l access after disabling clock > + * Some clocks are duplicated and some of them are marked as critical, > + * like fuse and fuse_burn for example, thus the enable_refcnt will > + * be non-zero here id the "unused" duplicate is disabled by CCF. s/id/if/ ? Best Regards Michał Mirosław

Re: [PATCH v15 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-14 Thread Michał Mirosław
lained yet: why is the multiplier proportional to a *difference* between src and dst widths? Also, I would expect max (worst case) is pixclock * read_size when src_w/dst_w >= read_size. BTW, you could move this below and : if (src > dst_w) peak_bandwidth *= ... > + /* average bandwidth in bytes/s */ > + avg_bandwidth = (bpp * src_w * src_h * mul + 7) / 8; > + avg_bandwidth *= drm_mode_vrefresh(_state->mode); > + > + /* mode.clock in kHz, peak bandwidth in kbit/s */ > + peak_bandwidth = crtc_state->mode.clock * bpp * mul; [...] Best Regards Michał Mirosław

Re: [PATCH v15 2/2] drm/tegra: dc: Extend debug stats with total number of events

2021-03-14 Thread Michał Mirosław
ooks good. It seems independent from the other patch. Reviewed-by: Michał Mirosław

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-05 Thread Michał Mirosław
On Fri, Mar 05, 2021 at 12:45:51AM +0300, Dmitry Osipenko wrote: > 04.03.2021 02:08, Michał Mirosław пишет: > > On Tue, Mar 02, 2021 at 03:44:44PM +0300, Dmitry Osipenko wrote: > >> Display controller (DC) performs isochronous memory transfers, and thus, > >> has a requi

Re: [PATCH v1] Input: elants_i2c - fix division by zero if firmware reports zero phys size

2021-03-03 Thread Michał Mirosław
y: Dmitry Osipenko > --- Rewieved-by: Michał Mirosław > Please note that ASUS TF700T isn't yet supported by upstream kernel, > hence this is not a critical fix. > > drivers/input/touchscreen/elants_i2c.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > &

Re: [PATCH 06/11] pragma once: convert include/linux/cb710.h

2021-03-03 Thread Michał Mirosław
t; > This file is concatenation of two files with two include guards. > Convert it manually. > > Signed-off-by: Alexey Dobriyan Acked-by: Michał Mirosław

Re: [PATCH v13 1/2] drm/tegra: dc: Support memory bandwidth management

2021-03-03 Thread Michał Mirosław
andwidth = avg_bandwidth; > + > + return 0; > +} [...] > +static const char * const tegra_plane_icc_names[] = { > + "wina", "winb", "winc", "", "", "", "cursor", > +}; > + > +int tegra_plane_interconnect_init(struct tegra_plane *plane) > +{ > + const char *icc_name = tegra_plane_icc_names[plane->index]; Is plane->index guaranteed to be <= 6? I would guess so, but maybe BUILD_BUG_ON(sizeof(icc_names)==TEGRA_DC_LEGACY_PLANES_NUM) or some other check could document this? [...] Best Regards Michał Mirosław

Re: [PATCH v2] ptrace: add PTRACE_GET_RSEQ_CONFIGURATION request

2021-02-26 Thread Michał Mirosław
__u32 pad; > }; > > where: > > .size = sizeof(struct ptrace_rseq_configuration), > > This way, the configuration structure can be expanded in the future. The > rseq ABI structure is by definition fixed-size, so there is no point in > having its size here. > > Florian, did I understand your request correctly, or am I missing your point ? In this case returning sizeof(conf) would serve the same purpose, wouldn't it? Best Regards Michał Mirosław [Resent because of HTML mail misfeature...]

Re: [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices

2021-02-12 Thread Michał Mirosław
On Fri, Feb 12, 2021 at 06:26:41PM +, Michal Rostecki wrote: > On Wed, Feb 10, 2021 at 05:08:05AM +0100, Michał Mirosław wrote: > > On Tue, Feb 09, 2021 at 09:30:38PM +0100, Michal Rostecki wrote: > > > From: Michal Rostecki > > > > > > Add the btrfs

Re: [PATCH RFC 6/6] btrfs: Add roundrobin raid1 read policy

2021-02-10 Thread Michał Mirosław
On Wed, Feb 10, 2021 at 07:23:04PM +, Michal Rostecki wrote: > On Wed, Feb 10, 2021 at 01:58:15PM +0100, Michał Mirosław wrote: > > On Wed, Feb 10, 2021 at 12:29:25PM +, Michal Rostecki wrote: > > > On Wed, Feb 10, 2021 at 05:24:28AM +0100, Michał Mirosław wrote: >

Re: [PATCH RFC] input/elants_i2c: Detect enum overflow

2021-02-10 Thread Michał Mirosław
h to next function elants_i2c_resume() > > Reported-by: Randy Dunlap > Acked-by: Randy Dunlap > Signed-off-by: Josh Poimboeuf Reviewed-by: Michał Mirosław > --- > drivers/input/touchscreen/elants_i2c.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --

Re: [PATCH RFC 6/6] btrfs: Add roundrobin raid1 read policy

2021-02-10 Thread Michał Mirosław
On Wed, Feb 10, 2021 at 12:29:25PM +, Michal Rostecki wrote: > On Wed, Feb 10, 2021 at 05:24:28AM +0100, Michał Mirosław wrote: > > On Tue, Feb 09, 2021 at 09:30:40PM +0100, Michal Rostecki wrote: > > [...] > > > For the array with 3 HDDs, not adding any pena

Re: [PATCH RFC 6/6] btrfs: Add roundrobin raid1 read policy

2021-02-09 Thread Michał Mirosław
gle mirror will be selected for next reads (until a read on some other one completes). Have you tried testing with much more jobs / non-sequential accesses? Best Reagrds, Michał Mirosław

Re: [PATCH RFC 4/6] btrfs: Check if the filesystem is has mixed type of devices

2021-02-09 Thread Michał Mirosław
rue; > + if (!fs_devices->mixed) > + fs_devices->mixed = btrfs_check_mixed(fs_devices, rotating); Duplication. Maybe pull all this into a function? Best Regards, Michał Mirosław

Re: [PATCH] mmc: cb710: Use new tasklet API

2021-02-09 Thread Michał Mirosław
On Mon, Feb 08, 2021 at 02:45:51PM +0100, Emil Renner Berthing wrote: > This converts the driver to use the new tasklet API introduced in > commit 12cc923f1ccc ("tasklet: Introduce new initialization API") > > Signed-off-by: Emil Renner Berthing Acked-by: Michał Mirosław

Re: [PATCH RESEND v8 2/4] input: elants: support old touch report format

2021-01-22 Thread Michał Mirosław
On Fri, Jan 22, 2021 at 11:10:52PM +0300, Dmitry Osipenko wrote: > 08.01.2021 01:06, Dmitry Osipenko пишет: > > 11.12.2020 21:48, Dmitry Torokhov пишет: > >> On Fri, Dec 11, 2020 at 06:04:01PM +0100, Michał Mirosław wrote: > >>> On Fri, Dec 11, 2020 at 07:39:33P

Re: [PATCH v1 1/2] net: phy: Add 100 base-x mode

2021-01-11 Thread Michał Mirosław
l 10GE MII > * @PHY_INTERFACE_MODE_10GKR: 10GBASE-KR - with Clause 73 AN > + * @PHY_INTERFACE_MODE_100BASEX: 100 BaseX > * @PHY_INTERFACE_MODE_MAX: Book keeping [...] This is kernel-internal interface, so maybe the new mode can be inserted before 1000baseX for easier lookup? Best Regards Michał Mirosław

Re: [f2fs-dev] [PATCH v7 0/3] Update to zstd-1.4.6

2020-12-16 Thread Michał Mirosław
ling to work in the kernel. > [0] > https://github.com/terrelln/linux/commit/ac2ee65dcb7318afe426ad08f6a844faf3aebb41 I looks like you could remove a bit more dead code by noting __GNUC__ >= 4 (gcc-4.9 is currently the oldest supported [1]). [1] Documentation/process/changes.rst Best Regards Michał Mirosław

Re: [PATCH RESEND v8 2/4] input: elants: support old touch report format

2020-12-11 Thread Michał Mirosław
On Fri, Dec 11, 2020 at 07:39:33PM +0300, Dmitry Osipenko wrote: > 11.12.2020 19:09, Michał Mirosław пишет: > > On Thu, Dec 10, 2020 at 11:29:40PM -0800, Dmitry Torokhov wrote: > >> Hi Michał, > >> On Fri, Dec 11, 2020 at 07:53:56AM +0100, Michał Mirosław wrote: > >

Re: [PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624

2020-12-11 Thread Michał Mirosław
On Thu, Dec 10, 2020 at 11:22:09PM -0800, Dmitry Torokhov wrote: > Hi Michał, > > On Fri, Dec 11, 2020 at 07:53:56AM +0100, Michał Mirosław wrote: > > + > > + if (!phy_x || !phy_y) { > > + dev_warn(>dev, > > +

Re: [PATCH RESEND v8 2/4] input: elants: support old touch report format

2020-12-11 Thread Michał Mirosław
On Thu, Dec 10, 2020 at 11:29:40PM -0800, Dmitry Torokhov wrote: > Hi Michał, > On Fri, Dec 11, 2020 at 07:53:56AM +0100, Michał Mirosław wrote: > > @@ -998,17 +1011,18 @@ static irqreturn_t elants_i2c_irq(int irq, void > > *_dev) > > } > > >

[PATCH RESEND v8 1/4] input: elants: document some registers and values

2020-12-10 Thread Michał Mirosław
Add information found in downstream kernels, to make the code less magic. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH RESEND v8 4/4] input: elants: support 0x66 reply opcode for reporting touches

2020-12-10 Thread Michał Mirosław
for reporting touches. The calibration replies are handled separately from the the rest of the commands in the driver by entering into ELAN_WAIT_RECALIBRATION state and thus this change shouldn't change the old behavior. Signed-off-by: Dmitry Osipenko Tested-by: Michał Mirosław Signed-off

[PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624

2020-12-10 Thread Michał Mirosław
EKTF3624 as present in Asus TF300T tablet has touchscreen size encoded in different registers. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 84 -- 1 file changed, 79 insertions(+), 5

[PATCH RESEND v8 2/4] input: elants: support old touch report format

2020-12-10 Thread Michał Mirosław
Support ELAN touchpad sensor with older firmware as found on eg. Asus Transformer Pads. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 36 ++ 1 file changed, 25 insertions(+), 11

[PATCH RESEND v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens

2020-12-10 Thread Michał Mirosław
nused constants from patch 1 added a new drive-by cleanup (last patch) v7: rebased onto current dtor/input/for-next v8: rebased onto current dtor/input/for-linus v8-resend: rebased again, no changes though --- Dmitry Osipenko (1): input: elants: support 0x66 reply opcode for reporting touches

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Thu, Dec 03, 2020 at 03:59:21AM +, Nick Terrell wrote: > On Dec 2, 2020, at 7:14 PM, Michał Mirosław wrote: > > On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: > >> On Dec 2, 2020, at 5:16 PM, Michał Mirosław > >> wrote: > >>> On Wed,

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
On Thu, Dec 03, 2020 at 01:42:03AM +, Nick Terrell wrote: > > > > On Dec 2, 2020, at 5:16 PM, Michał Mirosław wrote: > > > > On Wed, Dec 02, 2020 at 12:32:40PM -0800, Nick Terrell wrote: > >> From: Nick Terrell > >> > >> This patch: >

Re: [PATCH v6 1/3] lib: zstd: Add kernel-specific API

2020-12-02 Thread Michał Mirosław
*output, struct zstd_in_buffer *input) > +{ > + ZSTD_outBuffer o; > + ZSTD_inBuffer i; > + size_t ret; > + > + memcpy(, output, sizeof(o)); > + memcpy(, input, sizeof(i)); > + ret = ZSTD_compressStream(cstream, , ); > + memcpy(output, , sizeof(o)); > + memcpy(input, , sizeof(i)); > + return ret; > +} Is all this copying necessary? How is it different from type-punning by direct pointer cast? Best Regards Michał Mirosław

Re: [PATCH] power: bq25890: Use the correct range for IILIM register

2020-11-24 Thread Michał Mirosław
On Wed, Nov 25, 2020 at 04:48:05AM +0100, Sebastian Krzyszkowiak wrote: > I've checked bq25890, bq25892, bq25895 and bq25896 datasheets and > they all define IILIM to be between 100mA-3.25A with 50mA steps. That's what DS says, indeed. Reviewed-by: Michał Mirosław

Re: About regression caused by commit aea6cb99703e ("regulator: resolve supply after creating regulator")

2020-11-22 Thread Michał Mirosław
On Sun, Nov 22, 2020 at 03:43:33PM +0100, Jan Kiszka wrote: > On 09.11.20 00:28, Qu Wenruo wrote: > > On 2020/11/9 上午1:18, Michał Mirosław wrote: > >> On Sun, Nov 08, 2020 at 03:35:33PM +0800, Qu Wenruo wrote: [...] > >>> It turns out that, commit aea6cb99703e (&q

[PATCH RESEND 0/4] regulator: debugging and fixing supply deps

2020-11-12 Thread Michał Mirosław
t, so might be worth backporting. The error message is left on purpose so that these configurations can be detected and fixed. (The first two patches are resends from Nov 5). (Series resent because of wrong arm-kernel ML address.) Michał Mirosław (4): regulator: fix memory leak with repeated set

[PATCH RESEND 3/4] regulator: avoid resolve_supply() infinite recursion

2020-11-12 Thread Michał Mirosław
lator") Cc: sta...@vger.kernel.org Reported-by: Ahmad Fatoum Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ad36f03d7ee6..ab922ed273f3 100644 --- a/drivers/regulator/core.c +++

[PATCH RESEND 4/4] regulator: workaround self-referent regulators

2020-11-12 Thread Michał Mirosław
after creating regulator") Cc: sta...@vger.kernel.org Reported-by: Ahmad Fatoum Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ab922ed273f3..38ba579ef

[PATCH RESEND 2/4] regulator: debug early supply resolving

2020-11-12 Thread Michał Mirosław
Help debugging the case when set_machine_constraints() needs to be repeated. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index bcd64ba21fb9..ad36f03d7ee6 100644

[PATCH RESEND 1/4] regulator: fix memory leak with repeated set_machine_constraints()

2020-11-12 Thread Michał Mirosław
uot;) Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 2e1ea18221ef..bcd64ba21fb9 100644 --- a/drivers/regulator

[PATCH 4/4] regulator: workaround self-referent regulators

2020-11-12 Thread Michał Mirosław
after creating regulator") Cc: sta...@vger.kernel.org Reported-by: Ahmad Fatoum Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ab922ed273f3..38ba579ef

[PATCH 3/4] regulator: avoid resolve_supply() infinite recursion

2020-11-12 Thread Michał Mirosław
lator") Cc: sta...@vger.kernel.org Reported-by: Ahmad Fatoum Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ad36f03d7ee6..ab922ed273f3 100644 --- a/drivers/regulator/core.c +++

[PATCH 2/4] regulator: debug early supply resolving

2020-11-12 Thread Michał Mirosław
Help debugging the case when set_machine_constraints() needs to be repeated. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index bcd64ba21fb9..ad36f03d7ee6 100644

[PATCH 0/4] regulator: debugging and fixing supply deps

2020-11-12 Thread Michał Mirosław
t, so might be worth backporting. The error message is left on purpose so that these configurations can be detected and fixed. (The first two patches are resends from Nov 5). Michał Mirosław (4): regulator: fix memory leak with repeated set_machine_constraints() regulator: debug early supply resolvin

[PATCH 1/4] regulator: fix memory leak with repeated set_machine_constraints()

2020-11-12 Thread Michał Mirosław
uot;) Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 2e1ea18221ef..bcd64ba21fb9 100644 --- a/drivers/regulator

[PATCH RESEND v8 1/4] input: elants: document some registers and values

2020-11-09 Thread Michał Mirosław
Add information found in downstream kernels, to make the code less magic. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH RESEND v8 3/4] input: elants: read touchscreen size for EKTF3624

2020-11-09 Thread Michał Mirosław
EKTF3624 as present in Asus TF300T tablet has touchscreen size encoded in different registers. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 84 -- 1 file changed, 79 insertions(+), 5

[PATCH RESEND v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens

2020-11-09 Thread Michał Mirosław
nused constants from patch 1 added a new drive-by cleanup (last patch) v7: rebased onto current dtor/input/for-next v8: rebased onto current dtor/input/for-linus --- Dmitry Osipenko (1): input: elants: support 0x66 reply opcode for reporting touches Michał Mirosław (3): input: elants: doc

[PATCH RESEND v8 4/4] input: elants: support 0x66 reply opcode for reporting touches

2020-11-09 Thread Michał Mirosław
for reporting touches. The calibration replies are handled separately from the the rest of the commands in the driver by entering into ELAN_WAIT_RECALIBRATION state and thus this change shouldn't change the old behavior. Signed-off-by: Dmitry Osipenko Tested-by: Michał Mirosław Signed-off

[PATCH RESEND v8 2/4] input: elants: support old touch report format

2020-11-09 Thread Michał Mirosław
Support ELAN touchpad sensor with older firmware as found on eg. Asus Transformer Pads. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 36 ++ 1 file changed, 25 insertions(+), 11

Re: About regression caused by commit aea6cb99703e ("regulator: resolve supply after creating regulator")

2020-11-08 Thread Michał Mirosław
n trying to get voltage from unresolved supply") recently accepted to regulator tree [1]. Can you verify this? [1] git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next Best Regards Michał Mirosław

Re: [BUG] Error applying setting, reverse things back on lot of devices

2020-11-08 Thread Michał Mirosław
On Thu, Nov 05, 2020 at 10:11:30AM +0100, Ahmad Fatoum wrote: > Hello, > > On 11/5/20 3:57 AM, Michał Mirosław wrote: > >>> Can you catch debug logs for the bootup in question? I'm not sure what's > >>> the failure mode in your case. I guess this is not a bypa

Re: [BUG] Error applying setting, reverse things back on lot of devices

2020-11-04 Thread Michał Mirosław
On Wed, Nov 04, 2020 at 11:28:45AM +0100, Ahmad Fatoum wrote: > Hello, > > On 11/2/20 9:27 PM, Michał Mirosław wrote: > > On Mon, Nov 02, 2020 at 01:48:54PM +0100, Ahmad Fatoum wrote: > >> Hello Michał, > >> > >> CC += linux-stm32 > >> > >&

[PATCH] regulator: debug early supply resolving

2020-11-04 Thread Michał Mirosław
Help debugging the case when set_machine_constraints() needs to be repeated. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 402a72a70eb1..c84e3b0b63de 100644

[PATCH] regulator: fix memory leak with repeated set_machine_constraints()

2020-11-04 Thread Michał Mirosław
uot;) Cc: sta...@vger.kernel.org Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 29 + 1 file changed, 13 insertions(+), 16 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 8521f74ee75c..402a72a70eb1 100644 --- a/drivers/regulator

Re: linux-next: build failure after merge of the mfd tree

2020-11-04 Thread Michał Mirosław
itching to regmap") > > I have used the version of the mfd tree from next-20201104 for today. Hi, It's missing a patch for gpio part [1]. [1] https://lkml.org/lkml/2020/9/26/398 Best Regards Michał Mirosław

Re: [PATCH 1/5] gpio: tps65910: use regmap accessors

2020-11-04 Thread Michał Mirosław
On Wed, Nov 04, 2020 at 02:43:31PM +, Lee Jones wrote: > On Thu, 01 Oct 2020, Lee Jones wrote: > > On Wed, 30 Sep 2020, Linus Walleij wrote: > > > On Sun, Sep 27, 2020 at 1:59 AM Michał Mirosław > > > wrote: > > > > Use regmap accessors directly f

Re: [PATCH v1 00/30] Introduce core voltage scaling for NVIDIA Tegra20/30 SoCs

2020-11-04 Thread Michał Mirosław
? Best Regards Michał Mirosław

Re: [PATCH v3] mfd: tps65910: Correct power-off programming sequence

2020-11-04 Thread Michał Mirosław
t's probably going to be accepted shortly. This just means replacing register accesses: tps65910_reg_*() -> regmap_*(). Best Regards, Michał Mirosław

Re: [BUG] Error applying setting, reverse things back on lot of devices

2020-11-02 Thread Michał Mirosław
On Mon, Nov 02, 2020 at 01:48:54PM +0100, Ahmad Fatoum wrote: > Hello Michał, > > CC += linux-stm32 > > On 10/24/20 1:53 PM, Michał Mirosław wrote: > > On Fri, Oct 23, 2020 at 10:39:43PM +0200, Corentin Labbe wrote: > >> On Fri, Oct 23, 2020 at 03:42:01

[PATCH v3 2/2] arm: defconfig: enable tegra20-spdif

2020-10-28 Thread Michał Mirosław
Enable tegra20-spdif in tegra and multiplatform defconfigs. The driver will be switched to "default n" in another patch. Signed-off-by: Michał Mirosław --- v3: split from main patch v2: add the symbol to defconfig as suggested by Thierry Reding --- arch/arm/configs/multi_v7_def

[PATCH v3 1/2] ASoC: tegra20-spdif: remove "default m"

2020-10-28 Thread Michał Mirosław
Make tegra20-spdif default to N as all other drivers do. Signed-off-by: Michał Mirosław Fixes: 774fec338bfc ("ASoC: Tegra: Implement SPDIF CPU DAI") --- v3: split-off the defconfig changes v2: add the symbol to defconfig as suggested by Thierry Reding --- sound/soc/tegra/Kconfig | 1

[PATCH v8 1/4] input: elants: document some registers and values

2020-10-24 Thread Michał Mirosław
Add information found in downstream kernels, to make the code less magic. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

[PATCH v8 2/4] input: elants: support old touch report format

2020-10-24 Thread Michał Mirosław
Support ELAN touchpad sensor with older firmware as found on eg. Asus Transformer Pads. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 36 ++ 1 file changed, 25 insertions(+), 11

[PATCH v8 4/4] input: elants: support 0x66 reply opcode for reporting touches

2020-10-24 Thread Michał Mirosław
for reporting touches. The calibration replies are handled separately from the the rest of the commands in the driver by entering into ELAN_WAIT_RECALIBRATION state and thus this change shouldn't change the old behavior. Signed-off-by: Dmitry Osipenko Tested-by: Michał Mirosław Signed-off

[PATCH v8 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreens

2020-10-24 Thread Michał Mirosław
nused constants from patch 1 added a new drive-by cleanup (last patch) v7: rebased onto current dtor/input/for-next v8: rebased onto current dtor/input/for-linus again --- Dmitry Osipenko (1): input: elants: support 0x66 reply opcode for reporting touches Michał Mirosław (3): input: e

[PATCH v8 3/4] input: elants: read touchscreen size for EKTF3624

2020-10-24 Thread Michał Mirosław
EKTF3624 as present in Asus TF300T tablet has touchscreen size encoded in different registers. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 84 -- 1 file changed, 79 insertions(+), 5

[RESEND v2] ASoC: tegra20-spdif: remove "default m"

2020-10-24 Thread Michał Mirosław
Make tegra20-spdif default to N as all other drivers do. Add the selection to defconfigs instead. Signed-off-by: Michał Mirosław Fixes: 774fec338bfc ("ASoC: Tegra: Implement SPDIF CPU DAI") --- v2: add the symbol to defconfig as suggested by Thierry Reding --- arch/a

Re: [BUG] Error applying setting, reverse things back on lot of devices

2020-10-24 Thread Michał Mirosław
> > 0xc087f4d0) > > > [5.618713] sun4i-drm display-engine: bound 120.mixer (ops > > > 0xc087f4d0) > > > [5.626022] sun4i-drm display-engine: bound 1c7.tcon-top (ops > > > 0xc08837e0) > > > [5.633467] sun4i-drm display-engine:

Re: [PATCH v2] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-06 Thread Michał Mirosław
> to exit when device is being closed. > > This has a side-effect of fixing issue of accessing inut->users > outside of input->mutex protection. [...] Reviewed-by: Michał Mirosław (after with a fix mentioned below) > --- a/drivers/iio/adc/exynos_adc.c > +++ b/drivers/iio/a

Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread Michał Mirosław
On Mon, Oct 05, 2020 at 10:36:36AM -0700, dmitry.torok...@gmail.com wrote: > Hi Michał, > > On Mon, Oct 05, 2020 at 01:09:08PM +0200, Michał Mirosław wrote: > > On Sun, Oct 04, 2020 at 10:24:20PM -0700, dmitry.torok...@gmail.com wrote: > > > The order in which 'users' c

Re: [PATCH] iio: adc: exynos: do not rely on 'users' counter in ISR

2020-10-05 Thread Michał Mirosław
paired with READ_ONCE in the ISR. But is the check really needed? I see that this is to break waiting for a touch release event, so I would assume this shouldn't wait forever (unless the hardware is buggy) and breaking the loop will desync touch state (I would guess this would be noticable by next user). Best Regards, Michał Mirosław

Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver

2020-10-01 Thread Michał Mirosław
t in two? Or just calculating the PLLA base rate by multiplying? Best Regards, Michał Mirosław

Re: [PATCH v3 01/13] ASoC: soc-core: Fix component name_prefix parsing

2020-10-01 Thread Michał Mirosław
(>dlc, component) && > + map->name_prefix) { > component->name_prefix = map->name_prefix; > return; > } Hi, It is not obvious how the patch fixes the problem described. I guess now map->name_prefix is NULL on some level and overrides prefix found earlier? Best Regards, Michał Mirosław

Re: [PATCH v1 2/2] media: tegra-video: Allow building driver with COMPILE_TEST

2020-09-30 Thread Michał Mirosław
egards, Michał Mirosław

Re: [PATCH v7 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreen

2020-09-30 Thread Michał Mirosław
On Sat, Sep 19, 2020 at 11:41:19PM +0200, Michał Mirosław wrote: > This series cleans up the driver a bit and implements changes needed to > support EKTF3624-based touchscreen used in Asus TF300T, Google Nexus 7 > and similar Tegra3-based tablets. [...] Ping? Should I resend? This

[PATCH v2] ASoC: tegra20-spdif: remove "default m"

2020-09-28 Thread Michał Mirosław
Make tegra20-spdif default to N as all other drivers do. Add the selection to defconfigs instead. Signed-off-by: Michał Mirosław Fixes: 774fec338bfc ("ASoC: Tegra: Implement SPDIF CPU DAI") --- v2: add the symbol to defconfig as suggested by Thierry Reding --- arch/a

Re: [PATCH] ASoC: tegra20-spdif: remove "default m"

2020-09-28 Thread Michał Mirosław
On Mon, Sep 28, 2020 at 10:10:26AM +0200, Thierry Reding wrote: > On Sat, Sep 26, 2020 at 09:42:40PM +0200, Michał Mirosław wrote: > > Make tegra20-spdif default to N as all other drivers do. > > > > Signed-off-by: Michał Mirosław > > Fixes: 774fec338bfc ("ASoC

[PATCH 5/5] mfd: tps65910: remove unused pointers

2020-09-26 Thread Michał Mirosław
Client pointers in tps65910 data are not used in the drivers. Remove those fields. Signed-off-by: Michał Mirosław --- include/linux/mfd/tps65910.h | 5 - 1 file changed, 5 deletions(-) diff --git a/include/linux/mfd/tps65910.h b/include/linux/mfd/tps65910.h index f7398d982f23..701925db75b3

[PATCH 1/5] gpio: tps65910: use regmap accessors

2020-09-26 Thread Michał Mirosław
Use regmap accessors directly for register manipulation - removing one layer of abstraction. Signed-off-by: Michał Mirosław --- drivers/gpio/gpio-tps65910.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910

[PATCH 2/5] regulator: tps65910: use regmap accessors

2020-09-26 Thread Michał Mirosław
Use regmap accessors directly for register manipulation - removing one layer of abstraction. Signed-off-by: Michał Mirosław --- drivers/regulator/tps65910-regulator.c | 125 + 1 file changed, 63 insertions(+), 62 deletions(-) diff --git a/drivers/regulator/tps65910

[PATCH 3/5] mfd: tps65911-comparator: use regmap accessors

2020-09-26 Thread Michał Mirosław
Use regmap accessors directly for register manipulation - removing one layer of abstraction. Signed-off-by: Michał Mirosław --- drivers/mfd/tps65911-comparator.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/tps65911-comparator.c b/drivers/mfd/tps65911

[PATCH 4/5] mfd: tps65910: clean up after switching to regmap

2020-09-26 Thread Michał Mirosław
Remove wrappers around regmap calls to remove now-useless indirection. Signed-off-by: Michał Mirosław --- drivers/mfd/tps65910.c | 16 include/linux/mfd/tps65910.h | 35 --- 2 files changed, 8 insertions(+), 43 deletions(-) diff --git

[PATCH 0/5] tps65910: cleanup regmap use

2020-09-26 Thread Michał Mirosław
tps65910 was converted a long time ago to regmap. This series cleans up after the conversion by removing tps65910_reg_*() indirections and other unused fields in MFD structure. Michał Mirosław (5): gpio: tps65910: use regmap accessors regulator: tps65910: use regmap accessors mfd: tps65911

[PATCH 1/3] regulator: print state at boot

2020-09-26 Thread Michał Mirosław
Make the initial state of the regulator shown when debugging. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 9238613a8c26..bf88d74f5401 100644

[PATCH 0/3] regulator: debugging aids

2020-09-26 Thread Michał Mirosław
Three simple patches to aid in debugging regulators. Michał Mirosław (3): regulator: print state at boot regulator: print symbolic errors in kernel messages regulator: resolve supply after creating regulator drivers/regulator/core.c | 124 ++- 1 file

[PATCH 3/3] regulator: resolve supply after creating regulator

2020-09-26 Thread Michał Mirosław
: could not add device link regulator.3 err -2 Note: It doesn't fix the problem for bypassed regulators, though. Fixes: 45389c47526d ("regulator: core: Add early supply resolution for regulators") Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 21 + 1 fi

[PATCH 2/3] regulator: print symbolic errors in kernel messages

2020-09-26 Thread Michał Mirosław
Change all error-printing messages to include error name via %pe instead of numeric error or nothing. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 94 +--- 1 file changed, 49 insertions(+), 45 deletions(-) diff --git a/drivers/regulator

[PATCH] ASoC: tegra20-spdif: remove "default m"

2020-09-26 Thread Michał Mirosław
Make tegra20-spdif default to N as all other drivers do. Signed-off-by: Michał Mirosław Fixes: 774fec338bfc ("ASoC: Tegra: Implement SPDIF CPU DAI") --- sound/soc/tegra/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/tegra/Kconfig b/sound/soc/tegra/Kco

[PATCH v4 2/2] power: bq25890: support IBAT compensation

2020-09-26 Thread Michał Mirosław
Add configuration for compensation of IBAT measuring resistor in series with the battery. Signed-off-by: Michał Mirosław --- v4: renamed properties applying property-suffix --- drivers/power/supply/bq25890_charger.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff

[PATCH v4 1/2] power: bq25890: document IBAT compensation DT properties

2020-09-26 Thread Michał Mirosław
Document new properties for IBAT compensation feature. Signed-off-by: Michał Mirosław --- v2: initial version v4: renamed properties applying property-suffix --- Documentation/devicetree/bindings/power/supply/bq25890.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation

[PATCH v4 0/2] power: bq25890: IBAT compensation support

2020-09-26 Thread Michał Mirosław
These two patches add support for IBAT compensation feature of bq2589x chargers. --- v4 fixed property names for the features and dropped other applied or rejected patches Michał Mirosław (2): power: bq25890: document IBAT compensation DT properties power: bq25890: support IBAT

[PATCH v2] regulator: unexport regulator_lock/unlock()

2020-09-19 Thread Michał Mirosław
regulator_lock/unlock() was used only to guard regulator_notifier_call_chain(). As no users remain, make the functions internal. Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 6 ++ include/linux/regulator/driver.h | 3 --- 2 files changed, 2 insertions(+), 7

[PATCH v7 3/4] input: elants: read touchscreen size for EKTF3624

2020-09-19 Thread Michał Mirosław
EKTF3624 as present in Asus TF300T tablet has touchscreen size encoded in different registers. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 84 -- 1 file changed, 79 insertions(+), 5

[PATCH v7 0/4] input: elants: Support Asus TF300T and Nexus 7 touchscreen

2020-09-19 Thread Michał Mirosław
nused constants from patch 1 added a new drive-by cleanup (last patch) v7: rebased onto current dtor/input/for-next --- Dmitry Osipenko (1): input: elants: support 0x66 reply opcode for reporting touches Michał Mirosław (3): input: elants: document some registers and values input: elant

[PATCH v7 2/4] input: elants: support old touch report format

2020-09-19 Thread Michał Mirosław
Support ELAN touchpad sensor with older firmware as found on eg. Asus Transformer Pads. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 36 ++ 1 file changed, 25 insertions(+), 11

[PATCH v7 4/4] input: elants: support 0x66 reply opcode for reporting touches

2020-09-19 Thread Michał Mirosław
for reporting touches. The calibration replies are handled separately from the the rest of the commands in the driver by entering into ELAN_WAIT_RECALIBRATION state and thus this change shouldn't change the old behavior. Signed-off-by: Dmitry Osipenko Tested-by: Michał Mirosław Signed-off

[PATCH v7 1/4] input: elants: document some registers and values

2020-09-19 Thread Michał Mirosław
Add information found in downstream kernels, to make the code less magic. Signed-off-by: Michał Mirosław Reviewed-by: Dmitry Osipenko Tested-by: Dmitry Osipenko --- drivers/input/touchscreen/elants_i2c.c | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git

Re: [PATCH 0/3] regulator: unexport regulator_lock/unlock()

2020-09-15 Thread Michał Mirosław
On Mon, Sep 07, 2020 at 07:05:49PM +0100, Mark Brown wrote: > On Mon, 10 Aug 2020 06:33:30 +0200, Michał Mirosław wrote: > > This removes regulator_lock/unlock() calls around > > regulator_notifier_call_chain() as they are redundant - drivers > > already have to guarantee regu

Re: [PATCH 0/3] regulator: unexport regulator_lock/unlock()

2020-09-05 Thread Michał Mirosław
On Mon, Aug 10, 2020 at 06:33:30AM +0200, Michał Mirosław wrote: > This removes regulator_lock/unlock() calls around > regulator_notifier_call_chain() as they are redundant - drivers > already have to guarantee regulator_dev's existence during the call. > > This should make

Re: [PATCH v4 00/31] Improvements for Tegra I2C driver

2020-09-05 Thread Michał Mirosław
On Sat, Sep 05, 2020 at 11:41:20PM +0300, Dmitry Osipenko wrote: > Hello! > > This series performs refactoring of the Tegra I2C driver code and hardens > the atomic-transfer mode. [...] Pending comments, all LGTM. Best Regards, Michał Mirosław

Re: [PATCH v4 30/31] i2c: tegra: Clean up and improve comments

2020-09-05 Thread Michał Mirosław
On Sun, Sep 06, 2020 at 01:53:56AM +0300, Dmitry Osipenko wrote: > 06.09.2020 01:47, Michał Mirosław пишет: > > On Sat, Sep 05, 2020 at 11:41:50PM +0300, Dmitry Osipenko wrote: > >> Make all comments to be consistent in regards to capitalization and > >> punctuation, c

Re: [PATCH v4 11/31] i2c: tegra: Factor out runtime PM and hardware initialization

2020-09-05 Thread Michał Mirosław
On Sun, Sep 06, 2020 at 01:24:14AM +0300, Dmitry Osipenko wrote: > 06.09.2020 01:10, Michał Mirosław пишет: > > On Sat, Sep 05, 2020 at 11:41:31PM +0300, Dmitry Osipenko wrote: > >> Factor out runtime PM and hardware initialization into separate function > >> in

  1   2   3   4   >