Re: [PATCH] regulator: tps65910: wire up sleep control configuration

On Wed, Jun 14, 2017 at 03:42:08PM +0100, Mark Brown wrote: > On Wed, Jun 14, 2017 at 02:25:13PM +0200, Michał Mirosław wrote: > > References: 201cf052810d20814a77ca0e0045a2c1a3508a1f > I have no idea what you mean by this, sorry. This is a commit id which introduced the feat

[PATCH] regulator: tps65910: wire up sleep control configuration

This enables configuring the PMIC's sleep mode via device-tree. A pointer indirection to sleep mode data is removed, as it simplifies the implementation slightly. References: 201cf052810d20814a77ca0e0045a2c1a3508a1f Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- Documen

[PATCH] regulator: tps65910: wire up sleep control configuration

This enables configuring the PMIC's sleep mode via device-tree. A pointer indirection to sleep mode data is removed, as it simplifies the implementation slightly. References: 201cf052810d20814a77ca0e0045a2c1a3508a1f Signed-off-by: Michał Mirosław --- Documentation/devicetree/bindings/mfd

Re: [PATCH v2 2/2] regulator: tps65910: Allow supply references to the same chip

t for now. Best Regards, Michał Mirosław

Re: [PATCH v2 2/2] regulator: tps65910: Allow supply references to the same chip

t for now. Best Regards, Michał Mirosław

Re: [PATCH v2 2/2] regulator: tps65910: Allow supply references to the same chip

On Tue, Jun 13, 2017 at 06:46:28PM +0100, Mark Brown wrote: > On Tue, Jun 13, 2017 at 04:41:58PM +0200, Michał Mirosław wrote: > > This allows for (acyclic) references from tps6591x supplies to > > its outputs. > This is clearly not something that should be open coded in in

Re: [PATCH v2 2/2] regulator: tps65910: Allow supply references to the same chip

On Tue, Jun 13, 2017 at 06:46:28PM +0100, Mark Brown wrote: > On Tue, Jun 13, 2017 at 04:41:58PM +0200, Michał Mirosław wrote: > > This allows for (acyclic) references from tps6591x supplies to > > its outputs. > This is clearly not something that should be open coded in in

[PATCH v2 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

Extend regulator's info line with enabled/disabled status. Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- v2: - include commit message drivers/regulator/core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/core.c b/d

[PATCH v2 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

Extend regulator's info line with enabled/disabled status. Signed-off-by: Michał Mirosław --- v2: - include commit message drivers/regulator/core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index

[PATCH 2/2] regulator: use consumer->supply_name in debugfs/regulator_summary

0mV 0mV Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- v2: - extend commit message drivers/regulator/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ba4d121ae07fc..a9bfabd132cff

[PATCH 2/2] regulator: use consumer->supply_name in debugfs/regulator_summary

0mV 0mV Signed-off-by: Michał Mirosław --- v2: - extend commit message drivers/regulator/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index ba4d121ae07fc..a9bfabd132cff 100644 --- a/drivers/regulator

[PATCH v2 1/2] regulator: tps65910: check TPS65910_NUM_REGS at build time

Check TPS65910_NUM_REGS at build time instead of silently registering not all regulators at runtime. Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- v2: - added commit message drivers/regulator/tps65910-regulator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)

[PATCH v2 1/2] regulator: tps65910: check TPS65910_NUM_REGS at build time

Check TPS65910_NUM_REGS at build time instead of silently registering not all regulators at runtime. Signed-off-by: Michał Mirosław --- v2: - added commit message drivers/regulator/tps65910-regulator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/regulator

[PATCH v2 2/2] regulator: tps65910: Allow supply references to the same chip

This allows for (acyclic) references from tps6591x supplies to its outputs. Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- v2: - no changes drivers/regulator/tps65910-regulator.c | 39 -- 1 file changed, 33 insertions(+), 6 deletions(-)

[PATCH v2 2/2] regulator: tps65910: Allow supply references to the same chip

This allows for (acyclic) references from tps6591x supplies to its outputs. Signed-off-by: Michał Mirosław --- v2: - no changes drivers/regulator/tps65910-regulator.c | 39 -- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/regulator

Re: [PATCH 1/2] regulator: tps65910: check TPS65910_NUM_REGS at build time

On Tue, Jun 13, 2017 at 07:31:21PM +0530, Keerthy wrote: > On Tuesday 13 June 2017 07:28 PM, Michał Mirosław wrote: > > Missing commit log? [...] Oh, indeed. I'll fix this in a moment. Best Regards, Michał Mirosław

Re: [PATCH 1/2] regulator: tps65910: check TPS65910_NUM_REGS at build time

On Tue, Jun 13, 2017 at 07:31:21PM +0530, Keerthy wrote: > On Tuesday 13 June 2017 07:28 PM, Michał Mirosław wrote: > > Missing commit log? [...] Oh, indeed. I'll fix this in a moment. Best Regards, Michał Mirosław

[PATCH 2/2] regulator: tps65910: Allow supply references to the same chip

This allows for (acyclic) references from tps6591x supplies to its outputs. Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- drivers/regulator/tps65910-regulator.c | 39 -- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/d

[PATCH 2/2] regulator: tps65910: Allow supply references to the same chip

This allows for (acyclic) references from tps6591x supplies to its outputs. Signed-off-by: Michał Mirosław --- drivers/regulator/tps65910-regulator.c | 39 -- 1 file changed, 33 insertions(+), 6 deletions(-) diff --git a/drivers/regulator/tps65910-regulator.c b

[PATCH 1/2] regulator: tps65910: check TPS65910_NUM_REGS at build time

Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- drivers/regulator/tps65910-regulator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 696116ebdf50a..81672a58fcc23

[PATCH 1/2] regulator: tps65910: check TPS65910_NUM_REGS at build time

Signed-off-by: Michał Mirosław --- drivers/regulator/tps65910-regulator.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c index 696116ebdf50a..81672a58fcc23 100644 --- a/drivers/regulator

[PATCH 2/2] regulator: use consumer->supply_name in debugfs/regulator_summary

-dummy 1 02 0 0mV 0mA 0mV 0mV 1-0010-vccio0mV 0mV 1-0010-vcc330mV 0mV Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- d

[PATCH 2/2] regulator: use consumer->supply_name in debugfs/regulator_summary

-dummy 1 02 0 0mV 0mA 0mV 0mV 1-0010-vccio0mV 0mV 1-0010-vcc330mV 0mV Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 1 + 1

[PATCH 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- drivers/regulator/core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index c0d9ae8d0860e..ba4d121ae07fc 100644 --- a/drivers/regulator/

[PATCH 1/2] regulator: include 'enabled' status in debugfs/regulator_summary

Signed-off-by: Michał Mirosław --- drivers/regulator/core.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index c0d9ae8d0860e..ba4d121ae07fc 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator

[PATCH net-next 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal

Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- lib/test_bpf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 0362da0..00d3450 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -691,8 +691,13 @@ static struct bp

[PATCH net-next 23/27] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław <mirq-li...@rere.qmqm.pl> --- net/core/filter.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index b146170..c3321f1 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -

[PATCH net-next 24/27] bpf_test: prepare for VLAN_TAG_PRESENT removal

Signed-off-by: Michał Mirosław --- lib/test_bpf.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/lib/test_bpf.c b/lib/test_bpf.c index 0362da0..00d3450 100644 --- a/lib/test_bpf.c +++ b/lib/test_bpf.c @@ -691,8 +691,13 @@ static struct bpf_test tests

[PATCH net-next 23/27] net/bpf: split VLAN_PRESENT bit handling from VLAN_TCI

Signed-off-by: Michał Mirosław --- net/core/filter.c | 20 +--- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/net/core/filter.c b/net/core/filter.c index b146170..c3321f1 100644 --- a/net/core/filter.c +++ b/net/core/filter.c @@ -188,22 +188,20 @@ static u32

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

nc_lower_features(dev, lower, features); > + [...] This should be equal in resulting flags to: netdev_for_each_lower_dev(dev, lower...) netdev_update_features(lower); because netdev_fix_features(lower) will see already changed dev->features. Best Regards, Michał Mirosław

Re: [PATCH v2 net-next] net/core: generic support for disabling netdev features down stack

lower, features); > + [...] This should be equal in resulting flags to: netdev_for_each_lower_dev(dev, lower...) netdev_update_features(lower); because netdev_fix_features(lower) will see already changed dev->features. Best Regards, Michał Mirosław

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

sh = (struct shash_desc *)__desc > + char shash##__desc[] or similar? Otherwise it won't work if you use this macro twice in the same block. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to major

Re: [dm-devel] [PATCH v3 01/12] crypto: LLVMLinux: Add macro to remove use of VLAIS in crypto code

shash_desc *shash = (struct shash_desc *)__desc + char shash##__desc[] or similar? Otherwise it won't work if you use this macro twice in the same block. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord

Re: [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy()

mapping. > skb->protocol = eth_type_trans(skb, ndev); > napi_gro_receive(>napi, skb); > rx++; Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4 2/2] net: moxa: replace build_skb() with netdev_alloc_skb_ip_align() / memcpy()

, DMA_FROM_DEVICE); + dma_sync_single_for_device() is not needed here as CPU does not and should not write to the DMA_FROM_DEVICE mapping. skb-protocol = eth_type_trans(skb, ndev); napi_gro_receive(priv-napi, skb); rx++; Best Regards, Michał

Re: [RFT][PATCH 08/12] mmc: change cb710-mmc platform power management to use dev_pm_ops

ould move cb710_mmc_suspend() (or whatever you'll call it) to one ifdef block with cb710_mmc_dev_pm_ops. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [RFT][PATCH 08/12] mmc: change cb710-mmc platform power management to use dev_pm_ops

cb710_mmc_suspend() (or whatever you'll call it) to one ifdef block with cb710_mmc_dev_pm_ops. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] mmc: cb710: drop free_irq for devm_request_irq allocated irq

On Tue, Sep 24, 2013 at 10:40:57AM +0800, Wei Yongjun wrote: > From: Wei Yongjun > > irq allocated with devm_request_irq should not be freed using > free_irq, because doing so causes a dangling pointer, and a > subsequent double free. > > Signed-off-by: Wei Yongjun Acke

Re: [PATCH] mmc: cb710: drop free_irq for devm_request_irq allocated irq

yongjun_...@trendmicro.com.cn Acked-by: Michał Mirosław mirq-li...@rere.qmqm.pl -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 04/27] mmc: cb710: Move away from using deprecated APIs

ng the > use of the deprecated APIs. > > Cc: Michał Mirosław > Signed-off-by: Ulf Hansson Patch looks consistent with commit message. I can't test it on HW, though. Acked-by: Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a me

Re: [PATCH 04/27] mmc: cb710: Move away from using deprecated APIs

APIs. Cc: Michał Mirosław mirq-li...@rere.qmqm.pl Signed-off-by: Ulf Hansson ulf.hans...@linaro.org Patch looks consistent with commit message. I can't test it on HW, though. Acked-by: Michał Mirosław mirq-li...@rere.qmqm.pl -- To unsubscribe from this list: send the line unsubscribe linux

Re: [GIT] Networking

thing cares about the .../eth0/flags value because with the bit > ordering different for bits 10 and above things break. Are you sure it's "flags"? /sys/class/net/*/features were removed some time ago, and flags don't depend on NETIF_F_*. Best Regards, Michał Mirosław -- To unsubscri

Re: [GIT] Networking

is certainly a bug in NM, and a fresh one: commit b636ea86b1c0a28b77eda311c84d3b2417cad22e from 2013-04-10 14:40:58 (GMT). Userspace is expected to use ETHTOOL_GSTRINGS for ETH_SS_FEATURES and find a corresponding bit position by feature name ("vlan-challenged" in this case). Cc: commit'

Re: [GIT] Networking

in this case). Cc: commit's author. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [GIT] Networking

removed some time ago, and flags don't depend on NETIF_F_*. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH 1/1] eventfd: implementation of EFD_MASK flag

ctx->count = count; > + } > ctx->flags = flags; > > file = anon_inode_getfile("[eventfd]", _fops, ctx, Since EFD_MASK is a persistent flag for a fd's lifetime, maybe you could instead of all those if/elses and BUG_ON()s use another file_operati

Re: [PATCH 1/1] eventfd: implementation of EFD_MASK flag

file_operations struct for this feature? Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

[PATCH] regulator: show state for GPIO-controlled regulators

Signed-off-by: Michał Mirosław --- patch against https://github.com/torvalds/linux.git master drivers/regulator/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 2785843..6b3550a 100644 --- a/drivers

[PATCH] regulator: show state for GPIO-controlled regulators

Signed-off-by: Michał Mirosław mirq-li...@rere.qmqm.pl --- patch against https://github.com/torvalds/linux.git master drivers/regulator/core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 2785843..6b3550a 100644

Re: [PATCH 2.6.20 14/14] nfnetlink_log: micro-optimization: inst->skb != NULL in __nfulnl_send()

Patch updated to apply after a new version of 13/14: No other function calls __nfulnl_send() with inst->skb == NULL than nfulnl_timer(). Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.12 2007-02-14 12:27:09.0 +0100

Re: [PATCH 2.6.20 13/14] nfnetlink_log: fix reference counting

On Tue, Feb 13, 2007 at 01:58:34PM +0100, Patrick McHardy wrote: > Micha³ Miros³aw wrote: > > Fix reference counting (memory leak) problem in __nfulnl_send() and callers > > related to packet queueing. > > > > Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]&

Re: [PATCH 2.6.20 13/14] nfnetlink_log: fix reference counting

On Tue, Feb 13, 2007 at 01:58:34PM +0100, Patrick McHardy wrote: Micha³ Miros³aw wrote: Fix reference counting (memory leak) problem in __nfulnl_send() and callers related to packet queueing. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter

Re: [PATCH 2.6.20 14/14] nfnetlink_log: micro-optimization: inst-skb != NULL in __nfulnl_send()

Patch updated to apply after a new version of 13/14: No other function calls __nfulnl_send() with inst-skb == NULL than nfulnl_timer(). Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.12 2007-02-14 12:27:09.0 +0100 +++ linux-2.6.20

[PATCH 2.6.20 14/14] nfnetlink_log: micro-optimization: inst->skb != NULL in __nfulnl_send()

No other function calls __nfulnl_send() with inst->skb == NULL than nfulnl_timer(). Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.12 2007-02-12 17:58:01.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02

[PATCH 2.6.20 13/14] nfnetlink_log: fix reference counting

Fix reference counting (memory leak) problem in __nfulnl_send() and callers related to packet queueing. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.11 2007-02-12 17:35:50.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink

[PATCH 2.6.20 12/14] nfnetlink_log: possible NULL pointer dereference in nfulnl_recv_config()

Eliminate possible NULL pointer dereference in nfulnl_recv_config(). Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.10 2007-02-12 17:05:14.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 17:35:50.000

Re: [PATCH 2.6.20 +0/14] nfnetlink_log: patch series season 2

Dear list, As it turned out, not all worms eating nfnetlink_log have been exterminated by my last patch series. I'll append next four patches to the end of the series and I hope that it doesn't make your patching scripts unhappy. Those patches fix two bugs and make two other code

[PATCH 2.6.20 11/14] nfnetlink_log: iterator functions need iter_state * only

get_*() don't need access to seq_file - iter_state is enough for them. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.92007-02-12 00:19:16.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 17:05:14.000

[PATCH 2.6.20 07/10] nfnetlink_log: fix module reference counting

Count module references correctly: after instance_destroy() there might be timer pending and holding a reference for this netlink instance. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.52007-02-11 22:24:56.0 +0100 +++

[PATCH 2.6.20 08/10] nfnetlink_log: shorten instances_lock holding time

Shorten instances_lock window at the cost of doing unnecessary work on the failure case. I don't know if it makes sense actually. ;> Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.62007-02-11 22:31:19.0 +0100 +++ lin

[PATCH 2.6.20 03/10] nfnetlink_log: kill duplicate code

Kill some duplicate code in nfulnl_log_packet(). Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.12007-02-11 20:51:57.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11 20:43:24.0 +0100 @@ -666,30 +

[PATCH 2.6.20 09/10] nfnetlink_log: fix NULL pointer dereference

4/0x51 [nfnetlink_log] SS:ESP 0068:c03f5f30 <0>Kernel panic - not syncing: Fatal exception in interrupt <0>Rebooting in 5 seconds.. Panic no more! Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.72007-02-11 22:41:18.

[PATCH 2.6.20 01/10] nfnetlink_log: don't count max(a,b) twice

We don't need local nlbufsiz (skb size) as nfulnl_alloc_skb() takes the maximum anyway. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.orig 2007-02-10 18:25:14.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11

[PATCH 2.6.20 04/10] nfnetlink_log: fix possible use-after-free

Paranoia: instance_put() might have freed the inst pointer when we spin_unlock_bh(). Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.22007-02-11 20:43:24.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11

[PATCH 2.6.20 00/10] nfnetlink_log: patch series introduction

Dear list, After meeting a faint-hearted Linux kernel lately I decided to try myself at persuading it to not be afraid of NFLOG. This chat gave a series of ten commandments I present today. Take a look and agree or comment. Here's the list: 1. nfulnl_log_packet() - don't count the same thing

[PATCH 2.6.20 02/10] nfnetlink_log: stop reference leak

Stop reference leaking in nfulnl_log_packet(). If we start a timer we are already taking another reference. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.02007-02-11 20:20:27.0 +0100 +++ linux-2.6.20/net/net

[PATCH 2.6.20 05/10] nfnetlink_log: micro-optimization for inst==NULL in nfulnl_recv_config()

Simple micro-optimization: don't call instance_put() on known NULL pointers. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.32007-02-11 20:46:33.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11

[PATCH 2.6.20 10/10] nfnetlink_log: enable packet timestamps

It's nice to log packet arrival time of those little filthy packets. ;) Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.82007-02-11 23:59:01.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 00:19:16.000

[PATCH 2.6.20 06/10] nfnetlink_log: micro-optimization: don't modify destroyed instance

Simple micro-optimization: Don't change any options if the instance is being destroyed. Signed-off-by: Michał Mirosław <[EMAIL PROTECTED]> --- linux-2.6.20/net/netfilter/nfnetlink_log.c.42007-02-11 20:46:26.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11

[PATCH 2.6.20 06/10] nfnetlink_log: micro-optimization: don't modify destroyed instance

Simple micro-optimization: Don't change any options if the instance is being destroyed. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.42007-02-11 20:46:26.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11 22:24

[PATCH 2.6.20 10/10] nfnetlink_log: enable packet timestamps

It's nice to log packet arrival time of those little filthy packets. ;) Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.82007-02-11 23:59:01.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 00:19:16.0

[PATCH 2.6.20 02/10] nfnetlink_log: stop reference leak

Stop reference leaking in nfulnl_log_packet(). If we start a timer we are already taking another reference. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.02007-02-11 20:20:27.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c

[PATCH 2.6.20 05/10] nfnetlink_log: micro-optimization for inst==NULL in nfulnl_recv_config()

Simple micro-optimization: don't call instance_put() on known NULL pointers. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.32007-02-11 20:46:33.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11 20:46:26.0

[PATCH 2.6.20 00/10] nfnetlink_log: patch series introduction

Dear list, After meeting a faint-hearted Linux kernel lately I decided to try myself at persuading it to not be afraid of NFLOG. This chat gave a series of ten commandments I present today. Take a look and agree or comment. Here's the list: 1. nfulnl_log_packet() - don't count the same thing

[PATCH 2.6.20 04/10] nfnetlink_log: fix possible use-after-free

Paranoia: instance_put() might have freed the inst pointer when we spin_unlock_bh(). Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.22007-02-11 20:43:24.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11 20:46

[PATCH 2.6.20 09/10] nfnetlink_log: fix NULL pointer dereference

04 03 00 8b 53 34 8b 43 14 b9 40 00 00 00 e8 08 9a 84 EIP: [f8a4b3bf] __nfulnl_send+0x24/0x51 [nfnetlink_log] SS:ESP 0068:c03f5f30 0Kernel panic - not syncing: Fatal exception in interrupt 0Rebooting in 5 seconds.. Panic no more! Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux

[PATCH 2.6.20 01/10] nfnetlink_log: don't count max(a,b) twice

We don't need local nlbufsiz (skb size) as nfulnl_alloc_skb() takes the maximum anyway. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.orig 2007-02-10 18:25:14.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11 20:20

[PATCH 2.6.20 03/10] nfnetlink_log: kill duplicate code

Kill some duplicate code in nfulnl_log_packet(). Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.12007-02-11 20:51:57.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-11 20:43:24.0 +0100 @@ -666,30 +666,23

[PATCH 2.6.20 08/10] nfnetlink_log: shorten instances_lock holding time

Shorten instances_lock window at the cost of doing unnecessary work on the failure case. I don't know if it makes sense actually. ; Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.62007-02-11 22:31:19.0 +0100 +++ linux-2.6.20/net

[PATCH 2.6.20 07/10] nfnetlink_log: fix module reference counting

Count module references correctly: after instance_destroy() there might be timer pending and holding a reference for this netlink instance. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.52007-02-11 22:24:56.0 +0100 +++ linux

Re: [PATCH 2.6.20 +0/14] nfnetlink_log: patch series season 2

Dear list, As it turned out, not all worms eating nfnetlink_log have been exterminated by my last patch series. I'll append next four patches to the end of the series and I hope that it doesn't make your patching scripts unhappy. Those patches fix two bugs and make two other code

[PATCH 2.6.20 11/14] nfnetlink_log: iterator functions need iter_state * only

get_*() don't need access to seq_file - iter_state is enough for them. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.92007-02-12 00:19:16.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 17:05:14.0

[PATCH 2.6.20 13/14] nfnetlink_log: fix reference counting

Fix reference counting (memory leak) problem in __nfulnl_send() and callers related to packet queueing. Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.11 2007-02-12 17:35:50.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c

[PATCH 2.6.20 14/14] nfnetlink_log: micro-optimization: inst-skb != NULL in __nfulnl_send()

No other function calls __nfulnl_send() with inst-skb == NULL than nfulnl_timer(). Signed-off-by: Michał Mirosław [EMAIL PROTECTED] --- linux-2.6.20/net/netfilter/nfnetlink_log.c.12 2007-02-12 17:58:01.0 +0100 +++ linux-2.6.20/net/netfilter/nfnetlink_log.c 2007-02-12 17:58

<    1   2   3   4