Isn't the extra space there because you've included it in the definition
of "test"? The attempt at introducing indentation introduces the extra
space character. Defining test without the internal indentation should
produce the results you are looking for.
--
Michal Ostrowski <[EM
Isn't the extra space there because you've included it in the definition
of test? The attempt at introducing indentation introduces the extra
space character. Defining test without the internal indentation should
produce the results you are looking for.
--
Michal Ostrowski [EMAIL PROTECTED
;echo" to write to a "bind" attribute, echo will
continuously call write() trying to write to the attribute and always
get 0 as a result and thus find itself in a loop trying to do the write.
Perhaps the translation of -ENZIO to -ENODEV to success in
driver_probe_device() is not approria
to write to a bind attribute, echo will
continuously call write() trying to write to the attribute and always
get 0 as a result and thus find itself in a loop trying to do the write.
Perhaps the translation of -ENZIO to -ENODEV to success in
driver_probe_device() is not approriate here?
--
Michal
If bailing out because there is nothing to receive in rp_do_receive(),
tty_ldisc_deref is not called. Failure to do so increases the ref count
and causes release_dev() to hang since it can't get the ref count to 0.
---
Signed-off-by: Michal Ostrowski <[EMAIL PROTECTED]>
drivers/char/ro
If bailing out because there is nothing to receive in rp_do_receive(),
tty_ldisc_deref is not called. Failure to do so increases the ref count
and causes release_dev() to hang since it can't get the ref count to 0.
---
Signed-off-by: Michal Ostrowski [EMAIL PROTECTED]
drivers/char/rocket.c
do have space, we clone it. We always give dev_queue_xmit the
copy/clone pointer and let it free it. We then kfree_skb the original
skb depending on the return value of dev_queue_xmit (to conform to the
expectations of ppp_generic).
Michal Ostrowski
[EMAIL PROTECTED]
--- drivers/net/pppoe.c
we would have
to always copy skb's inside pppoe_xmit. Then, if dev_queue_xmit fails
the original is deleted.
In the common case dev_queue_xmit will not fail, and so in that case
I'd like to have to avoid making a copy of the skb.
Michal Ostrowski
[EMAIL PROTECTED]
-
To unsubscribe from this lis
.
In the common case dev_queue_xmit will not fail, and so in that case
I'd like to have to avoid making a copy of the skb.
Michal Ostrowski
[EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
do have space, we clone it. We always give dev_queue_xmit the
copy/clone pointer and let it free it. We then kfree_skb the original
skb depending on the return value of dev_queue_xmit (to conform to the
expectations of ppp_generic).
Michal Ostrowski
[EMAIL PROTECTED]
--- drivers/net/pppoe.c
ey pointed out a much nicer/correct/elegant/efficient
solution to this problem and I think that that's the way to go.
New patch below.
Michal Ostrowski
[EMAIL PROTECTED]
--- drivers/net/pppoe.c~Tue Mar 6 22:44:35 2001
+++ drivers/net/pppoe.c Mon May 14 14:10:49 2001
@@ -5,7 +5,7 @@
ase_sock releases the
socket spinlock before calling sk->backlog_rcv() (== tcp_v4_do_rcv),
however the comments at the top of tcp_v4_do_rcv() assert that the
socket's spinlock is held (which is definitely not the case).
Anybody care to comment on this?
Michal Ostrowski
[EMAIL PROTECTED]
---
/correct/elegant/efficient
solution to this problem and I think that that's the way to go.
New patch below.
Michal Ostrowski
[EMAIL PROTECTED]
--- drivers/net/pppoe.c~Tue Mar 6 22:44:35 2001
+++ drivers/net/pppoe.c Mon May 14 14:10:49 2001
@@ -5,7 +5,7 @@
* PPPoE --- PPP over Ethernet
of tcp_v4_do_rcv() assert that the
socket's spinlock is held (which is definitely not the case).
Anybody care to comment on this?
Michal Ostrowski
[EMAIL PROTECTED]
--- drivers/net/pppoe.c~Tue Mar 6 22:44:35 2001
+++ drivers/net/pppoe.c Mon May 14 08:24:06 2001
@@ -5,7 +5,7 @@
* PPPoE --- PPP
Meelis Roos writes:
> 2.4.0-test9
> modules.dep reports that pppox needs pppoe and pppoe needs pppox.
> modprobe pppo(e|x) segfaults (out of memory???).
>
A fix has been submitted. If you need a quick fix, do not compile as
a module, or remove line 158 of pppox.c.
Michal Ostr
Meelis Roos writes:
2.4.0-test9
modules.dep reports that pppox needs pppoe and pppoe needs pppox.
modprobe pppo(e|x) segfaults (out of memory???).
A fix has been submitted. If you need a quick fix, do not compile as
a module, or remove line 158 of pppox.c.
Michal Ostrowski
[EMAIL
16 matches
Mail list logo
