Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_sdio.c | 15 +++
drivers/staging/gdm72xx/gdm_usb.c | 10 ++
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx/gdm_sdio.c
index 6a23bef
Removed dump_eth_packet() and helper functions called upon packet tx/rx.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 106
1 file changed, 106 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging
Removed dump_eth_packet() and helper functions called upon packet tx/rx.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 106
1 file changed, 106 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_sdio.c | 15 +++
drivers/staging/gdm72xx/gdm_usb.c | 10 ++
2 files changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx
On 07/16/2014 09:50 PM, Greg KH wrote:
> On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote:
>> On 07/09/2014 07:51 PM, Greg KH wrote:
>>>> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
>>>> b/drivers/staging/gdm72xx/gdm_sdio.c
>>>> ind
On 07/09/2014 07:51 PM, Greg KH wrote:
>> diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
>> b/drivers/staging/gdm72xx/gdm_sdio.c
>> index 9d2de6f..914fd75 100644
>> --- a/drivers/staging/gdm72xx/gdm_sdio.c
>> +++ b/drivers/staging/gdm72xx/gdm_sdio.c
>> @@ -280,9 +280,11 @@ static void
On 07/09/2014 07:51 PM, Greg KH wrote:
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx/gdm_sdio.c
index 9d2de6f..914fd75 100644
--- a/drivers/staging/gdm72xx/gdm_sdio.c
+++ b/drivers/staging/gdm72xx/gdm_sdio.c
@@ -280,9 +280,11 @@ static void send_sdu(struct
On 07/16/2014 09:50 PM, Greg KH wrote:
On Wed, Jul 16, 2014 at 09:40:18PM +0100, Michalis Pappas wrote:
On 07/09/2014 07:51 PM, Greg KH wrote:
diff --git a/drivers/staging/gdm72xx/gdm_sdio.c
b/drivers/staging/gdm72xx/gdm_sdio.c
index 9d2de6f..914fd75 100644
--- a/drivers/staging/gdm72xx
On 07/09/2014 07:51 PM, Greg KH wrote:
> On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote:
>> Signed-off-by: Michalis Pappas
>> ---
>> drivers/staging/gdm72xx/gdm_qos.c | 2 ++
>> drivers/staging/gdm72xx/gdm_sdio.c | 7 +++
>> driver
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_sdio.c | 77
drivers/staging/gdm72xx/gdm_usb.c | 87 +-
drivers/staging/gdm72xx/gdm_wimax.c | 179 +---
3 files changed, 164 insertions(+), 179 deletions(-)
diff
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 11 +++
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 0f71d41
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 11 +++
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 4148013
On 07/09/2014 11:26 AM, Dan Carpenter wrote:
>> /* GetInformation mac address */
>> len = 0;
>> @@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device
>> *dev)
>> hci->length = H2B(len);
>> gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len);
>>
>> -val =
On 07/09/2014 11:26 AM, Dan Carpenter wrote:
/* GetInformation mac address */
len = 0;
@@ -621,12 +618,12 @@ static void gdm_wimax_prepare_device(struct net_device
*dev)
hci-length = H2B(len);
gdm_wimax_send(nic, hci, HCI_HEADER_SIZE+len);
-val = (1BIT_WIMAX) |
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 11 +++
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 11 +++
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_sdio.c | 77
drivers/staging/gdm72xx/gdm_usb.c | 87 +-
drivers/staging/gdm72xx/gdm_wimax.c | 179 +---
3 files changed, 164 insertions(+), 179
On 07/09/2014 07:51 PM, Greg KH wrote:
On Tue, Jul 01, 2014 at 02:00:15PM +0100, Michalis Pappas wrote:
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 ++
drivers/staging/gdm72xx/gdm_sdio.c | 7 +++
drivers/staging/gdm72xx/gdm_usb.c | 7
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_sdio.c | 77
drivers/staging/gdm72xx/gdm_usb.c | 87 +-
drivers/staging/gdm72xx/gdm_wimax.c | 179 +---
3 files changed, 164 insertions(+), 179 deletions(-)
diff
On 07/01/2014 07:08 PM, Ben Chan wrote:
>
>
>
> On Tue, Jul 1, 2014 at 9:40 AM, Michalis Pappas <mailto:mpap...@fastmail.fm>> wrote:
>
> On 07/01/2014 04:30 PM, Ben Chan wrote:
> >
> >
> >
> > On Tue, Jul 1, 2014 at 6:00 A
On 07/01/2014 07:08 PM, Ben Chan wrote:
On Tue, Jul 1, 2014 at 9:40 AM, Michalis Pappas mpap...@fastmail.fm
mailto:mpap...@fastmail.fm wrote:
On 07/01/2014 04:30 PM, Ben Chan wrote:
On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas
mpap...@fastmail.fm
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_sdio.c | 77
drivers/staging/gdm72xx/gdm_usb.c | 87 +-
drivers/staging/gdm72xx/gdm_wimax.c | 179 +---
3 files changed, 164 insertions(+), 179
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 11 ---
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 4148013
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 11 ---
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
On 07/01/2014 04:30 PM, Ben Chan wrote:
>
>
>
> On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas <mailto:mpap...@fastmail.fm>> wrote:
>
> Signed-off-by: Michalis Pappas <mailto:mpap...@fastmail.fm>>
> ---
> drivers/staging/gdm72xx
On 07/01/2014 04:37 PM, Ben Chan wrote:
> On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas wrote:
>> Signed-off-by: Michalis Pappas
>> ---
>> drivers/staging/gdm72xx/gdm_wimax.c | 10 +++---
>> drivers/staging/gdm72xx/hci.h | 6 ++
>> 2 files chan
Remove code surrounded by otherwise unused #define LOOPBACK_TEST
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 4148013
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 2 ++
drivers/staging/gdm72xx/gdm_sdio.c | 7 +++
drivers/staging/gdm72xx/gdm_usb.c | 7 +++
drivers/staging/gdm72xx/gdm_wimax.c | 6 ++
drivers/staging/gdm72xx/gdm_wimax.h | 2 ++
5 files changed, 24
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 10 +++---
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
index 63a760b
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 10 +++---
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx/gdm_wimax.c
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 ++
drivers/staging/gdm72xx/gdm_sdio.c | 7 +++
drivers/staging/gdm72xx/gdm_usb.c | 7 +++
drivers/staging/gdm72xx/gdm_wimax.c | 6 ++
drivers/staging/gdm72xx/gdm_wimax.h | 2 ++
5 files
Remove code surrounded by otherwise unused #define LOOPBACK_TEST
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 18 --
1 file changed, 18 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b/drivers/staging/gdm72xx
On 07/01/2014 04:37 PM, Ben Chan wrote:
On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas mpap...@fastmail.fm wrote:
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 10 +++---
drivers/staging/gdm72xx/hci.h | 6 ++
2 files changed, 9
On 07/01/2014 04:30 PM, Ben Chan wrote:
On Tue, Jul 1, 2014 at 6:00 AM, Michalis Pappas mpap...@fastmail.fm
mailto:mpap...@fastmail.fm wrote:
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
mailto:mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2
Fixes the following checkpatch.pl issue:
CHECK: extern prototypes should be avoided in .h files
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/sdio_boot.h | 2 +-
drivers/staging/gdm72xx/usb_boot.h | 4 ++--
3 files changed, 6
Fixes the following checkpatch.pl issue:
CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct
qos_entry_s)...)
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx
Fixes the following checkpatch.pl issue:
CHECK: Logical continuations should be on the previous line
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b/drivers/staging
Fixes the following checkpatch.pl issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 16
drivers/staging/gdm72xx/netlink_k.c | 7 ---
2 files changed, 12 insertions(+), 11 deletions
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_sdio.c | 14 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 29 +
drivers/staging/gdm72xx/gdm_usb.c | 17
drivers/staging/gdm72xx/gdm_usb.h | 11 +
drivers
Fixes the following checkpatch.pl issues:
WARNING: unnecessary whitespace before a quoted newline
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
Also some additional, whitespace related, readability issues.
Signed-off-by: Michalis Pappas
---
drivers
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.h | 17 -
drivers/staging/gdm72xx/gdm_wimax.c | 4
drivers/staging/gdm72xx/gdm_wimax.h | 6 --
drivers/staging/gdm72xx/usb_boot.c | 17 +
4 files changed, 1 insertion(+), 43 deletions
Fixes the following checkpatch.pl issue:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
Fixes the following checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging
On 04/29/2014 10:03 AM, Michalis Pappas wrote:
> Ok, I generated a new patchset based on running checkpatch.pl with the
> --strict option, as well as any recommendations made earlier on this thread.
>
> From the following patches, both 8/10 and 9/10 involve whitespace fixes:
> t
On 04/29/2014 10:03 AM, Michalis Pappas wrote:
Ok, I generated a new patchset based on running checkpatch.pl with the
--strict option, as well as any recommendations made earlier on this thread.
From the following patches, both 8/10 and 9/10 involve whitespace fixes:
the former fixes issues
Fixes the following checkpatch.pl issue:
CHECK: Avoid CamelCase:
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.h | 17 -
drivers/staging/gdm72xx/gdm_wimax.c | 4
drivers/staging/gdm72xx/gdm_wimax.h | 6 --
drivers/staging/gdm72xx/usb_boot.c | 17 +
4 files changed, 1
Fixes the following checkpatch.pl issue:
WARNING: Comparing jiffies is almost always wrong; prefer time_after,
time_before and friends
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion
Fixes the following checkpatch.pl issues:
WARNING: unnecessary whitespace before a quoted newline
CHECK: Alignment should match open parenthesis
CHECK: No space is necessary after a cast
Also some additional, whitespace related, readability issues.
Signed-off-by: Michalis Pappas mpap
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_sdio.c | 14 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 29 +
drivers/staging/gdm72xx/gdm_usb.c | 17
drivers/staging/gdm72xx/gdm_usb.h | 11
Fixes the following checkpatch.pl issue:
CHECK: braces {} should be used on all arms of this statement
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 16
drivers/staging/gdm72xx/netlink_k.c | 7 ---
2 files changed, 12
Fixes the following checkpatch.pl issue:
CHECK: Logical continuations should be on the previous line
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
Fixes the following checkpatch.pl issue:
CHECK: Prefer kmalloc(sizeof(*entry)...) over kmalloc(sizeof(struct
qos_entry_s)...)
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers
Fixes the following checkpatch.pl issue:
CHECK: extern prototypes should be avoided in .h files
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/sdio_boot.h | 2 +-
drivers/staging/gdm72xx/usb_boot.h | 4 ++--
3
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers
Indentation and other whitespace fixes.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_sdio.c | 14 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 29 +
drivers/staging/gdm72xx/gdm_usb.c | 17
drivers/staging
Whitespace fixes to conform to coding standards
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 72 ++---
drivers/staging/gdm72xx/gdm_sdio.c | 15
drivers/staging/gdm72xx/gdm_usb.c | 43 --
drivers/staging
Removed commented-out code
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.h | 17 -
drivers/staging/gdm72xx/gdm_wimax.c | 4
drivers/staging/gdm72xx/gdm_wimax.h | 6 --
drivers/staging/gdm72xx/usb_boot.c | 17 +
4 files changed
Fixed some braces to conform with coding style
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.c | 16
drivers/staging/gdm72xx/netlink_k.c | 7 ---
2 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_wimax.c
b
Fixed some camelCase variables
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index 519db48
Moved logical continuation to previous line to conform to coding style
---
drivers/staging/gdm72xx/gdm_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b/drivers/staging/gdm72xx/gdm_usb.c
index 9ddf8f5..b9d7643 100644
---
Modified struct allocation to match coding standards
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..519db48 100644
---
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b
Removed unnecessary extern declarations from header files
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/sdio_boot.h | 2 +-
drivers/staging/gdm72xx/usb_boot.h | 4 ++--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git
Ok, I generated a new patchset based on running checkpatch.pl with the
--strict option, as well as any recommendations made earlier on this thread.
>From the following patches, both 8/10 and 9/10 involve whitespace fixes:
the former fixes issues reported by checkpatch.pl while the latter is
Ok, I generated a new patchset based on running checkpatch.pl with the
--strict option, as well as any recommendations made earlier on this thread.
From the following patches, both 8/10 and 9/10 involve whitespace fixes:
the former fixes issues reported by checkpatch.pl while the latter is
mostly
Removed unnecessary extern declarations from header files
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.h | 6 +++---
drivers/staging/gdm72xx/sdio_boot.h | 2 +-
drivers/staging/gdm72xx/usb_boot.h | 4 ++--
3 files changed, 6 insertions(+), 6
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
Modified struct allocation to match coding standards
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
index 50d43ad..519db48 100644
---
Moved logical continuation to previous line to conform to coding style
---
drivers/staging/gdm72xx/gdm_usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b/drivers/staging/gdm72xx/gdm_usb.c
index 9ddf8f5..b9d7643 100644
---
Fixed some camelCase variables
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 31 +++
1 file changed, 15 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_qos.c
b/drivers/staging/gdm72xx/gdm_qos.c
Fixed some braces to conform with coding style
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_wimax.c | 16
drivers/staging/gdm72xx/netlink_k.c | 7 ---
2 files changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/staging
Removed commented-out code
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.h | 17 -
drivers/staging/gdm72xx/gdm_wimax.c | 4
drivers/staging/gdm72xx/gdm_wimax.h | 6 --
drivers/staging/gdm72xx/usb_boot.c | 17
Whitespace fixes to conform to coding standards
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 72 ++---
drivers/staging/gdm72xx/gdm_sdio.c | 15
drivers/staging/gdm72xx/gdm_usb.c | 43
Indentation and other whitespace fixes.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_sdio.c | 14 +++---
drivers/staging/gdm72xx/gdm_sdio.h | 29 +
drivers/staging/gdm72xx/gdm_usb.c | 17
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb:
fix deprecated function kernel_thread')
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion
On 04/23/2014 04:04 PM, Dan Carpenter wrote:
> On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote:
>> After all patches have been applied, the only remaining issue on the
>> TODO list is to conform to the coding standards. The remaining issues
>> repo
On 04/23/2014 04:04 PM, Dan Carpenter wrote:
On Wed, Apr 23, 2014 at 08:39:06AM +0800, Michalis Pappas wrote:
After all patches have been applied, the only remaining issue on the
TODO list is to conform to the coding standards. The remaining issues
reported by checkpatch.pl are probably
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b
Removed line related to replacement of kernel_thread with kthread, as issue
was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function
kernel_thread')
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git
Minor white-space fixes as suggested by checkpatch.pl.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_wimax.c | 2 ++
drivers/staging/gdm72xx/usb_boot.c | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers
The following patches perform various cleanups on the gdm72xx driver.
PATCH 1/3 fixes some small coding style issues
PATCH 2/3 removes an already completed item from the TODO list
PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions
After all patches have been applied, the only
The following patches perform various cleanups on the gdm72xx driver.
PATCH 1/3 fixes some small coding style issues
PATCH 2/3 removes an already completed item from the TODO list
PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions
After all patches have been applied, the only
Minor white-space fixes as suggested by checkpatch.pl.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_wimax.c | 2 ++
drivers/staging/gdm72xx/usb_boot.c | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff
Removed line related to replacement of kernel_thread with kthread, as issue
was fixed on ff5e4a1d2702 ('Staging: gdm72xx: gdm_usb: fix deprecated function
kernel_thread')
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/TODO b/drivers/staging
Minor white-space fixes as suggested by checkpatch.pl.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_wimax.c | 2 ++
drivers/staging/gdm72xx/usb_boot.c | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers
The following patches perform various cleanups on the gdm72xx driver.
PATCH 1/3 fixes some small coding style issues
PATCH 2/3 removes an already completed item from the TODO list
PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions
After all patches have been applied, the only
The following patches perform various cleanups on the gdm72xx driver.
PATCH 1/3 fixes some small coding style issues
PATCH 2/3 removes an already completed item from the TODO list
PATCH 3/3 replaces some jiffies comparisons with wrap-safe functions
After all patches have been applied, the only
Minor white-space fixes as suggested by checkpatch.pl.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_qos.c | 2 +-
drivers/staging/gdm72xx/gdm_wimax.c | 2 ++
drivers/staging/gdm72xx/usb_boot.c | 1 +
3 files changed, 4 insertions(+), 1 deletion(-)
diff
Removed line related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/TODO
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging
Made q_ops static, as suggested by sparse.
Signed-off-by: Michalis Pappas
---
drivers/staging/media/dt3155v4l/dt3155v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c
b/drivers/staging/media/dt3155v4l/dt3155v4l.c
index e729e52
Made q_ops static, as suggested by sparse.
Signed-off-by: Michalis Pappas mpap...@fastmail.fm
---
drivers/staging/media/dt3155v4l/dt3155v4l.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/dt3155v4l/dt3155v4l.c
b/drivers/staging/media/dt3155v4l
Replaced comparisons on jiffies values with wrap-safe functions.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/gdm_usb.c | 2 +-
drivers/staging/gdm72xx/sdio_boot.c | 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/gdm72xx/gdm_usb.c
b
Removed task related to replacement of kernel_thread with kthread,
as issue was fixed on ff5e4a1d2702582614996f6f6d005e9b5caadeb8.
Signed-off-by: Michalis Pappas
---
drivers/staging/gdm72xx/TODO | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/gdm72xx/TODO b/drivers/staging
1 - 100 of 108 matches
Mail list logo
