On Sat, Aug 24, 2019 at 1:25 PM Will Deacon wrote:
>
> Which bit are you pinging about? This patch (12/16) has been in -next for a
> while and is queued in the arm64 tree for 5.4. The Oops/boot issue is
> addressed in patch 14 which probably needs to be sent as a separate patch
> (with a commit
On Thu, Aug 15, 2019 at 11:12 AM Miguel Ojeda
wrote:
>
> Btw, I guess that is the Oops you were mentioning in the cover letter?
Pinging about this...
Cheers,
Miguel
On Mon, Aug 19, 2019 at 9:51 AM Nishka Dasgupta
wrote:
>
> The static structures ht16k33_fb_fix and ht16k33_fb_var, of types
> fb_fix_screeninfo and fb_var_screeninfo respectively, are not used
> except to be copied into other variables. Hence make both of them
> constant to prevent unintended
On Fri, Aug 16, 2019 at 1:05 AM Nick Desaulniers
wrote:
>
> On Thu, Aug 15, 2019 at 3:59 PM Miguel Ojeda
> wrote:
> >
> > On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor
> > wrote:
> > > * Revert commit bfd77145f35c ("Makefile: Convert -Wimplic
On Thu, Aug 15, 2019 at 10:45 PM Nathan Chancellor
wrote:
>
> I am still not a huge fan of the CONFIG_CC_IS_CLANG ifdefs but I don't
> really see a much cleaner way to get around this. Some that come to
> mind:
Yeah...
> * Revert commit bfd77145f35c ("Makefile: Convert -Wimplicit-fallthrough=3
Hi Linus,
Please pull these few fixes for auxdisplay for this cycle.
Cheers,
Miguel
The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d:
Linux 5.3-rc3 (2019-08-04 18:40:12 -0700)
are available in the Git repository at:
https://github.com/ojeda/linux.git
On Thu, Aug 15, 2019 at 11:08 AM Miguel Ojeda
wrote:
>
> On Thu, Aug 15, 2019 at 12:20 AM Nick Desaulniers
> wrote:
> >
> > This lone patch of the series is just cosmetic, but patch 14/16 fixes
> > a real boot issue:
> > https://github.com/ClangBuiltLinux/linu
On Thu, Aug 15, 2019 at 12:20 AM Nick Desaulniers
wrote:
>
> This lone patch of the series is just cosmetic, but patch 14/16 fixes
> a real boot issue:
> https://github.com/ClangBuiltLinux/linux/issues/619
> Miguel, I'd like to get that one landed ASAP; the rest are just for
> consistency.
Ah,
On Mon, Aug 12, 2019 at 6:29 PM Nick Desaulniers
wrote:
>
> On Sat, Aug 10, 2019 at 8:06 PM Joe Perches wrote:
> >
> > On Sat, 2019-08-10 at 19:04 -0700, Nathan Chancellor wrote:
> > > On a tangential note, how are you planning on doing the fallthrough
> > > comment to attribute conversion? The
On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote:
>
> Hi Nick,
>
> On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote:
> > GCC unescapes escaped string section names while Clang does not. Because
> > __section uses the `#` stringification operator for the section name, it
> >
On Sat, Aug 10, 2019 at 12:21 AM Nick Desaulniers
wrote:
>
> Hi Joe,
> While debugging:
> https://github.com/ClangBuiltLinux/linux/issues/619
> we found a bunch of places where __section is not used but could be,
> and uses a string literal when it probably should not be.
>
> Just a thought that
On Thu, Jul 4, 2019 at 9:34 PM Mans Rullgard wrote:
>
> While the individual CHARLCD_BL_xxx options have help texts, the
> menu itself does not. Fix this.
>
> Signed-off-by: Mans Rullgard
Picked it up and added a bit of extra explanation, thanks!
Cheers,
Miguel
On Mon, Jul 8, 2019 at 2:37 PM zhengbin wrote:
>
> In panel_attach, if misc_register fails, we need to delete scan_timer,
> which was setup in keypad_init->init_scan_timer.
>
> Reported-by: Hulk Robot
> Signed-off-by: zhengbin
Picked it up, thanks!
Cheers,
Miguel
On Tue, Aug 6, 2019 at 4:25 PM Masanari Iida wrote:
>
> This patch fix a spelling typo in cfag12864b-example.c
>
> Signed-off-by: Masanari Iida
Picked it up, thanks!
Cheers,
Miguel
On Tue, Aug 6, 2019 at 9:18 AM Geert Uytterhoeven wrote:
>
> On Tue, Aug 6, 2019 at 9:16 AM Masahiro Yamada
> wrote:
> > This header is included in drivers/auxdisplay/. Make it a local header.
> >
> > Signed-off-by: Masahiro Yamada
>
> Reviewed-by: Geert Uytterhoeven
Picked it up, thanks!
On Tue, Aug 6, 2019 at 9:15 AM Masahiro Yamada
wrote:
>
> Add a header include guard just in case.
>
> Signed-off-by: Masahiro Yamada
Picked it up, thanks!
Cheers,
Miguel
On Mon, Aug 5, 2019 at 1:55 PM Greg KH wrote:
>
> I think I got it working now, all looks good for 4.9.y, 4.14.y and
> 4.19.y for gcc9 so far. I'll leave 4.4.y alone :)
You are welcome! I am glad we can now use gcc 9 easily. I will be
keeping a look into gcc 10. :)
Cheers,
Miguel
On Sun, Aug 4, 2019 at 8:09 PM Linus Torvalds
wrote:
>
> So my only real concern is that the comment approach has always been
> the really traditional one, going back all the way to 'lint' days.
>
> And you obviously cannot use a #define to create a comment, so this
> whole keyword model will
On Fri, Aug 2, 2019 at 5:56 PM Greg KH wrote:
>
> I see a ton of warnings on those kernels today. I'll look into it next
> week after I apply your patches to see what's missing.
Yeah, the objtool ones -- I thought you were referring to the
-Wmissing-attributes that Rolf asked about (I am not
On Fri, Aug 2, 2019 at 1:25 PM Greg KH wrote:
>
> But it still doesn't work for 4.14.y and 4.19.y, so we are probably
> missing something there. So if you want to fix that up, I'd appreciate
> patches to do so :)
Hm... For 4.19.y and 4.14.y, I cannot see the init/exit_module
warnings under GCC
On Fri, Aug 2, 2019 at 12:33 PM Greg KH wrote:
>
> On Fri, Aug 02, 2019 at 12:19:33PM +0200, Miguel Ojeda wrote:
> > On Fri, Aug 2, 2019 at 10:17 AM Rolf Eike Beer wrote:
> > >
> > > Am Samstag, 8. Juni 2019, 14:00:34 CEST schrieb Miguel Ojeda:
> > > &
On Fri, Aug 2, 2019 at 12:33 PM Greg KH wrote:
>
> On Fri, Aug 02, 2019 at 12:19:33PM +0200, Miguel Ojeda wrote:
> > On Fri, Aug 2, 2019 at 10:17 AM Rolf Eike Beer wrote:
> > >
> > > Am Samstag, 8. Juni 2019, 14:00:34 CEST schrieb Miguel Ojeda:
> > > &
On Fri, Aug 2, 2019 at 10:17 AM Rolf Eike Beer wrote:
>
> Am Samstag, 8. Juni 2019, 14:00:34 CEST schrieb Miguel Ojeda:
> > On Thu, Jun 6, 2019 at 8:59 PM Greg KH wrote:
> > > "manually fixing it up" means "hacked it to pieces" to me, I have
On Thu, Aug 1, 2019 at 10:10 PM wrote:
>
> I'm not disagreeing... I think using a macro makes sense.
It is either a macro or waiting for 5+ years (while we keep using the
comment style) :-)
In case it helps to make one's mind about whether to go for it or not,
I summarized the advantages and a
On Thu, Aug 1, 2019 at 9:29 PM Andy Shevchenko
wrote:
>
> There were discussions in the past about use cases for
> simple_strto() functions and, in some rare cases,
> they have a benefit over kstrto() ones.
>
> Update a comment to reduce confusion about special use cases.
>
&
On Thu, Aug 1, 2019 at 12:07 AM Joe Perches wrote:
>
> Note also that this doesn't actually _use_ fallthrough
> it just reserves it.
If we are reserving it, we should be giving a compile error instead. I
don't see how users will understand they shouldn't use it just yet (it
is the same as adding
On Wed, Jul 31, 2019 at 11:01 PM wrote:
>
> The standard is moving toward adding this as an attribute with the
> [[fallthrough]] syntax; it is in C++17, not sure when it will be in C be if
> it isn't already.
Not yet, but it seems to be coming:
On Wed, Jul 31, 2019 at 10:02 PM Kees Cook wrote:
>
> On Wed, Jul 31, 2019 at 08:48:32PM +0200, Peter Zijlstra wrote:
> > On Wed, Jul 31, 2019 at 11:24:36AM -0700, h...@zytor.com wrote:
> > > >> > +/*
> > > >> > + * Add the pseudo keyword 'fallthrough' so case statement blocks
> > > >> > + * must
On Tue, Jun 25, 2019 at 9:19 AM Peter Zijlstra wrote:
>
> Can it build a kernel without patches yet? That is, why should I care
> what LLVM does?
Having more than a single compiler is always a good idea. You benefit
from more warnings, more tooling, a second implementation for
On Mon, Jun 24, 2019 at 10:53 PM Gustavo A. R. Silva
wrote:
>
> Once the C++17 `__attribute__((fallthrough))` is more widely handled by C
> compilers,
> static analyzers, and IDEs, we can switch to using that instead. Also, we are
> a few
> warnings away (less than five) from being able to
Hi Linus,
A cleanup that was in -next for several weeks (before I added
an Ack). It is late in the cycle, so pick it up if you feel
like it!
Cheers,
Miguel
The following changes since commit 9e0babf2c06c73cda2c0cd37a1653d823adb40ec:
Linux 5.2-rc5 (2019-06-16 08:49:45 -1000)
are available in
On Wed, Jun 19, 2019 at 6:38 PM Andy Shevchenko
wrote:
>
> There were discussions in the past about use cases for
> simple_strto() functions and in some rare cases they have a benefit
> on kstrto() ones.
>
> Update a comment to reduce confusing about special use cases.
I don't recall the
On Sun, May 26, 2019 at 6:05 PM Souptick Joarder wrote:
>
> While using mmap, the incorrect values of length and vm_pgoff are
> ignored and this driver goes ahead with mapping cfag12864b_buffer
> to user vma.
>
> Convert vm_insert_pages() to use vm_map_pages_zero(). We could later
> "fix" these
On Mon, Jun 10, 2019 at 4:49 PM Greg KH wrote:
>
> On Mon, Jun 10, 2019 at 04:42:27PM +0200, Miguel Ojeda wrote:
> > I think Josh Poimboeuf added support for a few related things in GCC 8
> > (e.g. 13810435b9a7 ("objtool: Support GCC 8's cold subfunctions")).
>
On Mon, Jun 10, 2019 at 4:21 PM Greg KH wrote:
>
> > I also checked that 4.19.49 compiles fine with GCC 9, although with a
> > lot of warnings, mostly from objtool, like "warning: objtool:
> > sock_register()+0xd: sibling call from callable instruction with
> > modified stack frame". But it's a
On Thu, Jun 6, 2019 at 8:59 PM Greg KH wrote:
>
> "manually fixing it up" means "hacked it to pieces" to me, I have no
> idea what the end result really was :)
>
> If someone wants to send me some patches I can actually apply, that
> would be best...
I will give it a go whenever I get some free
On Thu, Jun 6, 2019 at 5:29 PM Greg KH wrote:
>
> And if you want this, you should look at how the backports to 4.14.y
> worked, they did not include a3f8a30f3f00 ("Compiler Attributes: use
> feature checks instead of version checks"), as that gets really messy...
I am confused -- I interpreted
On Wed, May 29, 2019 at 9:09 AM Souptick Joarder wrote:
>
> On Wed, May 29, 2019 at 1:38 AM Miguel Ojeda
> wrote:
> >
> > If the user asks us for offset == num, we should already fail in the
> > first check, i.e. the one testing for offsets beyond the object
there.
Signed-off-by: Miguel Ojeda
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index ddf20bd0c317..74cf8b0ce353 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1547,7 +1547,7 @@ static int __vm_map_pages(struct vm_area_struct *vma,
struct page
On Fri, May 24, 2019 at 8:07 AM Souptick Joarder wrote:
>
> > > Taking a quick look now, by the way, why does vm_map_pages_zero() (and
> > > __vm_map_pages() etc.) get a pointer to an array instead of a pointer
> > > to the first element?
>
> For this particular driver, one page is getting mapped
On Thu, May 23, 2019 at 2:58 PM Miguel Ojeda
wrote:
>
> Taking a quick look now, by the way, why does vm_map_pages_zero() (and
> __vm_map_pages() etc.) get a pointer to an array instead of a pointer
> to the first element?
Also, in __vm_map_pages(), semantically w.r.t. to the commen
On Fri, May 24, 2019 at 4:12 AM Steven Rostedt wrote:
>
> On Thu, 23 May 2019 14:45:35 +0200
> Miguel Ojeda wrote:
>
> I still prefer the typecast of void *, as that's used a bit more in the
> kernel, but since char * is also used (not as much), I'll leave it. But
> the pa
On Mon, May 20, 2019 at 5:26 PM Souptick Joarder wrote:
>
> While using mmap, the incorrect value of length and vm_pgoff are
> ignored and this driver go ahead with mapping fbdev.buffer
> to user vma.
Typos: values*, goes* (same for the other patch)
> Convert vm_insert_pages() to use
On Thu, May 23, 2019 at 10:18 AM Souptick Joarder wrote:
>
> Miguel, Ack from Robin is missing in linux-next-20190523 when applied.
Thanks for the warning! I wanted to review first but didn't get to it yet.
Taking a quick look now, by the way, why does vm_map_pages_zero() (and
__vm_map_pages()
places doing this clear (trace.c and trace_kdb.c),
take the chance to move the workaround into a single place in
the internal header.
Signed-off-by: Miguel Ojeda
---
kernel/trace/trace.c | 6 +-
kernel/trace/trace.h | 18 ++
kernel/trace/trace_kdb.c | 6 +-
3 files
On Wed, May 22, 2019 at 1:52 PM Steven Rostedt wrote:
>
> On Wed, 22 May 2019 11:58:10 +0200
> Miguel Ojeda wrote:
>
> > +/* reset all but tr, trace, and overruns */
> > +static __always_inline void trace_iterator_reset(struct trace_iterator
> > *iter)
> >
places doing this clear (trace.c and trace_kdb.c),
take the chance to move the workaround into a single place in
the internal header.
Signed-off-by: Miguel Ojeda
---
Steven, let me know if you still prefer (char *) or anything else
(or just change it in your side if you want :-)
kernel/trace
On Fri, May 17, 2019 at 11:25 AM Miguel Ojeda
wrote:
>
> ./include/linux/string.h:344:9: warning: '__builtin_memset' offset
> [8505, 8560] from the object at 'iter' is out of the bounds of
By the way, I noticed these offsets of the new warning seem to be off
by 1, repo
On Fri, May 17, 2019 at 7:59 PM Linus Torvalds
wrote:
>
> On Fri, May 17, 2019 at 2:25 AM Miguel Ojeda
> wrote:
> >
> > + memset((char *)(iter) + offsetof(struct trace_iterator, seq), 0,
> > + sizeof(struct trace_iterator) -
> > +
Hi Steven,
On Fri, May 17, 2019 at 6:47 PM Steven Rostedt wrote:
>
> Hi Miguel,
>
> Linus mentioned this too.
>
>
> https://lore.kernel.org/lkml/CAHk-=wihyb8w__yqjgyjyzsvniu5ctktcfycmcgdqvg8guj...@mail.gmail.com/T/#u
Ah, I didn't see that. We were discussing here [1] backporting to 4.19
some
On Fri, May 17, 2019 at 11:23 AM Greg KH wrote:
>
> On Fri, May 17, 2019 at 11:01:45AM +0200, Miguel Ojeda wrote:
>
> > a6e60d84989f ("include/linux/module.h: copy __init/__exit attrs to
> > init/cleanup_module")
>
> That patch I applied now.
Note
places doing this clear (trace.c and trace_kdb.c),
take the chance to move the workaround into a single place in
the internal header.
Signed-off-by: Miguel Ojeda
---
kernel/trace/trace.c | 7 +--
kernel/trace/trace.h | 14 ++
kernel/trace/trace_kdb.c | 7 +--
3 files
On Fri, May 17, 2019 at 10:51 AM Greg KH wrote:
>
> On Fri, May 17, 2019 at 10:35:29AM +0200, Miguel Ojeda wrote:
> > On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra wrote:
> > >
> > > Right; if there is anything you can reproduce on linus.git I'll happily
&g
On Fri, May 17, 2019 at 9:38 AM Peter Zijlstra wrote:
>
> On Fri, May 17, 2019 at 07:09:31AM +0200, Greg KH wrote:
> > On Thu, May 16, 2019 at 08:14:25PM -0700, Ivan Babrou wrote:
> > > We are building the upstream kernel. There are a few patches, but
> > > nothing related to objtool.
> > >
> > >
Hi,
On Thu, May 16, 2019 at 10:11 PM Ivan Babrou wrote:
>
> Hey Miguel,
>
> The first error is during perf build process (make -C tools/perf install):
>
> [17:38:21] In file included from /usr/include/string.h:635,
> [17:38:21] from ui/tui/helpline.c:4:
> [17:38:21] In function
:54
+0200)
The usual roughly-per-release .clang-format macro list update
--------
Miguel Ojeda (1):
clang-format: Update with the latest for_each macro list
.clang-format | 24
1 file changed, 24 insertions(+)
Re-run the shell fragment that generated the original list now that
there are two dozens of new entries after v5.1's merge window.
---
Sending this as a PR for the next -rc.
.clang-format | 24
1 file changed, 24 insertions(+)
diff --git a/.clang-format b/.clang-format
Hi Linus,
On Sun, Mar 24, 2019 at 10:10 PM Linus Torvalds
wrote:
>
> Side note: this is very annoying. As part of the rc release I'm going
> through things like this, and I notice that the new Kconfig option has
> absolutely no help text.
>
> That might be acceptable if the choice of options
Hi Linus,
Please pull these fixes and improvements for auxdisplay.
Cheers,
Miguel
The following changes since commit 1c163f4c7b3f621efff9b28a47abb36f7378d783:
Linux 5.0 (2019-03-03 15:21:29 -0800)
are available in the Git repository at:
https://github.com/ojeda/linux.git
On Sat, Mar 23, 2019 at 3:51 PM Randy Dunlap wrote:
>
> I haven't seen any issues with this in linux-next, so go ahead, please.
Thanks for the very quick answer, Randy!
Cheers,
Miguel
On Wed, Mar 6, 2019 at 11:14 AM Miguel Ojeda
wrote:
>
> Since you are touching the panel.c options, CC'ing the maintainers
> (please do run get_maintainer.pl in that case!)
I was preparing the PR for -rc2 and I just noticed we didn't CC Randy
which was the last one changing the Kconfi
On Tue, Mar 12, 2019 at 4:48 PM Måns Rullgård wrote:
>
> The current code unconditionally flashes the light once. I though it
> best to keep that behaviour as default, even if it's not seen as ideal.
Sent into -next. If no one else says anything after a few days, I will
send the series for
On Tue, Mar 12, 2019 at 4:46 PM Andy Shevchenko
wrote:
>
> It seems these two series are orthogonal to each other, so, can be applied
> separately.
Sent to -next for a few days.
Cheers,
Miguel
On Tue, Mar 12, 2019 at 9:46 AM Geert Uytterhoeven wrote:
>
> Yeah, the alphas on the server side, powering AltaVista, are also long
> gone...
As usual with these things, people can still use older Linux releases
for a very long time. If they really need it (e.g. commercially), they
have the
On Wed, Mar 13, 2019 at 8:03 AM Enrico Weigelt, metux IT consult
wrote:
>
> On 12.03.19 17:33, Greg KH wrote:
> > On Tue, Mar 12, 2019 at 03:57:33PM +0100, Enrico Weigelt, metux IT consult
> > wrote:
> >> ---
> >> drivers/tty/serial/8250/8250_bcm2835aux.c | 12
> >> 1 file changed,
Hi Enrico,
On Mon, Mar 11, 2019 at 2:21 PM Enrico Weigelt, metux IT consult
wrote:
>
> Formatting of Kconfig files doesn't look so pretty, so let the
> Great White Handkerchief come around and clean it up.
I am all for humor in the right places, but this does not even explain
why this is being
On Tue, Mar 12, 2019 at 3:44 PM Andy Shevchenko
wrote:
>
> I have found a memory leak in hd44780 and it becomes that we have no
> counterpart to charlcd_alloc() that developers can easily miss.
Side-note now that I see these patches: I forgot to CC you in a series
for charlcd that we got from
On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard wrote:
>
> The auxdisplay Kconfig is confusing. It creates two separate menus
> even though the settings are closely related. Moreover, the options
> for setting the boot message depend on CONFIG_PARPORT even though they
> are used by drivers that do
On Wed, Mar 6, 2019 at 10:56 AM Miguel Ojeda
wrote:
>
> CC'ing Willy in case he wants to take a look for charlcd.c
(and Geert, sorry!)
Cheers,
Miguel
On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard wrote:
>
> /* display a short message */
> -#ifdef CONFIG_PANEL_CHANGE_MESSAGE
> - charlcd_puts(lcd, "\x1b[Lc\x1b[Lb\x1b[L*" CONFIG_PANEL_BOOT_MESSAGE);
> -#else
> - charlcd_puts(lcd, "\x1b[Lc\x1b[Lb\x1b[L*Linux-" UTS_RELEASE "\n");
On Fri, Mar 1, 2019 at 7:48 PM Mans Rullgard wrote:
>
> +#ifdef CONFIG_CHARLCD_BL_ON
> +#define LCD_INIT_BL "\x1b[L+"
> +#elif defined (CONFIG_CHARLCD_BL_FLASH)
Style nitpick: no space after "elif defined". Do you mind if I change
it before sending it to linux-next? Otherwise, looks fine to me.
)
auxdisplay:
- ht16k33: fix potential user-after-free on module unload
Reported by Sven Van Asbroeck
Miguel Ojeda (1):
auxdisplay: ht16k33: fix potential user-after-free on module unload
[-Wmissing-attributes]
These patch series clean these new warnings. Most of them are caused
by the module_init/exit macros.
Link: https://lore.kernel.org/lkml/20190125104353.2791-1-labb...@redhat.com/
--------
Miguel Ojeda (3):
lib/crc
On Mon, Feb 11, 2019 at 8:26 AM Robin van der Gracht wrote:
>
> Looks good
>
> Acked-by: Robin van der Gracht
Thanks all! I will send this for -rc7.
Cheers,
Miguel
Hi Sven,
On Sun, Feb 10, 2019 at 7:05 PM Sven Van Asbroeck wrote:
>
> For relatively straightforward problems, I'd say yes.
>
> However, the problems flagged by this script are not trivial at all.
> In many cases, the missing _sync is just a symptom of general
> synchronization issues on
On Sat, Feb 9, 2019 at 9:33 PM Laura Abbott wrote:
>
> Tested-by: Laura Abbott
>
> You can look at the full build logs at
> https://koji.fedoraproject.org/koji/taskinfo?taskID=326911 .
>
> Thanks,
> Laura
Thanks a lot for the tests, Laura!
I will send this for -rc7.
Cheers,
Miguel
On Sat, Feb 9, 2019 at 1:41 AM Nick Desaulniers wrote:
>
> Drop "they" from this sentence if there's a respin, otherwise looks helpful.
> Reviewed-by: Nick Desaulniers
Good catch!
Thank you,
Miguel
On Sat, Feb 9, 2019 at 12:26 PM Ard Biesheuvel
wrote:
>
> On Sat, 9 Feb 2019 at 12:19, Miguel Ojeda
> wrote:
> >
> > It also affects the optimizer in two different ways AFAIK:
> >
> > * For the function itself, it gets optimized for size instead of spee
On Sat, Feb 9, 2019 at 11:44 AM Ard Biesheuvel
wrote:
>
> On Sat, 9 Feb 2019 at 01:09, Miguel Ojeda
> wrote:
> >
> > The upcoming GCC 9 release extends the -Wmissing-attributes warnings
> > (enabled by -Wall) to C and aliases: it warns when particular function
ess it returns true and the work doesn't re-arm itself.
Explicitly flush or use cancel_delayed_work_sync() to wait on it.
Link:
https://lore.kernel.org/lkml/20190204220952.30761-1-thesve...@googlemail.com/
Reported-by: Sven Van Asbroeck
Signed-off-by: Miguel Ojeda
---
drivers/auxdisplay/ht16k33.c
nly __cold) for module.h as well. However, since we decided
to go with the new __copy attribute, I will leave the series for a few days
again and send the PR for -rc7.
Link: https://lore.kernel.org/lkml/20190125104353.2791-1-labb...@redhat.com/
Miguel Ojeda (3):
lib/crc32.c: mark crc32_le_base/__crc3
/lkml/20190206175627.ga20...@gmail.com/
Suggested-by: Martin Sebor
Signed-off-by: Miguel Ojeda
---
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/module.h b/include/linux/module.h
index 8fa38d3e7538..f5bc4c046461 100644
--- a/include
ed-by: Ard Biesheuvel
Tested-by: Laura Abbott
Signed-off-by: Miguel Ojeda
---
lib/crc32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/crc32.c b/lib/crc32.c
index 45b1d67a1767..4a20455d1f61 100644
--- a/lib/crc32.c
+++ b/lib/crc32.c
@@ -206,8 +206,8 @@ u32 __p
their
functions marked as such.
Suggested-by: Martin Sebor
Signed-off-by: Miguel Ojeda
---
include/linux/compiler_attributes.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/include/linux/compiler_attributes.h
b/include/linux/compiler_attributes.h
index 19f32b0c29af..6b318efd8a
On Thu, Feb 7, 2019 at 11:54 AM Jessica Yu wrote:
>
> My order of preference would be 2, 1, striving for 3 eventually.
For reference, for 3), we would need to tweak the following ~130
modules [1]. Quite a lot of them are the simple kind. Also, if we end
up with 3), we could potentially remove a
On Thu, Feb 7, 2019 at 11:28 PM Jason Gunthorpe wrote:
>
> Commit 2db76d7c3c6d ("lib/scatterlist: sg_page_iter: support sg lists w/o
> backing pages") introduced the sg_page_iter_dma_address() function without
> providing a way to use it in the general case. If the sg_dma_len() is not
> equal to
On Thu, Feb 7, 2019 at 11:33 PM Sven Van Asbroeck wrote:
>
> On Thu, Feb 7, 2019 at 5:21 PM Dmitry Torokhov
> wrote:
> >
> > > ./drivers//input/keyboard/matrix_keypad.c:512:1-18: missing clean-up
> > > of INIT_WORK/INIT_DELAYED_WORK initialized here
> >
> > This is not as simple.
> >
>
> PS If
Hi Stephen,
On Wed, Feb 6, 2019 at 10:31 PM Stephen Rothwell wrote:
>
> Hi Miguel,
>
> After merging the compiler-attributes tree, today's linux-next build
> (arm multi_v7_defconfig) failed like this:
>
> In file included from arch/arm/crypto/aes-neonbs-glue.c:17:
> include/linux/module.h:138:7:
On Wed, Feb 6, 2019 at 6:56 PM Miguel Ojeda
wrote:
>
> diff --git a/include/linux/module.h b/include/linux/module.h
> index 8fa38d3e7538..1b5e370f1bc0 100644
> --- a/include/linux/module.h
> +++ b/include/linux/module.h
> @@ -129,13 +129,13 @@ extern void cleanup_module
be assumed to be unlikely).
Link: https://lore.kernel.org/lkml/20190123173707.ga16...@gmail.com/
Suggested-by: Martin Sebor
Tested-by: Laura Abbott
Signed-off-by: Miguel Ojeda
---
The new version I pushed for -next.
include/linux/module.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions
On Wed, Feb 6, 2019 at 5:31 PM Miguel Ojeda
wrote:
>
> On Mon, Feb 4, 2019 at 4:08 PM Jessica Yu wrote:
> >
> > IMHO I think annotating with __init is more straightforward, instead
> > of cherry-picking attributes (we wouldn't know at first glance why the
> > alia
On Mon, Feb 4, 2019 at 4:08 PM Jessica Yu wrote:
>
> IMHO I think annotating with __init is more straightforward, instead
> of cherry-picking attributes (we wouldn't know at first glance why the
> aliases are specifically annotated with __cold without looking at git
> history). Plus the actual
Hi Jessica,
On Thu, Jan 31, 2019 at 3:22 PM Jessica Yu wrote:
>
> Hi Miguel, sorry for the delay!
No worries! :)
> The module init functions are only called once from do_init_module().
> Does the __cold attribute just assume it is unlikely to be executed,
> or just that it is infrequently
use it feels ugly. I went ahead and did the obvious fixup
> > but it's worth discussing if we're going to end up with an explosion or
> > if there's a better way to handle this in one macro.
>
> Bernd Edlinger has sent a patch to gcc for this:
> https://gcc.gnu.org/ml/gcc-patches
Signed-off-by: Miguel Ojeda
---
I am picking this up through the compiler-attributes tree
and putting it into -next along with the other cleanup
for -Wmissing-attributes (unless some other maintainer wants it).
lib/crc32.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/crc
Hi Laura,
On Wed, Jan 23, 2019 at 4:27 PM Laura Abbott wrote:
>
> This looks like we just need to make the attributes match
>
> BUILDSTDERR: lib/crc32.c:209:5: warning: 'crc32_le_base' specifies less
> restrictive attribute than its target 'crc32_le': 'pure'
> [-Wmissing-attributes]
>
On Wed, Jan 23, 2019 at 6:17 PM Miguel Ojeda
wrote:
>
> Hi Laura,
>
> On Wed, Jan 23, 2019 at 4:27 PM Laura Abbott wrote:
> >
> > There's also some missing attribute warnings. The majority are caused by a
> > missing attribute in module_init/module_exit
> >
&g
On Wed, Jan 23, 2019 at 6:17 PM Miguel Ojeda
wrote:
>
> Hi Laura,
>
> On Wed, Jan 23, 2019 at 4:27 PM Laura Abbott wrote:
> >
> > There's also some missing attribute warnings. The majority are caused by a
> > missing attribute in module_init/module_exit
> >
&g
in the definition of the aliases (since those are not
seen by any other TU).
Suggested-by: Martin Sebor
Signed-off-by: Miguel Ojeda
---
Note that an alternative is using the new copy attribute
introduced by GCC 9 (Martin told me about it, as well as the
new warning).
What I am concerned about using __copy
Hi Laura,
On Wed, Jan 23, 2019 at 4:27 PM Laura Abbott wrote:
>
> There's also some missing attribute warnings. The majority are caused by a
> missing attribute in module_init/module_exit
>
> BUILDSTDERR: In file included from drivers/scsi/hptiop.c:18:
> BUILDSTDERR:
301 - 400 of 1035 matches
Mail list logo
