Re: [PATCH] drivers/auxdisplay: TRIVIAl removed unnessecary braces from if statements

Hi Ben, On Sun, Sep 23, 2018 at 4:33 PM, wrote: > From: Ben Moore > > removed braches from single line if statements > > Signed-off-by: Ben Moore > --- > drivers/auxdisplay/panel.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/auxdisplay/panel.c

Re: [PATCH] drivers/auxdisplay: TRIVIAl removed unnessecary braces from if statements

Hi Ben, On Sun, Sep 23, 2018 at 4:33 PM, wrote: > From: Ben Moore > > removed braches from single line if statements > > Signed-off-by: Ben Moore > --- > drivers/auxdisplay/panel.c | 8 +++- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/auxdisplay/panel.c

Re: [PATCH TRIVIAL] Punctuation fixes

Hi Richard, On Sun, Sep 23, 2018 at 10:59 AM, Richard Weinberger wrote: > On Sun, Sep 23, 2018 at 3:00 AM Miguel Ojeda > wrote: >> >> Hi Diego, >> >> A few things, since it looks like this is your first patch. > > git log... Oops! I guess I mistyped the

Re: [PATCH TRIVIAL] Punctuation fixes

Hi Richard, On Sun, Sep 23, 2018 at 10:59 AM, Richard Weinberger wrote: > On Sun, Sep 23, 2018 at 3:00 AM Miguel Ojeda > wrote: >> >> Hi Diego, >> >> A few things, since it looks like this is your first patch. > > git log... Oops! I guess I mistyped the

Re: [PATCH TRIVIAL] Punctuation fixes

Hi Diego, A few things, since it looks like this is your first patch. On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola wrote: > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola wrote: >> >> Signed-off-by: Diego Viola >> --- >> CREDITS | 2 +- >> MAINTAINERS | 2 +- >> Makefile| 2 +- >> 3

Re: [PATCH TRIVIAL] Punctuation fixes

Hi Diego, A few things, since it looks like this is your first patch. On Sat, Sep 22, 2018 at 5:56 PM, Diego Viola wrote: > On Wed, Sep 12, 2018 at 12:54 AM Diego Viola wrote: >> >> Signed-off-by: Diego Viola >> --- >> CREDITS | 2 +- >> MAINTAINERS | 2 +- >> Makefile| 2 +- >> 3

Re: [PATCH] auxdisplay/cfag12864bfb.c: Replace vm_insert_page

On Fri, Sep 21, 2018 at 1:07 PM, Souptick Joarder wrote: > On Fri, Sep 21, 2018 at 2:56 AM Miguel Ojeda > wrote: >> >> A link to the discussion/plan would be nice. The commit 1c8f422059ae5 >> ("mm: change return type to vm_fault_t") explains a bit, bu

Re: [PATCH] auxdisplay/cfag12864bfb.c: Replace vm_insert_page

On Fri, Sep 21, 2018 at 1:07 PM, Souptick Joarder wrote: > On Fri, Sep 21, 2018 at 2:56 AM Miguel Ojeda > wrote: >> >> A link to the discussion/plan would be nice. The commit 1c8f422059ae5 >> ("mm: change return type to vm_fault_t") explains a bit, bu

Re: [PATCH] auxdisplay/cfag12864bfb.c: Replace vm_insert_page

On Thu, Sep 20, 2018 at 10:23 PM, Souptick Joarder wrote: > There is a plan to remove vm_insert_page permanently > and replace it with new API vmf_insert_page which will > return vm_fault_t type. As part of it vm_insert_page > is removed from this driver. A link to the discussion/plan would be

Re: [PATCH] auxdisplay/cfag12864bfb.c: Replace vm_insert_page

On Thu, Sep 20, 2018 at 10:23 PM, Souptick Joarder wrote: > There is a plan to remove vm_insert_page permanently > and replace it with new API vmf_insert_page which will > return vm_fault_t type. As part of it vm_insert_page > is removed from this driver. A link to the discussion/plan would be

Re: linux-next: disabling -Wstringop-truncation

Hi Stephen, Andi, (Linus), On Fri, Aug 31, 2018 at 3:17 AM, Linus Torvalds wrote: > On Thu, Aug 30, 2018 at 3:07 PM Stephen Rothwell > wrote: >> >> I am now mainly using gcc v8.2 for my builds and -Wstringop-truncation >> causes so many warnings that I am sure to miss others, so I have >>

Re: linux-next: disabling -Wstringop-truncation

Hi Stephen, Andi, (Linus), On Fri, Aug 31, 2018 at 3:17 AM, Linus Torvalds wrote: > On Thu, Aug 30, 2018 at 3:07 PM Stephen Rothwell > wrote: >> >> I am now mainly using gcc v8.2 for my builds and -Wstringop-truncation >> causes so many warnings that I am sure to miss others, so I have >>

Re: [PATCH v2 0/2] Compiler Attributes: (naked only, for v4.19)

On Thu, Sep 20, 2018 at 3:59 PM, Greg Kroah-Hartman wrote: > On Thu, Sep 20, 2018 at 03:57:48PM +0200, Greg Kroah-Hartman wrote: >> On Tue, Sep 18, 2018 at 06:55:40PM +0200, Miguel Ojeda wrote: >> > These two patches are the 5th and 6th of the Compiler Attributes series,

Re: [PATCH v2 0/2] Compiler Attributes: (naked only, for v4.19)

On Thu, Sep 20, 2018 at 3:59 PM, Greg Kroah-Hartman wrote: > On Thu, Sep 20, 2018 at 03:57:48PM +0200, Greg Kroah-Hartman wrote: >> On Tue, Sep 18, 2018 at 06:55:40PM +0200, Miguel Ojeda wrote: >> > These two patches are the 5th and 6th of the Compiler Attributes series,

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

On Thu, Sep 20, 2018 at 9:36 AM, Dominique Martinet wrote: > Greg Kroah-Hartman wrote on Thu, Sep 20, 2018: >> Why not just route these through Andrew? He takes lots of stuff like >> this for this very reason. > > That works for me (although it might have helped if Andrew had been in > Cc at any

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

On Thu, Sep 20, 2018 at 9:36 AM, Dominique Martinet wrote: > Greg Kroah-Hartman wrote on Thu, Sep 20, 2018: >> Why not just route these through Andrew? He takes lots of stuff like >> this for this very reason. > > That works for me (although it might have helped if Andrew had been in > Cc at any

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

On Thu, Sep 20, 2018 at 9:22 AM, Greg Kroah-Hartman wrote: > For this instance, I think we should just revert the offending patch, > which should resolve the issue for everyone and then you can try to redo > your series to get it right the next time. > > Sound good? On one hand, "reverting &

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

On Thu, Sep 20, 2018 at 9:22 AM, Greg Kroah-Hartman wrote: > For this instance, I think we should just revert the offending patch, > which should resolve the issue for everyone and then you can try to redo > your series to get it right the next time. > > Sound good? On one hand, "reverting &

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

Hi Dominique, On Thu, Sep 20, 2018 at 1:05 AM, Dominique Martinet wrote: > Greg Kroah-Hartman wrote on Wed, Sep 19, 2018: >> > > So, with this applied, does clang really build an arm32 kernel >> > > successfully? No other problem at all? And this isn't really a >> > > regression, arm32 never

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

Hi Dominique, On Thu, Sep 20, 2018 at 1:05 AM, Dominique Martinet wrote: > Greg Kroah-Hartman wrote on Wed, Sep 19, 2018: >> > > So, with this applied, does clang really build an arm32 kernel >> > > successfully? No other problem at all? And this isn't really a >> > > regression, arm32 never

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

On Wed, Sep 19, 2018 at 11:14 PM, Greg Kroah-Hartman wrote: > On Tue, Sep 18, 2018 at 08:56:04PM +0200, Miguel Ojeda wrote: >> Hi Greg, >> > >> Since Linus/Andrew/you >> didn't comment on whether you wanted or not this for 4.19, we are >> assuming they would

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

On Wed, Sep 19, 2018 at 11:14 PM, Greg Kroah-Hartman wrote: > On Tue, Sep 18, 2018 at 08:56:04PM +0200, Miguel Ojeda wrote: >> Hi Greg, >> > >> Since Linus/Andrew/you >> didn't comment on whether you wanted or not this for 4.19, we are >> assuming they would

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

Hi Greg, On Tue, Sep 18, 2018 at 7:34 PM, Greg Kroah-Hartman wrote: > On Tue, Sep 18, 2018 at 06:55:42PM +0200, Miguel Ojeda wrote: >> The naked attribute is supported by at least gcc >= 4.6 (for ARM, >> which is the only current user), gcc >= 8 (for x86), clang >= 3

Re: [PATCH v2 2/2] Compiler Attributes: naked can be shared

Hi Greg, On Tue, Sep 18, 2018 at 7:34 PM, Greg Kroah-Hartman wrote: > On Tue, Sep 18, 2018 at 06:55:42PM +0200, Miguel Ojeda wrote: >> The naked attribute is supported by at least gcc >= 4.6 (for ARM, >> which is the only current user), gcc >= 8 (for x86), clang >= 3

[PATCH v2 2/2] Compiler Attributes: naked can be shared

Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Suggested-by: Arnd Bergmann Tested-by: Stefan Agner Reviewed-by: Stefan Agner Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 -

[PATCH v2 2/2] Compiler Attributes: naked can be shared

Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Suggested-by: Arnd Bergmann Tested-by: Stefan Agner Reviewed-by: Stefan Agner Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 -

[PATCH v2 1/2] Compiler Attributes: naked was fixed in gcc 4.6

rvalds Cc: linux-spa...@vger.kernel.org Tested-by: Stefan Agner Reviewed-by: Stefan Agner Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/inc

[PATCH v2 1/2] Compiler Attributes: naked was fixed in gcc 4.6

rvalds Cc: linux-spa...@vger.kernel.org Tested-by: Stefan Agner Reviewed-by: Stefan Agner Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/inc

[PATCH v2 0/2] Compiler Attributes: (naked only, for v4.19)

Ojeda Miguel Ojeda (2): Compiler Attributes: naked was fixed in gcc 4.6 Compiler Attributes: naked can be shared include/linux/compiler-gcc.h | 14 -- include/linux/compiler_types.h | 8 2 files changed, 8 insertions(+), 14 deletions(-) -- 2.17.1

[PATCH v2 0/2] Compiler Attributes: (naked only, for v4.19)

Ojeda Miguel Ojeda (2): Compiler Attributes: naked was fixed in gcc 4.6 Compiler Attributes: naked can be shared include/linux/compiler-gcc.h | 14 -- include/linux/compiler_types.h | 8 2 files changed, 8 insertions(+), 14 deletions(-) -- 2.17.1

Re: [PATCH 2/2] Compiler Attributes: naked can be shared

On Tue, Sep 18, 2018 at 9:30 AM, Greg Kroah-Hartman wrote: > On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote: >> On 13.09.2018 16:59, Miguel Ojeda wrote: >> > The naked attribute is supported by at least gcc >= 4.6 (for ARM, >> > which is the only cu

Re: [PATCH 2/2] Compiler Attributes: naked can be shared

On Tue, Sep 18, 2018 at 9:30 AM, Greg Kroah-Hartman wrote: > On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote: >> On 13.09.2018 16:59, Miguel Ojeda wrote: >> > The naked attribute is supported by at least gcc >= 4.6 (for ARM, >> > which is the only cu

Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

On Fri, Sep 14, 2018 at 7:12 PM, Miguel Ojeda wrote: > Hi Harshit, Another two nitpicks: * Since this is the second version of the patch, write "[PATCH v2]" in the title instead; that way people know you have sent an earlier version. On top of that, you should explain the differ

Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

On Fri, Sep 14, 2018 at 7:12 PM, Miguel Ojeda wrote: > Hi Harshit, Another two nitpicks: * Since this is the second version of the patch, write "[PATCH v2]" in the title instead; that way people know you have sent an earlier version. On top of that, you should explain the differ

Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

Hi Harshit, On Fri, Sep 14, 2018 at 12:44 PM, Harshit Jain wrote: > From: Harshit Jain > > * This commit resolves the following warning when the mainline kernel is > build with the android environment. Typo: built > > -> warning :-> >

Re: [PATCH] scripts: unifdef: fix stringop-truncation warning

Hi Harshit, On Fri, Sep 14, 2018 at 12:44 PM, Harshit Jain wrote: > From: Harshit Jain > > * This commit resolves the following warning when the mainline kernel is > build with the android environment. Typo: built > > -> warning :-> >

Re: [PATCH] sched/core: Fix compiling warring in smp=n case

>> >> Fixes: 2e62c4743adc ("sched/fair: Remove #ifdefs from >> scale_rt_capacity()") > > > Hi, > > Miguel also found this warning. Can we pick it up now? ;-) Also Zhong has just sent another patch for this. Whenever this is picked up, feel free to add: Acked-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH] sched/core: Fix compiling warring in smp=n case

>> >> Fixes: 2e62c4743adc ("sched/fair: Remove #ifdefs from >> scale_rt_capacity()") > > > Hi, > > Miguel also found this warning. Can we pick it up now? ;-) Also Zhong has just sent another patch for this. Whenever this is picked up, feel free to add: Acked-by: Miguel Ojeda Cheers, Miguel

Re: [PATCH] sched: Fix a GCC compiled warning.

Hi Zhong, On Fri, Sep 14, 2018 at 4:49 PM, zhong jiang wrote: > Fix the following compile warning: > > kernel/sched/core.c: In function ‘update_rq_clock_task’: > kernel/sched/core.c:139:6: warning: unused variable ‘steal’ > [-Wunused-variable] > s64 steal = 0, irq_delta = 0; > Dou (and I,

Re: [PATCH] sched: Fix a GCC compiled warning.

Hi Zhong, On Fri, Sep 14, 2018 at 4:49 PM, zhong jiang wrote: > Fix the following compile warning: > > kernel/sched/core.c: In function ‘update_rq_clock_task’: > kernel/sched/core.c:139:6: warning: unused variable ‘steal’ > [-Wunused-variable] > s64 steal = 0, irq_delta = 0; > Dou (and I,

[PATCH 2/2] Compiler Attributes: naked can be shared

amada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Suggested-by: Arnd Bergmann Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 include/linux/compiler_types.h

[PATCH 1/2] Compiler Attributes: naked was fixed in gcc 4.6

Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linu

[PATCH 2/2] Compiler Attributes: naked can be shared

amada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Suggested-by: Arnd Bergmann Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 include/linux/compiler_types.h

[PATCH 1/2] Compiler Attributes: naked was fixed in gcc 4.6

Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Luc Van Oostenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linu

[PATCH 0/2] Compiler Attributes (naked only, for v4.19)

These two patches are the 5th and 6th of the Compiler Attributes series, which Stefan and Nick requested to go into v4.19 so that the clang ARM32 build is fixed. The v5 of Compiler Attributes will have these two removed if this goes in. Miguel Ojeda (2): Compiler Attributes: naked was fixed

[PATCH 0/2] Compiler Attributes (naked only, for v4.19)

These two patches are the 5th and 6th of the Compiler Attributes series, which Stefan and Nick requested to go into v4.19 so that the clang ARM32 build is fixed. The v5 of Compiler Attributes will have these two removed if this goes in. Miguel Ojeda (2): Compiler Attributes: naked was fixed

Re: [PATCH] include/linux/compiler-clang.h: define __naked

Hi again, On Wed, Sep 12, 2018 at 6:19 AM, Miguel Ojeda wrote: > > I will do a bigger one tomorrow or so and see if there are any > important differences. Regardless of what we do, I will send the > __naked patches separately as well (requested by Nick on GitHub). So I did

Re: [PATCH] include/linux/compiler-clang.h: define __naked

Hi again, On Wed, Sep 12, 2018 at 6:19 AM, Miguel Ojeda wrote: > > I will do a bigger one tomorrow or so and see if there are any > important differences. Regardless of what we do, I will send the > __naked patches separately as well (requested by Nick on GitHub). So I did

Re: [PATCH] include/linux/compiler-clang.h: define __naked

Hi Arnd, Nick, Stefan, On Mon, Sep 10, 2018 at 2:14 PM, Arnd Bergmann wrote: > On Mon, Sep 10, 2018 at 8:05 AM Stefan Agner wrote: >> >> ARM32 arch code uses the __naked attribute. This has previously been >> defined in include/linux/compiler-gcc.h, which is no longer included >> for Clang.

Re: [PATCH] include/linux/compiler-clang.h: define __naked

Hi Arnd, Nick, Stefan, On Mon, Sep 10, 2018 at 2:14 PM, Arnd Bergmann wrote: > On Mon, Sep 10, 2018 at 8:05 AM Stefan Agner wrote: >> >> ARM32 arch code uses the __naked attribute. This has previously been >> defined in include/linux/compiler-gcc.h, which is no longer included >> for Clang.

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

Hi Vincent, On Mon, Sep 10, 2018 at 9:00 AM, Vincent Guittot wrote: > On Sun, 9 Sep 2018 at 19:00, Miguel Ojeda > wrote: >> >> On Sun, Sep 9, 2018 at 6:45 PM, Borislav Petkov wrote: >> > On Sun, Sep 09, 2018 at 06:36:01PM +0200, Miguel Ojeda wrote: >> &

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

Hi Vincent, On Mon, Sep 10, 2018 at 9:00 AM, Vincent Guittot wrote: > On Sun, 9 Sep 2018 at 19:00, Miguel Ojeda > wrote: >> >> On Sun, Sep 9, 2018 at 6:45 PM, Borislav Petkov wrote: >> > On Sun, Sep 09, 2018 at 06:36:01PM +0200, Miguel Ojeda wrote: >> &

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

On Sun, Sep 9, 2018 at 6:45 PM, Borislav Petkov wrote: > On Sun, Sep 09, 2018 at 06:36:01PM +0200, Miguel Ojeda wrote: >> No, you get a different warning depending on whether you have enabled >> CONFIG_PARAVIRT_TIME_ACCOUNTING or CONFIG_IRQ_TIME_ACCOUNTING. > >

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

On Sun, Sep 9, 2018 at 6:45 PM, Borislav Petkov wrote: > On Sun, Sep 09, 2018 at 06:36:01PM +0200, Miguel Ojeda wrote: >> No, you get a different warning depending on whether you have enabled >> CONFIG_PARAVIRT_TIME_ACCOUNTING or CONFIG_IRQ_TIME_ACCOUNTING. > >

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

Hi Borislav, On Sun, Sep 9, 2018 at 6:06 PM, Borislav Petkov wrote: > On Sun, Sep 09, 2018 at 04:48:19PM +0200, Miguel Ojeda wrote: >> Indeed. But note that the attribute needs to be written before the >> variable name so that it applies to both variables (or write it twice) &g

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

Hi Borislav, On Sun, Sep 9, 2018 at 6:06 PM, Borislav Petkov wrote: > On Sun, Sep 09, 2018 at 04:48:19PM +0200, Miguel Ojeda wrote: >> Indeed. But note that the attribute needs to be written before the >> variable name so that it applies to both variables (or write it twice) &g

[PATCH] arch/arm64/include/asm/jump_label.h: use asm_volatile_goto

All other uses of "asm goto" go through asm_volatile_goto (including the arm version of the same file). For consistency, use it here as well. Cc: Nick Desaulniers Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Miguel Ojeda --- arch/arm

[PATCH] arch/arm64/include/asm/jump_label.h: use asm_volatile_goto

All other uses of "asm goto" go through asm_volatile_goto (including the arm version of the same file). For consistency, use it here as well. Cc: Nick Desaulniers Cc: Catalin Marinas Cc: Will Deacon Cc: linux-arm-ker...@lists.infradead.org Signed-off-by: Miguel Ojeda --- arch/arm

Re: [PATCH] include/linux/compiler*.h: add version detection to asm_volatile_goto

equences: > + * GCC < 4.8.2 'asm goto' miscompiles certain code sequences: > * Nice catch. Indeed, it seems broken since 4.5.3 and fixed in every version after 4.8.1 (at least the ones in godbolt). Reviewed-by: Miguel Ojeda By the way, arch/arm64/include/asm/jump_label.h is the only

Re: [PATCH] include/linux/compiler*.h: add version detection to asm_volatile_goto

equences: > + * GCC < 4.8.2 'asm goto' miscompiles certain code sequences: > * Nice catch. Indeed, it seems broken since 4.5.3 and fixed in every version after 4.8.1 (at least the ones in godbolt). Reviewed-by: Miguel Ojeda By the way, arch/arm64/include/asm/jump_label.h is the only

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

On Sun, Sep 9, 2018 at 11:36 AM, Borislav Petkov wrote: > > Alternatively, if you don't want to let the crazy ifdeffery in that > function grow even more, you can simply do: > > --- > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 625bc9897f62..1728743360d4 100644 > ---

Re: [PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

On Sun, Sep 9, 2018 at 11:36 AM, Borislav Petkov wrote: > > Alternatively, if you don't want to let the crazy ifdeffery in that > function grow even more, you can simply do: > > --- > diff --git a/kernel/sched/core.c b/kernel/sched/core.c > index 625bc9897f62..1728743360d4 100644 > ---

[PATCH v4 05/13] Compiler Attributes: naked was fixed in gcc 4.6

rtinet Cc: Nick Desaulniers Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 76

[PATCH v4 10/13] Compiler Attributes: KENTRY used twice the "used" attribute

Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 4030a2940d6b..17ee9165ca51 100644 --- a/include/linux/compiler.h +++ b/include/linux

[PATCH v4 05/13] Compiler Attributes: naked was fixed in gcc 4.6

rtinet Cc: Nick Desaulniers Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 76

[PATCH v4 10/13] Compiler Attributes: KENTRY used twice the "used" attribute

Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 4030a2940d6b..17ee9165ca51 100644 --- a/include/linux/compiler.h +++ b/include/linux

[PATCH v4 04/13] Compiler Attributes: homogenize __must_be_array

Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 1 - include/linux/compiler-gcc.h | 7 --- include/linux/compiler-intel.h | 3 --- include

[PATCH v4 07/13] Compiler Attributes: remove unneeded sparse (__CHECKER__) tests

tenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 6 ++ include/linux/compiler.h | 4 include/linux/compiler_types.h | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/lin

[PATCH v4 03/13] Compiler Attributes: remove unneeded tests

Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler_types.h | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/incl

[PATCH v4 04/13] Compiler Attributes: homogenize __must_be_array

Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 1 - include/linux/compiler-gcc.h | 7 --- include/linux/compiler-intel.h | 3 --- include

[PATCH v4 07/13] Compiler Attributes: remove unneeded sparse (__CHECKER__) tests

tenryck Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 6 ++ include/linux/compiler.h | 4 include/linux/compiler_types.h | 2 +- 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/lin

[PATCH v4 03/13] Compiler Attributes: remove unneeded tests

Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler_types.h | 23 +++ 1 file changed, 3 insertions(+), 20 deletions(-) diff --git a/incl

[PATCH v4 09/13] Compiler Attributes: use feature checks instead of version checks

net Cc: Nick Desaulniers Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Luc Van Oostenryck Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 4 - include/linux/compiler-gcc.h| 51 -- include/linux/compiler-intel.h | 6 - include/li

[PATCH v4 00/13] Compiler Attributes

Cc: linux-spa...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Miguel Ojeda v3 -> v4 This time it is an important fix I found while doing randconfigs, plus the documentation sentence that Nick suggested and the MAINTAINERS file. Compile-tested for a while on (x86_64, g

[PATCH v4 08/13] Compiler Attributes: add missing SPDX ID in compiler_types.h

-spa...@vger.kernel.org Signed-off-by: Miguel Ojeda --- include/linux/compiler_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index a3eceb3ad1b3..ed7c0e4a180e 100644 --- a/include/linux/compiler_types.h +++ b/include/linux

[PATCH v4 13/13] Compiler Attributes: Add MAINTAINERS entry

Cc: Eli Friedman Cc: Christopher Li Cc: Kees Cook Cc: Ingo Molnar Cc: Geert Uytterhoeven Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Nick Desaulniers Cc: Linus Torvalds Signed-off-by: Miguel Ojeda --- MAINTAINERS | 5

[PATCH v4 02/13] Compiler Attributes: always use the extra-underscores syntax

rtinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 2 +- include/linux/compiler-gcc.h | 14 ++-- include/linux/compiler-intel.h | 2 +- include/linux/compiler.h | 8 +++

[PATCH v4 01/13] Compiler Attributes: remove unused attributes

Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 2 -- include/linux/compiler.h | 4 include/linux/compiler_types.h | 1 - 3 files changed, 7

[PATCH v4 12/13] Compiler Attributes: add Doc/process/programming-language.rst

Torvalds Cc: linux-spa...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Miguel Ojeda --- Documentation/process/index.rst | 1 + .../process/programming-language.rst | 45 +++ 2 files changed, 46 insertions(+) create mode 100644 Documentation

[PATCH v4 09/13] Compiler Attributes: use feature checks instead of version checks

net Cc: Nick Desaulniers Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Luc Van Oostenryck Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 4 - include/linux/compiler-gcc.h| 51 -- include/linux/compiler-intel.h | 6 - include/li

[PATCH v4 00/13] Compiler Attributes

Cc: linux-spa...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Miguel Ojeda v3 -> v4 This time it is an important fix I found while doing randconfigs, plus the documentation sentence that Nick suggested and the MAINTAINERS file. Compile-tested for a while on (x86_64, g

[PATCH v4 08/13] Compiler Attributes: add missing SPDX ID in compiler_types.h

-spa...@vger.kernel.org Signed-off-by: Miguel Ojeda --- include/linux/compiler_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/compiler_types.h b/include/linux/compiler_types.h index a3eceb3ad1b3..ed7c0e4a180e 100644 --- a/include/linux/compiler_types.h +++ b/include/linux

[PATCH v4 13/13] Compiler Attributes: Add MAINTAINERS entry

Cc: Eli Friedman Cc: Christopher Li Cc: Kees Cook Cc: Ingo Molnar Cc: Geert Uytterhoeven Cc: Arnd Bergmann Cc: Greg Kroah-Hartman Cc: Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Nick Desaulniers Cc: Linus Torvalds Signed-off-by: Miguel Ojeda --- MAINTAINERS | 5

[PATCH v4 02/13] Compiler Attributes: always use the extra-underscores syntax

rtinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 2 +- include/linux/compiler-gcc.h | 14 ++-- include/linux/compiler-intel.h | 2 +- include/linux/compiler.h | 8 +++

[PATCH v4 01/13] Compiler Attributes: remove unused attributes

Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 2 -- include/linux/compiler.h | 4 include/linux/compiler_types.h | 1 - 3 files changed, 7

[PATCH v4 12/13] Compiler Attributes: add Doc/process/programming-language.rst

Torvalds Cc: linux-spa...@vger.kernel.org Cc: linux-...@vger.kernel.org Signed-off-by: Miguel Ojeda --- Documentation/process/index.rst | 1 + .../process/programming-language.rst | 45 +++ 2 files changed, 46 insertions(+) create mode 100644 Documentation

[PATCH v4 11/13] Compiler Attributes: remove uses of __attribute__ from compiler.h

Suggested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 17ee9165ca51..b5fb034fa6fa 100644

[PATCH v4 06/13] Compiler Attributes: naked can be shared

ted-by: Arnd Bergmann Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 include/linux/compiler_types.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 4cd5e9264bce..3b32bbf

[PATCH v4 11/13] Compiler Attributes: remove uses of __attribute__ from compiler.h

Suggested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 17ee9165ca51..b5fb034fa6fa 100644

[PATCH v4 06/13] Compiler Attributes: naked can be shared

ted-by: Arnd Bergmann Signed-off-by: Miguel Ojeda --- include/linux/compiler-gcc.h | 8 include/linux/compiler_types.h | 8 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h index 4cd5e9264bce..3b32bbf

[PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

-variable] s64 steal = 0, irq_delta = 0; The reason is that CONFIG_SMP guards HAVE_SCHED_AVG_IRQ, which in turn disables the code guarded by HAVE_SCHED_AVG_IRQ. Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Miguel Ojeda --- kernel/sched/core.c | 7 +-- 1 file changed, 5 insertions

[PATCH] kernel/sched/core.c: Avoid unused variable on non-SMP configs

-variable] s64 steal = 0, irq_delta = 0; The reason is that CONFIG_SMP guards HAVE_SCHED_AVG_IRQ, which in turn disables the code guarded by HAVE_SCHED_AVG_IRQ. Cc: Ingo Molnar Cc: Peter Zijlstra Signed-off-by: Miguel Ojeda --- kernel/sched/core.c | 7 +-- 1 file changed, 5 insertions

Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

Hi Jarkko, On Thu, Sep 6, 2018 at 11:21 AM, Jarkko Sakkinen wrote: > There is another open. If I grep through the kernel tree I see SPDX > headers that are decorated both with C99- and C89-style comments. I > guess I ended up using C99-style because when I was instructed to add > SPDX headers in

Re: [PATCH v13 11/13] platform/x86: Intel SGX driver

Hi Jarkko, On Thu, Sep 6, 2018 at 11:21 AM, Jarkko Sakkinen wrote: > There is another open. If I grep through the kernel tree I see SPDX > headers that are decorated both with C99- and C89-style comments. I > guess I ended up using C99-style because when I was instructed to add > SPDX headers in

[PATCH 04/12] Compiler Attributes: homogenize __must_be_array

Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 1 - include/linux/compiler-gcc.h | 7 --- include/linux/compiler-intel.h | 3 --- include

[PATCH 04/12] Compiler Attributes: homogenize __must_be_array

Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler-clang.h | 1 - include/linux/compiler-gcc.h | 7 --- include/linux/compiler-intel.h | 3 --- include

[PATCH 03/12] Compiler Attributes: remove unneeded tests

Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler_types.h | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git

[PATCH 03/12] Compiler Attributes: remove unneeded tests

Masahiro Yamada Cc: Joe Perches Cc: Dominique Martinet Cc: Linus Torvalds Cc: linux-spa...@vger.kernel.org Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler_types.h | 24 +++- 1 file changed, 3 insertions(+), 21 deletions(-) diff --git

[PATCH 11/12] Compiler Attributes: remove uses of __attribute__ from compiler.h

Suggested-by: Nick Desaulniers Reviewed-by: Nick Desaulniers Signed-off-by: Miguel Ojeda --- include/linux/compiler.h | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 17ee9165ca51..b5fb034fa6fa 100644

[PATCH 10/12] Compiler Attributes: KENTRY used twice the "used" attribute

-spa...@vger.kernel.org Signed-off-by: Miguel Ojeda --- include/linux/compiler.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/compiler.h b/include/linux/compiler.h index 4030a2940d6b..17ee9165ca51 100644 --- a/include/linux/compiler.h +++ b/include/linux

<    1   2   3   4   5   6   7   8   9   10   >