[PATCH] MAINTAINERS: Add Mihail to Komeda DRM driver

2019-10-21 Thread Mihail Atanassov
I'll be the main point of contact. Cc: James Qian Wang (Arm Technology China) Cc: Liviu Dudau Signed-off-by: Mihail Atanassov --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 94fb077c0817..d32f263f0022 100644 --- a/MAINTAINERS +++ b

Re: drm/komeda: Dump SC_ENH_* registers from scaler block

2019-10-21 Thread Mihail Atanassov
On Wednesday, 16 October 2019 09:17:39 BST james qian wang (Arm Technology China) wrote: > On Tue, Oct 15, 2019 at 11:00:01AM +0000, Mihail Atanassov wrote: > > Signed-off-by: Mihail Atanassov > > --- > > .../gpu/drm/arm/display/komeda/d71/d71_component.c | 14 +

Re: [PATCH v2 1/4] drm: Add a new helper drm_color_ctm_s31_32_to_qm_n()

2019-10-11 Thread Mihail Atanassov
Hi James, On Friday, 11 October 2019 06:45:27 BST james qian wang (Arm Technology China) wrote: > Add a new helper function drm_color_ctm_s31_32_to_qm_n() for driver to > convert S31.32 sign-magnitude to Qm.n 2's complement that supported by > hardware. > > Signed-off-by: james qian wang (Arm

Re: [PATCH] drm/komeda: Reordered the komeda's de-init functions

2019-08-23 Thread Mihail Atanassov
v->funcs->disable_irq(mdev); > - drm_dev_unregister(drm); > component_unbind_all(mdev->dev, drm); > - komeda_kms_cleanup_private_objs(kms); > drm_mode_config_cleanup(drm); > + komeda_kms_cleanup_private_objs(kms); > drm->dev_private = NULL; > drm_dev_put(drm); > } > Thanks. See my include order comment above, with that fixed: Reviewed-by: Mihail Atanassov -- Mihail

[PATCH] drm/komeda: Add missing of_node_get() call

2019-08-20 Thread Mihail Atanassov
komeda_pipeline_destroy has the matching of_node_put(). Fixes: 29e56aec911dd ("drm/komeda: Add DT parsing") Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/arm/disp

Re: [PATCH] drm/komeda: Adds error event print functionality

2019-08-02 Thread Mihail Atanassov
1. Refine komeda_sprintf(); > 2. Not using STR_SZ macro for the string size in komeda_print_events(). > > Changes since v1: > 1. Handling the event print by CONFIG_KOMEDA_ERROR_PRINT; > 2. Changing the max string size to 256. > > Signed-off-by: Lowry Li (Arm Technology

[PATCH] drm: mali-dp: add atomic_print_state for planes

2017-02-13 Thread Mihail Atanassov
Print all the extra fields of malidp_plane_state. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_planes.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c

[PATCH] drm: mali-dp: add atomic_print_state for planes

2017-02-13 Thread Mihail Atanassov
Print all the extra fields of malidp_plane_state. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_planes.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 414aada..3879dc5 100644

[PATCH v2] drm: mali-dp: Add CTM support

2017-02-13 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- Link to v1: https://lkml.org/lkml/20

[PATCH v2] drm: mali-dp: Add CTM support

2017-02-13 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov --- Link to v1: https://lkml.org/lkml/2017/2/1/254 Changes since v1

[RFC] drm: Helper macro for drm state duplication

2017-02-09 Thread Mihail Atanassov
red this also applies to the other drm_*_state derivatives, so I concocted a macro helper to do the copy in one chunk (two if you count the __drm_atomic_helper* one). I'd appreciate some comments on whether anyone else might find this macro useful. Thanks! Mihail Atanassov (1): drm: Add helper ma

[RFC] drm: Helper macro for drm state duplication

2017-02-09 Thread Mihail Atanassov
red this also applies to the other drm_*_state derivatives, so I concocted a macro helper to do the copy in one chunk (two if you count the __drm_atomic_helper* one). I'd appreciate some comments on whether anyone else might find this macro useful. Thanks! Mihail Atanassov (1): drm: Add helper ma

[PATCH] drm: Add helper macro for duplicating custom drm_*_state

2017-02-09 Thread Mihail Atanassov
ple) is not first in the derived struct, to avoid missing any data before it and corrupting the base's data. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- include/drm/drm_atomic_helper.h | 33 + 1 file changed, 33 insertions(+) diff --git a/in

[PATCH] drm: Add helper macro for duplicating custom drm_*_state

2017-02-09 Thread Mihail Atanassov
ple) is not first in the derived struct, to avoid missing any data before it and corrupting the base's data. Signed-off-by: Mihail Atanassov --- include/drm/drm_atomic_helper.h | 33 + 1 file changed, 33 insertions(+) diff --git a/include/drm/drm_atomic_helper.

[PATCH v3 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-07 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> Acked-by: Liviu Dudau <liviu.du...@ar

[PATCH v3 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-07 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov Reviewed-by: Brian Starkey Acked-by: Liviu Dudau --- Link to v2: https://lkml.org/lkml/2017/2/1/378 Link to v1: https://lkml.org

[PATCH v3 2/2] drm: mali-dp: enable gamma support

2017-02-07 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> Acked-by: Liviu Dudau <liviu.du...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 130 +

[PATCH v3 2/2] drm: mali-dp: enable gamma support

2017-02-07 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov Reviewed-by: Brian Starkey Acked-by: Liviu Dudau --- drivers/gpu/drm/arm/malidp_crtc.c | 130 -- drivers/gpu/drm/arm/malidp_drv.c | 52 +++ drivers/gpu/drm/arm

[PATCH v2 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> --- Link to v1: https://lkml.org/lkml/

[PATCH v2 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov Reviewed-by: Brian Starkey --- Link to v1: https://lkml.org/lkml/2017/2/1/203 Changes since v1: - Moved unused variable to patch

[PATCH v2 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> Reviewed-by: Brian Starkey <brian.star...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 132 -- drivers/gpu/drm/arm/malidp_

[PATCH v2 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov Reviewed-by: Brian Starkey --- drivers/gpu/drm/arm/malidp_crtc.c | 132 -- drivers/gpu/drm/arm/malidp_drv.c | 52 +++ drivers/gpu/drm/arm/malidp_drv.h | 1

[PATCH] drm: mali-dp: Add CTM support

2017-02-01 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- This patch depends on "[PATCH 2/2

[PATCH] drm: mali-dp: Add CTM support

2017-02-01 Thread Mihail Atanassov
All DPs have a COLORADJ matrix which is applied prior to output gamma. Attach that to the CTM property. Also, ensure the input CTM's coefficients can fit in the DP registers' Q3.12 format. Signed-off-by: Mihail Atanassov --- This patch depends on "[PATCH 2/2] drm: mali-dp: enable gamma su

[PATCH 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 39 +-- drivers/gpu/d

[PATCH 1/2] drm: mali-dp: add malidp_crtc_state struct

2017-02-01 Thread Mihail Atanassov
Add a custom CRTC state struct to enable storing driver-private per-CRTC state. This patch only adds the base drm_crtc_state struct. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_crtc.c | 39 +-- drivers/gpu/drm/arm/malidp_drv.h | 6

[PATCH 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_crtc.c | 130 -- drivers/gpu/drm/arm/malidp_drv.c | 52 +++ drivers/gpu/drm/arm/malidp_drv.h

[PATCH 2/2] drm: mali-dp: enable gamma support

2017-02-01 Thread Mihail Atanassov
table of coefficients for all 3 curves on DP500. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_crtc.c | 130 -- drivers/gpu/drm/arm/malidp_drv.c | 52 +++ drivers/gpu/drm/arm/malidp_drv.h | 1 + drivers/gpu/drm/arm/malidp_hw.c

[PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Mihail Atanassov
The reset hook needs to allocate space for a malidp_plane_state, which is larger than drm_plane_state. Otherwise, the hook is identical to the default one. Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_planes.c | 23 ++-

[PATCH] drm: mali-dp: add custom plane ->reset hook

2017-01-30 Thread Mihail Atanassov
The reset hook needs to allocate space for a malidp_plane_state, which is larger than drm_plane_state. Otherwise, the hook is identical to the default one. Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_planes.c | 23 ++- 1 file changed, 22 insertions(+), 1

[PATCH 1/2] drm: mali-dp: Check hw version matches device-tree

2017-01-23 Thread Mihail Atanassov
Refuse to bind if the device-tree compatible string lists a different hardware version. Reviewed-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- A couple of small improvements to driver-to-hardware binding. drivers

[PATCH 1/2] drm: mali-dp: Check hw version matches device-tree

2017-01-23 Thread Mihail Atanassov
Refuse to bind if the device-tree compatible string lists a different hardware version. Reviewed-by: Brian Starkey Signed-off-by: Mihail Atanassov --- A couple of small improvements to driver-to-hardware binding. drivers/gpu/drm/arm/malidp_drv.c | 52

[PATCH 2/2] drm: mali-dp: Check for sufficient address space

2017-01-23 Thread Mihail Atanassov
If the device-tree 'reg' node doesn't reserve enough space for the DP, fail to bind. Reviewed-by: Brian Starkey <brian.star...@arm.com> Signed-off-by: Mihail Atanassov <mihail.atanas...@arm.com> --- drivers/gpu/drm/arm/malidp_drv.c | 20 drivers/gpu/drm/arm/m

[PATCH 2/2] drm: mali-dp: Check for sufficient address space

2017-01-23 Thread Mihail Atanassov
If the device-tree 'reg' node doesn't reserve enough space for the DP, fail to bind. Reviewed-by: Brian Starkey Signed-off-by: Mihail Atanassov --- drivers/gpu/drm/arm/malidp_drv.c | 20 drivers/gpu/drm/arm/malidp_regs.h | 2 ++ 2 files changed, 22 insertions(+) diff