Re: [PATCH v3] media: pvrusb2: fix parsing error

2020-08-20 Thread Mike Isely
Acked-by: Mike Isely On Thu, 20 Aug 2020, Tong Zhang wrote: > pvr2_std_str_to_id() returns 0 on failure and 1 on success, > however the caller is checking failure case using <0 > > Co-developed-by: Hans Verkuil > Signed-off-by: Tong Zhang > --- > > v2: return -

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-25 Thread Mike Isely
PM, Kees Cook wrote: > > In preparation for unconditionally passing the struct timer_list pointer to > > all timer callbacks, switch to using the new timer_setup() and from_timer() > > to pass the timer pointer explicitly. > > > > Cc: Mike Isely > > Cc: Mauro Ca

Re: [PATCH] media: pvrusb2: Convert timers to use timer_setup()

2017-10-25 Thread Mike Isely
Acked-By: Mike Isely On Tue, 24 Oct 2017, Kees Cook wrote: > In preparation for unconditionally passing the struct timer_list pointer to > all timer callbacks, switch to using the new timer_setup() and from_timer() > to pass the timer pointer explicitly. > > Cc: Mike Ise

Re: usb/media/pvrusb2: warning in pvr2_send_request_ex/usb_submit_urb

2017-09-20 Thread Mike Isely
118 > pvr2_context_thread_func+0x361/0x8c0 > drivers/media/usb/pvrusb2/pvrusb2-context.c:167 > kthread+0x3a1/0x470 kernel/kthread.c:231 > ret_from_fork+0x2a/0x40 arch/x86/entry/entry_64.S:431 > Code: 48 8b 85 30 ff ff ff 48 8d b8 98 00 00 00 e8 ee 82 89 fe 45 89 > e8 44 89 f1 4c

Re: [PATCH v2 5/6] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-10-29 Thread Mike Isely
rol infrastructure. > Add support for the new field which on structure > v4l2_ext_controls > > Acked-by: Mike Isely > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/media/usb/pvrusb2/pvrusb2-v4l2.c | 16 ++-- > 1 file changed, 14 insertions(+), 2 deletions(-) >

Re: [PATCH v2 07/10] media/usb/pvrusb2: Support for V4L2_CTRL_WHICH_DEF_VAL

2015-08-21 Thread Mike Isely
down to choosing between pvr2_ctrl_get_value() vs pvr2_ctrl_get_def(). It's not a correctness comment; what you have should work fine. So I'm ack'ing this in any case: Acked-By: Mike Isely But you can do the above pretty easily & safely, and simplify it a bit further.

Re: [PATCH 065/193] drivers/media/video/pvrusb2: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Mike Isely
I never liked that designation in the first place, so no argument here... Acked-By: Mike Isely On Tue, 23 Oct 2012, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summi

Re: [PATCH] pvrusb2: Declare MODULE_FIRMWARE usage

2012-07-26 Thread Mike Isely
Acked-By: Mike Isely -Mike On Thu, 26 Jul 2012, Tim Gardner wrote: > Cc: Mike Isely > Cc: Mauro Carvalho Chehab > Cc: linux-me...@vger.kernel.org > Signed-off-by: Tim Gardner > --- > drivers/media/video/pvrusb2/pvrusb2-devattr.c | 17 - > 1 file c

Re: [PATCH] [393/2many] MAINTAINERS - PVRUSB2 VIDEO4LINUX DRIVER

2007-08-13 Thread Mike Isely
Signed-off-by: Mike Isely <[EMAIL PROTECTED]> On Sun, 12 Aug 2007, [EMAIL PROTECTED] wrote: > Add file pattern to MAINTAINER entry > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> > > diff --git a/MAINTAINERS b/MAINTAINERS > index 62b6ede..3889034 1006

Re: [PATCH 4/5] pvrusb2: use mutex instead of semaphore

2007-04-27 Thread Mike Isely
Whoops. A straggler. Signed-off-by: Mike Isely <[EMAIL PROTECTED]> On Fri, 27 Apr 2007, Matthias Kaehlcke wrote: > the pvrusb2 driver use a semaphore as mutex. use the mutex API instead > of the (binary) semaphore > > Signed-off-by: Matthias Kaehlcke <[EMAIL PROTECTED]&

Re: [PATCH 2.6.20] pvrusb2: use ARRAY_SIZE macro when appropriate (2)

2007-02-05 Thread Mike Isely
initial patch a while back I then combed through the entire pvrusb2 driver and cleaned up all the other cases. Those patches should already be on a trajectory for 2.6.21. I'll check it against this patch but I think these should already all be handled. -Mike --

Re: [PATCH 2.6.20-rc5 2/4] pvrusb2: Use ARRAY_SIZE macro

2007-01-18 Thread Mike Isely
propriate. > > Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> > --- Ahmed: I've pulled your patch into my driver source and will propagate it up appropriately as part of the next batch of pvrusb2 changes to come out of the v4l-dvb repository. -M

Re: [PATCH] video: pvrusb2-hdw kfree cleanup

2007-01-02 Thread Mike Isely
ed-off-by: Mariusz Kozlowski <[EMAIL PROTECTED]> > > Signed-off-by: Mike Isely <[EMAIL PROTECTED]> -Mike -- | Mike Isely | PGP fingerprint Spammers Die!! | | 03 54 43 4D 75 E5 CC 92