Re: [PATCH] scsi: core: Log SCSI command age with errors

2019-09-30 Thread Milan P. Gandhi
On 9/30/19 2:12 PM, Martin Wilck wrote: > On Fri, 2019-09-27 at 13:45 -0400, Laurence Oberman wrote: >> >> Hi Martin >> >> Agreed about log extraction, but turning that on with a busy workload >> in a production environment is not practical. We cant do it with >> systems with 1000's of luns and

[PATCH v2] scsi: core: Log SCSI command age with errors

2019-09-25 Thread Milan P. Gandhi
Couple of users had requested to print the SCSI command age along with command failure errors. This is a small change, but allows users to get more important information about the command that was failed, it would help the users in debugging the command failures: Signed-off-by: Milan P. Gandhi

Re: [PATCH] scsi: core: Log SCSI command age with errors

2019-09-25 Thread Milan P. Gandhi
On 9/25/19 9:15 PM, Bart Van Assche wrote: > On 9/22/19 11:01 PM, Milan P. Gandhi wrote: >> +    off += scnprintf(logbuf + off, logbuf_len - off, >> + "cmd-age=%lus", cmd_age); > > Have you considered to change cmd-age into cmd_age? I'm afraid other

Re: [PATCH] scsi: core: Log SCSI command age with errors

2019-09-23 Thread Milan P. Gandhi
On 9/23/19 6:32 PM, Laurence Oberman wrote: > On Mon, 2019-09-23 at 11:31 +0530, Milan P. Gandhi wrote: >> Couple of users had requested to print the SCSI command age along >> with command failure errors. This is a small change, but allows >> users to get more import

[PATCH] scsi: core: Log SCSI command age with errors

2019-09-23 Thread Milan P. Gandhi
Couple of users had requested to print the SCSI command age along with command failure errors. This is a small change, but allows users to get more important information about the command that was failed, it would help the users in debugging the command failures: Signed-off-by: Milan P. Gandhi