[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in init_task.h

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- init_task.h |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/init_task.h b/include/linux/init_task.h index a2d95ff..7951023

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/atm, net

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- drivers/atm/atmtcp.c |2 +- net/atm/clip.c |2 +- net/atm/lec.c|2 +- net/atm/mpc.c|2 +- net/atm/signaling.c |2 +- ne

[KJ][PATCH] sound: SPIN_LOCK_UNLOCKED cleanup

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- soc/at91/at91-i2s.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/at91/at91-i2s.c b/sound/soc/at91/at91-i2s.c

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/char/keyboard

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- keyboard.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c index cb8d691..df9bfc1

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/serial

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- cpm_uart/cpm_uart_core.c | 12 ++-- s3c2410.c|6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/serial/cp

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/mips

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- excite_setup.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/basler/excite/excite_setup.c b/arch/mips/basler/excite/excite_setup.c

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/mips

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- excite_setup.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/mips/basler/excite/excite_setup.c b/arch/mips/basler/excite/excite_setup.c index 42f0eda

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/serial

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- cpm_uart/cpm_uart_core.c | 12 ++-- s3c2410.c|6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/serial/cpm_uart

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/char/keyboard

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- keyboard.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/keyboard.c b/drivers/char/keyboard.c index cb8d691..df9bfc1 100644

[KJ][PATCH] sound: SPIN_LOCK_UNLOCKED cleanup

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- soc/at91/at91-i2s.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/at91/at91-i2s.c b/sound/soc/at91/at91-i2s.c index 9fc0c03

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/atm, net

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- drivers/atm/atmtcp.c |2 +- net/atm/clip.c |2 +- net/atm/lec.c|2 +- net/atm/mpc.c|2 +- net/atm/signaling.c |2 +- net/dccp

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in init_task.h

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- init_task.h |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/init_task.h b/include/linux/init_task.h index a2d95ff..7951023 100644

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/s390

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- char/vmlogrdr.c |6 +++--- cio/cmf.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s39

[KJ][PATCH] i2c: SPIN_LOCK_UNLOCKED cleanup

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- i2c-pxa.c |2 +- i2c-s3c2410.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/m68k

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- amiga/amiints.c |2 +- amiga/cia.c |4 ++-- apollo/dn_ints.c |2 +- atari/ataints.c |2 +- kernel/ints.c|4 ++-- mac/macints.c

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/m68k

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- amiga/amiints.c |2 +- amiga/cia.c |4 ++-- apollo/dn_ints.c |2 +- atari/ataints.c |2 +- kernel/ints.c|4 ++-- mac/macints.c|2 +- q40

[KJ][PATCH] i2c: SPIN_LOCK_UNLOCKED cleanup

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- i2c-pxa.c |2 +- i2c-s3c2410.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/i2c/busses/i2c-pxa.c b/drivers/i2c/busses/i2c-pxa.c

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in drivers/s390

SPIN_LOCK_UNLOCKED cleanup,use __SPIN_LOCK_UNLOCKED instead. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- char/vmlogrdr.c |6 +++--- cio/cmf.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/s390/char/vmlogrdr.c b/drivers/s390/char

Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore

; > > (note the space between the 'if' and the '(', and no braces used) > ok.. got it.. -- Milind Arun Choudhary - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[KJ]use mutex instead of a binary semaphore

mounts happen on bdev in between freeze_bdev and thaw_bdev(). so locking is done in freeze_bdev & unlocking in thaw_bdev these can be from different context i guess.. is my understandig correct.. CMIIW.. would appreciate some pointers on how to identify such cases.. -- Milind Arun Choud

[KJ][PATCH]Rocket port:use mutex instead of binary semaphore

Use mutex instead of binary semaphore for mutual exclusion. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- rocket.c | 22 -- rocket_int.h |2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/char/rocket.c b/driver

[KJ][PATCH]Rocket port:use mutex instead of binary semaphore

Use mutex instead of binary semaphore for mutual exclusion. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- rocket.c | 22 -- rocket_int.h |2 +- 2 files changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/char/rocket.c b/drivers/char

[KJ]use mutex instead of a binary semaphore

mounts happen on bdev in between freeze_bdev and thaw_bdev(). so locking is done in freeze_bdev unlocking in thaw_bdev these can be from different context i guess.. is my understandig correct.. CMIIW.. would appreciate some pointers on how to identify such cases.. -- Milind Arun Choudhary

Re: [KJ][PATCH]Rocket port:use mutex instead of binary semaphore

it.. -- Milind Arun Choudhary - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[KJ][PATCH]SPIN_LOCK_UNLOCKED macro cleanup in arch/ia64

SPIN_LOCK_UNLOCKED macro cleanup, use __SPIN_LOCK_UNLOCKED instead. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- kernel/traps.c |6 +++--- kernel/unwind.c |2 +- mm/tlb.c|6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arc

[KJ][PATCH]SPIN_LOCK_UNLOCKED macro cleanup in arch/ia64

SPIN_LOCK_UNLOCKED macro cleanup, use __SPIN_LOCK_UNLOCKED instead. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- kernel/traps.c |6 +++--- kernel/unwind.c |2 +- mm/tlb.c|6 +++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/arch/ia64/kernel

Re: [KJ][PATCH 03/04]use set_current_state in fs

On 11:39 Sat 14 Apr , Eric Dumazet wrote: > Milind Arun Choudhary a écrit : > >use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs > Probably a dumb question, so please forgive me. no. you have a valid point My bad :( I should probably be enjoying my w

[KJ][PATCH 03/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/nfs Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- idmap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 9d4a6b2..054ca15 100644

[KJ][PATCH 04/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/reiserfs Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- journal.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index 7280a23

[KJ][PATCH 02/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/ocfs2 Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- dlmthread.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c inde

[KJ][PATCH 01/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current->state = TASK_*, in fs/jfs Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- jfs_lock.h |2 +- jfs_logmgr.c |4 ++-- jfs_txnmgr.c |6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git

[KJ][PATCH]use set_current_state in drivers/char

use set_current_state(TASK_*) instead of current->state = TASK_*, Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- amiserial.c |4 ++-- cyclades.c |4 ++-- epca.c |2 +- genrtc.c|2 +- mxser.c |2 +- mxser_new.c |2 +- n_r3964.c

[KJ][PATCH]use set_current_state in drivers/char

use set_current_state(TASK_*) instead of current-state = TASK_*, Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- amiserial.c |4 ++-- cyclades.c |4 ++-- epca.c |2 +- genrtc.c|2 +- mxser.c |2 +- mxser_new.c |2 +- n_r3964.c |4

[KJ][PATCH 01/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current-state = TASK_*, in fs/jfs Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- jfs_lock.h |2 +- jfs_logmgr.c |4 ++-- jfs_txnmgr.c |6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/fs/jfs/jfs_lock.h

[KJ][PATCH 02/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current-state = TASK_*, in fs/ocfs2 Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- dlmthread.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ocfs2/dlm/dlmthread.c b/fs/ocfs2/dlm/dlmthread.c index 2b264c6

[KJ][PATCH 03/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current-state = TASK_*, in fs/nfs Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- idmap.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/nfs/idmap.c b/fs/nfs/idmap.c index 9d4a6b2..054ca15 100644 --- a/fs/nfs

[KJ][PATCH 04/04]use set_current_state in fs

use set_current_state(TASK_*) instead of current-state = TASK_*, in fs/reiserfs Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- journal.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/reiserfs/journal.c b/fs/reiserfs/journal.c index 7280a23..864b15a

Re: [KJ][PATCH 03/04]use set_current_state in fs

On 11:39 Sat 14 Apr , Eric Dumazet wrote: Milind Arun Choudhary a écrit : use set_current_state(TASK_*) instead of current-state = TASK_*, in fs/nfs Probably a dumb question, so please forgive me. no. you have a valid point My bad :( I should probably be enjoying my weekend outdoors

Re: [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

On 14:13 Thu 12 Apr , Luck, Tony wrote: > On Fri, Apr 13, 2007 at 02:01:40AM +0530, Milind Arun Choudhary wrote: > > - size = ROUNDUP(size, iovp_size); > > + size = ALIGN(size, iovp_size); > > Why is "ALIGN" better than "ROUNDUP"? I can't see any

[KJ][PATCH 03/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

ROUND_UP macro cleanup in arch/x86_64 ALIGN, ALIGN_DOWN where ever appropriate. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- arch/x86_64/kernel/e820.c | 16 arch/x86_64/kernel/signal.c |4 ++-- arch/x86_64/mm/init.c |8 arch/x86

[KJ][PATCH 01/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

Add ALIGN_DOWN and round_down macros to kernel.h Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- kernel.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 9ddf25c..f8648b2 100644 --- a/include

[KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

ROUND_UP|DOWN macro cleanup in arch/ia64, use ALIGN ALIGN_DOWN and round_down where ever appropriate. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- arch/ia64/hp/common/sba_iommu.c |8 +++- arch/ia64/ia32/sys_ia32.c|4 +--- arch/ia64/kernel

[KJ][PATCH]ROUND_UP macro cleanup in arch/sparc,sparc64

ROUND_UP macro cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- sparc/kernel/sys_sunos.c |5 ++--- sparc64/kernel/sys_sunos32.c |5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/sparc/kernel/sys_sunos.c b/arch/sparc/

[KJ][PATCH]ROUND_UP macro cleanup in arch/sparc,sparc64

ROUND_UP macro cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- sparc/kernel/sys_sunos.c |5 ++--- sparc64/kernel/sys_sunos32.c |5 ++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/arch/sparc/kernel/sys_sunos.c b/arch/sparc/kernel

[KJ][PATCH 01/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

Add ALIGN_DOWN and round_down macros to kernel.h Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- kernel.h |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/linux/kernel.h b/include/linux/kernel.h index 9ddf25c..f8648b2 100644 --- a/include/linux

[KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

ROUND_UP|DOWN macro cleanup in arch/ia64, use ALIGN ALIGN_DOWN and round_down where ever appropriate. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- arch/ia64/hp/common/sba_iommu.c |8 +++- arch/ia64/ia32/sys_ia32.c|4 +--- arch/ia64/kernel/efi.c

[KJ][PATCH 03/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

ROUND_UP macro cleanup in arch/x86_64 ALIGN, ALIGN_DOWN where ever appropriate. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- arch/x86_64/kernel/e820.c | 16 arch/x86_64/kernel/signal.c |4 ++-- arch/x86_64/mm/init.c |8 arch/x86_64/mm

Re: [KJ][PATCH 02/03]ROUND_UP|DOWN macro cleanup in arch/ia64,x86_64

On 14:13 Thu 12 Apr , Luck, Tony wrote: On Fri, Apr 13, 2007 at 02:01:40AM +0530, Milind Arun Choudhary wrote: - size = ROUNDUP(size, iovp_size); + size = ALIGN(size, iovp_size); Why is ALIGN better than ROUNDUP? I can't see any point to this change. Its a janitorial work. I'm

[KJ][PATCH] ROUND_UP macro cleanup in arch/sh64/kernel/pci_sh5.c

ROUND_UP macro cleanup, use ALIGN where ever appropriate. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- pci_sh5.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/sh64/kernel/pci_sh5.c b/arch/sh64/kernel/pci_sh5.c index 9dae689..1

[KJ][RFC][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/arm

arm/kernel/time.c +++ b/arch/arm/kernel/time.c @@ -510,7 +510,7 @@ void __init time_init(void) #ifdef CONFIG_NO_IDLE_HZ if (system_timer->dyn_tick) - system_timer->dyn_tick->lock = SPIN_LOCK_UNLOCKED; + spin_lock_init(_timer->dyn_tick->lock); #e

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/powerpc

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK or __SPIN_LOCK_UNLOCKED where ever appropriate. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> -- kernel/irq.c |2 +- kernel/rtas.c |2 +- oprofile/op_model_cell.c |2 +- platforms/cell/spu_

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- ieee1394_transactions.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ieee1394/ieee1394_transactions.c b/drivers/ie

[KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c

remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- pata_winbond.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c index 6c11103..cfcd2a5

[KJ][PATCH] SPIN_LOCK_UNLOCKED cleanup in drivers/ata/pata_winbond.c

remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- pata_winbond.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c index 6c11103..cfcd2a5 100644

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK instead Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- ieee1394_transactions.c |2 +- 1 files changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ieee1394/ieee1394_transactions.c b/drivers/ieee1394/ieee1394_transactions.c

[KJ][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/powerpc

SPIN_LOCK_UNLOCKED cleanup,use DEFINE_SPINLOCK or __SPIN_LOCK_UNLOCKED where ever appropriate. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] -- kernel/irq.c |2 +- kernel/rtas.c |2 +- oprofile/op_model_cell.c |2 +- platforms/cell/spu_base.c

[KJ][RFC][PATCH]SPIN_LOCK_UNLOCKED cleanup in arch/arm

/time.c +++ b/arch/arm/kernel/time.c @@ -510,7 +510,7 @@ void __init time_init(void) #ifdef CONFIG_NO_IDLE_HZ if (system_timer-dyn_tick) - system_timer-dyn_tick-lock = SPIN_LOCK_UNLOCKED; + spin_lock_init(system_timer-dyn_tick-lock); #endif } -- Milind Arun

[KJ][PATCH] ROUND_UP macro cleanup in arch/sh64/kernel/pci_sh5.c

ROUND_UP macro cleanup, use ALIGN where ever appropriate. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- pci_sh5.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/arch/sh64/kernel/pci_sh5.c b/arch/sh64/kernel/pci_sh5.c index 9dae689..11d1fef

Re: [KJ] remove SPIN_LOCK_UNLOCKED

mic_locks[] = { [0 ... LOCK_COUNT - 1] = __RAW_SPIN_LOCK_UNLOCKED}; my question is still there in the original post about spin_lock_init() CMIIW Refer: http://lkml.org/lkml/2005/6/20/47 http://lkml.org/lkml/2007/1/16/90 http://lists.openwall.net/linux-kernel/2007/02/01/258 -- Milind Arun Choudhary - To unsu

[KJ]remove SPIN_LOCK_UNLOCKED

rpc->rpd = dev; INIT_WORK(>dpc_handler, aer_isr); -- Milind Arun Choudhary - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[KJ]remove SPIN_LOCK_UNLOCKED

; INIT_WORK(rpc-dpc_handler, aer_isr); -- Milind Arun Choudhary - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [KJ] remove SPIN_LOCK_UNLOCKED

}; my question is still there in the original post about spin_lock_init() CMIIW Refer: http://lkml.org/lkml/2005/6/20/47 http://lkml.org/lkml/2007/1/16/90 http://lists.openwall.net/linux-kernel/2007/02/01/258 -- Milind Arun Choudhary - To unsubscribe from this list: send the line unsubscribe

[KJ][RFC]NAME_OFFSET macro

ame) though ..the first one seem to be just fine thoughts -- Milind Arun Choudhary - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[KJ][RFC]NAME_OFFSET macro

Arun Choudhary - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[KJ][PATCH]ROUND_UP macro cleanup in fs/smbfs/request.c

ROUND_UP macro cleanup use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- request.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/smbfs/request.c b/fs/smbfs/request.c index 723f7c6..c288fbe 100644 --- a/fs/smbfs/request.c +++ b/fs

[KJ][PATCH]ROUND_UP macro cleanup in fs/(select|compat|readdir).c

ROUND_UP macro cleanup use,ALIGN or DIV_ROUND_UP where ever appropriate. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- compat.c | 20 readdir.c |8 +++- select.c |8 3 files changed, 15 insertions(+), 21 deletions(-) diff --gi

[KJ][PATCH]ROUND_UP macro cleanup in arch/alpha/kernel/osf_sys.c

ROUND_UP macro cleanup use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- osf_sys.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff --git a/arch/alpha/kernel/osf_sys.c b/arch/alpha/kernel/osf_sys.c index be133f1..c77d231 100644 --- a/arch/alpha/

[KJ][PATCH]ROUND_UP macro cleanup in fs/(select|compat|readdir).c

ROUND_UP macro cleanup use,ALIGN or DIV_ROUND_UP where ever appropriate. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- compat.c | 20 readdir.c |8 +++- select.c |8 3 files changed, 15 insertions(+), 21 deletions(-) diff --git a/fs

[KJ][PATCH]ROUND_UP macro cleanup in fs/smbfs/request.c

ROUND_UP macro cleanup use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- request.c |7 +++ 1 files changed, 3 insertions(+), 4 deletions(-) diff --git a/fs/smbfs/request.c b/fs/smbfs/request.c index 723f7c6..c288fbe 100644 --- a/fs/smbfs/request.c +++ b/fs/smbfs

[KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c

ROUND_UP macro cleanup use DIV_ROUND_UP Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- ppp_generic.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index ef58e41..4b302f3 100644 --- a/drive

[KJ][PATCH]ROUND_UP macro cleanup in drivers/char/lp.c

ROUND_UP macro cleanup use DIV_ROUND_UP Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- lp.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/char/lp.c b/drivers/char/lp.c index b51d08b..c086910 100644 --- a/drivers/char/lp.c +++ b/driver

[KJ][PATCH]Unused ROUND_UP, NAME_OFFSET macro in arch/powerpc

Unused ROUND_UP, NAME_OFFSET macro cleanup Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- sys_ppc32.c |4 1 files changed, 4 deletions(-) diff --git a/arch/powerpc/kernel/sys_ppc32.c b/arch/powerpc/kernel/sys_ppc32.c index 673e8d9..047246a 100644 --- a/arch/p

[KJ][PATCH]Unused ROUND_UP, NAME_OFFSET macro in arch/powerpc

Unused ROUND_UP, NAME_OFFSET macro cleanup Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- sys_ppc32.c |4 1 files changed, 4 deletions(-) diff --git a/arch/powerpc/kernel/sys_ppc32.c b/arch/powerpc/kernel/sys_ppc32.c index 673e8d9..047246a 100644 --- a/arch/powerpc

[KJ][PATCH]ROUND_UP macro cleanup in drivers/char/lp.c

ROUND_UP macro cleanup use DIV_ROUND_UP Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- lp.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/char/lp.c b/drivers/char/lp.c index b51d08b..c086910 100644 --- a/drivers/char/lp.c +++ b/drivers/char

[KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ppp_generic.c

ROUND_UP macro cleanup use DIV_ROUND_UP Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- ppp_generic.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/ppp_generic.c b/drivers/net/ppp_generic.c index ef58e41..4b302f3 100644 --- a/drivers/net

[KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ixgb

IXGB_ROUNDUP macro cleanup ,use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- ixgb.h |3 --- ixgb_ethtool.c |4 ++-- ixgb_main.c|4 ++-- ixgb_param.c |4 ++-- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/ne

[KJ][PATCH]ROUND_UP macro cleanup in drivers/net/ixgb

IXGB_ROUNDUP macro cleanup ,use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- ixgb.h |3 --- ixgb_ethtool.c |4 ++-- ixgb_main.c|4 ++-- ixgb_param.c |4 ++-- 4 files changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/ixgb/ixgb.h

[KJ][PATCH] ROUND_UP macro cleanup in drivers/net/e1000

E1000_ROUNDUP macro cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- e1000.h |3 --- e1000_ethtool.c |6 +++--- e1000_main.c| 10 +- e1000_param.c |4 ++-- 4 files changed, 10 insertions(+), 13 deletions(-) diff

[KJ][PATCH] ROUND_UP cleanup in arch/mips/kernel/sysirix.c

ROUND_UP(32|64) cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- sysirix.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/mips/kernel/sysirix.c b/arch/mips/kernel/sysirix.c index 93a1484..59c25bc 100644 --- a/arch/mips/

[KJ][PATCH] ROUND_UP macro cleanup in drivers/pci

ROUND_UP macro cleanup, use ALIGN where ever appropriate Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- hotplug/cpci_hotplug_pci.c |2 -- setup-bus.c|8 +++- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/pci/h

[KJ][PATCH] ROUND_UP macro cleanup in arch/parisc

ROUND_UP macro cleanup, use ALIGN where ever appropriate Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- hpux/fs.c |5 ++--- kernel/sys_parisc32.c |3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/parisc/hpux/fs.c b/arch/paris

[KJ][PATCH] ROUND_UP macro cleanup in arch/parisc

ROUND_UP macro cleanup, use ALIGN where ever appropriate Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- hpux/fs.c |5 ++--- kernel/sys_parisc32.c |3 +-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/arch/parisc/hpux/fs.c b/arch/parisc/hpux

[KJ][PATCH] ROUND_UP macro cleanup in drivers/pci

ROUND_UP macro cleanup, use ALIGN where ever appropriate Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- hotplug/cpci_hotplug_pci.c |2 -- setup-bus.c|8 +++- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/pci/hotplug

[KJ][PATCH] ROUND_UP cleanup in arch/mips/kernel/sysirix.c

ROUND_UP(32|64) cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- sysirix.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/mips/kernel/sysirix.c b/arch/mips/kernel/sysirix.c index 93a1484..59c25bc 100644 --- a/arch/mips/kernel

[KJ][PATCH] ROUND_UP macro cleanup in drivers/net/e1000

E1000_ROUNDUP macro cleanup, use ALIGN Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- e1000.h |3 --- e1000_ethtool.c |6 +++--- e1000_main.c| 10 +- e1000_param.c |4 ++-- 4 files changed, 10 insertions(+), 13 deletions(-) diff --git a/drivers

[KJ][PATCH] ROUND_?UP macro cleanup in drivers/parisc

Clean up ROUND_?UP, Use ALIGN where ever appropriate. Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- ccio-dma.c |8 iommu-helpers.h |4 ++-- sba_iommu.c |6 ++ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/paris

[KJ][PATCH] ROUND_?UP macro cleanup in drivers/parisc

Clean up ROUND_?UP, Use ALIGN where ever appropriate. Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- ccio-dma.c |8 iommu-helpers.h |4 ++-- sba_iommu.c |6 ++ 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/drivers/parisc/ccio

Re: [KJ][PATCH] BIT macro cleanup

On 3/29/07, Richard Knutsson <[EMAIL PROTECTED]> wrote: Alexey Dobriyan wrote: > On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote: > >> +#define BIT(nr) (1UL << ((nr) % BITS_PER_LONG)) >> > > I think this would be a disaster b

Re: [KJ][PATCH] BIT macro cleanup

On 3/29/07, Richard Knutsson [EMAIL PROTECTED] wrote: Alexey Dobriyan wrote: On Wed, Mar 28, 2007 at 09:03:09AM +0530, Milind Arun Choudhary wrote: +#define BIT(nr) (1UL ((nr) % BITS_PER_LONG)) I think this would be a disaster because something like BIT(123) would not even

[KJ][PATCH] BIT macro cleanup

BIT macro cleanup,now in bitops.h Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]> --- arch/ppc/platforms/chestnut.c |1 drivers/edac/edac_mc.h |2 - drivers/i2c/busses/i2c-pxa.c| 55 ++-- d

[KJ][PATCH] BIT macro cleanup

BIT macro cleanup,now in bitops.h Signed-off-by: Milind Arun Choudhary [EMAIL PROTECTED] --- arch/ppc/platforms/chestnut.c |1 drivers/edac/edac_mc.h |2 - drivers/i2c/busses/i2c-pxa.c| 55 ++-- drivers/net

Re: [KJ][RFC][PATCH] BIT macro cleanup

; (nr)) thoughts > > And what about the "1%"? > > The 1% will need either LLBIT or an extra % 8. -- Milind Arun Choudhary - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [KJ][RFC][PATCH] BIT macro cleanup

or an extra % 8. -- Milind Arun Choudhary - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/