[PATCH] backlight: Add TI LMU backlight driver

2017-03-19 Thread Milo Kim
gt; Cc: Sebastian Reichel <s...@kernel.org> Cc: Tony Lindgren <t...@atomide.com> Signed-off-by: Milo Kim <milo@ti.com> --- .../bindings/leds/backlight/ti-lmu-backlight.txt | 65 ++ drivers/video/backlight/Kconfig| 7 + drivers/video/backlight/Makefile

[PATCH] backlight: Add TI LMU backlight driver

2017-03-19 Thread Milo Kim
Lindgren Signed-off-by: Milo Kim --- .../bindings/leds/backlight/ti-lmu-backlight.txt | 65 ++ drivers/video/backlight/Kconfig| 7 + drivers/video/backlight/Makefile | 3 + drivers/video/backlight/ti-lmu-backlight-core.c| 655

[PATCH 2/2] regulator: lm363x: Use generic DT property name for external control pins

2017-02-28 Thread Milo Kim
Vpos and Vneg LDOs can be enabled or disabled by external GPIOs. Use general DT property 'enable-gpios' for this usage. Two enable pins are differentiable by selecting the index number. Signed-off-by: Milo Kim <milo@ti.com> --- drivers/regulator/lm363x-regulator.c | 4 ++-- 1 file chan

[PATCH 2/2] regulator: lm363x: Use generic DT property name for external control pins

2017-02-28 Thread Milo Kim
Vpos and Vneg LDOs can be enabled or disabled by external GPIOs. Use general DT property 'enable-gpios' for this usage. Two enable pins are differentiable by selecting the index number. Signed-off-by: Milo Kim --- drivers/regulator/lm363x-regulator.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/2] Documentation: dt-bindings: Use generic property for hardware enable pins

2017-02-28 Thread Milo Kim
With index usages, device specific properties can be replaced with generic one. Vpos is index 0 and Vneg is index 1. DT examples are added as well. Signed-off-by: Milo Kim <milo@ti.com> --- .../bindings/regulator/lm363x-regulator.txt| 78 +- 1 file chang

[PATCH 1/2] Documentation: dt-bindings: Use generic property for hardware enable pins

2017-02-28 Thread Milo Kim
With index usages, device specific properties can be replaced with generic one. Vpos is index 0 and Vneg is index 1. DT examples are added as well. Signed-off-by: Milo Kim --- .../bindings/regulator/lm363x-regulator.txt| 78 +- 1 file changed, 76 insertions(+), 2

[PATCH 2/2] mfd: add TI LMU driver

2017-02-27 Thread Milo Kim
is already upstreamed. Acked-by: Lee Jones <lee.jo...@linaro.org> Signed-off-by: Milo Kim <milo@ti.com> --- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile| 2 + drivers/mfd/ti-lmu.c| 259 + include/

[PATCH 2/2] mfd: add TI LMU driver

2017-02-27 Thread Milo Kim
is already upstreamed. Acked-by: Lee Jones Signed-off-by: Milo Kim --- drivers/mfd/Kconfig | 12 ++ drivers/mfd/Makefile| 2 + drivers/mfd/ti-lmu.c| 259 + include/linux/mfd/ti-lmu-register.h | 280

[PATCH 1/2] Documentation: dt-bindings: mfd: add TI LMU device binding information

2017-02-27 Thread Milo Kim
This patch describes overall binding for TI LMU MFD devices. Acked-by: Lee Jones <lee.jo...@linaro.org> Acked-by: Rob Herring <robh...@kernel.org> Signed-off-by: Milo Kim <milo@ti.com> --- Documentation/devicetree/bindings/mfd/ti-lmu.txt | 243 +++ 1

[PATCH 1/2] Documentation: dt-bindings: mfd: add TI LMU device binding information

2017-02-27 Thread Milo Kim
This patch describes overall binding for TI LMU MFD devices. Acked-by: Lee Jones Acked-by: Rob Herring Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/mfd/ti-lmu.txt | 243 +++ 1 file changed, 243 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v3 0/2] Support TI LMU devices

2017-02-27 Thread Milo Kim
ox x This patch-set includes only MFD part. Other subsystem drivers will be sent separately. ti-lmu-backlight: Backlight subsystem ti-lmu-fault-monitor: Misc driver leds-lm3633: LED subsystem Updates from v2: Submit acked patches to get merged quickly. Milo

[PATCH v3 0/2] Support TI LMU devices

2017-02-27 Thread Milo Kim
ox x This patch-set includes only MFD part. Other subsystem drivers will be sent separately. ti-lmu-backlight: Backlight subsystem ti-lmu-fault-monitor: Misc driver leds-lm3633: LED subsystem Updates from v2: Submit acked patches to get merged quickly. Milo

Re: [PATCH resend v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-09 Thread Milo Kim
On 01/10/2017 12:27 PM, Shawn Guo wrote: On Wed, Jan 04, 2017 at 04:04:36PM +0900, Milo Kim wrote: Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Mi

Re: [PATCH resend v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-09 Thread Milo Kim
On 01/10/2017 12:27 PM, Shawn Guo wrote: On Wed, Jan 04, 2017 at 04:04:36PM +0900, Milo Kim wrote: Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree

Re: [PATCH v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
On 01/04/2017 01:55 PM, Milo Kim wrote: Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Milo Kim <woogyom@gmail.com> --- .../devicetree/bin

Re: [PATCH v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
On 01/04/2017 01:55 PM, Milo Kim wrote: Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/boot/dts

[PATCH resend v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Milo Kim <woogyom@gmail.com> --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/

[PATCH resend v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/boot/dts/Makefile | 1 + arch

[PATCH v4 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2017-01-03 Thread Milo Kim
and add the vendor prefix. Use generic node name for the backlight panel. Sort alphabetically for the pinctrl nodes. Remove unnecessary pinmux of HDMI CEC. v3: Specify the dtbs for i.MX6 build. v2: Fix DT node for regulator, phy-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6

[PATCH v4 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2017-01-03 Thread Milo Kim
and add the vendor prefix. Use generic node name for the backlight panel. Sort alphabetically for the pinctrl nodes. Remove unnecessary pinmux of HDMI CEC. v3: Specify the dtbs for i.MX6 build. v2: Fix DT node for regulator, phy-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6

[PATCH v4 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-03 Thread Milo Kim
lt-in eMMC storage. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 255 + 1 file changed, 255 insertions(+) create mode 100644 arch/arm/boot/dts/imx6qdl-

[PATCH v4 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-03 Thread Milo Kim
lt-in eMMC storage. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 255 + 1 file changed, 255 insertions(+) create mode 100644 arch/arm/boot/dts/imx6qdl-savageboard.dtsi diff --git a/arch/arm/boot/d

[PATCH v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Milo Kim <woogyom@gmail.com> --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/

[PATCH v4 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-03 Thread Milo Kim
Common savageboard DT file is used for board support. Add the vendor name and specify the dtb file for i.MX6Q build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- .../devicetree/bindings/vendor-prefixes.txt| 1 + arch/arm/boot/dts/Makefile | 1 + arch

[PATCH v4 3/3] ARM: dts: imx6: Support Savageboard quad

2017-01-03 Thread Milo Kim
Use common board file and support SATA interface additionally. Specify the dtb file for i.MX6 build. Reviewed-by: Fabio Estevam <fabio.este...@nxp.com> Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-savagebo

[PATCH v4 3/3] ARM: dts: imx6: Support Savageboard quad

2017-01-03 Thread Milo Kim
Use common board file and support SATA interface additionally. Specify the dtb file for i.MX6 build. Reviewed-by: Fabio Estevam Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-savageboard.dts | 55 + 2 files

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 04:44 PM, Shawn Guo wrote: On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an un

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 04:44 PM, Shawn Guo wrote: On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an un

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 04:41 PM, Shawn Guo wrote: On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an un

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 04:41 PM, Shawn Guo wrote: On Mon, Jan 02, 2017 at 04:31:07PM +0900, Milo Kim wrote: On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an un

Re: [PATCH v3 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-01 Thread Milo Kim
On 01/02/2017 04:03 PM, Shawn Guo wrote: + model = "Poslab SavageBoard Dual"; + compatible = "poslab,imx6dl-savageboard", "fsl,imx6dl"; It seems that 'poslab' should be added to Documentation/devicetree/bindings/vendor-prefixes.txt Ah, right. Thanks for the review! Best regards,

Re: [PATCH v3 2/3] ARM: dts: imx6: Support Savageboard dual

2017-01-01 Thread Milo Kim
On 01/02/2017 04:03 PM, Shawn Guo wrote: + model = "Poslab SavageBoard Dual"; + compatible = "poslab,imx6dl-savageboard", "fsl,imx6dl"; It seems that 'poslab' should be added to Documentation/devicetree/bindings/vendor-prefixes.txt Ah, right. Thanks for the review! Best regards,

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an undocumented compatible. AVIC TM097TDH02 panel is compatible with Hannstar HSD100PXN1, so I reuse it. It's the same rule as the usage of

Re: [PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2017-01-01 Thread Milo Kim
On 01/02/2017 03:52 PM, Shawn Guo wrote: + panel { + compatible = "avic, tm097tdh02", "hannstar,hsd100pxn1"; "avic, tm097tdh02" is an undocumented compatible. AVIC TM097TDH02 panel is compatible with Hannstar HSD100PXN1, so I reuse it. It's the same rule as the usage of

Re: [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation

2016-12-17 Thread Milo Kim
Hi Luis, On 12/17/2016 01:14 AM, Luis R. Rodriguez wrote: Milo if sysfs is used can't the old userspace be mapped to use the new sysfs interface through a wrapper of some sort ? What exactly would be needed to ensure old userspace will not break? LP5521 and LP5523 have two ways to load hex

Re: [PATCH 5/5] firmware: add DECLARE_FW_CUSTOM_FALLBACK() annotation

2016-12-17 Thread Milo Kim
Hi Luis, On 12/17/2016 01:14 AM, Luis R. Rodriguez wrote: Milo if sysfs is used can't the old userspace be mapped to use the new sysfs interface through a wrapper of some sort ? What exactly would be needed to ensure old userspace will not break? LP5521 and LP5523 have two ways to load hex

Re: [PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

2016-12-17 Thread Milo Kim
On 12/18/2016 01:24 AM, Sebastian Reichel wrote: patches look fine, but these two patches must be reordered to fix bisectability. Otherwise after patch 1 the thread is not properly killed during driver removal. Thanks for your guidelines. The v3 patchset has been sent. Best regards, Milo

Re: [PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

2016-12-17 Thread Milo Kim
On 12/18/2016 01:24 AM, Sebastian Reichel wrote: patches look fine, but these two patches must be reordered to fix bisectability. Otherwise after patch 1 the thread is not properly killed during driver removal. Thanks for your guidelines. The v3 patchset has been sent. Best regards, Milo

[PATCH v3 1/7] power: supply: tps65217: Use 'poll_task' on unloading the module

2016-12-17 Thread Milo Kim
Use the task_struct variable for running polling thread. If polling task is activated, then use it to stop running thread. This is a preceding step of supporting two interrupts of TPS65217 charger, so checking single IRQ number is not appropriate when the module is removed. Signed-off-by: Milo

[PATCH v3 5/7] power: supply: tps65217: Use generic name for power supply property

2016-12-17 Thread Milo Kim
Replace 'ac_props' with 'charger_props'. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c

[PATCH v3 1/7] power: supply: tps65217: Use 'poll_task' on unloading the module

2016-12-17 Thread Milo Kim
Use the task_struct variable for running polling thread. If polling task is activated, then use it to stop running thread. This is a preceding step of supporting two interrupts of TPS65217 charger, so checking single IRQ number is not appropriate when the module is removed. Signed-off-by: Milo

[PATCH v3 5/7] power: supply: tps65217: Use generic name for power supply property

2016-12-17 Thread Milo Kim
Replace 'ac_props' with 'charger_props'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 5daf36192b8c

[PATCH v3 7/7] power: supply: tps65217: Use generic charger name

2016-12-17 Thread Milo Kim
"tps65217-charger" is more appropriate name because the driver supports not only AC but also USB charger. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH v3 6/7] power: supply: tps65217: Use generic name for get_property()

2016-12-17 Thread Milo Kim
Rename it as tps65217_charger_get_property(). Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_cha

[PATCH v3 7/7] power: supply: tps65217: Use generic charger name

2016-12-17 Thread Milo Kim
"tps65217-charger" is more appropriate name because the driver supports not only AC but also USB charger. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/tps65217_charger.c

[PATCH v3 6/7] power: supply: tps65217: Use generic name for get_property()

2016-12-17 Thread Milo Kim
Rename it as tps65217_charger_get_property(). Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 79afecafd945

[PATCH v3 4/7] power: supply: tps65217: Use generic name for power supply structure

2016-12-17 Thread Milo Kim
Replace 'ac' of tps65217_charger structure with 'psy'. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/

[PATCH v3 0/7] power: supply: tps65217: Support USB charger feature

2016-12-17 Thread Milo Kim
structure v3: Reorder the patches to avoid bisection issue v2: Regenerate the patchset for better code review Milo Kim (7): power: supply: tps65217: Use 'poll_task' on unloading the module power: supply: tps65217: Support USB charger interrupt power: supply: tps65217: Use generic name

[PATCH v3 3/7] power: supply: tps65217: Use generic name for charger online

2016-12-17 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. Replace 'ac_online' with 'online'. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH v3 2/7] power: supply: tps65217: Support USB charger interrupt

2016-12-17 Thread Milo Kim
cases, enable charging operation. Interrupt request: If an interrupt number is invalid, then use legacy polling thread. Otherwise, create IRQ threads to handle AC and USB charger event. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.

[PATCH v3 4/7] power: supply: tps65217: Use generic name for power supply structure

2016-12-17 Thread Milo Kim
Replace 'ac' of tps65217_charger structure with 'psy'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index

[PATCH v3 0/7] power: supply: tps65217: Support USB charger feature

2016-12-17 Thread Milo Kim
structure v3: Reorder the patches to avoid bisection issue v2: Regenerate the patchset for better code review Milo Kim (7): power: supply: tps65217: Use 'poll_task' on unloading the module power: supply: tps65217: Support USB charger interrupt power: supply: tps65217: Use generic name

[PATCH v3 3/7] power: supply: tps65217: Use generic name for charger online

2016-12-17 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. Replace 'ac_online' with 'online'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply

[PATCH v3 2/7] power: supply: tps65217: Support USB charger interrupt

2016-12-17 Thread Milo Kim
cases, enable charging operation. Interrupt request: If an interrupt number is invalid, then use legacy polling thread. Otherwise, create IRQ threads to handle AC and USB charger event. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 52

Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism

2016-12-13 Thread Milo Kim
Hi Jacek, On 12/13/2016 06:44 PM, Jacek Anaszewski wrote: Could you please verify if leds-lp55xx-common.c driver really needs a custom firmware loading fallback mechanism? Thanks for sharing this. The lp55xx-common uses this mechanism to load and run LED effect manually, so this could be a

Re: [PATCH 4/5] firmware: add SmPL report for custom fallback mechanism

2016-12-13 Thread Milo Kim
Hi Jacek, On 12/13/2016 06:44 PM, Jacek Anaszewski wrote: Could you please verify if leds-lp55xx-common.c driver really needs a custom firmware loading fallback mechanism? Thanks for sharing this. The lp55xx-common uses this mechanism to load and run LED effect manually, so this could be a

Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

2016-12-12 Thread Milo Kim
On 12/13/2016 02:25 AM, Rob Herring wrote: On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: Interrupt numbers are from the datasheet, so no need to keep them in the ABI. Use the number in the DT file. I don't see the purpose of ripping this out. The headers have always been

Re: [PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

2016-12-12 Thread Milo Kim
On 12/13/2016 02:25 AM, Rob Herring wrote: On Fri, Dec 09, 2016 at 03:28:31PM +0900, Milo Kim wrote: Interrupt numbers are from the datasheet, so no need to keep them in the ABI. Use the number in the DT file. I don't see the purpose of ripping this out. The headers have always been

Re: [PATCH] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-12 Thread Milo Kim
On 12/13/2016 12:49 AM, Maxime Ripard wrote: Hi, On Fri, Dec 09, 2016 at 10:47:58AM +0900, Milo Kim wrote: The commit 10efbf5f1633 introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim <woogyom@gmail.com> checkpatch reports an error on th

Re: [PATCH] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-12 Thread Milo Kim
On 12/13/2016 12:49 AM, Maxime Ripard wrote: Hi, On Fri, Dec 09, 2016 at 10:47:58AM +0900, Milo Kim wrote: The commit 10efbf5f1633 introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim checkpatch reports an error on this one (commit format), please

[PATCH resend] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-12 Thread Milo Kim
The commit 10efbf5f1633 ("ARM: dts: sun8i: Add dts file for NanoPi M1 SBC") introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/a

[PATCH resend] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-12 Thread Milo Kim
The commit 10efbf5f1633 ("ARM: dts: sun8i: Add dts file for NanoPi M1 SBC") introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Makefile

[PATCH v2 2/8] power: supply: tps65217: Use 'poll_task' on unloading the module

2016-12-08 Thread Milo Kim
TPS65217 has two interrupt numbers so checking single IRQ number is not appropriate when the module is removed. Use the task_struct variable for running polling thread. If polling task is activated, then use it to stop running thread. Signed-off-by: Milo Kim <woogyom@gmail.com> --- d

[PATCH v2 7/8] power: supply: tps65217: Use generic name for get_property()

2016-12-08 Thread Milo Kim
Rename it as tps65217_charger_get_property(). Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_cha

[PATCH v2 5/8] power: supply: tps65217: Use generic name for power supply structure

2016-12-08 Thread Milo Kim
Replace 'ac' of tps65217_charger structure with 'psy'. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/

[PATCH v2 2/8] power: supply: tps65217: Use 'poll_task' on unloading the module

2016-12-08 Thread Milo Kim
TPS65217 has two interrupt numbers so checking single IRQ number is not appropriate when the module is removed. Use the task_struct variable for running polling thread. If polling task is activated, then use it to stop running thread. Signed-off-by: Milo Kim --- drivers/power/supply

[PATCH v2 7/8] power: supply: tps65217: Use generic name for get_property()

2016-12-08 Thread Milo Kim
Rename it as tps65217_charger_get_property(). Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 79afeca..63c5556

[PATCH v2 5/8] power: supply: tps65217: Use generic name for power supply structure

2016-12-08 Thread Milo Kim
Replace 'ac' of tps65217_charger structure with 'psy'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index

[PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

2016-12-08 Thread Milo Kim
structure v2: Regenerate the patchset for better code review Milo Kim (8): power: supply: tps65217: Support USB charger interrupt power: supply: tps65217: Use 'poll_task' on unloading the module power: supply: tps65217: Remove IRQ data from driver data power: supply: tps65217: Use generic

[PATCH v2 8/8] power: supply: tps65217: Use generic charger name

2016-12-08 Thread Milo Kim
"tps65217-charger" is more appropriate name because the driver supports not only AC but also USB charger. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/driv

[PATCH v2 0/8] power: supply: tps65217: Support USB charger feature

2016-12-08 Thread Milo Kim
structure v2: Regenerate the patchset for better code review Milo Kim (8): power: supply: tps65217: Support USB charger interrupt power: supply: tps65217: Use 'poll_task' on unloading the module power: supply: tps65217: Remove IRQ data from driver data power: supply: tps65217: Use generic

[PATCH v2 8/8] power: supply: tps65217: Use generic charger name

2016-12-08 Thread Milo Kim
"tps65217-charger" is more appropriate name because the driver supports not only AC but also USB charger. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/supply/tps65217_charger.c

[PATCH v2 1/8] power: supply: tps65217: Support USB charger interrupt

2016-12-08 Thread Milo Kim
threads to handle AC and USB charger event. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 47 +++-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers

[PATCH v2 4/8] power: supply: tps65217: Use generic name for charger online

2016-12-08 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. Replace 'ac_online' with 'online'. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH v2 3/8] power: supply: tps65217: Remove IRQ data from driver data

2016-12-08 Thread Milo Kim
IRQ number is only used on requesting the interrupt, so no need to keep it inside the driver data. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/d

[PATCH v2 6/8] power: supply: tps65217: Use generic name for power supply property

2016-12-08 Thread Milo Kim
Replace 'ac_props' with 'charger_props'. Signed-off-by: Milo Kim <woogyom@gmail.com> --- drivers/power/supply/tps65217_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c

[PATCH v2 1/8] power: supply: tps65217: Support USB charger interrupt

2016-12-08 Thread Milo Kim
threads to handle AC and USB charger event. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 47 +++-- 1 file changed, 27 insertions(+), 20 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c

[PATCH v2 4/8] power: supply: tps65217: Use generic name for charger online

2016-12-08 Thread Milo Kim
This driver supports AC and USB chargers. Generic name is preferred. Replace 'ac_online' with 'online'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/power/supply

[PATCH v2 3/8] power: supply: tps65217: Remove IRQ data from driver data

2016-12-08 Thread Milo Kim
IRQ number is only used on requesting the interrupt, so no need to keep it inside the driver data. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply

[PATCH v2 6/8] power: supply: tps65217: Use generic name for power supply property

2016-12-08 Thread Milo Kim
Replace 'ac_props' with 'charger_props'. Signed-off-by: Milo Kim --- drivers/power/supply/tps65217_charger.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/power/supply/tps65217_charger.c b/drivers/power/supply/tps65217_charger.c index 5daf361..79afeca 100644

[PATCH 4/4] dt-bindings: input: Specify the interrupt number of TPS65217 power button

2016-12-08 Thread Milo Kim
Specify the power button interrupt number which is from the datasheet. Signed-off-by: Milo Kim <woogyom@gmail.com> --- Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings

[PATCH 3/4] dt-bindings: power/supply: Update TPS65217 properties

2016-12-08 Thread Milo Kim
Add interrupt specifiers for USB and AC charger input. Interrupt numbers are from the datasheet. Fix wrong property for compatible string. Signed-off-by: Milo Kim <woogyom@gmail.com> --- .../devicetree/bindings/power/supply/tps65217_charger.txt | 7 ++- 1 file chan

[PATCH 4/4] dt-bindings: input: Specify the interrupt number of TPS65217 power button

2016-12-08 Thread Milo Kim
Specify the power button interrupt number which is from the datasheet. Signed-off-by: Milo Kim --- Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/input/tps65218-pwrbutton.txt

[PATCH 3/4] dt-bindings: power/supply: Update TPS65217 properties

2016-12-08 Thread Milo Kim
Add interrupt specifiers for USB and AC charger input. Interrupt numbers are from the datasheet. Fix wrong property for compatible string. Signed-off-by: Milo Kim --- .../devicetree/bindings/power/supply/tps65217_charger.txt | 7 ++- 1 file changed, 6 insertions(+), 1 deletion

[PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

2016-12-08 Thread Milo Kim
Interrupt numbers are from the datasheet, so no need to keep them in the ABI. Use the number in the DT file. Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/am335x-bone-common.dtsi | 8 +++- include/dt-bindings/mfd/tps65217.h| 26 ---

[PATCH 1/4] ARM: dts: am335x: Fix the interrupt name of TPS65217

2016-12-08 Thread Milo Kim
Use 'interrupt-names' for getting the charger interrupt number. Fixes: 1934e89a769b ("ARM: dts: am335x: Add the charger interrupt") Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH 0/4] dt-bindings: mfd: Update TPS65217 interrupts

2016-12-08 Thread Milo Kim
This patch-set fixes wrong property name and uses TPS65217 HW interrupt number from the datasheet instead of the DT ABI. DT bindings are also updated. Milo Kim (4): ARM: dts: am335x: Fix the interrupt name of TPS65217 dt-bindings: mfd: Remove TPS65217 interrupts dt-bindings: power/supply

[PATCH 2/4] dt-bindings: mfd: Remove TPS65217 interrupts

2016-12-08 Thread Milo Kim
Interrupt numbers are from the datasheet, so no need to keep them in the ABI. Use the number in the DT file. Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 8 +++- include/dt-bindings/mfd/tps65217.h| 26 -- 2 files changed, 3

[PATCH 1/4] ARM: dts: am335x: Fix the interrupt name of TPS65217

2016-12-08 Thread Milo Kim
Use 'interrupt-names' for getting the charger interrupt number. Fixes: 1934e89a769b ("ARM: dts: am335x: Add the charger interrupt") Signed-off-by: Milo Kim --- arch/arm/boot/dts/am335x-bone-common.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/

[PATCH 0/4] dt-bindings: mfd: Update TPS65217 interrupts

2016-12-08 Thread Milo Kim
This patch-set fixes wrong property name and uses TPS65217 HW interrupt number from the datasheet instead of the DT ABI. DT bindings are also updated. Milo Kim (4): ARM: dts: am335x: Fix the interrupt name of TPS65217 dt-bindings: mfd: Remove TPS65217 interrupts dt-bindings: power/supply

[PATCH] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-08 Thread Milo Kim
The commit 10efbf5f1633 introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index c

[PATCH] ARM: dts: sun8i: Support DTB build for NanoPi M1

2016-12-08 Thread Milo Kim
The commit 10efbf5f1633 introduced NanoPi M1 board but it's missing in Allwinner H3 DTB build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index cccdbcb..4cbdf6f 100644

[PATCH v3 2/3] ARM: dts: imx6: Support Savageboard dual

2016-12-08 Thread Milo Kim
Common savageboard DT file is used for board support. Specify this dtb file for i.MX6Q build. Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6dl-savageboard.dts | 50 2 files chang

[PATCH v3 2/3] ARM: dts: imx6: Support Savageboard dual

2016-12-08 Thread Milo Kim
Common savageboard DT file is used for board support. Specify this dtb file for i.MX6Q build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6dl-savageboard.dts | 50 2 files changed, 51 insertions(+) create

[PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2016-12-08 Thread Milo Kim
output simultaneously. * Pinmux eMMC, ethernet, HDMI, I2C, power button, PWM, SD card and UART. * Others Enable ethernet, UART1 debug, USB host, USDHC3 for microSD card and USDHC4 for built-in eMMC storage. Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/i

[PATCH v3 3/3] ARM: dts: imx6: Support Savageboard quad

2016-12-08 Thread Milo Kim
Use common board file and support SATA interface additionally. Specify this dtb file for i.MX6 build. Signed-off-by: Milo Kim <woogyom@gmail.com> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-savageboard.dts | 54 + 2

[PATCH v3 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2016-12-08 Thread Milo Kim
. v2: Fix DT node for regulator, phy-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6: Add Savageboard common file ARM: dts: imx6: Support Savageboard dual ARM: dts: imx6: Support Savageboard quad arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx6dl

[PATCH v3 1/3] ARM: dts: imx6: Add Savageboard common file

2016-12-08 Thread Milo Kim
output simultaneously. * Pinmux eMMC, ethernet, HDMI, I2C, power button, PWM, SD card and UART. * Others Enable ethernet, UART1 debug, USB host, USDHC3 for microSD card and USDHC4 for built-in eMMC storage. Signed-off-by: Milo Kim --- arch/arm/boot/dts/imx6qdl-savageboard.dtsi | 262

[PATCH v3 3/3] ARM: dts: imx6: Support Savageboard quad

2016-12-08 Thread Milo Kim
Use common board file and support SATA interface additionally. Specify this dtb file for i.MX6 build. Signed-off-by: Milo Kim --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/imx6q-savageboard.dts | 54 + 2 files changed, 55 insertions

[PATCH v3 0/3] ARM: dts: imx6: Support Poslab Savageboard dual & quad

2016-12-08 Thread Milo Kim
. v2: Fix DT node for regulator, phy-reset-gpios and iomuxc node. Milo Kim (3): ARM: dts: imx6: Add Savageboard common file ARM: dts: imx6: Support Savageboard dual ARM: dts: imx6: Support Savageboard quad arch/arm/boot/dts/Makefile | 2 + arch/arm/boot/dts/imx6dl

  1   2   3   4   5   6   7   >