[tip:perf/core] perf tools: Avoid possible race condition in copyfile()

2015-06-12 Thread tip-bot for Milos Vyletel
Commit-ID: d7c72606d97e6f462a99b79e55b39808147d4c8b Gitweb: http://git.kernel.org/tip/d7c72606d97e6f462a99b79e55b39808147d4c8b Author: Milos Vyletel AuthorDate: Mon, 8 Jun 2015 16:50:16 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 10 Jun 2015 11:51:24 -0300 perf tools

[tip:perf/core] perf tools: Avoid possible race condition in copyfile()

2015-06-12 Thread tip-bot for Milos Vyletel
Commit-ID: d7c72606d97e6f462a99b79e55b39808147d4c8b Gitweb: http://git.kernel.org/tip/d7c72606d97e6f462a99b79e55b39808147d4c8b Author: Milos Vyletel mi...@redhat.com AuthorDate: Mon, 8 Jun 2015 16:50:16 +0200 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate: Wed, 10 Jun

[PATCH v2] perf tools: avoid possible race condition in copyfile

2015-06-08 Thread Milos Vyletel
also did revert fix from 0635b0f that to exposes previously fixed race with EEXIST and recreator test passed sucessfully. Signed-off-by: Milos Vyletel Acked-by: Ingo Molnar --- tools/perf/util/util.c | 46 +++--- 1 file changed, 31 insertions(+), 15

Re: [PATCH] perf tools: avoid possible race condition in copyfile

2015-06-08 Thread Milos Vyletel
On Mon, Jun 08, 2015 at 10:39:57AM -0300, Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar escreveu: > > * Milos Vyletel wrote: > > > On top of that slow_copyfile no longer needs to deal with file mode when > > > creatin

Re: [PATCH] perf tools: avoid possible race condition in copyfile

2015-06-08 Thread Milos Vyletel
On Mon, Jun 08, 2015 at 10:39:57AM -0300, Arnaldo Carvalho de Melo wrote: Em Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar escreveu: * Milos Vyletel mi...@redhat.com wrote: On top of that slow_copyfile no longer needs to deal with file mode when creating file since temporary file

[PATCH v2] perf tools: avoid possible race condition in copyfile

2015-06-08 Thread Milos Vyletel
binary itself. I also did revert fix from 0635b0f that to exposes previously fixed race with EEXIST and recreator test passed sucessfully. Signed-off-by: Milos Vyletel mi...@redhat.com Acked-by: Ingo Molnar mi...@kernel.org --- tools/perf/util/util.c | 46

Re: [PATCH] perf tools: avoid possible race condition in copyfile

2015-06-04 Thread Milos Vyletel
On Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar wrote: > > * Milos Vyletel wrote: > > > Use unique temporary files when copying to buildid dir to prevent races > > in case multiple instances are trying to copy same file. This is done by > > > > - cr

[PATCH] perf tools: avoid possible race condition in copyfile

2015-06-04 Thread Milos Vyletel
. On top of that slow_copyfile no longer needs to deal with file mode when creating file since temporary file is already created and mode is set. Signed-off-by: Milos Vyletel --- tools/perf/util/util.c | 48 1 file changed, 32 insertions(+), 16

Re: [PATCH] perf tools: avoid possible race condition in copyfile

2015-06-04 Thread Milos Vyletel
On Thu, Jun 04, 2015 at 11:11:00AM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: Use unique temporary files when copying to buildid dir to prevent races in case multiple instances are trying to copy same file. This is done by - creating template in form path

[PATCH] perf tools: avoid possible race condition in copyfile

2015-06-04 Thread Milos Vyletel
to parse them. On top of that slow_copyfile no longer needs to deal with file mode when creating file since temporary file is already created and mode is set. Signed-off-by: Milos Vyletel mi...@redhat.com --- tools/perf/util/util.c | 48 1 file changed

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-06-03 Thread Milos Vyletel
On Wed, Jun 03, 2015 at 01:21:41PM +0200, Ingo Molnar wrote: > > * Milos Vyletel wrote: > > > On Thu, May 14, 2015 at 07:38:08PM +0200, Ingo Molnar wrote: > > > > > > > > * Milos Vyletel wrote: > > > > > > &g

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-06-03 Thread Milos Vyletel
On Thu, May 14, 2015 at 07:38:08PM +0200, Ingo Molnar wrote: > > * Milos Vyletel wrote: > > > On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote: > > > > > On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote: > > > > > > > &

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-06-03 Thread Milos Vyletel
On Thu, May 14, 2015 at 07:38:08PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote: On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: Use

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-06-03 Thread Milos Vyletel
On Wed, Jun 03, 2015 at 01:21:41PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: On Thu, May 14, 2015 at 07:38:08PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-05-20 Thread Milos Vyletel
On Thu, May 14, 2015 at 07:38:08PM +0200, Ingo Molnar wrote: > > * Milos Vyletel wrote: > > > On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote: > > > > > On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote: > > > > > > > &

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-05-20 Thread Milos Vyletel
On Thu, May 14, 2015 at 07:38:08PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote: On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: Use

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-05-14 Thread Milos Vyletel
On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote: > On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote: > > > > * Milos Vyletel wrote: > > > > > Use new read/write locks when accesing buildid directory on places where > > > we

[PATCH 2/2] perf/tools: put new buildid locks to use

2015-05-14 Thread Milos Vyletel
Use new read/write locks when accesing buildid directory on places where we may race if multiple instances are run simultaneously. Signed-off-by: Milos Vyletel --- tools/perf/builtin-buildid-cache.c | 12 +++ tools/perf/util/build-id.c | 41

[PATCH 1/2] perf/tools: add read/write buildid dir locks

2015-05-14 Thread Milos Vyletel
Protect access to buildid dir by flock to prevent race conditions. This patch adds buildid_dir_read/write_lock/unlock functions. Signed-off-by: Milos Vyletel --- tools/perf/util/build-id.c | 56 ++ tools/perf/util/build-id.h | 5 + 2 files

[PATCH 0/2] Add perf debug dir locking

2015-05-14 Thread Milos Vyletel
functional change however more testing is welcome. Milos Milos Vyletel (2): perf/tools: add read/write buildid dir locks perf/tools: put new buildid locks to use tools/perf/builtin-buildid-cache.c | 12 + tools/perf/util/build-id.c | 97 ++ tools

Re: [PATCH 2/2] perf/tools: put new buildid locks to use

2015-05-14 Thread Milos Vyletel
On Thu, May 14, 2015 at 01:38:21PM +0200, Jiri Olsa wrote: On Thu, May 14, 2015 at 12:40:59PM +0200, Ingo Molnar wrote: * Milos Vyletel mi...@redhat.com wrote: Use new read/write locks when accesing buildid directory on places where we may race if multiple instances are run

[PATCH 1/2] perf/tools: add read/write buildid dir locks

2015-05-14 Thread Milos Vyletel
Protect access to buildid dir by flock to prevent race conditions. This patch adds buildid_dir_read/write_lock/unlock functions. Signed-off-by: Milos Vyletel mi...@redhat.com --- tools/perf/util/build-id.c | 56 ++ tools/perf/util/build-id.h | 5

[PATCH 2/2] perf/tools: put new buildid locks to use

2015-05-14 Thread Milos Vyletel
Use new read/write locks when accesing buildid directory on places where we may race if multiple instances are run simultaneously. Signed-off-by: Milos Vyletel mi...@redhat.com --- tools/perf/builtin-buildid-cache.c | 12 +++ tools/perf/util/build-id.c | 41

[PATCH 0/2] Add perf debug dir locking

2015-05-14 Thread Milos Vyletel
functional change however more testing is welcome. Milos Milos Vyletel (2): perf/tools: add read/write buildid dir locks perf/tools: put new buildid locks to use tools/perf/builtin-buildid-cache.c | 12 + tools/perf/util/build-id.c | 97 ++ tools

[PATCH v2] rcu: small rcu_dereference doc update

2015-04-17 Thread Milos Vyletel
Make a note stating that repeated calls of rcu_dereference() may not return the same pointer if update happens while in critical section. Reported-by: Jeff Haran Signed-off-by: Milos Vyletel --- Documentation/RCU/whatisRCU.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PATCH] rcu: small rcu_dereference doc update

2015-04-17 Thread Milos Vyletel
On Fri, Apr 17, 2015 at 10:13:50AM -0400, Steven Rostedt wrote: > On Fri, 17 Apr 2015 07:06:38 -0700 > "Paul E. McKenney" wrote: > > > On Fri, Apr 17, 2015 at 12:33:36PM +0200, Milos Vyletel wrote: > > > Make a note stating that repeated calls of rcu_dereferen

[PATCH] rcu: small rcu_dereference doc update

2015-04-17 Thread Milos Vyletel
Make a note stating that repeated calls of rcu_dereference() may not return the same pointer if update happens while in critical section. Reported-by: Jeff Haran Signed-off-by: Milos Vyletel --- Documentation/RCU/whatisRCU.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH] rcu: small rcu_dereference doc update

2015-04-17 Thread Milos Vyletel
Make a note stating that repeated calls of rcu_dereference() may not return the same pointer if update happens while in critical section. Reported-by: Jeff Haran jeff.ha...@citrix.com Signed-off-by: Milos Vyletel mi...@redhat.com --- Documentation/RCU/whatisRCU.txt | 4 +++- 1 file changed, 3

Re: [PATCH] rcu: small rcu_dereference doc update

2015-04-17 Thread Milos Vyletel
On Fri, Apr 17, 2015 at 10:13:50AM -0400, Steven Rostedt wrote: On Fri, 17 Apr 2015 07:06:38 -0700 Paul E. McKenney paul...@linux.vnet.ibm.com wrote: On Fri, Apr 17, 2015 at 12:33:36PM +0200, Milos Vyletel wrote: Make a note stating that repeated calls of rcu_dereference() may

[PATCH v2] rcu: small rcu_dereference doc update

2015-04-17 Thread Milos Vyletel
Make a note stating that repeated calls of rcu_dereference() may not return the same pointer if update happens while in critical section. Reported-by: Jeff Haran jeff.ha...@citrix.com Signed-off-by: Milos Vyletel mi...@redhat.com --- Documentation/RCU/whatisRCU.txt | 4 +++- 1 file changed, 3

[tip:perf/core] perf tools: Fix race in build_id_cache__add_s()

2015-03-22 Thread tip-bot for Milos Vyletel
Commit-ID: 0635b0f71424be7706793ac260d063491a2889a0 Gitweb: http://git.kernel.org/tip/0635b0f71424be7706793ac260d063491a2889a0 Author: Milos Vyletel AuthorDate: Fri, 20 Mar 2015 11:37:25 +0100 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 20 Mar 2015 17:49:50 -0300 perf tools

[tip:perf/core] perf tools: Fix race in build_id_cache__add_s()

2015-03-22 Thread tip-bot for Milos Vyletel
Commit-ID: 0635b0f71424be7706793ac260d063491a2889a0 Gitweb: http://git.kernel.org/tip/0635b0f71424be7706793ac260d063491a2889a0 Author: Milos Vyletel mi...@redhat.com AuthorDate: Fri, 20 Mar 2015 11:37:25 +0100 Committer: Arnaldo Carvalho de Melo a...@redhat.com CommitDate: Fri, 20 Mar

[PATCH] perf: fix race in build_id_cache__add_s()

2015-03-20 Thread Milos Vyletel
$3}' /proc/cpuinfo); do perf record -a -v -T -F 1000 -C $cpu \ -o perf-${cpu}.data sleep 5 2> /dev/null & done wait and simply search for empty files by find /lib/modules/`uname -r`/kernel/* -size 0 Signed-off-by: Milos Vyletel --- tools/perf/util/build-id.c |

[PATCH] perf: fix race in build_id_cache__add_s()

2015-03-20 Thread Milos Vyletel
perf record -a -v -T -F 1000 -C $cpu \ -o perf-${cpu}.data sleep 5 2 /dev/null done wait and simply search for empty files by find /lib/modules/`uname -r`/kernel/* -size 0 Signed-off-by: Milos Vyletel mi...@redhat.com --- tools/perf/util/build-id.c | 3 ++- 1 file changed

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-12 Thread Milos Vyletel
.* altogether since it's no-op and pretty confusing for users (myself included). Milos On Wed, Jun 11, 2014 at 6:32 PM, David Miller wrote: > From: Milos Vyletel > Date: Tue, 10 Jun 2014 13:49:35 -0400 > >> On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger >> wrote: >>> On T

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-12 Thread Milos Vyletel
.* altogether since it's no-op and pretty confusing for users (myself included). Milos On Wed, Jun 11, 2014 at 6:32 PM, David Miller da...@davemloft.net wrote: From: Milos Vyletel milos.vyle...@gmail.com Date: Tue, 10 Jun 2014 13:49:35 -0400 On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger step

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Milos Vyletel
On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger wrote: > On Tue, 10 Jun 2014 12:19:11 -0400 > Milos Vyletel wrote: > >> As it is right now net.ipv6.conf.all.* are mostly ignored and instead >> we're only making decisions based on interface specific settings. These >>

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Milos Vyletel
> Hello, > >> >> IN6_DEV_MAXCONF >> IN6_DEV_HOPLIMIT >> IN6_DEV_MTU > > I'm a little bit surprise to set the MTU as the maximum of all/dev > value. Since the default for "all" is IPV6_MIN_MTU, it is probably > harmless, but it could be a little bit surprising for administrators. > >>

[patch net-next 4/5] Documentation: update ipv6 part of networking/ip-sysctl.txt

2014-06-10 Thread Milos Vyletel
Documentation was updated with details how net.ipv6.conf.all settings are used and how they affect current behaviour and interface-specific settings. Signed-off-by: Milos Vyletel --- Documentation/networking/ip-sysctl.txt | 48 ++ 1 file changed, 43 insertions

[patch net-next 1/5] ipv6: align sysctl table creation code with ipv4

2014-06-10 Thread Milos Vyletel
Use ADDRCONF_SYSCTL* macros to define sysctl table. This is first step to align ipv6 and ipv4 sysctl code. Signed-off-by: Milos Vyletel --- net/ipv6/addrconf.c | 300 1 file changed, 66 insertions(+), 234 deletions(-) diff --git a/net/ipv6

[patch net-next 5/5] ipv6: copy default config values to interfaces

2014-06-10 Thread Milos Vyletel
Propagate changes to default sysctl values to all interfaces if they were not previously configured and interface was not up before. This is usually only true during boot when we apply /etc/sysctl.conf values before network is brought up. Signed-off-by: Milos Vyletel --- include/linux/ipv6.h

[patch net-next 2/5] ipv6: rename DEVCONF* to IPV6_DEVCONF* to align with ipv4

2014-06-10 Thread Milos Vyletel
Use IPV6_DEVCONF* name similar to the IPV4_DEVCONF* used in ipv4. Another step in aligning code. Signed-off-by: Milos Vyletel --- include/uapi/linux/ipv6.h | 68 +-- net/ipv6/addrconf.c | 74 +++ 2 files

[patch net-next 2/5] ipv6: rename DEVCONF* to IPV6_DEVCONF* to align with ipv4

2014-06-10 Thread Milos Vyletel
Use IPV6_DEVCONF* name similar to the IPV4_DEVCONF* used in ipv4. Another step in aligning code. Signed-off-by: Milos Vyletel milos.vyle...@gmail.com --- include/uapi/linux/ipv6.h | 68 +-- net/ipv6/addrconf.c | 74

[patch net-next 5/5] ipv6: copy default config values to interfaces

2014-06-10 Thread Milos Vyletel
Propagate changes to default sysctl values to all interfaces if they were not previously configured and interface was not up before. This is usually only true during boot when we apply /etc/sysctl.conf values before network is brought up. Signed-off-by: Milos Vyletel milos.vyle...@gmail.com

[patch net-next 4/5] Documentation: update ipv6 part of networking/ip-sysctl.txt

2014-06-10 Thread Milos Vyletel
Documentation was updated with details how net.ipv6.conf.all settings are used and how they affect current behaviour and interface-specific settings. Signed-off-by: Milos Vyletel milos.vyle...@gmail.com --- Documentation/networking/ip-sysctl.txt | 48 ++ 1 file

[patch net-next 1/5] ipv6: align sysctl table creation code with ipv4

2014-06-10 Thread Milos Vyletel
Use ADDRCONF_SYSCTL* macros to define sysctl table. This is first step to align ipv6 and ipv4 sysctl code. Signed-off-by: Milos Vyletel milos.vyle...@gmail.com --- net/ipv6/addrconf.c | 300 1 file changed, 66 insertions(+), 234 deletions

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Milos Vyletel
Hello, IN6_DEV_MAXCONF IN6_DEV_HOPLIMIT IN6_DEV_MTU I'm a little bit surprise to set the MTU as the maximum of all/dev value. Since the default for all is IPV6_MIN_MTU, it is probably harmless, but it could be a little bit surprising for administrators.

Re: [patch net-next 3/5] ipv6: consider net.ipv6.conf.all sysctls when making decisions

2014-06-10 Thread Milos Vyletel
On Tue, Jun 10, 2014 at 1:13 PM, Stephen Hemminger step...@networkplumber.org wrote: On Tue, 10 Jun 2014 12:19:11 -0400 Milos Vyletel milos.vyle...@gmail.com wrote: As it is right now net.ipv6.conf.all.* are mostly ignored and instead we're only making decisions based on interface specific

Re: [patch net-next] net: ipv6: trigger action when setting conf.all sysctls

2014-05-28 Thread Milos Vyletel
On Wed, May 21, 2014 at 4:31 PM, David Miller wrote: > From: Cong Wang > Date: Wed, 21 May 2014 10:35:17 -0700 > >> On Mon, May 19, 2014 at 10:09 AM, Milos Vyletel >> wrote: >>> As it is right now most of these tunables don't do anything - they don't >>&

Re: [patch net-next] net: ipv6: trigger action when setting conf.all sysctls

2014-05-28 Thread Milos Vyletel
On Wed, May 21, 2014 at 4:31 PM, David Miller da...@davemloft.net wrote: From: Cong Wang cw...@twopensource.com Date: Wed, 21 May 2014 10:35:17 -0700 On Mon, May 19, 2014 at 10:09 AM, Milos Vyletel milos.vyle...@gmail.com wrote: As it is right now most of these tunables don't do anything

[patch net-next] net: ipv6: trigger action when setting conf.all sysctls

2014-05-19 Thread Milos Vyletel
.conf.lo.accept_dad = 1 Signed-off-by: Milos Vyletel --- net/ipv6/addrconf.c | 157 ++-- 1 file changed, 127 insertions(+), 30 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 6c7fa08..f4a1eaa 100644 --- a/net/ipv6/addrconf.c

[patch net-next] net: ipv6: trigger action when setting conf.all sysctls

2014-05-19 Thread Milos Vyletel
.conf.lo.accept_dad = 1 Signed-off-by: Milos Vyletel milos.vyle...@gmail.com --- net/ipv6/addrconf.c | 157 ++-- 1 file changed, 127 insertions(+), 30 deletions(-) diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c index 6c7fa08..f4a1eaa 100644

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-06 Thread Milos Vyletel
And this time in plain text... Most likely yes but I wanted to keep sha1_ssse3_mod_init consistent with sha256_ssse3_mod_init/sha512_ssse3_mod_init functions. Milos On Tue, May 6, 2014 at 4:28 AM, Pavel Machek wrote: > On Wed 2014-04-30 15:17:54, Milos Vyletel wrote: >> Coverity

Re: [PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-05-06 Thread Milos Vyletel
And this time in plain text... Most likely yes but I wanted to keep sha1_ssse3_mod_init consistent with sha256_ssse3_mod_init/sha512_ssse3_mod_init functions. Milos On Tue, May 6, 2014 at 4:28 AM, Pavel Machek pa...@ucw.cz wrote: On Wed 2014-04-30 15:17:54, Milos Vyletel wrote: Coverity

[PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-04-30 Thread Milos Vyletel
name); 263return crypto_register_shash(); 264} Reported-by: Signed-off-by: Milos Vyletel --- arch/x86/crypto/sha1_ssse3_glue.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/arch/x86/crypto/sha1_ssse3_glue.c b/arch/x86/crypto/sha1_ssse3_gl

[PATCH] crypto: x86/sha1: fix coverity CID 1195603

2014-04-30 Thread Milos Vyletel
return crypto_register_shash(alg); 264} Reported-by: scan-ad...@coverity.com Signed-off-by: Milos Vyletel milos.vyle...@gmail.com --- arch/x86/crypto/sha1_ssse3_glue.c | 22 -- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/arch/x86/crypto

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-27 Thread Milos Vyletel
- Original Message - > Milos Vyletel writes: > > On Feb 25, 2013, at 5:12 PM, Greg KH wrote: > > > >> On Fri, Feb 22, 2013 at 10:14:49AM +1030, Rusty Russell wrote: > >>> Milos Vyletel writes: > >>> > >>>> When virtio-blk d

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-27 Thread Milos Vyletel
- Original Message - Milos Vyletel milos.vyle...@sde.cz writes: On Feb 25, 2013, at 5:12 PM, Greg KH g...@kroah.com wrote: On Fri, Feb 22, 2013 at 10:14:49AM +1030, Rusty Russell wrote: Milos Vyletel milos.vyle...@sde.cz writes: When virtio-blk device is resized from host

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-26 Thread Milos Vyletel
- Original Message - > On 02/25/2013 10:54 PM, Milos Vyletel wrote: > > - Original Message - > >> On 02/22/2013 03:02 AM, Milos Vyletel wrote: > >>> When virtio-blk device is resized from host (using block_resize from > >>> QEMU) > >

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-26 Thread Milos Vyletel
- Original Message - On 02/25/2013 10:54 PM, Milos Vyletel wrote: - Original Message - On 02/22/2013 03:02 AM, Milos Vyletel wrote: When virtio-blk device is resized from host (using block_resize from QEMU) emit KOBJ_CHANGE uevent to notify guest about such change

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Milos Vyletel
On Feb 25, 2013, at 5:12 PM, Greg KH wrote: > On Fri, Feb 22, 2013 at 10:14:49AM +1030, Rusty Russell wrote: >> Milos Vyletel writes: >> >>> When virtio-blk device is resized from host (using block_resize from QEMU) >>> emit >>> KOBJ_CHANG

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Milos Vyletel
On Feb 25, 2013, at 5:39 PM, Kay Sievers wrote: > On Mon, Feb 25, 2013 at 11:12 PM, Greg KH wrote: > >> Hm, I thought we were frowning apon running binaries from udev rules >> these days, especially ones that might have big consequences (like >> resizing a disk image) like this. >> >> Kay,

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Milos Vyletel
- Original Message - > On 02/22/2013 03:02 AM, Milos Vyletel wrote: > > When virtio-blk device is resized from host (using block_resize from QEMU) > > emit > > KOBJ_CHANGE uevent to notify guest about such change. This allows user to > > have > > custom ude

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Milos Vyletel
- Original Message - On 02/22/2013 03:02 AM, Milos Vyletel wrote: When virtio-blk device is resized from host (using block_resize from QEMU) emit KOBJ_CHANGE uevent to notify guest about such change. This allows user to have custom udev rules which would take whatever action

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Milos Vyletel
On Feb 25, 2013, at 5:39 PM, Kay Sievers k...@vrfy.org wrote: On Mon, Feb 25, 2013 at 11:12 PM, Greg KH g...@kroah.com wrote: Hm, I thought we were frowning apon running binaries from udev rules these days, especially ones that might have big consequences (like resizing a disk image) like

Re: [PATCH] virtio-blk: emit udev event when device is resized

2013-02-25 Thread Milos Vyletel
On Feb 25, 2013, at 5:12 PM, Greg KH g...@kroah.com wrote: On Fri, Feb 22, 2013 at 10:14:49AM +1030, Rusty Russell wrote: Milos Vyletel milos.vyle...@sde.cz writes: When virtio-blk device is resized from host (using block_resize from QEMU) emit KOBJ_CHANGE uevent to notify guest about

[PATCH] virtio-blk: emit udev event when device is resized

2013-02-21 Thread Milos Vyletel
;, \ ENV{RESIZE}=="1", \ ENV{ID_FS_TYPE}=="LVM2_member", \ RUN+="/sbin/pvresize /dev/%k" Signed-off-by: Milos Vyletel --- drivers/block/virtio_blk.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/block/virtio_blk.c b/dri

[PATCH] virtio-blk: emit udev event when device is resized

2013-02-21 Thread Milos Vyletel
/pvresize /dev/%k Signed-off-by: Milos Vyletel milos.vyle...@sde.cz --- drivers/block/virtio_blk.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/block/virtio_blk.c b/drivers/block/virtio_blk.c index 8ad21a2..5990382 100644 --- a/drivers/block/virtio_blk.c +++ b/drivers