and read(). eg,
> +* SetPageReferenced(page) or mark_page_accessed(page) or
> +* activate_page(page).
> +*/
> + for (cur_off = offset; cur_off < end ; ) {
> + struct page *page;
> + loff_t end_of_coverage;
> +
> + page
= (cur_off + PAGE_CACHE_SIZE) PAGE_CACHE_MASK;
+ }
+
+out:
+ fdput(f);
+ return ret;
+}
_
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
ut that won't work.
>
Per definition EWOULDBLOCK seams like a better fit. Like you said
above it won't stop blocking unless you do something. I also did a
search in the kernel source (excluding drivers / sound directories)
use of EAGAIN (even in network code) is like 2 magnitudes bigger the
edium and large reads. Needs quantifying.
>
> And I don't believe that e) will be a problem in the real world. It's
> a significant increase in worst-case latency and a negligible increase
> in average latency. I've asked at least three times for someone to
> explain why this is unac
th pwritev, in applications that don't
want to block while logging (but it's okay to drop low level log
messages). That's a whole different use case in my mind.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this
On Mon, Mar 30, 2015 at 6:57 PM, Andrew Morton
wrote:
> On Mon, 30 Mar 2015 18:49:06 -0400 Milosz Tanski wrote:
>
>> > A fincore+pread solution that blocks is simply unsafe
>> > to use for us. We'll have to stay with the threadpool :-(.
>>
>> We're getting
nse if we send it down the
wire while we process other connections. It becomes even more useful
over HTTP2 which provides it's own framing where we can send a partial
response frame and move onto other requests in this connection or
other connections.
--
Milosz Tanski
CTO
16 East 34th Stree
t; a significant increase in worst-case latency and a negligible increase
>> in average latency. I've asked at least three times for someone to
>> explain why this is unacceptable and no explanation has been provided.
>
> See above.
--
Milosz Tanski
CTO
16 East 34th Street,
t;
At the LSF/MM session, the agreement form the active participants
(James Bottomley, Ted Tso, Christoph, and I forget the last guy's
name) that we should ship both syscalls in the first patch. Personally
I don't care, but you're the only voice against it.
--
Milosz Tanski
CTO
16 East
d leave lots of free memory for the kernel especially
for the page cache. For example the Google want to minimize malloc().
So in tcmalloc() they grab large chunks and rarely release it to back
to the OS, in fact old version never shrank it. So you can entirely
avoid stalls in malloc() for many work
level log
messages). That's a whole different use case in my mind.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
asked at least three times for someone to
explain why this is unacceptable and no explanation has been provided.
See above.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe
in the first patch. Personally
I don't care, but you're the only voice against it.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord
) will be a problem in the real world. It's
a significant increase in worst-case latency and a negligible increase
in average latency. I've asked at least three times for someone to
explain why this is unacceptable and no explanation has been provided.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
onto other requests in this connection or
other connections.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
and rarely release it to back
to the OS, in fact old version never shrank it. So you can entirely
avoid stalls in malloc() for many workloads.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line
On Mon, Mar 30, 2015 at 6:57 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Mon, 30 Mar 2015 18:49:06 -0400 Milosz Tanski mil...@adfin.com wrote:
A fincore+pread solution that blocks is simply unsafe
to use for us. We'll have to stay with the threadpool :-(.
We're getting data from
.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Fri, Mar 27, 2015 at 12:30 PM, Andrew Morton
wrote:
> On Fri, 27 Mar 2015 08:58:54 -0700 Jeremy Allison wrote:
>
>> On Fri, Mar 27, 2015 at 02:01:59AM -0700, Andrew Morton wrote:
>> > On Fri, 27 Mar 2015 01:48:33 -0700 Christoph Hellwig
>> > wrote:
>> >
>> > > On Fri, Mar 27, 2015 at
EOF it'll return 0 instead of EWOULDBLOCK today. I
actually test for this in the preadv2 test in xfstest here:
https://github.com/mtanski/xfstests/commit/688db24c292999c81ee17caf2b61fe8cf7bb3cd6#diff-114416ea98ce29dde3b5b3d145afbd2bR81.
There's one caveat, that it's possible to get EWOULDBLOCK w
On Thu, Mar 26, 2015 at 11:28 PM, Andrew Morton
wrote:
> On Mon, 16 Mar 2015 14:27:10 -0400 Milosz Tanski wrote:
>
>> This patchset introduces two new syscalls preadv2 and pwritev2. They are the
>> same syscalls as preadv and pwrite but with a flag argument. Additionally,
>
reading
at end of file if the file metadata is not paged in.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
On Fri, Mar 27, 2015 at 12:30 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Fri, 27 Mar 2015 08:58:54 -0700 Jeremy Allison j...@samba.org wrote:
On Fri, Mar 27, 2015 at 02:01:59AM -0700, Andrew Morton wrote:
On Fri, 27 Mar 2015 01:48:33 -0700 Christoph Hellwig h...@infradead.org
On Thu, Mar 26, 2015 at 11:28 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Mon, 16 Mar 2015 14:27:10 -0400 Milosz Tanski mil...@adfin.com wrote:
This patchset introduces two new syscalls preadv2 and pwritev2. They are the
same syscalls as preadv and pwrite but with a flag argument
On Thu, Mar 26, 2015 at 3:12 PM, Milosz Tanski wrote:
> On Thu, Mar 26, 2015 at 7:55 AM, Christoph Hellwig wrote:
>>
>> On Mon, Mar 16, 2015 at 02:27:10PM -0400, Milosz Tanski wrote:
>> > This patchset introduces two new syscalls preadv2 and pwritev2. They are
>
On Thu, Mar 26, 2015 at 7:55 AM, Christoph Hellwig wrote:
>
> On Mon, Mar 16, 2015 at 02:27:10PM -0400, Milosz Tanski wrote:
> > This patchset introduces two new syscalls preadv2 and pwritev2. They are the
> > same syscalls as preadv and pwrite but with a flag argument. Additio
On Thu, Mar 26, 2015 at 3:12 PM, Milosz Tanski mil...@adfin.com wrote:
On Thu, Mar 26, 2015 at 7:55 AM, Christoph Hellwig h...@infradead.org wrote:
On Mon, Mar 16, 2015 at 02:27:10PM -0400, Milosz Tanski wrote:
This patchset introduces two new syscalls preadv2 and pwritev2
On Thu, Mar 26, 2015 at 7:55 AM, Christoph Hellwig h...@infradead.org wrote:
On Mon, Mar 16, 2015 at 02:27:10PM -0400, Milosz Tanski wrote:
This patchset introduces two new syscalls preadv2 and pwritev2. They are the
same syscalls as preadv and pwrite but with a flag argument. Additionally
On Mon, Mar 16, 2015 at 6:02 PM, Dave Chinner wrote:
> On Mon, Mar 16, 2015 at 02:34:22PM -0400, Milosz Tanski wrote:
>> preadv2 is a new syscall introduced that is like preadv2 but with flag
>> argument. The first use case of this is to let us add a flag to perform a
>> no
On Mon, Mar 16, 2015 at 5:07 PM, Andreas Dilger wrote:
>
>> On Mar 16, 2015, at 12:34 PM, Milosz Tanski wrote:
>>
>> preadv2 is a new syscall introduced that is like preadv2 but with flag
>
> Sorry, "preadv2 ... is like preadv2"?
I already have a
2
+
+#endif /* HAVE_PREADV2 */
+#endif /* PREADV2_PWRITEV2_H */
diff --git a/src/preadv2.c b/src/preadv2.c
new file mode 100644
index 000..a4f89b5
--- /dev/null
+++ b/src/preadv2.c
@@ -0,0 +1,150 @@
+/*
+ * Copyright 2014 Red Hat, Inc. All rights reserved.
+ * Copyright 2015 Milosz Tanski
+ *
+ * Licens
New syscalls that take an flag argument. This change does not add any specific
flags.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
---
fs/read_write.c | 172 ++
include/linux/compat.h| 6 ++
include/linux
New syscalls that are a variation on the preadv/pwritev but support an extra
flag argument.
Signed-off-by: Milosz Tanski
Suggested-by: Jeff Moyer
Fixes: Jeff Moyer
---
man2/readv.2 | 71 +++-
1 file changed, 61 insertions(+), 10
this code.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
Reviewed-by: Jeff Moyer
Acked-by: Sage Weil
---
fs/ceph/file.c | 2 ++
fs/cifs/file.c | 6 ++
fs/nfs/file.c | 5 -
fs/ocfs2/file.c| 6 ++
fs/pipe.c | 3 ++-
fs/read_write.c| 44
Plumbing the flags argument through the vfs code so they can be passed down to
__generic_file_(read/write)_iter function that do the acctual work.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
Reviewed-by: Jeff Moyer
---
drivers/target/target_core_file.c | 6 +++---
fs/nfsd
From: Christoph Hellwig
Add support for non-blocking reads. The guts are handled by the generic
code, the only addition is a non-blocking variant of xfs_rw_ilock.
Signed-off-by: Christoph Hellwig
---
fs/xfs/xfs_file.c | 32 +++-
1 file changed, 27 insertions(+), 5
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
---
arch/x86/syscalls/syscall_32.tbl | 2 ++
arch/x86/syscalls/syscall_64.tbl | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
index b3560ec..b37aa9c 100644
ess, per. Jeff Moyer
- Resolved duplicate (c) code in syscall code, per. Jeff
- Included perf data in thread cover letter, per. Jeff
- Created a new flag (not O_NONBLOCK) for readv2, perf Jeff
I have co-developed these changes with Christoph Hellwig.
Christoph Hellwig (1):
xfs: add RWF
On Mon, Mar 16, 2015 at 6:02 PM, Dave Chinner da...@fromorbit.com wrote:
On Mon, Mar 16, 2015 at 02:34:22PM -0400, Milosz Tanski wrote:
preadv2 is a new syscall introduced that is like preadv2 but with flag
argument. The first use case of this is to let us add a flag to perform a
non-blocking
On Mon, Mar 16, 2015 at 5:07 PM, Andreas Dilger adil...@dilger.ca wrote:
On Mar 16, 2015, at 12:34 PM, Milosz Tanski mil...@adfin.com wrote:
preadv2 is a new syscall introduced that is like preadv2 but with flag
Sorry, preadv2 ... is like preadv2?
I already have a fix for in my branch
, per. Jeff
- Included perf data in thread cover letter, per. Jeff
- Created a new flag (not O_NONBLOCK) for readv2, perf Jeff
I have co-developed these changes with Christoph Hellwig.
Christoph Hellwig (1):
xfs: add RWF_NONBLOCK support
Milosz Tanski (4):
vfs: Prepare for adding a new
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
arch/x86/syscalls/syscall_32.tbl | 2 ++
arch/x86/syscalls/syscall_64.tbl | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
index
New syscalls that are a variation on the preadv/pwritev but support an extra
flag argument.
Signed-off-by: Milosz Tanski mil...@adfin.com
Suggested-by: Jeff Moyer jmo...@redhat.com
Fixes: Jeff Moyer jmo...@redhat.com
---
man2/readv.2 | 71
New syscalls that take an flag argument. This change does not add any specific
flags.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
fs/read_write.c | 172 ++
include/linux/compat.h
this code.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jeff Moyer jmo...@redhat.com
Acked-by: Sage Weil s...@redhat.com
---
fs/ceph/file.c | 2 ++
fs/cifs/file.c | 6 ++
fs/nfs/file.c | 5 -
fs/ocfs2/file.c| 6
/* PREADV2_PWRITEV2_H */
diff --git a/src/preadv2.c b/src/preadv2.c
new file mode 100644
index 000..a4f89b5
--- /dev/null
+++ b/src/preadv2.c
@@ -0,0 +1,150 @@
+/*
+ * Copyright 2014 Red Hat, Inc. All rights reserved.
+ * Copyright 2015 Milosz Tanski
+ *
+ * License: GPLv2
+ *
+ */
+#include stdio.h
From: Christoph Hellwig h...@lst.de
Add support for non-blocking reads. The guts are handled by the generic
code, the only addition is a non-blocking variant of xfs_rw_ilock.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/xfs/xfs_file.c | 32 +++-
1 file
Plumbing the flags argument through the vfs code so they can be passed down to
__generic_file_(read/write)_iter function that do the acctual work.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jeff Moyer jmo...@redhat.com
---
drivers/target
== n) {
+ state->ret = nread;
+ tevent_req_done(req);
+ return tevent_req_post(req, ev);
+ }
+
SMBPROFILE_BYTES_ASYNC_START(syscall_asys_pread, profile_p,
state->profile_bytes, n);
ret = asys_pread(state->asys_ctx, fsp->f
(syscall_asys_pread, profile_p,
state-profile_bytes, n);
ret = asys_pread(state-asys_ctx, fsp-fh-fd, data, n, offset, req);
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from
ed up preadv2 support into samba and I hopefully have
some numbers from it soon. Finally, I'm putting together a test case
for the typical webapp middle-tier service (epoll + threadpool for
diskio).
Haven't stopped, just progressing on that slower due to external factors.
P.S: Sorry for re-send. On the road a
: Sorry for re-send. On the road and was using gmail to respond
with... it randomly forgets plain-text only settings.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e: mil...@adfin.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Tue, Dec 2, 2014 at 5:42 PM, Andrew Morton wrote:
>
> On Tue, 2 Dec 2014 17:17:42 -0500 Milosz Tanski wrote:
>
> > > There have been several incomplete attempts to implement fincore(). If
> > > we were to complete those attempts, preadv2() could be implemented
On Tue, Dec 2, 2014 at 5:42 PM, Andrew Morton a...@linux-foundation.org wrote:
On Tue, 2 Dec 2014 17:17:42 -0500 Milosz Tanski mil...@adfin.com wrote:
There have been several incomplete attempts to implement fincore(). If
we were to complete those attempts, preadv2() could be implemented
On Tue, Nov 25, 2014 at 6:01 PM, Andrew Morton
wrote:
>
> On Mon, 10 Nov 2014 11:40:23 -0500 Milosz Tanski wrote:
>
> > This patcheset introduces an ability to perform a non-blocking read from
> > regular files in buffered IO mode. This works by only for those filesyste
On Tue, Nov 25, 2014 at 6:01 PM, Andrew Morton
a...@linux-foundation.org wrote:
On Mon, 10 Nov 2014 11:40:23 -0500 Milosz Tanski mil...@adfin.com wrote:
This patcheset introduces an ability to perform a non-blocking read from
regular files in buffered IO mode. This works by only for those
tree. This is 3.19 stuff I presume ?
>> istr akpm picked up execveat recently, so if that goes in first, we'll
>> need to respin this anyway..
>
> Sure. I just wanted to test with trinity *before* it makes it into the
> kernel. Crazy, I know. ;-)
I am happy to help out to make s
te a test using the framework, the
documentation (README) seams very XFS specific and otherwise the test
seam to be be split between many different files / directories / C
code / shell code. I might be me being slow... but it's just not
obvious for me how to glue the whole thing together.
--
Milosz
and otherwise the test
seam to be be split between many different files / directories / C
code / shell code. I might be me being slow... but it's just not
obvious for me how to glue the whole thing together.
--
Milosz Tanski
CTO
16 East 34th Street, 15th floor
New York, NY 10016
p: 646-253-9055
e
..
Sure. I just wanted to test with trinity *before* it makes it into the
kernel. Crazy, I know. ;-)
I am happy to help out to make sure it's solid... although deep down
inside I secretly wish that now wasn't the time we decided to start
doing it :)
Cheers,
Jeff
--
Milosz Tanski
CTO
16
On Tue, Nov 11, 2014 at 1:44 AM, Dave Chinner wrote:
> On Mon, Nov 10, 2014 at 11:40:23AM -0500, Milosz Tanski wrote:
>> This patcheset introduces an ability to perform a non-blocking read from
>> regular files in buffered IO mode. This works by only for those filesystems
&g
On Tue, Nov 11, 2014 at 1:44 AM, Dave Chinner da...@fromorbit.com wrote:
On Mon, Nov 10, 2014 at 11:40:23AM -0500, Milosz Tanski wrote:
This patcheset introduces an ability to perform a non-blocking read from
regular files in buffered IO mode. This works by only for those filesystems
that have
benchmarks and I have no observed any perf regressions in
any of the normal (old) code paths.
I have co-developed these changes with Christoph Hellwig.
Christoph Hellwig (3):
xfs: add RWF_NONBLOCK support
fs: pass iocb to generic_write_sync
fs: add a flag for per-operation O_DSYNC semant
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
---
arch/x86/syscalls/syscall_32.tbl | 2 ++
arch/x86/syscalls/syscall_64.tbl | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
index 9fe1b5d..d592d87 100644
From: Christoph Hellwig
Add support for non-blocking reads. The guts are handled by the generic
code, the only addition is a non-blocking variant of xfs_rw_ilock.
Signed-off-by: Christoph Hellwig
---
fs/xfs/xfs_file.c | 32 +++-
1 file changed, 27 insertions(+), 5
this code.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
Reviewed-by: Jeff Moyer
Acked-by: Sage Weil
---
fs/ceph/file.c | 2 ++
fs/cifs/file.c | 6 ++
fs/nfs/file.c | 5 -
fs/ocfs2/file.c| 6 ++
fs/pipe.c | 3 ++-
fs/read_write.c| 44
of fallocate. It has been switched to use an open coded variant
instead.
Signed-off-by: Christoph Hellwig
[Small change in generic_write_sync() suggested by Anton Altaparmakov]
Signed-off-by: Milosz Tanski
Acked-by: Steven Whitehouse
Acked-by: Anton Altaparmakov
Reviewed-by: Jan Kara
New syscalls that take an flag argument. This change does not add any specific
flags.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
---
fs/read_write.c | 172 ++
include/linux/compat.h| 6 ++
include/linux
return 0;
}
EOF
Signed-off-by: Christoph Hellwig
[mil...@adfin.com: comapt syscall changes for RWF_ODSYNC]
Signed-off-by: Milosz Tanski
Reviewed-by: Jeff Moyer
Acked-by: Sage Weil
---
fs/ceph/file.c | 4 +++-
fs/fuse/file.c | 2 ++
fs/nfs/file.c | 10 ++
Plumbing the flags argument through the vfs code so they can be passed down to
__generic_file_(read/write)_iter function that do the acctual work.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
Reviewed-by: Jeff Moyer
---
drivers/target/target_core_file.c | 6 +++---
fs/nfsd
...@lst.de
[mil...@adfin.com: comapt syscall changes for RWF_ODSYNC]
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Jeff Moyer jmo...@redhat.com
Acked-by: Sage Weil s...@redhat.com
---
fs/ceph/file.c | 4 +++-
fs/fuse/file.c | 2 ++
fs/nfs/file.c | 10 ++
fs/ocfs2
Plumbing the flags argument through the vfs code so they can be passed down to
__generic_file_(read/write)_iter function that do the acctual work.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jeff Moyer jmo...@redhat.com
---
drivers/target
New syscalls that take an flag argument. This change does not add any specific
flags.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
fs/read_write.c | 172 ++
include/linux/compat.h
version
of fallocate. It has been switched to use an open coded variant
instead.
Signed-off-by: Christoph Hellwig h...@lst.de
[Small change in generic_write_sync() suggested by Anton Altaparmakov]
Signed-off-by: Milosz Tanski mil...@adfin.com
Acked-by: Steven Whitehouse swhit...@redhat.com
this code.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
Reviewed-by: Jeff Moyer jmo...@redhat.com
Acked-by: Sage Weil s...@redhat.com
---
fs/ceph/file.c | 2 ++
fs/cifs/file.c | 6 ++
fs/nfs/file.c | 5 -
fs/ocfs2/file.c| 6
From: Christoph Hellwig h...@lst.de
Add support for non-blocking reads. The guts are handled by the generic
code, the only addition is a non-blocking variant of xfs_rw_ilock.
Signed-off-by: Christoph Hellwig h...@lst.de
---
fs/xfs/xfs_file.c | 32 +++-
1 file
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
---
arch/x86/syscalls/syscall_32.tbl | 2 ++
arch/x86/syscalls/syscall_64.tbl | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
index
(old) code paths.
I have co-developed these changes with Christoph Hellwig.
Christoph Hellwig (3):
xfs: add RWF_NONBLOCK support
fs: pass iocb to generic_write_sync
fs: add a flag for per-operation O_DSYNC semantics
Milosz Tanski (4):
vfs: Prepare for adding a new preadv/pwritev with user
ple of nanoseconds.
>
> Actually I'd probably write:
>
>if (type == READ && (flags & RWF_NONBLOCK))
> return -EAGAIN;
>
>if (type == WRITE && (flags & RWF_DSYNC))
> return -EINVAL;
>
> (no 'else
On Thu, Nov 6, 2014 at 6:25 PM, Jeff Moyer wrote:
> Milosz Tanski writes:
>
>> New syscalls that take an flag argument. This change does not add any
>> specific
>> flags.
>>
>> Signed-off-by: Milosz Tanski
>> Reviewed-by: Christoph Hellwig
>>
On Thu, Nov 6, 2014 at 6:25 PM, Jeff Moyer jmo...@redhat.com wrote:
Milosz Tanski mil...@adfin.com writes:
New syscalls that take an flag argument. This change does not add any
specific
flags.
Signed-off-by: Milosz Tanski mil...@adfin.com
Reviewed-by: Christoph Hellwig h...@lst.de
== WRITE (flags RWF_DSYNC))
return -EINVAL;
(no 'else' since the code will never be reached if the first test is
true).
--
Roger Willcocks ro...@filmlight.ltd.uk
This is what I changed it to (and will be sending that out for the
next version).
--
Milosz Tanski
CTO
16 East 34th
The pull request for these changes is at:
https://bitbucket.org/adfin/linux-fs.git read_call_6
I've updated it so far with various Ack-by from different maintainers
(and a small stylistic fix).
On Wed, Nov 5, 2014 at 4:14 PM, Milosz Tanski wrote:
> This patcheset introduces an abil
On Thu, Nov 6, 2014 at 5:52 AM, Anton Altaparmakov wrote:
> Hi,
>
>> On 5 Nov 2014, at 23:14, Milosz Tanski wrote:
>>
>> From: Christoph Hellwig
>>
>> Clean up the generic_write_sync by just passing an iocb and a bytes
>> written / negative e
On Thu, Nov 6, 2014 at 2:56 AM, Christoph Hellwig wrote:
> This series looks good, do you also have a man page sniplet to document
> the new syscalls?
>
I just send out the two patches for the man pages, ran out of time
yesterday to update it for RWF_ODSYNC.
--
Milosz Tanski
CTO
16
Document RWF_ODSYNC flag for pwritev2 as implemented by Christoph Hellwig.
Signed-off-by: Milosz Tanski
---
man2/readv.2 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man2/readv.2 b/man2/readv.2
index 31b3870..ff1405c 100644
--- a/man2/readv.2
+++ b/man2/readv.2
@@ -203,6
New syscalls that are a variation on the preadv/pwritev but support an extra
flag argument.
Signed-off-by: Milosz Tanski
Suggested-by: Jeff Moyer
Fixes: Jeff Moyer
---
man2/readv.2 | 71 +++-
1 file changed, 61 insertions(+), 10
New syscalls that are a variation on the preadv/pwritev but support an extra
flag argument.
Signed-off-by: Milosz Tanski mil...@adfin.com
Suggested-by: Jeff Moyer jmo...@redhat.com
Fixes: Jeff Moyer jmo...@redhat.com
---
man2/readv.2 | 71
Document RWF_ODSYNC flag for pwritev2 as implemented by Christoph Hellwig.
Signed-off-by: Milosz Tanski mil...@adfin.com
---
man2/readv.2 | 10 ++
1 file changed, 10 insertions(+)
diff --git a/man2/readv.2 b/man2/readv.2
index 31b3870..ff1405c 100644
--- a/man2/readv.2
+++ b/man2/readv
On Thu, Nov 6, 2014 at 2:56 AM, Christoph Hellwig h...@infradead.org wrote:
This series looks good, do you also have a man page sniplet to document
the new syscalls?
I just send out the two patches for the man pages, ran out of time
yesterday to update it for RWF_ODSYNC.
--
Milosz Tanski
CTO
On Thu, Nov 6, 2014 at 5:52 AM, Anton Altaparmakov ai...@cam.ac.uk wrote:
Hi,
On 5 Nov 2014, at 23:14, Milosz Tanski mil...@adfin.com wrote:
From: Christoph Hellwig h...@lst.de
Clean up the generic_write_sync by just passing an iocb and a bytes
written / negative errno argument
The pull request for these changes is at:
https://bitbucket.org/adfin/linux-fs.git read_call_6
I've updated it so far with various Ack-by from different maintainers
(and a small stylistic fix).
On Wed, Nov 5, 2014 at 4:14 PM, Milosz Tanski mil...@adfin.com wrote:
This patcheset introduces
Plumbing the flags argument through the vfs code so they can be passed down to
__generic_file_(read/write)_iter function that do the acctual work.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
Reviewed-by: Jeff Moyer
---
drivers/target/target_core_file.c | 6 +++---
fs/nfsd
From: Christoph Hellwig
Add support for non-blocking reads. The guts are handled by the generic
code, the only addition is a non-blocking variant of xfs_rw_ilock.
Signed-off-by: Christoph Hellwig
---
fs/xfs/xfs_file.c | 32 +++-
1 file changed, 27 insertions(+), 5
this code.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
Reviewed-by: Jeff Moyer
---
fs/ceph/file.c | 2 ++
fs/cifs/file.c | 6 ++
fs/nfs/file.c | 5 -
fs/ocfs2/file.c| 6 ++
fs/pipe.c | 3 ++-
fs/read_write.c| 38
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
---
arch/x86/syscalls/syscall_32.tbl | 2 ++
arch/x86/syscalls/syscall_64.tbl | 2 ++
2 files changed, 4 insertions(+)
diff --git a/arch/x86/syscalls/syscall_32.tbl b/arch/x86/syscalls/syscall_32.tbl
index 9fe1b5d..d592d87 100644
return 0;
}
EOF
Signed-off-by: Christoph Hellwig
[mil...@adfin.com: added flag check to compat_do_readv_writev()]
Signed-off-by: Milosz Tanski
---
fs/ceph/file.c | 4 +++-
fs/fuse/file.c | 2 ++
fs/nfs/file.c | 10 ++
fs/ocfs2/file.c| 6 --
fs/read_writ
New syscalls that take an flag argument. This change does not add any specific
flags.
Signed-off-by: Milosz Tanski
Reviewed-by: Christoph Hellwig
---
fs/read_write.c | 176 ++
include/linux/compat.h| 6 ++
include/linux
From: Christoph Hellwig
Clean up the generic_write_sync by just passing an iocb and a bytes
written / negative errno argument. In addition to simplifying the
callers this also prepares for passing a per-operation O_DSYNC
flag. Two callers didn't quite fit that scheme:
- dio_complete didn't
ths.
I have co-developed these changes with Christoph Hellwig.
Christoph Hellwig (3):
xfs: add RWF_NONBLOCK support
fs: pass iocb to generic_write_sync
fs: add a flag for per-operation O_DSYNC semantics
Milosz Tanski (4):
vfs: Prepare for adding a new preadv/pwritev with user flags.
vf
1 - 100 of 330 matches
Mail list logo
