Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-20 Thread Min Guo
On Fri, 2020-11-20 at 09:36 +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 03:42:06PM +0800, Min Guo wrote: > > On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > > > On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > > > > Hi greg k

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-19 Thread Min Guo
On Fri, 2020-11-20 at 07:54 +0100, Greg Kroah-Hartman wrote: > On Fri, Nov 20, 2020 at 02:48:50PM +0800, Min Guo wrote: > > Hi greg k-h: > > On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > > > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min@mediatek.com

Re: [PATCH] usb: musb: remove unused variable 'devctl'

2020-11-19 Thread Min Guo
Hi greg k-h: On Wed, 2020-11-18 at 12:48 +0100, Greg Kroah-Hartman wrote: > On Tue, Nov 17, 2020 at 04:21:25PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > Remove unused 'devctl' variable to fix compile warnings: > > > > drivers/

Re: [PATCH] usb: musb: mediatek: add reset FADDR to zero in reset interrupt handle

2020-05-14 Thread Min Guo
On Thu, 2020-05-14 at 12:01 +0800, Macpaul Lin wrote: > When receiving reset interrupt, FADDR need to be reset to zero in > periphearl mode. Otherwise ep0 cannot do enumeration when re-pluging USB > cable. > > Signed-off-by: Macpaul Lin > --- > drivers/usb/musb/mediatek.c |6 ++ > 1

Re: [PATCH v8 6/6] usb: musb: Add support for MediaTek musb controller

2019-10-18 Thread Min Guo
Hi, On Thu, 2019-10-17 at 09:34 -0700, Tony Lindgren wrote: > Hi, > > Just few comments for future changes that might help below. > > * min@mediatek.com [191017 09:42]: > > --- /dev/null > > +++ b/drivers/usb/musb/mediatek.c > > +static int musb_usb_role_sx_set(struct device *dev, enum

Re: [PATCH RESEND v7 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-10-17 Thread Min Guo
On Thu, 2019-10-17 at 09:08 -0500, Rob Herring wrote: > On Thu, 17 Oct 2019 16:25:49 +0800, wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > > > > Signed-off-by: Min Guo > > --

Re: [PATCH v6 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-07-09 Thread Min Guo
Hi Rob, On Mon, 2019-07-08 at 16:30 -0600, Rob Herring wrote: > On Tue, Jun 04, 2019 at 07:39:14PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. >

Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-03-04 Thread Min Guo
Hi Rob, On Mon, 2019-03-04 at 11:42 -0600, Rob Herring wrote: > On Sun, Feb 24, 2019 at 7:36 PM Min Guo wrote: > > > > Hi Rob, > > On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > > > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min@mediatek.co

Re: [PATCH v5 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-02-24 Thread Min Guo
Hi Rob, On Fri, 2019-02-22 at 10:49 -0600, Rob Herring wrote: > On Tue, Feb 19, 2019 at 03:36:30PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. >

Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-02-14 Thread Min Guo
compatible = "usb-b-connector"; label = "micro-USB"; type = "micro"; extcon = <_usb>; vbus-supply = <_vbus>; }; }; Regards, Min. On Fri, 2019-01-25 at 10:07 +0800, Min Guo wrote: > Hi Bin, > > Thanks for your help

Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-24 Thread Min Guo
; port { connector_to_usb: endpoint { remote-endpoint = <_to_connector>; }; }; } Can I describe usb-connector like this? Or can you give me some advices? Regards, Min. On Tue, 2019-01-22 at 08:33 -0600, Bin Liu wrote: > Hi Min, > > On Tue, Jan 22

Re: [PATCH v4 1/6] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-22 Thread Min Guo
, is it possible to emulate an usb-connector driver by extcon-usb-gpio, and also use the notifier mechanism or can you give me some advices? Hi Rob, On Mon, 2019-01-21 at 09:14 -0600, Rob Herring wrote: > On Mon, Jan 21, 2019 at 08:22:26PM +0800, min@mediatek.com wrote: > > From

Re: [PATCH v4 6/6] usb: musb: Add support for MediaTek musb controller

2019-01-21 Thread Min Guo
Hi Bin, On Mon, 2019-01-21 at 10:07 -0600, Bin Liu wrote: > Hi Min, > > On Mon, Jan 21, 2019 at 08:22:31PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode. > >

Re: [PATCH v4 5/6] usb: musb: Add musb_clearb/w() interface

2019-01-21 Thread Min Guo
Hi Bin, On Mon, 2019-01-21 at 09:59 -0600, Bin Liu wrote: > Hi Min, > > On Mon, Jan 21, 2019 at 08:22:30PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > Delete the const attribute of addr parameter in readb/w/l hooks, these > > changes are for im

Re: [PATCH v3 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Min Guo
On Thu, 2019-01-17 at 06:33 -0800, Tony Lindgren wrote: > Hi, > > * min@mediatek.com [190117 07:16]: > > There are some quirk of MediaTek musb controller, such as: > > -W1C interrupt status registers > > -Private data toggle registers > > -No dedicated DMA interrupt line > > Can you

Re: [PATCH v3 0/4] Add MediaTek MUSB Controller Driver

2019-01-17 Thread Min Guo
Hi Bin, On Thu, 2019-01-17 at 09:00 -0600, Bin Liu wrote: > On Thu, Jan 17, 2019 at 03:15:44PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > These patches introduce the MediaTek MUSB controller driver. > > > > The driver can be co

Re: [PATCH v3 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-17 Thread Min Guo
Hello! On Thu, 2019-01-17 at 14:06 +0300, Sergei Shtylyov wrote: > Hello! > > On 01/17/2019 10:15 AM, min@mediatek.com wrote: > > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg m

Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-16 Thread Min Guo
On Wed, 2019-01-16 at 07:59 -0600, Bin Liu wrote: > On Wed, Jan 16, 2019 at 05:39:02PM +0800, Min Guo wrote: > > Hi Bin, > > > > On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > > > Hi Min, > > > > > > very close, thanks. > > > Be

Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-16 Thread Min Guo
Hi Bin, On Tue, 2019-01-15 at 14:38 -0600, Bin Liu wrote: > Hi Min, > > very close, thanks. > Below I tried to explain a further cleanup in musb_clearb/w() and > musb_get/set_toggle() implementation. Please let me know if it is not > clear. > > Basically, we don't need musb_default_clearb/w(),

Re: [PATCH v2 3/4] usb: musb: Extract set toggle as a separate interface

2019-01-15 Thread Min Guo
Hi Bin, On Tue, 2019-01-15 at 14:40 -0600, Bin Liu wrote: > Hi Min, > > On Tue, Jan 15, 2019 at 04:19:42PM +0100, Matthias Brugger wrote: > > > > > > On 15/01/2019 02:43, min@mediatek.com wrote: > > > From: Min Guo > > > >

Re: [PATCH v2 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-15 Thread Min Guo
ed musb_default_clearb/w(), just assign the > musb_io function pointers to musb_readb/w(). > > Then the mtk platform musb_clearb/w() calls musb_readb/w() and > musb_writeb/w() to handle W1C. Okay. > On Tue, Jan 15, 2019 at 09:43:46AM +0800, min....@mediatek.com wrote: > &

Re: [PATCH v2 3/4] usb: musb: Extract set toggle as a separate interface

2019-01-15 Thread Min Guo
Hi Matthias, On Tue, 2019-01-15 at 16:19 +0100, Matthias Brugger wrote: > > On 15/01/2019 02:43, min@mediatek.com wrote: > > From: Min Guo > > > > Add a common interface for set data toggle > > > > Signed-off-by: Min Guo > >

Re: [PATCH 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-10 Thread Min Guo
> On Thu, Dec 27, 2018 at 03:34:26PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode > > > > diff --git a/drivers/usb/musb/musbhsdma.c b/drivers/usb/mu

Re: [PATCH 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-10 Thread Min Guo
an quickly understand the core driver is modified > accordingly to handle the differences. Okay, tkanks. > On Thu, Jan 10, 2019 at 03:24:22PM +0800, Min Guo wrote: > > Hi Bin, > > [snip] > > > > > > > + musb_writeb(mbase, MUSB_IN

Re: [PATCH 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-09 Thread Min Guo
Hi Bin, On Wed, 2019-01-09 at 08:01 -0600, Bin Liu wrote: > Hi Min, > > On Wed, Jan 09, 2019 at 08:31:08PM +0800, Min Guo wrote: > > Hi Bin, > > On Tue, 2019-01-08 at 09:44 -0600, Bin Liu wrote: > > > Hi, > > > > > > On Thu, Dec 27, 2018

Re: [PATCH 4/4] usb: musb: Add support for MediaTek musb controller

2019-01-09 Thread Min Guo
Hi Bin, On Tue, 2019-01-08 at 09:44 -0600, Bin Liu wrote: > Hi, > > On Thu, Dec 27, 2018 at 03:34:26PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode > > >

Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-07 Thread Min Guo
On Mon, 2019-01-07 at 14:40 -0600, Bin Liu wrote: > Hi, > > On Thu, Dec 27, 2018 at 03:34:23PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mod

Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-06 Thread Min Guo
On Fri, 2019-01-04 at 10:10 -0600, Rob Herring wrote: > On Thu, Jan 3, 2019 at 9:00 PM Min Guo wrote: > > > > On Thu, 2019-01-03 at 16:14 -0600, Rob Herring wrote: > > > On Thu, Dec 27, 2018 at 03:34:23PM +0800, min@mediatek.com wrote: > > > > From: Min Gu

Re: [PATCH 1/4] dt-bindings: usb: musb: Add support for MediaTek musb controller

2019-01-03 Thread Min Guo
On Thu, 2019-01-03 at 16:14 -0600, Rob Herring wrote: > On Thu, Dec 27, 2018 at 03:34:23PM +0800, min@mediatek.com wrote: > > From: Min Guo > > > > This adds support for MediaTek musb controller in > > host, peripheral and otg mode > > > > Signed-off-b