Re: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability

2020-12-01 Thread Moritz Fischer
Hi Matthew, On Mon, Nov 30, 2020 at 04:45:20PM -0800, matthew.gerl...@linux.intel.com wrote: > > > On Sat, 28 Nov 2020, Wu, Hao wrote: > > > > Subject: [PATCH v3 2/2] fpga: dfl: look for vendor specific capability > > > > Maybe we can change the title a little bit, what about > > fpga:

Re: [PATCH Xilinx Alveo 1/8] Documentation: fpga: Add a document describing Alveo XRT drivers

2020-11-30 Thread Moritz Fischer
On Sat, Nov 28, 2020 at 04:00:33PM -0800, Sonal Santan wrote: > From: Sonal Santan > > Describe Alveo XRT driver architecture and provide basic overview > of Xilinx Alveo platform. > > Signed-off-by: Sonal Santan > --- > Documentation/fpga/index.rst | 1 + > Documentation/fpga/xrt.rst |

Re: [PATCHv2 1/5] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag

2020-11-30 Thread Moritz Fischer
Hi Richard, On Mon, Nov 30, 2020 at 12:55:44PM -0600, Richard Gong wrote: > > Hi Moritz, > > Sorry for late reply, I was out last week. No worries, usually I'm late with replies ;-) > > On 11/21/20 7:10 PM, Moritz Fischer wrote: > > Richard, > > > > On W

Re: [PATCH Xilinx Alveo 2/8] fpga: xrt: Add UAPI header files

2020-11-30 Thread Moritz Fischer
Hi Sonal, On Sat, Nov 28, 2020 at 04:00:34PM -0800, Sonal Santan wrote: > From: Sonal Santan > > Add XRT UAPI header files which describe flash layout, XRT > mailbox protocol, xclBin/axlf FPGA image container format and > XRT management physical function driver ioctl interfaces. > >

Re: [PATCH v2 2/2] fpga: dfl: look for vendor specific capability

2020-11-21 Thread Moritz Fischer
Hi Matthew, On Wed, Nov 18, 2020 at 11:01:51AM -0800, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach > > A DFL may not begin at offset 0 of BAR 0. A PCIe vendor > specific capability can be used to specify the start of a > number of DFLs. > > Signed-off-by: Matthew Gerlach >

Re: [PATCHv2 1/5] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag

2020-11-21 Thread Moritz Fischer
Richard, On Wed, Nov 18, 2020 at 12:16:09PM -0600, Richard Gong wrote: > > > -#define COMMAND_RECONFIG_FLAG_PARTIAL1 > > > +#define COMMAND_RECONFIG_FLAG_PARTIAL0 > > > +#define COMMAND_AUTHENTICATE_BITSTREAM 1 > > > > Can you explain how this commit by itself doesn't break things? >

Re: [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-21 Thread Moritz Fischer
On Fri, Nov 20, 2020 at 03:46:48PM -0800, David Gow wrote: > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > functions, it should depend on HAS_IOMEM. > > This fixes make allyesconfig under UML (ARCH=um), which doesn't

Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-20 Thread Moritz Fischer
Hi David, On Fri, Nov 20, 2020 at 03:40:13PM +0800, Xu Yilun wrote: > On Fri, Nov 20, 2020 at 03:30:35PM +0800, David Gow wrote: > > On Fri, Nov 20, 2020 at 2:27 PM Moritz Fischer wrote: > > > > > > Hi David, > > > > > > On Thu, Nov 19, 2020 at 12:22

Re: [PATCH] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL

2020-11-19 Thread Moritz Fischer
Hi David, On Thu, Nov 19, 2020 at 12:22:09AM -0800, David Gow wrote: > Because dfl.c uses the 'devm_ioremap', 'devm_iounmap', > 'devm_ioremap_resource', and 'devm_platform_ioremap_resource' > functions, it should depend on HAS_IOMEM. > > This fixes make allyesconfig under UML (ARCH=um), which

Re: [PATCH v6 1/7] fpga: sec-mgr: fpga security manager class driver

2020-11-19 Thread Moritz Fischer
Hi Russ, On Thu, Nov 19, 2020 at 06:39:44PM -0800, Russ Weight wrote: > > > On 11/15/20 3:03 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Thu, Nov 05, 2020 at 05:08:59PM -0800, Russ Weight wrote: > >> Create the FPGA Security Manager class driver

Re: [PATCHv2 1/5] firmware: stratix10-svc: add COMMAND_AUTHENTICATE_BITSTREAM flag

2020-11-18 Thread Moritz Fischer
On Wed, Nov 18, 2020 at 08:29:09AM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add COMMAND_AUTHENTICATE_BITSTREAM command flag for new added bitstream > authentication feature. Authenticating a bistream is to make sure a signed > bitstream has the valid signatures. > >

Re: linux-next: Signed-off-by missing for commit in the fpga tree

2020-11-15 Thread Moritz Fischer
On Mon, Nov 16, 2020 at 09:52:40AM +1100, Stephen Rothwell wrote: > Hi all, > > Commits > > aaf8fe39c952 ("Revert "fpga: dfl: fix the definitions of type & feature_id > for dfl devices"") > 9922e71f43ac ("Revert "fpga: dfl: move dfl_device_id to mod_devicetable.h"") > 3ae706b58b0b

Re: [PATCH v6 1/7] fpga: sec-mgr: fpga security manager class driver

2020-11-15 Thread Moritz Fischer
Hi Russ, On Thu, Nov 05, 2020 at 05:08:59PM -0800, Russ Weight wrote: > Create the FPGA Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry

Re: [PATCH v5 3/6] fpga: m10bmc-sec: expose max10 flash update count

2020-11-15 Thread Moritz Fischer
On Fri, Nov 13, 2020 at 04:55:56PM -0800, Russ Weight wrote: > Extend the MAX10 BMC Secure Update driver to provide a > sysfs file to expose the flash update count for the FPGA > user image. > > Signed-off-by: Russ Weight > Reviewed-by: Tom Rix > --- > v5: > - Renamed sysfs node

[RESEND PATCH 07/10] fpga: fpga-mgr: ts73xx: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/ts73xx-fpga.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c index

[RESEND PATCH 06/10] fpga: fpga-mgr: socfpga: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/socfpga.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 4a8a2fcd4e6c

[RESEND PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration by using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c

[RESEND PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/dfl-fme-mgr.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c index

[RESEND PATCH 04/10] fpga: fpga-mgr: ice40-spi: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/ice40-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c index

[RESEND PATCH 05/10] fpga: fpga-mgr: machxo2-spi: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/machxo2-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index

[RESEND PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/altera-pr-ip-core-plat.c | 10 -- drivers/fpga/altera-pr-ip-core.c | 4 +--- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers

[RESEND PATCH 09/10] fpga: fpga-mgr: zynqmp: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/zynqmp-fpga.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c

[RESEND PATCH 08/10] fpga: fpga-mgr: xilinx-spi: Simplify registration

2020-11-15 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/xilinx-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c index

[RESEND PATCH 00/10] Introduce devm_fpga_mgr_register()

2020-11-15 Thread Moritz Fischer
This patchset introduces the devm_fpga_mgr_register API, a devres managed version of fpga_mgr_register(). It reduces boilerplate being repeated literally in every single driver by moving it to the fpga-mgr core. Moritz Fischer (10): fpga: fpga-mgr: Add devm_fpga_mgr_register() API fpga: fpga

[RESEND PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API

2020-11-15 Thread Moritz Fischer
(). Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/fpga-mgr.c | 81 +-- include/linux/fpga/fpga-mgr.h | 2 + 2 files changed, 71 insertions(+), 12 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index f38bab01432e

Re: [PATCHv1 3/4] dt-bindings: fpga: add authenticate-fpga-config property

2020-11-15 Thread Moritz Fischer
Hi Richard, On Thu, Nov 12, 2020 at 12:06:42PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Add authenticate-fpga-config property for FPGA bitstream authentication. > > Signed-off-by: Richard Gong > --- > Documentation/devicetree/bindings/fpga/fpga-region.txt | 1 + >

Re: [PATCHv1 4/4] fpga: stratix10-soc: entend driver for bitstream authentication

2020-11-15 Thread Moritz Fischer
On Thu, Nov 12, 2020 at 12:06:43PM -0600, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Exten FPGA manager driver to support FPGA bitstream authentication on Nit: Extend > Intel SocFPGA platforms. > > Signed-off-by: Richard Gong > --- > drivers/fpga/stratix10-soc.c | 5 - >

Re: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-29 Thread Moritz Fischer
Hi Russ, On Wed, Oct 28, 2020 at 11:37:46AM -0700, Russ Weight wrote: > > > On 10/27/20 7:41 PM, Wu, Hao wrote: > >> On 10/25/20 7:29 PM, Wu, Hao wrote: > Subject: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class > driver > > Create the FPGA Security Manager

Re: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-29 Thread Moritz Fischer
Hi Russ, On Mon, Oct 26, 2020 at 04:00:40PM -0700, Russ Weight wrote: > > > On 10/25/20 12:12 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Tue, Oct 20, 2020 at 05:31:12PM -0700, Russ Weight wrote: > >> I see that I need to remove "intel" from

[PATCH net-next v4] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-28 Thread Moritz Fischer
] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 Signed-off-by: Moritz Fischer --- Changes from v3: - Added

Re: [PATCH/RFC net-next v3] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-28 Thread Moritz Fischer
Hi Jakub, On Tue, Oct 27, 2020 at 04:16:06PM -0700, Jakub Kicinski wrote: > On Fri, 23 Oct 2020 13:28:34 -0700 Moritz Fischer wrote: > > diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c > > b/drivers/net/ethernet/dec/tulip/de2104x.c > > index d9f6c19940ef

Re: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-26 Thread Moritz Fischer
Hi Tom, On Mon, Oct 26, 2020 at 07:23:37AM -0700, Tom Rix wrote: > > On 10/25/20 7:29 PM, Wu, Hao wrote: > >> Subject: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class > >> driver > >> > >> Create the FPGA Security Manager class driver. The security > >> manager provides

Re: [PATCH v5 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-25 Thread Moritz Fischer
Hi Russ, On Tue, Oct 20, 2020 at 05:31:12PM -0700, Russ Weight wrote: > I see that I need to remove "intel" from the subject line on this patch. > I'll take care of that. > > I still have an outstanding question about treating a class-driver as a > managed resource of the parent device. I'm

[PATCH/RFC net-next v3] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-23 Thread Moritz Fischer
] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 Signed-off-by: Moritz Fischer --- I'd consider it a bug-fix

[PATCH/RFC net v2] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread Moritz Fischer
] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 Signed-off-by: Moritz Fischer --- Changes from v1: - Replace

Re: [PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread Moritz Fischer
On Thu, Oct 22, 2020 at 04:04:16PM -0700, James Bottomley wrote: > On Thu, 2020-10-22 at 15:06 -0700, Moritz Fischer wrote: > > The driver does not implement a shutdown handler which leads to > > issues > > when using kexec in certain scenarios. The NIC keeps on fetching >

[PATCH/RFC net] net: dec: tulip: de2104x: Add shutdown handler to stop NIC

2020-10-22 Thread Moritz Fischer
] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 DMAR: DMAR:[DMA read] Request device [5e:00.0]fault addr f000 Signed-off-by: Moritz Fischer --- Hi all, I'm not sure

Re: [PATCH v10 0/6] add DFL bus support to MODULE_DEVICE_TABLE()

2020-10-15 Thread Moritz Fischer
Hi Xu, On Thu, Oct 15, 2020 at 03:16:27PM +0800, Xu Yilun wrote: > Patch #1 is a fix of the fields in struct dfl_device & dfl_device_id. > > Patch #2, 3, 4 add dfl bus support to MODULE_DEVICE_TABLE(), they also > move the necessary definitions in head file to public folders so that > scatter

Re: [PATCH v9 6/6] memory: dfl-emif: add the DFL EMIF private feature driver

2020-10-12 Thread Moritz Fischer
Hi Krzysztof, On Mon, Oct 12, 2020 at 06:40:46PM +0200, Krzysztof Kozlowski wrote: > On Sat, 10 Oct 2020 at 09:15, Xu Yilun wrote: > > > > This driver is for the EMIF private feature implemented under FPGA > > Device Feature List (DFL) framework. It is used to expose memory > > interface status

Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"

2020-10-09 Thread Moritz Fischer
Hi Xu, On Fri, Oct 09, 2020 at 03:34:24PM +0800, Xu Yilun wrote: > On Fri, Oct 09, 2020 at 08:41:18AM +0200, Greg KH wrote: > > On Fri, Oct 09, 2020 at 02:20:59PM +0800, Xu Yilun wrote: > > > Hi Greg: > > > > > > On Mon, Sep 28, 2020 at 09:19:00PM -0700,

Re: [PATCH v2 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API

2020-10-09 Thread Moritz Fischer
On Mon, Oct 05, 2020 at 10:37:26AM -0700, Moritz Fischer wrote: > Add a devm_fpga_mgr_register() API that can be used to register a FPGA > Manager that was created using devm_fpga_mgr_create(). > > Introduce a struct fpga_mgr_devres that makes the devres > allocation a little bi

Re: [PATCH v3 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-07 Thread Moritz Fischer
On Wed, Oct 07, 2020 at 09:43:24AM -0700, Russ Weight wrote: > > > On 10/7/20 7:44 AM, Moritz Fischer wrote: > > Hi Russ, > > > > On Tue, Oct 06, 2020 at 05:09:58PM -0700, Russ Weight wrote: > >> Create the Intel Security Manager class driver. The secur

Re: [PATCH v3 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-07 Thread Moritz Fischer
Hi Russ, On Tue, Oct 06, 2020 at 05:09:58PM -0700, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry

[PATCH v2 00/10] Introduce devm_fpga_mgr_register()

2020-10-05 Thread Moritz Fischer
yle - use fpga_mgr_devres consistently - Addressed Tom's feedback - err -> ret - removed removal of deprecated API - added Reviewed-by: tags Moritz Fischer (10): fpga: fpga-mgr: Add devm_fpga_mgr_register() API fpga: fpga-mgr: altera-ps-spi: Simplify registration fpga: fpga-mgr: d

[no subject]

2020-10-05 Thread Moritz Fischer
: - Addressed Hao's feedback - priv -> res - comment style - use fpga_mgr_devres consistently - Addressed Tom's feedback - err -> ret - removed removal of deprecated API - added Reviewed-by: tags Moritz Fischer (10): fpga: fpga-mgr: Add devm_fpga_mgr_register() API fpga: fp

[PATCH v2 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API

2020-10-05 Thread Moritz Fischer
(). Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/fpga-mgr.c | 81 +-- include/linux/fpga/fpga-mgr.h | 2 + 2 files changed, 71 insertions(+), 12 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index f38bab01432e

[PATCH v2 04/10] fpga: fpga-mgr: ice40-spi: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/ice40-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c index

[PATCH v2 06/10] fpga: fpga-mgr: socfpga: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/socfpga.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 4a8a2fcd4e6c

[PATCH v2 05/10] fpga: fpga-mgr: machxo2-spi: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/machxo2-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index

[PATCH v2 07/10] fpga: fpga-mgr: ts73xx: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/ts73xx-fpga.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c index

[PATCH v2 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration by using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c

[PATCH v2 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/dfl-fme-mgr.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c index

[PATCH v2 08/10] fpga: fpga-mgr: xilinx-spi: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/xilinx-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c index

[PATCH v2 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- Changes from v1: - Removed part that removes unused symbol --- drivers/fpga/altera-pr-ip-core-plat.c | 10 -- drivers/fpga/altera-pr-ip-core.c | 4 +--- 2 files changed, 1 insertion

[PATCH v2 09/10] fpga: fpga-mgr: zynqmp: Simplify registration

2020-10-05 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Reviewed-by: Tom Rix Signed-off-by: Moritz Fischer --- drivers/fpga/zynqmp-fpga.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c

Re: [PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API

2020-10-05 Thread Moritz Fischer
ing devm_fpga_mgr_create(). > > > > Introduce a struct fpga_mgr_devres that makes the devres > > allocation a little bit more readable and gets reused for > > devm_fpga_mgr_create() devm_fpga_mgr_register(). > > > > Signed-off-by: Moritz Fischer > > --- > > drivers/fpg

Re: [PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration

2020-10-04 Thread Moritz Fischer
On Sun, Oct 04, 2020 at 11:47:26AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > Remove the now obsolete altera_pr_unregister() function. > > > > Signed-off-by: Moritz Fisc

Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration

2020-10-04 Thread Moritz Fischer
On Sun, Oct 04, 2020 at 11:22:31AM -0700, Tom Rix wrote: > > On 10/3/20 10:14 PM, Moritz Fischer wrote: > > Simplify registration using new devm_fpga_mgr_register() API. > > > > Signed-off-by: Moritz Fischer > > --- > > drivers/fpga/dfl-fme-mgr.c | 12

[PATCH 06/10] fpga: fpga-mgr: socfpga: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/socfpga.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 4a8a2fcd4e6c..1f467173fc1f 100644

[PATCH 10/10] fpga: fpga-mgr: altera-pr-ip: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Remove the now obsolete altera_pr_unregister() function. Signed-off-by: Moritz Fischer --- We should take another look at this, IIRC correctly the point of splitting this up into a separate driver was to make it useable

[PATCH 05/10] fpga: fpga-mgr: machxo2-spi: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/machxo2-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index b316369156fe..114a64d2b7a4

[PATCH 08/10] fpga: fpga-mgr: xilinx-spi: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/xilinx-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/xilinx-spi.c b/drivers/fpga/xilinx-spi.c index 824abbbd631e..27defa98092d

[PATCH 07/10] fpga: fpga-mgr: ts73xx: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/ts73xx-fpga.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/ts73xx-fpga.c b/drivers/fpga/ts73xx-fpga.c index 2888ff000e4d..101f016c6ed8

[PATCH 09/10] fpga: fpga-mgr: zynqmp: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/zynqmp-fpga.c | 21 + 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/fpga/zynqmp-fpga.c b/drivers/fpga/zynqmp-fpga.c index 4a1139e05280

[PATCH 02/10] fpga: fpga-mgr: altera-ps-spi: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration by using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/altera-ps-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/altera-ps-spi.c b/drivers/fpga/altera-ps-spi.c index 0221dee8dd4c

[PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/dfl-fme-mgr.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c index b3f7eee3c93f..3fc2be87d059

[PATCH 00/10] Introduce devm_fpga_mgr_register()

2020-10-03 Thread Moritz Fischer
This patchset introduces the devm_fpga_mgr_register API, a devres managed version of fpga_mgr_register(). It reduces boilerplate being repeated literally in every single driver by moving it to the fpga-mgr core. Moritz Fischer (10): fpga: fpga-mgr: Add devm_fpga_mgr_register() API fpga: fpga

[PATCH 01/10] fpga: fpga-mgr: Add devm_fpga_mgr_register() API

2020-10-03 Thread Moritz Fischer
-off-by: Moritz Fischer --- drivers/fpga/fpga-mgr.c | 76 ++- include/linux/fpga/fpga-mgr.h | 2 + 2 files changed, 68 insertions(+), 10 deletions(-) diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c index f38bab01432e..774ac98fb69c 100644

[PATCH 04/10] fpga: fpga-mgr: ice40-spi: Simplify registration

2020-10-03 Thread Moritz Fischer
Simplify registration using new devm_fpga_mgr_register() API. Signed-off-by: Moritz Fischer --- drivers/fpga/ice40-spi.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/fpga/ice40-spi.c b/drivers/fpga/ice40-spi.c index 8d689fea0dab..69dec5af23c3 100644

Re: [PATCH v2 1/7] fpga: sec-mgr: intel fpga security manager class driver

2020-10-02 Thread Moritz Fischer
Hi Russ, On Fri, Oct 02, 2020 at 04:03:59PM -0700, Russ Weight wrote: > Hi Moritz, > > This patch aligns with FPGA Manager implementation as you requested by > splitting up the create() and register() functions and adding a devm_ > version of the create() function. I have a question (below)

Re: [PATCH v4 5/7] clk: axi-clkgen: Respect ZYNQMP PFD/VCO frequency limits

2020-10-01 Thread Moritz Fischer
On Thu, Oct 01, 2020 at 08:18:59AM +0300, Alexandru Ardelean wrote: > On Wed, Sep 30, 2020 at 8:16 PM Moritz Fischer wrote: > > > > On Wed, Sep 30, 2020 at 08:22:23AM +0300, Alexandru Ardelean wrote: > > > On Tue, Sep 29, 2020 at 6:30 PM Moritz Fischer wrote: >

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-10-01 Thread Moritz Fischer
Hi Russ, On Wed, Sep 30, 2020 at 06:07:00PM -0700, Russ Weight wrote: > > Hi Moritz, > > On 9/30/20 5:31 PM, Moritz Fischer wrote: > > I think providing the devm_ managed APIs is nicer, and makes it easier > > for the consumer of the API to do the right thing. > >

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-30 Thread Moritz Fischer
Hi Russ, On Wed, Sep 30, 2020 at 01:54:50PM -0700, Russ Weight wrote: > > > On 9/16/20 1:16 PM, Moritz Fischer wrote: > > Hi Russ, > > > > On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > >> Create the Intel Security Manager class driver

Re: [PATCH v4 40/52] docs: fpga: replace :c:member: macros

2020-09-30 Thread Moritz Fischer
[error at 11] > fpga_region->get_bridges > ---^ > > Replace them by :c:expr:, with does what's desired. > > Signed-off-by: Mauro Carvalho Chehab Reviewed-by: Moritz Fischer > --- > Documentation/driver-api/fpga/fpga-mgr.rst | 2 +- > D

Re: [PATCH v4 5/7] clk: axi-clkgen: Respect ZYNQMP PFD/VCO frequency limits

2020-09-30 Thread Moritz Fischer
On Wed, Sep 30, 2020 at 08:22:23AM +0300, Alexandru Ardelean wrote: > On Tue, Sep 29, 2020 at 6:30 PM Moritz Fischer wrote: > > > > Hi Alexandru, > > > > On Tue, Sep 29, 2020 at 05:44:15PM +0300, Alexandru Ardelean wrote: > > > From: Mathias Tausen > >

Re: [PATCH v4 5/7] clk: axi-clkgen: Respect ZYNQMP PFD/VCO frequency limits

2020-09-29 Thread Moritz Fischer
Hi Alexandru, On Tue, Sep 29, 2020 at 05:44:15PM +0300, Alexandru Ardelean wrote: > From: Mathias Tausen > > Since axi-clkgen is now supported on ZYNQMP, make sure the max/min > frequencies of the PFD and VCO are respected. > > Signed-off-by: Mathias Tausen > Signed-off-by: Alexandru Ardelean

Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"

2020-09-28 Thread Moritz Fischer
PM +0800, Xu Yilun wrote: > > > > Hi Greg, > > > > > > > > On Sun, Sep 27, 2020 at 07:51:08AM +0200, Greg KH wrote: > > > > > On Sat, Sep 26, 2020 at 12:22:19PM -0700, Moritz Fischer wrote: > > > > > > Hi Greg, > > > >

Re: [PATCH v29 3/6] Add Aspeed SoC 24xx and 25xx families JTAG master driver

2020-09-27 Thread Moritz Fischer
Hi Ernesto, Oleksandr, On Mon, Apr 13, 2020 at 03:29:17PM -0700, Ernesto Corona wrote: > Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller. > > Driver implements the following jtag ops: > - freq_get; > - freq_set; > - status_get; > - status_set > - xfer; > - mode_set; > -

Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"

2020-09-26 Thread Moritz Fischer
> On Thu, Sep 24, 2020 at 10:27:00AM -0700, Moritz Fischer wrote: > > > Hi Xu, > > > > > > On Fri, Sep 25, 2020 at 12:59:57AM +0800, Xu Yilun wrote: > > > > Now the DFL device drivers could be made as independent modules and put > > > > in differen

Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"

2020-09-24 Thread Moritz Fischer
On Thu, Sep 24, 2020 at 12:01:55PM -0700, Tom Rix wrote: > > On 9/24/20 9:59 AM, Xu Yilun wrote: > > Now the DFL device drivers could be made as independent modules and put > > in different subsystems according to their functionalities. So the name > > should be descriptive and unique in the

Re: [PATCH v3 1/5] fpga: dfl: rename the bus type "dfl" to "fpga-dfl"

2020-09-24 Thread Moritz Fischer
Hi Xu, On Fri, Sep 25, 2020 at 12:59:57AM +0800, Xu Yilun wrote: > Now the DFL device drivers could be made as independent modules and put > in different subsystems according to their functionalities. So the name > should be descriptive and unique in the whole kernel. > > The patch changes the

Re: [PATCH v3 6/6] clk: axi-clkgen: Add support for FPGA info

2020-09-24 Thread Moritz Fischer
On Thu, Sep 24, 2020 at 09:50:12AM +0300, Alexandru Ardelean wrote: > From: Mircea Caprioru > > This patch adds support for vco maximum and minimum ranges in accordance > with fpga speed grade, voltage, device package, technology and family. This > new information is extracted from two new

Re: [PATCH v2 0/6] clk: axi-clk-gen: misc updates to the driver

2020-09-23 Thread Moritz Fischer
Hi Stephen, On Wed, Sep 23, 2020 at 04:58:33PM -0700, Stephen Boyd wrote: > Quoting Alexandru Ardelean (2020-09-22 23:22:33) > > On Tue, Sep 22, 2020 at 10:42 PM Stephen Boyd wrote: > > > > > > Quoting Moritz Fischer (2020-09-14 19:41:38) > > > > O

Re: [PATCH v3] memory: dfl-emif: add the DFL EMIF private feature driver

2020-09-21 Thread Moritz Fischer
Hi Krzysztof, On Mon, Sep 21, 2020 at 10:46:45PM +0200, Krzysztof Kozlowski wrote: > WhOn Mon, 21 Sep 2020 at 22:31, Moritz Fischer wrote: > > > > Hi Krzysztof, > > > > On Mon, Sep 21, 2020 at 09:23:11AM +0200, Krzysztof Kozlowski wrote: > > > On Mon, Sep 21

Re: [PATCH v3] memory: dfl-emif: add the DFL EMIF private feature driver

2020-09-21 Thread Moritz Fischer
Hi Krzysztof, On Mon, Sep 21, 2020 at 09:23:11AM +0200, Krzysztof Kozlowski wrote: > On Mon, Sep 21, 2020 at 01:31:20PM +0800, Xu Yilun wrote: > > This driver is for the EMIF private feature implemented under FPGA > > Device Feature List (DFL) framework. It is used to expose memory > > interface

Re: [PATCH v2 1/1] fpga: dfl: afu: harden port enable logic

2020-09-17 Thread Moritz Fischer
On Thu, Sep 17, 2020 at 01:28:22PM -0700, Tom Rix wrote: > > On 9/17/20 11:32 AM, Russ Weight wrote: > > Port enable is not complete until ACK = 0. Change > > __afu_port_enable() to guarantee that the enable process > > is complete by polling for ACK == 0. > > > > Signed-off-by: Russ Weight

Re: [PATCH v2 next] fpga: dfl: n3000-nios: Make m10_n3000_info static

2020-09-16 Thread Moritz Fischer
On Thu, Sep 17, 2020 at 10:12:40AM +0800, YueHaibing wrote: > Fix sparse warning: > > drivers/fpga/dfl-n3000-nios.c:392:23: warning: > symbol 'm10_n3000_info' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > drivers/fpga/dfl-n3000-nios.c | 2 +- > 1 file changed, 1

Re: [PATCH v1 02/12] fpga: create intel max10 bmc security engine

2020-09-16 Thread Moritz Fischer
Russ, On Fri, Sep 04, 2020 at 04:52:55PM -0700, Russ Weight wrote: > Create a platform driver that can be invoked as a sub > driver for the Intel MAX10 BMC in order to support > secure updates. This sub-driver will invoke an > instance of the Intel FPGA Security Manager class driver > in order to

Re: [PATCH -next] fpga: dfl: Make m10_n3000_info static

2020-09-16 Thread Moritz Fischer
Hi Yue, On Wed, Sep 16, 2020 at 10:25:36PM +0800, YueHaibing wrote: > Fix sparse warning: > > drivers/fpga/dfl-n3000-nios.c:392:23: warning: > symbol 'm10_n3000_info' was not declared. Should it be static? > > Signed-off-by: YueHaibing > --- > drivers/fpga/dfl-n3000-nios.c | 2 +- > 1 file

Re: [PATCH v1 01/12] fpga: fpga security manager class driver

2020-09-16 Thread Moritz Fischer
Hi Russ, On Fri, Sep 04, 2020 at 04:52:54PM -0700, Russ Weight wrote: > Create the Intel Security Manager class driver. The security > manager provides interfaces to manage secure updates for the > FPGA and BMC images that are stored in FLASH. The driver can > also be used to update root entry

Re: [PATCH v8 2/2] fpga: dfl: add support for N3000 Nios private feature

2020-09-15 Thread Moritz Fischer
On Mon, Sep 07, 2020 at 10:23:27PM +0800, Xu Yilun wrote: > This patch adds support for the Nios handshake private feature on Intel > PAC (Programmable Acceleration Card) N3000. > > The Nios is the embedded processor on the FPGA card. This private feature > provides a handshake interface to FPGA

Re: [PATCH v2 4/4] fpga: dfl: move dfl bus related APIs to include/linux/fpga/dfl.h

2020-09-15 Thread Moritz Fischer
On Tue, Sep 15, 2020 at 11:27:53AM +0800, Xu Yilun wrote: > The patch moves dfl-bus related APIs to include/linux/fpga/dfl.h > > Now the DFL device drivers could be made as independent modules and put > in different folders according to their functionality. In order for > scattered DFL device

Re: [PATCH v2 2/4] dfl: add dfl bus support to MODULE_DEVICE_TABLE()

2020-09-15 Thread Moritz Fischer
Hi Hao, Xu, On Tue, Sep 15, 2020 at 05:58:46AM +, Wu, Hao wrote: > > On Tue, Sep 15, 2020 at 12:08:38PM +0800, Wu, Hao wrote: > > > > On Tue, Sep 15, 2020 at 11:27:51AM +0800, Xu Yilun wrote: > > > > > Device Feature List (DFL) is a linked list of feature headers within > > > > > the > > > >

[PATCH net-next v2 3/3] net: dec: tulip: de2104x: Replace kmemdup() with devm_kmempdup()

2020-09-14 Thread Moritz Fischer
Replace an instance of kmemdup() with the devres counted version instead. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/dec/tulip/de2104x.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec

[PATCH net-next v2 2/3] net: dec: tulip: de2104x: Replace pci_enable_device with devres version

2020-09-14 Thread Moritz Fischer
Replace pci_enable_device() with its devres counterpart pcim_enable_device(). Signed-off-by: Moritz Fischer --- Note: Please check my logic on this, it would seem to me calling pci_disable_device() on devices enabled with pcim_enable_device() *should* be fine. Changes from v1: - Fixed missing

[PATCH net-next v2 1/3] net: dec: tulip: de2104x: Replace alloc_etherdev by devm_alloc_etherdev

2020-09-14 Thread Moritz Fischer
Replace devm_alloc_etherdev() with its devres version. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/dec/tulip/de2104x.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/dec/tulip/de2104x.c b/drivers/net/ethernet/dec/tulip/de2104x.c index

[PATCH net-next v2 0/3] First bunch of Tulip cleanups

2020-09-14 Thread Moritz Fischer
from v1: - Fix issue with the pci_enable_device patch. Moritz Fischer (3): net: dec: tulip: de2104x: Replace alloc_etherdev by devm_alloc_etherdev net: dec: tulip: de2104x: Replace pci_enable_device with devres version net: dec: tulip: de2104x: Replace kmemdup() with devm_kmempdup

Re: [PATCH v2 3/4] fpga: dfl: fix the comments of type & feature_id fields

2020-09-14 Thread Moritz Fischer
On Tue, Sep 15, 2020 at 11:27:52AM +0800, Xu Yilun wrote: > The description of feature_id in struct dfl_device is not accurate. In > DFL specification the feature_id is the 12 bits field. The description > in struct dfl_device_id is more clear so we make them aligned. We also > made the similar

Re: [PATCH v2 2/4] dfl: add dfl bus support to MODULE_DEVICE_TABLE()

2020-09-14 Thread Moritz Fischer
On Tue, Sep 15, 2020 at 11:27:51AM +0800, Xu Yilun wrote: > Device Feature List (DFL) is a linked list of feature headers within the > device MMIO space. It is used by FPGA to enumerate multiple sub features > within it. Each feature can be uniquely identified by DFL type and > feature id, which

Re: [PATCH v2 1/4] fpga: dfl: move dfl_device_id to mod_devicetable.h

2020-09-14 Thread Moritz Fischer
On Tue, Sep 15, 2020 at 11:27:50AM +0800, Xu Yilun wrote: > In order to support MODULE_DEVICE_TABLE() for dfl device driver, this > patch moves struct dfl_device_id to mod_devicetable.h > > Signed-off-by: Xu Yilun > Signed-off-by: Wu Hao > Signed-off-by: Matthew Gerlach > Signed-off-by: Russ

<    1   2   3   4   5   6   7   8   9   10   >