Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct

Hi Alan, generally ok with the change. On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull wrote: > -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf, > - size_t count) > +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct

Re: [PATCH v19 05/12] fpga-mgr: add fpga image information struct

Hi Alan, generally ok with the change. On Wed, Sep 28, 2016 at 11:21 AM, Alan Tull wrote: > -int fpga_mgr_buf_load(struct fpga_manager *mgr, u32 flags, const char *buf, > - size_t count) > +int fpga_mgr_buf_load(struct fpga_manager *mgr, struct fpga_image_info *info, > +

Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

Dmitry, On Wed, Sep 28, 2016 at 10:27 AM, Dmitry Torokhov <dmitry.torok...@gmail.com> wrote: > On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer > <moritz.fisc...@ettus.com> wrote: >> Add compatible string for NI version of cros-ec-spi. >> >> Signed-off-by: Mori

Re: [PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

Dmitry, On Wed, Sep 28, 2016 at 10:27 AM, Dmitry Torokhov wrote: > On Wed, Sep 28, 2016 at 9:59 AM, Moritz Fischer > wrote: >> Add compatible string for NI version of cros-ec-spi. >> >> Signed-off-by: Moritz Fischer >> --- >> drivers/mfd/cros_ec_spi.c |

[PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

Add compatible string for NI version of cros-ec-spi. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/mfd/cros_ec_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index ebe9b94..e4504ec 100644 --- a/drive

[PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version

Document the alternative compatibility string for the NI version of the chromium embedded controller. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- Documentation/devicetree/bindings/mfd/cros-ec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documen

[PATCH 3/3] mfd: cros_ec_spi: Add compatible string for NI version of cros-ec-spi

Add compatible string for NI version of cros-ec-spi. Signed-off-by: Moritz Fischer --- drivers/mfd/cros_ec_spi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mfd/cros_ec_spi.c b/drivers/mfd/cros_ec_spi.c index ebe9b94..e4504ec 100644 --- a/drivers/mfd/cros_ec_spi.c +++ b/drivers

[PATCH 2/3] mfd: cros_ec_spi: Add additional compatible string for NI version

Document the alternative compatibility string for the NI version of the chromium embedded controller. Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/mfd/cros-ec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mfd

[PATCH 1/3] Docs: DT: Add National Instruments vendor prefix

Add National Instruments (ni) vendor prefix to list of vendor prefixes Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.

[PATCH 1/3] Docs: DT: Add National Instruments vendor prefix

Add National Instruments (ni) vendor prefix to list of vendor prefixes Signed-off-by: Moritz Fischer --- Documentation/devicetree/bindings/vendor-prefixes.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree

Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support

Hi Alan, On Mon, Aug 8, 2016 at 12:18 PM, atull wrote: >> Please don't use module.h in drivers controlled by a bool >> Kconfig setting. >> >> THanks, >> Paul. >> > > Thanks for the feedback. Can you provide an example of what you > would consider to be proper usage

Re: [PATCH v18 6/6] ARM: socfpga: fpga bridge driver support

Hi Alan, On Mon, Aug 8, 2016 at 12:18 PM, atull wrote: >> Please don't use module.h in drivers controlled by a bool >> Kconfig setting. >> >> THanks, >> Paul. >> > > Thanks for the feedback. Can you provide an example of what you > would consider to be proper usage in the kernel? I think

Re: [PATCH] fpga: zynq: Add hardware dependencies

On Thu, Jul 7, 2016 at 1:07 AM, Jean Delvare <jdelv...@suse.de> wrote: > The zynq-fpga driver is specific to its architecture, so do not > propose it on other architectures, unless build-testing. > > Signed-off-by: Jean Delvare <jdelv...@suse.de> > Cc: Moritz Fische

Re: [PATCH] fpga: zynq: Add hardware dependencies

On Thu, Jul 7, 2016 at 1:07 AM, Jean Delvare wrote: > The zynq-fpga driver is specific to its architecture, so do not > propose it on other architectures, unless build-testing. > > Signed-off-by: Jean Delvare > Cc: Moritz Fischer > Cc: Alan Tull > Cc: Greg Kroah-Hartman

Re: [PATCH 1/2] ARM: socfpga: add bindings doc for arria10 fpga manager

Acked-By: Moritz Fischer <moritz.fisc...@ettus.com> On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull <at...@opensource.altera.com> wrote: > Add a device tree bindings document for the SoCFPGA Arria10 > FPGA Manager driver. > > Signed-off-by: Alan Tull <

Re: [PATCH 1/2] ARM: socfpga: add bindings doc for arria10 fpga manager

Acked-By: Moritz Fischer On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull wrote: > Add a device tree bindings document for the SoCFPGA Arria10 > FPGA Manager driver. > > Signed-off-by: Alan Tull > --- > .../bindings/fpga/altera-socfpga-a10-fpga-mgr.txt | 19 >

[PATCH v2] mtd: spi-nor: Add support for N25Q016A

This commit adds support in the spi-nor driver for the N25Q016A, a 16Mbit SPI NOR flash from Micron. Cc: David Woodhouse <dw...@infradead.org> Cc: Brian Norris <computersforpe...@gmail.com> Cc: Jagan Teki <jt...@openedev.com> Signed-off-by: Moritz Fischer <moritz.fisc...@et

[PATCH v2] mtd: spi-nor: Add support for N25Q016A

This commit adds support in the spi-nor driver for the N25Q016A, a 16Mbit SPI NOR flash from Micron. Cc: David Woodhouse Cc: Brian Norris Cc: Jagan Teki Signed-off-by: Moritz Fischer --- drivers/mtd/spi-nor/spi-nor.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mtd/spi-nor

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

Hi Alan, couple of nits inline below. On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull wrote: > +static int socfpga_a10_fpga_write_complete(struct fpga_manager *mgr, u32 > flags) > +{ > + struct a10_fpga_priv *priv = mgr->priv; > + u32 reg; > + int

Re: [PATCH 2/2] fpga-manager: Add Socfpga Arria10 support

Hi Alan, couple of nits inline below. On Tue, Jul 12, 2016 at 12:07 PM, Alan Tull wrote: > +static int socfpga_a10_fpga_write_complete(struct fpga_manager *mgr, u32 > flags) > +{ > + struct a10_fpga_priv *priv = mgr->priv; > + u32 reg; > + int ret; > + > + /* Wait for

Re: [PATCH 4/5] reset: zynq: make it explicitly non-modular

s (or is now) contained at the top of the file in the comments. > > Cc: Philipp Zabel <p.za...@pengutronix.de> > Cc: Michal Simek <michal.si...@xilinx.com> > Cc: "Sören Brinkmann" <soren.brinkm...@xilinx.com> > Cc: Moritz Fischer <moritz.fisc...@ettus.com

Re: [PATCH 4/5] reset: zynq: make it explicitly non-modular

of the file in the comments. > > Cc: Philipp Zabel > Cc: Michal Simek > Cc: "Sören Brinkmann" > Cc: Moritz Fischer > Signed-off-by: Paul Gortmaker Acked-By: Moritz Fischer Thanks, Moritz

Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

dependency on HAS_DMA to fix this. >> >> Signed-off-by: Geert Uytterhoeven <ge...@linux-m68k.org> >> Reviewed-by: Moritz Fischer <moritz.fisc...@ettus.com> >> --- >> v2: >> - Add Reviewed-by, >> - Updated error message for recent kernels, >&g

Re: [PATCH v2] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

t; >> Signed-off-by: Geert Uytterhoeven >> Reviewed-by: Moritz Fischer >> --- >> v2: >> - Add Reviewed-by, >> - Updated error message for recent kernels, >> - Submit to Greg, as requested by Alan. > > Hi Geert, > > Thank you! We should probably pick this one over Sudip's duplicate? Cheers, Moritz

Re: [PATCH] fpga: zynq-fpga: fix build failure

here was no dependency while > building. > > Signed-off-by: Sudip Mukherjee <sudip.mukher...@codethink.co.uk> Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> Thanks, Moritz

Re: [PATCH] fpga: zynq-fpga: fix build failure

building. > > Signed-off-by: Sudip Mukherjee Acked-by: Moritz Fischer Thanks, Moritz

Re: [RFC/PATCH 1/2] doc: bindings: Add bindings documentation for mtd otp nvmem

Hi Boris, On Thu, May 26, 2016 at 1:04 AM, Boris Brezillon wrote: > I think the MTD partition -> nvmem connection could benefit to non-OTP > partitions too. Yeah, I thought about that, too. Would you use the _read, and _write callbacks in that case? > So,

Re: [RFC/PATCH 1/2] doc: bindings: Add bindings documentation for mtd otp nvmem

Hi Boris, On Thu, May 26, 2016 at 1:04 AM, Boris Brezillon wrote: > I think the MTD partition -> nvmem connection could benefit to non-OTP > partitions too. Yeah, I thought about that, too. Would you use the _read, and _write callbacks in that case? > So, how about defining the nvmem regions

[RFC/PATCH 1/2] doc: bindings: Add bindings documentation for mtd otp nvmem

This commit adds documentation describing the bindings for exposing mtd flash otp regions as nvmem providers via devicetree. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- .../devicetree/bindings/mtd/otp-nvmem.txt | 62 ++ 1 file changed, 62 inse

[RFC/PATCH 1/2] doc: bindings: Add bindings documentation for mtd otp nvmem

This commit adds documentation describing the bindings for exposing mtd flash otp regions as nvmem providers via devicetree. Signed-off-by: Moritz Fischer --- .../devicetree/bindings/mtd/otp-nvmem.txt | 62 ++ 1 file changed, 62 insertions(+) create mode 100644

[RFC/PATCH 2/2] mtd: otp: Expose mtd flash otp regions as nvmem providers

t; Cc: Boris Brezillon <boris.brezil...@free-electrons.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/mtd/Kconfig| 8 drivers/mtd/Makefile | 1 + drivers/mtd/mtdcore.c | 35 ++ drivers/mtd/mtdcore.h | 1 + driv

[RFC/PATCH 2/2] mtd: otp: Expose mtd flash otp regions as nvmem providers

This commit introduces support for exposing otp regions in mtd flash devices as nvmem providers, allowing them to provide information such as serial numbers, calibration data or product ids. Cc: David Woodhouse Cc: Brian Norris Cc: Boris Brezillon Signed-off-by: Moritz Fischer --- drivers

[RFC/PATCH 0/2] Adding support to expose mtd flash otp regions via nvmem

to what I tried to implement. If someone has suggestions (especially on how to deduplicate some of the parsing code w.r.t to partitions I'd be happy to rework the series) Thanks for your feedback, Moritz Moritz Fischer (2): doc: bindings: Add bindings documentation for mtd otp nvmem mtd: otp

[RFC/PATCH 0/2] Adding support to expose mtd flash otp regions via nvmem

to what I tried to implement. If someone has suggestions (especially on how to deduplicate some of the parsing code w.r.t to partitions I'd be happy to rework the series) Thanks for your feedback, Moritz Moritz Fischer (2): doc: bindings: Add bindings documentation for mtd otp nvmem mtd: otp

[PATCH] mtd: ofpart: Assign device node to partitions parsed with ofpart

This patch adds a struct device_node pointer to struct mtd_partition. Partitions parsed via ofpart can now be referenced via devicetree. Cc: David Woodhouse <dw...@infradead.org> Cc: Brian Norris <computersforpe...@gmail.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.

[PATCH] mtd: ofpart: Assign device node to partitions parsed with ofpart

This patch adds a struct device_node pointer to struct mtd_partition. Partitions parsed via ofpart can now be referenced via devicetree. Cc: David Woodhouse Cc: Brian Norris Signed-off-by: Moritz Fischer --- Hi all, during my work on another patch series for supporting otp regions as nvmem

[PATCH] misc: at24: Fix typo in at24 header file

This commit fixes a simple typo s/mvmem/nvmem in the example. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- include/linux/platform_data/at24.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/platform_data/at24.h b/include/linux/platform_dat

[PATCH] misc: at24: Fix typo in at24 header file

This commit fixes a simple typo s/mvmem/nvmem in the example. Signed-off-by: Moritz Fischer --- include/linux/platform_data/at24.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/platform_data/at24.h b/include/linux/platform_data/at24.h index dc9a13e..be830b1

Re: [PATCH 17/54] MAINTAINERS: Add file patterns for fpga device tree bindings

.org> > Cc: Alan Tull <at...@opensource.altera.com> > Cc: Moritz Fischer <moritz.fisc...@ettus.com> Feel free to add my Acked-by, Moritz

Re: [PATCH 17/54] MAINTAINERS: Add file patterns for fpga device tree bindings

On Sun, May 22, 2016 at 2:05 AM, Geert Uytterhoeven wrote: > Submitters of device tree binding documentation may forget to CC > the subsystem maintainer if this is missing. > > Signed-off-by: Geert Uytterhoeven > Cc: Alan Tull > Cc: Moritz Fischer Feel free to add my Acked-by, Moritz

Re: [PATCH] mtd: Adding of_mtd_info_get to get mtd_info from devicetree

Hi Boris, On Mon, May 16, 2016 at 1:05 AM, Boris Brezillon wrote: >> Here are a few questions (I'm assuming the netdev + MAC address case): >> - how would you link the net/PHY device to the MTD partition storing >> the MAC address Well in my case I

Re: [PATCH] mtd: Adding of_mtd_info_get to get mtd_info from devicetree

Hi Boris, On Mon, May 16, 2016 at 1:05 AM, Boris Brezillon wrote: >> Here are a few questions (I'm assuming the netdev + MAC address case): >> - how would you link the net/PHY device to the MTD partition storing >> the MAC address Well in my case I actually planned to use it with the OTP

[PATCH] mtd: Adding of_mtd_info_get to get mtd_info from devicetree

This allows for getting a struct mtd_info from a node pointer, allowing mtd devices to e.g. store serial numbers or MAC addresses. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/mtd/mtdcore.c | 21 + include/linux/mtd/mtd.h | 2 ++ 2 files chang

[PATCH] mtd: Adding of_mtd_info_get to get mtd_info from devicetree

This allows for getting a struct mtd_info from a node pointer, allowing mtd devices to e.g. store serial numbers or MAC addresses. Signed-off-by: Moritz Fischer --- drivers/mtd/mtdcore.c | 21 + include/linux/mtd/mtd.h | 2 ++ 2 files changed, 23 insertions(+) diff --git

[RFC/PATCH] mtd: m25p80: Add support for One-Time-Programmable area.

and will prevent further writes to any of the 64 bytes. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- Hi all, this is much a work in progress and unfortunately given the hardware (zynq 7000 qspi driver from vendor tree) I have, and the nature of it being an *one* time progra

[RFC/PATCH] mtd: m25p80: Add support for One-Time-Programmable area.

and will prevent further writes to any of the 64 bytes. Signed-off-by: Moritz Fischer --- Hi all, this is much a work in progress and unfortunately given the hardware (zynq 7000 qspi driver from vendor tree) I have, and the nature of it being an *one* time programmable part it's really hard

[PATCH] spi: Fix simple typo s/impelment/implement

This fixes a simple typo in one of the comments. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0239b45..af7c48d 100644 --- a/drivers/spi/spi.c

[PATCH] spi: Fix simple typo s/impelment/implement

This fixes a simple typo in one of the comments. Signed-off-by: Moritz Fischer --- drivers/spi/spi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 0239b45..af7c48d 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -933,7

[PATCH] mtd: spi-nor: Add support for Micron n25q016a

This commit adds support in the spi-nor driver for the N25Q016A, a 16Mbit SPI NOR flash from Micron. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- Hi, attached patch adds support for N25Q016a from Micron. I have another set of changes that adds support for the 64 byt

[PATCH] mtd: spi-nor: Add support for Micron n25q016a

This commit adds support in the spi-nor driver for the N25Q016A, a 16Mbit SPI NOR flash from Micron. Signed-off-by: Moritz Fischer --- Hi, attached patch adds support for N25Q016a from Micron. I have another set of changes that adds support for the 64 byte part of this (and other N25Q Micron

Re: [PATCH 2/2] dmaengine: vdma: Add clock support

Hi, thanks for looking into this. On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana wrote: > +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable) > +{ > + int i = 0, ret; > + > + for (i = 0; i < xdev->numclks; i++) { > +

Re: [PATCH 2/2] dmaengine: vdma: Add clock support

Hi, thanks for looking into this. On Wed, Apr 20, 2016 at 12:20 AM, Kedareswara rao Appana wrote: > +static int xdma_clk_init(struct xilinx_dma_device *xdev, bool enable) > +{ > + int i = 0, ret; > + > + for (i = 0; i < xdev->numclks; i++) { > + if (enable) { > +

[PATCH v3 3/5] net: macb: Fix coding style suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Acked-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- dr

[PATCH v3 2/5] net: macb: Fix coding style warnings

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars, as well as a dangling else. Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethe

[PATCH v3 3/5] net: macb: Fix coding style suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Acked-by: Michal Simek Acked-by: Nicolas Ferre Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24

[PATCH v3 2/5] net: macb: Fix coding style warnings

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars, as well as a dangling else. Acked-by: Nicolas Ferre Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 100 +++- 1

[PATCH v3 5/5] net: macb: Fix simple typo

Acked-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

[PATCH v3 5/5] net: macb: Fix simple typo

Acked-by: Michal Simek Acked-by: Nicolas Ferre Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index 01a8ffb..eec3200 100644

[PATCH v3 4/5] net: macb: Use ether_addr_copy over memcpy

Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Acked-by: Michal Simek <michal.si...@xilinx.com> Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/mac

[PATCH v3 4/5] net: macb: Use ether_addr_copy over memcpy

Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Acked-by: Michal Simek Acked-by: Nicolas Ferre Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence

[PATCH v3 0/5] macb: Codingstyle cleanups

as suggested by Joe Cheers, Moritz Moritz Fischer (5): net: macb: Fix coding style error message net: macb: Fix coding style warnings net: macb: Fix coding style suggestions net: macb: Use ether_addr_copy over memcpy net: macb: Fix simple typo drivers/net/ethernet/cadence/macb.c

[PATCH v3 1/5] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Acked-by: Nicolas Ferre <nicolas.fe...@atmel.com> Acked-by: Michal Simek <michal.si...@xilinx.com> Signed-off-by: Moritz Fischer <moritz

[PATCH v3 0/5] macb: Codingstyle cleanups

as suggested by Joe Cheers, Moritz Moritz Fischer (5): net: macb: Fix coding style error message net: macb: Fix coding style warnings net: macb: Fix coding style suggestions net: macb: Use ether_addr_copy over memcpy net: macb: Fix simple typo drivers/net/ethernet/cadence/macb.c

[PATCH v3 1/5] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Acked-by: Nicolas Ferre Acked-by: Michal Simek Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insert

Re: [RFC 0/2] staging: ion: of_ion_device_get

On Tue, Mar 22, 2016 at 4:20 PM, Laura Abbott wrote: > If allocation is coming from userspace and drivers are only importing > you should be using the dma_buf APIs instead of Ion APIs directly. > Ion is a dma_buf exporter and dma_buf APIs are the preferred API. Ok, thanks.

Re: [RFC 0/2] staging: ion: of_ion_device_get

On Tue, Mar 22, 2016 at 4:20 PM, Laura Abbott wrote: > If allocation is coming from userspace and drivers are only importing > you should be using the dma_buf APIs instead of Ion APIs directly. > Ion is a dma_buf exporter and dma_buf APIs are the preferred API. Ok, thanks. Sounds reasonable.

Re: [RFC 0/2] staging: ion: of_ion_device_get

On Tue, Mar 22, 2016 at 4:20 PM, Laura Abbott <labb...@redhat.com> wrote: > On 03/22/2016 04:08 PM, Moritz Fischer wrote: >> >> Hi Laura, >> >> On Tue, Mar 22, 2016 at 3:51 PM, Laura Abbott <labb...@redhat.com> wrote: >> >>> In the past what

Re: [RFC 0/2] staging: ion: of_ion_device_get

On Tue, Mar 22, 2016 at 4:20 PM, Laura Abbott wrote: > On 03/22/2016 04:08 PM, Moritz Fischer wrote: >> >> Hi Laura, >> >> On Tue, Mar 22, 2016 at 3:51 PM, Laura Abbott wrote: >> >>> In the past what drivers have done is a foo_ion_cli

Re: [RFC 0/2] staging: ion: of_ion_device_get

Hi Laura, On Tue, Mar 22, 2016 at 3:51 PM, Laura Abbott wrote: > In the past what drivers have done is a foo_ion_client_create which has the > reference > to the ion_device created from ion_device_create. Drivers then call the > foo_ion_client_create function. Oh, so you

Re: [RFC 0/2] staging: ion: of_ion_device_get

Hi Laura, On Tue, Mar 22, 2016 at 3:51 PM, Laura Abbott wrote: > In the past what drivers have done is a foo_ion_client_create which has the > reference > to the ion_device created from ion_device_create. Drivers then call the > foo_ion_client_create function. Oh, so you mean you add a

Re: [RFC 1/2] misc: Add of_get_misc get a reference from devicetree

Meh, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer <moritz.fisc...@ettus.com> wrote: > > + > +err_dev: > + put_device(dev); > + return ERR_PTR(ret); > +} > +#else > +struct misc_device *of_misc_get(struct device_node *) Ok, that one is broken Sorry, Moritz

Re: [RFC 1/2] misc: Add of_get_misc get a reference from devicetree

Meh, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer wrote: > > + > +err_dev: > + put_device(dev); > + return ERR_PTR(ret); > +} > +#else > +struct misc_device *of_misc_get(struct device_node *) Ok, that one is broken Sorry, Moritz

Re: [RFC 2/2] staging: android: ion: Add of_ion_device_get function

Derp, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer <moritz.fisc...@ettus.com> wrote: > Allows to obtain a reference to the global /dev/ion backing > struct ion_device via devicetree. > > Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> > --- > drivers/

Re: [RFC 2/2] staging: android: ion: Add of_ion_device_get function

Derp, On Tue, Mar 22, 2016 at 3:33 PM, Moritz Fischer wrote: > Allows to obtain a reference to the global /dev/ion backing > struct ion_device via devicetree. > > Signed-off-by: Moritz Fischer > --- > drivers/staging/android/ion/ion.c | 10 ++ > 1 file c

[RFC 2/2] staging: android: ion: Add of_ion_device_get function

Allows to obtain a reference to the global /dev/ion backing struct ion_device via devicetree. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/staging/android/ion/ion.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/android/ion/io

[RFC 2/2] staging: android: ion: Add of_ion_device_get function

Allows to obtain a reference to the global /dev/ion backing struct ion_device via devicetree. Signed-off-by: Moritz Fischer --- drivers/staging/android/ion/ion.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion

[RFC 1/2] misc: Add of_get_misc get a reference from devicetree

This commit enables access to a miscdevice via a reference obtained from devicetree. This allows to implement a of_ion_device_get() in the next step. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/char/misc.c| 38 ++ include

[RFC 1/2] misc: Add of_get_misc get a reference from devicetree

This commit enables access to a miscdevice via a reference obtained from devicetree. This allows to implement a of_ion_device_get() in the next step. Signed-off-by: Moritz Fischer --- drivers/char/misc.c| 38 ++ include/linux/miscdevice.h | 3 +++ 2

[RFC 0/2] staging: ion: of_ion_device_get

to get to that via devicetree, though. I'll admit that hacking up miscdevice is quite hacky, maybe I should add a foo_get_ion_device() to my heap implementing platform device? If someone can explain me how to correctly do that with what we currently have, even better. Cheers, Moritz Moritz

[RFC 0/2] staging: ion: of_ion_device_get

to get to that via devicetree, though. I'll admit that hacking up miscdevice is quite hacky, maybe I should add a foo_get_ion_device() to my heap implementing platform device? If someone can explain me how to correctly do that with what we currently have, even better. Cheers, Moritz Moritz

Re: [PATCH 0/5] net: macb: Checkpatch cleanups

Nicolas, On Wed, Mar 16, 2016 at 6:39 AM, Nicolas Ferre <nicolas.fe...@atmel.com> wrote: > Le 13/03/2016 20:10, Moritz Fischer a écrit : >> Hi all, >> >> I backed out the variable scope changes and made a separate >> patch for the ether_addr_copy change. >

Re: [PATCH 0/5] net: macb: Checkpatch cleanups

Nicolas, On Wed, Mar 16, 2016 at 6:39 AM, Nicolas Ferre wrote: > Le 13/03/2016 20:10, Moritz Fischer a écrit : >> Hi all, >> >> I backed out the variable scope changes and made a separate >> patch for the ether_addr_copy change. >> >> Changes from

Re: [PATCH 5/7] dmaengine: xilinx_vdma: Remove unnecessary axi dma device-tree binding doc

Hi there, On Tue, Mar 15, 2016 at 10:23 AM, Kedareswara rao Appana wrote: > AXI DMA support is added to the existing AXI VDMA driver. > The binding doc for AXI DMA should also be updated in the > VDMA device-tree binding doc. > > Signed-off-by: Kedareswara rao Appana

Re: [PATCH 5/7] dmaengine: xilinx_vdma: Remove unnecessary axi dma device-tree binding doc

Hi there, On Tue, Mar 15, 2016 at 10:23 AM, Kedareswara rao Appana wrote: > AXI DMA support is added to the existing AXI VDMA driver. > The binding doc for AXI DMA should also be updated in the > VDMA device-tree binding doc. > > Signed-off-by: Kedareswara rao Appana > --- >

Re: [PATCH 0/7] dmaengine: xilinx_vdma: AXI DMA's enhancments

Hi, On Tue, Mar 15, 2016 at 10:23 AM, Kedareswara rao Appana wrote: > This patch series does some enhancments to the VDMA driver > which includes > --> Adding support for AXI DMA IP. > --> Adding support for AXI CDMA IP. > --> Fixing checkpatch warnings. > >

Re: [PATCH 0/7] dmaengine: xilinx_vdma: AXI DMA's enhancments

Hi, On Tue, Mar 15, 2016 at 10:23 AM, Kedareswara rao Appana wrote: > This patch series does some enhancments to the VDMA driver > which includes > --> Adding support for AXI DMA IP. > --> Adding support for AXI CDMA IP. > --> Fixing checkpatch warnings. > > Kedareswara rao Appana (7): >

Re: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings

+} > > WARNING: void function return statements are not generally useful > + return; > +} > > WARNING: Missing a blank line after declarations > + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK; > + vdma_ctrl_write(chan, XILINX_VDMA_R

Re: [PATCH 1/7] dmaengine: xilinx_vdma: Fix checkpatch.pl warnings

ion return statements are not generally useful > + return; > +} > > WARNING: Missing a blank line after declarations > + u32 errors = status & XILINX_VDMA_DMASR_ALL_ERR_MASK; > + vdma_ctrl_write(chan, XILINX_VDMA_REG_DMASR, > Acked-by: Moritz Fis

[PATCH 3/5] net: macb: Address checkpatch 'check' suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(

[PATCH 3/5] net: macb: Address checkpatch 'check' suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git

[PATCH 2/5] net: macb: Fix coding style warnings

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars, as well as a dangling else. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 101 +++--

[PATCH 0/5] net: macb: Checkpatch cleanups

Hi all, I backed out the variable scope changes and made a separate patch for the ether_addr_copy change. Changes from v1: * Backed out variable scope changes * Separated out ether_addr_copy into it's own commit * Fixed typo in comments as suggested by Joe Cheers, Moritz Moritz Fischer (5

[PATCH 2/5] net: macb: Fix coding style warnings

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars, as well as a dangling else. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 101 +++- 1 file changed, 43

[PATCH 0/5] net: macb: Checkpatch cleanups

Hi all, I backed out the variable scope changes and made a separate patch for the ether_addr_copy change. Changes from v1: * Backed out variable scope changes * Separated out ether_addr_copy into it's own commit * Fixed typo in comments as suggested by Joe Cheers, Moritz Moritz Fischer (5

[PATCH 4/5] net: macb: Use ether_addr_copy over memcpy

Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drive

[PATCH 5/5] net: macb: Fix simple typo.

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index a0c01e5..681e5bf 100644 --- a/drivers/net/et

[PATCH 4/5] net: macb: Use ether_addr_copy over memcpy

Checkpatch suggests using ether_addr_copy over memcpy to copy the mac address. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c

[PATCH 5/5] net: macb: Fix simple typo.

Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence/macb.c index a0c01e5..681e5bf 100644 --- a/drivers/net/ethernet/cadence/macb.c +++ b

[PATCH 1/5] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 1/5] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ether

<    6   7   8   9   10   11   12   13   14   15   >