Re: [PATCH 0/3] net: macb: Fix coding style issues

Hi all, thanks for the feedback. On Wed, Mar 9, 2016 at 8:29 AM, Michal Simek wrote: > On 7.3.2016 18:13, Nicolas Ferre wrote: >> I'm not usually fond of this type of patches, but I must admit that this >> series corrects some style issues. While I was playing around

Re: [PATCH 0/3] net: macb: Fix coding style issues

Hi all, thanks for the feedback. On Wed, Mar 9, 2016 at 8:29 AM, Michal Simek wrote: > On 7.3.2016 18:13, Nicolas Ferre wrote: >> I'm not usually fond of this type of patches, but I must admit that this >> series corrects some style issues. While I was playing around with my fixed-link for

Re: [PATCH 2/3] net: macb: Fix more coding style issues

Hi Joe, David, On Mon, Mar 7, 2016 at 10:49 AM, David Miller <da...@davemloft.net> wrote: > From: Moritz Fischer <moritz.fisc...@ettus.com> > Date: Mon, 7 Mar 2016 08:17:38 -0800 > >> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int &g

Re: [PATCH 2/3] net: macb: Fix more coding style issues

Hi Joe, David, On Mon, Mar 7, 2016 at 10:49 AM, David Miller wrote: > From: Moritz Fischer > Date: Mon, 7 Mar 2016 08:17:38 -0800 > >> @@ -945,6 +943,7 @@ static int macb_rx_frame(struct macb *bp, unsigned int >> first_frag, >> static int macb_rx(

[PATCH 3/3] net: macb: Address checkpatch 'check' suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(

[PATCH 3/3] net: macb: Address checkpatch 'check' suggestions

This commit deals with a bunch of checkpatch suggestions that without changing behavior make checkpatch happier. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git

Re: [PATCH 3/3] net: macb: Cleanup checkpatch checks

Derp, it's monday morning. Ignore the second [3/3] patch... Sorry for the noise. Moritz

Re: [PATCH 3/3] net: macb: Cleanup checkpatch checks

Derp, it's monday morning. Ignore the second [3/3] patch... Sorry for the noise. Moritz

[PATCH 0/3] net: macb: Fix coding style issues

into one commit. Cheers, Moritz Moritz Fischer (3): net: macb: Fix coding style error message net: macb: Fix more coding style issues net: macb: Address checkpatch 'check' suggestions drivers/net/ethernet/cadence/macb.c | 157 1 file changed, 71

[PATCH 0/3] net: macb: Fix coding style issues

into one commit. Cheers, Moritz Moritz Fischer (3): net: macb: Fix coding style error message net: macb: Fix more coding style issues net: macb: Address checkpatch 'check' suggestions drivers/net/ethernet/cadence/macb.c | 157 1 file changed, 71

[PATCH 2/3] net: macb: Fix more coding style issues

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars. Notable exceptions are ether_addr_copy vs memcpy, as well as a dangling else after a return. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drive

[PATCH 1/3] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 2/3] net: macb: Fix more coding style issues

This commit takes care of the coding style warnings that are mostly due to a different comment style and lines over 80 chars. Notable exceptions are ether_addr_copy vs memcpy, as well as a dangling else after a return. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 109

[PATCH 1/3] net: macb: Fix coding style error message

checkpatch.pl gave the following error: ERROR: space required before the open parenthesis '(' + for(; p < end; p++, offset += 4) Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ether

[PATCH 3/3] net: macb: Cleanup checkpatch checks

This commit deals with a bunch of check suggestions that without changing behavior make checkpatch hapy. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(+), 22 del

[PATCH 3/3] net: macb: Cleanup checkpatch checks

This commit deals with a bunch of check suggestions that without changing behavior make checkpatch hapy. Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 46 +++-- 1 file changed, 24 insertions(+), 22 deletions(-) diff --git a/drivers/net

[RFC] net: macb: Attempt to make fixed link working on macb

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/net/ethernet/cadence/macb.c | 63 - drivers/net/ethernet/cadence/macb.h | 1 + 2 files changed, 43 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/d

[RFC] net: macb: Attempt to make fixed link working on macb

Signed-off-by: Moritz Fischer --- drivers/net/ethernet/cadence/macb.c | 63 - drivers/net/ethernet/cadence/macb.h | 1 + 2 files changed, 43 insertions(+), 21 deletions(-) diff --git a/drivers/net/ethernet/cadence/macb.c b/drivers/net/ethernet/cadence

[RFC] Attempt to add fixed link functionality to macb

for pointers on obvious mistakes than for a thorough code review. Thanks in advance, Moritz Moritz Fischer (1): net: macb: Attempt to make fixed link working on macb drivers/net/ethernet/cadence/macb.c | 63 - drivers/net/ethernet/cadence/macb.h | 1 + 2

[RFC] Attempt to add fixed link functionality to macb

for pointers on obvious mistakes than for a thorough code review. Thanks in advance, Moritz Moritz Fischer (1): net: macb: Attempt to make fixed link working on macb drivers/net/ethernet/cadence/macb.c | 63 - drivers/net/ethernet/cadence/macb.h | 1 + 2

[PATCH] fpga-manager: Replaced macro with static inline function

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- include/linux/fpga/fpga-mgr.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h index 0940bf4..8064f1b 100644 --- a/include/linux/fpga/fpga-mgr.h

[PATCH] fpga-manager: Replaced macro with static inline function

Signed-off-by: Moritz Fischer --- include/linux/fpga/fpga-mgr.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h index 0940bf4..8064f1b 100644 --- a/include/linux/fpga/fpga-mgr.h +++ b/include/linux/fpga/fpga

Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver

Delvare <jdelv...@suse.de> >> Cc: Alan Tull <at...@opensource.altera.com> >> Cc: Moritz Fischer <moritz.fisc...@ettus.com> >> Cc: Michal Simek <michal.si...@xilinx.com> >> Cc: "Sören Brinkmann" <soren.brinkm...@xilinx.com> Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> Thanks for catching that, Moritz

Re: [PATCH] fpga manager: Add hardware dependency to Zynq driver

Hi Jean, On Mon, Feb 22, 2016 at 7:04 AM, Michal Simek wrote: > On 22.2.2016 14:42, Jean Delvare wrote: >> The Zynq FPGA manager driver serves no purpose on other architectures >> so hide it unless build-testing. >> >> Signed-off-by: Jean Delvare >> Cc: Alan T

Re: [PATCH 1/1] of/overlay: of overlay callbacks

Hi Alan, a couple of nits below. On Wed, Feb 17, 2016 at 9:41 AM, Alan Tull wrote: > > +/* > + * Send overlay callbacks to handlers that match. This call is blocking. In Can we make this 'Invoke' instead of send? > @@ -370,6 +448,13 @@ int

Re: [PATCH 1/1] of/overlay: of overlay callbacks

Hi Alan, a couple of nits below. On Wed, Feb 17, 2016 at 9:41 AM, Alan Tull wrote: > > +/* > + * Send overlay callbacks to handlers that match. This call is blocking. In Can we make this 'Invoke' instead of send? > @@ -370,6 +448,13 @@ int of_overlay_create(struct device_node *tree) >

Re: [PATCH v16 0/6] Device Tree support for FPGA programming

Hi Alan, On Thu, Feb 11, 2016 at 2:17 PM, atull wrote: >> > > I looked into it further and now I've got a solution for this issue >> > > that I can post soon. I can stop using the DT overlay configfs >> > > interface and add a sysfs file for applying an overlay to

Re: [PATCH v16 0/6] Device Tree support for FPGA programming

Hi Alan, On Thu, Feb 11, 2016 at 2:17 PM, atull wrote: >> > > I looked into it further and now I've got a solution for this issue >> > > that I can post soon. I can stop using the DT overlay configfs >> > > interface and add a sysfs file for applying an overlay to an FPGA >> > > region. The

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

ked-by: Moritz Fischer Moritz

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

tch looks good to me, FWIW: Acked-by: Moritz Fischer <moritz.fisc...@ettus.com> Moritz

Re: [PATCH v3 2/4] power: reset: add reboot mode driver

Hi Andy, looks good to me. Feel free to add my Reviewed-by On Tue, Feb 2, 2016 at 2:02 AM, Andy Yan wrote: > This is commonly used on Android based devices, in order to > reboot the device into fastboot or recovery mode. > Reviewed-by: Moritz Fischer > Reviewed-by: Matthias Brugg

Re: [PATCH v3 2/4] power: reset: add reboot mode driver

Hi Andy, looks good to me. Feel free to add my Reviewed-by On Tue, Feb 2, 2016 at 2:02 AM, Andy Yan <andy@rock-chips.com> wrote: > This is commonly used on Android based devices, in order to > reboot the device into fastboot or recovery mode. > Reviewed-by: Moritz Fisch

Re: [PATCH v15 1/6] fpga: add bindings document for fpga area and fpga bus

Hi, On Wed, Jan 27, 2016 at 9:24 PM, atull wrote: >> I think I said this before, but you should not need simple-bus. Having >> it is wrong if the bus requires some configuration before enumerating >> the child nodes. The way you have it, the bridge driver could probe >> before the FPGA manager

Re: [PATCH v2 2/4] power: reset: add reboot mode driver

Hi Andy, On Tue, Jan 12, 2016 at 12:31 PM, Andy Yan wrote: > This driver parse the reboot commands like "reboot loader" > and "reboot recovery" to get a boot mode described in the > device tree , then call the write interfae to store the boot > mode in some persistent storage like special

Re: [PATCH v15 1/6] fpga: add bindings document for fpga area and fpga bus

Hi, On Wed, Jan 27, 2016 at 9:24 PM, atull wrote: >> I think I said this before, but you should not need simple-bus. Having >> it is wrong if the bus requires some configuration before enumerating >> the child nodes. The way you have it, the bridge driver could

Re: [PATCH v2 2/4] power: reset: add reboot mode driver

Hi Andy, On Tue, Jan 12, 2016 at 12:31 PM, Andy Yan wrote: > This driver parse the reboot commands like "reboot loader" > and "reboot recovery" to get a boot mode described in the > device tree , then call the write interfae to store the boot > mode in some persistent

[RESEND][PATCH] PM / Domains: Fix typo in comment

Acked-by: Kevin Hilman Signed-off-by: Moritz Fischer --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 167418e..f23c036 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base

[RESEND][PATCH] PM / Domains: Fix typo in comment

Acked-by: Kevin Hilman <khil...@baylibre.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 167418e..f2

Re: [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs

On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger wrote: > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger Acked-by: Moritz Fischer

Re: [PATCH 07/22] fpga: Fix dependencies for !HAS_IOMEM archs

On Mon, Jan 25, 2016 at 11:24 PM, Richard Weinberger <rich...@nod.at> wrote: > Not every arch has io memory. > So, unbreak the build by fixing the dependencies. > > Signed-off-by: Richard Weinberger <rich...@nod.at> Acked-by: Moritz Fischer <moritz.fisc...@ettus.com>

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

On Fri, Jan 22, 2016 at 5:37 PM, atull wrote: > On Fri, 22 Jan 2016, Moritz Fischer wrote: > >> Alan, >> >> On Wed, Jan 20, 2016 at 8:24 PM, wrote: >> >> > +static int fpga_area_probe(struct platform_device *pdev) >> > +{ >> > + s

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

Alan, On Wed, Jan 20, 2016 at 8:24 PM, wrote: > +static int fpga_area_probe(struct platform_device *pdev) > +{ > + struct device *dev = >dev; > + struct device_node *np = dev->of_node; > + struct fpga_area *area; > + int ret; > + > + area = devm_kzalloc(dev,

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

Alan, On Wed, Jan 20, 2016 at 8:24 PM, wrote: > +static int fpga_area_probe(struct platform_device *pdev) > +{ > + struct device *dev = >dev; > + struct device_node *np = dev->of_node; > + struct fpga_area *area; > + int ret; > + > +

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

On Fri, Jan 22, 2016 at 5:37 PM, atull <at...@opensource.altera.com> wrote: > On Fri, 22 Jan 2016, Moritz Fischer wrote: > >> Alan, >> >> On Wed, Jan 20, 2016 at 8:24 PM, <at...@opensource.altera.com> wrote: >> >> > +stat

Re: [PATCH v15 0/6] altera fpga area and fpga bus

Hi Alan, On Thu, Jan 21, 2016 at 5:42 PM, atull wrote: > If you want to send me a Xilinx example of usage for me to include in that > document, that would be useful also. I think you might have sent me > something a while ago, but I can't find it now. Will do. I'll clean up some of my

Re: [PATCH v15 1/6] fpga: add bindings document for fpga area and fpga bus

Hi Alan, On Thu, Jan 21, 2016 at 6:21 PM, atull wrote: > target-path = "/amba/fpga_bus@0/devcfg@f8007000"; derp ... building in the driver helps ... all good on your side ;-) Cheers, Moritz

Re: [PATCH v15 1/6] fpga: add bindings document for fpga area and fpga bus

Hi Alan, I tried getting a simple example to work with overlays, however so far I failed getting the child nodes to probe drivers, maybe you have an idea? The fpga image is loaded just fine. in dts: fpga_bus@0 { compatible = "altr,fpga-bus", "simple-bus";

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

Hi Alan, minor nits inline: On Wed, Jan 20, 2016 at 8:24 PM, wrote: > v15: Add altr,fpga-bus implementation > Change compatible string "fpga-area" -> "altr,fpga-area" Doesn't look that way down there. Or am I reading the code wrong? > +static const struct of_device_id

Re: [PATCH v15 2/6] add sysfs document for fpga bridge class

On Thu, Jan 21, 2016 at 1:17 PM, Måns Rullgård wrote: > I don't see a patch in this email. So it's not just me :-) Cheers, Moritz

Re: [PATCH v15 0/6] altera fpga area and fpga bus

Hi Alan, On Wed, Jan 20, 2016 at 8:24 PM, wrote: > From: Alan Tull > > For v15, I'm not using the FPGA Manager as the bus. I'm adding a FPGA Bus; > the FPGA Manager and bridges go below it. > > I've gotten enough feedback that my proposals are Altera specific that I am > going with that and

Re: [PATCH v15 2/6] add sysfs document for fpga bridge class

On Thu, Jan 21, 2016 at 1:17 PM, Måns Rullgård wrote: > I don't see a patch in this email. So it's not just me :-) Cheers, Moritz

Re: [PATCH v15 0/6] altera fpga area and fpga bus

Hi Alan, On Wed, Jan 20, 2016 at 8:24 PM, wrote: > From: Alan Tull > > For v15, I'm not using the FPGA Manager as the bus. I'm adding a FPGA Bus; > the FPGA Manager and bridges go below it. > > I've gotten enough feedback that my

Re: [PATCH v15 1/6] fpga: add bindings document for fpga area and fpga bus

Hi Alan, I tried getting a simple example to work with overlays, however so far I failed getting the child nodes to probe drivers, maybe you have an idea? The fpga image is loaded just fine. in dts: fpga_bus@0 { compatible = "altr,fpga-bus", "simple-bus";

Re: [PATCH v15 5/6] fpga: fpga-area and fpga-bus: device tree control for FPGA

Hi Alan, minor nits inline: On Wed, Jan 20, 2016 at 8:24 PM, wrote: > v15: Add altr,fpga-bus implementation > Change compatible string "fpga-area" -> "altr,fpga-area" Doesn't look that way down there. Or am I reading the code wrong? > +static const struct

Re: [PATCH v15 1/6] fpga: add bindings document for fpga area and fpga bus

Hi Alan, On Thu, Jan 21, 2016 at 6:21 PM, atull wrote: > target-path = "/amba/fpga_bus@0/devcfg@f8007000"; derp ... building in the driver helps ... all good on your side ;-) Cheers, Moritz

Re: [PATCH v15 0/6] altera fpga area and fpga bus

Hi Alan, On Thu, Jan 21, 2016 at 5:42 PM, atull wrote: > If you want to send me a Xilinx example of usage for me to include in that > document, that would be useful also. I think you might have sent me > something a while ago, but I can't find it now. Will do.

Re: [PATCH 02/10] spi: cadence, zynq: use to_platform_device()

Hi, On Sun, Dec 27, 2015 at 5:15 AM, Geliang Tang wrote: > Use to_platform_device() instead of open-coding it. > Reviewed-by: Moritz Fischer > Signed-off-by: Geliang Tang Looks good to me, maybe (nit) split it up into two commits. Cheers, Moritz -- To unsubscribe from this l

Re: [PATCH 02/10] spi: cadence, zynq: use to_platform_device()

Hi, On Sun, Dec 27, 2015 at 5:15 AM, Geliang Tang <geliangt...@163.com> wrote: > Use to_platform_device() instead of open-coding it. > Reviewed-by: Moritz Fischer <moritz.fisc...@ettus.com> > Signed-off-by: Geliang Tang <geliangt...@163.com> Looks good to me, maybe

[PATCH] PM / Domains: Fix typo in comment

Signed-off-by: Moritz Fischer --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 65f50ec..53e81ac 100644 --- a/drivers/base/power/domain.c +++ b/drivers/base/power/domain.c @@ -160,7

[PATCH] PM / Domains: Fix typo in comment

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/base/power/domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c index 65f50ec..53e81ac 100644 --- a/drivers/base/power/domain.c +++ b/driver

[PATCH v2] extcon: gpio: Fix typo in comment (cosmetic)

Signed-off-by: Moritz Fischer --- drivers/extcon/extcon-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 279ff8f..d023789 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c

Re: [PATCH] extcon: gpio: Fix typo in comment.

On Wed, Dec 23, 2015 at 9:28 PM, Moritz Fischer wrote: > Signed-off-by: Moritz Fischer > --- > drivers/extcon/extcon-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c > index 27

[PATCH] extcon: gpio: Fix typo in comment.

Signed-off-by: Moritz Fischer --- drivers/extcon/extcon-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 279ff8f..0af543a 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/drivers/extcon/extcon-gpio.c

Re: [PATCH v1 1/6] dt-bindings: misc: add document for reboot-mode driver

Rob, On Tue, Dec 22, 2015 at 4:32 PM, Rob Herring wrote: > I would like to see the property names here standardized as much as > possible. I'm not sure if we can define the properties as a u32 or need > some flexibility here. Quick question, semi on topic. I have a similar case (and a driver

Re: [PATCH] extcon: gpio: Fix typo in comment.

On Wed, Dec 23, 2015 at 9:28 PM, Moritz Fischer <moritz.fisc...@ettus.com> wrote: > Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> > --- > drivers/extcon/extcon-gpio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/

[PATCH] extcon: gpio: Fix typo in comment.

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/extcon/extcon-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 279ff8f..0af543a 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/d

[PATCH v2] extcon: gpio: Fix typo in comment (cosmetic)

Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/extcon/extcon-gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-gpio.c b/drivers/extcon/extcon-gpio.c index 279ff8f..d023789 100644 --- a/drivers/extcon/extcon-gpio.c +++ b/d

Re: [PATCH v1 1/6] dt-bindings: misc: add document for reboot-mode driver

Rob, On Tue, Dec 22, 2015 at 4:32 PM, Rob Herring wrote: > I would like to see the property names here standardized as much as > possible. I'm not sure if we can define the properties as a u32 or need > some flexibility here. Quick question, semi on topic. I have a similar

Re: [PATCH 3/3] STAGING: COMEDI: Using kernel types in plx9080.h

t; + u8 dma_status; >> const int timeout = 1; >> unsigned int i; >> >> > > Thanks! > > Reviewed-by: Ian Abbott Acked-by: Moritz Fischer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 3/3] STAGING: COMEDI: Using kernel types in plx9080.h

t;> void __iomem *dma_cs_addr; >> - uint8_t dma_status; >> + u8 dma_status; >> const int timeout = 1; >> unsigned int i; >> >> > > Thanks! > > Reviewed-by: Ian Abbott <abbo...@mev.co.uk> Acked-by: Moritz Fis

Re: [PATCH v14 0/7] fpga area and fpga bridge framework

Hi Alan, On Mon, Dec 14, 2015 at 5:56 PM, Alan Tull wrote: >> I had an offline discussion with Josh Cartwright about his concerns. >> He brought up a good >> point on w.r.t to the way FPGA Area (Bus) deals with things. >> >> Currently we only support complete status = "okay" vs "disabled" kind

Re: [PATCH v14 0/7] fpga area and fpga bridge framework

Hi Alan, On Mon, Dec 14, 2015 at 5:56 PM, Alan Tull wrote: >> I had an offline discussion with Josh Cartwright about his concerns. >> He brought up a good >> point on w.r.t to the way FPGA Area (Bus) deals with things. >> >> Currently we only support complete status

Re: [PATCH v14 0/7] fpga area and fpga bridge framework

Hi Alan, On Thu, Dec 10, 2015 at 3:37 PM, wrote: > From: Alan Tull > > For v14 I'm dropping the concept of "simple-fpga-bus" for "fpga-area" > with reworked bindings. I had an offline discussion with Josh Cartwright about his concerns. He brought up a good point on w.r.t to the way FPGA Area

Re: [PATCH v14 0/7] fpga area and fpga bridge framework

Hi Alan, On Thu, Dec 10, 2015 at 3:37 PM, wrote: > From: Alan Tull > > For v14 I'm dropping the concept of "simple-fpga-bus" for "fpga-area" > with reworked bindings. I had an offline discussion with Josh Cartwright about his concerns.

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

Hi Gregory, so far dealt with this in u-boot. The power down the PHY part makes sense, though. Minor nit down inline. Will need to test on hardware (Zynq). On Wed, Dec 9, 2015 at 9:49 AM, Gregory CLEMENT wrote: > With device tree it is no more possible to reset the PHY at board > level.

Re: [PATCH] net/macb: add support for resetting PHY using GPIO

Hi Gregory, so far dealt with this in u-boot. The power down the PHY part makes sense, though. Minor nit down inline. Will need to test on hardware (Zynq). On Wed, Dec 9, 2015 at 9:49 AM, Gregory CLEMENT wrote: > With device tree it is no more possible to

Re: [PATCH LINUX v3 04/10] tty: xuartps: Clear interrupt status register in shutdown

ve to look this up myself. > > Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [PATCH LINUX v3 01/10] tty: xuartps: Beautify read-modify writes

On Sat, Dec 5, 2015 at 9:04 AM, Peter Hurley wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: >> Non-functional, formatting changes to ease reading the code. > > Reviewed-by: Peter Hurley Reviewed-by: Moritz Fischer http://vger.kernel.org/majordomo-info.html Please read t

Re: [PATCH LINUX v3 04/10] tty: xuartps: Clear interrupt status register in shutdown

ister worked so I didn't have to look this up myself. > > Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> Reviewed-by: Moritz Fischer <moritz.fisc...@ettus.com> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH LINUX v3 01/10] tty: xuartps: Beautify read-modify writes

On Sat, Dec 5, 2015 at 9:04 AM, Peter Hurley <pe...@hurleysoftware.com> wrote: > On 11/21/2015 09:59 PM, Soren Brinkmann wrote: >> Non-functional, formatting changes to ease reading the code. > > Reviewed-by: Peter Hurley <pe...@hurleysoftware.com> Reviewed-by:

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

Hi Jassi, thanks for your feedback. On Mon, Aug 10, 2015 at 1:05 AM, Jassi Brar wrote: > On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer > wrote: > >> + >> +static void xilinx_mbox_rx_data(struct mbox_chan *chan) >> +{ >> + struct xilinx_mbox *mbo

Re: [PATCHv7 2/2] mailbox: Adding driver for Xilinx LogiCORE IP mailbox.

Hi Jassi, thanks for your feedback. On Mon, Aug 10, 2015 at 1:05 AM, Jassi Brar <jassisinghb...@gmail.com> wrote: > On Wed, Jul 15, 2015 at 6:30 AM, Moritz Fischer > <moritz.fisc...@ettus.com> wrote: > >> + >> +static void xilinx_mbox_rx_data(struct mbox_ch

Re: [PATCH] net/macb: bindings doc: Merge cdns-emac to macb

nq-gem" Xilinx Zynq-7xxx SoC. >Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC. > + Or the generic form: "cdns,emac". > - reg: Address and length of the register set for the device > - interrupts: Should contain macb interrupt > - phy-mode: See

Re: [PATCH] net/macb: bindings doc: Merge cdns-emac to macb

lable on Atmel sama5d4 > SoCs. > + Use "cdns,zynq-gem" Xilinx Zynq-7xxx SoC. >Use "cdns,zynqmp-gem" for Zynq Ultrascale+ MPSoC. > + Or the generic form: "cdns,emac". > - reg: Address and length of the register set for the device > - interrupt

Re: [PATCH v2] fpga: zynq-fpga: Enable pm_runtime (suspend, resume)

Hi Mike, thanks for your feedback. I put what I think you suggested inline below. On Thu, Nov 19, 2015 at 11:25 PM, Mike Looijmans wrote: > On 19-11-15 23:07, Moritz Fischer wrote: >> @@ -457,19 +457,26 @@ static int zynq_fpga_probe(struct platform_device >> *pdev) >>

Re: [PATCH v2] fpga: zynq-fpga: Enable pm_runtime (suspend, resume)

Hi Mike, thanks for your feedback. I put what I think you suggested inline below. On Thu, Nov 19, 2015 at 11:25 PM, Mike Looijmans <mike.looijm...@topic.nl> wrote: > On 19-11-15 23:07, Moritz Fischer wrote: >> @@ -457,19 +457,26 @@ static int zynq_fpga_probe(struct platform_

[PATCH v2] fpga: zynq-fpga: Enable pm_runtime (suspend, resume)

Replaced constant clock_{enable,disable} calls with pm_runtime hooks for suspend and resume to avoid constant clk_enable / clk_disable. Acked-by: Alan Tull Signed-off-by: Moritz Fischer --- Changes: v1: - Removed superfluous #ifdef CONFIG_PM as suggested by Michal - Changed commit message

[PATCH v2] fpga: zynq-fpga: Enable pm_runtime (suspend, resume)

Replaced constant clock_{enable,disable} calls with pm_runtime hooks for suspend and resume to avoid constant clk_enable / clk_disable. Acked-by: Alan Tull <at...@opensource.altera.com> Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- Changes: v1: - Removed superf

Re: [PATCH v13 4/6] fpga: add fpga bridge framework

Hi Alan, while trying to implement something that works for Zynq along these lines I stumbled upon some minor stuff. On Tue, Nov 3, 2015 at 9:11 AM, wrote: > + * Return: 0 on success, negative error code otherwise. > + */ > +int fpga_bridge_register(struct device *dev, const char *name, > +

Re: [PATCH v13 4/6] fpga: add fpga bridge framework

Hi Alan, while trying to implement something that works for Zynq along these lines I stumbled upon some minor stuff. On Tue, Nov 3, 2015 at 9:11 AM, wrote: > + * Return: 0 on success, negative error code otherwise. > + */ > +int fpga_bridge_register(struct device

Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.

Michal, On Tue, Nov 17, 2015 at 9:53 AM, Michal Simek wrote: >> +#ifdef CONFIG_PM > > remove this Will do. > >> +static int zynq_fpga_runtime_suspend(struct device *dev) > > add __maybe_unused here Will do. >> +static int zynq_fpga_runtime_resume(struct device *dev) > > and here Will do.

[PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.

Replaced constant clock_{enable,disable} calls with pm_runtime hooks. Signed-off-by: Moritz Fischer --- drivers/fpga/zynq-fpga.c | 79 +--- 1 file changed, 62 insertions(+), 17 deletions(-) diff --git a/drivers/fpga/zynq-fpga.c b/drivers/fpga/zynq

[PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.

Replaced constant clock_{enable,disable} calls with pm_runtime hooks. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- drivers/fpga/zynq-fpga.c | 79 +--- 1 file changed, 62 insertions(+), 17 deletions(-) diff --git a/drivers/fpg

Re: [PATCH] fpga: zynq-fpga: Avoid hammering clk_{enable/disable}.

Michal, On Tue, Nov 17, 2015 at 9:53 AM, Michal Simek wrote: >> +#ifdef CONFIG_PM > > remove this Will do. > >> +static int zynq_fpga_runtime_suspend(struct device *dev) > > add __maybe_unused here Will do. >> +static int zynq_fpga_runtime_resume(struct device *dev)

[PATCH] MAINTAINERS: Add myself as reviewer for FPGA Manager Framework.

Nominate myself as Reviewer. Signed-off-by: Moritz Fischer --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7af7f4a..5c7ecf1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4381,6 +4381,7 @@ K:fmc_d.*register FPGA MANAGER FRAMEWORK M

Re: [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

FPGA" >> + depends on HAS_DMA >> help >> FPGA manager driver support for Xilinx Zynq FPGAs. >> >> -- >> 1.9.1 >> >> Good catch! Reviewed-by: Moritz Fischer Alan, if you don't mind I'll send you (or gregkh?) a patch

Re: [PATCH] fpga: FPGA_MGR_ZYNQ_FPGA should depend on HAS_DMA

FPGA_MGR_ZYNQ_FPGA >> tristate "Xilinx Zynq FPGA" >> + depends on HAS_DMA >> help >> FPGA manager driver support for Xilinx Zynq FPGAs. >> >> -- >> 1.9.1 >> >> Good catch! Reviewed-by: Moritz Fischer <moritz.fi

[PATCH] MAINTAINERS: Add myself as reviewer for FPGA Manager Framework.

Nominate myself as Reviewer. Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 7af7f4a..5c7ecf1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4381,6 +4381,7 @@ K:fmc_d.*re

Re: [RFC 2/3] pinctrl: e3xx: Adding support for NI Ettus Research USRP E3xx pinconf

Linus, Thanks for your review! On Mon, Nov 9, 2015 at 2:21 AM, Linus Walleij wrote: > On Fri, Nov 6, 2015 at 12:41 AM, Moritz Fischer > wrote: > >> The USRP E3XX series requires pinctrl to configure the idle state >> FPGA image for minimizing power consumption. >

[PATCH] ARM: dt: zynq: Add labels to cpu nodes to allow overriding OPPs.

By adding labels to the cpu nodes in the dtsi, a dts that includes it can change the OPPs by referencing the cpu0 through the label. Signed-off-by: Moritz Fischer --- arch/arm/boot/dts/zynq-7000.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/zynq

<    7   8   9   10   11   12   13   14   15   16   >